]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/result.c
Fixup bdb_entry_release now that entry_decode uses two memory blocks
[openldap] / servers / slapd / result.c
index b32a2f3d1bd80b20b30a43bb62412a93e2a1664b..c71972fe50a3e83212e0594eee245a580033a1e9 100644 (file)
@@ -25,22 +25,24 @@ static char *v2ref( struct berval **ref, const char *text )
        char *v2;
 
        if(ref == NULL) {
-           if (text)
-               return ch_strdup(text);
-           else
-               return NULL;
+               if (text) {
+                       return ch_strdup(text);
+               } else {
+                       return NULL;
+               }
        }
        
-       if (text) {
+       if ( text != NULL ) {
                len = strlen( text );
                if (text[len-1] != '\n') {
                    i = 1;
                }
        }
+
        v2 = ch_malloc( len+i+sizeof("Referral:") );
-       if (text) {
+       if( text != NULL ) {
                strcpy(v2, text);
-               if (i) {
+               if( i ) {
                        v2[len++] = '\n';
                }
        }
@@ -87,91 +89,10 @@ static ber_tag_t req2res( ber_tag_t tag )
                break;
 
        default:
-               assert( 0 );
-               tag = LBER_ERROR;
-       }
-       return tag;
-}
-
-static void trim_refs_urls(
-       struct berval **refs )
-{
-       unsigned i;
-
-       if( refs == NULL ) return;
-
-       for( i=0; refs[i] != NULL; i++ ) {
-               if(     refs[i]->bv_len > sizeof("ldap://")-1 &&
-                       strncasecmp( refs[i]->bv_val, "ldap://",
-                               sizeof("ldap://")-1 ) == 0 )
-               {
-                       unsigned j;
-                       for( j=sizeof("ldap://")-1; j<refs[i]->bv_len ; j++ ) {
-                               if( refs[i]->bv_val[j] == '/' ) {
-                                       refs[i]->bv_val[j] = '\0';
-                                       refs[i]->bv_len = j;
-                                       break;
-                               }
-                       }
-               }
-       }
-}
-
-struct berval **get_entry_referrals(
-       Backend *be,
-       Connection *conn,
-       Operation *op,
-       Entry *e )
-{
-       Attribute *attr;
-       struct berval **refs;
-       unsigned i, j;
-
-       AttributeDescription *ad_ref = slap_schema.si_ad_ref;
-
-       attr = attr_find( e->e_attrs, ad_ref );
-
-       if( attr == NULL ) return NULL;
-
-       for( i=0; attr->a_vals[i] != NULL; i++ ) {
-               /* count references */
-       }
-
-       if( i < 1 ) return NULL;
-
-       refs = ch_malloc( (i + 1) * sizeof(struct berval *));
-
-       for( i=0, j=0; attr->a_vals[i] != NULL; i++ ) {
-               unsigned k;
-               struct berval *ref = ber_bvdup( attr->a_vals[i] );
-
-               /* trim the label */
-               for( k=0; k<ref->bv_len; k++ ) {
-                       if( isspace(ref->bv_val[k]) ) {
-                               ref->bv_val[k] = '\0';
-                               ref->bv_len = k;
-                               break;
-                       }
-               }
-
-               if(     ref->bv_len > 0 ) {
-                       refs[j++] = ref;
-
-               } else {
-                       ber_bvfree( ref );
-               }
-       }
-
-       refs[j] = NULL;
-
-       if( j == 0 ) {
-               ber_bvecfree( refs );
-               refs = NULL;
+               tag = LBER_SEQUENCE;
        }
 
-       /* we should check that a referral value exists... */
-
-       return refs;
+       return tag;
 }
 
 static long send_ldap_ber(
@@ -212,8 +133,15 @@ static long send_ldap_ber(
                 * it's a hard error and return.
                 */
 
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_ldap_ber: conn %d  ber_flush failed err=%d (%s)\n",
+                          conn ? conn->c_connid : 0, err, sock_errstr(err) ));
+#else
                Debug( LDAP_DEBUG_CONNS, "ber_flush failed errno=%d reason=\"%s\"\n",
                    err, sock_errstr(err), 0 );
+#endif
+
 
                if ( err != EWOULDBLOCK && err != EAGAIN ) {
                        connection_closing( conn );
@@ -263,23 +191,71 @@ send_ldap_response(
 
        ber = ber_alloc_t( LBER_USE_DER );
 
-       Debug( LDAP_DEBUG_TRACE, "send_ldap_response: msgid=%ld tag=%ld err=%ld\n",
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_ldap_response: conn %d  msgid=%ld tag=%ld err=%ld\n",
+                  conn ? conn->c_connid : 0, (long)msgid, (long)tag, (long)err ));
+#else
+       Debug( LDAP_DEBUG_TRACE,
+               "send_ldap_response: msgid=%ld tag=%ld err=%ld\n",
                (long) msgid, (long) tag, (long) err );
+#endif
+
+
        if( ref ) {
-               Debug( LDAP_DEBUG_ARGS, "send_ldap_response: ref=%s\n",
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ARGS,
+                          "send_ldap_response: conn %d  ref=\"%s\"\n",
+                          conn ? conn->c_connid : 0,
+                          ref[0] && ref[0]->bv_val ? ref[0]->bv_val : "NULL" ));
+#else
+               Debug( LDAP_DEBUG_ARGS, "send_ldap_response: ref=\"%s\"\n",
                        ref[0] && ref[0]->bv_val ? ref[0]->bv_val : "NULL",
                        NULL, NULL );
+#endif
+
        }
 
        if ( ber == NULL ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_ldap_response: conn %d  ber_alloc failed\n",
+                          conn ? conn->c_connid : 0 ));
+#else
                Debug( LDAP_DEBUG_ANY, "ber_alloc failed\n", 0, 0, 0 );
+#endif
+
                return;
        }
 
-       rc = ber_printf( ber, "{it{ess",
+#ifdef LDAP_CONNECTIONLESS
+       if (conn->c_is_udp) {
+           rc = ber_write(ber, (char *)&op->o_peeraddr, sizeof(struct sockaddr), 0);
+           if (rc != sizeof(struct sockaddr)) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_ldap_response: conn %d  ber_write failed\n",
+                          conn ? conn->c_connid : 0 ));
+#else
+               Debug( LDAP_DEBUG_ANY, "ber_write failed\n", 0, 0, 0 );
+#endif
+               ber_free(ber, 1);
+               return;
+           }
+       }
+       if (conn->c_is_udp && op->o_protocol == LDAP_VERSION2) {
+           rc = ber_printf( ber, "{is{t{ess",
+               msgid, "", tag, err,
+               matched == NULL ? "" : matched,
+               text == NULL ? "" : text );
+       } else
+#endif
+       {
+           rc = ber_printf( ber, "{it{ess",
                msgid, tag, err,
                matched == NULL ? "" : matched,
                text == NULL ? "" : text );
+       }
 
        if( rc != -1 ) {
                if ( ref != NULL ) {
@@ -309,9 +285,21 @@ send_ldap_response(
        if( rc != -1 ) {
                rc = ber_printf( ber, "N}N}" );
        }
+#ifdef LDAP_CONNECTIONLESS
+       if( conn->c_is_udp && op->o_protocol == LDAP_VERSION2 && rc != -1 ) {
+               rc = ber_printf( ber, "N}" );
+       }
+#endif
 
        if ( rc == -1 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_ldap_response: conn %d  ber_printf failed\n",
+                          conn ? conn->c_connid : 0 ));
+#else
                Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                ber_free( ber, 1 );
                return;
        }
@@ -321,9 +309,16 @@ send_ldap_response(
        ber_free( ber, 1 );
 
        if ( bytes < 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_ldap_response: conn %d ber write failed\n",
+                          conn ? conn->c_connid : 0 ));
+#else
                Debug( LDAP_DEBUG_ANY,
                        "send_ldap_response: ber write failed\n",
                        0, 0, 0 );
+#endif
+
                return;
        }
 
@@ -354,9 +349,16 @@ send_ldap_disconnect(
 
        assert( LDAP_UNSOLICITED_ERROR( err ) );
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_ldap_disconnect: conn %d  %d:%s\n",
+                  conn ? conn->c_connid : 0, err, text ? text : "" ));
+#else
        Debug( LDAP_DEBUG_TRACE,
                "send_ldap_disconnect %d:%s\n",
                err, text ? text : "", NULL );
+#endif
+
 
        if ( op->o_protocol < LDAP_VERSION3 ) {
                reqoid = NULL;
@@ -374,9 +376,9 @@ send_ldap_disconnect(
                reqoid, NULL, NULL, NULL );
 
        Statslog( LDAP_DEBUG_STATS,
-           "conn=%ld op=%ld DISCONNECT err=%ld tag=%lu text=%s\n",
+           "conn=%ld op=%ld DISCONNECT tag=%lu err=%ld text=%s\n",
                (long) op->o_connid, (long) op->o_opid,
-               (long) tag, (long) err, text ? text : "" );
+               (unsigned long) tag, (long) err, text ? text : "" );
 }
 
 void
@@ -396,23 +398,42 @@ send_ldap_result(
 
        assert( !LDAP_API_ERROR( err ) );
 
-       Debug( LDAP_DEBUG_TRACE, "send_ldap_result: conn=%ld op=%ld p=%d\n",
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_ldap_result : conn %ld   op=%ld p=%d\n",
+                  (long)op->o_connid, (long)op->o_opid, op->o_protocol ));
+#else
+       Debug( LDAP_DEBUG_TRACE,
+               "send_ldap_result: conn=%ld op=%ld p=%d\n",
                (long) op->o_connid, (long) op->o_opid, op->o_protocol );
-       Debug( LDAP_DEBUG_ARGS, "send_ldap_result: %d:%s:%s\n",
-               err, matched ?  matched : "", text ? text : "" );
+#endif
+
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ARGS,
+                  "send_ldap_result: conn=%ld err=%d matched=\"%s\" text=\"%s\"\n",
+                  (long)op->o_connid, err, matched ? matched : "", text ? text : "" ));
+#else
+       Debug( LDAP_DEBUG_ARGS,
+               "send_ldap_result: err=%d matched=\"%s\" text=\"%s\"\n",
+               err, matched ?  matched : "", text ? text : "" );
+#endif
+
 
        if( ref ) {
-               Debug( LDAP_DEBUG_ARGS, "send_ldap_result: referral: %s\n",
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ARGS,
+                       "send_ldap_result: referral=\"%s\"\n",
+                       ref[0] && ref[0]->bv_val ? ref[0]->bv_val : "NULL" ));
+#else
+               Debug( LDAP_DEBUG_ARGS,
+                       "send_ldap_result: referral=\"%s\"\n",
                        ref[0] && ref[0]->bv_val ? ref[0]->bv_val : "NULL",
                        NULL, NULL );
+#endif
        }
 
        assert( err != LDAP_PARTIAL_RESULTS );
 
-       if( op->o_tag != LDAP_REQ_SEARCH ) {
-               trim_refs_urls( ref );
-       }
-
        if ( err == LDAP_REFERRAL ) {
                if( ref == NULL ) {
                        err = LDAP_NO_SUCH_OBJECT;
@@ -437,7 +458,7 @@ send_ldap_result(
        Statslog( LDAP_DEBUG_STATS,
            "conn=%ld op=%ld RESULT tag=%lu err=%ld text=%s\n",
                (long) op->o_connid, (long) op->o_opid,
-               (long) tag, (long) err, text ? text : "" );
+               (unsigned long) tag, (long) err, text ? text : "" );
 
        if( tmp != NULL ) {
                ch_free(tmp);
@@ -459,15 +480,22 @@ send_ldap_sasl(
        ber_tag_t tag;
        ber_int_t msgid;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_ldap_sasl: conn %d err=%ld len=%ld\n",
+                  op->o_connid, (long)err, cred ? cred->bv_len : -1 ));
+#else
        Debug( LDAP_DEBUG_TRACE, "send_ldap_sasl: err=%ld len=%ld\n",
                (long) err, cred ? cred->bv_len : -1, NULL );
+#endif
+
 
        tag = req2res( op->o_tag );
        msgid = (tag != LBER_SEQUENCE) ? op->o_msgid : 0;
 
        send_ldap_response( conn, op, tag, msgid,
                err, matched, text, ref,
-               NULL, NULL, cred, ctrls  );
+               NULL, NULL, cred, ctrls  );
 }
 
 void
@@ -486,11 +514,19 @@ send_ldap_extended(
        ber_tag_t tag;
        ber_int_t msgid;
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_ldap_extended: conn %d  err=%ld oid=%s len=%ld\n",
+                  op->o_connid, (long)err, rspoid ? rspoid : "",
+                  rspdata != NULL ? (long)rspdata->bv_len : (long)0 ));
+#else
        Debug( LDAP_DEBUG_TRACE,
-               "send_ldap_extended %ld:%s (%ld)\n",
+               "send_ldap_extended err=%ld oid=%s len=%ld\n",
                (long) err,
                rspoid ? rspoid : "",
                rspdata != NULL ? (long) rspdata->bv_len : (long) 0 );
+#endif
+
 
        tag = req2res( op->o_tag );
        msgid = (tag != LBER_SEQUENCE) ? op->o_msgid : 0;
@@ -518,12 +554,19 @@ send_search_result(
        char *tmp = NULL;
        assert( !LDAP_API_ERROR( err ) );
 
-       Debug( LDAP_DEBUG_TRACE, "send_ldap_search_result %d:%s:%s\n",
-               err, matched ?  matched : "", text ? text : "" );
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_search_result: conn %d err=%d matched=\"%s\"\n",
+                  op->o_connid, err, matched ? matched : "",
+                  text ? text : "" ));
+#else
+       Debug( LDAP_DEBUG_TRACE,
+               "send_search_result: err=%d matched=\"%s\" text=\"%s\"\n",
+               err, matched ?  matched : "", text ? text : "" );
+#endif
 
-       assert( err != LDAP_PARTIAL_RESULTS );
 
-       trim_refs_urls( refs );
+       assert( err != LDAP_PARTIAL_RESULTS );
 
        if( op->o_protocol < LDAP_VERSION3 ) {
                /* send references in search results */
@@ -555,7 +598,7 @@ send_search_result(
        Statslog( LDAP_DEBUG_STATS,
            "conn=%ld op=%ld SEARCH RESULT tag=%lu err=%ld text=%s\n",
                (long) op->o_connid, (long) op->o_opid,
-               (long) tag, (long) err, text ? text : "" );
+               (unsigned long) tag, (long) err, text ? text : "" );
 
        if (tmp != NULL) {
            ch_free(tmp);
@@ -577,19 +620,37 @@ send_search_entry(
        BerElement      *ber;
        Attribute       *a, *aa;
        int             i, rc=-1, bytes;
-       char            *edn;
+       char            *edn;
        int             userattrs;
        int             opattrs;
 
        AttributeDescription *ad_entry = slap_schema.si_ad_entry;
 
-       Debug( LDAP_DEBUG_TRACE, "=> send_search_entry: \"%s\"\n", e->e_dn, 0, 0 );
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_search_entry: conn %d  dn=\"%s\"%s\n",
+                  op->o_connid, e->e_dn,
+                  attrsonly ? " (attrsOnly)" : "" ));
+#else
+       Debug( LDAP_DEBUG_TRACE,
+               "=> send_search_entry: dn=\"%s\"%s\n",
+               e->e_dn, attrsonly ? " (attrsOnly)" : "", 0 );
+#endif
+
 
        if ( ! access_allowed( be, conn, op, e,
                ad_entry, NULL, ACL_READ ) )
        {
-               Debug( LDAP_DEBUG_ACL, "acl: access to entry not allowed\n",
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "acl", LDAP_LEVEL_INFO,
+                          "send_search_entry: conn %d access to entry (%s) not allowed\n",
+                          op->o_connid, e->e_dn ));
+#else
+               Debug( LDAP_DEBUG_ACL,
+                       "send_search_entry: access to entry not allowed\n",
                    0, 0, 0 );
+#endif
+
                return( 1 );
        }
 
@@ -598,17 +659,53 @@ send_search_entry(
        ber = ber_alloc_t( LBER_USE_DER );
 
        if ( ber == NULL ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_search_entry: conn %d  ber_alloc failed\n",
+                          op->o_connid ));
+#else
                Debug( LDAP_DEBUG_ANY, "ber_alloc failed\n", 0, 0, 0 );
+#endif
+
                send_ldap_result( conn, op, LDAP_OTHER,
                        NULL, "BER allocation error", NULL, NULL );
                goto error_return;
        }
 
-       rc = ber_printf( ber, "{it{s{" /*}}}*/, op->o_msgid,
+#ifdef LDAP_CONNECTIONLESS
+       if (conn->c_is_udp) {
+           rc = ber_write(ber, (char *)&op->o_peeraddr, sizeof(struct sockaddr), 0);
+           if (rc != sizeof(struct sockaddr)) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_search_entry: conn %d  ber_printf failed\n",
+                          conn ? conn->c_connid : 0 ));
+#else
+               Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+               ber_free(ber, 1);
+               return;
+           }
+       }
+       if (conn->c_is_udp && op->o_protocol == LDAP_VERSION2) {
+           rc = ber_printf( ber, "{is{t{s{",
+               op->o_msgid, "", LDAP_RES_SEARCH_ENTRY, e->e_dn );
+       } else
+#endif
+       {
+           rc = ber_printf( ber, "{it{s{" /*}}}*/, op->o_msgid,
                LDAP_RES_SEARCH_ENTRY, e->e_dn );
+       }
 
        if ( rc == -1 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_search_entry: conn %d  ber_printf failed\n",
+                          op->o_connid ));
+#else
                Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                ber_free( ber, 1 );
                send_ldap_result( conn, op, LDAP_OTHER,
                    NULL, "encoding DN error", NULL, NULL );
@@ -625,7 +722,7 @@ send_search_entry(
 
        for ( a = e->e_attrs; a != NULL; a = a->a_next ) {
                AttributeDescription *desc = a->a_desc;
-               char *type = desc->ad_cname->bv_val;
+               char *type = desc->ad_cname.bv_val;
 
                if ( attrs == NULL ) {
                        /* all addrs request, skip operational attributes */
@@ -648,13 +745,27 @@ send_search_entry(
                }
 
                if ( ! access_allowed( be, conn, op, e, desc, NULL, ACL_READ ) ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "acl", LDAP_LEVEL_INFO,
+                                  "send_search_entry: conn %d  access to attribute %s not allowed\n",
+                                  op->o_connid, desc->ad_cname.bv_val ));
+#else
                        Debug( LDAP_DEBUG_ACL, "acl: access to attribute %s not allowed\n",
-                           desc->ad_cname->bv_val, 0, 0 );
+                           desc->ad_cname.bv_val, 0, 0 );
+#endif
+
                        continue;
                }
 
                if (( rc = ber_printf( ber, "{s[" /*]}*/ , type )) == -1 ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                  "send_search_entry: conn %d  ber_printf failed\n",
+                                  op->o_connid ));
+#else
                        Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                        ber_free( ber, 1 );
                        send_ldap_result( conn, op, LDAP_OTHER,
                            NULL, "encoding description error", NULL, NULL );
@@ -666,15 +777,29 @@ send_search_entry(
                                if ( ! access_allowed( be, conn, op, e,
                                        desc, a->a_vals[i], ACL_READ ) )
                                {
+#ifdef NEW_LOGGING
+                                       LDAP_LOG(( "acl", LDAP_LEVEL_INFO,
+                                                  "send_search_entry: conn %d  access to attribute %s, value %d not allowed\n",
+                                                  op->o_connid, desc->ad_cname.bv_val, i ));
+#else
                                        Debug( LDAP_DEBUG_ACL,
                                                "acl: access to attribute %s, value %d not allowed\n",
-                                       desc->ad_cname->bv_val, i, 0 );
+                                       desc->ad_cname.bv_val, i, 0 );
+#endif
+
                                        continue;
                                }
 
                                if (( rc = ber_printf( ber, "O", a->a_vals[i] )) == -1 ) {
+#ifdef NEW_LOGGING
+                                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                                  "send_search_entry: conn %d  ber_printf failed.\n",
+                                                  op->o_connid ));
+#else
                                        Debug( LDAP_DEBUG_ANY,
                                            "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                                        ber_free( ber, 1 );
                                        send_ldap_result( conn, op, LDAP_OTHER,
                                                NULL, "encoding values error", NULL, NULL );
@@ -684,7 +809,14 @@ send_search_entry(
                }
 
                if (( rc = ber_printf( ber, /*{[*/ "]N}" )) == -1 ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                  "send_search_entry: conn %d  ber_printf failed\n",
+                                  op->o_connid ));
+#else
                        Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                        ber_free( ber, 1 );
                        send_ldap_result( conn, op, LDAP_OTHER,
                            NULL, "encode end error", NULL, NULL );
@@ -694,7 +826,7 @@ send_search_entry(
 
        /* eventually will loop through generated operational attributes */
        /* only have subschemaSubentry implemented */
-       aa = backend_operational( be, e );
+       aa = backend_operational( be, conn, op, e );
        
        for (a = aa ; a != NULL; a = a->a_next ) {
                AttributeDescription *desc = a->a_desc;
@@ -720,17 +852,32 @@ send_search_entry(
                }
 
                if ( ! access_allowed( be, conn, op, e, desc, NULL, ACL_READ ) ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "acl", LDAP_LEVEL_INFO,
+                                  "send_search_entry: conn %s  access to attribute %s not allowed\n",
+                                  op->o_connid, desc->ad_cname.bv_val ));
+#else
                        Debug( LDAP_DEBUG_ACL, "acl: access to attribute %s not allowed\n",
-                           desc->ad_cname->bv_val, 0, 0 );
+                           desc->ad_cname.bv_val, 0, 0 );
+#endif
+
                        continue;
                }
 
-               rc = ber_printf( ber, "{s[" /*]}*/ , desc->ad_cname->bv_val );
+               rc = ber_printf( ber, "{s[" /*]}*/ , desc->ad_cname.bv_val );
                if ( rc == -1 ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                  "send_search_entry: conn %d  ber_printf failed\n",
+                                  op->o_connid ));
+#else
                        Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                        ber_free( ber, 1 );
                        send_ldap_result( conn, op, LDAP_OTHER,
                            NULL, "encoding description error", NULL, NULL );
+                       attrs_free( aa );
                        goto error_return;
                }
 
@@ -739,29 +886,52 @@ send_search_entry(
                                if ( ! access_allowed( be, conn, op, e,
                                        desc, a->a_vals[i], ACL_READ ) )
                                {
+#ifdef NEW_LOGGING
+                                       LDAP_LOG(( "acl", LDAP_LEVEL_INFO,
+                                                  "send_search_entry: conn %d access to %s, value %d not allowed\n",
+                                                  op->o_connid, desc->ad_cname.bv_val, i ));
+#else
                                        Debug( LDAP_DEBUG_ACL,
                                                "acl: access to attribute %s, value %d not allowed\n",
-                                       desc->ad_cname->bv_val, i, 0 );
+                                       desc->ad_cname.bv_val, i, 0 );
+#endif
+
                                        continue;
                                }
 
 
                                if (( rc = ber_printf( ber, "O", a->a_vals[i] )) == -1 ) {
+#ifdef NEW_LOGGING
+                                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                                  "send_search_entry: conn %d  ber_printf failed\n",
+                                                  op->o_connid ));
+#else
                                        Debug( LDAP_DEBUG_ANY,
                                            "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                                        ber_free( ber, 1 );
                                        send_ldap_result( conn, op, LDAP_OTHER,
                                                NULL, "encoding values error", NULL, NULL );
+                                       attrs_free( aa );
                                        goto error_return;
                                }
                        }
                }
 
                if (( rc = ber_printf( ber, /*{[*/ "]N}" )) == -1 ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                                  "send_search_entry: conn %d  ber_printf failed\n",
+                                  op->o_connid ));
+#else
                        Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                        ber_free( ber, 1 );
                        send_ldap_result( conn, op, LDAP_OTHER,
                            NULL, "encode end error", NULL, NULL );
+                       attrs_free( aa );
                        goto error_return;
                }
        }
@@ -770,8 +940,19 @@ send_search_entry(
 
        rc = ber_printf( ber, /*{{{*/ "}N}N}" );
 
+#ifdef LDAP_CONNECTIONLESS
+       if (conn->c_is_udp && op->o_protocol == LDAP_VERSION2 && rc != -1)
+               rc = ber_printf( ber, "}" );
+#endif
        if ( rc == -1 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_search_entry: conn %d ber_printf failed\n",
+                          op->o_connid ));
+#else
                Debug( LDAP_DEBUG_ANY, "ber_printf failed\n", 0, 0, 0 );
+#endif
+
                ber_free( ber, 1 );
                send_ldap_result( conn, op, LDAP_OTHER,
                        NULL, "encode entry end error", NULL, NULL );
@@ -782,9 +963,16 @@ send_search_entry(
        ber_free( ber, 1 );
 
        if ( bytes < 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                          "send_ldap_response: conn %d  ber write failed.\n",
+                          op->o_connid ));
+#else
                Debug( LDAP_DEBUG_ANY,
                        "send_ldap_response: ber write failed\n",
                        0, 0, 0 );
+#endif
+
                return -1;
        }
 
@@ -797,7 +985,14 @@ send_search_entry(
        Statslog( LDAP_DEBUG_STATS2, "conn=%ld op=%ld ENTRY dn=\"%s\"\n",
            (long) conn->c_connid, (long) op->o_opid, e->e_dn, 0, 0 );
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+                  "send_search_entry: conn %d exit.\n",
+                  op->o_connid ));
+#else
        Debug( LDAP_DEBUG_TRACE, "<= send_search_entry\n", 0, 0, 0 );
+#endif
+
 
        rc = 0;
 
@@ -812,7 +1007,6 @@ send_search_reference(
     Operation  *op,
     Entry      *e,
        struct berval **refs,
-       int scope,
        LDAPControl **ctrls,
     struct berval ***v2refs
 )
@@ -824,30 +1018,60 @@ send_search_reference(
        AttributeDescription *ad_ref = slap_schema.si_ad_ref;
        AttributeDescription *ad_entry = slap_schema.si_ad_entry;
 
-       Debug( LDAP_DEBUG_TRACE, "=> send_search_reference (%s)\n", e->e_dn, 0, 0 );
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+               "send_search_reference: conn %d  dn=\"%s\"\n",
+               op->o_connid, e->e_dn ));
+#else
+       Debug( LDAP_DEBUG_TRACE,
+               "=> send_search_reference: dn=\"%s\"\n",
+               e->e_dn, 0, 0 );
+#endif
+
 
        if ( ! access_allowed( be, conn, op, e,
                ad_entry, NULL, ACL_READ ) )
        {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "acl", LDAP_LEVEL_INFO,
+                       "send_search_reference: conn %d access to entry %s not allowed\n",
+                       op->o_connid, e->e_dn ));
+#else
                Debug( LDAP_DEBUG_ACL,
                        "send_search_reference: access to entry not allowed\n",
                    0, 0, 0 );
+#endif
+
                return( 1 );
        }
 
        if ( ! access_allowed( be, conn, op, e,
                ad_ref, NULL, ACL_READ ) )
        {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "acl", LDAP_LEVEL_INFO,
+                       "send_search_reference: conn %d access to reference not allowed.\n",
+                       op->o_connid ));
+#else
                Debug( LDAP_DEBUG_ACL,
                        "send_search_reference: access to reference not allowed\n",
                    0, 0, 0 );
+#endif
+
                return( 1 );
        }
 
        if( refs == NULL ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                       "send_search_reference: null ref in (%s).\n",
+                       op->o_connid, e->e_dn ));
+#else
                Debug( LDAP_DEBUG_ANY,
                        "send_search_reference: null ref in (%s)\n", 
                        e->e_dn, 0, 0 );
+#endif
+
                return( 1 );
        }
 
@@ -862,8 +1086,15 @@ send_search_reference(
        ber = ber_alloc_t( LBER_USE_DER );
 
        if ( ber == NULL ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                       "send_search_reference: conn %d ber_alloc failed\n",
+                       op->o_connid ));
+#else
                Debug( LDAP_DEBUG_ANY,
                        "send_search_reference: ber_alloc failed\n", 0, 0, 0 );
+#endif
+
                send_ldap_result( conn, op, LDAP_OTHER,
                        NULL, "alloc BER error", NULL, NULL );
                return -1;
@@ -873,8 +1104,15 @@ send_search_reference(
                LDAP_RES_SEARCH_REFERENCE, refs );
 
        if ( rc == -1 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_ERR,
+                       "send_search_reference: conn %d ber_printf failed.\n",
+                       op->o_connid ));
+#else
                Debug( LDAP_DEBUG_ANY,
                        "send_search_reference: ber_printf failed\n", 0, 0, 0 );
+#endif
+
                ber_free( ber, 1 );
                send_ldap_result( conn, op, LDAP_OTHER,
                        NULL, "encode DN error", NULL, NULL );
@@ -890,10 +1128,15 @@ send_search_reference(
        num_pdu_sent++;
        ldap_pvt_thread_mutex_unlock( &num_sent_mutex );
 
-       Statslog( LDAP_DEBUG_STATS2, "conn=%ld op=%ld ENTRY dn=\"%s\"\n",
-           (long) conn->c_connid, (long) op->o_opid, e->e_dn, 0, 0 );
+       Statslog( LDAP_DEBUG_STATS2, "conn=%ld op=%ld REF dn=\"%s\"\n",
+               (long) conn->c_connid, (long) op->o_opid, e->e_dn, 0, 0 );
 
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "operation", LDAP_LEVEL_ENTRY,
+               "send_search_reference: conn %d exit.\n", op->o_connid ));
+#else
        Debug( LDAP_DEBUG_TRACE, "<= send_search_reference\n", 0, 0, 0 );
+#endif
 
        return 0;
 }
@@ -915,8 +1158,14 @@ str2result(
        *info = NULL;
 
        if ( strncasecmp( s, "RESULT", 6 ) != 0 ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                          "str2result: (%s), expecting \"RESULT\"\n", s ));
+#else
                Debug( LDAP_DEBUG_ANY, "str2result (%s) expecting \"RESULT\"\n",
                    s, 0, 0 );
+#endif
+
 
                return( -1 );
        }
@@ -944,8 +1193,14 @@ str2result(
                                *info = c;
                        }
                } else {
+#ifdef NEW_LOGGING
+                       LDAP_LOG(( "operation", LDAP_LEVEL_INFO,
+                                  "str2result: (%s) unknown.\n", s ));
+#else
                        Debug( LDAP_DEBUG_ANY, "str2result (%s) unknown\n",
                            s, 0, 0 );
+#endif
+
                        rc = -1;
                }
        }