make sure NULL pointers are not dereferenced

[openldap] / servers / slapd / root_dse.c

diff --git a/servers/slapd/root_dse.c b/servers/slapd/root_dse.c
index a166feea9c737049bbf781417d26e94b7ce9a971..356cbc78a68182b7c59ac41ae7c6bc2bcf4ca2fd 100644 (file)
--- a/servers/slapd/root_dse.c
+++ b/servers/slapd/root_dse.c
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1999-2005 The OpenLDAP Foundation.
+ * Copyright 1999-2006 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -44,6 +44,70 @@ static struct berval *supportedFeatures;
 
 static Entry   *usr_attr = NULL;
 
+/*
+ * allow modules to register functions that muck with the root DSE entry
+ */
+
+typedef struct entry_info_t {
+       SLAP_ENTRY_INFO_FN      func;
+       void                    *arg;
+       struct entry_info_t     *next;
+} entry_info_t;
+
+static entry_info_t *extra_info;
+
+int
+entry_info_register( SLAP_ENTRY_INFO_FN func, void *arg )
+{
+       entry_info_t    *ei = ch_calloc( 1, sizeof( entry_info_t ) );
+
+       ei->func = func;
+       ei->arg = arg;
+
+       ei->next = extra_info;
+       extra_info = ei;
+
+       return 0;
+}
+
+int
+entry_info_unregister( SLAP_ENTRY_INFO_FN func, void *arg )
+{
+       entry_info_t    **eip;
+
+       for ( eip = &extra_info; *eip != NULL; eip = &(*eip)->next ) {
+               if ( (*eip)->func == func && (*eip)->arg == arg ) {
+                       entry_info_t    *ei = *eip;
+
+                       *eip = ei->next;
+
+                       ch_free( ei );
+
+                       return 0;
+               }
+       }
+
+       return -1;
+}
+
+void
+entry_info_destroy( void )
+{
+       entry_info_t    **eip;
+
+       for ( eip = &extra_info; *eip != NULL;  ) {
+               entry_info_t    *ei = *eip;
+
+               eip = &(*eip)->next;
+
+               ch_free( ei );
+       }
+}
+
+/*
+ * Allow modules to register supported features
+ */
+
 static int
 supported_feature_init( void )
 {
@@ -150,7 +214,6 @@ root_dse_info(
                = slap_schema.si_ad_ref;
 
        e = (Entry *) SLAP_CALLOC( 1, sizeof(Entry) );
-
        if( e == NULL ) {
                Debug( LDAP_DEBUG_ANY,
                        "root_dse_info: SLAP_CALLOC failed", 0, 0, 0 );
@@ -169,6 +232,7 @@ root_dse_info(
 
        e->e_private = NULL;
 
+       /* FIXME: is this really needed? */
        BER_BVSTR( &val, "top" );
        if( attr_merge_one( e, ad_objectClass, &val, NULL ) ) {
                return LDAP_OTHER;
@@ -296,6 +360,14 @@ root_dse_info(
                }
        }
 
+       if ( extra_info ) {
+               entry_info_t    *ei = extra_info;
+
+               for ( ; ei; ei = ei->next ) {
+                       ei->func( ei->arg, e );
+               }
+       }
+
        *entry = e;
        return LDAP_SUCCESS;
 }
@@ -405,7 +477,8 @@ slap_discover_feature(
                return rc;
        }
 
-       rc = ldap_set_option( ld, LDAP_OPT_PROTOCOL_VERSION, &version );
+       rc = ldap_set_option( ld, LDAP_OPT_PROTOCOL_VERSION,
+               (const void *)&version );
        if ( rc != LDAP_SUCCESS ) {
                goto done;
        }