]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/sasl.c
don't leak callbacks if stuff cannot be registered; provide a means to dispose of...
[openldap] / servers / slapd / sasl.c
index e92780132f496f81f7342652a0525b062a263328..25bde088eadcdbcc8ee94cbccd4ce4b671ac37ec 100644 (file)
@@ -1,7 +1,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2005 The OpenLDAP Foundation.
+ * Copyright 1998-2006 The OpenLDAP Foundation.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
@@ -150,10 +150,10 @@ static const char *slap_propnames[] = {
 static Filter generic_filter = { LDAP_FILTER_PRESENT, { 0 }, NULL };
 static struct berval generic_filterstr = BER_BVC("(objectclass=*)");
 
-#define        PROP_CONN       0
-#define        PROP_AUTHC      1
-#define        PROP_AUTHZ      2
-#define        PROP_COUNT      3       /* Number of properties we used */
+#define        SLAP_SASL_PROP_CONN     0
+#define        SLAP_SASL_PROP_AUTHC    1
+#define        SLAP_SASL_PROP_AUTHZ    2
+#define        SLAP_SASL_PROP_COUNT    3       /* Number of properties we used */
 
 typedef struct lookup_info {
        int flags;
@@ -173,8 +173,7 @@ sasl_ap_lookup( Operation *op, SlapReply *rs )
        Attribute *a;
        const char *text;
        int rc, i;
-       slap_callback *tmp = op->o_callback;
-       lookup_info *sl = tmp->sc_private;
+       lookup_info *sl = (lookup_info *)op->o_callback->sc_private;
 
        if (rs->sr_type != REP_SEARCH) return 0;
 
@@ -185,7 +184,7 @@ sasl_ap_lookup( Operation *op, SlapReply *rs )
                        if ( sl->flags & SASL_AUXPROP_AUTHZID ) continue;
                        /* Skip our private properties */
                        if ( !strcmp( name, slap_propnames[0] )) {
-                               i += PROP_COUNT-1;
+                               i += SLAP_SASL_PROP_COUNT - 1;
                                continue;
                        }
                        name++;
@@ -202,6 +201,14 @@ sasl_ap_lookup( Operation *op, SlapReply *rs )
                                "slap_ap_lookup: str2ad(%s): %s\n", name, text, 0 );
                        continue;
                }
+
+               /* If it's the rootdn and a rootpw was present, we already set
+                * it so don't override it here.
+                */
+               if ( ad == slap_schema.si_ad_userPassword && sl->list[i].values && 
+                       be_isroot_dn( op->o_bd, &op->o_req_ndn ))
+                       continue;
+
                a = attr_find( rs->sr_entry->e_attrs, ad );
                if ( !a ) continue;
                if ( ! access_allowed( op, rs->sr_entry, ad, NULL, ACL_AUTH, NULL ) ) {
@@ -214,9 +221,9 @@ sasl_ap_lookup( Operation *op, SlapReply *rs )
                for ( bv = a->a_vals; bv->bv_val; bv++ ) {
                        /* ITS#3846 don't give hashed passwords to SASL */
                        if ( ad == slap_schema.si_ad_userPassword &&
-                               bv->bv_val[0] == '{' ) {
-                               rc = lutil_passwd_scheme( bv->bv_val );
-                               if ( rc ) {
+                               bv->bv_val[0] == '{' /*}*/ )
+                       {
+                               if ( lutil_passwd_scheme( bv->bv_val ) ) {
                                        /* If it's not a recognized scheme, just assume it's
                                         * a cleartext password that happened to include brackets.
                                         *
@@ -226,11 +233,10 @@ sasl_ap_lookup( Operation *op, SlapReply *rs )
                                         * past the scheme name, skip this value.
                                         */
 #ifdef SLAPD_CLEARTEXT
-                                       if ( !strncasecmp( bv->bv_val, sc_cleartext.bv_val,
-                                               sc_cleartext.bv_len )) {
+                                       if ( !ber_bvstrcasecmp( bv, &sc_cleartext ) ) {
                                                struct berval cbv;
                                                cbv.bv_len = bv->bv_len - sc_cleartext.bv_len;
-                                               if ( cbv.bv_len ) {
+                                               if ( cbv.bv_len > 0 ) {
                                                        cbv.bv_val = bv->bv_val + sc_cleartext.bv_len;
                                                        sl->sparams->utils->prop_set( sl->sparams->propctx,
                                                                sl->list[i].name, cbv.bv_val, cbv.bv_len );
@@ -267,19 +273,19 @@ slap_auxprop_lookup(
        /* Find our DN and conn first */
        for( i = 0; sl.list[i].name; i++ ) {
                if ( sl.list[i].name[0] == '*' ) {
-                       if ( !strcmp( sl.list[i].name, slap_propnames[PROP_CONN] ) ) {
+                       if ( !strcmp( sl.list[i].name, slap_propnames[SLAP_SASL_PROP_CONN] ) ) {
                                if ( sl.list[i].values && sl.list[i].values[0] )
                                        AC_MEMCPY( &conn, sl.list[i].values[0], sizeof( conn ) );
                                continue;
                        }
                        if ( (flags & SASL_AUXPROP_AUTHZID) &&
-                               !strcmp( sl.list[i].name, slap_propnames[PROP_AUTHZ] ) ) {
+                               !strcmp( sl.list[i].name, slap_propnames[SLAP_SASL_PROP_AUTHZ] ) ) {
 
                                if ( sl.list[i].values && sl.list[i].values[0] )
                                        AC_MEMCPY( &op.o_req_ndn, sl.list[i].values[0], sizeof( struct berval ) );
                                break;
                        }
-                       if ( !strcmp( sl.list[i].name, slap_propnames[PROP_AUTHC] ) ) {
+                       if ( !strcmp( sl.list[i].name, slap_propnames[SLAP_SASL_PROP_AUTHC] ) ) {
                                if ( sl.list[i].values && sl.list[i].values[0] ) {
                                        AC_MEMCPY( &op.o_req_ndn, sl.list[i].values[0], sizeof( struct berval ) );
                                        if ( !(flags & SASL_AUXPROP_AUTHZID) )
@@ -297,7 +303,7 @@ slap_auxprop_lookup(
                        if ( flags & SASL_AUXPROP_AUTHZID ) continue;
                        /* Skip our private properties */
                        if ( !strcmp( name, slap_propnames[0] )) {
-                               i += PROP_COUNT-1;
+                               i += SLAP_SASL_PROP_COUNT - 1;
                                continue;
                        }
                        name++;
@@ -318,26 +324,70 @@ slap_auxprop_lookup(
 
                op.o_bd = select_backend( &op.o_req_ndn, 0, 1 );
 
-               if ( op.o_bd && op.o_bd->be_search ) {
-                       SlapReply rs = {REP_RESULT};
-                       op.o_hdr = conn->c_sasl_bindop->o_hdr;
-                       op.o_tag = LDAP_REQ_SEARCH;
-                       op.o_ndn = conn->c_ndn;
-                       op.o_callback = &cb;
-                       op.o_time = slap_get_time();
-                       op.o_do_not_cache = 1;
-                       op.o_is_auth_check = 1;
-                       op.o_req_dn = op.o_req_ndn;
-                       op.ors_scope = LDAP_SCOPE_BASE;
-                       op.ors_deref = LDAP_DEREF_NEVER;
-                       op.ors_tlimit = SLAP_NO_LIMIT;
-                       op.ors_slimit = 1;
-                       op.ors_filter = &generic_filter;
-                       op.ors_filterstr = generic_filterstr;
-                       /* FIXME: we want all attributes, right? */
-                       op.ors_attrs = NULL;
-
-                       op.o_bd->be_search( &op, &rs );
+               if ( op.o_bd ) {
+                       /* For rootdn, see if we can use the rootpw */
+                       if ( be_isroot_dn( op.o_bd, &op.o_req_ndn ) &&
+                               !BER_BVISEMPTY( &op.o_bd->be_rootpw )) {
+                               struct berval cbv = BER_BVNULL;
+
+                               /* If there's a recognized scheme, see if it's CLEARTEXT */
+                               if ( lutil_passwd_scheme( op.o_bd->be_rootpw.bv_val )) {
+                                       if ( !strncasecmp( op.o_bd->be_rootpw.bv_val,
+                                               sc_cleartext.bv_val, sc_cleartext.bv_len )) {
+
+                                               /* If it's CLEARTEXT, skip past scheme spec */
+                                               cbv.bv_len = op.o_bd->be_rootpw.bv_len -
+                                                       sc_cleartext.bv_len;
+                                               if ( cbv.bv_len ) {
+                                                       cbv.bv_val = op.o_bd->be_rootpw.bv_val +
+                                                               sc_cleartext.bv_len;
+                                               }
+                                       }
+                               /* No scheme, use the whole value */
+                               } else {
+                                       cbv = op.o_bd->be_rootpw;
+                               }
+                               if ( !BER_BVISEMPTY( &cbv )) {
+                                       for( i = 0; sl.list[i].name; i++ ) {
+                                               const char *name = sl.list[i].name;
+
+                                               if ( name[0] == '*' ) {
+                                                       if ( flags & SASL_AUXPROP_AUTHZID ) continue;
+                                                               name++;
+                                               } else if ( !(flags & SASL_AUXPROP_AUTHZID ) )
+                                                       continue;
+
+                                               if ( !strcasecmp(name,"userPassword") ) {
+                                                       sl.sparams->utils->prop_set( sl.sparams->propctx,
+                                                               sl.list[i].name, cbv.bv_val, cbv.bv_len );
+                                                       break;
+                                               }
+                                       }
+                               }
+                       }
+
+                       if ( op.o_bd->be_search ) {
+                               SlapReply rs = {REP_RESULT};
+                               op.o_hdr = conn->c_sasl_bindop->o_hdr;
+                               op.o_tag = LDAP_REQ_SEARCH;
+                               op.o_dn = conn->c_ndn;
+                               op.o_ndn = conn->c_ndn;
+                               op.o_callback = &cb;
+                               slap_op_time( &op.o_time, &op.o_tincr );
+                               op.o_do_not_cache = 1;
+                               op.o_is_auth_check = 1;
+                               op.o_req_dn = op.o_req_ndn;
+                               op.ors_scope = LDAP_SCOPE_BASE;
+                               op.ors_deref = LDAP_DEREF_NEVER;
+                               op.ors_tlimit = SLAP_NO_LIMIT;
+                               op.ors_slimit = 1;
+                               op.ors_filter = &generic_filter;
+                               op.ors_filterstr = generic_filterstr;
+                               /* FIXME: we want all attributes, right? */
+                               op.ors_attrs = NULL;
+
+                               op.o_bd->be_search( &op, &rs );
+                       }
                }
        }
 }
@@ -372,12 +422,12 @@ slap_auxprop_store(
        /* Find our DN and conn first */
        for( i = 0; pr[i].name; i++ ) {
                if ( pr[i].name[0] == '*' ) {
-                       if ( !strcmp( pr[i].name, slap_propnames[PROP_CONN] ) ) {
+                       if ( !strcmp( pr[i].name, slap_propnames[SLAP_SASL_PROP_CONN] ) ) {
                                if ( pr[i].values && pr[i].values[0] )
                                        AC_MEMCPY( &conn, pr[i].values[0], sizeof( conn ) );
                                continue;
                        }
-                       if ( !strcmp( pr[i].name, slap_propnames[PROP_AUTHC] ) ) {
+                       if ( !strcmp( pr[i].name, slap_propnames[SLAP_SASL_PROP_AUTHC] ) ) {
                                if ( pr[i].values && pr[i].values[0] ) {
                                        AC_MEMCPY( &op.o_req_ndn, pr[i].values[0], sizeof( struct berval ) );
                                }
@@ -414,29 +464,24 @@ slap_auxprop_store(
        }
        *modtail = NULL;
 
-       rc = slap_mods_check( modlist, &text, textbuf, textlen, NULL );
+       rc = slap_mods_check( &op, modlist, &text, textbuf, textlen, NULL );
 
        if ( rc == LDAP_SUCCESS ) {
                rc = slap_mods_no_user_mod_check( &op, modlist,
                        &text, textbuf, textlen );
 
                if ( rc == LDAP_SUCCESS ) {
-                       rc = slap_mods_opattrs( &op, modlist, modtail,
-                                       &text, textbuf, textlen, 1 );
-
-                       if ( rc == LDAP_SUCCESS ) {
-                               op.o_hdr = conn->c_sasl_bindop->o_hdr;
-                               op.o_tag = LDAP_REQ_MODIFY;
-                               op.o_ndn = op.o_req_ndn;
-                               op.o_callback = &cb;
-                               op.o_time = slap_get_time();
-                               op.o_do_not_cache = 1;
-                               op.o_is_auth_check = 1;
-                               op.o_req_dn = op.o_req_ndn;
-                               op.orm_modlist = modlist;
+                       op.o_hdr = conn->c_sasl_bindop->o_hdr;
+                       op.o_tag = LDAP_REQ_MODIFY;
+                       op.o_ndn = op.o_req_ndn;
+                       op.o_callback = &cb;
+                       slap_op_time( &op.o_time, &op.o_tincr );
+                       op.o_do_not_cache = 1;
+                       op.o_is_auth_check = 1;
+                       op.o_req_dn = op.o_req_ndn;
+                       op.orm_modlist = modlist;
 
-                               rc = op.o_bd->be_modify( &op, &rs );
-                       }
+                       rc = op.o_bd->be_modify( &op, &rs );
                }
        }
        slap_mods_free( modlist, 1 );
@@ -496,7 +541,7 @@ slap_sasl_canonicalize(
 {
        Connection *conn = (Connection *)context;
        struct propctx *props = sasl_auxprop_getctx( sconn );
-       struct propval auxvals[3];
+       struct propval auxvals[ SLAP_SASL_PROP_COUNT ] = { { 0 } };
        struct berval dn;
        int rc, which;
        const char *names[2];
@@ -529,13 +574,13 @@ slap_sasl_canonicalize(
                prop_request( props, slap_propnames );
 
        if ( flags & SASL_CU_AUTHID )
-               which = PROP_AUTHC;
+               which = SLAP_SASL_PROP_AUTHC;
        else
-               which = PROP_AUTHZ;
+               which = SLAP_SASL_PROP_AUTHZ;
 
        /* Need to store the Connection for auxprop_lookup */
-       if ( !auxvals[PROP_CONN].values ) {
-               names[0] = slap_propnames[PROP_CONN];
+       if ( !auxvals[SLAP_SASL_PROP_CONN].values ) {
+               names[0] = slap_propnames[SLAP_SASL_PROP_CONN];
                names[1] = NULL;
                prop_set( props, names[0], (char *)&conn, sizeof( conn ) );
        }
@@ -559,7 +604,7 @@ slap_sasl_canonicalize(
         * it does authzID before the authcID. If we see that authzID
         * has already been done, don't do anything special with authcID.
         */
-       if ( flags == SASL_CU_AUTHID && !auxvals[PROP_AUTHZ].values ) {
+       if ( flags == SASL_CU_AUTHID && !auxvals[SLAP_SASL_PROP_AUTHZ].values ) {
                conn->c_sasl_dn.bv_val = (char *) in;
        } else if ( flags == SASL_CU_AUTHZID && conn->c_sasl_dn.bv_val ) {
                rc = strcmp( in, conn->c_sasl_dn.bv_val );
@@ -608,7 +653,11 @@ slap_sasl_authorize(
        struct propctx *props)
 {
        Connection *conn = (Connection *)context;
-       struct propval auxvals[3];
+       /* actually:
+        *      (SLAP_SASL_PROP_COUNT - 1)      because we skip "conn",
+        *      + 1                             for NULL termination?
+        */
+       struct propval auxvals[ SLAP_SASL_PROP_COUNT ] = { { 0 } };
        struct berval authcDN, authzDN = BER_BVNULL;
        int rc;
 
@@ -624,7 +673,7 @@ slap_sasl_authorize(
                BER_BVZERO( &conn->c_sasl_dn );
        }
 
-       /* Skip PROP_CONN */
+       /* Skip SLAP_SASL_PROP_CONN */
        prop_getnames( props, slap_propnames+1, auxvals );
        
        /* Should not happen */
@@ -787,6 +836,18 @@ slap_sasl_err2ldap( int saslerr )
 {
        int rc;
 
+       /* map SASL errors to LDAP resultCode returned by:
+        *      sasl_server_new()
+        *              SASL_OK, SASL_NOMEM
+        *      sasl_server_step()
+        *              SASL_OK, SASL_CONTINUE, SASL_TRANS, SASL_BADPARAM, SASL_BADPROT,
+        *      ...
+        *      sasl_server_start()
+        *      + SASL_NOMECH
+        *      sasl_setprop()
+        *              SASL_OK, SASL_BADPARAM
+        */
+
        switch (saslerr) {
                case SASL_OK:
                        rc = LDAP_SUCCESS;
@@ -795,8 +856,6 @@ slap_sasl_err2ldap( int saslerr )
                        rc = LDAP_SASL_BIND_IN_PROGRESS;
                        break;
                case SASL_FAIL:
-                       rc = LDAP_OTHER;
-                       break;
                case SASL_NOMEM:
                        rc = LDAP_OTHER;
                        break;
@@ -804,6 +863,9 @@ slap_sasl_err2ldap( int saslerr )
                        rc = LDAP_AUTH_METHOD_NOT_SUPPORTED;
                        break;
                case SASL_BADAUTH:
+               case SASL_NOUSER:
+               case SASL_TRANS:
+               case SASL_EXPIRED:
                        rc = LDAP_INVALID_CREDENTIALS;
                        break;
                case SASL_NOAUTHZ:
@@ -813,6 +875,13 @@ slap_sasl_err2ldap( int saslerr )
                case SASL_ENCRYPT:
                        rc = LDAP_INAPPROPRIATE_AUTH;
                        break;
+               case SASL_UNAVAIL:
+               case SASL_TRYAGAIN:
+                       rc = LDAP_UNAVAILABLE;
+                       break;
+               case SASL_DISABLED:
+                       rc = LDAP_UNWILLING_TO_PERFORM;
+                       break;
                default:
                        rc = LDAP_OTHER;
                        break;
@@ -979,6 +1048,42 @@ int slap_sasl_destroy( void )
        return 0;
 }
 
+#if SASL_VERSION_MAJOR >= 2
+static char *
+slap_sasl_peer2ipport( struct berval *peer )
+{
+       int             isv6 = 0;
+       char            *ipport,
+                       *p = &peer->bv_val[ STRLENOF( "IP=" ) ];
+       ber_len_t       plen = peer->bv_len - STRLENOF( "IP=" );
+
+       /* IPv6? */
+       if ( p[0] == '[' ) {
+               isv6 = 1;
+               plen--;
+       }
+       ipport = ch_strdup( &p[isv6] );
+
+       /* Convert IPv6/IPv4 addresses to address;port syntax. */
+       p = strrchr( ipport, ':' );
+       if ( p != NULL ) {
+               *p = ';';
+               if ( isv6 ) {
+                       assert( p[-1] == ']' );
+                       AC_MEMCPY( &p[-1], p, plen - ( p - ipport ) + 1 );
+               }
+
+       } else if ( isv6 ) {
+               /* trim ']' */
+               plen--;
+               assert( p[plen] == ']' );
+               p[plen] = '\0';
+       }
+
+       return ipport;
+}
+#endif
+
 int slap_sasl_open( Connection *conn, int reopen )
 {
        int sc = LDAP_SUCCESS;
@@ -1040,31 +1145,17 @@ int slap_sasl_open( Connection *conn, int reopen )
        /* create new SASL context */
 #if SASL_VERSION_MAJOR >= 2
        if ( conn->c_sock_name.bv_len != 0 &&
-            strncmp( conn->c_sock_name.bv_val, "IP=", 3 ) == 0) {
-               char *p;
-
-               iplocalport = ch_strdup( conn->c_sock_name.bv_val + 3 );
-               /* Convert IPv6 addresses to address;port syntax. */
-               p = strrchr( iplocalport, ' ' );
-               /* Convert IPv4 addresses to address;port syntax. */
-               if ( p == NULL ) p = strchr( iplocalport, ':' );
-               if ( p != NULL ) {
-                       *p = ';';
-               }
+               strncmp( conn->c_sock_name.bv_val, "IP=", STRLENOF( "IP=" ) ) == 0 )
+       {
+               iplocalport = slap_sasl_peer2ipport( &conn->c_sock_name );
        }
+
        if ( conn->c_peer_name.bv_len != 0 &&
-            strncmp( conn->c_peer_name.bv_val, "IP=", 3 ) == 0) {
-               char *p;
-
-               ipremoteport = ch_strdup( conn->c_peer_name.bv_val + 3 );
-               /* Convert IPv6 addresses to address;port syntax. */
-               p = strrchr( ipremoteport, ' ' );
-               /* Convert IPv4 addresses to address;port syntax. */
-               if ( p == NULL ) p = strchr( ipremoteport, ':' );
-               if ( p != NULL ) {
-                       *p = ';';
-               }
+               strncmp( conn->c_peer_name.bv_val, "IP=", STRLENOF( "IP=" ) ) == 0 )
+       {
+               ipremoteport = slap_sasl_peer2ipport( &conn->c_peer_name );
        }
+
        sc = sasl_server_new( "ldap", global_host, global_realm,
                iplocalport, ipremoteport, session_callbacks, SASL_SUCCESS_DATA, &ctx );
        if ( iplocalport != NULL ) {
@@ -1381,6 +1472,9 @@ int slap_sasl_bind( Operation *op, SlapReply *rs )
                }
        } else if ( sc == SASL_CONTINUE ) {
                rs->sr_err = LDAP_SASL_BIND_IN_PROGRESS,
+#if SASL_VERSION_MAJOR >= 2
+               rs->sr_text = sasl_errdetail( ctx );
+#endif
                rs->sr_sasldata = &response;
                send_ldap_sasl( op, rs );
 
@@ -1393,9 +1487,7 @@ int slap_sasl_bind( Operation *op, SlapReply *rs )
        }
 
 #if SASL_VERSION_MAJOR < 2
-       if( response.bv_len ) {
-               ch_free( response.bv_val );
-       }
+       if( response.bv_len ) ch_free( response.bv_val );
 #endif
 
        Debug(LDAP_DEBUG_TRACE, "<== slap_sasl_bind: rc=%d\n", rs->sr_err, 0, 0);
@@ -1464,7 +1556,7 @@ slap_sasl_setpass( Operation *op, SlapReply *rs )
        assert( ber_bvcmp( &slap_EXOP_MODIFY_PASSWD, &op->ore_reqoid ) == 0 );
 
        rs->sr_err = sasl_getprop( op->o_conn->c_sasl_authctx, SASL_USERNAME,
-               (SASL_CONST void **)&id.bv_val );
+               (SASL_CONST void **)(char *)&id.bv_val );
 
        if( rs->sr_err != SASL_OK ) {
                rs->sr_text = "unable to retrieve SASL username";