]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/sasl.c
Added op->o_is_auth_check; use ACL_AUTH instead of ACL_SEARCH/ACL_READ
[openldap] / servers / slapd / sasl.c
index 6db5f1dc3c2736d652c58fdaa1def43054af13c6..518db4ec92b08b6362daedab1ade8d101d323956 100644 (file)
@@ -1,6 +1,6 @@
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
 
 #include "slap.h"
 
-#ifdef HAVE_CYRUS_SASL
 #include <limits.h>
 
-#ifdef HAVE_SASL_SASL_H
-#include <sasl/sasl.h>
-#else
-#include <sasl.h>
-#endif
+#ifdef HAVE_CYRUS_SASL
+# ifdef HAVE_SASL_SASL_H
+#  include <sasl/sasl.h>
+# else
+#  include <sasl.h>
+# endif
+
+# if SASL_VERSION_MAJOR >= 2
+#  include <sasl/saslplug.h>
+#  define      SASL_CONST const
+# else
+#  define      SASL_CONST
+# endif
 
-#include <lutil.h>
-#if SASL_VERSION_MAJOR >= 2
-#include <sasl/saslplug.h>
-#define        SASL_CONST const
-#else
-#define        SASL_CONST
-#endif
+static sasl_security_properties_t sasl_secprops;
+#endif /* HAVE_CYRUS_SASL */
 
 #include "ldap_pvt.h"
 #include "lber_pvt.h"
-
-/* Flags for telling slap_sasl_getdn() what type of identity is being passed */
-#define FLAG_GETDN_AUTHCID 2
-#define FLAG_GETDN_AUTHZID 4
-
-static sasl_security_properties_t sasl_secprops;
+#include <lutil.h>
 
 int slap_sasl_config( int cargc, char **cargv, char *line,
        const char *fname, int lineno )
@@ -49,11 +46,13 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                        if ( cargc != 2 ) {
 #ifdef NEW_LOGGING
                                LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d: missing policy in \"sasl-authz-policy <policy>\" line\n",
-                                          fname, lineno, 0 );
+                                       "%s: line %d: missing policy in"
+                                       " \"sasl-authz-policy <policy>\" line\n",
+                                       fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
-           "%s: line %d: missing policy in \"sasl-authz-policy <policy>\" line\n",
+                                       "%s: line %d: missing policy in"
+                                       " \"sasl-authz-policy <policy>\" line\n",
                                    fname, lineno, 0 );
 #endif
 
@@ -77,18 +76,42 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
 #endif
                                return( 1 );
                        }
-                       
 
+               } else if ( !strcasecmp( cargv[0], "sasl-regexp" ) 
+                       || !strcasecmp( cargv[0], "saslregexp" ) )
+               {
+                       int rc;
+                       if ( cargc != 3 ) {
+#ifdef NEW_LOGGING
+                               LDAP_LOG( CONFIG, CRIT,
+                                       "%s: line %d: need 2 args in "
+                                       "\"saslregexp <match> <replace>\"\n",
+                                       fname, lineno, 0 );
+#else
+                               Debug( LDAP_DEBUG_ANY, 
+                                       "%s: line %d: need 2 args in "
+                                       "\"saslregexp <match> <replace>\"\n",
+                                       fname, lineno, 0 );
+#endif
+
+                               return( 1 );
+                       }
+                       rc = slap_sasl_regexp_config( cargv[1], cargv[2] );
+                       if ( rc ) {
+                               return rc;
+                       }
+
+#ifdef HAVE_CYRUS_SASL
                /* set SASL host */
                } else if ( strcasecmp( cargv[0], "sasl-host" ) == 0 ) {
                        if ( cargc < 2 ) {
 #ifdef NEW_LOGGING
                                LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d: missing host in \"sasl-host <host>\" line\n",
-                                          fname, lineno, 0 );
+                                       "%s: line %d: missing host in \"sasl-host <host>\" line\n",
+                                       fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
-           "%s: line %d: missing host in \"sasl-host <host>\" line\n",
+                               "%s: line %d: missing host in \"sasl-host <host>\" line\n",
                                    fname, lineno, 0 );
 #endif
 
@@ -98,8 +121,8 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                        if ( global_host != NULL ) {
 #ifdef NEW_LOGGING
                                LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d: already set sasl-host!\n",
-                                          fname, lineno, 0 );
+                                       "%s: line %d: already set sasl-host!\n",
+                                       fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "%s: line %d: already set sasl-host!\n",
@@ -116,12 +139,12 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                } else if ( strcasecmp( cargv[0], "sasl-realm" ) == 0 ) {
                        if ( cargc < 2 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d: missing realm in \"sasl-realm <realm>\" line.\n",
-                                          fname, lineno, 0 );
+                               LDAP_LOG( CONFIG, CRIT, "%s: line %d: "
+                                       "missing realm in \"sasl-realm <realm>\" line.\n",
+                                       fname, lineno, 0 );
 #else
-                               Debug( LDAP_DEBUG_ANY,
-           "%s: line %d: missing realm in \"sasl-realm <realm>\" line\n",
+                               Debug( LDAP_DEBUG_ANY, "%s: line %d: "
+                                       "missing realm in \"sasl-realm <realm>\" line.\n",
                                    fname, lineno, 0 );
 #endif
 
@@ -131,8 +154,8 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                        if ( global_realm != NULL ) {
 #ifdef NEW_LOGGING
                                LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d: already set sasl-realm!\n",
-                                          fname, lineno, 0 );
+                                       "%s: line %d: already set sasl-realm!\n",
+                                       fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "%s: line %d: already set sasl-realm!\n",
@@ -145,42 +168,18 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                                global_realm = ch_strdup( cargv[1] );
                        }
 
-               } else if ( !strcasecmp( cargv[0], "sasl-regexp" ) 
-                       || !strcasecmp( cargv[0], "saslregexp" ) )
-               {
-                       int rc;
-                       if ( cargc != 3 ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d: need 2 args in "
-                                          "\"saslregexp <match> <replace>\"\n",
-                                          fname, lineno, 0 );
-#else
-                               Debug( LDAP_DEBUG_ANY, 
-                               "%s: line %d: need 2 args in \"saslregexp <match> <replace>\"\n",
-                                   fname, lineno, 0 );
-#endif
-
-                               return( 1 );
-                       }
-                       rc = slap_sasl_regexp_config( cargv[1], cargv[2] );
-                       if ( rc ) {
-                               return rc;
-                       }
-
                /* SASL security properties */
                } else if ( strcasecmp( cargv[0], "sasl-secprops" ) == 0 ) {
                        char *txt;
 
                        if ( cargc < 2 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d: missing flags in "
-                                          "\"sasl-secprops <properties>\" line\n",
-                                          fname, lineno, 0 );
+                               LDAP_LOG( CONFIG, CRIT, "%s: line %d: "
+                                       "missing flags in \"sasl-secprops <properties>\" line\n",
+                                       fname, lineno, 0 );
 #else
-                               Debug( LDAP_DEBUG_ANY,
-           "%s: line %d: missing flags in \"sasl-secprops <properties>\" line\n",
+                               Debug( LDAP_DEBUG_ANY, "%s: line %d: "
+                                       "missing flags in \"sasl-secprops <properties>\" line\n",
                                    fname, lineno, 0 );
 #endif
 
@@ -191,22 +190,25 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                        if ( txt != NULL ) {
 #ifdef NEW_LOGGING
                                LDAP_LOG( CONFIG, CRIT,
-                                          "%s: line %d sasl-secprops: %s\n",
-                                          fname, lineno, txt );
+                                       "%s: line %d sasl-secprops: %s\n",
+                                       fname, lineno, txt );
 #else
                                Debug( LDAP_DEBUG_ANY,
-           "%s: line %d: sasl-secprops: %s\n",
+                                       "%s: line %d: sasl-secprops: %s\n",
                                    fname, lineno, txt );
 #endif
 
                                return 1;
                        }
+#endif /* HAVE_CYRUS_SASL */
            }
 
            return LDAP_SUCCESS;
 }
 
-static int
+#ifdef HAVE_CYRUS_SASL
+
+int
 slap_sasl_log(
        void *context,
        int priority,
@@ -286,180 +288,6 @@ slap_sasl_log(
 }
 
 
-/* Take any sort of identity string and return a DN with the "dn:" prefix. The
-   string returned in *dn is in its own allocated memory, and must be free'd 
-   by the calling process.
-   -Mark Adamson, Carnegie Mellon
-
-   The "dn:" prefix is no longer used anywhere inside slapd. It is only used
-   on strings passed in directly from SASL.
-   -Howard Chu, Symas Corp.
-*/
-
-#define        SET_DN  1
-#define        SET_U   2
-
-static struct berval ext_bv = BER_BVC( "EXTERNAL" );
-
-int slap_sasl_getdn( Connection *conn, char *id, int len,
-       char *user_realm, struct berval *dn, int flags )
-{
-       char *c1;
-       int rc, is_dn = 0, do_norm = 1;
-       sasl_conn_t *ctx;
-       struct berval dn2;
-
-#ifdef NEW_LOGGING
-       LDAP_LOG( TRANSPORT, ENTRY, 
-               "slap_sasl_getdn: conn %d id=%s\n",
-               conn ? conn->c_connid : -1, id ? (*id ? id : "<empty>") : "NULL", 0 );
-#else
-       Debug( LDAP_DEBUG_ARGS, "slap_sasl_getdn: id=%s\n", 
-      id?(*id?id:"<empty>"):"NULL",0,0 );
-#endif
-
-       dn->bv_val = NULL;
-       dn->bv_len = 0;
-
-       if ( id ) {
-               if ( len == 0 ) len = strlen( id );
-
-               /* Blatantly anonymous ID */
-               if ( len == sizeof("anonymous") - 1 &&
-                       !strcasecmp( id, "anonymous" ) ) {
-                       return( LDAP_SUCCESS );
-               }
-       } else {
-               len = 0;
-       }
-
-       ctx = conn->c_sasl_context;
-
-       /* An authcID needs to be converted to authzID form. Set the
-        * values directly into *dn; they will be normalized later. (and
-        * normalizing always makes a new copy.) An ID from a TLS certificate
-        * is already normalized, so copy it and skip normalization.
-        */
-       if( flags & FLAG_GETDN_AUTHCID ) {
-#ifdef HAVE_TLS
-               if( conn->c_is_tls &&
-                       conn->c_sasl_bind_mech.bv_len == ext_bv.bv_len &&
-                       strcasecmp( ext_bv.bv_val, conn->c_sasl_bind_mech.bv_val ) == 0 )
-               {
-                       /* X.509 DN is already normalized */
-                       do_norm = 0;
-                       is_dn = SET_DN;
-                       ber_str2bv( id, len, 1, dn );
-
-               } else
-#endif
-               {
-                       /* convert to u:<username> form */
-                       is_dn = SET_U;
-                       dn->bv_val = id;
-                       dn->bv_len = len;
-               }
-       }
-       if( !is_dn ) {
-               if( !strncasecmp( id, "u:", sizeof("u:")-1 )) {
-                       is_dn = SET_U;
-                       dn->bv_val = id+2;
-                       dn->bv_len = len-2;
-               } else if ( !strncasecmp( id, "dn:", sizeof("dn:")-1) ) {
-                       is_dn = SET_DN;
-                       dn->bv_val = id+3;
-                       dn->bv_len = len-3;
-               }
-       }
-
-       /* No other possibilities from here */
-       if( !is_dn ) {
-               dn->bv_val = NULL;
-               dn->bv_len = 0;
-               return( LDAP_INAPPROPRIATE_AUTH );
-       }
-
-       /* Username strings */
-       if( is_dn == SET_U ) {
-               char *p, *realm;
-               len = dn->bv_len + sizeof("uid=")-1 + sizeof(",cn=auth")-1;
-
-               /* username may have embedded realm name */
-               if( ( realm = strchr( dn->bv_val, '@') ) ) {
-                       *realm++ = '\0';
-                       len += sizeof(",cn=")-2;
-               } else if( user_realm && *user_realm ) {
-                       len += strlen( user_realm ) + sizeof(",cn=")-1;
-               }
-
-               if( conn->c_sasl_bind_mech.bv_len ) {
-                       len += conn->c_sasl_bind_mech.bv_len + sizeof(",cn=")-1;
-               }
-
-               /* Build the new dn */
-               c1 = dn->bv_val;
-               dn->bv_val = ch_malloc( len+1 );
-               p = lutil_strcopy( dn->bv_val, "uid=" );
-               p = lutil_strncopy( p, c1, dn->bv_len );
-
-               if( realm ) {
-                       int rlen = dn->bv_len - ( realm - c1 );
-                       p = lutil_strcopy( p, ",cn=" );
-                       p = lutil_strncopy( p, realm, rlen );
-                       realm[-1] = '@';
-               } else if( user_realm && *user_realm ) {
-                       p = lutil_strcopy( p, ",cn=" );
-                       p = lutil_strcopy( p, user_realm );
-               }
-
-               if( conn->c_sasl_bind_mech.bv_len ) {
-                       p = lutil_strcopy( p, ",cn=" );
-                       p = lutil_strcopy( p, conn->c_sasl_bind_mech.bv_val );
-               }
-               p = lutil_strcopy( p, ",cn=auth" );
-               dn->bv_len = p - dn->bv_val;
-
-#ifdef NEW_LOGGING
-               LDAP_LOG( TRANSPORT, ENTRY, 
-                       "slap_sasl_getdn: u:id converted to %s.\n", dn->bv_val, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "getdn: u:id converted to %s\n", dn->bv_val,0,0 );
-#endif
-       }
-
-       /* All strings are in DN form now. Normalize if needed. */
-       if ( do_norm ) {
-               rc = dnNormalize2( NULL, dn, &dn2 );
-
-               /* User DNs were constructed above and must be freed now */
-               if ( is_dn == SET_U )
-                       ch_free( dn->bv_val );
-
-               if ( rc != LDAP_SUCCESS ) {
-                       dn->bv_val = NULL;
-                       dn->bv_len = 0;
-                       return rc;
-               }
-               *dn = dn2;
-       }
-
-       /* Run thru regexp */
-       slap_sasl2dn( conn, dn, &dn2 );
-       if( dn2.bv_val ) {
-               ch_free( dn->bv_val );
-               *dn = dn2;
-#ifdef NEW_LOGGING
-               LDAP_LOG( TRANSPORT, ENTRY, 
-                       "slap_sasl_getdn: dn:id converted to %s.\n", dn->bv_val, 0, 0 );
-#else
-               Debug( LDAP_DEBUG_TRACE, "getdn: dn:id converted to %s\n",
-                       dn->bv_val, 0, 0 );
-#endif
-       }
-
-       return( LDAP_SUCCESS );
-}
-
 #if SASL_VERSION_MAJOR >= 2
 static const char *slap_propnames[] = {
        "*slapConn", "*authcDN", "*authzDN", NULL };
@@ -597,7 +425,7 @@ slap_auxprop_lookup(
                Backend *be;
                Operation op = {0};
                slap_callback cb = { slap_cb_null_response,
-                       slap_cb_null_sresult, sasl_ap_lookup, NULL };
+                       slap_cb_null_sresult, sasl_ap_lookup, slap_cb_null_sreference, NULL };
 
                cb.sc_private = &sl;
 
@@ -610,6 +438,7 @@ slap_auxprop_lookup(
                        op.o_callback = &cb;
                        op.o_time = slap_get_time();
                        op.o_do_not_cache = 1;
+                       op.o_is_auth_check = 1;
                        op.o_threadctx = conn->c_sasl_bindop->o_threadctx;
 
                        (*be->be_search)( be, conn, &op, NULL, &dn,
@@ -704,7 +533,7 @@ slap_sasl_checkpass(
         */
 
        rc = slap_sasl_getdn( conn, (char *)username, 0, NULL, &dn,
-               FLAG_GETDN_AUTHCID );
+               SLAP_GETDN_AUTHCID );
        if ( rc != LDAP_SUCCESS ) {
                sasl_seterror( sconn, 0, ldap_err2string( rc ) );
                return SASL_NOUSER;
@@ -723,7 +552,7 @@ slap_sasl_checkpass(
        if ( be && be->be_search ) {
                Operation op = {0};
                slap_callback cb = { slap_cb_null_response,
-                       slap_cb_null_sresult, sasl_cb_checkpass, NULL };
+                       slap_cb_null_sresult, sasl_cb_checkpass, slap_cb_null_sreference, NULL };
 
                ci.cred.bv_val = (char *)pass;
                ci.cred.bv_len = passlen;
@@ -735,6 +564,7 @@ slap_sasl_checkpass(
                op.o_callback = &cb;
                op.o_time = slap_get_time();
                op.o_do_not_cache = 1;
+               op.o_is_auth_check = 1;
                op.o_threadctx = conn->c_sasl_bindop->o_threadctx;
 
                (*be->be_search)( be, conn, &op, NULL, &dn,
@@ -782,13 +612,13 @@ slap_sasl_canonicalize(
        LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_canonicalize: conn %d %s=\"%s\"\n",
                conn ? conn->c_connid : -1,
-               (flags & SASL_CU_AUTHID) ? "authcid" : "authzid", in ? in : "<empty>");
+               (flags & SASL_CU_AUTHID) ? "authcid" : "authzid",
+               in ? in : "<empty>");
 #else
-       Debug( LDAP_DEBUG_ARGS, "SASL Canonicalize [conn=%ld]: "
-               "%s=\"%s\"\n",
-                       conn ? conn->c_connid : -1,
-                       (flags & SASL_CU_AUTHID) ? "authcid" : "authzid",
-                       in ? in : "<empty>" );
+       Debug( LDAP_DEBUG_ARGS, "SASL Canonicalize [conn=%ld]: %s=\"%s\"\n",
+               conn ? conn->c_connid : -1,
+               (flags & SASL_CU_AUTHID) ? "authcid" : "authzid",
+               in ? in : "<empty>");
 #endif
 
        /* If name is too big, just truncate. We don't care, we're
@@ -818,21 +648,32 @@ slap_sasl_canonicalize(
        if ( auxvals[which].values )
                goto done;
 
-       if ( flags == SASL_CU_AUTHZID ) {
-       /* If we got unqualified authzid's, they probably came from SASL
-        * itself just passing the authcid to us. Look inside the oparams
-        * structure to see if that's true. (HACK: the out_len pointer is
-        * the address of a member of a sasl_out_params_t structure...)
+       /* Normally we require an authzID to have a u: or dn: prefix.
+        * However, SASL frequently gives us an authzID that is just
+        * an exact copy of the authcID, without a prefix. We need to
+        * detect and allow this condition. If SASL calls canonicalize
+        * with SASL_CU_AUTHID|SASL_CU_AUTHZID this is a no-brainer.
+        * But if it's broken into two calls, we need to remember the
+        * authcID so that we can compare the authzID later. We store
+        * the authcID temporarily in conn->c_sasl_dn. We necessarily
+        * finish Canonicalizing before Authorizing, so there is no
+        * conflict with slap_sasl_authorize's use of this temp var.
+        *
+        * The SASL EXTERNAL mech is backwards from all the other mechs,
+        * it does authzID before the authcID. If we see that authzID
+        * has already been done, don't do anything special with authcID.
         */
-               sasl_out_params_t dummy;
-               int offset = (void *)&dummy.ulen - (void *)&dummy.authid;
-               char **authid = (void *)out_len - offset;
-               if ( *authid && !strcmp( in, *authid ) )
-                       goto done;
+       if ( flags == SASL_CU_AUTHID && !auxvals[PROP_AUTHZ].values ) {
+               conn->c_sasl_dn.bv_val = (char *) in;
+       } else if ( flags == SASL_CU_AUTHZID && conn->c_sasl_dn.bv_val ) {
+               rc = strcmp( in, conn->c_sasl_dn.bv_val );
+               conn->c_sasl_dn.bv_val = NULL;
+               /* They were equal, no work needed */
+               if ( !rc ) goto done;
        }
 
        rc = slap_sasl_getdn( conn, (char *)in, inlen, (char *)user_realm, &dn,
-               (flags & SASL_CU_AUTHID) ? FLAG_GETDN_AUTHCID : FLAG_GETDN_AUTHZID );
+               (flags & SASL_CU_AUTHID) ? SLAP_GETDN_AUTHCID : SLAP_GETDN_AUTHZID );
        if ( rc != LDAP_SUCCESS ) {
                sasl_seterror( sconn, 0, ldap_err2string( rc ) );
                return SASL_NOAUTHZ;
@@ -846,14 +687,16 @@ slap_sasl_canonicalize(
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_canonicalize: conn %d %s=\"%s\"\n",
-               conn ? conn->c_connid : -1, names[0]+1, dn.bv_val );
+               conn ? conn->c_connid : -1, names[0]+1,
+               dn.bv_val ? dn.bv_val : "<EMPTY>" );
 #else
-       Debug( LDAP_DEBUG_ARGS, "SASL Canonicalize [conn=%ld]: "
-               "%s=\"%s\"\n",
-                       conn ? conn->c_connid : -1,
-                       names[0]+1, dn.bv_val );
+       Debug( LDAP_DEBUG_ARGS, "SASL Canonicalize [conn=%ld]: %s=\"%s\"\n",
+               conn ? conn->c_connid : -1, names[0]+1,
+               dn.bv_val ? dn.bv_val : "<EMPTY>" );
 #endif
-done:  AC_MEMCPY( out, in, inlen );
+
+done:
+       AC_MEMCPY( out, in, inlen );
        out[inlen] = '\0';
 
        *out_len = inlen;
@@ -901,7 +744,7 @@ slap_sasl_authorize(
        /* Nothing to do if no authzID was given */
        if ( !auxvals[1].name || !auxvals[1].values ) {
                conn->c_sasl_dn = authcDN;
-               return SASL_OK;
+               goto ok;
        }
        
        AC_MEMCPY( &authzDN, auxvals[1].values[0], sizeof(authzDN) );
@@ -925,6 +768,13 @@ slap_sasl_authorize(
        }
 
        conn->c_sasl_dn = authzDN;
+ok:
+       if (conn->c_sasl_bindop) {
+               Statslog( LDAP_DEBUG_STATS,
+                       "conn=%lu op=%lu BIND authcid=\"%s\"\n",
+                       conn->c_connid, conn->c_sasl_bindop->o_opid, 
+                       auth_identity, 0, 0);
+       }
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
@@ -987,7 +837,8 @@ slap_sasl_authorize(
 
        /* Convert the identities to DN's. If no authzid was given, client will
           be bound as the DN matching their username */
-       rc = slap_sasl_getdn( conn, (char *)authcid, 0, realm, &authcDN, FLAG_GETDN_AUTHCID );
+       rc = slap_sasl_getdn( conn, (char *)authcid, 0, realm,
+               &authcDN, SLAP_GETDN_AUTHCID );
        if( rc != LDAP_SUCCESS ) {
                *errstr = ldap_err2string( rc );
                return SASL_NOAUTHZ;
@@ -1003,10 +854,10 @@ slap_sasl_authorize(
 #endif
 
                conn->c_sasl_dn = authcDN;
-               *errstr = NULL;
-               return SASL_OK;
+               goto ok;
        }
-       rc = slap_sasl_getdn( conn, (char *)authzid, 0, realm, &authzDN, FLAG_GETDN_AUTHZID );
+       rc = slap_sasl_getdn( conn, (char *)authzid, 0, realm,
+               &authzDN, SLAP_GETDN_AUTHZID );
        if( rc != LDAP_SUCCESS ) {
                ch_free( authcDN.bv_val );
                *errstr = ldap_err2string( rc );
@@ -1030,7 +881,9 @@ slap_sasl_authorize(
                ch_free( authzDN.bv_val );
                return SASL_NOAUTHZ;
        }
+       conn->c_sasl_dn = authzDN;
 
+ok:
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, RESULTS, 
                "slap_sasl_authorize: conn %d authorization allowed\n",
@@ -1041,7 +894,13 @@ slap_sasl_authorize(
                (long) (conn ? conn->c_connid : -1), 0, 0 );
 #endif
 
-       conn->c_sasl_dn = authzDN;
+       if (conn->c_sasl_bindop) {
+               Statslog( LDAP_DEBUG_STATS,
+                       "conn=%lu op=%lu BIND authcid=\"%s\"\n",
+                       conn->c_connid, conn->c_sasl_bindop->o_opid, 
+                       authcid, 0, 0);
+       }
+
        *errstr = NULL;
        return SASL_OK;
 }
@@ -1084,7 +943,6 @@ slap_sasl_err2ldap( int saslerr )
 }
 #endif
 
-
 int slap_sasl_init( void )
 {
 #ifdef HAVE_CYRUS_SASL
@@ -1114,12 +972,15 @@ int slap_sasl_init( void )
                return -1;
        }
 #endif
-       
+
+       /* SASL 2 does its own memory management internally */
+#if SASL_VERSION_MAJOR < 2
        sasl_set_alloc(
                ber_memalloc,
                ber_memcalloc,
                ber_memrealloc,
                ber_memfree ); 
+#endif
 
        sasl_set_mutex(
                ldap_pvt_sasl_mutex_new,
@@ -1199,10 +1060,20 @@ int slap_sasl_open( Connection *conn )
 
        session_callbacks =
 #if SASL_VERSION_MAJOR >= 2
-               ch_calloc( 5, sizeof(sasl_callback_t));
+               SLAP_CALLOC( 5, sizeof(sasl_callback_t));
 #else
-               ch_calloc( 3, sizeof(sasl_callback_t));
+               SLAP_CALLOC( 3, sizeof(sasl_callback_t));
 #endif
+       if( session_callbacks == NULL ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG( TRANSPORT, ERR, 
+                               "slap_sasl_open: SLAP_MALLOC failed", 0, 0, 0 );
+#else
+                       Debug( LDAP_DEBUG_ANY, 
+                               "slap_sasl_open: SLAP_MALLOC failed", 0, 0, 0 );
+#endif
+                       return -1;
+       }
        conn->c_sasl_extra = session_callbacks;
 
        session_callbacks[cb=0].id = SASL_CB_LOG;
@@ -1264,7 +1135,7 @@ int slap_sasl_open( Connection *conn )
                }
        }
        sc = sasl_server_new( "ldap", global_host, global_realm,
-               iplocalport, ipremoteport, session_callbacks, 0, &ctx );
+               iplocalport, ipremoteport, session_callbacks, SASL_SUCCESS_DATA, &ctx );
        if ( iplocalport != NULL ) {
                ch_free( iplocalport );
        }
@@ -1485,8 +1356,7 @@ int slap_sasl_bind(
        if ( !conn->c_sasl_bind_in_progress ) {
                sc = START( ctx,
                        conn->c_sasl_bind_mech.bv_val,
-                       cred->bv_len ? cred->bv_val : "",
-                       cred->bv_len,
+                       cred->bv_val, cred->bv_len,
                        (SASL_CONST char **)&response.bv_val, &reslen, &errstr );
 
        } else {
@@ -1568,7 +1438,7 @@ int
 slap_sasl_setpass(
        Connection      *conn,
        Operation       *op,
-       const char      *reqoid,
+       struct berval   *reqoid,
        struct berval   *reqdata,
        char            **rspoid,
        struct berval   **rspdata,
@@ -1581,7 +1451,7 @@ slap_sasl_setpass(
        struct berval old = { 0, NULL };
 
        assert( reqoid != NULL );
-       assert( strcmp( LDAP_EXOP_MODIFY_PASSWD, reqoid ) == 0 );
+       assert( ber_bvcmp( &slap_EXOP_MODIFY_PASSWD, reqoid ) == 0 );
 
        rc = sasl_getprop( conn->c_sasl_context, SASL_USERNAME,
                (SASL_CONST void **)&id.bv_val );
@@ -1648,4 +1518,188 @@ slap_sasl_setpass(
 done:
        return rc;
 }
+#endif /* HAVE_CYRUS_SASL */
+
+/* Take any sort of identity string and return a DN with the "dn:" prefix. The
+   string returned in *dn is in its own allocated memory, and must be free'd 
+   by the calling process.
+   -Mark Adamson, Carnegie Mellon
+
+   The "dn:" prefix is no longer used anywhere inside slapd. It is only used
+   on strings passed in directly from SASL.
+   -Howard Chu, Symas Corp.
+*/
+
+#define SET_NONE       0
+#define        SET_DN          1
+#define        SET_U           2
+
+static struct berval ext_bv = BER_BVC( "EXTERNAL" );
+
+int slap_sasl_getdn( Connection *conn, char *id, int len,
+       char *user_realm, struct berval *dn, int flags )
+{
+       char *c1;
+       int rc, is_dn = SET_NONE, do_norm = 1;
+       struct berval dn2;
+
+#ifdef NEW_LOGGING
+       LDAP_LOG( TRANSPORT, ENTRY, 
+               "slap_sasl_getdn: conn %d id=%s [len=%d]\n",
+               conn ? conn->c_connid : -1, id ? (*id ? id : "<empty>") : "NULL", len );
+#else
+       Debug( LDAP_DEBUG_ARGS, "slap_sasl_getdn: id=%s [len=%d]\n", 
+               id ? ( *id ? id : "<empty>" ) : "NULL", len, 0 );
 #endif
+
+       dn->bv_val = NULL;
+       dn->bv_len = 0;
+
+       if ( id ) {
+               if ( len == 0 ) len = strlen( id );
+
+               /* Blatantly anonymous ID */
+               if ( len == sizeof("anonymous") - 1 &&
+                       !strcasecmp( id, "anonymous" ) ) {
+                       return( LDAP_SUCCESS );
+               }
+       } else {
+               len = 0;
+       }
+
+       /* An authcID needs to be converted to authzID form. Set the
+        * values directly into *dn; they will be normalized later. (and
+        * normalizing always makes a new copy.) An ID from a TLS certificate
+        * is already normalized, so copy it and skip normalization.
+        */
+       if( flags & SLAP_GETDN_AUTHCID ) {
+               if( conn->c_sasl_bind_mech.bv_len == ext_bv.bv_len &&
+                       strcasecmp( ext_bv.bv_val, conn->c_sasl_bind_mech.bv_val ) == 0 )
+               {
+                       /* EXTERNAL DNs are already normalized */
+                       do_norm = 0;
+                       is_dn = SET_DN;
+                       ber_str2bv( id, len, 1, dn );
+
+               } else {
+                       /* convert to u:<username> form */
+                       is_dn = SET_U;
+                       dn->bv_val = id;
+                       dn->bv_len = len;
+               }
+       }
+       if( is_dn == SET_NONE ) {
+               if( !strncasecmp( id, "u:", sizeof("u:")-1 )) {
+                       is_dn = SET_U;
+                       dn->bv_val = id+2;
+                       dn->bv_len = len-2;
+               } else if ( !strncasecmp( id, "dn:", sizeof("dn:")-1) ) {
+                       is_dn = SET_DN;
+                       dn->bv_val = id+3;
+                       dn->bv_len = len-3;
+               }
+       }
+
+       /* No other possibilities from here */
+       if( is_dn == SET_NONE ) {
+               dn->bv_val = NULL;
+               dn->bv_len = 0;
+               return( LDAP_INAPPROPRIATE_AUTH );
+       }
+
+       /* Username strings */
+       if( is_dn == SET_U ) {
+               char *p, *realm;
+               len = dn->bv_len + sizeof("uid=")-1 + sizeof(",cn=auth")-1;
+
+               /* username may have embedded realm name */
+               if( ( realm = strchr( dn->bv_val, '@') ) ) {
+                       *realm++ = '\0';
+                       len += sizeof(",cn=")-2;
+               } else if( user_realm && *user_realm ) {
+                       len += strlen( user_realm ) + sizeof(",cn=")-1;
+               }
+
+               if( conn->c_sasl_bind_mech.bv_len ) {
+                       len += conn->c_sasl_bind_mech.bv_len + sizeof(",cn=")-1;
+               }
+
+               /* Build the new dn */
+               c1 = dn->bv_val;
+               dn->bv_val = SLAP_MALLOC( len+1 );
+               if( dn->bv_val == NULL ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG( TRANSPORT, ERR, 
+                               "slap_sasl_getdn: SLAP_MALLOC failed", 0, 0, 0 );
+#else
+                       Debug( LDAP_DEBUG_ANY, 
+                               "slap_sasl_getdn: SLAP_MALLOC failed", 0, 0, 0 );
+#endif
+                       return LDAP_OTHER;
+               }
+               p = lutil_strcopy( dn->bv_val, "uid=" );
+               p = lutil_strncopy( p, c1, dn->bv_len );
+
+               if( realm ) {
+                       int rlen = dn->bv_len - ( realm - c1 );
+                       p = lutil_strcopy( p, ",cn=" );
+                       p = lutil_strncopy( p, realm, rlen );
+                       realm[-1] = '@';
+               } else if( user_realm && *user_realm ) {
+                       p = lutil_strcopy( p, ",cn=" );
+                       p = lutil_strcopy( p, user_realm );
+               }
+
+               if( conn->c_sasl_bind_mech.bv_len ) {
+                       p = lutil_strcopy( p, ",cn=" );
+                       p = lutil_strcopy( p, conn->c_sasl_bind_mech.bv_val );
+               }
+               p = lutil_strcopy( p, ",cn=auth" );
+               dn->bv_len = p - dn->bv_val;
+
+#ifdef NEW_LOGGING
+               LDAP_LOG( TRANSPORT, ENTRY, 
+                       "slap_sasl_getdn: u:id converted to %s.\n", dn->bv_val, 0, 0 );
+#else
+               Debug( LDAP_DEBUG_TRACE, "getdn: u:id converted to %s\n", dn->bv_val,0,0 );
+#endif
+       } else {
+               
+               /* Dup the DN in any case, so we don't risk 
+                * leaks or dangling pointers later,
+                * and the DN value is '\0' terminated */
+               ber_dupbv( &dn2, dn );
+               dn->bv_val = dn2.bv_val;
+       }
+
+       /* All strings are in DN form now. Normalize if needed. */
+       if ( do_norm ) {
+               rc = dnNormalize2( NULL, dn, &dn2 );
+
+               /* User DNs were constructed above and must be freed now */
+               ch_free( dn->bv_val );
+
+               if ( rc != LDAP_SUCCESS ) {
+                       dn->bv_val = NULL;
+                       dn->bv_len = 0;
+                       return rc;
+               }
+               *dn = dn2;
+       }
+
+       /* Run thru regexp */
+       slap_sasl2dn( conn, dn, &dn2 );
+       if( dn2.bv_val ) {
+               ch_free( dn->bv_val );
+               *dn = dn2;
+#ifdef NEW_LOGGING
+               LDAP_LOG( TRANSPORT, ENTRY, 
+                       "slap_sasl_getdn: dn:id converted to %s.\n", dn->bv_val, 0, 0 );
+#else
+               Debug( LDAP_DEBUG_TRACE, "getdn: dn:id converted to %s\n",
+                       dn->bv_val, 0, 0 );
+#endif
+       }
+
+       return( LDAP_SUCCESS );
+}