]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/sasl.c
Sync with HEAD
[openldap] / servers / slapd / sasl.c
index adbaf79a66aeca1a7b9f99b2270ccf6813469a0e..6c9378f954970e77ac60d7c8e881b7be7ac4c168 100644 (file)
@@ -1,7 +1,16 @@
 /* $OpenLDAP$ */
-/*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2003 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
 # endif
 
 # if SASL_VERSION_MAJOR >= 2
+# ifdef HAVE_SASL_SASL_H
 #  include <sasl/saslplug.h>
+# else
+#  include <saslplug.h>
+# endif
 #  define      SASL_CONST const
 # else
 #  define      SASL_CONST
 # endif
 
 static sasl_security_properties_t sasl_secprops;
+
+#define SASL_VERSION_FULL      ((SASL_VERSION_MAJOR << 16) |\
+       (SASL_VERSION_MINOR << 8) | SASL_VERSION_STEP)
+
 #endif /* HAVE_CYRUS_SASL */
 
 #include "ldap_pvt.h"
@@ -293,6 +310,7 @@ static const char *slap_propnames[] = {
        "*slapConn", "*authcDN", "*authzDN", NULL };
 
 static Filter generic_filter = { LDAP_FILTER_PRESENT };
+static struct berval generic_filterstr = BER_BVC("(objectclass=*)");
 
 #define        PROP_CONN       0
 #define        PROP_AUTHC      1
@@ -305,7 +323,7 @@ typedef struct lookup_info {
        sasl_server_params_t *sparams;
 } lookup_info;
 
-static slap_response sasl_ap_lookup, sasl_cb_checkpass;
+static slap_response sasl_ap_lookup, sasl_ap_store, sasl_cb_checkpass;
 
 static int
 sasl_ap_lookup( Operation *op, SlapReply *rs )
@@ -442,16 +460,126 @@ slap_auxprop_lookup(
                        op.o_tmpmfuncs = conn->c_sasl_bindop->o_tmpmfuncs;
                        op.o_conn = conn;
                        op.o_connid = conn->c_connid;
+                       op.o_req_dn = op.o_req_ndn;
                        op.ors_scope = LDAP_SCOPE_BASE;
                        op.ors_deref = LDAP_DEREF_NEVER;
                        op.ors_slimit = 1;
                        op.ors_filter = &generic_filter;
+                       op.ors_filterstr = generic_filterstr;
 
                        op.o_bd->be_search( &op, &rs );
                }
        }
 }
 
+#if SASL_VERSION_FULL >= 0x020110
+static int
+sasl_ap_store( Operation *op, SlapReply *rs )
+{
+       return 0;
+}
+
+static int
+slap_auxprop_store(
+       void *glob_context,
+       sasl_server_params_t *sparams,
+       struct propctx *prctx,
+       const char *user,
+       unsigned ulen)
+{
+       Operation op = {0};
+       SlapReply rs = {REP_RESULT};
+       int rc, i, j;
+       Connection *conn = NULL;
+       const struct propval *pr;
+       Modifications *modlist = NULL, **modtail = &modlist, *mod;
+       slap_callback cb = { sasl_ap_store, NULL };
+       char textbuf[SLAP_TEXT_BUFLEN];
+       const char *text;
+       size_t textlen = sizeof(textbuf);
+
+       /* just checking if we are enabled */
+       if (!prctx) return SASL_OK;
+
+       if (!sparams || !user) return SASL_BADPARAM;
+
+       pr = sparams->utils->prop_get( sparams->propctx );
+
+       /* Find our DN and conn first */
+       for( i = 0; pr[i].name; i++ ) {
+               if ( pr[i].name[0] == '*' ) {
+                       if ( !strcmp( pr[i].name, slap_propnames[PROP_CONN] ) ) {
+                               if ( pr[i].values && pr[i].values[0] )
+                                       AC_MEMCPY( &conn, pr[i].values[0], sizeof( conn ) );
+                               continue;
+                       }
+                       if ( !strcmp( pr[i].name, slap_propnames[PROP_AUTHC] ) ) {
+                               if ( pr[i].values && pr[i].values[0] ) {
+                                       AC_MEMCPY( &op.o_req_ndn, pr[i].values[0], sizeof( struct berval ) );
+                               }
+                       }
+               }
+       }
+       if (!conn || !op.o_req_ndn.bv_val) return SASL_BADPARAM;
+
+       op.o_bd = select_backend( &op.o_req_ndn, 0, 1 );
+
+       if ( !op.o_bd || !op.o_bd->be_modify ) return SASL_FAIL;
+               
+       pr = sparams->utils->prop_get( prctx );
+       if (!pr) return SASL_BADPARAM;
+
+       for (i=0; pr[i].name; i++);
+       if (!i) return SASL_BADPARAM;
+
+       for (i=0; pr[i].name; i++) {
+               mod = (Modifications *)ch_malloc( sizeof(Modifications) );
+               mod->sml_op = LDAP_MOD_REPLACE;
+               ber_str2bv( pr[i].name, 0, 0, &mod->sml_type );
+               mod->sml_values = (struct berval *)ch_malloc( (pr[i].nvalues + 1) *
+                       sizeof(struct berval));
+               for (j=0; j<pr[i].nvalues; j++) {
+                       ber_str2bv( pr[i].values[j], 0, 1, &mod->sml_values[j]);
+               }
+               mod->sml_values[j].bv_val = NULL;
+               mod->sml_values[j].bv_len = 0;
+               mod->sml_nvalues = NULL;
+               mod->sml_desc = NULL;
+               *modtail = mod;
+               modtail = &mod->sml_next;
+       }
+       *modtail = NULL;
+
+       rc = slap_mods_check( modlist, 0, &text, textbuf, textlen, NULL );
+
+       if ( rc == LDAP_SUCCESS ) {
+               rc = slap_mods_opattrs( &op, modlist, modtail, &text, textbuf,
+                       textlen );
+       }
+
+       if ( rc == LDAP_SUCCESS ) {
+               op.o_tag = LDAP_REQ_MODIFY;
+               op.o_protocol = LDAP_VERSION3;
+               op.o_ndn = op.o_req_ndn;
+               op.o_callback = &cb;
+               op.o_time = slap_get_time();
+               op.o_do_not_cache = 1;
+               op.o_is_auth_check = 1;
+               op.o_threadctx = conn->c_sasl_bindop->o_threadctx;
+               op.o_tmpmemctx = conn->c_sasl_bindop->o_tmpmemctx;
+               op.o_tmpmfuncs = conn->c_sasl_bindop->o_tmpmfuncs;
+               op.o_conn = conn;
+               op.o_connid = conn->c_connid;
+               op.o_req_dn = op.o_req_ndn;
+               op.orm_modlist = modlist;
+
+               rc = op.o_bd->be_modify( &op, &rs );
+       }
+       slap_mods_free( modlist );
+       return rc ? SASL_FAIL : SASL_OK;
+}
+#endif /* SASL_VERSION_FULL >= 2.1.16 */
+
 static sasl_auxprop_plug_t slap_auxprop_plugin = {
        0,      /* Features */
        0,      /* spare */
@@ -459,7 +587,12 @@ static sasl_auxprop_plug_t slap_auxprop_plugin = {
        NULL,   /* auxprop_free */
        slap_auxprop_lookup,
        "slapd",        /* name */
-       NULL    /* spare */
+#if SASL_VERSION_FULL >= 0x020110
+       slap_auxprop_store      /* the declaration of this member changed
+                                * in cyrus SASL from 2.1.15 to 2.1.16 */
+#else
+       NULL
+#endif
 };
 
 static int
@@ -567,10 +700,12 @@ slap_sasl_checkpass(
                op.o_tmpmfuncs = conn->c_sasl_bindop->o_tmpmfuncs;
                op.o_conn = conn;
                op.o_connid = conn->c_connid;
+               op.o_req_dn = op.o_req_ndn;
                op.ors_scope = LDAP_SCOPE_BASE;
                op.ors_deref = LDAP_DEREF_NEVER;
                op.ors_slimit = 1;
                op.ors_filter = &generic_filter;
+               op.ors_filterstr = generic_filterstr;
 
                op.o_bd->be_search( &op, &rs );
        }
@@ -729,7 +864,7 @@ slap_sasl_authorize(
                "slap_sasl_authorize: conn %d authcid=\"%s\" authzid=\"%s\"\n",
                conn ? conn->c_connid : -1, auth_identity, requested_user);
 #else
-       Debug( LDAP_DEBUG_ARGS, "SASL Authorize [conn=%ld]: "
+       Debug( LDAP_DEBUG_ARGS, "SASL proxy authorize [conn=%ld]: "
                "authcid=\"%s\" authzid=\"%s\"\n",
                conn ? conn->c_connid : -1, auth_identity, requested_user );
 #endif
@@ -752,16 +887,17 @@ slap_sasl_authorize(
        
        AC_MEMCPY( &authzDN, auxvals[1].values[0], sizeof(authzDN) );
 
-       rc = slap_sasl_authorized( conn, &authcDN, &authzDN );
+       rc = slap_sasl_authorized( conn->c_sasl_bindop, &authcDN, &authzDN );
        ch_free( authcDN.bv_val );
        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( TRANSPORT, INFO, 
-                       "slap_sasl_authorize: conn %ld  authorization disallowed (%d)\n",
+                       "slap_sasl_authorize: conn %ld "
+                       "proxy authorization disallowed (%d)\n",
                        (long)(conn ? conn->c_connid : -1), rc, 0 );
 #else
-               Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
-                       " authorization disallowed (%d)\n",
+               Debug( LDAP_DEBUG_TRACE, "SASL Proxy Authorize [conn=%ld]: "
+                       "proxy authorization disallowed (%d)\n",
                        (long) (conn ? conn->c_connid : -1), rc, 0 );
 #endif
 
@@ -781,11 +917,11 @@ ok:
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
-               "slap_sasl_authorize: conn %d authorization allowed\n",
+               "slap_sasl_authorize: conn %d proxy authorization allowed\n",
                (long)(conn ? conn->c_connid : -1), 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
-               " authorization allowed\n",
+               " proxy authorization allowed\n",
                (long) (conn ? conn->c_connid : -1), 0, 0 );
 #endif
        return SASL_OK;
@@ -825,7 +961,7 @@ slap_sasl_authorize(
 #endif
 
        /* Figure out how much data we have for the dn */
-       rc = sasl_getprop( conn->c_sasl_context, SASL_REALM, (void **)&realm );
+       rc = sasl_getprop( conn->c_sasl_authctx, SASL_REALM, (void **)&realm );
        if( rc != SASL_OK && rc != SASL_NOTDONE ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( TRANSPORT, ERR,
@@ -867,16 +1003,17 @@ slap_sasl_authorize(
                return SASL_NOAUTHZ;
        }
 
-       rc = slap_sasl_authorized(conn, &authcDN, &authzDN );
+       rc = slap_sasl_authorized(conn->c_sasl_bindop, &authcDN, &authzDN );
        ch_free( authcDN.bv_val );
        if( rc ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( TRANSPORT, INFO, 
-                       "slap_sasl_authorize: conn %ld  authorization disallowed (%d)\n",
+                       "slap_sasl_authorize: conn %ld "
+                       "proxy authorization disallowed (%d)\n",
                        (long)(conn ? conn->c_connid : -1), rc, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
-                       " authorization disallowed (%d)\n",
+                       "proxy authorization disallowed (%d)\n",
                        (long) (conn ? conn->c_connid : -1), rc, 0 );
 #endif
 
@@ -889,7 +1026,7 @@ slap_sasl_authorize(
 ok:
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, RESULTS, 
-               "slap_sasl_authorize: conn %d authorization allowed\n",
+               "slap_sasl_authorize: conn %d proxy authorization allowed\n",
           (long)(conn ? conn->c_connid : -1 ), 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
@@ -959,21 +1096,28 @@ int slap_sasl_init( void )
        };
 
 #ifdef HAVE_SASL_VERSION
-#define SASL_BUILD_VERSION ((SASL_VERSION_MAJOR << 24) |\
-       (SASL_VERSION_MINOR << 16) | SASL_VERSION_STEP)
+       /* stringify the version number, sasl.h doesn't do it for us */
+#define        VSTR0(maj, min, pat)    #maj "." #min "." #pat
+#define        VSTR(maj, min, pat)     VSTR0(maj, min, pat)
+#define        SASL_VERSION_STRING     VSTR(SASL_VERSION_MAJOR, SASL_VERSION_MINOR, \
+                               SASL_VERSION_STEP)
 
        sasl_version( NULL, &rc );
        if ( ((rc >> 16) != ((SASL_VERSION_MAJOR << 8)|SASL_VERSION_MINOR)) ||
                (rc & 0xffff) < SASL_VERSION_STEP) {
-
+               char version[sizeof("xxx.xxx.xxxxx")];
+               sprintf( version, "%u.%d.%d", (unsigned)rc >> 24, (rc >> 16) & 0xff,
+                       rc & 0xffff );
 #ifdef NEW_LOGGING
                LDAP_LOG( TRANSPORT, INFO,
-               "slap_sasl_init: SASL version mismatch, got %x, wanted %x.\n",
-                       rc, SASL_BUILD_VERSION, 0 );
+               "slap_sasl_init: SASL library version mismatch:"
+               " expected " SASL_VERSION_STRING ","
+               " got %s\n", version, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
-               "slap_sasl_init: SASL version mismatch, got %x, wanted %x.\n",
-                       rc, SASL_BUILD_VERSION, 0 );
+               "slap_sasl_init: SASL library version mismatch:"
+               " expected " SASL_VERSION_STRING ","
+               " got %s\n", version, 0, 0 );
 #endif
                return -1;
        }
@@ -1047,7 +1191,7 @@ int slap_sasl_destroy( void )
        return 0;
 }
 
-int slap_sasl_open( Connection *conn )
+int slap_sasl_open( Connection *conn, int reopen )
 {
        int cb, sc = LDAP_SUCCESS;
 #if SASL_VERSION_MAJOR >= 2
@@ -1058,18 +1202,18 @@ int slap_sasl_open( Connection *conn )
        sasl_conn_t *ctx = NULL;
        sasl_callback_t *session_callbacks;
 
-       assert( conn->c_sasl_context == NULL );
-       assert( conn->c_sasl_extra == NULL );
+       assert( conn->c_sasl_authctx == NULL );
 
-       conn->c_sasl_layers = 0;
+       if ( !reopen ) {
+               assert( conn->c_sasl_extra == NULL );
 
-       session_callbacks =
+               session_callbacks =
 #if SASL_VERSION_MAJOR >= 2
-               SLAP_CALLOC( 5, sizeof(sasl_callback_t));
+                       SLAP_CALLOC( 5, sizeof(sasl_callback_t));
 #else
-               SLAP_CALLOC( 3, sizeof(sasl_callback_t));
+                       SLAP_CALLOC( 3, sizeof(sasl_callback_t));
 #endif
-       if( session_callbacks == NULL ) {
+               if( session_callbacks == NULL ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG( TRANSPORT, ERR, 
                                "slap_sasl_open: SLAP_MALLOC failed", 0, 0, 0 );
@@ -1078,31 +1222,36 @@ int slap_sasl_open( Connection *conn )
                                "slap_sasl_open: SLAP_MALLOC failed", 0, 0, 0 );
 #endif
                        return -1;
-       }
-       conn->c_sasl_extra = session_callbacks;
+               }
+               conn->c_sasl_extra = session_callbacks;
 
-       session_callbacks[cb=0].id = SASL_CB_LOG;
-       session_callbacks[cb].proc = &slap_sasl_log;
-       session_callbacks[cb++].context = conn;
+               session_callbacks[cb=0].id = SASL_CB_LOG;
+               session_callbacks[cb].proc = &slap_sasl_log;
+               session_callbacks[cb++].context = conn;
 
-       session_callbacks[cb].id = SASL_CB_PROXY_POLICY;
-       session_callbacks[cb].proc = &slap_sasl_authorize;
-       session_callbacks[cb++].context = conn;
+               session_callbacks[cb].id = SASL_CB_PROXY_POLICY;
+               session_callbacks[cb].proc = &slap_sasl_authorize;
+               session_callbacks[cb++].context = conn;
 
 #if SASL_VERSION_MAJOR >= 2
-       session_callbacks[cb].id = SASL_CB_CANON_USER;
-       session_callbacks[cb].proc = &slap_sasl_canonicalize;
-       session_callbacks[cb++].context = conn;
-
-       /* XXXX: this should be conditional */
-       session_callbacks[cb].id = SASL_CB_SERVER_USERDB_CHECKPASS;
-       session_callbacks[cb].proc = &slap_sasl_checkpass;
-       session_callbacks[cb++].context = conn;
+               session_callbacks[cb].id = SASL_CB_CANON_USER;
+               session_callbacks[cb].proc = &slap_sasl_canonicalize;
+               session_callbacks[cb++].context = conn;
+
+               /* XXXX: this should be conditional */
+               session_callbacks[cb].id = SASL_CB_SERVER_USERDB_CHECKPASS;
+               session_callbacks[cb].proc = &slap_sasl_checkpass;
+               session_callbacks[cb++].context = conn;
 #endif
 
-       session_callbacks[cb].id = SASL_CB_LIST_END;
-       session_callbacks[cb].proc = NULL;
-       session_callbacks[cb++].context = NULL;
+               session_callbacks[cb].id = SASL_CB_LIST_END;
+               session_callbacks[cb].proc = NULL;
+               session_callbacks[cb++].context = NULL;
+       } else {
+               session_callbacks = conn->c_sasl_extra;
+       }
+
+       conn->c_sasl_layers = 0;
 
        if( global_host == NULL ) {
                global_host = ldap_pvt_get_fqdn( NULL );
@@ -1161,7 +1310,7 @@ int slap_sasl_open( Connection *conn )
                return -1;
        }
 
-       conn->c_sasl_context = ctx;
+       conn->c_sasl_authctx = ctx;
 
        if( sc == SASL_OK ) {
                sc = sasl_setprop( ctx,
@@ -1193,7 +1342,7 @@ int slap_sasl_external(
 {
 #if SASL_VERSION_MAJOR >= 2
        int sc;
-       sasl_conn_t *ctx = conn->c_sasl_context;
+       sasl_conn_t *ctx = conn->c_sasl_authctx;
 
        if ( ctx == NULL ) {
                return LDAP_UNAVAILABLE;
@@ -1213,7 +1362,7 @@ int slap_sasl_external(
 
 #elif defined(HAVE_CYRUS_SASL)
        int sc;
-       sasl_conn_t *ctx = conn->c_sasl_context;
+       sasl_conn_t *ctx = conn->c_sasl_authctx;
        sasl_external_properties_t extprops;
 
        if ( ctx == NULL ) {
@@ -1237,32 +1386,7 @@ int slap_sasl_external(
 
 int slap_sasl_reset( Connection *conn )
 {
-       int rc = LDAP_SUCCESS;
-#ifdef HAVE_CYRUS_SASL
-       sasl_conn_t *ctx = conn->c_sasl_context;
-       slap_ssf_t ssf = 0;
-       const char *authid = NULL;
-#if SASL_VERSION_MAJOR >= 2
-       sasl_getprop( ctx, SASL_SSF_EXTERNAL, &ssf );
-       sasl_getprop( ctx, SASL_AUTH_EXTERNAL, &authid );
-       if ( authid ) authid = ch_strdup( authid );
-#else
-       /* we can't retrieve the external properties from SASL 1.5.
-        * we can get it again from the underlying TLS or IPC connection,
-        * but it's simpler just to ignore it since 1.5 is obsolete.
-        */
-#endif
-       rc = slap_sasl_close( conn );
-       ldap_pvt_sasl_remove( conn->c_sb );
-       if ( rc == LDAP_SUCCESS ) {
-               rc = slap_sasl_open( conn );
-       }
-       if ( rc == LDAP_SUCCESS ) {
-               rc = slap_sasl_external( conn, ssf, authid );
-       }
-       if ( authid ) ch_free( authid );
-#endif
-       return rc;
+       return LDAP_SUCCESS;
 }
 
 char ** slap_sasl_mechs( Connection *conn )
@@ -1270,7 +1394,9 @@ char ** slap_sasl_mechs( Connection *conn )
        char **mechs = NULL;
 
 #ifdef HAVE_CYRUS_SASL
-       sasl_conn_t *ctx = conn->c_sasl_context;
+       sasl_conn_t *ctx = conn->c_sasl_authctx;
+
+       if( ctx == NULL ) ctx = conn->c_sasl_sockctx;
 
        if( ctx != NULL ) {
                int sc;
@@ -1306,13 +1432,19 @@ char ** slap_sasl_mechs( Connection *conn )
 int slap_sasl_close( Connection *conn )
 {
 #ifdef HAVE_CYRUS_SASL
-       sasl_conn_t *ctx = conn->c_sasl_context;
+       sasl_conn_t *ctx = conn->c_sasl_authctx;
 
        if( ctx != NULL ) {
                sasl_dispose( &ctx );
        }
+       if ( conn->c_sasl_sockctx && conn->c_sasl_authctx != conn->c_sasl_sockctx ) {
+               ctx = conn->c_sasl_sockctx;
+               sasl_dispose( &ctx );
+       }
 
-       conn->c_sasl_context = NULL;
+       conn->c_sasl_authctx = NULL;
+       conn->c_sasl_sockctx = NULL;
+       conn->c_sasl_done = 0;
 
        free( conn->c_sasl_extra );
        conn->c_sasl_extra = NULL;
@@ -1324,7 +1456,7 @@ int slap_sasl_close( Connection *conn )
 int slap_sasl_bind( Operation *op, SlapReply *rs )
 {
 #ifdef HAVE_CYRUS_SASL
-       sasl_conn_t *ctx = op->o_conn->c_sasl_context;
+       sasl_conn_t *ctx = op->o_conn->c_sasl_authctx;
        struct berval response;
        unsigned reslen = 0;
        int sc;
@@ -1365,6 +1497,30 @@ int slap_sasl_bind( Operation *op, SlapReply *rs )
 #endif
 
        if ( !op->o_conn->c_sasl_bind_in_progress ) {
+               /* If we already authenticated once, must use a new context */
+               if ( op->o_conn->c_sasl_done ) {
+                       slap_ssf_t ssf = 0;
+                       const char *authid = NULL;
+#if SASL_VERSION_MAJOR >= 2
+                       sasl_getprop( ctx, SASL_SSF_EXTERNAL, (void *)&ssf );
+                       sasl_getprop( ctx, SASL_AUTH_EXTERNAL, (void *)&authid );
+                       if ( authid ) authid = ch_strdup( authid );
+#endif
+                       if ( ctx != op->o_conn->c_sasl_sockctx ) {
+                               sasl_dispose( &ctx );
+                       }
+                       op->o_conn->c_sasl_authctx = NULL;
+                               
+                       slap_sasl_open( op->o_conn, 1 );
+                       ctx = op->o_conn->c_sasl_authctx;
+#if SASL_VERSION_MAJOR >= 2
+                       if ( authid ) {
+                               sasl_setprop( ctx, SASL_SSF_EXTERNAL, &ssf );
+                               sasl_setprop( ctx, SASL_AUTH_EXTERNAL, authid );
+                               ch_free( (char *)authid );
+                       }
+#endif
+               }
                sc = START( ctx,
                        op->o_conn->c_sasl_bind_mech.bv_val,
                        op->orb_cred.bv_val, op->orb_cred.bv_len,
@@ -1384,21 +1540,47 @@ int slap_sasl_bind( Operation *op, SlapReply *rs )
                op->orb_edn = op->o_conn->c_sasl_dn;
                op->o_conn->c_sasl_dn.bv_val = NULL;
                op->o_conn->c_sasl_dn.bv_len = 0;
+               op->o_conn->c_sasl_done = 1;
 
                rs->sr_err = LDAP_SUCCESS;
 
                (void) sasl_getprop( ctx, SASL_SSF, (void *)&ssf );
                op->orb_ssf = ssf ? *ssf : 0;
 
+               ctx = NULL;
                if( op->orb_ssf ) {
                        ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
                        op->o_conn->c_sasl_layers++;
+
+                       /* If there's an old layer, set sockctx to NULL to
+                        * tell connection_read() to wait for us to finish.
+                        * Otherwise there is a race condition: we have to
+                        * send the Bind response using the old security
+                        * context and then remove it before reading any
+                        * new messages.
+                        */
+                       if ( op->o_conn->c_sasl_sockctx ) {
+                               ctx = op->o_conn->c_sasl_sockctx;
+                               op->o_conn->c_sasl_sockctx = NULL;
+                       } else {
+                               op->o_conn->c_sasl_sockctx = op->o_conn->c_sasl_authctx;
+                       }
                        ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
                }
 
+               /* Must send response using old security layer */
                if (response.bv_len) rs->sr_sasldata = &response;
                send_ldap_sasl( op, rs );
-
+               
+               /* Now dispose of the old security layer.
+                */
+               if ( ctx ) {
+                       ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
+                       ldap_pvt_sasl_remove( op->o_conn->c_sb );
+                       op->o_conn->c_sasl_sockctx = op->o_conn->c_sasl_authctx;
+                       ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
+                       sasl_dispose( &ctx );
+               }
        } else if ( sc == SASL_CONTINUE ) {
                rs->sr_err = LDAP_SASL_BIND_IN_PROGRESS,
                rs->sr_sasldata = &response;
@@ -1454,7 +1636,7 @@ slap_sasl_setpass( Operation *op, SlapReply *rs )
 
        assert( ber_bvcmp( &slap_EXOP_MODIFY_PASSWD, &op->ore_reqoid ) == 0 );
 
-       rs->sr_err = sasl_getprop( op->o_conn->c_sasl_context, SASL_USERNAME,
+       rs->sr_err = sasl_getprop( op->o_conn->c_sasl_authctx, SASL_USERNAME,
                (SASL_CONST void **)&id.bv_val );
 
        if( rs->sr_err != SASL_OK ) {
@@ -1492,13 +1674,13 @@ slap_sasl_setpass( Operation *op, SlapReply *rs )
        }
 
 #if SASL_VERSION_MAJOR < 2
-       rs->sr_err = sasl_setpass( op->o_conn->c_sasl_context,
+       rs->sr_err = sasl_setpass( op->o_conn->c_sasl_authctx,
                id.bv_val, new.bv_val, new.bv_len, 0, &rs->sr_text );
 #else
-       rs->sr_err = sasl_setpass( op->o_conn->c_sasl_context, id.bv_val,
+       rs->sr_err = sasl_setpass( op->o_conn->c_sasl_authctx, id.bv_val,
                new.bv_val, new.bv_len, old.bv_val, old.bv_len, 0 );
        if( rs->sr_err != SASL_OK ) {
-               rs->sr_text = sasl_errdetail( op->o_conn->c_sasl_context );
+               rs->sr_text = sasl_errdetail( op->o_conn->c_sasl_authctx );
        }
 #endif
        switch(rs->sr_err) {
@@ -1522,14 +1704,12 @@ done:
 #endif /* HAVE_CYRUS_SASL */
 
 /* Take any sort of identity string and return a DN with the "dn:" prefix. The
-   string returned in *dn is in its own allocated memory, and must be free'd 
-   by the calling process.
-   -Mark Adamson, Carnegie Mellon
-
-   The "dn:" prefix is no longer used anywhere inside slapd. It is only used
-   on strings passed in directly from SASL.
-   -Howard Chu, Symas Corp.
-*/
+ * string returned in *dn is in its own allocated memory, and must be free'd 
+ * by the calling process.  -Mark Adamson, Carnegie Mellon
+ *
+ * The "dn:" prefix is no longer used anywhere inside slapd. It is only used
+ * on strings passed in directly from SASL.  -Howard Chu, Symas Corp.
+ */
 
 #define SET_NONE       0
 #define        SET_DN          1