]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/sasl.c
protect gecos from overflow
[openldap] / servers / slapd / sasl.c
index 13088088afe0de9f69dfad6fecea924867969f29..756ae1187beef67aa04c8f65909902af918525db 100644 (file)
@@ -24,8 +24,8 @@
 #include <sasl.h>
 #endif
 
-#if SASL_VERSION_MAJOR >= 2
 #include <lutil.h>
+#if SASL_VERSION_MAJOR >= 2
 #include <sasl/saslplug.h>
 #define        SASL_CONST const
 #else
 
 #include <ldap_pvt.h>
 
-#ifdef SLAPD_SPASSWD
-#include <lutil.h>
-#endif
-
 /* Flags for telling slap_sasl_getdn() what type of identity is being passed */
 #define FLAG_GETDN_AUTHCID 2
 #define FLAG_GETDN_AUTHZID 4
@@ -51,9 +47,9 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                if ( strcasecmp( cargv[0], "sasl-authz-policy" ) == 0 ) {
                        if ( cargc != 2 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: missing policy in \"sasl-authz-policy <policy>\" line\n",
-                                          fname, lineno ));
+                                          fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
            "%s: line %d: missing policy in \"sasl-authz-policy <policy>\" line\n",
@@ -64,12 +60,12 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                        }
                        if ( slap_sasl_setpolicy( cargv[1] ) ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: unable "
                                           "to parse value \"%s\" "
                                           "in \"sasl-authz-policy "
                                           "<policy>\" line.\n",
-                                          fname, lineno, cargv[1] ));
+                                          fname, lineno, cargv[1] );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "%s: line %d: unable "
@@ -86,9 +82,9 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                } else if ( strcasecmp( cargv[0], "sasl-host" ) == 0 ) {
                        if ( cargc < 2 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: missing host in \"sasl-host <host>\" line\n",
-                                          fname, lineno ));
+                                          fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
            "%s: line %d: missing host in \"sasl-host <host>\" line\n",
@@ -100,9 +96,9 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
 
                        if ( global_host != NULL ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: already set sasl-host!\n",
-                                          fname, lineno ));
+                                          fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "%s: line %d: already set sasl-host!\n",
@@ -119,9 +115,9 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                } else if ( strcasecmp( cargv[0], "sasl-realm" ) == 0 ) {
                        if ( cargc < 2 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: missing realm in \"sasl-realm <realm>\" line.\n",
-                                          fname, lineno ));
+                                          fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
            "%s: line %d: missing realm in \"sasl-realm <realm>\" line\n",
@@ -133,9 +129,9 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
 
                        if ( global_realm != NULL ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: already set sasl-realm!\n",
-                                          fname, lineno ));
+                                          fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "%s: line %d: already set sasl-realm!\n",
@@ -154,10 +150,10 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                        int rc;
                        if ( cargc != 3 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: need 2 args in "
                                           "\"saslregexp <match> <replace>\"\n",
-                                          fname, lineno ));
+                                          fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY, 
                                "%s: line %d: need 2 args in \"saslregexp <match> <replace>\"\n",
@@ -177,10 +173,10 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
 
                        if ( cargc < 2 ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d: missing flags in "
                                           "\"sasl-secprops <properties>\" line\n",
-                                          fname, lineno ));
+                                          fname, lineno, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
            "%s: line %d: missing flags in \"sasl-secprops <properties>\" line\n",
@@ -193,9 +189,9 @@ int slap_sasl_config( int cargc, char **cargv, char *line,
                        txt = slap_sasl_secprops( cargv[1] );
                        if ( txt != NULL ) {
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "config", LDAP_LEVEL_CRIT,
+                               LDAP_LOG( CONFIG, CRIT,
                                           "%s: line %d sasl-secprops: %s\n",
-                                          fname, lineno, txt ));
+                                          fname, lineno, txt );
 #else
                                Debug( LDAP_DEBUG_ANY,
            "%s: line %d: sasl-secprops: %s\n",
@@ -276,10 +272,8 @@ slap_sasl_log(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "SASL [conn=%ld] %s: %s\n",
-               conn ? conn->c_connid : -1,
-               label, message ));
+       LDAP_LOG( TRANSPORT, ENTRY, 
+               "SASL [conn=%ld] %s: %s\n", conn ? conn->c_connid : -1, label, message);
 #else
        Debug( level, "SASL [conn=%ld] %s: %s\n",
                conn ? conn->c_connid: -1,
@@ -315,10 +309,9 @@ int slap_sasl_getdn( Connection *conn, char *id, int len,
        struct berval dn2;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
+       LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_getdn: conn %d id=%s\n",
-               conn ? conn->c_connid : -1,
-               id ? (*id ? id : "<empty>") : "NULL" ));
+               conn ? conn->c_connid : -1, id ? (*id ? id : "<empty>") : "NULL", 0 );
 #else
        Debug( LDAP_DEBUG_ARGS, "slap_sasl_getdn: id=%s\n", 
       id?(*id?id:"<empty>"):"NULL",0,0 );
@@ -389,7 +382,7 @@ int slap_sasl_getdn( Connection *conn, char *id, int len,
                len = dn->bv_len + sizeof("uid=")-1 + sizeof(",cn=auth")-1;
 
                /* username may have embedded realm name */
-               if( realm = strchr( dn->bv_val, '@') ) {
+               if( ( realm = strchr( dn->bv_val, '@') ) ) {
                        *realm++ = '\0';
                        len += sizeof(",cn=")-2;
                } else if( user_realm && *user_realm ) {
@@ -403,29 +396,29 @@ int slap_sasl_getdn( Connection *conn, char *id, int len,
                /* Build the new dn */
                c1 = dn->bv_val;
                dn->bv_val = ch_malloc( len+1 );
-               p = slap_strcopy( dn->bv_val, "uid=" );
-               p = slap_strncopy( p, c1, dn->bv_len );
+               p = lutil_strcopy( dn->bv_val, "uid=" );
+               p = lutil_strncopy( p, c1, dn->bv_len );
 
                if( realm ) {
                        int rlen = dn->bv_len - ( realm - c1 );
-                       p = slap_strcopy( p, ",cn=" );
-                       p = slap_strncopy( p, realm, rlen );
+                       p = lutil_strcopy( p, ",cn=" );
+                       p = lutil_strncopy( p, realm, rlen );
                        realm[-1] = '@';
                } else if( user_realm && *user_realm ) {
-                       p = slap_strcopy( p, ",cn=" );
-                       p = slap_strcopy( p, user_realm );
+                       p = lutil_strcopy( p, ",cn=" );
+                       p = lutil_strcopy( p, user_realm );
                }
 
                if( conn->c_sasl_bind_mech.bv_len ) {
-                       p = slap_strcopy( p, ",cn=" );
-                       p = slap_strcopy( p, conn->c_sasl_bind_mech.bv_val );
+                       p = lutil_strcopy( p, ",cn=" );
+                       p = lutil_strcopy( p, conn->c_sasl_bind_mech.bv_val );
                }
-               p = slap_strcopy( p, ",cn=auth" );
+               p = lutil_strcopy( p, ",cn=auth" );
                dn->bv_len = p - dn->bv_val;
 
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                       "slap_sasl_getdn: u:id converted to %s.\n", dn->bv_val ));
+               LDAP_LOG( TRANSPORT, ENTRY, 
+                       "slap_sasl_getdn: u:id converted to %s.\n", dn->bv_val, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "getdn: u:id converted to %s\n", dn->bv_val,0,0 );
 #endif
@@ -453,8 +446,8 @@ int slap_sasl_getdn( Connection *conn, char *id, int len,
                ch_free( dn->bv_val );
                *dn = dn2;
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                       "slap_sasl_getdn: dn:id converted to %s.\n", dn->bv_val ));
+               LDAP_LOG( TRANSPORT, ENTRY, 
+                       "slap_sasl_getdn: dn:id converted to %s.\n", dn->bv_val, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "getdn: dn:id converted to %s\n",
                        dn->bv_val, 0, 0 );
@@ -465,7 +458,77 @@ int slap_sasl_getdn( Connection *conn, char *id, int len,
 }
 
 #if SASL_VERSION_MAJOR >= 2
-static const char *slap_propnames[] = { "*authcDN", "*authzDN", NULL };
+static const char *slap_propnames[] = {
+       "*slapConn", "*authcDN", "*authzDN", NULL };
+
+static Filter *generic_filter;
+
+#define        PROP_CONN       0
+#define        PROP_AUTHC      1
+#define        PROP_AUTHZ      2
+
+typedef struct lookup_info {
+       int last;
+       int flags;
+       const struct propval *list;
+       sasl_server_params_t *sparams;
+} lookup_info;
+
+static int
+sasl_ap_lookup(
+       BackendDB *be,
+       Connection *conn,
+       Operation *op,
+       Entry *e,
+       AttributeName *an,
+       int attrsonly,
+       LDAPControl **ctrls )
+{
+       BerVarray bv;
+       AttributeDescription *ad;
+       Attribute *a;
+       const char *text;
+       int rc, i;
+       slap_callback *tmp = op->o_callback;
+       lookup_info *sl = tmp->sc_private;
+
+       for( i = 0; i < sl->last; i++ ) {
+               const char *name = sl->list[i].name;
+
+               if ( name[0] == '*' ) {
+                       if ( sl->flags & SASL_AUXPROP_AUTHZID ) continue;
+                       name++;
+               } else if ( !(sl->flags & SASL_AUXPROP_AUTHZID ) )
+                       continue;
+
+               if ( sl->list[i].values ) {
+                       if ( !(sl->flags & SASL_AUXPROP_OVERRIDE) ) continue;
+               }
+               ad = NULL;
+               rc = slap_str2ad( name, &ad, &text );
+               if ( rc != LDAP_SUCCESS ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG( TRANSPORT, DETAIL1, 
+                               "slap_auxprop: str2ad(%s): %s\n", name, text, 0 );
+#else
+                       Debug( LDAP_DEBUG_TRACE,
+                               "slap_auxprop: str2ad(%s): %s\n", name, text, 0 );
+#endif
+                       continue;
+               }
+               a = attr_find( e->e_attrs, ad );
+               if ( !a ) continue;
+               if ( ! access_allowed( be, conn, op, e, ad, NULL, ACL_AUTH, NULL ) )
+                       continue;
+               if ( sl->list[i].values && ( sl->flags & SASL_AUXPROP_OVERRIDE ) )
+                       sl->sparams->utils->prop_erase( sl->sparams->propctx, sl->list[i].name );
+               for ( bv = a->a_vals; bv->bv_val; bv++ ) {
+                       sl->sparams->utils->prop_set( sl->sparams->propctx, sl->list[i].name,
+                               bv->bv_val, bv->bv_len );
+               }
+       }
+       return LDAP_SUCCESS;
+}
 
 static void
 slap_auxprop_lookup(
@@ -475,29 +538,35 @@ slap_auxprop_lookup(
        const char *user,
        unsigned ulen)
 {
-       int rc, i, last;
+       int rc, i, doit=0;
        struct berval dn;
-       const struct propval *list;
-       BerVarray vals, bv;
-       AttributeDescription *ad;
-       const char *text;
-
-       list = sparams->utils->prop_get( sparams->propctx );
-
-       /* Find our DN first */
-       for( i = 0, last = 0; list[i].name; i++ ) {
-               if ( list[i].name[0] == '*' ) {
+       Connection *conn = NULL;
+       lookup_info sl;
+
+       sl.list = sparams->utils->prop_get( sparams->propctx );
+       sl.sparams = sparams;
+       sl.flags = flags;
+
+       /* Find our DN and conn first */
+       for( i = 0, sl.last = 0; sl.list[i].name; i++ ) {
+               if ( sl.list[i].name[0] == '*' ) {
+                       if ( !strcmp( sl.list[i].name, slap_propnames[PROP_CONN] ) ) {
+                               if ( sl.list[i].values && sl.list[i].values[0] )
+                                       AC_MEMCPY( &conn, sl.list[i].values[0], sizeof( conn ) );
+                               if ( !sl.last ) sl.last = i;
+                       }
                        if ( (flags & SASL_AUXPROP_AUTHZID) &&
-                               !strcmp( list[i].name, slap_propnames[1] ) ) {
-                               if ( list[i].values && list[i].values[0] )
-                                       AC_MEMCPY( &dn, list[i].values[0], sizeof( dn ) );
-                               if ( !last ) last = i;
+                               !strcmp( sl.list[i].name, slap_propnames[PROP_AUTHZ] ) ) {
+
+                               if ( sl.list[i].values && sl.list[i].values[0] )
+                                       AC_MEMCPY( &dn, sl.list[i].values[0], sizeof( dn ) );
+                               if ( !sl.last ) sl.last = i;
                                break;
                        }
-                       if ( !strcmp( list[i].name, slap_propnames[0] ) ) {
-                               if ( !last ) last = i;
-                               if ( list[i].values && list[i].values[0] ) {
-                                       AC_MEMCPY( &dn, list[i].values[0], sizeof( dn ) );
+                       if ( !strcmp( sl.list[i].name, slap_propnames[PROP_AUTHC] ) ) {
+                               if ( !sl.last ) sl.last = i;
+                               if ( sl.list[i].values && sl.list[i].values[0] ) {
+                                       AC_MEMCPY( &dn, sl.list[i].values[0], sizeof( dn ) );
                                        if ( !(flags & SASL_AUXPROP_AUTHZID) )
                                                break;
                                }
@@ -505,9 +574,9 @@ slap_auxprop_lookup(
                }
        }
 
-       /* Now fetch the rest */
-       for( i = 0; i < last; i++ ) {
-               const char *name = list[i].name;
+       /* Now see what else needs to be fetched */
+       for( i = 0; i < sl.last; i++ ) {
+               const char *name = sl.list[i].name;
 
                if ( name[0] == '*' ) {
                        if ( flags & SASL_AUXPROP_AUTHZID ) continue;
@@ -515,30 +584,34 @@ slap_auxprop_lookup(
                } else if ( !(flags & SASL_AUXPROP_AUTHZID ) )
                        continue;
 
-               if ( list[i].values ) {
+               if ( sl.list[i].values ) {
                        if ( !(flags & SASL_AUXPROP_OVERRIDE) ) continue;
-                       sparams->utils->prop_erase( sparams->propctx, list[i].name );
                }
-               ad = NULL;
-               rc = slap_str2ad( name, &ad, &text );
-               if ( rc != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                       LDAP_LOG(( "sasl", LDAP_LEVEL_DETAIL1,
-                               "slap_auxprop: str2ad(%s): %s\n", name, text ));
-#else
-                       Debug( LDAP_DEBUG_TRACE,
-                               "slap_auxprop: str2ad(%s): %s\n", name, text, 0 );
-#endif
-                       rc = slap_str2undef_ad( name, &ad, &text );
-                       if ( rc != LDAP_SUCCESS ) continue;
-               }
-               rc = backend_attribute( NULL,NULL,NULL,NULL, &dn, ad, &vals );
-               if ( rc != LDAP_SUCCESS ) continue;
-               for ( bv = vals; bv->bv_val; bv++ ) {
-                       sparams->utils->prop_set( sparams->propctx, list[i].name,
-                               bv->bv_val, bv->bv_len );
+               doit = 1;
+       }
+
+       if (doit) {
+               Backend *be;
+               Operation op = {0};
+               slap_callback cb = { slap_cb_null_response,
+                       slap_cb_null_sresult, sasl_ap_lookup, NULL };
+
+               cb.sc_private = &sl;
+
+               be = select_backend( &dn, 0, 1 );
+
+               if ( be && be->be_search ) {
+                       op.o_tag = LDAP_REQ_SEARCH;
+                       op.o_protocol = LDAP_VERSION3;
+                       op.o_ndn = conn->c_ndn;
+                       op.o_callback = &cb;
+                       op.o_time = slap_get_time();
+                       op.o_do_not_cache = 1;
+
+                       (*be->be_search)( be, conn, &op, NULL, &dn,
+                               LDAP_SCOPE_BASE, LDAP_DEREF_NEVER, 1, 0,
+                               generic_filter, NULL, NULL, 0 );
                }
-               ber_bvarray_free( vals );
        }
 }
 
@@ -569,6 +642,42 @@ slap_auxprop_init(
        return SASL_OK;
 }
 
+typedef struct checkpass_info {
+       int rc;
+       struct berval cred;
+} checkpass_info;
+
+static int
+sasl_cb_checkpass(
+       BackendDB *be,
+       Connection *conn,
+       Operation *op,
+       Entry *e,
+       AttributeName *an,
+       int attrsonly,
+       LDAPControl **ctrls )
+{
+       slap_callback *tmp = op->o_callback;
+       checkpass_info *ci = tmp->sc_private;
+       Attribute *a;
+       struct berval *bv;
+       
+       ci->rc = SASL_NOVERIFY;
+
+       a = attr_find( e->e_attrs, slap_schema.si_ad_userPassword );
+       if ( !a ) return 0;
+       if ( ! access_allowed( be, conn, op, e, slap_schema.si_ad_userPassword,
+               NULL, ACL_AUTH, NULL ) ) return 0;
+
+       for ( bv = a->a_vals; bv->bv_val != NULL; bv++ ) {
+               if ( !lutil_passwd( bv, &ci->cred, NULL ) ) {
+                       ci->rc = SASL_OK;
+                       break;
+               }
+       }
+       return 0;
+}
+
 static int
 slap_sasl_checkpass(
        sasl_conn_t *sconn,
@@ -579,12 +688,12 @@ slap_sasl_checkpass(
        struct propctx *propctx)
 {
        Connection *conn = (Connection *)context;
-       struct berval dn, cred;
+       struct berval dn;
        int rc;
-       BerVarray vals, bv;
+       Backend *be;
+       checkpass_info ci;
 
-       cred.bv_val = (char *)pass;
-       cred.bv_len = passlen;
+       ci.rc = SASL_NOUSER;
 
        /* SASL will fallback to its own mechanisms if we don't
         * find an answer here.
@@ -606,34 +715,35 @@ slap_sasl_checkpass(
                return SASL_NOUSER;
        }
 
-       rc = backend_attribute( NULL, NULL, NULL, NULL, &dn,
-               slap_schema.si_ad_userPassword, &vals);
-       if ( rc != LDAP_SUCCESS ) {
-               ch_free( dn.bv_val );
-               sasl_seterror( sconn, 0, ldap_err2string( rc ) );
-               return SASL_NOVERIFY;
+       be = select_backend( &dn, 0, 1 );
+       if ( be && be->be_search ) {
+               Operation op = {0};
+               slap_callback cb = { slap_cb_null_response,
+                       slap_cb_null_sresult, sasl_cb_checkpass, NULL };
+
+               ci.cred.bv_val = (char *)pass;
+               ci.cred.bv_len = passlen;
+
+               cb.sc_private = &ci;
+               op.o_tag = LDAP_REQ_SEARCH;
+               op.o_protocol = LDAP_VERSION3;
+               op.o_ndn = conn->c_ndn;
+               op.o_callback = &cb;
+               op.o_time = slap_get_time();
+               op.o_do_not_cache = 1;
+
+               (*be->be_search)( be, conn, &op, NULL, &dn,
+                       LDAP_SCOPE_BASE, LDAP_DEREF_NEVER, 1, 0,
+                       generic_filter, NULL, NULL, 0 );
        }
-
-       rc = SASL_NOVERIFY;
-
-       if ( vals != NULL ) {
-               for ( bv = vals; bv->bv_val != NULL; bv++ ) {
-                       if ( !lutil_passwd( bv, &cred, NULL ) ) {
-                               rc = SASL_OK;
-                               break;
-                       }
-               }
-               ber_bvarray_free( vals );
-       }
-
-       if ( rc != SASL_OK ) {
+       if ( ci.rc != SASL_OK ) {
                sasl_seterror( sconn, 0,
                        ldap_err2string( LDAP_INVALID_CREDENTIALS ) );
        }
 
        ch_free( dn.bv_val );
 
-       return rc;
+       return ci.rc;
 }
 
 /* Convert a SASL authcid or authzid into a DN. Store the DN in an
@@ -664,11 +774,10 @@ slap_sasl_canonicalize(
        *out_len = 0;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
+       LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_canonicalize: conn %d %s=\"%s\"\n",
-                       conn ? conn->c_connid : -1,
-                       (flags & SASL_CU_AUTHID) ? "authcid" : "authzid",
-                       in ? in : "<empty>" ));
+               conn ? conn->c_connid : -1,
+               (flags & SASL_CU_AUTHID) ? "authcid" : "authzid", in ? in : "<empty>");
 #else
        Debug( LDAP_DEBUG_ARGS, "SASL Canonicalize [conn=%ld]: "
                "%s=\"%s\"\n",
@@ -689,10 +798,17 @@ slap_sasl_canonicalize(
                prop_request( props, slap_propnames );
 
        if ( flags & SASL_CU_AUTHID )
-               which = 0;
+               which = PROP_AUTHC;
        else
-               which = 1;
+               which = PROP_AUTHZ;
 
+       /* Need to store the Connection for auxprop_lookup */
+       if ( !auxvals[PROP_CONN].values ) {
+               names[0] = slap_propnames[PROP_CONN];
+               names[1] = NULL;
+               prop_set( props, names[0], (char *)&conn, sizeof( conn ) );
+       }
+               
        /* Already been here? */
        if ( auxvals[which].values )
                goto done;
@@ -723,10 +839,9 @@ slap_sasl_canonicalize(
        prop_set( props, names[0], (char *)&dn, sizeof( dn ) );
                
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
+       LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_canonicalize: conn %d %s=\"%s\"\n",
-                       conn ? conn->c_connid : -1,
-                       names[0]+1, dn.bv_val ));
+               conn ? conn->c_connid : -1, names[0]+1, dn.bv_val );
 #else
        Debug( LDAP_DEBUG_ARGS, "SASL Canonicalize [conn=%ld]: "
                "%s=\"%s\"\n",
@@ -759,9 +874,9 @@ slap_sasl_authorize(
        int rc;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
+       LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_authorize: conn %d authcid=\"%s\" authzid=\"%s\"\n",
-                       conn ? conn->c_connid : -1, auth_identity, requested_user));
+               conn ? conn->c_connid : -1, auth_identity, requested_user);
 #else
        Debug( LDAP_DEBUG_ARGS, "SASL Authorize [conn=%ld]: "
                "authcid=\"%s\" authzid=\"%s\"\n",
@@ -773,7 +888,8 @@ slap_sasl_authorize(
                conn->c_sasl_dn.bv_len = 0;
        }
 
-       prop_getnames( props, slap_propnames, auxvals );
+       /* Skip PROP_CONN */
+       prop_getnames( props, slap_propnames+1, auxvals );
        
        AC_MEMCPY( &authcDN, auxvals[0].values[0], sizeof(authcDN) );
 
@@ -785,13 +901,13 @@ slap_sasl_authorize(
        
        AC_MEMCPY( &authzDN, auxvals[1].values[0], sizeof(authzDN) );
 
-       rc = slap_sasl_authorized( &authcDN, &authzDN );
+       rc = slap_sasl_authorized( conn, &authcDN, &authzDN );
        ch_free( authcDN.bv_val );
        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_INFO,
-                          "slap_sasl_authorize: conn %ld  authorization disallowed (%d)\n",
-                          (long)(conn ? conn->c_connid : -1), rc ));
+               LDAP_LOG( TRANSPORT, INFO, 
+                       "slap_sasl_authorize: conn %ld  authorization disallowed (%d)\n",
+                       (long)(conn ? conn->c_connid : -1), rc, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
                        " authorization disallowed (%d)\n",
@@ -806,9 +922,9 @@ slap_sasl_authorize(
        conn->c_sasl_dn = authzDN;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_authorize: conn %d authorization allowed\n",
-                  (long)(conn ? conn->c_connid : -1 ) ));
+       LDAP_LOG( TRANSPORT, ENTRY, 
+               "slap_sasl_authorize: conn %d authorization allowed\n",
+               (long)(conn ? conn->c_connid : -1), 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
                " authorization allowed\n",
@@ -838,11 +954,10 @@ slap_sasl_authorize(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_authorize: conn %d         authcid=\"%s\" authzid=\"%s\"\n",
-                  conn ? conn->c_connid : -1,
-                  authcid ? authcid : "<empty>",
-                  authzid ? authzid : "<empty>" ));
+       LDAP_LOG( TRANSPORT, ENTRY, 
+               "slap_sasl_authorize: conn %d    authcid=\"%s\" authzid=\"%s\"\n",
+               conn ? conn->c_connid : -1, authcid ? authcid : "<empty>",
+               authzid ? authzid : "<empty>" );
 #else
        Debug( LDAP_DEBUG_ARGS, "SASL Authorize [conn=%ld]: "
                "authcid=\"%s\" authzid=\"%s\"\n",
@@ -855,8 +970,8 @@ slap_sasl_authorize(
        rc = sasl_getprop( conn->c_sasl_context, SASL_REALM, (void **)&realm );
        if( rc != SASL_OK && rc != SASL_NOTDONE ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
-                       "slap_sasl_authorize: getprop(REALM) failed.\n" ));
+               LDAP_LOG( TRANSPORT, ERR,
+                       "slap_sasl_authorize: getprop(REALM) failed.\n", 0, 0, 0 );
 #else
                Debug(LDAP_DEBUG_TRACE,
                        "authorize: getprop(REALM) failed!\n", 0,0,0);
@@ -874,9 +989,9 @@ slap_sasl_authorize(
        }
        if( ( authzid == NULL ) || !strcmp( authcid,authzid ) ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                          "slap_sasl_authorize: conn %d  Using authcDN=%s\n",
-                          conn ? conn->c_connid : -1, authcDN.bv_val ));
+               LDAP_LOG( TRANSPORT, ENTRY, 
+                       "slap_sasl_authorize: conn %d  Using authcDN=%s\n",
+                       conn ? conn->c_connid : -1, authcDN.bv_val, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
                 "Using authcDN=%s\n", (long) (conn ? conn->c_connid : -1), authcDN.bv_val,0 );
@@ -893,13 +1008,13 @@ slap_sasl_authorize(
                return SASL_NOAUTHZ;
        }
 
-       rc = slap_sasl_authorized( &authcDN, &authzDN );
+       rc = slap_sasl_authorized(conn, &authcDN, &authzDN );
        ch_free( authcDN.bv_val );
        if( rc ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_INFO,
-                          "slap_sasl_authorize: conn %ld  authorization disallowed (%d)\n",
-                          (long)(conn ? conn->c_connid : -1), rc ));
+               LDAP_LOG( TRANSPORT, INFO, 
+                       "slap_sasl_authorize: conn %ld  authorization disallowed (%d)\n",
+                       (long)(conn ? conn->c_connid : -1), rc, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
                        " authorization disallowed (%d)\n",
@@ -912,9 +1027,9 @@ slap_sasl_authorize(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_authorize: conn %d authorization allowed\n",
-                  (long)(conn ? conn->c_connid : -1 ) ));
+       LDAP_LOG( TRANSPORT, RESULTS, 
+               "slap_sasl_authorize: conn %d authorization allowed\n",
+          (long)(conn ? conn->c_connid : -1 ), 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "SASL Authorize [conn=%ld]: "
                " authorization allowed\n",
@@ -975,10 +1090,10 @@ int slap_sasl_init( void )
        };
 
        sasl_set_alloc(
-               ch_malloc,
-               ch_calloc,
-               ch_realloc,
-               ch_free ); 
+               ber_memalloc,
+               ber_memcalloc,
+               ber_memrealloc,
+               ber_memfree ); 
 
        sasl_set_mutex(
                ldap_pvt_sasl_mutex_new,
@@ -995,8 +1110,7 @@ int slap_sasl_init( void )
 
        if( rc != SASL_OK ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_INFO,
-                          "slap_sasl_init: init failed.\n" ));
+               LDAP_LOG( TRANSPORT, INFO, "slap_sasl_init: init failed.\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "sasl_server_init failed\n",
                        0, 0, 0 );
@@ -1006,8 +1120,7 @@ int slap_sasl_init( void )
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_INFO,
-                  "slap_sasl_init: initialized!\n"));
+       LDAP_LOG( TRANSPORT, INFO, "slap_sasl_init: initialized!\n", 0, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "slap_sasl_init: initialized!\n",
                0, 0, 0 );
@@ -1028,6 +1141,9 @@ int slap_sasl_destroy( void )
 {
 #ifdef HAVE_CYRUS_SASL
        sasl_done();
+#endif
+#if SASL_VERSION_MAJOR >= 2
+       filter_free( generic_filter );
 #endif
        free( global_host );
        global_host = NULL;
@@ -1088,6 +1204,9 @@ int slap_sasl_open( Connection *conn )
 
        /* create new SASL context */
 #if SASL_VERSION_MAJOR >= 2
+       if ( generic_filter == NULL ) {
+               generic_filter = str2filter( "(objectclass=*)" );
+       }
        if ( conn->c_sock_name.bv_len != 0 &&
             strncmp( conn->c_sock_name.bv_val, "IP=", 3 ) == 0) {
                char *p;
@@ -1129,8 +1248,8 @@ int slap_sasl_open( Connection *conn )
 
        if( sc != SASL_OK ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
-                          "slap_sasl_open: sasl_server_new failed: %d\n", sc ));
+               LDAP_LOG( TRANSPORT, ERR, 
+                       "slap_sasl_open: sasl_server_new failed: %d\n", sc, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "sasl_server_new failed: %d\n",
                        sc, 0, 0 );
@@ -1147,8 +1266,8 @@ int slap_sasl_open( Connection *conn )
 
                if( sc != SASL_OK ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
-                                  "slap_sasl_open: sasl_setprop failed: %d \n", sc ));
+                       LDAP_LOG( TRANSPORT, ERR, 
+                               "slap_sasl_open: sasl_setprop failed: %d \n", sc, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY, "sasl_setprop failed: %d\n",
                                sc, 0, 0 );
@@ -1242,8 +1361,8 @@ char ** slap_sasl_mechs( Connection *conn )
 
                if( sc != SASL_OK ) {
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
-                               "slap_sasl_mechs: sasl_listmech failed: %d\n", sc ));
+                       LDAP_LOG( TRANSPORT, ERR, 
+                               "slap_sasl_mechs: sasl_listmech failed: %d\n", sc, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY, "slap_sasl_listmech failed: %d\n",
                                sc, 0, 0 );
@@ -1300,12 +1419,12 @@ int slap_sasl_bind(
        int sc;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "sasl_bind: conn %ld dn=\"%s\" mech=%s datalen=%ld\n",
-               conn->c_connid,
+       LDAP_LOG( TRANSPORT, ENTRY, 
+               "sasl_bind: dn=\"%s\" mech=%s datalen=%ld\n",
                dn->bv_len ? dn->bv_val : "",
-               conn->c_sasl_bind_in_progress ? "<continuing>" : conn->c_sasl_bind_mech.bv_val,
-               cred ? cred->bv_len : 0 ));
+               conn->c_sasl_bind_in_progress ? "<continuing>" : 
+               conn->c_sasl_bind_mech.bv_val,
+               cred ? cred->bv_len : 0 );
 #else
        Debug(LDAP_DEBUG_ARGS,
                "==> sasl_bind: dn=\"%s\" mech=%s datalen=%ld\n",
@@ -1389,8 +1508,7 @@ int slap_sasl_bind(
 #endif
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "slap_sasl_bind: rc=%d\n", rc ));
+       LDAP_LOG( TRANSPORT, RESULTS, "slap_sasl_bind: rc=%d\n", rc, 0, 0 );
 #else
        Debug(LDAP_DEBUG_TRACE, "<== slap_sasl_bind: rc=%d\n", rc, 0, 0);
 #endif
@@ -1445,11 +1563,11 @@ slap_sasl_setpass(
        }
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "backend", LDAP_LEVEL_ENTRY,
+       LDAP_LOG( BACKEND, ENTRY,
                "slap_sasl_setpass: \"%s\"\n",
-               id.bv_val ? id.bv_val : "" ));
+               id.bv_val ? id.bv_val : "", 0, 0);
 #else
-       Debug( LDAP_DEBUG_ARGS, "==> ldbm_back_exop_passwd: \"%s\"\n",
+       Debug( LDAP_DEBUG_ARGS, "==> slap_sasl_setpass: \"%s\"\n",
                id.bv_val ? id.bv_val : "", 0, 0 );
 #endif
 
@@ -1477,7 +1595,7 @@ slap_sasl_setpass(
                id.bv_val, new.bv_val, new.bv_len, 0, text );
 #else
        rc = sasl_setpass( conn->c_sasl_context, id.bv_val,
-               old.bv_val, old.bv_len, new.bv_val, new.bv_len, 0 );
+               new.bv_val, new.bv_len, old.bv_val, old.bv_len, 0 );
        if( rc != SASL_OK ) {
                *text = sasl_errdetail( conn->c_sasl_context );
        }