]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/saslauthz.c
add logs; fix bug in group/dn selection logic
[openldap] / servers / slapd / saslauthz.c
index ca9a416d0da1f1b869eae7982aac2c988cb9db4d..8935182ccc3d6dbddbb3cd6c05c593de18bb74cb 100644 (file)
@@ -1,7 +1,8 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 1998-2003 The OpenLDAP Foundation.
+ * Copyright 1998-2004 The OpenLDAP Foundation.
+ * Portions Copyright 2000 Mark Adamson, Carnegie Mellon.
  * All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * top-level directory of the distribution or, alternatively, at
  * <http://www.OpenLDAP.org/license.html>.
  */
-/* Portions Copyright (c) 2000, Mark Adamson, Carnegie Mellon.
- * All rights reserved.
- * This software is not subject to any license of Carnegie Mellon University.
- *
- * Redistribution and use in source and binary forms are permitted without 
- * restriction or fee of any kind as long as this notice is preserved.
- *
- * The name "Carnegie Mellon" must not be used to endorse or promote
- * products derived from this software without prior written permission.
- */
 
 #include "portable.h"
 
@@ -29,6 +20,7 @@
 
 #include <ac/stdlib.h>
 #include <ac/string.h>
+#include <ac/ctype.h>
 
 #include "slap.h"
 
 
 #define SASLREGEX_REPLACE 10
 
+#define LDAP_X_SCOPE_EXACT     ((ber_int_t) 0x0010)
+#define LDAP_X_SCOPE_REGEX     ((ber_int_t) 0x0020)
+#define LDAP_X_SCOPE_CHILDREN  ((ber_int_t) 0x0030)
+#define LDAP_X_SCOPE_SUBTREE   ((ber_int_t) 0x0040)
+#define LDAP_X_SCOPE_ONELEVEL  ((ber_int_t) 0x0050)
+
+/*
+ * IDs in DNauthzid form can now have a type specifier, that
+ * influences how they are used in related operations.
+ *
+ * syntax: dn[.{exact|regex}]:<val>
+ *
+ * dn.exact:   the value must pass normalization and is used 
+ *             in exact DN match.
+ * dn.regex:   the value is treated as a regular expression 
+ *             in matching DN values in authz{To|From}
+ *             attributes.
+ * dn:         for backwards compatibility reasons, the value 
+ *             is treated as a regular expression, and thus 
+ *             it is not normalized nor validated; it is used
+ *             in exact or regex comparisons based on the 
+ *             context.
+ *
+ * IDs in DNauthzid form can now have a type specifier, that
+ * influences how they are used in related operations.
+ *
+ * syntax: u[.mech[/realm]]:<val>
+ * 
+ * where mech is a SIMPLE, AUTHZ, or a SASL mechanism name
+ * and realm is mechanism specific realm (separate to those
+ * which are representable as part of the principal).
+ */
+
 typedef struct sasl_regexp {
-  char *sr_match;                                                      /* regexp match pattern */
-  char *sr_replace;                                            /* regexp replace pattern */
-  regex_t sr_workspace;                                                /* workspace for regexp engine */
-  int sr_offset[SASLREGEX_REPLACE+2];          /* offsets of $1,$2... in *replace */
+  char *sr_match;                                              /* regexp match pattern */
+  char *sr_replace;                                    /* regexp replace pattern */
+  regex_t sr_workspace;                                        /* workspace for regexp engine */
+  int sr_offset[SASLREGEX_REPLACE+2];  /* offsets of $1,$2... in *replace */
 } SaslRegexp_t;
 
 static int nSaslRegexp = 0;
 static SaslRegexp_t *SaslRegexp = NULL;
 
+#ifdef SLAP_SASL_REWRITE
+#include "rewrite.h"
+struct rewrite_info    *sasl_rwinfo = NULL;
+#define AUTHID_CONTEXT "authid"
+#endif /* SLAP_SASL_REWRITE */
+
 /* What SASL proxy authorization policies are allowed? */
-#define        SASL_AUTHZ_NONE 0
-#define        SASL_AUTHZ_FROM 1
-#define        SASL_AUTHZ_TO   2
+#define        SASL_AUTHZ_NONE 0x00
+#define        SASL_AUTHZ_FROM 0x01
+#define        SASL_AUTHZ_TO   0x02
+#define SASL_AUTHZ_AND 0x10
 
 static int authz_policy = SASL_AUTHZ_NONE;
 
@@ -65,14 +97,93 @@ int slap_sasl_setpolicy( const char *arg )
                authz_policy = SASL_AUTHZ_FROM;
        } else if ( strcasecmp( arg, "to" ) == 0 ) {
                authz_policy = SASL_AUTHZ_TO;
-       } else if ( strcasecmp( arg, "both" ) == 0 ) {
+       } else if ( strcasecmp( arg, "both" ) == 0 || strcasecmp( arg, "any" ) == 0 ) {
                authz_policy = SASL_AUTHZ_FROM | SASL_AUTHZ_TO;
+       } else if ( strcasecmp( arg, "all" ) == 0 ) {
+               authz_policy = SASL_AUTHZ_FROM | SASL_AUTHZ_TO | SASL_AUTHZ_AND;
        } else {
                rc = LDAP_OTHER;
        }
        return rc;
 }
 
+int slap_parse_user( struct berval *id, struct berval *user,
+               struct berval *realm, struct berval *mech )
+{
+       char    u;
+       
+       assert( id );
+       assert( !BER_BVISNULL( id ) );
+       assert( user );
+       assert( realm );
+       assert( mech );
+
+       u = id->bv_val[ 0 ];
+       
+       if ( u != 'u' && u != 'U' ) {
+               /* called with something other than u: */
+               return LDAP_PROTOCOL_ERROR;
+       }
+
+       /* uauthzid form:
+        *              u[.mech[/realm]]:user
+        */
+       
+       user->bv_val = strchr( id->bv_val, ':' );
+       if ( BER_BVISNULL( user ) ) {
+               return LDAP_PROTOCOL_ERROR;
+       }
+       user->bv_val[ 0 ] = '\0';
+       user->bv_val++;
+       user->bv_len = id->bv_len - ( user->bv_val - id->bv_val );
+
+       mech->bv_val = strchr( id->bv_val, '.' );
+       if ( !BER_BVISNULL( mech ) ) {
+               mech->bv_val[ 0 ] = '\0';
+               mech->bv_val++;
+
+               realm->bv_val = strchr( mech->bv_val, '/' );
+
+               if ( !BER_BVISNULL( realm ) ) {
+                       realm->bv_val[ 0 ] = '\0';
+                       realm->bv_val++;
+                       mech->bv_len = realm->bv_val - mech->bv_val - 1;
+                       realm->bv_len = user->bv_val - realm->bv_val - 1;
+               } else {
+                       mech->bv_len = user->bv_val - mech->bv_val - 1;
+               }
+
+       } else {
+               BER_BVZERO( realm );
+       }
+
+       if ( id->bv_val[ 1 ] != '\0' ) {
+               return LDAP_PROTOCOL_ERROR;
+       }
+
+       if ( !BER_BVISNULL( mech ) ) {
+               assert( mech->bv_val == id->bv_val + 2 );
+
+               AC_MEMCPY( mech->bv_val - 2, mech->bv_val, mech->bv_len + 1 );
+               mech->bv_val -= 2;
+       }
+
+       if ( !BER_BVISNULL( realm ) ) {
+               assert( realm->bv_val >= id->bv_val + 2 );
+
+               AC_MEMCPY( realm->bv_val - 2, realm->bv_val, realm->bv_len + 1 );
+               realm->bv_val -= 2;
+       }
+
+       /* leave "u:" before user */
+       user->bv_val -= 2;
+       user->bv_len += 2;
+       user->bv_val[ 0 ] = u;
+       user->bv_val[ 1 ] = ':';
+
+       return LDAP_SUCCESS;
+}
+
 static int slap_parseURI( Operation *op, struct berval *uri,
        struct berval *base, struct berval *nbase,
        int *scope, Filter **filter, struct berval *fstr )
@@ -81,13 +192,10 @@ static int slap_parseURI( Operation *op, struct berval *uri,
        int rc;
        LDAPURLDesc *ludp;
 
-       assert( uri != NULL && uri->bv_val != NULL );
-       base->bv_val = NULL;
-       base->bv_len = 0;
-       nbase->bv_val = NULL;
-       nbase->bv_len = 0;
-       fstr->bv_val = NULL;
-       fstr->bv_len = 0;
+       assert( uri != NULL && !BER_BVISNULL( uri ) );
+       BER_BVZERO( base );
+       BER_BVZERO( nbase );
+       BER_BVZERO( fstr );
        *scope = -1;
        *filter = NULL;
 
@@ -99,23 +207,117 @@ static int slap_parseURI( Operation *op, struct berval *uri,
                "slap_parseURI: parsing %s\n", uri->bv_val, 0, 0 );
 #endif
 
-       /* If it does not look like a URI, assume it is a DN */
-       if( !strncasecmp( uri->bv_val, "dn:", sizeof("dn:")-1 ) ) {
-               bv.bv_val = uri->bv_val + sizeof("dn:")-1;
+       rc = LDAP_PROTOCOL_ERROR;
+       if ( !strncasecmp( uri->bv_val, "dn", STRLENOF( "dn" ) ) ) {
+               bv.bv_val = uri->bv_val + STRLENOF( "dn" );
+
+               if ( bv.bv_val[ 0 ] == '.' ) {
+                       bv.bv_val++;
+
+                       if ( !strncasecmp( bv.bv_val, "exact:", STRLENOF( "exact:" ) ) ) {
+                               bv.bv_val += STRLENOF( "exact:" );
+                               *scope = LDAP_X_SCOPE_EXACT;
+
+                       } else if ( !strncasecmp( bv.bv_val, "regex:", STRLENOF( "regex:" ) ) ) {
+                               bv.bv_val += STRLENOF( "regex:" );
+                               *scope = LDAP_X_SCOPE_REGEX;
+
+                       } else if ( !strncasecmp( bv.bv_val, "children:", STRLENOF( "chldren:" ) ) ) {
+                               bv.bv_val += STRLENOF( "children:" );
+                               *scope = LDAP_X_SCOPE_CHILDREN;
+
+                       } else if ( !strncasecmp( bv.bv_val, "subtree:", STRLENOF( "subtree:" ) ) ) {
+                               bv.bv_val += STRLENOF( "subtree:" );
+                               *scope = LDAP_X_SCOPE_SUBTREE;
+
+                       } else if ( !strncasecmp( bv.bv_val, "onelevel:", STRLENOF( "onelevel:" ) ) ) {
+                               bv.bv_val += STRLENOF( "onelevel:" );
+                               *scope = LDAP_X_SCOPE_ONELEVEL;
+
+                       } else {
+                               return LDAP_PROTOCOL_ERROR;
+                       }
+               }
+
+               if ( bv.bv_val[ 0 ] != ':' ) {
+                       return LDAP_PROTOCOL_ERROR;
+               }
+               bv.bv_val++;
+
                bv.bv_val += strspn( bv.bv_val, " " );
+               /* jump here in case no type specification was present
+                * and uir was not an URI... HEADS-UP: assuming EXACT */
+is_dn:         bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
+
+               switch ( *scope ) {
+               case LDAP_X_SCOPE_EXACT:
+               case LDAP_X_SCOPE_CHILDREN:
+               case LDAP_X_SCOPE_SUBTREE:
+               case LDAP_X_SCOPE_ONELEVEL:
+                       rc = dnNormalize( 0, NULL, NULL, &bv, nbase, op->o_tmpmemctx );
+                       if( rc != LDAP_SUCCESS ) {
+                               *scope = -1;
+                       }
+                       break;
 
-is_dn: bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
+               case LDAP_X_SCOPE_REGEX:
+                       ber_dupbv_x( nbase, &bv, op->o_tmpmemctx );
+                       rc = LDAP_SUCCESS;
+                       break;
 
-               rc = dnNormalize( 0, NULL, NULL, &bv, nbase, op->o_tmpmemctx );
-               if( rc == LDAP_SUCCESS ) {
-                       *scope = LDAP_SCOPE_BASE;
+               default:
+                       *scope = -1;
+                       break;
+               }
+
+               return rc;
+
+       } else if ( ( uri->bv_val[ 0 ] == 'u' || uri->bv_val[ 0 ] == 'U' )
+                       && ( uri->bv_val[ 1 ] == ':' 
+                               || uri->bv_val[ 1 ] == '/' 
+                               || uri->bv_val[ 1 ] == '.' ) )
+       {
+               Connection      c = *op->o_conn;
+               char            buf[ SLAP_LDAPDN_MAXLEN ];
+               struct berval   id,
+                               user = BER_BVNULL,
+                               realm = BER_BVNULL,
+                               mech = BER_BVNULL;
+
+               if ( sizeof( buf ) <= uri->bv_len ) {
+                       return LDAP_INVALID_SYNTAX;
+               }
+
+               id.bv_len = uri->bv_len;
+               id.bv_val = buf;
+               strncpy( buf, uri->bv_val, sizeof( buf ) );
+
+               rc = slap_parse_user( &id, &user, &realm, &mech );
+               if ( rc != LDAP_SUCCESS ) {
+                       return rc;
+               }
+
+               if ( !BER_BVISNULL( &mech ) ) {
+                       c.c_sasl_bind_mech = mech;
+               } else {
+                       BER_BVSTR( &c.c_sasl_bind_mech, "AUTHZ" );
+               }
+               
+               rc = slap_sasl_getdn( &c, op, &user,
+                               realm.bv_val, nbase, SLAP_GETDN_AUTHZID );
+
+               if ( rc == LDAP_SUCCESS ) {
+                       *scope = LDAP_X_SCOPE_EXACT;
                }
-               return( rc );
-       }
 
+               return rc;
+       }
+               
        rc = ldap_url_parse( uri->bv_val, &ludp );
        if ( rc == LDAP_URL_ERR_BADSCHEME ) {
+               /* last chance: assume it's a(n exact) DN ... */
                bv.bv_val = uri->bv_val;
+               *scope = LDAP_X_SCOPE_EXACT;
                goto is_dn;
        }
 
@@ -128,7 +330,7 @@ is_dn:      bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
        {
                /* host part must be empty */
                /* attrs and extensions parts must be empty */
-               rc =  LDAP_PROTOCOL_ERROR;
+               rc = LDAP_PROTOCOL_ERROR;
                goto done;
        }
 
@@ -152,14 +354,12 @@ is_dn:    bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
 done:
        if( rc != LDAP_SUCCESS ) {
                if( *filter ) filter_free_x( op, *filter );
-               base->bv_val = NULL;
-               base->bv_len = 0;
-               fstr->bv_val = NULL;
-               fstr->bv_len = 0;
+               BER_BVZERO( base );
+               BER_BVZERO( fstr );
        } else {
                /* Don't free these, return them to caller */
                ludp->lud_filter = NULL;
-               ludp->lud_dn= NULL;
+               ludp->lud_dn = NULL;
        }
 
        ldap_free_urldesc( ludp );
@@ -206,8 +406,101 @@ static int slap_sasl_rx_off(char *rep, int *off)
        return( LDAP_SUCCESS );
 }
 
+#ifdef SLAP_SASL_REWRITE
+int slap_sasl_rewrite_config( 
+               const char      *fname,
+               int             lineno,
+               int             argc,
+               char            **argv
+)
+{
+       int     rc;
+       char    *savearg0;
+
+       /* init at first call */
+       if ( sasl_rwinfo == NULL ) {
+               sasl_rwinfo = rewrite_info_init( REWRITE_MODE_USE_DEFAULT );
+       }
+
+       /* strip "authid-" prefix for parsing */
+       savearg0 = argv[0];
+       argv[0] += STRLENOF( "authid-" );
+       rc = rewrite_parse( sasl_rwinfo, fname, lineno, argc, argv );
+       argv[0] = savearg0;
+
+       return rc;
+}
+
+int slap_sasl_rewrite_destroy( void )
+{
+       if ( sasl_rwinfo ) {
+               rewrite_info_delete( sasl_rwinfo );
+               sasl_rwinfo = NULL;
+       }
+
+       return 0;
+}
+
+int slap_sasl_regexp_rewrite_config(
+               const char      *fname,
+               int             lineno,
+               const char      *match,
+               const char      *replace,
+               const char      *context )
+{
+       int     rc;
+       char    *newreplace, *p;
+       char    *argvRule[] = { "rewriteRule", NULL, NULL, "@", NULL };
+
+       /* init at first call */
+       if ( sasl_rwinfo == NULL ) {
+               char *argvEngine[] = { "rewriteEngine", "on", NULL };
+               char *argvContext[] = { "rewriteContext", NULL, NULL };
+               char *argvFirstRule[] = { "rewriteRule", ".*", 
+                       "%{>" AUTHID_CONTEXT "(%0)}", ":", NULL };
+
+               /* initialize rewrite engine */
+               sasl_rwinfo = rewrite_info_init( REWRITE_MODE_USE_DEFAULT );
+
+               /* switch on rewrite engine */
+               rc = rewrite_parse( sasl_rwinfo, fname, lineno, 2, argvEngine );
+               if (rc != LDAP_SUCCESS) {
+                       return rc;
+               }
+
+               /* create generic authid context */
+               argvContext[1] = AUTHID_CONTEXT;
+               rc = rewrite_parse( sasl_rwinfo, fname, lineno, 2, argvContext );
+               if (rc != LDAP_SUCCESS) {
+                       return rc;
+               }
+       }
+
+       newreplace = ch_strdup( replace );
+       
+       for (p = strchr( newreplace, '$' ); p; p = strchr( p + 1, '$' ) ) {
+               if ( isdigit( p[1] ) ) {
+                       p[0] = '%';
+               } else {
+                       p++;
+               }
+       }
+
+       argvRule[1] = (char *)match;
+       argvRule[2] = newreplace;
+       rc = rewrite_parse( sasl_rwinfo, fname, lineno, 4, argvRule );
+       ch_free( newreplace );
+
+       return rc;
+}
+#endif /* SLAP_SASL_REWRITE */
+
 int slap_sasl_regexp_config( const char *match, const char *replace )
 {
+#ifdef SLAP_SASL_REWRITE
+       return slap_sasl_regexp_rewrite_config( "sasl-regexp", 0,
+                       match, replace, AUTHID_CONTEXT );
+#else /* ! SLAP_SASL_REWRITE */
        int rc;
        SaslRegexp_t *reg;
 
@@ -240,9 +533,9 @@ int slap_sasl_regexp_config( const char *match, const char *replace )
 
        nSaslRegexp++;
        return( LDAP_SUCCESS );
+#endif /* ! SLAP_SASL_REWRITE */
 }
 
-
 /* Perform replacement on regexp matches */
 static void slap_sasl_rx_exp(
        const char *rep,
@@ -299,8 +592,47 @@ static void slap_sasl_rx_exp(
    LDAP URI to find the matching LDAP entry, using the pattern matching
    strings given in the saslregexp config file directive(s) */
 
-static int slap_sasl_regexp( struct berval *in, struct berval *out, void *ctx )
+static int slap_sasl_regexp( struct berval *in, struct berval *out,
+               int flags, void *ctx )
 {
+#ifdef SLAP_SASL_REWRITE
+       const char      *context = AUTHID_CONTEXT;
+
+       if ( sasl_rwinfo == NULL || BER_BVISNULL( in ) ) {
+               return 0;
+       }
+
+       /* FIXME: if aware of authc/authz mapping, 
+        * we could use different contexts ... */
+       switch ( rewrite_session( sasl_rwinfo, context, in->bv_val, NULL, 
+                               &out->bv_val ) )
+       {
+       case REWRITE_REGEXEC_OK:
+               if ( !BER_BVISNULL( out ) ) {
+                       char *val = out->bv_val;
+                       ber_str2bv_x( val, 0, 1, out, ctx );
+                       free( val );
+               } else {
+                       ber_dupbv_x( out, in, ctx );
+               }
+#ifdef NEW_LOGGING
+               LDAP_LOG( BACK_LDAP, DETAIL1, 
+                       "[rw] %s: \"%s\" -> \"%s\"\n",
+                       context, in->bv_val, out->bv_val );             
+#else /* !NEW_LOGGING */
+               Debug( LDAP_DEBUG_ARGS,
+                       "[rw] %s: \"%s\" -> \"%s\"\n",
+                       context, in->bv_val, out->bv_val );             
+#endif /* !NEW_LOGGING */
+               return 1;
+               
+       case REWRITE_REGEXEC_UNWILLING:
+       case REWRITE_REGEXEC_ERR:
+       default:
+               return 0;
+       }
+
+#else /* ! SLAP_SASL_REWRITE */
        char *saslname = in->bv_val;
        SaslRegexp_t *reg;
        regmatch_t sr_strings[SASLREGEX_REPLACE];       /* strings matching $1,$2 ... */
@@ -340,14 +672,15 @@ static int slap_sasl_regexp( struct berval *in, struct berval *out, void *ctx )
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_regexp: converted SASL name to %s\n",
-               out->bv_len ? out->bv_val : "", 0, 0 );
+               BER_BVISEMPTY( out ) ? "" : out->bv_val, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE,
                "slap_sasl_regexp: converted SASL name to %s\n",
-               out->bv_len ? out->bv_val : "", 0, 0 );
+               BER_BVISEMPTY( out ) ? "" : out->bv_val, 0, 0 );
 #endif
 
        return( 1 );
+#endif /* ! SLAP_SASL_REWRITE */
 }
 
 /* This callback actually does some work...*/
@@ -358,16 +691,16 @@ static int sasl_sc_sasl2dn( Operation *o, SlapReply *rs )
        if (rs->sr_type != REP_SEARCH) return 0;
 
        /* We only want to be called once */
-       if( ndn->bv_val ) {
+       if ( !BER_BVISNULL( ndn ) ) {
                o->o_tmpfree(ndn->bv_val, o->o_tmpmemctx);
-               ndn->bv_val = NULL;
+               BER_BVZERO( ndn );
 
 #ifdef NEW_LOGGING
                LDAP_LOG( TRANSPORT, DETAIL1,
-                       "slap_sasl2dn: search DN returned more than 1 entry\n", 0, 0, 0 );
+                       "slap_sc_sasl2dn: search DN returned more than 1 entry\n", 0, 0, 0 );
 #else
                Debug( LDAP_DEBUG_TRACE,
-                       "slap_sasl2dn: search DN returned more than 1 entry\n", 0,0,0 );
+                       "slap_sc_sasl2dn: search DN returned more than 1 entry\n", 0, 0, 0 );
 #endif
                return -1;
        }
@@ -412,7 +745,7 @@ int slap_sasl_match( Operation *opx, struct berval *rule,
        int rc; 
        regex_t reg;
        smatch_info sm;
-       slap_callback cb = { sasl_sc_smatch, NULL };
+       slap_callback cb = { NULL, sasl_sc_smatch, NULL, NULL };
        Operation op = {0};
        SlapReply rs = {REP_RESULT};
 
@@ -432,7 +765,71 @@ int slap_sasl_match( Operation *opx, struct berval *rule,
        if( rc != LDAP_SUCCESS ) goto CONCLUDED;
 
        /* Massive shortcut: search scope == base */
-       if( op.oq_search.rs_scope == LDAP_SCOPE_BASE ) {
+       switch ( op.oq_search.rs_scope ) {
+       case LDAP_SCOPE_BASE:
+       case LDAP_X_SCOPE_EXACT:
+exact_match:
+               if ( dn_match( &op.o_req_ndn, assertDN ) ) {
+                       rc = LDAP_SUCCESS;
+               } else {
+                       rc = LDAP_INAPPROPRIATE_AUTH;
+               }
+               goto CONCLUDED;
+
+       case LDAP_X_SCOPE_CHILDREN:
+       case LDAP_X_SCOPE_SUBTREE:
+       case LDAP_X_SCOPE_ONELEVEL:
+       {
+               int     d = assertDN->bv_len - op.o_req_ndn.bv_len;
+
+               rc = LDAP_INAPPROPRIATE_AUTH;
+
+               if ( d == 0 && op.oq_search.rs_scope == LDAP_X_SCOPE_SUBTREE ) {
+                       goto exact_match;
+
+               } else if ( d > 0 ) {
+                       struct berval bv;
+
+                       /* leave room for at least one char of attributeType,
+                        * one for '=' and one for ',' */
+                       if ( d < STRLENOF( "x=,") ) {
+                               goto CONCLUDED;
+                       }
+
+                       bv.bv_len = op.o_req_ndn.bv_len;
+                       bv.bv_val = assertDN->bv_val + d;
+
+                       if ( bv.bv_val[ -1 ] == ',' && dn_match( &op.o_req_ndn, &bv ) ) {
+                               switch ( op.oq_search.rs_scope ) {
+                               case LDAP_X_SCOPE_SUBTREE:
+                               case LDAP_X_SCOPE_CHILDREN:
+                                       rc = LDAP_SUCCESS;
+                                       break;
+
+                               case LDAP_X_SCOPE_ONELEVEL:
+                               {
+                                       struct berval   pdn;
+
+                                       dnParent( assertDN, &pdn );
+                                       /* the common portion of the DN
+                                        * already matches, so only check
+                                        * if parent DN of assertedDN 
+                                        * is all the pattern */
+                                       if ( pdn.bv_len == op.o_req_ndn.bv_len ) {
+                                               rc = LDAP_SUCCESS;
+                                       }
+                                       break;
+                               }
+                               default:
+                                       /* at present, impossible */
+                                       assert( 0 );
+                               }
+                       }
+               }
+               goto CONCLUDED;
+       }
+
+       case LDAP_X_SCOPE_REGEX:
                rc = regcomp(&reg, op.o_req_ndn.bv_val,
                        REG_EXTENDED|REG_ICASE|REG_NOSUB);
                if ( rc == 0 ) {
@@ -445,9 +842,16 @@ int slap_sasl_match( Operation *opx, struct berval *rule,
                        rc = LDAP_INAPPROPRIATE_AUTH;
                }
                goto CONCLUDED;
+
+       default:
+               break;
        }
 
        /* Must run an internal search. */
+       if ( op.oq_search.rs_filter == NULL ) {
+               rc = LDAP_FILTER_ERROR;
+               goto CONCLUDED;
+       }
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, DETAIL1, 
@@ -485,6 +889,8 @@ int slap_sasl_match( Operation *opx, struct berval *rule,
        op.o_conn = opx->o_conn;
        op.o_connid = opx->o_connid;
        op.o_req_dn = op.o_req_ndn;
+       op.oq_search.rs_slimit = 1;
+       op.oq_search.rs_tlimit = -1;
 
        op.o_bd->be_search( &op, &rs );
 
@@ -546,7 +952,7 @@ slap_sasl_check_authz( Operation *op,
 
        /* Check if the *assertDN matches any **vals */
        if( vals != NULL ) {
-               for( i=0; vals[i].bv_val != NULL; i++ ) {
+               for( i=0; !BER_BVISNULL( &vals[i] ); i++ ) {
                        rc = slap_sasl_match( op, &vals[i], assertDN, authc );
                        if ( rc == LDAP_SUCCESS ) goto COMPLETE;
                }
@@ -578,13 +984,13 @@ COMPLETE:
  * entry, return the DN of that one entry.
  */
 void slap_sasl2dn( Operation *opx,
-       struct berval *saslname, struct berval *sasldn )
+       struct berval *saslname, struct berval *sasldn, int flags )
 {
        int rc;
-       slap_callback cb = { sasl_sc_sasl2dn, NULL };
+       slap_callback cb = { NULL, sasl_sc_sasl2dn, NULL, NULL };
        Operation op = {0};
        SlapReply rs = {REP_RESULT};
-       struct berval regout = { 0, NULL };
+       struct berval regout = BER_BVNULL;
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
@@ -601,15 +1007,15 @@ void slap_sasl2dn( Operation *opx,
        cb.sc_private = sasldn;
 
        /* Convert the SASL name into a minimal URI */
-       if( !slap_sasl_regexp( saslname, &regout, opx->o_tmpmemctx ) ) {
+       if( !slap_sasl_regexp( saslname, &regout, flags, opx->o_tmpmemctx ) ) {
                goto FINISHED;
        }
 
        rc = slap_parseURI( opx, &regout, &op.o_req_dn,
                &op.o_req_ndn, &op.oq_search.rs_scope, &op.oq_search.rs_filter,
                &op.ors_filterstr );
-       if( regout.bv_val ) sl_free( regout.bv_val, opx->o_tmpmemctx );
-       if( rc != LDAP_SUCCESS ) {
+       if ( !BER_BVISNULL( &regout ) ) sl_free( regout.bv_val, opx->o_tmpmemctx );
+       if ( rc != LDAP_SUCCESS ) {
                goto FINISHED;
        }
 
@@ -617,11 +1023,31 @@ void slap_sasl2dn( Operation *opx,
        op.o_bd = select_backend( &op.o_req_ndn, 0, 1 );
 
        /* Massive shortcut: search scope == base */
-       if( op.oq_search.rs_scope == LDAP_SCOPE_BASE ) {
+       switch ( op.oq_search.rs_scope ) {
+       case LDAP_SCOPE_BASE:
+       case LDAP_X_SCOPE_EXACT:
                *sasldn = op.o_req_ndn;
-               op.o_req_ndn.bv_len = 0;
-               op.o_req_ndn.bv_val = NULL;
+               BER_BVZERO( &op.o_req_ndn );
+               /* intentionally continue to next case */
+
+       case LDAP_X_SCOPE_REGEX:
+       case LDAP_X_SCOPE_SUBTREE:
+       case LDAP_X_SCOPE_CHILDREN:
+       case LDAP_X_SCOPE_ONELEVEL:
+               /* correctly parsed, but illegal */
                goto FINISHED;
+
+       case LDAP_SCOPE_ONELEVEL:
+       case LDAP_SCOPE_SUBTREE:
+#ifdef LDAP_SCOPE_SUBORDINATE
+       case LDAP_SCOPE_SUBORDINATE:
+#endif
+               /* do a search */
+               break;
+
+       default:
+               /* catch unhandled cases (there shouldn't be) */
+               assert( 0 );
        }
 
 #ifdef NEW_LOGGING
@@ -655,27 +1081,30 @@ void slap_sasl2dn( Operation *opx,
 #endif
        op.oq_search.rs_deref = LDAP_DEREF_NEVER;
        op.oq_search.rs_slimit = 1;
+       op.oq_search.rs_tlimit = -1;
        op.oq_search.rs_attrsonly = 1;
-       op.o_req_dn = op.o_req_ndn;
+       /* use req_ndn as req_dn instead of non-pretty base of uri */
+       if( !BER_BVISNULL( &op.o_req_dn ) ) ch_free( op.o_req_dn.bv_val );
+       ber_dupbv_x( &op.o_req_dn, &op.o_req_ndn, op.o_tmpmemctx );
 
        op.o_bd->be_search( &op, &rs );
        
 FINISHED:
-       if( sasldn->bv_len ) {
+       if( !BER_BVISEMPTY( sasldn ) ) {
                opx->o_conn->c_authz_backend = op.o_bd;
        }
-       if( op.o_req_dn.bv_len ) ch_free( op.o_req_dn.bv_val );
-       if( op.o_req_ndn.bv_len ) sl_free( op.o_req_ndn.bv_val, opx->o_tmpmemctx );
+       if( !BER_BVISNULL( &op.o_req_dn ) ) sl_free( op.o_req_dn.bv_val, opx->o_tmpmemctx );
+       if( !BER_BVISNULL( &op.o_req_ndn ) ) sl_free( op.o_req_ndn.bv_val, opx->o_tmpmemctx );
        if( op.oq_search.rs_filter ) filter_free_x( opx, op.oq_search.rs_filter );
-       if( op.ors_filterstr.bv_len ) ch_free( op.ors_filterstr.bv_val );
+       if( !BER_BVISNULL( &op.ors_filterstr ) ) ch_free( op.ors_filterstr.bv_val );
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl2dn: Converted SASL name to %s\n",
-               sasldn->bv_len ? sasldn->bv_val : "<nothing>", 0, 0 );
+               !BER_BVISEMPTY( sasldn ) ? sasldn->bv_val : "<nothing>", 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "<==slap_sasl2dn: Converted SASL name to %s\n",
-               sasldn->bv_len ? sasldn->bv_val : "<nothing>", 0, 0 );
+               !BER_BVISEMPTY( sasldn ) ? sasldn->bv_val : "<nothing>", 0, 0 );
 #endif
 
        return;
@@ -714,7 +1143,9 @@ int slap_sasl_authorized( Operation *op,
        }
 
        /* Allow the manager to authorize as any DN. */
-       if( op->o_conn->c_authz_backend && be_isroot( op->o_conn->c_authz_backend, authcDN )) {
+       if( op->o_conn->c_authz_backend &&
+               be_isroot_dn( op->o_conn->c_authz_backend, authcDN ))
+       {
                rc = LDAP_SUCCESS;
                goto DONE;
        }
@@ -723,7 +1154,7 @@ int slap_sasl_authorized( Operation *op,
        if( authz_policy & SASL_AUTHZ_TO ) {
                rc = slap_sasl_check_authz( op, authcDN, authzDN,
                        slap_schema.si_ad_saslAuthzTo, authcDN );
-               if( rc == LDAP_SUCCESS ) {
+               if( rc == LDAP_SUCCESS && !(authz_policy & SASL_AUTHZ_AND) ) {
                        goto DONE;
                }
        }