]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/saslauthz.c
add Time subsystem
[openldap] / servers / slapd / saslauthz.c
index 2b55104a17dd038956ecd094bca4c35e80eb1196..a8d0871c02833fea058b709d9e0c0f4e5383b01a 100644 (file)
@@ -12,9 +12,9 @@
 
 #include "portable.h"
 
-#include <ac/stdlib.h>
 #include <stdio.h>
 
+#include <ac/stdlib.h>
 #include <ac/string.h>
 
 #include "slap.h"
 #include <ldap_pvt.h>
 #endif
 
-/* URI format: ldap://<host>/<base>[?[<attrs>][?[<scope>][?[<filter>]]]]   */
+/* URI format: ldap://<host>/<base>[?[<attrs>][?[<scope>][?[<filter>]]]] */
 
-int slap_parseURI( char *uri, struct berval *searchbase, int *scope, Filter **filter )
+static int slap_parseURI( char *uri,
+       struct berval *searchbase, int *scope, Filter **filter )
 {
        char *start, *end;
        struct berval bv;
@@ -42,15 +43,14 @@ int slap_parseURI( char *uri, struct berval *searchbase, int *scope, Filter **fi
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_parseURI: parsing %s\n", uri ));
+               "slap_parseURI: parsing %s\n", uri ));
 #else
        Debug( LDAP_DEBUG_TRACE, "slap_parseURI: parsing %s\n", uri, 0, 0 );
 #endif
 
-
        /* If it does not look like a URI, assume it is a DN */
-       if( !strncasecmp( uri, "dn:", 3 ) ) {
-               uri += 3;
+       if( !strncasecmp( uri, "dn:", sizeof("dn:")-1 ) ) {
+               uri += sizeof("dn:")-1;
                uri += strspn( uri, " " );
                bv.bv_val = uri;
                /* FIXME: if dnNormalize actually uses input bv_len we
@@ -63,12 +63,14 @@ is_dn:              bv.bv_len = 1;
                }
                return( rc );
        }
-       if( strncasecmp( uri, "ldap://", 7 ) ) {
+
+       /* FIXME: should use ldap_url_parse() */
+       if( strncasecmp( uri, "ldap://", sizeof("ldap://")-1 ) ) {
                bv.bv_val = uri;
                goto is_dn;
        }
 
-       end = strchr( uri + 7, '/' );
+       end = strchr( uri + (sizeof("ldap://")-1), '/' );
        if ( end == NULL )
                return( LDAP_PROTOCOL_ERROR );
 
@@ -98,17 +100,17 @@ is_dn:             bv.bv_len = 1;
 
        /* Grab the scope */
        start = end+1;
-       if( !strncasecmp( start, "base?", 5 )) {
+       if( !strncasecmp( start, "base?", sizeof("base?")-1 )) {
                *scope = LDAP_SCOPE_BASE;
-               start += 5;
+               start += sizeof("base?")-1;
        }
-       else if( !strncasecmp( start, "one?", 4 )) {
+       else if( !strncasecmp( start, "one?", sizeof("one?")-1 )) {
                *scope = LDAP_SCOPE_ONELEVEL;
-               start += 4;
+               start += sizeof("one?")-1;
        }
-       else if( !strncasecmp( start, "sub?", 3 )) {
+       else if( !strncasecmp( start, "sub?", sizeof("sub?")-1 )) {
                *scope = LDAP_SCOPE_SUBTREE;
-               start += 4;
+               start += sizeof("sub?")-1;
        }
        else {
                free( searchbase->bv_val );
@@ -123,44 +125,69 @@ is_dn:            bv.bv_len = 1;
 }
 
 
-
-
-
 int slap_sasl_regexp_config( const char *match, const char *replace )
 {
 #ifdef HAVE_CYRUS_SASL
        const char *c;
        int rc, n;
        SaslRegexp_t *reg;
+       struct berval bv, nbv;
 
        SaslRegexp = (SaslRegexp_t *) ch_realloc( (char *) SaslRegexp,
          (nSaslRegexp + 1) * sizeof(SaslRegexp_t) );
        reg = &( SaslRegexp[nSaslRegexp] );
-       reg->match = ch_strdup( match );
-       reg->replace = ch_strdup( replace );
-       dn_normalize( reg->match );
-       dn_normalize( reg->replace );
+       ber_str2bv( match, 0, 0, &bv );
+       rc = dnNormalize2( NULL, &bv, &nbv );
+       if ( rc ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
+                          "slap_sasl_regexp_config: \"%s\" could not be normalized.\n",
+                          match ));
+#else
+               Debug( LDAP_DEBUG_ANY,
+               "SASL match pattern %s could not be normalized.\n",
+               match, 0, 0 );
+#endif
+               return( rc );
+       }
+       reg->sr_match = nbv.bv_val;
+
+       ber_str2bv( replace, 0, 0, &bv );
+       rc = dnNormalize2( NULL, &bv, &nbv );
+       if ( rc ) {
+#ifdef NEW_LOGGING
+               LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
+                          "slap_sasl_regexp_config: \"%s\" could not be normalized.\n",
+                          replace ));
+#else
+               Debug( LDAP_DEBUG_ANY,
+               "SASL replace pattern %s could not be normalized.\n",
+               replace, 0, 0 );
+#endif
+               return( rc );
+       }
+       reg->sr_replace = nbv.bv_val;
 
        /* Precompile matching pattern */
-       rc = regcomp( &reg->workspace, reg->match, REG_EXTENDED|REG_ICASE );
+       rc = regcomp( &reg->sr_workspace, reg->sr_match, REG_EXTENDED|REG_ICASE );
        if ( rc ) {
 #ifdef NEW_LOGGING
                LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
                           "slap_sasl_regexp_config: \"%s\" could not be compiled.\n",
-                          reg->match ));
+                          reg->sr_match ));
 #else
                Debug( LDAP_DEBUG_ANY,
                "SASL match pattern %s could not be compiled by regexp engine\n",
-               reg->match, 0, 0 );
+               reg->sr_match, 0, 0 );
 #endif
 
                return( LDAP_OPERATIONS_ERROR );
        }
 
        /* Precompile replace pattern. Find the $<n> placeholders */
-       reg->offset[0] = -2;
+       reg->sr_offset[0] = -2;
        n = 1;
-       for ( c = reg->replace;  *c;  c++ ) {
+       for ( c = reg->sr_replace;       *c;  c++ ) {
                if ( *c == '\\' ) {
                        c++;
                        continue;
@@ -169,25 +196,27 @@ int slap_sasl_regexp_config( const char *match, const char *replace )
                        if ( n == SASLREGEX_REPLACE ) {
 #ifdef NEW_LOGGING
                                LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
-                                          "slap_sasl_regexp_config: \"%s\" has too many $n placeholders (max %d)\n",
-                                          reg->replace, SASLREGEX_REPLACE ));
+                                       "slap_sasl_regexp_config: \"%s\" has too many $n "
+                                               "placeholders (max %d)\n",
+                                       reg->sr_replace, SASLREGEX_REPLACE ));
 #else
                                Debug( LDAP_DEBUG_ANY,
-                                  "SASL replace pattern %s has too many $n placeholders (max %d)\n",
-                                  reg->replace, SASLREGEX_REPLACE, 0 );
+                                       "SASL replace pattern %s has too many $n "
+                                               "placeholders (max %d)\n",
+                                       reg->sr_replace, SASLREGEX_REPLACE, 0 );
 #endif
 
                                return( LDAP_OPERATIONS_ERROR );
                        }
-                       reg->offset[n] = c - reg->replace;
+                       reg->sr_offset[n] = c - reg->sr_replace;
                        n++;
                }
        }
 
        /* Final placeholder, after the last $n */
-       reg->offset[n] = c - reg->replace;
+       reg->sr_offset[n] = c - reg->sr_replace;
        n++;
-       reg->offset[n] = -1;
+       reg->sr_offset[n] = -1;
 
        nSaslRegexp++;
 #endif
@@ -195,13 +224,8 @@ int slap_sasl_regexp_config( const char *match, const char *replace )
 }
 
 
-
-
-
 #ifdef HAVE_CYRUS_SASL
 
-
-
 /* Take the passed in SASL name and attempt to convert it into an
    LDAP URI to find the matching LDAP entry, using the pattern matching
    strings given in the saslregexp config file directive(s) */
@@ -212,10 +236,9 @@ char *slap_sasl_regexp( char *saslname )
        int i, n, len, insert;
        SaslRegexp_t *reg;
 
-
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_regexp: converting SASL name %s\n", saslname ));
+               "slap_sasl_regexp: converting SASL name %s\n", saslname ));
 #else
        Debug( LDAP_DEBUG_TRACE, "slap_sasl_regexp: converting SASL name %s\n",
           saslname, 0, 0 );
@@ -226,8 +249,8 @@ char *slap_sasl_regexp( char *saslname )
 
        /* Match the normalized SASL name to the saslregexp patterns */
        for( reg = SaslRegexp,i=0;  i<nSaslRegexp;  i++,reg++ ) {
-               if ( regexec( &reg->workspace, saslname, SASLREGEX_REPLACE,
-                 reg->strings, 0)  == 0 )
+               if ( regexec( &reg->sr_workspace, saslname, SASLREGEX_REPLACE,
+                 reg->sr_strings, 0)  == 0 )
                        break;
        }
 
@@ -245,15 +268,15 @@ char *slap_sasl_regexp( char *saslname )
 
        n=1;
        len = 0;
-       while( reg->offset[n] >= 0 ) {
+       while( reg->sr_offset[n] >= 0 ) {
                /* Len of next section from replacement string (x,y,z above) */
-               len += reg->offset[n] - reg->offset[n-1] - 2;
-               if( reg->offset[n+1] < 0)
+               len += reg->sr_offset[n] - reg->sr_offset[n-1] - 2;
+               if( reg->sr_offset[n+1] < 0)
                        break;
 
                /* Len of string from saslname that matched next $i  (b,d above) */
-               i = reg->replace[ reg->offset[n] + 1 ]  - '0';
-               len += reg->strings[i].rm_eo - reg->strings[i].rm_so;
+               i = reg->sr_replace[ reg->sr_offset[n] + 1 ]    - '0';
+               len += reg->sr_strings[i].rm_eo - reg->sr_strings[i].rm_so;
                n++;
        }
        uri = ch_malloc( len + 1 );
@@ -261,18 +284,18 @@ char *slap_sasl_regexp( char *saslname )
        /* Fill in URI with replace string, replacing $i as we go */
        n=1;
        insert = 0;
-       while( reg->offset[n] >= 0) {
+       while( reg->sr_offset[n] >= 0) {
                /* Paste in next section from replacement string (x,y,z above) */
-               len = reg->offset[n] - reg->offset[n-1] - 2;
-               strncpy( uri+insert, reg->replace + reg->offset[n-1] + 2, len);
+               len = reg->sr_offset[n] - reg->sr_offset[n-1] - 2;
+               strncpy( uri+insert, reg->sr_replace + reg->sr_offset[n-1] + 2, len);
                insert += len;
-               if( reg->offset[n+1] < 0)
+               if( reg->sr_offset[n+1] < 0)
                        break;
 
                /* Paste in string from saslname that matched next $i  (b,d above) */
-               i = reg->replace[ reg->offset[n] + 1 ]  - '0';
-               len = reg->strings[i].rm_eo - reg->strings[i].rm_so;
-               strncpy( uri+insert, saslname + reg->strings[i].rm_so, len );
+               i = reg->sr_replace[ reg->sr_offset[n] + 1 ]    - '0';
+               len = reg->sr_strings[i].rm_eo - reg->sr_strings[i].rm_so;
+               strncpy( uri+insert, saslname + reg->sr_strings[i].rm_so, len );
                insert += len;
 
                n++;
@@ -281,7 +304,7 @@ char *slap_sasl_regexp( char *saslname )
        uri[insert] = '\0';
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_regexp: converted SASL name to %s\n", uri ));
+               "slap_sasl_regexp: converted SASL name to %s\n", uri ));
 #else
        Debug( LDAP_DEBUG_TRACE,
           "slap_sasl_regexp: converted SASL name to %s\n", uri, 0, 0 );
@@ -290,6 +313,43 @@ char *slap_sasl_regexp( char *saslname )
        return( uri );
 }
 
+/* Two empty callback functions to avoid sending results */
+static void sasl_sc_r( Connection *conn, Operation *o, ber_tag_t tag,
+       ber_int_t msgid, ber_int_t err, const char *matched,
+       const char *text, BerVarray ref, const char *resoid,
+       struct berval *resdata, struct berval *sasldata, LDAPControl **c)
+{
+}
+
+static void sasl_sc_s( Connection *conn, Operation *o, ber_int_t err,
+       const char *matched, const char *text, BerVarray refs, LDAPControl **c,
+       int nentries)
+{
+}
+
+/* This callback actually does some work...*/
+static int sasl_sc_sasl2dn( BackendDB *be, Connection *conn, Operation *o,
+       Entry *e, AttributeName *an, int ao, LDAPControl **c)
+{
+       struct berval *ndn = o->o_callback->sc_private;
+
+       /* We only want to be called once */
+       if (ndn->bv_val) {
+               free(ndn->bv_val);
+               ndn->bv_val = NULL;
+#ifdef NEW_LOGGING
+       LDAP_LOG(( "sasl", LDAP_LEVEL_DETAIL1,
+                  "slap_sasl2dn: search DN returned more than 1 entry\n" ));
+#else
+       Debug( LDAP_DEBUG_TRACE,
+          "slap_sasl2dn: search DN returned more than 1 entry\n", 0,0,0 );
+#endif
+               return -1;
+       } else {
+               ber_dupbv(ndn, &e->e_nname);
+               return 0;
+       }
+}
 
 /*
  * Given a SASL name (e.g. "UID=name,cn=REALM,cn=MECH,cn=AUTH")
@@ -300,29 +360,29 @@ char *slap_sasl_regexp( char *saslname )
  * entry, return the DN of that one entry.
  */
 
-char *slap_sasl2dn( char *saslname )
+void slap_sasl2dn( struct berval *saslname, struct berval *dn )
 {
        char *uri=NULL;
        struct berval searchbase = {0, NULL};
-       struct berval dn = {0, NULL};
-       struct berval ndn;
        int rc, scope;
        Backend *be;
        Filter *filter=NULL;
-       Connection *conn=NULL;
-       LDAP *client=NULL;
-       LDAPMessage *res=NULL, *msg;
+       slap_callback cb = {sasl_sc_r, sasl_sc_s, sasl_sc_sasl2dn, NULL};
+       Operation op = {0};
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "slap_sasl2dn: converting SASL name %s to DN.\n", saslname ));
+               "slap_sasl2dn: converting SASL name %s to DN.\n", saslname->bv_val ));
 #else
        Debug( LDAP_DEBUG_TRACE,
-               "==>slap_sasl2dn: Converting SASL name %s to a DN\n", saslname, 0,0 );
+               "==>slap_sasl2dn: Converting SASL name %s to a DN\n", saslname->bv_val, 0,0 );
 #endif
+       dn->bv_val = NULL;
+       dn->bv_len = 0;
+       cb.sc_private = dn;
 
        /* Convert the SASL name into an LDAP URI */
-       uri = slap_sasl_regexp( saslname );
+       uri = slap_sasl_regexp( saslname->bv_val );
        if( uri == NULL )
                goto FINISHED;
 
@@ -333,7 +393,7 @@ char *slap_sasl2dn( char *saslname )
 
        /* Massive shortcut: search scope == base */
        if( scope == LDAP_SCOPE_BASE ) {
-               dn = searchbase;
+               *dn = searchbase;
                searchbase.bv_len = 0;
                searchbase.bv_val = NULL;
                goto FINISHED;
@@ -351,73 +411,58 @@ char *slap_sasl2dn( char *saslname )
           searchbase.bv_val, scope, 0 );
 #endif
 
-
        be = select_backend( &searchbase, 0, 1 );
        if(( be == NULL ) || ( be->be_search == NULL))
                goto FINISHED;
        suffix_alias( be, &searchbase );
 
-       rc = connection_internal_open( &conn, &client, saslname );
-       if( rc != LDAP_SUCCESS )
-               goto FINISHED;
+       ldap_pvt_thread_mutex_init( &op.o_abandonmutex );
+       op.o_tag = LDAP_REQ_SEARCH;
+       op.o_protocol = LDAP_VERSION3;
+       op.o_ndn = *saslname;
+       op.o_callback = &cb;
+       op.o_time = slap_get_time();
 
-       (*be->be_search)( be, conn, STAILQ_FIRST(&conn->c_ops), /*base*/NULL, &searchbase,
+       (*be->be_search)( be, /*conn*/NULL, &op, /*base*/NULL, &searchbase,
           scope, /*deref=*/1, /*sizelimit=*/1, /*time=*/0, filter, /*fstr=*/NULL,
           /*attrs=*/NULL, /*attrsonly=*/0 );
-
-
-       /* Read the client side of the internal search */
-       rc = ldap_result( client, LDAP_RES_ANY, LDAP_MSG_ALL, NULL, &res );
-       if( rc == -1 )
-               goto FINISHED;
-
-       /* Make sure exactly one entry was returned */
-       rc = ldap_count_entries( client, res );
-#ifdef NEW_LOGGING
-       LDAP_LOG(( "sasl", LDAP_LEVEL_DETAIL1,
-                  "slap_sasl2dn: search DN returned %d entries\n", rc ));
-#else
-       Debug( LDAP_DEBUG_TRACE,
-          "slap_sasl2dn: search DN returned %d entries\n", rc,0,0 );
-#endif
-
-       if( rc != 1 )
-               goto FINISHED;
-
-       msg = ldap_first_entry( client, res );
-       dn.bv_val = ldap_get_dn( client, msg );
-       dn.bv_len = dn.bv_val ? strlen( dn.bv_val ) : 0;
-       if( dn.bv_val ) {
-               rc = dnNormalize2( NULL, &dn, &ndn );
-               ldap_memfree( dn.bv_val );
-               if( rc != LDAP_SUCCESS ) {
-                       dn.bv_val = NULL;
-                       dn.bv_len = 0;
-                       goto FINISHED;
-               }
-               dn = ndn;
-       }
+       
+       ldap_pvt_thread_mutex_destroy( &op.o_abandonmutex );
 
 FINISHED:
        if( searchbase.bv_len ) ch_free( searchbase.bv_val );
        if( filter ) filter_free( filter );
        if( uri ) ch_free( uri );
-       if( conn ) connection_internal_close( conn );
-       if( res ) ldap_msgfree( res );
-       if( client  ) ldap_unbind( client );
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
                "slap_sasl2dn: Converted SASL name to %s\n",
-               dn.bv_len ? dn.bv_val : "<nothing>" ));
+               dn->bv_len ? dn->bv_val : "<nothing>" ));
 #else
        Debug( LDAP_DEBUG_TRACE, "<==slap_sasl2dn: Converted SASL name to %s\n",
-               dn.bv_len ? dn.bv_val : "<nothing>", 0, 0 );
+               dn->bv_len ? dn->bv_val : "<nothing>", 0, 0 );
 #endif
 
-       return( dn.bv_val );
+       return;
 }
 
+typedef struct smatch_info {
+       struct berval *dn;
+       int match;
+} smatch_info;
+
+static int sasl_sc_smatch( BackendDB *be, Connection *conn, Operation *o,
+       Entry *e, AttributeName *an, int ao, LDAPControl **c)
+{
+       smatch_info *sm = o->o_callback->sc_private;
+
+       if (dn_match(sm->dn, &e->e_nname)) {
+               sm->match = 1;
+               return -1;      /* short-circuit the search */
+       } else {
+               return 1;
+       }
+}
 
 /*
  * Map a SASL regexp rule to a DN. If the rule is just a DN or a scope=base
@@ -429,23 +474,23 @@ FINISHED:
  */
 
 static
-int slap_sasl_match( char *rule, char *assertDN, char *authc )
+int slap_sasl_match( char *rule, struct berval *assertDN, struct berval *authc )
 {
        struct berval searchbase = {0, NULL};
        int rc, scope;
        Backend *be;
        Filter *filter=NULL;
-       Connection *conn=NULL;
-       LDAP *client=NULL;
-       LDAPMessage *res=NULL, *msg;
        regex_t reg;
+       smatch_info sm;
+       slap_callback cb = {sasl_sc_r, sasl_sc_s, sasl_sc_smatch, &sm};
+       Operation op = {0};
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "slap_sasl_match: comparing DN %s to rule %s\n", assertDN, rule ));
+               "slap_sasl_match: comparing DN %s to rule %s\n", assertDN->bv_val, rule ));
 #else
        Debug( LDAP_DEBUG_TRACE,
-          "===>slap_sasl_match: comparing DN %s to rule %s\n", assertDN, rule, 0 );
+          "===>slap_sasl_match: comparing DN %s to rule %s\n", assertDN->bv_val, rule, 0 );
 #endif
 
        rc = slap_parseURI( rule, &searchbase, &scope, &filter );
@@ -457,7 +502,7 @@ int slap_sasl_match( char *rule, char *assertDN, char *authc )
                rc = regcomp(&reg, searchbase.bv_val,
                        REG_EXTENDED|REG_ICASE|REG_NOSUB);
                if ( rc == 0 ) {
-                       rc = regexec(&reg, assertDN, 0, NULL, 0);
+                       rc = regexec(&reg, assertDN->bv_val, 0, NULL, 0);
                        regfree( &reg );
                }
                if ( rc == 0 )
@@ -486,52 +531,30 @@ int slap_sasl_match( char *rule, char *assertDN, char *authc )
        }
        suffix_alias( be, &searchbase );
 
-       /* Make an internal connection on which to run the search */
-       rc = connection_internal_open( &conn, &client, authc );
-       if( rc != LDAP_SUCCESS )
-               goto CONCLUDED;
+       sm.dn = assertDN;
+       sm.match = 0;
+
+       ldap_pvt_thread_mutex_init( &op.o_abandonmutex );
+       op.o_tag = LDAP_REQ_SEARCH;
+       op.o_protocol = LDAP_VERSION3;
+       op.o_ndn = *authc;
+       op.o_callback = &cb;
+       op.o_time = slap_get_time();
 
-       (*be->be_search)( be, conn, STAILQ_FIRST(&conn->c_ops), /*base=*/NULL, &searchbase,
+       (*be->be_search)( be, /*conn=*/NULL, &op, /*base=*/NULL, &searchbase,
           scope, /*deref=*/1, /*sizelimit=*/0, /*time=*/0, filter, /*fstr=*/NULL,
           /*attrs=*/NULL, /*attrsonly=*/0 );
 
-       /* On the client side of the internal search, read the results. Check
-          if the assertDN matches any of the DN's returned by the search */
-       rc = ldap_result( client, LDAP_RES_ANY, LDAP_MSG_ALL, NULL, &res );
-       if( rc == -1 )
-               goto CONCLUDED;
+       ldap_pvt_thread_mutex_destroy( &op.o_abandonmutex );
 
-       for( msg=ldap_first_entry( client, res );
-             msg;
-             msg=ldap_next_entry( client, msg ) )
-       {
-               struct berval dn;
-               dn.bv_val = ldap_get_dn( client, msg );
-
-               if( dn.bv_val ) {
-                       struct berval ndn;
-                       dn.bv_len = strlen( dn.bv_val );
-                       rc = dnNormalize2( NULL, &dn, &ndn );
-                       ldap_memfree( dn.bv_val );
-                       if( rc != LDAP_SUCCESS ) {
-                               goto CONCLUDED;
-                       }
-                       rc = strcmp( ndn.bv_val, assertDN );
-                       free( ndn.bv_val );
-                       if( rc == 0 ) {
-                               rc = LDAP_SUCCESS;
-                               goto CONCLUDED;
-                       }
-               }
-       }
-       rc = LDAP_INAPPROPRIATE_AUTH;
+       if (sm.match)
+               rc = LDAP_SUCCESS;
+       else
+               rc = LDAP_INAPPROPRIATE_AUTH;
 
 CONCLUDED:
        if( searchbase.bv_len ) ch_free( searchbase.bv_val );
        if( filter ) filter_free( filter );
-       if( conn ) connection_internal_close( conn );
-       if( res ) ldap_msgfree( res );
-       if( client  ) ldap_unbind( client );
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
                   "slap_sasl_match: comparison returned %d\n", rc ));
@@ -544,9 +567,6 @@ CONCLUDED:
 }
 
 
-
-
-
 /*
  * This function answers the question, "Can this ID authorize to that ID?",
  * based on authorization rules. The rules are stored in the *searchDN, in the
@@ -555,71 +575,71 @@ CONCLUDED:
  *
  * DN's passed in should have a dn: prefix
  */
-
 static int
-slap_sasl_check_authz(char *searchDN, char *assertDN, char *attr, char *authc)
+slap_sasl_check_authz(struct berval *searchDN, struct berval *assertDN, struct berval *attr, struct berval *authc)
 {
        const char *errmsg;
        int i, rc;
-       struct berval **vals=NULL;
+       BerVarray vals=NULL;
        AttributeDescription *ad=NULL;
        struct berval bv;
 
-
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
                   "slap_sasl_check_authz: does %s match %s rule in %s?\n",
-                  assertDN, attr, searchDN ));
+                  assertDN->bv_val, attr->bv_val, searchDN->bv_val ));
 #else
        Debug( LDAP_DEBUG_TRACE,
           "==>slap_sasl_check_authz: does %s match %s rule in %s?\n",
-          assertDN, attr, searchDN);
+          assertDN->bv_val, attr->bv_val, searchDN->bv_val);
 #endif
 
-       rc = slap_str2ad( attr, &ad, &errmsg );
+       rc = slap_bv2ad( attr, &ad, &errmsg );
        if( rc != LDAP_SUCCESS )
                goto COMPLETE;
 
-       bv.bv_val = searchDN+3;
-       bv.bv_len = strlen(bv.bv_val);
+       bv.bv_val = searchDN->bv_val + 3;
+       bv.bv_len = searchDN->bv_len - 3;
        rc = backend_attribute( NULL, NULL, NULL, NULL, &bv, ad, &vals );
        if( rc != LDAP_SUCCESS )
                goto COMPLETE;
 
+       bv.bv_val = assertDN->bv_val + 3;
+       bv.bv_len = assertDN->bv_len - 3;
        /* Check if the *assertDN matches any **vals */
-       for( i=0; vals[i] != NULL; i++ ) {
-               rc = slap_sasl_match( vals[i]->bv_val, assertDN+3, authc );
+       for( i=0; vals[i].bv_val != NULL; i++ ) {
+               rc = slap_sasl_match( vals[i].bv_val, &bv, authc );
                if ( rc == LDAP_SUCCESS )
                        goto COMPLETE;
        }
        rc = LDAP_INAPPROPRIATE_AUTH;
 
 COMPLETE:
-       if( vals ) ber_bvecfree( vals );
+       if( vals ) ber_bvarray_free( vals );
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_check_authz: %s check returning %s\n", attr, rc ));
+                  "slap_sasl_check_authz: %s check returning %s\n", attr->bv_val, rc ));
 #else
        Debug( LDAP_DEBUG_TRACE,
-          "<==slap_sasl_check_authz: %s check returning %d\n", attr, rc, 0);
+          "<==slap_sasl_check_authz: %s check returning %d\n", attr->bv_val, rc, 0);
 #endif
 
        return( rc );
 }
-
-
-
 #endif /* HAVE_CYRUS_SASL */
 
 
-
-
-
 /* Check if a bind can SASL authorize to another identity.
    Accepts authorization DN's with "dn:" prefix */
 
-int slap_sasl_authorized( char *authcDN, char *authzDN )
+static struct berval sasl_authz_src = {
+       sizeof(SASL_AUTHZ_SOURCE_ATTR)-1, SASL_AUTHZ_SOURCE_ATTR };
+
+static struct berval sasl_authz_dst = {
+       sizeof(SASL_AUTHZ_DEST_ATTR)-1, SASL_AUTHZ_DEST_ATTR };
+
+int slap_sasl_authorized( struct berval *authcDN, struct berval *authzDN )
 {
        int rc = LDAP_INAPPROPRIATE_AUTH;
 
@@ -632,28 +652,27 @@ int slap_sasl_authorized( char *authcDN, char *authzDN )
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_authorized: can %s become %s?\n", authcDN, authzDN ));
+               "slap_sasl_authorized: can %s become %s?\n", authcDN->bv_val, authzDN->bv_val ));
 #else
        Debug( LDAP_DEBUG_TRACE,
-          "==>slap_sasl_authorized: can %s become %s?\n", authcDN, authzDN, 0 );
+          "==>slap_sasl_authorized: can %s become %s?\n", authcDN->bv_val, authzDN->bv_val, 0 );
 #endif
 
-
        /* If person is authorizing to self, succeed */
-       if ( !strcmp( authcDN, authzDN ) ) {
+       if ( dn_match( authcDN, authzDN ) ) {
                rc = LDAP_SUCCESS;
                goto DONE;
        }
 
        /* Check source rules */
-       rc = slap_sasl_check_authz( authcDN, authzDN, SASL_AUTHZ_SOURCE_ATTR,
+       rc = slap_sasl_check_authz( authcDN, authzDN, &sasl_authz_src,
           authcDN );
        if( rc == LDAP_SUCCESS ) {
                goto DONE;
        }
 
        /* Check destination rules */
-       rc = slap_sasl_check_authz( authzDN, authcDN, SASL_AUTHZ_DEST_ATTR,
+       rc = slap_sasl_check_authz( authzDN, authcDN, &sasl_authz_dst,
           authcDN );
        if( rc == LDAP_SUCCESS ) {
                goto DONE;
@@ -666,9 +685,10 @@ DONE:
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-                  "slap_sasl_authorized: return %d\n", rc ));
+               "slap_sasl_authorized: return %d\n", rc ));
 #else
-       Debug( LDAP_DEBUG_TRACE, "<== slap_sasl_authorized: return %d\n",rc,0,0 );
+       Debug( LDAP_DEBUG_TRACE,
+               "<== slap_sasl_authorized: return %d\n", rc, 0, 0 );
 #endif
 
        return( rc );