]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/saslauthz.c
limit checking in syncrepl
[openldap] / servers / slapd / saslauthz.c
index d57a45128c870edf77901d3055a0a9bb9e0105e2..ca6fd0ae9815a53d2f17e56590f94e8b15695b80 100644 (file)
@@ -27,6 +27,7 @@
 #include <limits.h>
 
 #include <ldap_pvt.h>
+#include "lutil.h"
 
 #define SASLREGEX_REPLACE 10
 
@@ -35,6 +36,8 @@
 #define LDAP_X_SCOPE_CHILDREN  ((ber_int_t) 0x0030)
 #define LDAP_X_SCOPE_SUBTREE   ((ber_int_t) 0x0040)
 #define LDAP_X_SCOPE_ONELEVEL  ((ber_int_t) 0x0050)
+#define LDAP_X_SCOPE_GROUP     ((ber_int_t) 0x0060)
+#define LDAP_X_SCOPE_USERS     ((ber_int_t) 0x0070)
 
 /*
  * IDs in DNauthzid form can now have a type specifier, that
@@ -73,11 +76,11 @@ typedef struct sasl_regexp {
 static int nSaslRegexp = 0;
 static SaslRegexp_t *SaslRegexp = NULL;
 
-#ifdef SLAP_SASL_REWRITE
+#ifdef SLAP_AUTH_REWRITE
 #include "rewrite.h"
 struct rewrite_info    *sasl_rwinfo = NULL;
 #define AUTHID_CONTEXT "authid"
-#endif /* SLAP_SASL_REWRITE */
+#endif /* SLAP_AUTH_REWRITE */
 
 /* What SASL proxy authorization policies are allowed? */
 #define        SASL_AUTHZ_NONE 0x00
@@ -87,6 +90,10 @@ struct rewrite_info  *sasl_rwinfo = NULL;
 
 static int authz_policy = SASL_AUTHZ_NONE;
 
+static
+int slap_sasl_match( Operation *opx, struct berval *rule,
+       struct berval *assertDN, struct berval *authc );
+
 int slap_sasl_setpolicy( const char *arg )
 {
        int rc = LDAP_SUCCESS;
@@ -208,6 +215,13 @@ static int slap_parseURI( Operation *op, struct berval *uri,
 #endif
 
        rc = LDAP_PROTOCOL_ERROR;
+       /*
+        * dn[.<dnstyle>]:<dnpattern>
+        * <dnstyle> ::= {exact|regex|children|subtree|onelevel}
+        *
+        * <dnstyle> defaults to "exact"
+        * if <dnstyle> is not "regex", <dnpattern> must pass DN normalization
+        */
        if ( !strncasecmp( uri->bv_val, "dn", STRLENOF( "dn" ) ) ) {
                bv.bv_val = uri->bv_val + STRLENOF( "dn" );
 
@@ -222,7 +236,7 @@ static int slap_parseURI( Operation *op, struct berval *uri,
                                bv.bv_val += STRLENOF( "regex:" );
                                *scope = LDAP_X_SCOPE_REGEX;
 
-                       } else if ( !strncasecmp( bv.bv_val, "children:", STRLENOF( "chldren:" ) ) ) {
+                       } else if ( !strncasecmp( bv.bv_val, "children:", STRLENOF( "children:" ) ) ) {
                                bv.bv_val += STRLENOF( "children:" );
                                *scope = LDAP_X_SCOPE_CHILDREN;
 
@@ -237,18 +251,25 @@ static int slap_parseURI( Operation *op, struct berval *uri,
                        } else {
                                return LDAP_PROTOCOL_ERROR;
                        }
-               }
 
-               if ( bv.bv_val[ 0 ] != ':' ) {
-                       return LDAP_PROTOCOL_ERROR;
+               } else {
+                       if ( bv.bv_val[ 0 ] != ':' ) {
+                               return LDAP_PROTOCOL_ERROR;
+                       }
+                       *scope = LDAP_X_SCOPE_EXACT;
+                       bv.bv_val++;
                }
-               bv.bv_val++;
 
                bv.bv_val += strspn( bv.bv_val, " " );
                /* jump here in case no type specification was present
-                * and uir was not an URI... HEADS-UP: assuming EXACT */
+                * and uri was not an URI... HEADS-UP: assuming EXACT */
 is_dn:         bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
 
+               /* a single '*' means any DN without using regexes */
+               if ( ber_bvccmp( &bv, '*' ) ) {
+                       *scope = LDAP_X_SCOPE_USERS;
+               }
+
                switch ( *scope ) {
                case LDAP_X_SCOPE_EXACT:
                case LDAP_X_SCOPE_CHILDREN:
@@ -262,6 +283,8 @@ is_dn:              bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
 
                case LDAP_X_SCOPE_REGEX:
                        ber_dupbv_x( nbase, &bv, op->o_tmpmemctx );
+
+               case LDAP_X_SCOPE_USERS:
                        rc = LDAP_SUCCESS;
                        break;
 
@@ -272,6 +295,9 @@ is_dn:              bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
 
                return rc;
 
+       /*
+        * u:<uid>
+        */
        } else if ( ( uri->bv_val[ 0 ] == 'u' || uri->bv_val[ 0 ] == 'U' )
                        && ( uri->bv_val[ 1 ] == ':' 
                                || uri->bv_val[ 1 ] == '/' 
@@ -311,11 +337,90 @@ is_dn:            bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
                }
 
                return rc;
-       }
+
+       /*
+        * group[/<groupoc>[/<groupat>]]:<groupdn>
+        *
+        * groupoc defaults to "groupOfNames"
+        * groupat defaults to "member"
+        * 
+        * <groupdn> must pass DN normalization
+        */
+       } else if ( strncasecmp( uri->bv_val, "group", STRLENOF( "group" ) ) == 0 )
+       {
+               struct berval   group_dn = BER_BVNULL,
+                               group_oc = BER_BVNULL,
+                               member_at = BER_BVNULL;
+               char            *tmp;
+
+               bv.bv_val = uri->bv_val + STRLENOF( "group" );
+               group_dn.bv_val = strchr( bv.bv_val, ':' );
+               if ( group_dn.bv_val == NULL ) {
+                       /* last chance: assume it's a(n exact) DN ... */
+                       bv.bv_val = uri->bv_val;
+                       *scope = LDAP_X_SCOPE_EXACT;
+                       goto is_dn;
+               }
                
+               if ( bv.bv_val[ 0 ] == '/' ) {
+                       group_oc.bv_val = &bv.bv_val[ 1 ];
+
+                       member_at.bv_val = strchr( group_oc.bv_val, '/' );
+                       if ( member_at.bv_val ) {
+                               group_oc.bv_len = member_at.bv_val - group_oc.bv_val;
+                               member_at.bv_val++;
+                               member_at.bv_len = group_dn.bv_val - member_at.bv_val;
+
+                       } else {
+                               group_oc.bv_len = group_dn.bv_val - group_oc.bv_val;
+                               BER_BVSTR( &member_at, "member" );
+                       }
+
+               } else {
+                       BER_BVSTR( &group_oc, "groupOfNames" );
+               }
+               group_dn.bv_val++;
+               group_dn.bv_len = uri->bv_len - ( group_dn.bv_val - uri->bv_val );
+
+               rc = dnNormalize( 0, NULL, NULL, &group_dn, nbase, op->o_tmpmemctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       *scope = -1;
+                       return rc;
+               }
+               *scope = LDAP_X_SCOPE_GROUP;
+
+               /* FIXME: caller needs to add value of member attribute
+                * and close brackets twice */
+               fstr->bv_len = STRLENOF( "(&(objectClass=)(=" /* )) */ )
+                       + group_oc.bv_len + member_at.bv_len;
+               fstr->bv_val = ch_malloc( fstr->bv_len + 1 );
+
+               tmp = lutil_strncopy( fstr->bv_val, "(&(objectClass=" /* )) */ ,
+                               STRLENOF( "(&(objectClass=" /* )) */ ) );
+               tmp = lutil_strncopy( tmp, group_oc.bv_val, group_oc.bv_len );
+               tmp = lutil_strncopy( tmp, /* ( */ ")(" /* ) */ ,
+                               STRLENOF( /* ( */ ")(" /* ) */ ) );
+               tmp = lutil_strncopy( tmp, member_at.bv_val, member_at.bv_len );
+               tmp = lutil_strncopy( tmp, "=", STRLENOF( "=" ) );
+
+               return rc;
+       }
+
+       /*
+        * ldap:///<base>??<scope>?<filter>
+        * <scope> ::= {base|one|subtree}
+        *
+        * <scope> defaults to "base"
+        * <base> must pass DN normalization
+        * <filter> must pass str2filter()
+        */
        rc = ldap_url_parse( uri->bv_val, &ludp );
        if ( rc == LDAP_URL_ERR_BADSCHEME ) {
-               /* last chance: assume it's a(n exact) DN ... */
+               /*
+                * last chance: assume it's a(n exact) DN ...
+                *
+                * NOTE: must pass DN normalization
+                */
                bv.bv_val = uri->bv_val;
                *scope = LDAP_X_SCOPE_EXACT;
                goto is_dn;
@@ -406,7 +511,7 @@ static int slap_sasl_rx_off(char *rep, int *off)
        return( LDAP_SUCCESS );
 }
 
-#ifdef SLAP_SASL_REWRITE
+#ifdef SLAP_AUTH_REWRITE
 int slap_sasl_rewrite_config( 
                const char      *fname,
                int             lineno,
@@ -434,7 +539,7 @@ int slap_sasl_rewrite_config(
 int slap_sasl_rewrite_destroy( void )
 {
        if ( sasl_rwinfo ) {
-               rewrite_info_delete( sasl_rwinfo );
+               rewrite_info_delete( &sasl_rwinfo );
                sasl_rwinfo = NULL;
        }
 
@@ -449,15 +554,12 @@ int slap_sasl_regexp_rewrite_config(
                const char      *context )
 {
        int     rc;
-       char    *newreplace, *p;
-       char    *argvRule[] = { "rewriteRule", NULL, NULL, "@", NULL };
+       char    *argvRule[] = { "rewriteRule", NULL, NULL, ":@", NULL };
 
        /* init at first call */
        if ( sasl_rwinfo == NULL ) {
                char *argvEngine[] = { "rewriteEngine", "on", NULL };
                char *argvContext[] = { "rewriteContext", NULL, NULL };
-               char *argvFirstRule[] = { "rewriteRule", ".*", 
-                       "%{>" AUTHID_CONTEXT "(%0)}", ":", NULL };
 
                /* initialize rewrite engine */
                sasl_rwinfo = rewrite_info_init( REWRITE_MODE_USE_DEFAULT );
@@ -476,31 +578,20 @@ int slap_sasl_regexp_rewrite_config(
                }
        }
 
-       newreplace = ch_strdup( replace );
-       
-       for (p = strchr( newreplace, '$' ); p; p = strchr( p + 1, '$' ) ) {
-               if ( isdigit( p[1] ) ) {
-                       p[0] = '%';
-               } else {
-                       p++;
-               }
-       }
-
        argvRule[1] = (char *)match;
-       argvRule[2] = newreplace;
+       argvRule[2] = (char *)replace;
        rc = rewrite_parse( sasl_rwinfo, fname, lineno, 4, argvRule );
-       ch_free( newreplace );
 
        return rc;
 }
-#endif /* SLAP_SASL_REWRITE */
+#endif /* SLAP_AUTH_REWRITE */
 
 int slap_sasl_regexp_config( const char *match, const char *replace )
 {
-#ifdef SLAP_SASL_REWRITE
+#ifdef SLAP_AUTH_REWRITE
        return slap_sasl_regexp_rewrite_config( "sasl-regexp", 0,
                        match, replace, AUTHID_CONTEXT );
-#else /* ! SLAP_SASL_REWRITE */
+#else /* ! SLAP_AUTH_REWRITE */
        int rc;
        SaslRegexp_t *reg;
 
@@ -533,7 +624,7 @@ int slap_sasl_regexp_config( const char *match, const char *replace )
 
        nSaslRegexp++;
        return( LDAP_SUCCESS );
-#endif /* ! SLAP_SASL_REWRITE */
+#endif /* ! SLAP_AUTH_REWRITE */
 }
 
 /* Perform replacement on regexp matches */
@@ -592,10 +683,10 @@ static void slap_sasl_rx_exp(
    LDAP URI to find the matching LDAP entry, using the pattern matching
    strings given in the saslregexp config file directive(s) */
 
-static int slap_sasl_regexp( struct berval *in, struct berval *out,
+static int slap_authz_regexp( struct berval *in, struct berval *out,
                int flags, void *ctx )
 {
-#ifdef SLAP_SASL_REWRITE
+#ifdef SLAP_AUTH_REWRITE
        const char      *context = AUTHID_CONTEXT;
 
        if ( sasl_rwinfo == NULL || BER_BVISNULL( in ) ) {
@@ -632,7 +723,7 @@ static int slap_sasl_regexp( struct berval *in, struct berval *out,
                return 0;
        }
 
-#else /* ! SLAP_SASL_REWRITE */
+#else /* ! SLAP_AUTH_REWRITE */
        char *saslname = in->bv_val;
        SaslRegexp_t *reg;
        regmatch_t sr_strings[SASLREGEX_REPLACE];       /* strings matching $1,$2 ... */
@@ -642,9 +733,9 @@ static int slap_sasl_regexp( struct berval *in, struct berval *out,
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
-               "slap_sasl_regexp: converting SASL name %s\n", saslname, 0, 0 );
+               "slap_authz_regexp: converting SASL name %s\n", saslname, 0, 0 );
 #else
-       Debug( LDAP_DEBUG_TRACE, "slap_sasl_regexp: converting SASL name %s\n",
+       Debug( LDAP_DEBUG_TRACE, "slap_authz_regexp: converting SASL name %s\n",
           saslname, 0, 0 );
 #endif
 
@@ -671,16 +762,16 @@ static int slap_sasl_regexp( struct berval *in, struct berval *out,
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
-               "slap_sasl_regexp: converted SASL name to %s\n",
+               "slap_authz_regexp: converted SASL name to %s\n",
                BER_BVISEMPTY( out ) ? "" : out->bv_val, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE,
-               "slap_sasl_regexp: converted SASL name to %s\n",
+               "slap_authz_regexp: converted SASL name to %s\n",
                BER_BVISEMPTY( out ) ? "" : out->bv_val, 0, 0 );
 #endif
 
        return( 1 );
-#endif /* ! SLAP_SASL_REWRITE */
+#endif /* ! SLAP_AUTH_REWRITE */
 }
 
 /* This callback actually does some work...*/
@@ -719,14 +810,44 @@ static int sasl_sc_smatch( Operation *o, SlapReply *rs )
 {
        smatch_info *sm = o->o_callback->sc_private;
 
-       if (rs->sr_type != REP_SEARCH) return 0;
+       if ( rs->sr_type != REP_SEARCH ) {
+               if ( rs->sr_err != LDAP_SUCCESS ) {
+                       sm->match = -1;
+               }
+               return 0;
+       }
+
+       if ( sm->match == 1 ) {
+               sm->match = -1;
+               return 0;
+       }
 
        if (dn_match(sm->dn, &rs->sr_entry->e_nname)) {
                sm->match = 1;
-               return -1;      /* short-circuit the search */
+
+       } else {
+               sm->match = -1;
        }
 
-       return 1;
+       return 0;
+}
+
+int
+slap_sasl_matches( Operation *op, BerVarray rules,
+               struct berval *assertDN, struct berval *authc )
+{
+       int     rc = LDAP_INAPPROPRIATE_AUTH;
+
+       if ( rules != NULL ) {
+               int     i;
+
+               for( i = 0; !BER_BVISNULL( &rules[i] ); i++ ) {
+                       rc = slap_sasl_match( op, &rules[i], assertDN, authc );
+                       if ( rc == LDAP_SUCCESS ) break;
+               }
+       }
+       
+       return rc;
 }
 
 /*
@@ -749,6 +870,10 @@ int slap_sasl_match( Operation *opx, struct berval *rule,
        Operation op = {0};
        SlapReply rs = {REP_RESULT};
 
+       sm.dn = assertDN;
+       sm.match = 0;
+       cb.sc_private = &sm;
+
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
                "slap_sasl_match: comparing DN %s to rule %s\n", 
@@ -764,9 +889,7 @@ int slap_sasl_match( Operation *opx, struct berval *rule,
                &op.ors_filterstr );
        if( rc != LDAP_SUCCESS ) goto CONCLUDED;
 
-       /* Massive shortcut: search scope == base */
        switch ( op.oq_search.rs_scope ) {
-       case LDAP_SCOPE_BASE:
        case LDAP_X_SCOPE_EXACT:
 exact_match:
                if ( dn_match( &op.o_req_ndn, assertDN ) ) {
@@ -843,6 +966,48 @@ exact_match:
                }
                goto CONCLUDED;
 
+       case LDAP_X_SCOPE_GROUP: {
+               char    *tmp;
+
+               /* Now filterstr looks like "(&(objectClass=<group_oc>)(<member_at>="
+                * we need to append the <assertDN> so that the <group_dn> is searched
+                * with scope "base", and the filter ensures that <assertDN> is
+                * member of the group */
+               tmp = ch_realloc( op.ors_filterstr.bv_val, op.ors_filterstr.bv_len +
+                       assertDN->bv_len + STRLENOF( /*"(("*/ "))" ) + 1 );
+               if ( tmp == NULL ) {
+                       rc = LDAP_NO_MEMORY;
+                       goto CONCLUDED;
+               }
+               op.ors_filterstr.bv_val = tmp;
+               
+               tmp = lutil_strcopy( &tmp[op.ors_filterstr.bv_len], assertDN->bv_val );
+               tmp = lutil_strcopy( tmp, /*"(("*/ "))" );
+
+               /* pass opx because str2filter_x may (and does) use o_tmpmfuncs */
+               op.ors_filter = str2filter_x( opx, op.ors_filterstr.bv_val );
+               if ( op.ors_filter == NULL ) {
+                       rc = LDAP_PROTOCOL_ERROR;
+                       goto CONCLUDED;
+               }
+               op.ors_scope = LDAP_SCOPE_BASE;
+
+               /* hijack match DN: use that of the group instead of the assertDN;
+                * assertDN is now in the filter */
+               sm.dn = &op.o_req_ndn;
+
+               /* do the search */
+               break;
+               }
+
+       case LDAP_X_SCOPE_USERS:
+               if ( !BER_BVISEMPTY( assertDN ) ) {
+                       rc = LDAP_SUCCESS;
+               } else {
+                       rc = LDAP_INAPPROPRIATE_AUTH;
+               }
+               goto CONCLUDED;
+
        default:
                break;
        }
@@ -869,10 +1034,6 @@ exact_match:
                goto CONCLUDED;
        }
 
-       sm.dn = assertDN;
-       sm.match = 0;
-       cb.sc_private = &sm;
-
        op.o_tag = LDAP_REQ_SEARCH;
        op.o_protocol = LDAP_VERSION3;
        op.o_ndn = *authc;
@@ -888,23 +1049,26 @@ exact_match:
 #endif
        op.o_conn = opx->o_conn;
        op.o_connid = opx->o_connid;
-       op.o_req_dn = op.o_req_ndn;
+       /* use req_ndn as req_dn instead of non-pretty base of uri */
+       if( !BER_BVISNULL( &op.o_req_dn ) ) ch_free( op.o_req_dn.bv_val );
+       ber_dupbv_x( &op.o_req_dn, &op.o_req_ndn, op.o_tmpmemctx );
        op.oq_search.rs_slimit = 1;
-       op.oq_search.rs_tlimit = -1;
+       op.oq_search.rs_tlimit = SLAP_NO_LIMIT;
+       op.o_sync_slog_size = -1;
 
        op.o_bd->be_search( &op, &rs );
 
-       if (sm.match) {
+       if (sm.match == 1) {
                rc = LDAP_SUCCESS;
        } else {
                rc = LDAP_INAPPROPRIATE_AUTH;
        }
 
 CONCLUDED:
-       if( op.o_req_dn.bv_len ) ch_free( op.o_req_dn.bv_val );
-       if( op.o_req_ndn.bv_len ) slap_sl_free( op.o_req_ndn.bv_val, opx->o_tmpmemctx );
+       if( !BER_BVISNULL( &op.o_req_dn ) ) slap_sl_free( op.o_req_dn.bv_val, opx->o_tmpmemctx );
+       if( !BER_BVISNULL( &op.o_req_ndn ) ) slap_sl_free( op.o_req_ndn.bv_val, opx->o_tmpmemctx );
        if( op.oq_search.rs_filter ) filter_free_x( opx, op.oq_search.rs_filter );
-       if( op.ors_filterstr.bv_len ) ch_free( op.ors_filterstr.bv_val );
+       if( !BER_BVISNULL( &op.ors_filterstr ) ) ch_free( op.ors_filterstr.bv_val );
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
@@ -934,7 +1098,7 @@ slap_sasl_check_authz( Operation *op,
        struct berval *authc )
 {
        int i, rc;
-       BerVarray vals=NULL;
+       BerVarray vals = NULL;
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY, 
@@ -946,18 +1110,11 @@ slap_sasl_check_authz( Operation *op,
           assertDN->bv_val, ad->ad_cname.bv_val, searchDN->bv_val);
 #endif
 
-       rc = backend_attribute( op, NULL,
-               searchDN, ad, &vals );
+       rc = backend_attribute( op, NULL, searchDN, ad, &vals );
        if( rc != LDAP_SUCCESS ) goto COMPLETE;
 
-       /* Check if the *assertDN matches any **vals */
-       if( vals != NULL ) {
-               for( i=0; !BER_BVISNULL( &vals[i] ); i++ ) {
-                       rc = slap_sasl_match( op, &vals[i], assertDN, authc );
-                       if ( rc == LDAP_SUCCESS ) goto COMPLETE;
-               }
-       }
-       rc = LDAP_INAPPROPRIATE_AUTH;
+       /* Check if the *assertDN matches any *vals */
+       rc = slap_sasl_matches( op, vals, assertDN, authc );
 
 COMPLETE:
        if( vals ) ber_bvarray_free_x( vals, op->o_tmpmemctx );
@@ -1007,7 +1164,7 @@ void slap_sasl2dn( Operation *opx,
        cb.sc_private = sasldn;
 
        /* Convert the SASL name into a minimal URI */
-       if( !slap_sasl_regexp( saslname, &regout, flags, opx->o_tmpmemctx ) ) {
+       if( !slap_authz_regexp( saslname, &regout, flags, opx->o_tmpmemctx ) ) {
                goto FINISHED;
        }
 
@@ -1022,9 +1179,7 @@ void slap_sasl2dn( Operation *opx,
        /* Must do an internal search */
        op.o_bd = select_backend( &op.o_req_ndn, 0, 1 );
 
-       /* Massive shortcut: search scope == base */
        switch ( op.oq_search.rs_scope ) {
-       case LDAP_SCOPE_BASE:
        case LDAP_X_SCOPE_EXACT:
                *sasldn = op.o_req_ndn;
                BER_BVZERO( &op.o_req_ndn );
@@ -1034,9 +1189,12 @@ void slap_sasl2dn( Operation *opx,
        case LDAP_X_SCOPE_SUBTREE:
        case LDAP_X_SCOPE_CHILDREN:
        case LDAP_X_SCOPE_ONELEVEL:
+       case LDAP_X_SCOPE_GROUP:
+       case LDAP_X_SCOPE_USERS:
                /* correctly parsed, but illegal */
                goto FINISHED;
 
+       case LDAP_SCOPE_BASE:
        case LDAP_SCOPE_ONELEVEL:
        case LDAP_SCOPE_SUBTREE:
 #ifdef LDAP_SCOPE_SUBORDINATE
@@ -1081,7 +1239,7 @@ void slap_sasl2dn( Operation *opx,
 #endif
        op.oq_search.rs_deref = LDAP_DEREF_NEVER;
        op.oq_search.rs_slimit = 1;
-       op.oq_search.rs_tlimit = -1;
+       op.oq_search.rs_tlimit = SLAP_NO_LIMIT;
        op.oq_search.rs_attrsonly = 1;
        /* use req_ndn as req_dn instead of non-pretty base of uri */
        if( !BER_BVISNULL( &op.o_req_dn ) ) ch_free( op.o_req_dn.bv_val );
@@ -1093,10 +1251,18 @@ FINISHED:
        if( !BER_BVISEMPTY( sasldn ) ) {
                opx->o_conn->c_authz_backend = op.o_bd;
        }
-       if( !BER_BVISNULL( &op.o_req_dn ) ) slap_sl_free( op.o_req_dn.bv_val, opx->o_tmpmemctx );
-       if( !BER_BVISNULL( &op.o_req_ndn ) ) slap_sl_free( op.o_req_ndn.bv_val, opx->o_tmpmemctx );
-       if( op.oq_search.rs_filter ) filter_free_x( opx, op.oq_search.rs_filter );
-       if( !BER_BVISNULL( &op.ors_filterstr ) ) ch_free( op.ors_filterstr.bv_val );
+       if( !BER_BVISNULL( &op.o_req_dn ) ) {
+               slap_sl_free( op.o_req_dn.bv_val, opx->o_tmpmemctx );
+       }
+       if( !BER_BVISNULL( &op.o_req_ndn ) ) {
+               slap_sl_free( op.o_req_ndn.bv_val, opx->o_tmpmemctx );
+       }
+       if( op.oq_search.rs_filter ) {
+               filter_free_x( opx, op.oq_search.rs_filter );
+       }
+       if( !BER_BVISNULL( &op.ors_filterstr ) ) {
+               ch_free( op.ors_filterstr.bv_val );
+       }
 
 #ifdef NEW_LOGGING
        LDAP_LOG( TRANSPORT, ENTRY,