]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/saslauthz.c
remove dbenv->lock_put() call from transaction-protected operations
[openldap] / servers / slapd / saslauthz.c
index d25ab6a09c00c5f5e86f00be779e94dbda30e037..d196a4f084ba1d4c1de2e9278fccc3d43d3dc513 100644 (file)
 
 #ifdef HAVE_CYRUS_SASL
 #include <limits.h>
+
+#ifdef HAVE_SASL_SASL_H
+#include <sasl/sasl.h>
+#else
 #include <sasl.h>
-#include <ldap_pvt.h>
 #endif
 
+#include <ldap_pvt.h>
+
 /* URI format: ldap://<host>/<base>[?[<attrs>][?[<scope>][?[<filter>]]]] */
 
-static int slap_parseURI( char *uri,
-       struct berval *searchbase, int *scope, Filter **filter )
+static int slap_parseURI( struct berval *uri,
+       struct berval *searchbase, int *scope, Filter **filter,
+       struct berval *fstr )
 {
-       char *start, *end;
        struct berval bv;
        int rc;
+       LDAPURLDesc *ludp;
 
-
-       assert( uri != NULL );
+       assert( uri != NULL && uri->bv_val != NULL );
        searchbase->bv_val = NULL;
        searchbase->bv_len = 0;
        *scope = -1;
        *filter = NULL;
 
+       if ( fstr ) {
+               fstr->bv_val = NULL;
+               fstr->bv_len = 0;
+       }
+
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "slap_parseURI: parsing %s\n", uri ));
+               "slap_parseURI: parsing %s\n", uri->bv_val ));
 #else
-       Debug( LDAP_DEBUG_TRACE, "slap_parseURI: parsing %s\n", uri, 0, 0 );
+       Debug( LDAP_DEBUG_TRACE, "slap_parseURI: parsing %s\n", uri->bv_val, 0, 0 );
 #endif
 
        /* If it does not look like a URI, assume it is a DN */
-       if( !strncasecmp( uri, "dn:", sizeof("dn:")-1 ) ) {
-               uri += sizeof("dn:")-1;
-               uri += strspn( uri, " " );
-               bv.bv_val = uri;
-               /* FIXME: if dnNormalize actually uses input bv_len we
-                * will have to make this right.
-                */
-is_dn:         bv.bv_len = 1;
+       if( !strncasecmp( uri->bv_val, "dn:", sizeof("dn:")-1 ) ) {
+               bv.bv_val = uri->bv_val + sizeof("dn:")-1;
+               bv.bv_val += strspn( bv.bv_val, " " );
+
+is_dn:         bv.bv_len = uri->bv_len - (bv.bv_val - uri->bv_val);
                rc = dnNormalize2( NULL, &bv, searchbase );
                if (rc == LDAP_SUCCESS) {
                        *scope = LDAP_SCOPE_BASE;
@@ -64,66 +71,83 @@ is_dn:              bv.bv_len = 1;
                return( rc );
        }
 
-       /* FIXME: should use ldap_url_parse() */
-       if( strncasecmp( uri, "ldap://", sizeof("ldap://")-1 ) ) {
-               bv.bv_val = uri;
+       rc = ldap_url_parse( uri->bv_val, &ludp );
+       if ( rc == LDAP_URL_ERR_BADSCHEME ) {
+               bv.bv_val = uri->bv_val;
                goto is_dn;
        }
 
-       end = strchr( uri + (sizeof("ldap://")-1), '/' );
-       if ( end == NULL )
+       if ( rc != LDAP_URL_SUCCESS ) {
                return( LDAP_PROTOCOL_ERROR );
+       }
 
        /* could check the hostname here */
 
-       /* Grab the searchbase */
-       start = end+1;
-       end = strchr( start, '?' );
-       bv.bv_val = start;
-       if( end == NULL ) {
-               bv.bv_len = 1;
-               return dnNormalize2( NULL, &bv, searchbase );
-       }
-       *end = '\0';
-       bv.bv_len = end - start;
-       rc = dnNormalize2( NULL, &bv, searchbase );
-       *end = '?';
-       if (rc != LDAP_SUCCESS)
-               return( rc );
+       /* Grab the scope */
+       *scope = ludp->lud_scope;
 
-       /* Skip the attrs */
-       start = end+1;
-       end = strchr( start, '?' );
-       if( end == NULL ) {
-               return( LDAP_SUCCESS );
+       /* Grab the filter */
+       if ( ludp->lud_filter ) {
+               *filter = str2filter( ludp->lud_filter );
+               if ( *filter == NULL )
+                       rc = LDAP_PROTOCOL_ERROR;
+               else if ( fstr )
+                       ber_str2bv( ludp->lud_filter, 0, 1, fstr );
        }
 
-       /* Grab the scope */
-       start = end+1;
-       if( !strncasecmp( start, "base?", sizeof("base?")-1 )) {
-               *scope = LDAP_SCOPE_BASE;
-               start += sizeof("base?")-1;
-       }
-       else if( !strncasecmp( start, "one?", sizeof("one?")-1 )) {
-               *scope = LDAP_SCOPE_ONELEVEL;
-               start += sizeof("one?")-1;
-       }
-       else if( !strncasecmp( start, "sub?", sizeof("sub?")-1 )) {
-               *scope = LDAP_SCOPE_SUBTREE;
-               start += sizeof("sub?")-1;
-       }
-       else {
-               free( searchbase->bv_val );
-               searchbase->bv_val = NULL;
-               return( LDAP_PROTOCOL_ERROR );
+       /* Grab the searchbase */
+       if ( rc == LDAP_URL_SUCCESS ) {
+               bv.bv_val = ludp->lud_dn;
+               bv.bv_len = strlen( bv.bv_val );
+               rc = dnNormalize2( NULL, &bv, searchbase );
        }
 
-       /* Grab the filter */
-       *filter = str2filter( start );
+       ldap_free_urldesc( ludp );
 
-       return( LDAP_SUCCESS );
+       return( rc );
 }
 
+static int slap_sasl_rx_off(char *rep, int *off)
+{
+       const char *c;
+       int n;
+
+       /* Precompile replace pattern. Find the $<n> placeholders */
+       off[0] = -2;
+       n = 1;
+       for ( c = rep;   *c;  c++ ) {
+               if ( *c == '\\' && c[1] ) {
+                       c++;
+                       continue;
+               }
+               if ( *c == '$' ) {
+                       if ( n == SASLREGEX_REPLACE ) {
+#ifdef NEW_LOGGING
+                               LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
+                                       "slap_sasl_regexp_config: \"%s\" has too many $n "
+                                               "placeholders (max %d)\n",
+                                       rep, SASLREGEX_REPLACE ));
+#else
+                               Debug( LDAP_DEBUG_ANY,
+                                       "SASL replace pattern %s has too many $n "
+                                               "placeholders (max %d)\n",
+                                       rep, SASLREGEX_REPLACE, 0 );
+#endif
+
+                               return( LDAP_OPERATIONS_ERROR );
+                       }
+                       off[n] = c - rep;
+                       n++;
+               }
+       }
+
+       /* Final placeholder, after the last $n */
+       off[n] = c - rep;
+       n++;
+       off[n] = -1;
+       return( LDAP_SUCCESS );
+}
+#endif /* HAVE_CYRUS_SASL */
 
 int slap_sasl_regexp_config( const char *match, const char *replace )
 {
@@ -132,6 +156,7 @@ int slap_sasl_regexp_config( const char *match, const char *replace )
        int rc, n;
        SaslRegexp_t *reg;
        struct berval bv, nbv;
+       Filter *filter;
 
        SaslRegexp = (SaslRegexp_t *) ch_realloc( (char *) SaslRegexp,
          (nSaslRegexp + 1) * sizeof(SaslRegexp_t) );
@@ -150,72 +175,49 @@ int slap_sasl_regexp_config( const char *match, const char *replace )
 #endif
                return( rc );
        }
-       reg->match = nbv.bv_val;
+       reg->sr_match = nbv.bv_val;
 
        ber_str2bv( replace, 0, 0, &bv );
-       rc = dnNormalize2( NULL, &bv, &nbv );
+       rc = slap_parseURI( &bv, &reg->sr_replace.dn, &reg->sr_replace.scope,
+               &filter, &reg->sr_replace.filter );
+       if ( filter ) filter_free( filter );
        if ( rc ) {
 #ifdef NEW_LOGGING
                LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
-                          "slap_sasl_regexp_config: \"%s\" could not be normalized.\n",
+                          "slap_sasl_regexp_config: \"%s\" could not be parsed.\n",
                           replace ));
 #else
                Debug( LDAP_DEBUG_ANY,
-               "SASL replace pattern %s could not be normalized.\n",
+               "SASL replace pattern %s could not be parsed.\n",
                replace, 0, 0 );
 #endif
                return( rc );
        }
-       reg->replace = nbv.bv_val;
 
        /* Precompile matching pattern */
-       rc = regcomp( &reg->workspace, reg->match, REG_EXTENDED|REG_ICASE );
+       rc = regcomp( &reg->sr_workspace, reg->sr_match, REG_EXTENDED|REG_ICASE );
        if ( rc ) {
 #ifdef NEW_LOGGING
                LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
                           "slap_sasl_regexp_config: \"%s\" could not be compiled.\n",
-                          reg->match ));
+                          reg->sr_match ));
 #else
                Debug( LDAP_DEBUG_ANY,
                "SASL match pattern %s could not be compiled by regexp engine\n",
-               reg->match, 0, 0 );
+               reg->sr_match, 0, 0 );
 #endif
 
                return( LDAP_OPERATIONS_ERROR );
        }
 
-       /* Precompile replace pattern. Find the $<n> placeholders */
-       reg->offset[0] = -2;
-       n = 1;
-       for ( c = reg->replace;  *c;  c++ ) {
-               if ( *c == '\\' ) {
-                       c++;
-                       continue;
-               }
-               if ( *c == '$' ) {
-                       if ( n == SASLREGEX_REPLACE ) {
-#ifdef NEW_LOGGING
-                               LDAP_LOG(( "sasl", LDAP_LEVEL_ERR,
-                                          "slap_sasl_regexp_config: \"%s\" has too many $n placeholders (max %d)\n",
-                                          reg->replace, SASLREGEX_REPLACE ));
-#else
-                               Debug( LDAP_DEBUG_ANY,
-                                  "SASL replace pattern %s has too many $n placeholders (max %d)\n",
-                                  reg->replace, SASLREGEX_REPLACE, 0 );
-#endif
+       rc = slap_sasl_rx_off( reg->sr_replace.dn.bv_val, reg->sr_dn_offset );
+       if ( rc != LDAP_SUCCESS ) return rc;
 
-                               return( LDAP_OPERATIONS_ERROR );
-                       }
-                       reg->offset[n] = c - reg->replace;
-                       n++;
-               }
+       if (reg->sr_replace.filter.bv_val ) {
+               rc = slap_sasl_rx_off( reg->sr_replace.filter.bv_val, reg->sr_fi_offset );
+               if ( rc != LDAP_SUCCESS ) return rc;
        }
 
-       /* Final placeholder, after the last $n */
-       reg->offset[n] = c - reg->replace;
-       n++;
-       reg->offset[n] = -1;
-
        nSaslRegexp++;
 #endif
        return( LDAP_SUCCESS );
@@ -224,15 +226,65 @@ int slap_sasl_regexp_config( const char *match, const char *replace )
 
 #ifdef HAVE_CYRUS_SASL
 
+/* Perform replacement on regexp matches */
+static void slap_sasl_rx_exp( char *rep, int *off, regmatch_t *str,
+       char *saslname, struct berval *out )
+{
+       int i, n, len, insert;
+
+       /* Get the total length of the final URI */
+
+       n=1;
+       len = 0;
+       while( off[n] >= 0 ) {
+               /* Len of next section from replacement string (x,y,z above) */
+               len += off[n] - off[n-1] - 2;
+               if( off[n+1] < 0)
+                       break;
+
+               /* Len of string from saslname that matched next $i  (b,d above) */
+               i = rep[ off[n] + 1 ]   - '0';
+               len += str[i].rm_eo - str[i].rm_so;
+               n++;
+       }
+       out->bv_val = ch_malloc( len + 1 );
+       out->bv_len = len;
+
+       /* Fill in URI with replace string, replacing $i as we go */
+       n=1;
+       insert = 0;
+       while( off[n] >= 0) {
+               /* Paste in next section from replacement string (x,y,z above) */
+               len = off[n] - off[n-1] - 2;
+               strncpy( out->bv_val+insert, rep + off[n-1] + 2, len);
+               insert += len;
+               if( off[n+1] < 0)
+                       break;
+
+               /* Paste in string from saslname that matched next $i  (b,d above) */
+               i = rep[ off[n] + 1 ]   - '0';
+               len = str[i].rm_eo - str[i].rm_so;
+               strncpy( out->bv_val+insert, saslname + str[i].rm_so, len );
+               insert += len;
+
+               n++;
+       }
+
+       out->bv_val[insert] = '\0';
+}
+
 /* Take the passed in SASL name and attempt to convert it into an
    LDAP URI to find the matching LDAP entry, using the pattern matching
    strings given in the saslregexp config file directive(s) */
-static
-char *slap_sasl_regexp( char *saslname )
+
+static int slap_sasl_regexp( struct berval *in, SaslUri_t *out )
 {
-       char *uri=NULL;
-       int i, n, len, insert;
+       char *saslname = in->bv_val;
+       char *scope[] = { "base", "one", "sub" };
        SaslRegexp_t *reg;
+       int i;
+
+       memset( out, 0, sizeof( *out ) );
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
@@ -243,72 +295,45 @@ char *slap_sasl_regexp( char *saslname )
 #endif
 
        if (( saslname == NULL ) || ( nSaslRegexp == 0 ))
-               return( NULL );
+               return( 0 );
 
        /* Match the normalized SASL name to the saslregexp patterns */
        for( reg = SaslRegexp,i=0;  i<nSaslRegexp;  i++,reg++ ) {
-               if ( regexec( &reg->workspace, saslname, SASLREGEX_REPLACE,
-                 reg->strings, 0)  == 0 )
+               if ( regexec( &reg->sr_workspace, saslname, SASLREGEX_REPLACE,
+                 reg->sr_strings, 0)  == 0 )
                        break;
        }
 
        if( i >= nSaslRegexp )
-               return( NULL );
+               return( 0 );
 
        /*
         * The match pattern may have been of the form "a(b.*)c(d.*)e" and the
         * replace pattern of the form "x$1y$2z". The returned string needs
         * to replace the $1,$2 with the strings that matched (b.*) and (d.*)
         */
+       slap_sasl_rx_exp( reg->sr_replace.dn.bv_val, reg->sr_dn_offset,
+               reg->sr_strings, saslname, &out->dn );
 
+       if ( reg->sr_replace.filter.bv_val )
+               slap_sasl_rx_exp( reg->sr_replace.filter.bv_val,
+                       reg->sr_fi_offset, reg->sr_strings, saslname, &out->filter );
+       
+       out->scope = reg->sr_replace.scope;
 
-       /* Get the total length of the final URI */
-
-       n=1;
-       len = 0;
-       while( reg->offset[n] >= 0 ) {
-               /* Len of next section from replacement string (x,y,z above) */
-               len += reg->offset[n] - reg->offset[n-1] - 2;
-               if( reg->offset[n+1] < 0)
-                       break;
-
-               /* Len of string from saslname that matched next $i  (b,d above) */
-               i = reg->replace[ reg->offset[n] + 1 ]  - '0';
-               len += reg->strings[i].rm_eo - reg->strings[i].rm_so;
-               n++;
-       }
-       uri = ch_malloc( len + 1 );
-
-       /* Fill in URI with replace string, replacing $i as we go */
-       n=1;
-       insert = 0;
-       while( reg->offset[n] >= 0) {
-               /* Paste in next section from replacement string (x,y,z above) */
-               len = reg->offset[n] - reg->offset[n-1] - 2;
-               strncpy( uri+insert, reg->replace + reg->offset[n-1] + 2, len);
-               insert += len;
-               if( reg->offset[n+1] < 0)
-                       break;
-
-               /* Paste in string from saslname that matched next $i  (b,d above) */
-               i = reg->replace[ reg->offset[n] + 1 ]  - '0';
-               len = reg->strings[i].rm_eo - reg->strings[i].rm_so;
-               strncpy( uri+insert, saslname + reg->strings[i].rm_so, len );
-               insert += len;
-
-               n++;
-       }
-
-       uri[insert] = '\0';
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "slap_sasl_regexp: converted SASL name to %s\n", uri ));
+               "slap_sasl_regexp: converted SASL name to ldap:///%s??%s?%s\n",
+               out->dn.bv_val, scope[out->scope], out->filter.bv_val ?
+               out->filter.bv_val : "" ));
 #else
        Debug( LDAP_DEBUG_TRACE,
-          "slap_sasl_regexp: converted SASL name to %s\n", uri, 0, 0 );
+          "slap_sasl_regexp: converted SASL name to ldap:///%s??%s?%s\n",
+               out->dn.bv_val, scope[out->scope], out->filter.bv_val ?
+               out->filter.bv_val : "" );
 #endif
 
-       return( uri );
+       return( 1 );
 }
 
 /* Two empty callback functions to avoid sending results */
@@ -358,15 +383,14 @@ static int sasl_sc_sasl2dn( BackendDB *be, Connection *conn, Operation *o,
  * entry, return the DN of that one entry.
  */
 
-void slap_sasl2dn( struct berval *saslname, struct berval *dn )
+void slap_sasl2dn( Connection *conn, struct berval *saslname, struct berval *dn )
 {
-       char *uri=NULL;
-       struct berval searchbase = {0, NULL};
-       int rc, scope;
+       int rc;
        Backend *be;
        Filter *filter=NULL;
        slap_callback cb = {sasl_sc_r, sasl_sc_s, sasl_sc_sasl2dn, NULL};
        Operation op = {0};
+       SaslUri_t uri;
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
@@ -379,58 +403,55 @@ void slap_sasl2dn( struct berval *saslname, struct berval *dn )
        dn->bv_len = 0;
        cb.sc_private = dn;
 
-       /* Convert the SASL name into an LDAP URI */
-       uri = slap_sasl_regexp( saslname->bv_val );
-       if( uri == NULL )
+       /* Convert the SASL name into a minimal URI */
+       if( !slap_sasl_regexp( saslname, &uri ) )
                goto FINISHED;
 
-       rc = slap_parseURI( uri, &searchbase, &scope, &filter );
-       if( rc ) {
-               goto FINISHED;
-       }
+       if ( uri.filter.bv_val )
+               filter = str2filter( uri.filter.bv_val );
+
+       /* Must do an internal search */
+
+       be = select_backend( &uri.dn, 0, 1 );
+
+       conn->c_authz_backend = be;
 
        /* Massive shortcut: search scope == base */
-       if( scope == LDAP_SCOPE_BASE ) {
-               *dn = searchbase;
-               searchbase.bv_len = 0;
-               searchbase.bv_val = NULL;
+       if( uri.scope == LDAP_SCOPE_BASE ) {
+               *dn = uri.dn;
+               uri.dn.bv_len = 0;
+               uri.dn.bv_val = NULL;
                goto FINISHED;
        }
 
-       /* Must do an internal search */
-
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_DETAIL1,
                   "slap_sasl2dn: performing internal search (base=%s, scope=%d)\n",
-                  searchbase.bv_val, scope ));
+                  uri.dn.bv_val, uri.scope ));
 #else
        Debug( LDAP_DEBUG_TRACE,
           "slap_sasl2dn: performing internal search (base=%s, scope=%d)\n",
-          searchbase.bv_val, scope, 0 );
+          uri.dn.bv_val, uri.scope, 0 );
 #endif
 
-       be = select_backend( &searchbase, 0, 1 );
        if(( be == NULL ) || ( be->be_search == NULL))
                goto FINISHED;
-       suffix_alias( be, &searchbase );
+       suffix_alias( be, &uri.dn );
 
-       ldap_pvt_thread_mutex_init( &op.o_abandonmutex );
        op.o_tag = LDAP_REQ_SEARCH;
        op.o_protocol = LDAP_VERSION3;
        op.o_ndn = *saslname;
        op.o_callback = &cb;
        op.o_time = slap_get_time();
 
-       (*be->be_search)( be, /*conn*/NULL, &op, /*base*/NULL, &searchbase,
-          scope, /*deref=*/1, /*sizelimit=*/1, /*time=*/0, filter, /*fstr=*/NULL,
+       (*be->be_search)( be, /*conn*/NULL, &op, /*base*/NULL, &uri.dn,
+          uri.scope, /*deref=*/1, /*sizelimit=*/1, /*time=*/0, filter, /*fstr=*/NULL,
           /*attrs=*/NULL, /*attrsonly=*/0 );
        
-       ldap_pvt_thread_mutex_destroy( &op.o_abandonmutex );
-
 FINISHED:
-       if( searchbase.bv_len ) ch_free( searchbase.bv_val );
+       if( uri.dn.bv_len ) ch_free( uri.dn.bv_val );
+       if( uri.filter.bv_len ) ch_free( uri.filter.bv_val );
        if( filter ) filter_free( filter );
-       if( uri ) ch_free( uri );
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
@@ -472,7 +493,7 @@ static int sasl_sc_smatch( BackendDB *be, Connection *conn, Operation *o,
  */
 
 static
-int slap_sasl_match( char *rule, struct berval *assertDN, struct berval *authc )
+int slap_sasl_match( struct berval *rule, struct berval *assertDN, struct berval *authc )
 {
        struct berval searchbase = {0, NULL};
        int rc, scope;
@@ -480,18 +501,18 @@ int slap_sasl_match( char *rule, struct berval *assertDN, struct berval *authc )
        Filter *filter=NULL;
        regex_t reg;
        smatch_info sm;
-       slap_callback cb = {sasl_sc_r, sasl_sc_s, sasl_sc_smatch, &sm};
+       slap_callback cb = { sasl_sc_r, sasl_sc_s, sasl_sc_smatch, NULL };
        Operation op = {0};
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
-               "slap_sasl_match: comparing DN %s to rule %s\n", assertDN->bv_val, rule ));
+               "slap_sasl_match: comparing DN %s to rule %s\n", assertDN->bv_val, rule->bv_val ));
 #else
        Debug( LDAP_DEBUG_TRACE,
-          "===>slap_sasl_match: comparing DN %s to rule %s\n", assertDN->bv_val, rule, 0 );
+          "===>slap_sasl_match: comparing DN %s to rule %s\n", assertDN->bv_val, rule->bv_val, 0 );
 #endif
 
-       rc = slap_parseURI( rule, &searchbase, &scope, &filter );
+       rc = slap_parseURI( rule, &searchbase, &scope, &filter, NULL );
        if( rc != LDAP_SUCCESS )
                goto CONCLUDED;
 
@@ -531,8 +552,8 @@ int slap_sasl_match( char *rule, struct berval *assertDN, struct berval *authc )
 
        sm.dn = assertDN;
        sm.match = 0;
+       cb.sc_private = &sm;
 
-       ldap_pvt_thread_mutex_init( &op.o_abandonmutex );
        op.o_tag = LDAP_REQ_SEARCH;
        op.o_protocol = LDAP_VERSION3;
        op.o_ndn = *authc;
@@ -543,8 +564,6 @@ int slap_sasl_match( char *rule, struct berval *assertDN, struct berval *authc )
           scope, /*deref=*/1, /*sizelimit=*/0, /*time=*/0, filter, /*fstr=*/NULL,
           /*attrs=*/NULL, /*attrsonly=*/0 );
 
-       ldap_pvt_thread_mutex_destroy( &op.o_abandonmutex );
-
        if (sm.match)
                rc = LDAP_SUCCESS;
        else
@@ -571,7 +590,7 @@ CONCLUDED:
  * attribute named by *attr. If any of those rules map to the *assertDN, the
  * authorization is approved.
  *
- * DN's passed in should have a dn: prefix
+ * The DNs should not have the dn: prefix
  */
 static int
 slap_sasl_check_authz(struct berval *searchDN, struct berval *assertDN, struct berval *attr, struct berval *authc)
@@ -580,7 +599,6 @@ slap_sasl_check_authz(struct berval *searchDN, struct berval *assertDN, struct b
        int i, rc;
        BerVarray vals=NULL;
        AttributeDescription *ad=NULL;
-       struct berval bv;
 
 #ifdef NEW_LOGGING
        LDAP_LOG(( "sasl", LDAP_LEVEL_ENTRY,
@@ -596,17 +614,13 @@ slap_sasl_check_authz(struct berval *searchDN, struct berval *assertDN, struct b
        if( rc != LDAP_SUCCESS )
                goto COMPLETE;
 
-       bv.bv_val = searchDN->bv_val + 3;
-       bv.bv_len = searchDN->bv_len - 3;
-       rc = backend_attribute( NULL, NULL, NULL, NULL, &bv, ad, &vals );
+       rc = backend_attribute( NULL, NULL, NULL, NULL, searchDN, ad, &vals );
        if( rc != LDAP_SUCCESS )
                goto COMPLETE;
 
-       bv.bv_val = assertDN->bv_val + 3;
-       bv.bv_len = assertDN->bv_len - 3;
        /* Check if the *assertDN matches any **vals */
        for( i=0; vals[i].bv_val != NULL; i++ ) {
-               rc = slap_sasl_match( vals[i].bv_val, &bv, authc );
+               rc = slap_sasl_match( &vals[i], assertDN, authc );
                if ( rc == LDAP_SUCCESS )
                        goto COMPLETE;
        }
@@ -629,7 +643,8 @@ COMPLETE:
 
 
 /* Check if a bind can SASL authorize to another identity.
-   Accepts authorization DN's with "dn:" prefix */
+ * The DNs should not have the dn: prefix
+ */
 
 static struct berval sasl_authz_src = {
        sizeof(SASL_AUTHZ_SOURCE_ATTR)-1, SASL_AUTHZ_SOURCE_ATTR };