]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/schema_check.c
zap charray
[openldap] / servers / slapd / schema_check.c
index dc5842c187d05908bc58a6207effa31193479746..7d74b8e8448a72b612255b7207e3455d60444af2 100644 (file)
@@ -45,11 +45,17 @@ entry_schema_check(
        AttributeDescription *ad_objectClass
                = slap_schema.si_ad_objectClass;
        int extensible = 0;
+       int subentry = is_entry_subentry( e );
+       int collectiveSubentry = 0;
+
+       if( subentry) collectiveSubentry = is_entry_collectiveAttributeSubentry( e );
 
        *text = textbuf;
 
        /* misc attribute checks */
        for ( a = e->e_attrs; a != NULL; a = a->a_next ) {
+               const char *type = a->a_desc->ad_cname.bv_val;
+
                /* there should be at least one value */
                assert( a->a_vals );
                assert( a->a_vals[0].bv_val != NULL ); 
@@ -62,20 +68,24 @@ entry_schema_check(
                        }
                }
 
+               if( !collectiveSubentry && is_at_collective( a->a_desc->ad_type ) ) {
+                       snprintf( textbuf, textlen,
+                               "'%s' can only appear in collectiveAttributeSubentry",
+                               type );
+                       return LDAP_OBJECT_CLASS_VIOLATION;
+               }
+
                /* if single value type, check for multiple values */
                if( is_at_single_value( a->a_desc->ad_type ) &&
                        a->a_vals[1].bv_val != NULL )
                {
-                       char *type = a->a_desc->ad_cname.bv_val;
-
                        snprintf( textbuf, textlen, 
                                "attribute '%s' cannot have multiple values",
                                type );
 
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                               "entry_schema_check: dn=\"%s\" %s\n",
-                               e->e_dn, textbuf ));
+                       LDAP_LOG( OPERATION, INFO, 
+                               "entry_schema_check: dn=\"%s\" %s\n", e->e_dn, textbuf, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
                            "Entry (%s), %s\n",
@@ -93,9 +103,9 @@ entry_schema_check(
        asc = attr_find( e->e_attrs, ad_structuralObjectClass );
        if ( asc == NULL ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "schema", LDAP_LEVEL_INFO, "entry_schema_check: "
-                       "No structuralObjectClass for entry (%s)\n",
-                       e->e_dn ));
+               LDAP_LOG( OPERATION, INFO, 
+                       "entry_schema_check: No structuralObjectClass for entry (%s)\n", 
+                       e->e_dn, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
                        "No structuralObjectClass for entry (%s)\n",
@@ -117,9 +127,8 @@ entry_schema_check(
                        asc->a_vals[0].bv_val );
 
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                       "entry_schema_check: dn (%s), %s\n",
-                       e->e_dn, textbuf ));
+               LDAP_LOG( OPERATION, INFO, 
+                       "entry_schema_check: dn (%s), %s\n", e->e_dn, textbuf, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
                        "entry_check_schema(%s): %s\n",
@@ -135,9 +144,8 @@ entry_schema_check(
                        asc->a_vals[0].bv_val );
 
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                       "entry_schema_check: dn (%s), %s\n",
-                       e->e_dn, textbuf ));
+               LDAP_LOG( OPERATION, INFO, 
+                       "entry_schema_check: dn (%s), %s\n", e->e_dn, textbuf, 0 );
 #else
                Debug( LDAP_DEBUG_ANY,
                        "entry_check_schema(%s): %s\n",
@@ -151,9 +159,9 @@ entry_schema_check(
        aoc = attr_find( e->e_attrs, ad_objectClass );
        if ( aoc == NULL ) {
 #ifdef NEW_LOGGING
-               LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                       "entry_schema_check: No objectClass for entry (%s).\n"
-                       e->e_dn ));
+               LDAP_LOG( OPERATION, INFO, 
+                       "entry_schema_check: No objectClass for entry (%s).\n"
+                       e->e_dn, 0, 0 );
 #else
                Debug( LDAP_DEBUG_ANY, "No objectClass for entry (%s)\n",
                    e->e_dn, 0, 0 );
@@ -196,9 +204,8 @@ entry_schema_check(
                                aoc->a_vals[i].bv_val );
 
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                               "entry_schema_check: dn (%s), %s\n",
-                               e->e_dn, textbuf ));
+                       LDAP_LOG( OPERATION, INFO, 
+                               "entry_schema_check: dn (%s), %s\n", e->e_dn, textbuf, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
                                "entry_check_schema(%s): %s\n",
@@ -208,13 +215,14 @@ entry_schema_check(
                        return LDAP_OBJECT_CLASS_VIOLATION;
                }
 
-               if ( oc->sco_check ) {
-                       int rc = (oc->sco_check)( be, e, oc,
+               if ( oc->soc_check ) {
+                       int rc = (oc->soc_check)( be, e, oc,
                                text, textbuf, textlen );
                        if( rc != LDAP_SUCCESS ) {
                                return rc;
                        }
                }
+
                if ( oc->soc_kind == LDAP_SCHEMA_ABSTRACT ) {
                        /* object class is abstract */
                        if ( oc != slap_schema.si_oc_top &&
@@ -231,9 +239,9 @@ entry_schema_check(
                                                                aoc->a_vals[i].bv_val );
 
 #ifdef NEW_LOGGING
-                                                       LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
+                                                       LDAP_LOG( OPERATION, INFO, 
                                                                "entry_schema_check: dn (%s), %s\n",
-                                                               e->e_dn, textbuf ));
+                                                               e->e_dn, textbuf, 0 );
 #else
                                                        Debug( LDAP_DEBUG_ANY,
                                                                "entry_check_schema(%s): %s\n",
@@ -252,10 +260,9 @@ entry_schema_check(
                                                if ( xc->soc_kind == LDAP_SCHEMA_AUXILIARY &&
                                                        is_object_subclass( oc, xc ) )
                                                {
-                                                       break;;
+                                                       xc = NULL;
+                                                       break;
                                                }
-
-                                               xc = NULL;
                                        }
                                }
 
@@ -265,9 +272,9 @@ entry_schema_check(
                                                aoc->a_vals[i].bv_val );
 
 #ifdef NEW_LOGGING
-                                       LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                                               "entry_schema_check: dn (%s), %s\n",
-                                               e->e_dn, textbuf ));
+                                       LDAP_LOG( OPERATION, INFO, 
+                                               "entry_schema_check: dn (%s), %s\n", 
+                                               e->e_dn, textbuf, 0 );
 #else
                                        Debug( LDAP_DEBUG_ANY,
                                                "entry_check_schema(%s): %s\n",
@@ -287,9 +294,8 @@ entry_schema_check(
                                        aoc->a_vals[i].bv_val, s );
 
 #ifdef NEW_LOGGING
-                               LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                                       "entry_schema_check: dn=\"%s\" %s",
-                                       e->e_dn, textbuf ));
+                               LDAP_LOG( OPERATION, INFO, 
+                                       "entry_schema_check: dn=\"%s\" %s", e->e_dn, textbuf, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
                                        "Entry (%s): %s\n",
@@ -320,9 +326,8 @@ entry_schema_check(
                                type );
 
 #ifdef NEW_LOGGING
-                       LDAP_LOG(( "schema", LDAP_LEVEL_INFO,
-                               "entry_schema_check: dn=\"%s\" %s\n",
-                               e->e_dn, textbuf ));
+                       LDAP_LOG( OPERATION, INFO, 
+                               "entry_schema_check: dn=\"%s\" %s\n", e->e_dn, textbuf, 0);
 #else
                        Debug( LDAP_DEBUG_ANY,
                            "Entry (%s), %s\n",
@@ -347,9 +352,9 @@ oc_check_required(
        Attribute       *a;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "schema", LDAP_LEVEL_ENTRY,
-               "oc_check_required: dn (%s), objectClass \"%s\"\n",
-       e->e_dn, ocname->bv_val ));
+       LDAP_LOG( OPERATION, ENTRY, 
+               "oc_check_required: dn (%s), objectClass \"%s\"\n", 
+               e->e_dn, ocname->bv_val, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE,
                "oc_check_required entry (%s), objectClass \"%s\"\n",
@@ -382,14 +387,14 @@ oc_check_required(
 
 int oc_check_allowed(
        AttributeType *at,
-       BVarray ocl,
+       BerVarray ocl,
        ObjectClass *sc )
 {
        int             i, j;
 
 #ifdef NEW_LOGGING
-       LDAP_LOG(( "schema", LDAP_LEVEL_ENTRY,
-               "oc_check_allowed: type \"%s\"\n", at->sat_cname.bv_val ));
+       LDAP_LOG( OPERATION, ENTRY, 
+               "oc_check_allowed: type \"%s\"\n", at->sat_cname.bv_val, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE,
                "oc_check_allowed type \"%s\"\n",
@@ -463,7 +468,7 @@ int oc_check_allowed(
  * Determine the structural object class from a set of OIDs
  */
 int structural_class(
-       BVarray ocs,
+       BerVarray ocs,
        struct berval *scbv,
        ObjectClass **scp,
        const char **text,
@@ -482,7 +487,7 @@ int structural_class(
 
                if( oc == NULL ) {
                        snprintf( textbuf, textlen,
-                               "unrecongized objectClass '%s'",
+                               "unrecognized objectClass '%s'",
                                ocs[i].bv_val );
                        *text = textbuf;
                        return LDAP_OBJECT_CLASS_VIOLATION;
@@ -503,7 +508,7 @@ int structural_class(
 
                                        if( xc == NULL ) {
                                                snprintf( textbuf, textlen,
-                                                       "unrecongized objectClass '%s'",
+                                                       "unrecognized objectClass '%s'",
                                                        ocs[i].bv_val );
                                                *text = textbuf;
                                                return LDAP_OBJECT_CLASS_VIOLATION;