]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/schema_init.c
component cleanup
[openldap] / servers / slapd / schema_init.c
index 1daa99628c2c04d76d29a8daf2c86278e953e8ab..a0e5fe6a061d63a86e490fb4d86b2aefae3d6e6f 100644 (file)
@@ -405,31 +405,27 @@ octetStringSubstringsIndexer(
 
        for( i=0; values[i].bv_val != NULL; i++ ) {
                /* count number of indices to generate */
-               if( values[i].bv_len < SLAP_INDEX_SUBSTR_MINLEN ) {
-                       continue;
-               }
-
                if( flags & SLAP_INDEX_SUBSTR_INITIAL ) {
-                       if( values[i].bv_len >= SLAP_INDEX_SUBSTR_MAXLEN ) {
-                               nkeys += SLAP_INDEX_SUBSTR_MAXLEN -
-                                       (SLAP_INDEX_SUBSTR_MINLEN - 1);
-                       } else {
-                               nkeys += values[i].bv_len - (SLAP_INDEX_SUBSTR_MINLEN - 1);
+                       if( values[i].bv_len >= SLAP_INDEX_SUBSTR_IF_MAXLEN ) {
+                               nkeys += SLAP_INDEX_SUBSTR_IF_MAXLEN -
+                                       (SLAP_INDEX_SUBSTR_IF_MINLEN - 1);
+                       } else if( values[i].bv_len >= SLAP_INDEX_SUBSTR_IF_MINLEN ) {
+                               nkeys += values[i].bv_len - (SLAP_INDEX_SUBSTR_IF_MINLEN - 1);
                        }
                }
 
                if( flags & SLAP_INDEX_SUBSTR_ANY ) {
-                       if( values[i].bv_len >= SLAP_INDEX_SUBSTR_MAXLEN ) {
-                               nkeys += values[i].bv_len - (SLAP_INDEX_SUBSTR_MAXLEN - 1);
+                       if( values[i].bv_len >= SLAP_INDEX_SUBSTR_ANY_LEN ) {
+                               nkeys += values[i].bv_len - (SLAP_INDEX_SUBSTR_ANY_LEN - 1);
                        }
                }
 
                if( flags & SLAP_INDEX_SUBSTR_FINAL ) {
-                       if( values[i].bv_len >= SLAP_INDEX_SUBSTR_MAXLEN ) {
-                               nkeys += SLAP_INDEX_SUBSTR_MAXLEN -
-                                       ( SLAP_INDEX_SUBSTR_MINLEN - 1);
-                       } else {
-                               nkeys += values[i].bv_len - (SLAP_INDEX_SUBSTR_MINLEN - 1);
+                       if( values[i].bv_len >= SLAP_INDEX_SUBSTR_IF_MAXLEN ) {
+                               nkeys += SLAP_INDEX_SUBSTR_IF_MAXLEN -
+                                       ( SLAP_INDEX_SUBSTR_IF_MINLEN - 1);
+                       } else if( values[i].bv_len >= SLAP_INDEX_SUBSTR_IF_MINLEN ) {
+                               nkeys += values[i].bv_len - (SLAP_INDEX_SUBSTR_IF_MINLEN - 1);
                        }
                }
        }
@@ -449,13 +445,11 @@ octetStringSubstringsIndexer(
        for( i=0; values[i].bv_val != NULL; i++ ) {
                ber_len_t j,max;
 
-               if( values[i].bv_len < SLAP_INDEX_SUBSTR_MINLEN ) continue;
-
                if( ( flags & SLAP_INDEX_SUBSTR_ANY ) &&
-                       ( values[i].bv_len >= SLAP_INDEX_SUBSTR_MAXLEN ) )
+                       ( values[i].bv_len >= SLAP_INDEX_SUBSTR_ANY_LEN ) )
                {
                        char pre = SLAP_INDEX_SUBSTR_PREFIX;
-                       max = values[i].bv_len - (SLAP_INDEX_SUBSTR_MAXLEN - 1);
+                       max = values[i].bv_len - (SLAP_INDEX_SUBSTR_ANY_LEN - 1);
 
                        for( j=0; j<max; j++ ) {
                                HASH_Init( &HASHcontext );
@@ -472,17 +466,20 @@ octetStringSubstringsIndexer(
                                        (unsigned char *)mr->smr_oid, mlen );
                                HASH_Update( &HASHcontext,
                                        (unsigned char *)&values[i].bv_val[j],
-                                       SLAP_INDEX_SUBSTR_MAXLEN );
+                                       SLAP_INDEX_SUBSTR_ANY_LEN );
                                HASH_Final( HASHdigest, &HASHcontext );
 
                                ber_dupbv_x( &keys[nkeys++], &digest, ctx );
                        }
                }
 
-               max = SLAP_INDEX_SUBSTR_MAXLEN < values[i].bv_len
-                       ? SLAP_INDEX_SUBSTR_MAXLEN : values[i].bv_len;
+               /* skip if too short */ 
+               if( values[i].bv_len < SLAP_INDEX_SUBSTR_IF_MINLEN ) continue;
 
-               for( j=SLAP_INDEX_SUBSTR_MINLEN; j<=max; j++ ) {
+               max = SLAP_INDEX_SUBSTR_IF_MAXLEN < values[i].bv_len
+                       ? SLAP_INDEX_SUBSTR_IF_MAXLEN : values[i].bv_len;
+
+               for( j=SLAP_INDEX_SUBSTR_IF_MINLEN; j<=max; j++ ) {
                        char pre;
 
                        if( flags & SLAP_INDEX_SUBSTR_INITIAL ) {
@@ -526,7 +523,6 @@ octetStringSubstringsIndexer(
                        }
 
                }
-
        }
 
        if( nkeys > 0 ) {
@@ -563,8 +559,9 @@ octetStringSubstringsFilter (
 
        sa = (SubstringsAssertion *) assertedValue;
 
-       if( flags & SLAP_INDEX_SUBSTR_INITIAL && sa->sa_initial.bv_val != NULL
-               && sa->sa_initial.bv_len >= SLAP_INDEX_SUBSTR_MINLEN )
+       if( flags & SLAP_INDEX_SUBSTR_INITIAL &&
+               sa->sa_initial.bv_val != NULL &&
+               sa->sa_initial.bv_len >= SLAP_INDEX_SUBSTR_IF_MINLEN )
        {
                nkeys++;
        }
@@ -572,16 +569,17 @@ octetStringSubstringsFilter (
        if( flags & SLAP_INDEX_SUBSTR_ANY && sa->sa_any != NULL ) {
                ber_len_t i;
                for( i=0; sa->sa_any[i].bv_val != NULL; i++ ) {
-                       if( sa->sa_any[i].bv_len >= SLAP_INDEX_SUBSTR_MAXLEN ) {
-                               /* don't bother accounting for stepping */
+                       if( sa->sa_any[i].bv_len >= SLAP_INDEX_SUBSTR_ANY_LEN ) {
+                               /* don't bother accounting with stepping */
                                nkeys += sa->sa_any[i].bv_len -
-                                       ( SLAP_INDEX_SUBSTR_MAXLEN - 1 );
+                                       ( SLAP_INDEX_SUBSTR_ANY_LEN - 1 );
                        }
                }
        }
 
-       if( flags & SLAP_INDEX_SUBSTR_FINAL && sa->sa_final.bv_val != NULL &&
-               sa->sa_final.bv_len >= SLAP_INDEX_SUBSTR_MINLEN )
+       if( flags & SLAP_INDEX_SUBSTR_FINAL &&
+               sa->sa_final.bv_val != NULL &&
+               sa->sa_final.bv_len >= SLAP_INDEX_SUBSTR_IF_MINLEN )
        {
                nkeys++;
        }
@@ -600,14 +598,15 @@ octetStringSubstringsFilter (
        keys = slap_sl_malloc( sizeof( struct berval ) * (nkeys+1), ctx );
        nkeys = 0;
 
-       if( flags & SLAP_INDEX_SUBSTR_INITIAL && sa->sa_initial.bv_val != NULL &&
-               sa->sa_initial.bv_len >= SLAP_INDEX_SUBSTR_MINLEN )
+       if( flags & SLAP_INDEX_SUBSTR_INITIAL &&
+               sa->sa_initial.bv_val != NULL &&
+               sa->sa_initial.bv_len >= SLAP_INDEX_SUBSTR_IF_MINLEN )
        {
                pre = SLAP_INDEX_SUBSTR_INITIAL_PREFIX;
                value = &sa->sa_initial;
 
-               klen = SLAP_INDEX_SUBSTR_MAXLEN < value->bv_len
-                       ? SLAP_INDEX_SUBSTR_MAXLEN : value->bv_len;
+               klen = SLAP_INDEX_SUBSTR_IF_MAXLEN < value->bv_len
+                       ? SLAP_INDEX_SUBSTR_IF_MAXLEN : value->bv_len;
 
                HASH_Init( &HASHcontext );
                if( prefix != NULL && prefix->bv_len > 0 ) {
@@ -630,18 +629,18 @@ octetStringSubstringsFilter (
        if( flags & SLAP_INDEX_SUBSTR_ANY && sa->sa_any != NULL ) {
                ber_len_t i, j;
                pre = SLAP_INDEX_SUBSTR_PREFIX;
-               klen = SLAP_INDEX_SUBSTR_MAXLEN;
+               klen = SLAP_INDEX_SUBSTR_ANY_LEN;
 
                for( i=0; sa->sa_any[i].bv_val != NULL; i++ ) {
-                       if( sa->sa_any[i].bv_len < SLAP_INDEX_SUBSTR_MAXLEN ) {
+                       if( sa->sa_any[i].bv_len < SLAP_INDEX_SUBSTR_ANY_LEN ) {
                                continue;
                        }
 
                        value = &sa->sa_any[i];
 
                        for(j=0;
-                               j <= value->bv_len - SLAP_INDEX_SUBSTR_MAXLEN;
-                               j += SLAP_INDEX_SUBSTR_STEP )
+                               j <= value->bv_len - SLAP_INDEX_SUBSTR_ANY_LEN;
+                               j += SLAP_INDEX_SUBSTR_ANY_STEP )
                        {
                                HASH_Init( &HASHcontext );
                                if( prefix != NULL && prefix->bv_len > 0 ) {
@@ -663,14 +662,15 @@ octetStringSubstringsFilter (
                }
        }
 
-       if( flags & SLAP_INDEX_SUBSTR_FINAL && sa->sa_final.bv_val != NULL &&
-               sa->sa_final.bv_len >= SLAP_INDEX_SUBSTR_MINLEN )
+       if( flags & SLAP_INDEX_SUBSTR_FINAL &&
+               sa->sa_final.bv_val != NULL &&
+               sa->sa_final.bv_len >= SLAP_INDEX_SUBSTR_IF_MINLEN )
        {
                pre = SLAP_INDEX_SUBSTR_FINAL_PREFIX;
                value = &sa->sa_final;
 
-               klen = SLAP_INDEX_SUBSTR_MAXLEN < value->bv_len
-                       ? SLAP_INDEX_SUBSTR_MAXLEN : value->bv_len;
+               klen = SLAP_INDEX_SUBSTR_IF_MAXLEN < value->bv_len
+                       ? SLAP_INDEX_SUBSTR_IF_MAXLEN : value->bv_len;
 
                HASH_Init( &HASHcontext );
                if( prefix != NULL && prefix->bv_len > 0 ) {
@@ -738,38 +738,172 @@ bitStringValidate(
        return LDAP_SUCCESS;
 }
 
+/*
+ * Syntax is [RFC2252]:
+ *
+
+6.3. Bit String
+
+   ( 1.3.6.1.4.1.1466.115.121.1.6 DESC 'Bit String' )
+
+   Values in this syntax are encoded according to the following BNF:
+
+      bitstring = "'" *binary-digit "'B"
+
+      binary-digit = "0" / "1"
+
+   ... 
+
+6.21. Name And Optional UID
+
+   ( 1.3.6.1.4.1.1466.115.121.1.34 DESC 'Name And Optional UID' )
+
+   Values in this syntax are encoded according to the following BNF:
+
+      NameAndOptionalUID = DistinguishedName [ "#" bitstring ]
+
+   Although the '#' character may occur in a string representation of a
+   distinguished name, no additional special quoting is done.  This
+   syntax has been added subsequent to RFC 1778.
+
+   Example:
+
+      1.3.6.1.4.1.1466.0=#04024869,O=Test,C=GB#'0101'B
+
+ *
+ * draft-ietf-ldapbis-syntaxes-xx.txt says:
+ *
+
+3.3.2.  Bit String
+
+   A value of the Bit String syntax is a sequence of binary digits.  The
+   LDAP-specific encoding of a value of this syntax is defined by the
+   following ABNF:
+
+      BitString    = SQUOTE *binary-digit SQUOTE "B"
+
+      binary-digit = "0" / "1"
+
+   The <SQUOTE> rule is defined in [MODELS].
+
+      Example:
+         '0101111101'B
+
+   The LDAP definition for the Bit String syntax is:
+
+      ( 1.3.6.1.4.1.1466.115.121.1.6 DESC 'Bit String' )
+
+   This syntax corresponds to the BIT STRING ASN.1 type from [ASN.1].
+
+   ...
+
+3.3.21.  Name and Optional UID
+
+   A value of the Name and Optional UID syntax is the distinguished name
+   [MODELS] of an entity optionally accompanied by a unique identifier
+   that serves to differentiate the entity from others with an identical
+   distinguished name.
+
+   The LDAP-specific encoding of a value of this syntax is defined by
+   the following ABNF:
+
+       NameAndOptionalUID = distinguishedName [ SHARP BitString ]
+
+   The <BitString> rule is defined in Section 3.3.2.  The
+   <distinguishedName> rule is defined in [LDAPDN].  The <SHARP> rule is
+   defined in [MODELS].
+
+   Note that although the '#' character may occur in the string
+   representation of a distinguished name, no additional escaping of
+   this character is performed when a <distinguishedName> is encoded in
+   a <NameAndOptionalUID>.
+
+      Example:
+         1.3.6.1.4.1.1466.0=#04024869,O=Test,C=GB#'0101'B
+
+   The LDAP definition for the Name and Optional UID syntax is:
+
+      ( 1.3.6.1.4.1.1466.115.121.1.34 DESC 'Name And Optional UID' )
+
+   This syntax corresponds to the NameAndOptionalUID ASN.1 type from
+   [X.520].
+
+ *
+ * draft-ietf-ldapbis-models-xx.txt [MODELS] says:
+ *
+
+1.4. Common ABNF Productions
+
+  ...
+      SHARP   = %x23 ; octothorpe (or sharp sign) ("#")
+  ...
+      SQUOTE  = %x27 ; single quote ("'")
+  ...
+      
+ *
+ * Note: normalization strips any leading "0"s, unless the
+ * bit string is exactly "'0'B", so the normalized example,
+ * in slapd, would result in
+ * 
+ * 1.3.6.1.4.1.1466.0=#04024869,o=test,c=gb#'101'B
+ * 
+ * Since draft-ietf-ldapbis-dn-xx.txt clarifies that SHARP,
+ * i.e. "#", doesn't have to be escaped except when at the
+ * beginning of a value, the definition of Name and Optional
+ * UID appears to be flawed, because there is no clear means
+ * to determine whether the UID part is present or not.
+ *
+ * Example:
+ *
+ *     cn=Someone,dc=example,dc=com#'1'B
+ *
+ * could be either a NameAndOptionalUID with trailing UID, i.e.
+ *
+ *     DN = "cn=Someone,dc=example,dc=com"
+ *     UID = "'1'B"
+ * 
+ * or a NameAndOptionalUID with no trailing UID, and the AVA
+ * in the last RDN made of
+ *
+ *     attributeType = dc 
+ *     attributeValue = com#'1'B
+ *
+ * in fact "com#'1'B" is a valid IA5 string.
+ *
+ * As a consequence, current slapd code assumes that the
+ * presence of portions of a BitString at the end of the string 
+ * representation of a NameAndOptionalUID means a BitString
+ * is expected, and cause an error otherwise.  This is quite
+ * arbitrary, and might change in the future.
+ */
+
+
 static int
 nameUIDValidate(
        Syntax *syntax,
        struct berval *in )
 {
        int rc;
-       struct berval dn;
+       struct berval dn, uid;
 
        if( in->bv_len == 0 ) return LDAP_SUCCESS;
 
        ber_dupbv( &dn, in );
        if( !dn.bv_val ) return LDAP_OTHER;
 
-       if( dn.bv_val[dn.bv_len-1] == 'B'
-               && dn.bv_val[dn.bv_len-2] == '\'' )
-       {
-               /* assume presence of optional UID */
-               ber_len_t i;
+       /* if there's a "#", try bitStringValidate()... */
+       uid.bv_val = strrchr( dn.bv_val, '#' );
+       if ( uid.bv_val ) {
+               uid.bv_val++;
+               uid.bv_len = dn.bv_len - ( uid.bv_val - dn.bv_val );
 
-               for(i=dn.bv_len-3; i>1; i--) {
-                       if( dn.bv_val[i] != '0' && dn.bv_val[i] != '1' ) {
-                               break;
-                       }
+               rc = bitStringValidate( NULL, &uid );
+               if ( rc == LDAP_SUCCESS ) {
+                       /* in case of success, trim the UID,
+                        * otherwise treat it as part of the DN */
+                       dn.bv_len -= uid.bv_len + 1;
+                       uid.bv_val[-1] = '\0';
                }
-               if( dn.bv_val[i] != '\'' || dn.bv_val[i-1] != '#' ) {
-                       ber_memfree( dn.bv_val );
-                       return LDAP_INVALID_SYNTAX;
-               }
-
-               /* trim the UID to allow use of dnValidate */
-               dn.bv_val[i-1] = '\0';
-               dn.bv_len = i-1;
        }
 
        rc = dnValidate( NULL, &dn );
@@ -789,11 +923,7 @@ nameUIDPretty(
        assert( out );
 
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ARGS, ">>> nameUIDPretty: <%s>\n", val->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, ">>> nameUIDPretty: <%s>\n", val->bv_val, 0, 0 );
-#endif
 
        if( val->bv_len == 0 ) {
                ber_dupbv_x( out, val, ctx );
@@ -802,38 +932,52 @@ nameUIDPretty(
                return LDAP_INVALID_SYNTAX;
 
        } else {
-               int rc;
-               struct berval dnval = *val;
-               struct berval uidval = BER_BVNULL;
+               int             rc;
+               struct berval   dnval = *val;
+               struct berval   uidval = BER_BVNULL;
 
-               if( val->bv_val[val->bv_len-1] == 'B'
-                       && val->bv_val[val->bv_len-2] == '\'' )
-               {
-                       uidval.bv_val=strrchr( val->bv_val, '#' );
-                       if( uidval.bv_val ) {
-                               dnval.bv_len = uidval.bv_val - dnval.bv_val;
-                               uidval.bv_len = val->bv_len - dnval.bv_len;
+               uidval.bv_val = strrchr( val->bv_val, '#' );
+               if ( uidval.bv_val ) {
+                       uidval.bv_val++;
+                       uidval.bv_len = val->bv_len - ( uidval.bv_val - val->bv_val );
+
+                       rc = bitStringValidate( NULL, &uidval );
+
+                       if ( rc == LDAP_SUCCESS ) {
+                               ber_dupbv_x( &dnval, val, ctx );
+                               dnval.bv_len -= uidval.bv_len + 1;
+                               dnval.bv_val[dnval.bv_len] = '\0';
 
-                               uidval.bv_len--;
-                               uidval.bv_val++;
+                       } else {
+                               uidval.bv_val = NULL;
                        }
                }
 
                rc = dnPretty( syntax, &dnval, out, ctx );
-               if( rc != LDAP_SUCCESS ) return rc;
+               if ( dnval.bv_val != val->bv_val ) {
+                       slap_sl_free( dnval.bv_val, ctx );
+               }
+               if( rc != LDAP_SUCCESS ) {
+                       return rc;
+               }
 
                if( uidval.bv_val ) {
-                       char *tmp = slap_sl_realloc( out->bv_val, out->bv_len + uidval.bv_len + 2, ctx );
-                       int i, c, got1;
+                       int     i, c, got1;
+                       char    *tmp;
+
+                       tmp = slap_sl_realloc( out->bv_val, out->bv_len 
+                               + STRLENOF( "#" ) + uidval.bv_len + 1,
+                               ctx );
                        if( tmp == NULL ) {
                                ber_memfree_x( out->bv_val, ctx );
                                return LDAP_OTHER;
                        }
                        out->bv_val = tmp;
                        out->bv_val[out->bv_len++] = '#';
+                       out->bv_val[out->bv_len++] = '\'';
 
                        got1 = uidval.bv_len < sizeof("'0'B"); 
-                       for(i=0; i<uidval.bv_len; i++) {
+                       for( i = 1; i < uidval.bv_len - 2; i++ ) {
                                c = uidval.bv_val[i];
                                switch(c) {
                                        case '0':
@@ -841,20 +985,18 @@ nameUIDPretty(
                                                break;
                                        case '1':
                                                got1 = 1;
-                                       default:
                                                out->bv_val[out->bv_len++] = c;
+                                               break;
                                }
                        }
 
+                       out->bv_val[out->bv_len++] = '\'';
+                       out->bv_val[out->bv_len++] = 'B';
                        out->bv_val[out->bv_len] = '\0';
                }
        }
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ARGS, "<<< nameUIDPretty: <%s>\n", out->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "<<< nameUIDPretty: <%s>\n", out->bv_val, 0, 0 );
-#endif
 
        return LDAP_SUCCESS;
 }
@@ -873,38 +1015,46 @@ uniqueMemberNormalize(
 
        assert( SLAP_MR_IS_VALUE_OF_SYNTAX( usage ));
 
-       ber_dupbv( &out, val );
-       if( out.bv_len != 0 ) {
+       ber_dupbv_x( &out, val, ctx );
+       if ( BER_BVISEMPTY( &out ) ) {
+               *normalized = out;
+
+       } else {
                struct berval uid = BER_BVNULL;
 
-               if( out.bv_val[out.bv_len-1] == 'B'
-                       && out.bv_val[out.bv_len-2] == '\'' )
-               {
-                       /* assume presence of optional UID */
-                       uid.bv_val = strrchr( out.bv_val, '#' );
+               uid.bv_val = strrchr( out.bv_val, '#' );
+               if ( uid.bv_val ) {
+                       uid.bv_val++;
+                       uid.bv_len = out.bv_len - ( uid.bv_val - out.bv_val );
 
-                       if( uid.bv_val == NULL ) {
-                               free( out.bv_val );
-                               return LDAP_INVALID_SYNTAX;
+                       rc = bitStringValidate( NULL, &uid );
+                       if ( rc == LDAP_SUCCESS ) {
+                               uid.bv_val[-1] = '\0';
+                               out.bv_len -= uid.bv_len + 1;
+                       } else {
+                               uid.bv_val = NULL;
                        }
-
-                       uid.bv_len = out.bv_len - (uid.bv_val - out.bv_val);
-                       out.bv_len -= uid.bv_len--;
-
-                       /* temporarily trim the UID */
-                       *(uid.bv_val++) = '\0';
                }
 
                rc = dnNormalize( 0, NULL, NULL, &out, normalized, ctx );
 
                if( rc != LDAP_SUCCESS ) {
-                       free( out.bv_val );
+                       slap_sl_free( out.bv_val, ctx );
                        return LDAP_INVALID_SYNTAX;
                }
 
-               if( uid.bv_len ) {
-                       normalized->bv_val = ch_realloc( normalized->bv_val,
-                               normalized->bv_len + uid.bv_len + sizeof("#") );
+               if( uid.bv_val ) {
+                       char    *tmp;
+
+                       tmp = ch_realloc( normalized->bv_val,
+                               normalized->bv_len + uid.bv_len
+                               + STRLENOF("#") + 1 );
+                       if ( tmp == NULL ) {
+                               ber_memfree_x( normalized->bv_val, ctx );
+                               return LDAP_OTHER;
+                       }
+
+                       normalized->bv_val = tmp;
 
                        /* insert the separator */
                        normalized->bv_val[normalized->bv_len++] = '#';
@@ -918,7 +1068,7 @@ uniqueMemberNormalize(
                        normalized->bv_val[normalized->bv_len] = '\0';
                }
 
-               free( out.bv_val );
+               slap_sl_free( out.bv_val, ctx );
        }
 
        return LDAP_SUCCESS;
@@ -935,56 +1085,52 @@ uniqueMemberMatch(
 {
        int match;
        struct berval *asserted = (struct berval *) assertedValue;
-       struct berval assertedDN = BER_BVNULL;
+       struct berval assertedDN = *asserted;
        struct berval assertedUID = BER_BVNULL;
        struct berval valueDN = BER_BVNULL;
        struct berval valueUID = BER_BVNULL;
 
-       if( asserted->bv_len != 0 ) {
-               assertedDN = *asserted;
+       if ( !BER_BVISEMPTY( asserted ) ) {
+               assertedUID.bv_val = strrchr( assertedDN.bv_val, '#' );
+               if ( !BER_BVISNULL( &assertedUID ) ) {
+                       assertedUID.bv_val++;
+                       assertedUID.bv_len = assertedDN.bv_len
+                               - ( assertedUID.bv_val - assertedDN.bv_val );
 
-               if( assertedDN.bv_val[assertedDN.bv_len-1] == 'B'
-                       && assertedDN.bv_val[assertedDN.bv_len-2] == '\'' )
-               {
-                       /* assume presence of optional UID */
-                       assertedUID.bv_val = strrchr( assertedDN.bv_val, '#' );
+                       if ( bitStringValidate( NULL, &assertedUID ) == LDAP_SUCCESS ) {
+                               assertedDN.bv_len -= assertedUID.bv_len + 1;
 
-                       if( assertedUID.bv_val == NULL ) {
-                               return LDAP_INVALID_SYNTAX;
+                       } else {
+                               BER_BVZERO( &assertedUID );
                        }
-
-                       assertedUID.bv_len = assertedDN.bv_len -
-                               (assertedUID.bv_val - assertedDN.bv_val);
-                       assertedDN.bv_len -= assertedUID.bv_len--;
-
-                       /* trim the separator */
-                       assertedUID.bv_val++;
                }
        }
 
-       if( value->bv_len != 0 ) {
+       if ( !BER_BVISEMPTY( value ) ) {
                valueDN = *value;
 
-               if( valueDN.bv_val[valueDN.bv_len-1] == 'B'
-                       && valueDN.bv_val[valueDN.bv_len-2] == '\'' )
-               {
-                       /* assume presence of optional UID */
-                       valueUID.bv_val = strrchr( valueDN.bv_val, '#' );
-
-                       if( valueUID.bv_val == NULL ) {
-                               return LDAP_INVALID_SYNTAX;
-                       }
+               valueUID.bv_val = strrchr( valueDN.bv_val, '#' );
+               if ( !BER_BVISNULL( &valueUID ) ) {
+                       valueUID.bv_val++;
+                       valueUID.bv_len = valueDN.bv_len
+                               - ( valueUID.bv_val - valueDN.bv_val );
 
-                       valueUID.bv_len = valueDN.bv_len -
-                               (assertedUID.bv_val - assertedDN.bv_val);
-                       valueDN.bv_len -= valueUID.bv_len--;
+                       if ( bitStringValidate( NULL, &valueUID ) == LDAP_SUCCESS ) {
+                               valueDN.bv_len -= valueUID.bv_len + 1;
 
-                       /* trim the separator */
-                       valueUID.bv_val++;
+                       } else {
+                               BER_BVZERO( &valueUID );
+                       }
                }
        }
 
        if( valueUID.bv_len && assertedUID.bv_len ) {
+               match = valueUID.bv_len - assertedUID.bv_len;
+               if ( match ) {
+                       *matchp = match;
+                       return LDAP_SUCCESS;
+               }
+
                match = memcmp( valueUID.bv_val, assertedUID.bv_val, valueUID.bv_len );
                if( match ) {
                        *matchp = match;
@@ -1502,7 +1648,7 @@ telephoneNumberNormalize(
        return LDAP_SUCCESS;
 }
 
-int
+static int
 numericoidValidate(
        Syntax *syntax,
        struct berval *in )
@@ -1787,7 +1933,6 @@ UUIDValidate(
 {
        int i;
        if( in->bv_len != 36 ) {
-               assert(0);
                return LDAP_INVALID_SYNTAX;
        }
 
@@ -1824,7 +1969,7 @@ UUIDNormalize(
        int i;
        int j;
        normalized->bv_len = 16;
-       normalized->bv_val = slap_sl_malloc( normalized->bv_len+1, ctx );
+       normalized->bv_val = slap_sl_malloc( normalized->bv_len + 1, ctx );
 
        for( i=0, j=0; i<36; i++ ) {
                unsigned char nibble;
@@ -1928,7 +2073,8 @@ numericStringNormalize(
  * Integer conversion macros that will use the largest available
  * type.
  */
-#if defined(HAVE_STRTOLL) && defined(LLONG_MAX) && defined(LLONG_MIN) && defined(HAVE_LONG_LONG)
+#if defined(HAVE_STRTOLL) && defined(LLONG_MAX) \
+       && defined(LLONG_MIN) && defined(HAVE_LONG_LONG)
 # define SLAP_STRTOL(n,e,b)  strtoll(n,e,b) 
 # define SLAP_LONG_MAX       LLONG_MAX
 # define SLAP_LONG_MIN       LLONG_MIN
@@ -1953,13 +2099,16 @@ integerBitAndMatch(
 
        /* safe to assume integers are NUL terminated? */
        lValue = SLAP_STRTOL(value->bv_val, NULL, 10);
-       if(( lValue == SLAP_LONG_MIN || lValue == SLAP_LONG_MAX) && errno == ERANGE ) {
+       if(( lValue == SLAP_LONG_MIN || lValue == SLAP_LONG_MAX) &&
+               errno == ERANGE )
+       {
                return LDAP_CONSTRAINT_VIOLATION;
        }
 
-       lAssertedValue = SLAP_STRTOL(((struct berval *)assertedValue)->bv_val, NULL, 10);
-       if(( lAssertedValue == SLAP_LONG_MIN || lAssertedValue == SLAP_LONG_MAX )
-               && errno == ERANGE )
+       lAssertedValue = SLAP_STRTOL(((struct berval *)assertedValue)->bv_val,
+               NULL, 10);
+       if(( lAssertedValue == SLAP_LONG_MIN || lAssertedValue == SLAP_LONG_MAX ) &&
+               errno == ERANGE )
        {
                return LDAP_CONSTRAINT_VIOLATION;
        }
@@ -1981,13 +2130,16 @@ integerBitOrMatch(
 
        /* safe to assume integers are NUL terminated? */
        lValue = SLAP_STRTOL(value->bv_val, NULL, 10);
-       if(( lValue == SLAP_LONG_MIN || lValue == SLAP_LONG_MAX ) && errno == ERANGE ) {
+       if(( lValue == SLAP_LONG_MIN || lValue == SLAP_LONG_MAX ) &&
+               errno == ERANGE )
+       {
                return LDAP_CONSTRAINT_VIOLATION;
        }
 
-       lAssertedValue = SLAP_STRTOL(((struct berval *)assertedValue)->bv_val, NULL, 10);
-       if(( lAssertedValue == SLAP_LONG_MIN || lAssertedValue == SLAP_LONG_MAX )
-               && errno == ERANGE )
+       lAssertedValue = SLAP_STRTOL( ((struct berval *)assertedValue)->bv_val,
+               NULL, 10);
+       if(( lAssertedValue == SLAP_LONG_MIN || lAssertedValue == SLAP_LONG_MAX ) &&
+               errno == ERANGE )
        {
                return LDAP_CONSTRAINT_VIOLATION;
        }
@@ -2018,9 +2170,7 @@ serialNumberAndIssuerValidate(
 
        /* validate serial number (strict for now) */
        for( n=0; n < sn.bv_len; n++ ) {
-               if( !ASCII_DIGIT(sn.bv_val[n]) ) {
-                       return LDAP_INVALID_SYNTAX;
-               }
+               if( !ASCII_DIGIT(sn.bv_val[n]) ) return LDAP_INVALID_SYNTAX;
        }
 
        /* validate DN */
@@ -2045,13 +2195,8 @@ serialNumberAndIssuerPretty(
        assert( val );
        assert( out );
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ARGS, ">>> serialNumberAndIssuerPretty: <%s>\n",
-               val->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, ">>> serialNumberAndIssuerPretty: <%s>\n",
                val->bv_val, 0, 0 );
-#endif
 
        if( val->bv_len < 3 ) return LDAP_INVALID_SYNTAX;
 
@@ -2072,9 +2217,7 @@ serialNumberAndIssuerPretty(
        sn.bv_len -= n;
 
        for( n=0; n < sn.bv_len; n++ ) {
-               if( !ASCII_DIGIT(sn.bv_val[n]) ) {
-                       return LDAP_INVALID_SYNTAX;
-               }
+               if( !ASCII_DIGIT(sn.bv_val[n]) ) return LDAP_INVALID_SYNTAX;
        }
 
        /* pretty DN */
@@ -2098,13 +2241,8 @@ serialNumberAndIssuerPretty(
        /* terminate */
        out->bv_val[out->bv_len] = '\0';
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ARGS, "<<< serialNumberAndIssuerPretty: <%s>\n",
-               out->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "<<< serialNumberAndIssuerPretty: <%s>\n",
                out->bv_val, 0, 0 );
-#endif
 
        return LDAP_SUCCESS;
 }
@@ -2132,13 +2270,8 @@ serialNumberAndIssuerNormalize(
        assert( val );
        assert( out );
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ARGS, ">>> serialNumberAndIssuerNormalize: <%s>\n",
-               val->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, ">>> serialNumberAndIssuerNormalize: <%s>\n",
                val->bv_val, 0, 0 );
-#endif
 
        if( val->bv_len < 3 ) return LDAP_INVALID_SYNTAX;
 
@@ -2185,13 +2318,8 @@ serialNumberAndIssuerNormalize(
        /* terminate */
        out->bv_val[out->bv_len] = '\0';
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( OPERATION, ARGS, "<<< serialNumberAndIssuerNormalize: <%s>\n",
-               out->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "<<< serialNumberAndIssuerNormalize: <%s>\n",
                out->bv_val, 0, 0 );
-#endif
 
        return rc;
 }
@@ -2248,13 +2376,8 @@ certificateExactNormalize(
        p += issuer_dn.bv_len;
        *p = '\0';
 
-#ifdef NEW_LOGGING
-       LDAP_LOG( CONFIG, ARGS, "certificateExactNormalize: %s\n",
-               normalized->bv_val, 0, 0 );
-#else
        Debug( LDAP_DEBUG_TRACE, "certificateExactNormalize: %s\n",
                normalized->bv_val, NULL, NULL );
-#endif
 
 done:
        if (xcert) X509_free(xcert);
@@ -2333,8 +2456,7 @@ check_time_syntax (struct berval *val,
        }
 
        /* leapyear check for the Gregorian calendar (year>1581) */
-       if (parts[parts[1] == 0 ? 0 : 1] % 4 == 0)
-       {
+       if (parts[parts[1] == 0 ? 0 : 1] % 4 == 0) {
                leapyear = 1;
        }
 
@@ -2347,16 +2469,17 @@ check_time_syntax (struct berval *val,
                fraction->bv_len = 0;
                if (p < e && (*p == '.' || *p == ',')) {
                        char *end_num;
-                       while (++p < e && ASCII_DIGIT(*p))
-                               ;
+                       while (++p < e && ASCII_DIGIT(*p)) {
+                               /* EMTPY */;
+                       }
                        if (p - fraction->bv_val == 1) {
                                return LDAP_INVALID_SYNTAX;
                        }
-                       for (end_num = p; end_num[-1] == '0'; --end_num)
-                               ;
+                       for (end_num = p; end_num[-1] == '0'; --end_num) {
+                               /* EMPTY */;
+                       }
                        c = end_num - fraction->bv_val;
-                       if (c != 1)
-                               fraction->bv_len = c;
+                       if (c != 1) fraction->bv_len = c;
                }
        }
 
@@ -2790,9 +2913,14 @@ firstComponentNormalize(
        void *ctx )
 {
        int rc;
-       struct berval oid;
+       struct berval comp;
        ber_len_t len;
 
+       if( SLAP_MR_IS_VALUE_OF_ASSERTION_SYNTAX( usage )) {
+               ber_dupbv_x( normalized, val, ctx );
+               return LDAP_SUCCESS;
+       }
+
        if( val->bv_len < 3 ) return LDAP_INVALID_SYNTAX;
 
        if( val->bv_val[0] != '(' /*')'*/ &&
@@ -2810,26 +2938,26 @@ firstComponentNormalize(
        }
 
        /* grab next word */
-       oid.bv_val = &val->bv_val[len];
+       comp.bv_val = &val->bv_val[len];
        len = val->bv_len - len;
-       for( oid.bv_len=0;
-               !ASCII_SPACE(oid.bv_val[oid.bv_len]) && oid.bv_len < len;
-               oid.bv_len++ )
+       for( comp.bv_len=0;
+               !ASCII_SPACE(comp.bv_val[comp.bv_len]) && comp.bv_len < len;
+               comp.bv_len++ )
        {
                /* empty */
        }
 
        if( mr == slap_schema.si_mr_objectIdentifierFirstComponentMatch ) {
-               rc = numericoidValidate( NULL, &oid );
+               rc = numericoidValidate( NULL, &comp );
        } else if( mr == slap_schema.si_mr_integerFirstComponentMatch ) {
-               rc = integerValidate( NULL, &oid );
+               rc = integerValidate( NULL, &comp );
        } else {
                rc = LDAP_INVALID_SYNTAX;
        }
        
 
        if( rc == LDAP_SUCCESS ) {
-               ber_dupbv_x( normalized, &oid, ctx );
+               ber_dupbv_x( normalized, &comp, ctx );
        }
 
        return rc;
@@ -2870,6 +2998,12 @@ static slap_syntax_defs_rec syntax_defs[] = {
                0, countryStringValidate, NULL},
        {"( 1.3.6.1.4.1.1466.115.121.1.12 DESC 'Distinguished Name' )",
                0, dnValidate, dnPretty},
+       {"( 1.2.36.79672281.1.5.0 DESC 'RDN' )",
+               0, rdnValidate, rdnPretty},
+#ifdef LDAP_COMP_MATCH
+       {"( 1.2.36.79672281.1.5.2 DESC 'ComponentFilter' )",
+               0, componentFilterValidate, NULL},
+#endif
        {"( 1.3.6.1.4.1.1466.115.121.1.13 DESC 'Data Quality' )",
                0, NULL, NULL},
        {"( 1.3.6.1.4.1.1466.115.121.1.14 DESC 'Delivery Method' )",
@@ -3076,6 +3210,50 @@ static slap_mrule_defs_rec mrule_defs[] = {
                octetStringIndexer, octetStringFilter,
                NULL },
 
+       {"( 1.3.6.1.4.1.4203.666.4.9 NAME 'dnSubtreeMatch' "
+               "SYNTAX 1.3.6.1.4.1.1466.115.121.1.12 )",
+               SLAP_MR_HIDE | SLAP_MR_EXT, NULL,
+               NULL, dnNormalize, dnRelativeMatch,
+               NULL, NULL,
+               NULL },
+
+       {"( 1.3.6.1.4.1.4203.666.4.8 NAME 'dnOneLevelMatch' "
+               "SYNTAX 1.3.6.1.4.1.1466.115.121.1.12 )",
+               SLAP_MR_HIDE | SLAP_MR_EXT, NULL,
+               NULL, dnNormalize, dnRelativeMatch,
+               NULL, NULL,
+               NULL },
+
+       {"( 1.3.6.1.4.1.4203.666.4.10 NAME 'dnSubordinateMatch' "
+               "SYNTAX 1.3.6.1.4.1.1466.115.121.1.12 )",
+               SLAP_MR_HIDE | SLAP_MR_EXT, NULL,
+               NULL, dnNormalize, dnRelativeMatch,
+               NULL, NULL,
+               NULL },
+
+       {"( 1.3.6.1.4.1.4203.666.4.11 NAME 'dnSuperiorMatch' "
+               "SYNTAX 1.3.6.1.4.1.1466.115.121.1.12 )",
+               SLAP_MR_HIDE | SLAP_MR_EXT, NULL,
+               NULL, dnNormalize, dnRelativeMatch,
+               NULL, NULL,
+               NULL },
+
+       {"( 1.2.36.79672281.1.13.3 NAME 'rdnMatch' "
+               "SYNTAX 1.2.36.79672281.1.5.0 )",
+               SLAP_MR_EQUALITY | SLAP_MR_EXT, NULL,
+               NULL, rdnNormalize, rdnMatch,
+               octetStringIndexer, octetStringFilter,
+               NULL },
+
+#ifdef LDAP_COMP_MATCH
+       {"( 1.2.36.79672281.1.13.2 NAME 'componentFilterMatch' "
+               "SYNTAX 1.2.36.79672281.1.5.2 )",
+               SLAP_MR_EQUALITY|SLAP_MR_EXT|SLAP_MR_COMPONENT, NULL,
+               NULL, NULL , componentFilterMatch,
+               octetStringIndexer, octetStringFilter,
+               NULL },
+#endif
+
        {"( 2.5.13.2 NAME 'caseIgnoreMatch' "
                "SYNTAX 1.3.6.1.4.1.1466.115.121.1.15 )",
                SLAP_MR_EQUALITY | SLAP_MR_EXT, directoryStringSyntaxes,