Add error handling to BDB_INDEX code

[openldap] / servers / slapd / schemaparse.c

diff --git a/servers/slapd/schemaparse.c b/servers/slapd/schemaparse.c
index 5370bf644b1df094cc4f5c81946e10584d9f3629..1570c3d3b8836c964b31dbb7f70681d2e106a215 100644 (file)
--- a/servers/slapd/schemaparse.c
+++ b/servers/slapd/schemaparse.c
@@ -37,7 +37,8 @@ static char *const err2text[] = {
        "MatchingRule not found",
        "Syntax not found",
        "Syntax required",
-       "Qualifier not supported"
+       "Qualifier not supported",
+       "Invalid NAME"
 };
 
 char *
@@ -50,6 +51,24 @@ scherr2str(int code)
        }
 }
 
+/* check schema descr validity */
+int slap_valid_descr( const char *descr )
+{
+       int i=0;
+
+       if( !DESC_LEADCHAR( descr[i] ) ) {
+               return 0;
+       }
+
+       while( descr[++i] ) {
+               if( !DESC_CHAR( descr[i] ) ) {
+                       return 0;
+               }
+       }
+
+       return 1;
+}
+
 
 /* OID Macros */
 
@@ -271,32 +290,6 @@ parse_at(
        char            *oid = NULL;
        char            *soid = NULL;
 
-       /* Kludge for OIDmacros for syntaxes. If the syntax field starts
-        * nonnumeric, look for and expand a macro. The macro's place in
-        * the input line will be replaced with a field of '0's to keep
-        * ldap_str2attributetype happy. The actual oid will be swapped
-        * into place afterwards.
-        */
-       for (; argv[3]; argv++)
-       {
-               /* Allow numeric OIDs to be wrapped in single quotes */
-               if (!strcasecmp(argv[3], "syntax") && argv[4] != NULL &&
-                   !OID_LEADCHAR(argv[4][argv[4][0] == '\'' ? 1 : 0]))
-               {
-                       int slen;
-                       Syntax *syn;
-                       syn = syn_find_desc(argv[4], &slen);
-                       if (!syn)
-                       {
-                           fprintf(stderr, "%s: line %d: OID %s not found\n",
-                               fname, lineno, argv[4]);
-                               return 1;
-                       }
-                       memset(strstr(line, argv[4]), '0', slen);
-                       soid = ch_strdup(syn->ssyn_syn.syn_oid );
-                       break;
-               }
-       }
        at = ldap_str2attributetype(line,&code,&err,LDAP_SCHEMA_ALLOW_ALL);
        if ( !at ) {
                fprintf( stderr, "%s: line %d: %s before %s\n",
@@ -321,9 +314,20 @@ parse_at(
                }
        }
        /* at->at_oid == NULL will be an error someday */
-       if (soid) {
-               ldap_memfree(at->at_syntax_oid);
-               at->at_syntax_oid = soid;
+       if ( at->at_syntax_oid && !OID_LEADCHAR( at->at_syntax_oid[0] )) {
+               /* Expand OID macros */
+               oid = find_oidm( at->at_syntax_oid );
+               if ( !oid ) {
+                       fprintf(stderr,
+                               "%s: line %d: OID %s not recognized\n",
+                               fname, lineno, at->at_syntax_oid);
+                       return 1;
+               }
+               if ( oid != at->at_syntax_oid ) {
+                       ldap_memfree( at->at_syntax_oid );
+                       at->at_syntax_oid = oid;
+               }
+
        }
        code = at_add(at,&err);
        if ( code ) {