]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/search.c
Fix prev commit
[openldap] / servers / slapd / search.c
index 61e4dd8f57df4513630d7fbc3d47a516371dbf47..39ca34f4b17eae260057f353906d94d74c88d9f4 100644 (file)
@@ -43,6 +43,7 @@ do_search(
        struct berval base = { 0, NULL };
        ber_len_t       siz, off, i;
        int                     manageDSAit;
+       int                     be_manageDSAit;
 #ifdef LDAP_SLAPI
        char            **attrs = NULL;
 #endif
@@ -108,7 +109,7 @@ do_search(
                goto return_results;
        }
 
-       rs->sr_err = dnPrettyNormal( NULL, &base, &op->o_req_dn, &op->o_req_ndn );
+       rs->sr_err = dnPrettyNormal( NULL, &base, &op->o_req_dn, &op->o_req_ndn, op->o_tmpmemctx );
        if( rs->sr_err != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, ERR, 
@@ -145,7 +146,7 @@ do_search(
                }
                goto return_results;
        }
-       filter2bv_x( op->ors_filter, &op->ors_filterstr, op->o_tmpmemctx );
+       filter2bv_x( op, op->ors_filter, &op->ors_filterstr );
 
 #ifdef NEW_LOGGING
        LDAP_LOG( OPERATION, ARGS, 
@@ -211,9 +212,11 @@ do_search(
                char abuf[BUFSIZ/2], *ptr = abuf;
                int len = 0, alen;
 
+               sprintf(abuf, "scope=%d deref=%d", op->ors_scope, op->ors_deref);
                Statslog( LDAP_DEBUG_STATS,
-                       "conn=%lu op=%lu SRCH base=\"%s\" scope=%d filter=\"%s\"\n",
-                       op->o_connid, op->o_opid, op->o_req_dn.bv_val, op->ors_scope, op->ors_filterstr.bv_val );
+                       "conn=%lu op=%lu SRCH base=\"%s\" %s filter=\"%s\"\n",
+                       op->o_connid, op->o_opid, op->o_req_dn.bv_val, abuf,
+                       op->ors_filterstr.bv_val );
 
                for ( i = 0; i<siz; i++ ) {
                        alen = op->ors_attrs[i].an_name.bv_len;
@@ -223,7 +226,7 @@ do_search(
                        if (len && (len + 1 + alen >= sizeof(abuf))) {
                                Statslog( LDAP_DEBUG_STATS, "conn=%lu op=%lu SRCH attr=%s\n",
                                    op->o_connid, op->o_opid, abuf, 0, 0 );
-                               len = 0;
+                               len = 0;
                                ptr = abuf;
                        }
                        if (len) {
@@ -242,7 +245,8 @@ do_search(
 
        manageDSAit = get_manageDSAit( op );
 
-       if ( op->ors_scope == LDAP_SCOPE_BASE ) {
+       /* fake while loop to allow breaking out */
+       while ( op->ors_scope == LDAP_SCOPE_BASE ) {
                Entry *entry = NULL;
 
                if ( op->o_req_ndn.bv_len == 0 ) {
@@ -259,16 +263,15 @@ do_search(
                        }
 
 #ifdef LDAP_SLAPI
-                       attrs = anlist2charray( op, op->ors_attrs );
-                       initSearchPlugin( op, attrs, manageDSAit );
-                       rs->sr_err = doPreSearchPluginFNs( op );
-                       if ( rs->sr_err == LDAP_SUCCESS ) {
+                       if ( op->o_pb ) {
+                               attrs = anlist2charray( op, op->ors_attrs );
+                               initSearchPlugin( op, attrs, manageDSAit );
+                               rs->sr_err = doPreSearchPluginFNs( op );
+                               if ( rs->sr_err ) break;
                                doSearchRewriteFNs( op );
-#endif /* LDAP_SLAPI */
-                       rs->sr_err = root_dse_info( op->o_conn, &entry, &rs->sr_text );
-#ifdef LDAP_SLAPI
                        }
 #endif /* LDAP_SLAPI */
+                       rs->sr_err = root_dse_info( op->o_conn, &entry, &rs->sr_text );
 
                } else if ( bvmatch( &op->o_req_ndn, &global_schemandn ) ) {
                        /* check restrictions */
@@ -278,22 +281,21 @@ do_search(
                        }
 
 #ifdef LDAP_SLAPI
-                       attrs = anlist2charray( op, op->ors_attrs );
-                       initSearchPlugin( op, attrs, manageDSAit );
-                       rs->sr_err = doPreSearchPluginFNs( op );
-                       if ( rs->sr_err == LDAP_SUCCESS ) {
+                       if ( op->o_pb ) {
+                               attrs = anlist2charray( op, op->ors_attrs );
+                               initSearchPlugin( op, attrs, manageDSAit );
+                               rs->sr_err = doPreSearchPluginFNs( op );
+                               if ( rs->sr_err ) break;
                                doSearchRewriteFNs( op );
-#endif /* LDAP_SLAPI */
-                       rs->sr_err = schema_info( &entry, &rs->sr_text );
-#ifdef LDAP_SLAPI
                        }
 #endif /* LDAP_SLAPI */
+                       rs->sr_err = schema_info( &entry, &rs->sr_text );
                }
 
                if( rs->sr_err != LDAP_SUCCESS ) {
                        send_ldap_result( op, rs );
 #ifdef LDAP_SLAPI
-                       doPostSearchPluginFNs( op );
+                       if ( op->o_pb ) doPostSearchPluginFNs( op );
 #endif /* LDAP_SLAPI */
                        goto return_results;
 
@@ -311,18 +313,19 @@ do_search(
                        rs->sr_err = LDAP_SUCCESS;
                        send_ldap_result( op, rs );
 #ifdef LDAP_SLAPI
-                       doPostSearchPluginFNs( op );
+                       if ( op->o_pb ) doPostSearchPluginFNs( op );
 #endif /* LDAP_SLAPI */
                        goto return_results;
                }
+               break;
        }
 
        if( !op->o_req_ndn.bv_len && default_search_nbase.bv_len ) {
-               ch_free( op->o_req_dn.bv_val );
-               ch_free( op->o_req_ndn.bv_val );
+               sl_free( op->o_req_dn.bv_val, op->o_tmpmemctx );
+               sl_free( op->o_req_ndn.bv_val, op->o_tmpmemctx );
 
-               ber_dupbv( &op->o_req_dn, &default_search_base );
-               ber_dupbv( &op->o_req_ndn, &default_search_nbase );
+               ber_dupbv_x( &op->o_req_dn, &default_search_base, op->o_tmpmemctx );
+               ber_dupbv_x( &op->o_req_ndn, &default_search_nbase, op->o_tmpmemctx );
        }
 
        /*
@@ -330,7 +333,20 @@ do_search(
         * appropriate one, or send a referral to our "referral server"
         * if we don't hold it.
         */
-       if ( (op->o_bd = select_backend( &op->o_req_ndn, manageDSAit, 1 )) == NULL ) {
+
+       /* Sync control overrides manageDSAit */
+
+       if ( manageDSAit != SLAP_NO_CONTROL ) {
+               if ( op->o_sync_mode & SLAP_SYNC_REFRESH ) {
+                       be_manageDSAit = SLAP_NO_CONTROL;
+               } else {
+                       be_manageDSAit = manageDSAit;
+               }
+       } else {
+               be_manageDSAit = manageDSAit;
+       }
+
+       if ( (op->o_bd = select_backend( &op->o_req_ndn, be_manageDSAit, 1 )) == NULL ) {
                rs->sr_ref = referral_rewrite( default_referral,
                        NULL, &op->o_req_dn, op->ors_scope );
 
@@ -356,14 +372,16 @@ do_search(
        }
 
 #ifdef LDAP_SLAPI
-       attrs = anlist2charray( op, op->ors_attrs );
-       initSearchPlugin( op, attrs, manageDSAit );
-       rs->sr_err = doPreSearchPluginFNs( op );
-       if ( rs->sr_err != LDAP_SUCCESS ) {
-               goto return_results;
-       }
+       if ( op->o_pb ) {
+               attrs = anlist2charray( op, op->ors_attrs );
+               initSearchPlugin( op, attrs, manageDSAit );
+               rs->sr_err = doPreSearchPluginFNs( op );
+               if ( rs->sr_err != LDAP_SUCCESS ) {
+                       goto return_results;
+               }
 
-       doSearchRewriteFNs( op );
+               doSearchRewriteFNs( op );
+       }
 #endif /* LDAP_SLAPI */
 
        /* actually do the search and send the result(s) */
@@ -375,25 +393,16 @@ do_search(
        }
 
 #ifdef LDAP_SLAPI
-       doPostSearchPluginFNs( op );
+       if ( op->o_pb ) doPostSearchPluginFNs( op );
 #endif /* LDAP_SLAPI */
 
 return_results:;
 
-#ifdef LDAP_CLIENT_UPDATE
-       if ( ( op->o_clientupdate_type & SLAP_LCUP_PERSIST ) )
-               return rs->sr_err;
-#endif
-#if defined(LDAP_CLIENT_UPDATE) && defined(LDAP_SYNC)
-       else
-#endif
-#ifdef LDAP_SYNC
        if ( ( op->o_sync_mode & SLAP_SYNC_PERSIST ) )
                return rs->sr_err;
-#endif
 
-       if( op->o_req_dn.bv_val != NULL) free( op->o_req_dn.bv_val );
-       if( op->o_req_ndn.bv_val != NULL) free( op->o_req_ndn.bv_val );
+       if( op->o_req_dn.bv_val != NULL) sl_free( op->o_req_dn.bv_val, op->o_tmpmemctx );
+       if( op->o_req_ndn.bv_val != NULL) sl_free( op->o_req_ndn.bv_val, op->o_tmpmemctx );
 
        if( op->ors_filterstr.bv_val != NULL) op->o_tmpfree( op->ors_filterstr.bv_val, op->o_tmpmemctx );
        if( op->ors_filter != NULL) filter_free_x( op, op->ors_filter );
@@ -448,7 +457,7 @@ static int doPreSearchPluginFNs( Operation *op )
        int rc;
 
        rc = doPluginFNs( op->o_bd, SLAPI_PLUGIN_PRE_SEARCH_FN, op->o_pb );
-       if ( rc != 0 ) {
+       if ( rc < 0 ) {
                /*
                 * A preoperation plugin failure will abort the
                 * entire operation.
@@ -460,8 +469,10 @@ static int doPreSearchPluginFNs( Operation *op )
                Debug(LDAP_DEBUG_TRACE, "doPreSearchPluginFNs: search preoperation plugin "
                                "returned %d.\n", rc, 0, 0);
 #endif
-               if ( slapi_pblock_get( op->o_pb, SLAPI_RESULT_CODE, (void *)&rc ) != 0)
+               if ( ( slapi_pblock_get( op->o_pb, SLAPI_RESULT_CODE, (void *)&rc ) != 0 ) ||
+                    rc == LDAP_SUCCESS ) {
                        rc = LDAP_OTHER;
+               }
        } else {
                rc = LDAP_SUCCESS;
        }
@@ -472,13 +483,36 @@ static int doPreSearchPluginFNs( Operation *op )
 static int doSearchRewriteFNs( Operation *op )
 {
        if ( doPluginFNs( op->o_bd, SLAPI_PLUGIN_COMPUTE_SEARCH_REWRITER_FN, op->o_pb ) == 0 ) {
+               int rc;
+
                /*
                 * The plugin can set the SLAPI_SEARCH_FILTER.
                 * SLAPI_SEARCH_STRFILER is not normative.
                 */
-               slapi_pblock_get( op->o_pb, SLAPI_SEARCH_FILTER, (void *)&op->ors_filter);
+               slapi_pblock_get( op->o_pb, SLAPI_SEARCH_FILTER, (void *)&op->ors_filter );
                op->o_tmpfree( op->ors_filterstr.bv_val, op->o_tmpmemctx );
-               filter2bv_x( op->ors_filter, &op->ors_filterstr, op->o_tmpmemctx );
+               filter2bv_x( op, op->ors_filter, &op->ors_filterstr );
+
+               /*
+                * Also permit other search parameters to be reset. One thing
+                * this doesn't (yet) deal with is plugins that change a root
+                * DSE search to a non-root DSE search...
+                */
+               slapi_pblock_get( op->o_pb, SLAPI_SEARCH_TARGET, (void **)&op->o_req_dn.bv_val );
+               op->o_req_dn.bv_len = strlen( op->o_req_dn.bv_val );
+
+               if( op->o_req_ndn.bv_val != NULL) {
+                       sl_free( op->o_req_ndn.bv_val, op->o_tmpmemctx );
+               }
+               rc = dnNormalize( 0, NULL, NULL, &op->o_req_dn, &op->o_req_ndn,
+                       op->o_tmpmemctx );
+               if ( rc != LDAP_SUCCESS ) {
+                       return rc;
+               }
+
+               slapi_pblock_get( op->o_pb, SLAPI_SEARCH_SCOPE, (void **)&op->ors_scope );
+               slapi_pblock_get( op->o_pb, SLAPI_SEARCH_DEREF, (void **)&op->ors_deref );
+
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, ARGS, 
                        "doSearchRewriteFNs: after compute_rewrite_search filter: %s\n", 
@@ -494,7 +528,7 @@ static int doSearchRewriteFNs( Operation *op )
 
 static void doPostSearchPluginFNs( Operation *op )
 {
-       if ( doPluginFNs( op->o_bd, SLAPI_PLUGIN_POST_SEARCH_FN, op->o_pb ) != 0 ) {
+       if ( doPluginFNs( op->o_bd, SLAPI_PLUGIN_POST_SEARCH_FN, op->o_pb ) < 0 ) {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, INFO, "doPostSearchPluginFNs: search postoperation plugins "
                                "failed\n", 0, 0, 0 );