fix for select_backend suggested G. Gombas (ITS 1090)

[openldap] / servers / slapd / starttls.c

diff --git a/servers/slapd/starttls.c b/servers/slapd/starttls.c
index ad16783c77587956a221258057f84399b5c1a33d..97bbab084ac9dd34cbd9fd11cb3a06b1333133b0 100644 (file)
--- a/servers/slapd/starttls.c
+++ b/servers/slapd/starttls.c
@@ -20,15 +20,14 @@
 
 int
 starttls_extop (
-       SLAP_EXTOP_CALLBACK_FN cb,
        Connection *conn,
        Operation *op,
-       char * reqoid,
+       const char * reqoid,
        struct berval * reqdata,
        char ** rspoid,
        struct berval ** rspdata,
        LDAPControl ***rspctrls,
-       char ** text,
+       const char ** text,
        struct berval *** refs )
 {
        void *ctx;
@@ -50,6 +49,31 @@ starttls_extop (
                goto done;
        }
 
+       /* can't start TLS if there are other op's around */
+       if (( conn->c_ops != NULL &&
+                       (conn->c_ops != op || op->o_next != NULL)) ||
+               ( conn->c_pending_ops != NULL))
+       {
+               *text = "cannot start TLS when operations our outstanding";
+               rc = LDAP_OPERATIONS_ERROR;
+               goto done;
+       }
+
+       if ( ( global_disallows & SLAP_DISALLOW_TLS_AUTHC ) &&
+               ( conn->c_dn != NULL ) )
+       {
+               *text = "cannot start TLS after authentication";
+               rc = LDAP_OPERATIONS_ERROR;
+               goto done;
+       }
+
+       if ( ( global_allows & SLAP_ALLOW_TLS_2_ANON ) &&
+               ( conn->c_dn != NULL ) )
+       {
+               /* force to anonymous */
+               connection2anonymous( conn );
+       }
+
        /* fail if TLS could not be initialized */
        if (ldap_pvt_tls_get_option(NULL, LDAP_OPT_X_TLS_CERT, &ctx) != 0
                || ctx == NULL)
@@ -65,16 +89,6 @@ starttls_extop (
                goto done;
        }
 
-       /* can't start TLS if there are other op's around */
-       if (( conn->c_ops != NULL &&
-                       (conn->c_ops != op || op->o_next != NULL)) ||
-               ( conn->c_pending_ops != NULL))
-       {
-               *text = "cannot start TLS when operations our outstanding";
-               rc = LDAP_OPERATIONS_ERROR;
-               goto done;
-       }
-
     conn->c_is_tls = 1;
     conn->c_needs_tls_accept = 1;