don't segfault if a database doesn't have the suffix

[openldap] / servers / slapd / starttls.c

diff --git a/servers/slapd/starttls.c b/servers/slapd/starttls.c
index 410e450733ce0e3473d42cf0de0fe5e6fe309a82..ff164a4c61a178fa85713389b4de5401f564b1d9 100644 (file)
--- a/servers/slapd/starttls.c
+++ b/servers/slapd/starttls.c
@@ -1,12 +1,16 @@
 /* $OpenLDAP$ */
-/* 
- * Copyright 1999 The OpenLDAP Foundation.
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2004 The OpenLDAP Foundation.
  * All rights reserved.
  *
- * Redistribution and use in source and binary forms are permitted only
- * as authorized by the OpenLDAP Public License.  A copy of this
- * license is available at http://www.OpenLDAP.org/license.html or
- * in file LICENSE in the top-level directory of the distribution.
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
@@ -14,57 +18,95 @@
 #include <stdio.h>
 #include <ac/socket.h>
 
+#include <ldap_pvt.h>
+
 #include "slap.h"
 
 #ifdef HAVE_TLS
 
 int
-starttls_extop (
-       SLAP_EXTOP_CALLBACK_FN cb,
-       Connection *conn,
-       Operation *op,
-       char * oid,
-       struct berval * reqdata,
-       struct berval ** rspdata,
-       LDAPControl ***rspctrls,
-       char ** text )
+starttls_extop ( Operation *op, SlapReply *rs )
 {
-       if ( reqdata != NULL ) {
+       void *ctx;
+       int rc;
+
+       if ( op->ore_reqdata != NULL ) {
                /* no request data should be provided */
+               rs->sr_text = "no request data expected";
                return LDAP_PROTOCOL_ERROR;
        }
 
+       /* acquire connection lock */
+       ldap_pvt_thread_mutex_lock( &op->o_conn->c_mutex );
+
        /* can't start TLS if it is already started */
-       if (conn->c_is_tls != 0)
-               return(LDAP_OPERATIONS_ERROR);
+       if (op->o_conn->c_is_tls != 0) {
+               rs->sr_text = "TLS already started";
+               rc = LDAP_OPERATIONS_ERROR;
+               goto done;
+       }
 
        /* can't start TLS if there are other op's around */
-       if (conn->c_ops != NULL) {
-               if (conn->c_ops != op || op->o_next != NULL)
-                       return(LDAP_OPERATIONS_ERROR);
+       if (( !LDAP_STAILQ_EMPTY(&op->o_conn->c_ops) &&
+                       (LDAP_STAILQ_FIRST(&op->o_conn->c_ops) != op ||
+                       LDAP_STAILQ_NEXT(op, o_next) != NULL)) ||
+               ( !LDAP_STAILQ_EMPTY(&op->o_conn->c_pending_ops) ))
+       {
+               rs->sr_text = "cannot start TLS when operations are outstanding";
+               rc = LDAP_OPERATIONS_ERROR;
+               goto done;
        }
-       if (conn->c_pending_ops != NULL) {
-               if (conn->c_pending_ops != op || op->o_next != NULL)
-                       return(LDAP_OPERATIONS_ERROR);
+
+       if ( !( global_disallows & SLAP_DISALLOW_TLS_2_ANON ) &&
+               ( op->o_conn->c_dn.bv_len != 0 ) )
+       {
+               Statslog( LDAP_DEBUG_STATS,
+                       "conn=%lu op=%lu AUTHZ anonymous mech=starttls ssf=0\n",
+                       op->o_connid, op->o_opid, 0, 0, 0 );
+
+               /* force to anonymous */
+               connection2anonymous( op->o_conn );
        }
 
-       /* here's some pseudo-code if HAVE_TLS is defined
-        * but for some reason TLS is not available.
-        */
-       /*
-               if (tls not really supported) {
-                       if (referral exists) {
-                               // caller will need to put the referral into the result
-                               return(LDAP_REFERRAL);
-                       }
-                       return(LDAP_UNAVAILABLE);
+       if ( ( global_disallows & SLAP_DISALLOW_TLS_AUTHC ) &&
+               ( op->o_conn->c_dn.bv_len != 0 ) )
+       {
+               rs->sr_text = "cannot start TLS after authentication";
+               rc = LDAP_OPERATIONS_ERROR;
+               goto done;
+       }
+
+       /* fail if TLS could not be initialized */
+       if (ldap_pvt_tls_get_option( NULL, LDAP_OPT_X_TLS_CTX, &ctx ) != 0
+               || ctx == NULL)
+       {
+               if (default_referral != NULL) {
+                       /* caller will put the referral in the result */
+                       rc = LDAP_REFERRAL;
+                       goto done;
                }
-       */
 
-    conn->c_is_tls = 1;
-    conn->c_needs_tls_accept = 1;
+               rs->sr_text = "Could not initialize TLS";
+               rc = LDAP_UNAVAILABLE;
+               goto done;
+       }
+
+    op->o_conn->c_is_tls = 1;
+    op->o_conn->c_needs_tls_accept = 1;
+
+    rc = LDAP_SUCCESS;
+
+done:
+       /* give up connection lock */
+       ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex );
+
+       /*
+        * RACE CONDITION: we give up lock before sending result
+        * Should be resolved by reworking connection state, not
+        * by moving send here (so as to ensure proper TLS sequencing)
+        */
 
-    return(LDAP_SUCCESS);
+       return rc;
 }
 
 #endif /* HAVE_TLS */