]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/syncrepl.c
Import ITS#3403 fix (syncrepl memory corruption) from HEAD
[openldap] / servers / slapd / syncrepl.c
index f76db0ee72c039fdc3efcdc4ca701beefa41b7f3..24e31fab1895178deb42af00b2c9b8fdc5a4f40f 100644 (file)
@@ -45,6 +45,9 @@ static int dn_callback( struct slap_op *, struct slap_rep * );
 static int nonpresent_callback( struct slap_op *, struct slap_rep * );
 static int null_callback( struct slap_op *, struct slap_rep * );
 
+static int si_refreshDelete = 0;
+static int si_refreshPresent = 0;
+
 static AttributeDescription *sync_descs[4];
 
 struct runqueue_s syncrepl_rq;
@@ -87,8 +90,15 @@ init_syncrepl(syncinfo_t *si)
                        Debug( LDAP_DEBUG_ANY, "out of memory\n", 0,0,0 );
 #endif
                }
+
+               /* Add Attributes */
+               for ( i = 0; sync_descs[ i ] != NULL; i++ ) {
+                       tmp[ n++ ] = ch_strdup ( sync_descs[i]->ad_cname.bv_val );
+                       tmp[ n ] = NULL;
+               }
+
        } else {
-               tmp = ( char ** ) ch_realloc( si->si_attrs, 5 * sizeof( char * ));
+               tmp = ( char ** ) ch_realloc( si->si_attrs, 3 * sizeof( char * ));
                if ( tmp == NULL ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR, "out of memory\n", 0,0,0 );
@@ -97,15 +107,27 @@ init_syncrepl(syncinfo_t *si)
 #endif
                }
                tmp[ n++ ] = ch_strdup( "*" );
+               tmp[ n++ ] = ch_strdup( "+" );
+               tmp[ n ] = NULL;
        }
        
        si->si_attrs = tmp;
 
-       /* Add Attributes */
-
-       for ( i = 0; sync_descs[ i ] != NULL; i++ ) {
-               si->si_attrs[ n++ ] = ch_strdup ( sync_descs[i]->ad_cname.bv_val );
-               si->si_attrs[ n ] = NULL;
+       for ( n = 0; si->si_exattrs[ n ] != NULL; n++ ) /* empty */;
+       if ( n ) {
+               /* Delete Attributes from exattrs list */
+               for ( i = 0; sync_descs[i] != NULL; i++ ) {
+                       for ( j = 0; si->si_exattrs[j] != NULL; j++ ) {
+                               if ( strcmp( si->si_exattrs[j], sync_descs[i]->ad_cname.bv_val )
+                                       == 0 )
+                               {
+                                       ch_free( si->si_exattrs[j] );
+                                       for ( k = j; si->si_exattrs[k] != NULL; k++ ) {
+                                               si->si_exattrs[k] = si->si_exattrs[k+1];
+                                       }
+                               }
+                       }
+               }
        }
 }
 
@@ -153,20 +175,18 @@ ldap_sync_search(
                ctrls[1] = NULL;
        }
 
-       timeout.tv_sec = si->si_tlimit > 0 ? si->si_tlimit : 1;
+       timeout.tv_sec = si->si_tlimit;
        timeout.tv_usec = 0;
 
        rc = ldap_search_ext( si->si_ld, si->si_base.bv_val, si->si_scope,
                si->si_filterstr.bv_val, si->si_attrs, si->si_attrsonly,
-               ctrls, NULL, si->si_tlimit < 0 ? NULL : &timeout,
+               ctrls, NULL, si->si_tlimit > 0 ? &timeout : NULL,
                si->si_slimit, &msgid );
        ber_free_buf( ber );
 
        return rc;
 }
 
-static const Listener dummy_list = { {0, ""}, {0, ""} };
-
 static int
 do_syncrep1(
        Operation *op,
@@ -180,6 +200,9 @@ do_syncrep1(
        struct sync_cookie      *sc = NULL;
        struct sync_cookie      syncCookie = { NULL, -1, NULL };
        struct berval   *psub;
+#ifdef HAVE_TLS
+       void    *ssl;
+#endif
 
        psub = &si->si_be->be_nsuffix[0];
 
@@ -258,7 +281,7 @@ do_syncrep1(
 
                lutil_sasl_freedefs( defaults );
 
-               /* FIXME : different error behaviors according to
+               /* FIXME: different error behaviors according to
                 *      1) return code
                 *      2) on err policy : exit, retry, backoff ...
                 */
@@ -272,6 +295,15 @@ do_syncrep1(
                                "ldap_sasl_interactive_bind_s failed (%d)\n",
                                rc, 0, 0 );
 #endif
+
+                       /* FIXME (see above comment) */
+                       /* if Kerberos credentials cache is not active, retry */
+                       if ( strcmp( si->si_saslmech, "GSSAPI" ) == 0 &&
+                               rc == LDAP_LOCAL_ERROR )
+                       {
+                               rc = LDAP_SERVER_DOWN;
+                       }
+
                        goto done;
                }
 #else /* HAVE_CYRUS_SASL */
@@ -281,7 +313,8 @@ do_syncrep1(
                goto done;
 #endif
        } else {
-               rc = ldap_bind_s( si->si_ld, si->si_binddn, si->si_passwd, si->si_bindmethod );
+               rc = ldap_bind_s( si->si_ld,
+                       si->si_binddn, si->si_passwd, si->si_bindmethod );
                if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG ( OPERATION, ERR, "do_syncrep1: "
@@ -294,6 +327,21 @@ do_syncrep1(
                }
        }
 
+       /* Set SSF to strongest of TLS, SASL SSFs */
+       op->o_sasl_ssf = 0;
+       op->o_tls_ssf = 0;
+       op->o_transport_ssf = 0;
+#ifdef HAVE_TLS
+       if ( ldap_get_option( si->si_ld, LDAP_OPT_X_TLS_SSL_CTX, &ssl )
+               == LDAP_SUCCESS && ssl != NULL )
+       {
+               op->o_tls_ssf = ldap_pvt_tls_get_strength( ssl );
+       }
+#endif /* HAVE_TLS */
+       ldap_get_option( si->si_ld, LDAP_OPT_X_SASL_SSF, &op->o_sasl_ssf );
+       op->o_ssf = ( op->o_sasl_ssf > op->o_tls_ssf )
+               ?  op->o_sasl_ssf : op->o_tls_ssf;
+
        /* get syncrepl cookie of shadow replica from subentry */
 
        assert( si->si_rid < 1000 );
@@ -320,7 +368,7 @@ do_syncrep1(
 
                /* read stored cookie if it exists */
                backend_attribute( op, NULL, &op->o_req_ndn,
-                       slap_schema.si_ad_syncreplCookie, &cookie );
+                       slap_schema.si_ad_syncreplCookie, &cookie, ACL_READ );
 
                if ( !cookie ) {
                        /* no stored cookie */
@@ -335,7 +383,7 @@ do_syncrep1(
                        sc = NULL;
                } else {
                        /* stored cookie */
-                       struct berval newcookie = { 0, NULL };
+                       struct berval newcookie = BER_BVNULL;
                        ber_dupbv( &cookie_bv, &cookie[0] );
                        ber_bvarray_add( &si->si_syncCookie.octet_str, &cookie_bv );
                        slap_parse_sync_cookie( &si->si_syncCookie );
@@ -373,7 +421,7 @@ do_syncrep1(
                        struct berval cookie_bv;
                        /* try to read stored cookie */
                        backend_attribute( op, NULL, &op->o_req_ndn,
-                               slap_schema.si_ad_syncreplCookie, &cookie );
+                               slap_schema.si_ad_syncreplCookie, &cookie, ACL_READ );
                        if ( cookie ) {
                                ber_dupbv( &cookie_bv, &cookie[0] );
                                ber_bvarray_add( &si->si_syncCookie.octet_str, &cookie_bv );
@@ -403,6 +451,8 @@ done:
                }
        }
 
+       slap_sl_free( op->o_req_ndn.bv_val, op->o_tmpmemctx );
+
        return rc;
 }
 
@@ -426,15 +476,15 @@ do_syncrep2(
        Entry           *entry = NULL;
 
        int             syncstate;
-       struct berval   syncUUID = { 0, NULL };
+       struct berval   syncUUID = BER_BVNULL;
        struct sync_cookie      syncCookie = { NULL, -1, NULL };
        struct sync_cookie      syncCookie_req = { NULL, -1, NULL };
-       struct berval           cookie = { 0, NULL };
+       struct berval           cookie = BER_BVNULL;
 
        int     rc, err, i;
        ber_len_t       len;
 
-       int rc_efree;
+       int rc_efree = 1;
 
        struct berval   *psub;
        Modifications   *modlist = NULL;
@@ -450,7 +500,7 @@ do_syncrep2(
        BerVarray syncUUIDs = NULL;
        ber_tag_t si_tag;
 
-       if ( slapd_abrupt_shutdown ) {
+       if ( slapd_shutdown ) {
                rc = -2;
                goto done;
        }
@@ -477,7 +527,7 @@ do_syncrep2(
        while (( rc = ldap_result( si->si_ld, LDAP_RES_ANY, LDAP_MSG_ONE, tout_p, &res ))
                > 0 )
        {
-               if ( slapd_abrupt_shutdown ) {
+               if ( slapd_shutdown ) {
                        rc = -2;
                        goto done;
                }
@@ -507,12 +557,14 @@ do_syncrep2(
                                                        syncCookie.octet_str[0].bv_val )
                                                slap_parse_sync_cookie( &syncCookie );
                                }
-                               entry = syncrepl_message_to_entry( si, op, msg,
-                                       &modlist, syncstate );
-                               rc_efree = syncrepl_entry( si, op, entry, modlist, syncstate,
-                                                       &syncUUID, &syncCookie_req );
-                               if ( syncCookie.octet_str && syncCookie.octet_str[0].bv_val ) {
-                                       syncrepl_updateCookie( si, op, psub, &syncCookie );
+                               if ( syncrepl_message_to_entry( si, op, msg,
+                                       &modlist, &entry, syncstate ) == LDAP_SUCCESS ) {
+                                       rc_efree = syncrepl_entry( si, op, entry, modlist,
+                                                               syncstate, &syncUUID, &syncCookie_req );
+                                       if ( syncCookie.octet_str &&
+                                                syncCookie.octet_str[0].bv_val ) {
+                                               syncrepl_updateCookie( si, op, psub, &syncCookie );
+                                       }
                                }
                                ldap_controls_free( rctrls );
                                if ( modlist ) {
@@ -521,15 +573,16 @@ do_syncrep2(
                                if ( rc_efree && entry ) {
                                        entry_free( entry );
                                }
+                               entry = NULL;
                                break;
 
                        case LDAP_RES_SEARCH_REFERENCE:
 #ifdef NEW_LOGGING
                                LDAP_LOG( OPERATION, ERR,
-                                       "do_syncrep2 : reference received\n", 0, 0, 0 );
+                                       "do_syncrep2: reference received error\n", 0, 0, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
-                                       "do_syncrep2 : reference received\n", 0, 0, 0 );
+                                       "do_syncrep2: reference received error\n", 0, 0, 0 );
 #endif
                                break;
 
@@ -570,7 +623,7 @@ do_syncrep2(
                                                &syncCookie_req.ctxcsn[0], &syncCookie.ctxcsn[0], &text );
                                }
                                if ( syncCookie.octet_str && syncCookie.octet_str->bv_val
-                                        && match < 0 ) {
+                                        && match < 0 && err == LDAP_SUCCESS ) {
                                        syncrepl_updateCookie( si, op, psub, &syncCookie );
                                }
                                if ( rctrls ) {
@@ -581,7 +634,8 @@ do_syncrep2(
                                         *      1) err code : LDAP_BUSY ...
                                         *      2) on err policy : stop service, stop sync, retry
                                         */
-                                       if ( refreshDeletes == 0 && match < 0 ) {
+                                       if ( refreshDeletes == 0 && match < 0 &&
+                                                err == LDAP_SUCCESS ) {
                                                syncrepl_del_nonpresent( op, si );
                                        } else {
                                                avl_free( si->si_presentlist, avl_ber_bvfree );
@@ -596,8 +650,6 @@ do_syncrep2(
                                rc = ldap_parse_intermediate( si->si_ld, msg,
                                        &retoid, &retdata, NULL, 0 );
                                if ( !rc && !strcmp( retoid, LDAP_SYNC_INFO ) ) {
-                                       int             si_refreshDelete = 0;
-                                       int             si_refreshPresent = 0;
                                        ber_init2( ber, retdata, LBER_USE_DER );
 
                                        switch ( si_tag = ber_peek_tag( ber, &len )) {
@@ -608,6 +660,7 @@ do_syncrep2(
                                        case LDAP_TAG_SYNC_REFRESH_DELETE:
                                                si_refreshDelete = 1;
                                        case LDAP_TAG_SYNC_REFRESH_PRESENT:
+                                               si_refreshPresent = 1;
                                                si_refreshPresent = 1;
                                                ber_scanf( ber, "t{", &tag );
                                                if ( ber_peek_tag( ber, &len ) == LDAP_TAG_SYNC_COOKIE )
@@ -654,11 +707,12 @@ do_syncrep2(
                                                for ( i = 0; syncUUIDs[i].bv_val; i++ ) {
                                                        struct berval *syncuuid_bv;
                                                        syncuuid_bv = ber_dupbv( NULL, &syncUUIDs[i] );
+                                                       slap_sl_free( syncUUIDs[i].bv_val,op->o_tmpmemctx );
                                                        avl_insert( &si->si_presentlist,
                                                                        (caddr_t) syncuuid_bv,
                                                                        syncuuid_cmp, avl_dup_error );
                                                }
-                                               ber_memfree_x( syncUUIDs, op->o_tmpmemctx );
+                                               slap_sl_free( syncUUIDs, op->o_tmpmemctx );
                                                break;
                                        default:
 #ifdef NEW_LOGGING
@@ -779,6 +833,8 @@ do_syncrepl(
        int first = 0;
        int dostop = 0;
        ber_socket_t s;
+       int i, defer = 1;
+       Backend *be;
 
 #ifdef NEW_LOGGING
        LDAP_LOG ( OPERATION, DETAIL1, "do_syncrepl\n", 0, 0, 0 );
@@ -797,7 +853,7 @@ do_syncrepl(
                return NULL;
        }
 
-       if ( slapd_abrupt_shutdown && si->si_ld ) {
+       if ( slapd_shutdown && si->si_ld ) {
                ldap_get_option( si->si_ld, LDAP_OPT_DESC, &s );
                connection_client_stop( s );
                ldap_unbind( si->si_ld );
@@ -805,25 +861,16 @@ do_syncrepl(
                return NULL;
        }
 
-       conn.c_connid = -1;
-       conn.c_send_ldap_result = slap_send_ldap_result;
-       conn.c_send_search_entry = slap_send_search_entry;
-       conn.c_send_search_reference = slap_send_search_reference;
-       conn.c_listener = (Listener *)&dummy_list;
-       conn.c_peer_name = slap_empty_bv;
+       connection_fake_init( &conn, &op, ctx );
 
-       /* set memory context */
-       op.o_tmpmemctx = sl_mem_create( SLMALLOC_SLAB_SIZE, ctx );
-       op.o_tmpmfuncs = &sl_mfuncs;
+       /* use global malloc for now */
+       op.o_tmpmemctx = NULL;
+       op.o_tmpmfuncs = &ch_mfuncs;
 
        op.o_dn = si->si_updatedn;
        op.o_ndn = si->si_updatedn;
-       op.o_time = slap_get_time();
-       op.o_threadctx = ctx;
        op.o_managedsait = 1;
-       op.o_bd = si->si_be;
-       op.o_conn = &conn;
-       op.o_connid = op.o_conn->c_connid;
+       op.o_bd = be = si->si_be;
 
        op.o_sync_state.ctxcsn = NULL;
        op.o_sync_state.sid = -1;
@@ -835,6 +882,8 @@ do_syncrepl(
        /* Establish session, do search */
        if ( !si->si_ld ) {
                first = 1;
+               si_refreshDelete = 0;
+               si_refreshPresent = 0;
                rc = do_syncrep1( &op, si );
        }
 
@@ -850,11 +899,10 @@ do_syncrepl(
                         */
                        if ( rc == LDAP_SUCCESS ) {
                                if ( first ) {
-                                       rc = connection_client_setup( s, (Listener *)&dummy_list, do_syncrepl,
-                                               arg );
+                                       rc = connection_client_setup( s, do_syncrepl, arg );
                                } else {
                                        connection_client_enable( s );
-                               }
+                               } 
                        } else if ( !first ) {
                                dostop = 1;
                        }
@@ -870,6 +918,7 @@ do_syncrepl(
         * 4) for Persist and Success, reschedule to defer
         */
        ldap_pvt_thread_mutex_lock( &syncrepl_rq.rq_mutex );
+
        if ( ldap_pvt_runqueue_isrunning( &syncrepl_rq, rtask )) {
                ldap_pvt_runqueue_stoptask( &syncrepl_rq, rtask );
        }
@@ -878,28 +927,49 @@ do_syncrepl(
                connection_client_stop( s );
        }
 
-       if ( rc && rc != LDAP_SERVER_DOWN ) {
-               ldap_pvt_runqueue_remove( &syncrepl_rq, rtask );
+       if ( rc == LDAP_SUCCESS ) {
+               if ( si->si_type == LDAP_SYNC_REFRESH_ONLY ) {
+                       defer = 0;
+               }
+               rtask->interval.tv_sec = si->si_interval;
+               ldap_pvt_runqueue_resched( &syncrepl_rq, rtask, defer );
+               if ( si->si_retrynum ) {
+                       for ( i = 0; si->si_retrynum_init[i] != -2; i++ ) {
+                               si->si_retrynum[i] = si->si_retrynum_init[i];
+                       }
+                       si->si_retrynum[i] = -2;
+               }
        } else {
-               if ( rc == LDAP_SERVER_DOWN ||
-                       si->si_type == LDAP_SYNC_REFRESH_ONLY ) {
-                       rc = 0;
-               } else {
-                       rc = 1;
+               for ( i = 0; si->si_retrynum && si->si_retrynum[i] <= 0; i++ ) {
+                       if ( si->si_retrynum[i] == -1  || si->si_retrynum[i] == -2 )
+                               break;
+               }
+
+               if ( !si->si_retrynum || si->si_retrynum[i] == -2 ) {
+                       ldap_pvt_runqueue_remove( &syncrepl_rq, rtask );
+                       LDAP_STAILQ_REMOVE( &be->be_syncinfo, si, syncinfo_s, si_next );
+                       syncinfo_free( si );
+               } else if ( si->si_retrynum[i] >= -1 ) {
+                       if ( si->si_retrynum[i] > 0 )
+                               si->si_retrynum[i]--;
+                       rtask->interval.tv_sec = si->si_retryinterval[i];
+                       ldap_pvt_runqueue_resched( &syncrepl_rq, rtask, 0 );
+                       slap_wake_listener();
                }
-               ldap_pvt_runqueue_resched( &syncrepl_rq, rtask, rc );
        }
+       
        ldap_pvt_thread_mutex_unlock( &syncrepl_rq.rq_mutex );
 
        return NULL;
 }
 
-Entry*
+int
 syncrepl_message_to_entry(
        syncinfo_t      *si,
        Operation       *op,
        LDAPMessage     *msg,
        Modifications   **modlist,
+       Entry                   **entry,
        int             syncstate
 )
 {
@@ -926,7 +996,7 @@ syncrepl_message_to_entry(
                Debug( LDAP_DEBUG_ANY,
                        "Message type should be entry (%d)", ldap_msgtype( msg ), 0, 0 );
 #endif
-               return NULL;
+               return -1;
        }
 
        op->o_tag = LDAP_REQ_ADD;
@@ -941,7 +1011,7 @@ syncrepl_message_to_entry(
                Debug( LDAP_DEBUG_ANY,
                        "syncrepl_message_to_entry : dn get failed (%d)", rc, 0, 0 );
 #endif
-               return NULL;
+               return rc;
        }
 
        dnPrettyNormal( NULL, &bdn, &dn, &ndn, op->o_tmpmemctx );
@@ -950,12 +1020,18 @@ syncrepl_message_to_entry(
        sl_free( ndn.bv_val, op->o_tmpmemctx );
        sl_free( dn.bv_val, op->o_tmpmemctx );
 
-       if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE )
-       {
-               return NULL;
+       if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE ) {
+               if ( entry )
+                       *entry = NULL;
+               return LDAP_SUCCESS;
+       }
+
+       if ( entry == NULL ) {
+               return -1;
        }
 
        e = ( Entry * ) ch_calloc( 1, sizeof( Entry ) );
+       *entry = e;
        e->e_name = op->o_req_dn;
        e->e_nname = op->o_req_ndn;
 
@@ -972,7 +1048,7 @@ syncrepl_message_to_entry(
                mod->sml_next = NULL;
                mod->sml_desc = NULL;
                mod->sml_type = tmp.sml_type;
-               mod->sml_bvalues = tmp.sml_bvalues;
+               mod->sml_values = tmp.sml_values;
                mod->sml_nvalues = NULL;
 
                *modtail = mod;
@@ -987,6 +1063,8 @@ syncrepl_message_to_entry(
                Debug( LDAP_DEBUG_ANY, "syncrepl_message_to_entry: no attributes\n",
                                0, 0, 0 );
 #endif
+               rc = -1;
+               goto done;
        }
 
        rc = slap_mods_check( *modlist, 1, &text, txtbuf, textlen, NULL );
@@ -1001,6 +1079,31 @@ syncrepl_message_to_entry(
 #endif
                goto done;
        }
+
+       /* Strip out dynamically generated attrs */
+       for ( modtail = modlist; *modtail ; ) {
+               mod = *modtail;
+               if ( mod->sml_desc->ad_type->sat_flags & SLAP_AT_DYNAMIC ) {
+                       *modtail = mod->sml_next;
+                       slap_mod_free( &mod->sml_mod, 0 );
+                       ch_free( mod );
+               } else {
+                       modtail = &mod->sml_next;
+               }
+       }
+
+       /* Strip out attrs in exattrs list */
+       for ( modtail = modlist; *modtail ; ) {
+               mod = *modtail;
+               if ( ldap_charray_inlist( si->si_exattrs,
+                                       mod->sml_desc->ad_type->sat_cname.bv_val )) {
+                       *modtail = mod->sml_next;
+                       slap_mod_free( &mod->sml_mod, 0 );
+                       ch_free( mod );
+               } else {
+                       modtail = &mod->sml_next;
+               }
+       }
        
        rc = slap_mods2entry( *modlist, &e, 1, 1, &text, txtbuf, textlen);
        if( rc != LDAP_SUCCESS ) {
@@ -1016,18 +1119,20 @@ syncrepl_message_to_entry(
 done:
        ber_free ( ber, 0 );
        if ( rc != LDAP_SUCCESS ) {
-               entry_free( e );
-               e = NULL;
+               if ( e ) {
+                       entry_free( e );
+                       *entry = e = NULL;
+               }
        }
 
-       return e;
+       return rc;
 }
 
 int
 syncrepl_entry(
        syncinfo_t* si,
        Operation *op,
-       Entry* e,
+       Entry* entry,
        Modifications* modlist,
        int syncstate,
        struct berval* syncUUID,
@@ -1037,24 +1142,41 @@ syncrepl_entry(
        Backend *be = op->o_bd;
        slap_callback   cb = { NULL };
        struct berval   *syncuuid_bv = NULL;
-       struct berval   syncUUID_strrep = { 0, NULL };
+       struct berval   syncUUID_strrep = BER_BVNULL;
+       struct berval   uuid_bv = BER_BVNULL;
 
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_search = {REP_RESULT};
+       SlapReply       rs_delete = {REP_RESULT};
+       SlapReply       rs_add = {REP_RESULT};
+       SlapReply       rs_modify = {REP_RESULT};
        Filter f = {0};
        AttributeAssertion ava = {0};
        int rc = LDAP_SUCCESS;
        int ret = LDAP_SUCCESS;
        const char *text;
 
+       struct berval pdn = BER_BVNULL;
+       struct berval org_req_dn = BER_BVNULL;
+       struct berval org_req_ndn = BER_BVNULL;
+       struct berval org_dn = BER_BVNULL;
+       struct berval org_ndn = BER_BVNULL;
+       int     org_managedsait;
+
        if (( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_ADD ))
        {
-               syncuuid_bv = ber_dupbv( NULL, syncUUID );
-               avl_insert( &si->si_presentlist, (caddr_t) syncuuid_bv,
-                       syncuuid_cmp, avl_dup_error );
+               if (!si_refreshPresent) {
+                       syncuuid_bv = ber_dupbv( NULL, syncUUID );
+                       avl_insert( &si->si_presentlist, (caddr_t) syncuuid_bv,
+                               syncuuid_cmp, avl_dup_error );
+               }
        }
 
        if ( syncstate == LDAP_SYNC_PRESENT ) {
-               return e ? 1 : 0;
+               return 0;
+       } else if ( syncstate != LDAP_SYNC_DELETE ) {
+               if ( entry == NULL ) {
+                       return 0;
+               }
        }
 
        f.f_choice = LDAP_FILTER_EQUALITY;
@@ -1072,12 +1194,17 @@ syncrepl_entry(
                syncUUID->bv_val, syncUUID->bv_len );
        op->ors_filterstr.bv_val[op->ors_filterstr.bv_len] = '\0';
 
+       op->o_tag = LDAP_REQ_SEARCH;
        op->ors_scope = LDAP_SCOPE_SUBTREE;
 
        /* get syncrepl cookie of shadow replica from subentry */
        op->o_req_dn = si->si_base;
        op->o_req_ndn = si->si_base;
 
+       op->o_time = slap_get_time();
+       op->ors_tlimit = SLAP_NO_LIMIT;
+       op->ors_slimit = 1;
+
        /* set callback function */
        op->o_callback = &cb;
        cb.sc_response = dn_callback;
@@ -1085,7 +1212,9 @@ syncrepl_entry(
 
        si->si_syncUUID_ndn.bv_val = NULL;
 
-       rc = be->be_search( op, &rs );
+       if ( limits_check( op, &rs_search ) == 0 ) {
+               rc = be->be_search( op, &rs_search );
+       }
 
        if ( op->ors_filterstr.bv_val ) {
                sl_free( op->ors_filterstr.bv_val, op->o_tmpmemctx );
@@ -1094,8 +1223,7 @@ syncrepl_entry(
        cb.sc_response = null_callback;
        cb.sc_private = si;
 
-       if ( rc == LDAP_SUCCESS && si->si_syncUUID_ndn.bv_val )
-       {
+       if ( rs_search.sr_err == LDAP_SUCCESS && si->si_syncUUID_ndn.bv_val ) {
                char *subseq_ptr;
 
                if ( syncstate != LDAP_SYNC_DELETE ) {
@@ -1112,76 +1240,132 @@ syncrepl_entry(
                op->o_req_dn = si->si_syncUUID_ndn;
                op->o_req_ndn = si->si_syncUUID_ndn;
                op->o_tag = LDAP_REQ_DELETE;
-               rc = be->be_delete( op, &rs );
+               rc = be->be_delete( op, &rs_delete );
+
+               org_req_dn = op->o_req_dn;
+               org_req_ndn = op->o_req_ndn;
+               org_dn = op->o_dn;
+               org_ndn = op->o_ndn;
+               org_managedsait = get_manageDSAit( op );
+               op->o_dn = op->o_bd->be_rootdn;
+               op->o_ndn = op->o_bd->be_rootndn;
+               op->o_managedsait = 1;
+
+               while ( rs_delete.sr_err == LDAP_SUCCESS && op->o_delete_glue_parent ) {
+                       op->o_delete_glue_parent = 0;
+                       if ( !be_issuffix( op->o_bd, &op->o_req_ndn )) {
+                               slap_callback cb = { NULL };
+                               cb.sc_response = slap_null_cb;
+                               dnParent( &op->o_req_ndn, &pdn );
+                               op->o_req_dn = pdn;
+                               op->o_req_ndn = pdn;
+                               op->o_callback = &cb;
+                               op->o_bd->be_delete( op, &rs_delete );
+                       } else {
+                               break;
+                   }
+               }
+
+               op->o_managedsait = org_managedsait;
+               op->o_dn = org_dn;
+               op->o_ndn = org_ndn;
+               op->o_req_dn = org_req_dn;
+               op->o_req_ndn = org_req_ndn;
+               op->o_delete_glue_parent = 0;
+
                op->o_no_psearch = 0;
        }
 
        switch ( syncstate ) {
        case LDAP_SYNC_ADD:
        case LDAP_SYNC_MODIFY:
-               if ( rc == LDAP_SUCCESS ||
-                        rc == LDAP_REFERRAL ||
-                        rc == LDAP_NO_SUCH_OBJECT )
+               if ( rs_search.sr_err == LDAP_SUCCESS ||
+                        rs_search.sr_err == LDAP_REFERRAL ||
+                        rs_search.sr_err == LDAP_NO_SUCH_OBJECT ||
+                        rs_search.sr_err == LDAP_NOT_ALLOWED_ON_NONLEAF )
                {
-                       attr_delete( &e->e_attrs, slap_schema.si_ad_entryUUID );
-                       attr_merge_one( e, slap_schema.si_ad_entryUUID,
-                               syncUUID, &ava.aa_value );
+                       attr_delete( &entry->e_attrs, slap_schema.si_ad_entryUUID );
+                       attr_merge_one( entry, slap_schema.si_ad_entryUUID,
+                               &syncUUID_strrep, syncUUID );
 
                        op->o_tag = LDAP_REQ_ADD;
-                       op->ora_e = e;
-                       op->o_req_dn = e->e_name;
-                       op->o_req_ndn = e->e_nname;
-                       rc = be->be_add( op, &rs );
+                       op->ora_e = entry;
+                       op->o_req_dn = entry->e_name;
+                       op->o_req_ndn = entry->e_nname;
+
+                       rc = be->be_add( op, &rs_add );
 
-                       if ( rc != LDAP_SUCCESS ) {
-                               if ( rc == LDAP_ALREADY_EXISTS ) {      
+                       if ( rs_add.sr_err != LDAP_SUCCESS ) {
+                               if ( rs_add.sr_err == LDAP_ALREADY_EXISTS &&
+                                        rs_search.sr_err != LDAP_NO_SUCH_OBJECT ) {
+                                       Modifications *mod;
+                                       Modifications *modtail = modlist;
+
+                                       assert( modlist );
+
+                                       for ( mod = modlist; mod != NULL; mod = mod->sml_next ) {
+                                               modtail = mod;
+                                       }
+
+                                       mod = (Modifications *)ch_calloc(1, sizeof(Modifications));
+                                       ber_dupbv( &uuid_bv, syncUUID );
+                                       mod->sml_op = LDAP_MOD_REPLACE;
+                                       mod->sml_desc = slap_schema.si_ad_entryUUID;
+                                       mod->sml_type = mod->sml_desc->ad_cname;
+                                       ber_bvarray_add( &mod->sml_values, &uuid_bv );
+                                       modtail->sml_next = mod;
+                                       
                                        op->o_tag = LDAP_REQ_MODIFY;
                                        op->orm_modlist = modlist;
-                                       op->o_req_dn = e->e_name;
-                                       op->o_req_ndn = e->e_nname;
-                                       rc = be->be_modify( op, &rs );
-                                       if ( rc != LDAP_SUCCESS ) {
+                                       op->o_req_dn = entry->e_name;
+                                       op->o_req_ndn = entry->e_nname;
+
+                                       rc = be->be_modify( op, &rs_modify );
+                                       if ( rs_modify.sr_err != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
                                                LDAP_LOG( OPERATION, ERR,
                                                        "syncrepl_entry : be_modify failed (%d)\n",
-                                                       rc, 0, 0 );
+                                                       rs_modify.sr_err, 0, 0 );
 #else
                                                Debug( LDAP_DEBUG_ANY,
                                                        "syncrepl_entry : be_modify failed (%d)\n",
-                                                       rc, 0, 0 );
+                                                       rs_modify.sr_err, 0, 0 );
 #endif
                                        }
                                        ret = 1;
                                        goto done;
-                               } else if ( rc == LDAP_REFERRAL || rc == LDAP_NO_SUCH_OBJECT ) {
-                                       syncrepl_add_glue( op, e );
+                               } else if ( rs_modify.sr_err == LDAP_REFERRAL ||
+                                                       rs_modify.sr_err == LDAP_NO_SUCH_OBJECT ) {
+                                       syncrepl_add_glue( op, entry );
                                        ret = 0;
                                        goto done;
                                } else {
 #ifdef NEW_LOGGING
                                        LDAP_LOG( OPERATION, ERR,
                                                "syncrepl_entry : be_add failed (%d)\n",
-                                               rc, 0, 0 );
+                                               rs_add.sr_err, 0, 0 );
 #else
                                        Debug( LDAP_DEBUG_ANY,
                                                "syncrepl_entry : be_add failed (%d)\n",
-                                               rc, 0, 0 );
+                                               rs_add.sr_err, 0, 0 );
 #endif
                                        ret = 1;
                                        goto done;
                                }
                        } else {
-                               be_entry_release_w( op, e );
+                               be_entry_release_w( op, entry );
                                ret = 0;
                                goto done;
                        }
                } else {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR,
-                               "syncrepl_entry : be_search failed (%d)\n", rc, 0, 0 );
+                               "syncrepl_entry : be_search failed (%d)\n",
+                               rs_search.sr_err, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
-                               "syncrepl_entry : be_search failed (%d)\n", rc, 0, 0 );
+                               "syncrepl_entry : be_search failed (%d)\n",
+                               rs_search.sr_err, 0, 0 );
 #endif
                        ret = 1;
                        goto done;
@@ -1189,7 +1373,7 @@ syncrepl_entry(
 
        case LDAP_SYNC_DELETE :
                /* Already deleted */
-               ret = 1;
+               ret = 0;
                goto done;
 
        default :
@@ -1207,14 +1391,21 @@ syncrepl_entry(
 done :
 
        if ( syncUUID_strrep.bv_val ) {
-               ber_memfree_x( syncUUID_strrep.bv_val, op->o_tmpmemctx );
+               slap_sl_free( syncUUID_strrep.bv_val, op->o_tmpmemctx );
        }
        if ( si->si_syncUUID_ndn.bv_val ) {
-               ber_memfree_x( si->si_syncUUID_ndn.bv_val, op->o_tmpmemctx );
+               ch_free( si->si_syncUUID_ndn.bv_val );
+               si->si_syncUUID_ndn.bv_val = NULL;
        }
        return ret;
 }
 
+static struct berval gcbva[] = {
+       BER_BVC("top"),
+       BER_BVC("glue"),
+       BER_BVNULL
+};
+
 static void
 syncrepl_del_nonpresent(
        Operation *op,
@@ -1223,8 +1414,24 @@ syncrepl_del_nonpresent(
 {
        Backend* be = op->o_bd;
        slap_callback   cb = { NULL };
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_search = {REP_RESULT};
+       SlapReply       rs_delete = {REP_RESULT};
+       SlapReply       rs_modify = {REP_RESULT};
        struct nonpresent_entry *np_list, *np_prev;
+       int rc;
+       Modifications *ml;
+       Modifications *mlnext;
+       Modifications *mod;
+       Modifications *modlist = NULL;
+       Modifications **modtail;
+       Attribute       *attr;
+
+       struct berval pdn = BER_BVNULL;
+       struct berval org_req_dn = BER_BVNULL;
+       struct berval org_req_ndn = BER_BVNULL;
+       struct berval org_dn = BER_BVNULL;
+       struct berval org_ndn = BER_BVNULL;
+       int     org_managedsait;
 
        op->o_req_dn = si->si_base;
        op->o_req_ndn = si->si_base;
@@ -1236,15 +1443,22 @@ syncrepl_del_nonpresent(
        op->o_tag = LDAP_REQ_SEARCH;
        op->ors_scope = si->si_scope;
        op->ors_deref = LDAP_DEREF_NEVER;
-       op->ors_slimit = 0;
-       op->ors_tlimit = 0;
+       op->o_time = slap_get_time();
+       op->ors_tlimit = SLAP_NO_LIMIT;
+       op->ors_slimit = SLAP_NO_LIMIT;
        op->ors_attrsonly = 0;
        op->ors_attrs = NULL;
        op->ors_filter = str2filter_x( op, si->si_filterstr.bv_val );
        op->ors_filterstr = si->si_filterstr;
 
        op->o_nocaching = 1;
-       be->be_search( op, &rs );
+       op->o_managedsait = 0;
+
+       if ( limits_check( op, &rs_search ) == 0 ) {
+               rc = be->be_search( op, &rs_search );
+       }
+
+       op->o_managedsait = 1;
        op->o_nocaching = 0;
 
        if ( op->ors_filter ) filter_free_x( op, op->ors_filter );
@@ -1261,7 +1475,70 @@ syncrepl_del_nonpresent(
                        cb.sc_private = si;
                        op->o_req_dn = *np_prev->npe_name;
                        op->o_req_ndn = *np_prev->npe_nname;
-                       op->o_bd->be_delete( op, &rs );
+                       rc = op->o_bd->be_delete( op, &rs_delete );
+
+                       if ( rs_delete.sr_err == LDAP_NOT_ALLOWED_ON_NONLEAF ) {
+                               modtail = &modlist;
+                               mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
+                               mod->sml_op = LDAP_MOD_REPLACE;
+                               mod->sml_desc = slap_schema.si_ad_objectClass;
+                               mod->sml_type = mod->sml_desc->ad_cname;
+                               mod->sml_values = &gcbva[0];
+                               *modtail = mod;
+                               modtail = &mod->sml_next;
+
+                               mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
+                               mod->sml_op = LDAP_MOD_REPLACE;
+                               mod->sml_desc = slap_schema.si_ad_structuralObjectClass;
+                               mod->sml_type = mod->sml_desc->ad_cname;
+                               mod->sml_values = &gcbva[1];
+                               *modtail = mod;
+                               modtail = &mod->sml_next;
+
+                               op->o_tag = LDAP_REQ_MODIFY;
+                               op->orm_modlist = modlist;
+
+                               rc = be->be_modify( op, &rs_modify );
+
+                               for ( ml = modlist; ml != NULL; ml = mlnext ) {
+                                       mlnext = ml->sml_next;
+                                       free( ml );
+                               }
+                       }
+
+                       org_req_dn = op->o_req_dn;
+                       org_req_ndn = op->o_req_ndn;
+                       org_dn = op->o_dn;
+                       org_ndn = op->o_ndn;
+                       org_managedsait = get_manageDSAit( op );
+                       op->o_dn = op->o_bd->be_rootdn;
+                       op->o_ndn = op->o_bd->be_rootndn;
+                       op->o_managedsait = 1;
+
+                       while ( rs_delete.sr_err == LDAP_SUCCESS &&
+                                       op->o_delete_glue_parent ) {
+                               op->o_delete_glue_parent = 0;
+                               if ( !be_issuffix( op->o_bd, &op->o_req_ndn )) {
+                                       slap_callback cb = { NULL };
+                                       cb.sc_response = slap_null_cb;
+                                       dnParent( &op->o_req_ndn, &pdn );
+                                       op->o_req_dn = pdn;
+                                       op->o_req_ndn = pdn;
+                                       op->o_callback = &cb;
+                                       /* give it a root privil ? */
+                                       op->o_bd->be_delete( op, &rs_delete );
+                               } else {
+                                       break;
+                           }
+                       }
+
+                       op->o_managedsait = org_managedsait;
+                       op->o_dn = org_dn;
+                       op->o_ndn = org_ndn;
+                       op->o_req_dn = org_req_dn;
+                       op->o_req_ndn = org_req_ndn;
+                       op->o_delete_glue_parent = 0;
+
                        ber_bvfree( np_prev->npe_name );
                        ber_bvfree( np_prev->npe_nname );
                        op->o_req_dn.bv_val = NULL;
@@ -1274,11 +1551,6 @@ syncrepl_del_nonpresent(
 }
 
 
-static struct berval gcbva[] = {
-       BER_BVC("top"),
-       BER_BVC("glue")
-};
-
 void
 syncrepl_add_glue(
        Operation* op,
@@ -1294,7 +1566,7 @@ syncrepl_add_glue(
        struct berval dn = {0, NULL};
        struct berval ndn = {0, NULL};
        Entry   *glue;
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_add = {REP_RESULT};
        char    *ptr, *comma;
 
        op->o_tag = LDAP_REQ_ADD;
@@ -1348,8 +1620,7 @@ syncrepl_add_glue(
                a->a_vals = ch_calloc( 3, sizeof( struct berval ));
                ber_dupbv( &a->a_vals[0], &gcbva[0] );
                ber_dupbv( &a->a_vals[1], &gcbva[1] );
-               a->a_vals[2].bv_len = 0;
-               a->a_vals[2].bv_val = NULL;
+               ber_dupbv( &a->a_vals[2], &gcbva[2] );
 
                a->a_nvals = a->a_vals;
 
@@ -1361,8 +1632,7 @@ syncrepl_add_glue(
 
                a->a_vals = ch_calloc( 2, sizeof( struct berval ));
                ber_dupbv( &a->a_vals[0], &gcbva[1] );
-               a->a_vals[1].bv_len = 0;
-               a->a_vals[1].bv_val = NULL;
+               ber_dupbv( &a->a_vals[1], &gcbva[2] );
 
                a->a_nvals = a->a_vals;
 
@@ -1372,8 +1642,8 @@ syncrepl_add_glue(
                op->o_req_dn = glue->e_name;
                op->o_req_ndn = glue->e_nname;
                op->ora_e = glue;
-               rc = be->be_add ( op, &rs );
-               if ( rc == LDAP_SUCCESS ) {
+               rc = be->be_add ( op, &rs_add );
+               if ( rs_add.sr_err == LDAP_SUCCESS ) {
                        be_entry_release_w( op, glue );
                } else {
                /* incl. ALREADY EXIST */
@@ -1400,8 +1670,8 @@ syncrepl_add_glue(
        op->o_req_dn = e->e_name;
        op->o_req_ndn = e->e_nname;
        op->ora_e = e;
-       rc = be->be_add ( op, &rs );
-       if ( rc == LDAP_SUCCESS ) {
+       rc = be->be_add ( op, &rs_add );
+       if ( rs_add.sr_err == LDAP_SUCCESS ) {
                be_entry_release_w( op, e );
        } else {
                entry_free( e );
@@ -1459,7 +1729,8 @@ syncrepl_updateCookie(
        struct berval slap_syncrepl_cn_bv = BER_BVNULL;
        
        slap_callback cb = { NULL };
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_add = {REP_RESULT};
+       SlapReply       rs_modify = {REP_RESULT};
 
        slap_sync_cookie_free( &si->si_syncCookie, 0 );
        slap_dup_sync_cookie( &si->si_syncCookie, syncCookie );
@@ -1468,38 +1739,41 @@ syncrepl_updateCookie(
        mod->sml_op = LDAP_MOD_REPLACE;
        mod->sml_desc = slap_schema.si_ad_objectClass;
        mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_bvalues = ocbva;
+       mod->sml_values = ocbva;
        *modtail = mod;
        modtail = &mod->sml_next;
 
        ber_dupbv( &cnbva[0], (struct berval *) &slap_syncrepl_bvc );
        assert( si->si_rid < 1000 );
        cnbva[0].bv_len = snprintf( cnbva[0].bv_val,
-               slap_syncrepl_bvc.bv_len,
+               slap_syncrepl_bvc.bv_len + 1,
                "syncrepl%ld", si->si_rid );
        mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
        mod->sml_op = LDAP_MOD_REPLACE;
        mod->sml_desc = slap_schema.si_ad_cn;
        mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_bvalues = cnbva;
+       mod->sml_values = cnbva;
        *modtail = mod;
        modtail = &mod->sml_next;
 
-       if ( scbva[0].bv_val ) ch_free( scbva[0].bv_val );
-       ber_dupbv( &scbva[0], &si->si_syncCookie.octet_str[0] );
        mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
        mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_syncreplCookie;
+       mod->sml_desc = slap_schema.si_ad_subtreeSpecification;
        mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_bvalues = scbva;
+       mod->sml_values = ssbva;
        *modtail = mod;
        modtail = &mod->sml_next;
 
+       /* Keep this last, so we can avoid touching the previous
+        * attributes unnecessarily.
+        */
+       if ( scbva[0].bv_val ) ch_free( scbva[0].bv_val );
+       ber_dupbv( &scbva[0], &si->si_syncCookie.octet_str[0] );
        mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
        mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_subtreeSpecification;
+       mod->sml_desc = slap_schema.si_ad_syncreplCookie;
        mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_bvalues = ssbva;
+       mod->sml_values = scbva;
        *modtail = mod;
        modtail = &mod->sml_next;
 
@@ -1507,7 +1781,7 @@ syncrepl_updateCookie(
 
        op->o_tag = LDAP_REQ_ADD;
        rc = slap_mods_opattrs( op, modlist, modtail,
-                                                        &text,txtbuf, textlen );
+                &text, txtbuf, textlen, 0 );
 
        for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
                ml->sml_op = LDAP_MOD_REPLACE;
@@ -1528,7 +1802,7 @@ syncrepl_updateCookie(
        slap_syncrepl_cn_bv.bv_val = syncrepl_cbuf;
        assert( si->si_rid < 1000 );
        slap_syncrepl_cn_bv.bv_len = snprintf( slap_syncrepl_cn_bv.bv_val,
-               slap_syncrepl_cn_bvc.bv_len,
+               slap_syncrepl_cn_bvc.bv_len + 1,
                "cn=syncrepl%ld", si->si_rid );
 
        build_new_dn( &slap_syncrepl_dn_bv, pdn, &slap_syncrepl_cn_bv,
@@ -1564,20 +1838,21 @@ syncrepl_updateCookie(
        /* update persistent cookie */
 update_cookie_retry:
        op->o_tag = LDAP_REQ_MODIFY;
-       op->orm_modlist = modlist;
-       rc = be->be_modify( op, &rs );
+       /* Just modify the cookie value, not the entire entry */
+       op->orm_modlist = mod;
+       rc = be->be_modify( op, &rs_modify );
 
-       if ( rc != LDAP_SUCCESS ) {
-               if ( rc == LDAP_REFERRAL ||
-                        rc == LDAP_NO_SUCH_OBJECT ) {
+       if ( rs_modify.sr_err != LDAP_SUCCESS ) {
+               if ( rs_modify.sr_err == LDAP_REFERRAL ||
+                        rs_modify.sr_err == LDAP_NO_SUCH_OBJECT ) {
                        op->o_tag = LDAP_REQ_ADD;
                        op->ora_e = e;
-                       rc = be->be_add( op, &rs );
-                       if ( rc != LDAP_SUCCESS ) {
-                               if ( rc == LDAP_ALREADY_EXISTS ) {
+                       rc = be->be_add( op, &rs_add );
+                       if ( rs_add.sr_err != LDAP_SUCCESS ) {
+                               if ( rs_add.sr_err == LDAP_ALREADY_EXISTS ) {
                                        goto update_cookie_retry;
-                               } else if ( rc == LDAP_REFERRAL ||
-                                                       rc == LDAP_NO_SUCH_OBJECT ) {
+                               } else if ( rs_add.sr_err == LDAP_REFERRAL ||
+                                                       rs_add.sr_err == LDAP_NO_SUCH_OBJECT ) {
 #ifdef NEW_LOGGING
                                        LDAP_LOG( OPERATION, ERR,
                                                "cookie will be non-persistent\n",
@@ -1590,12 +1865,10 @@ update_cookie_retry:
                                } else {
 #ifdef NEW_LOGGING
                                        LDAP_LOG( OPERATION, ERR,
-                                               "be_add failed (%d)\n",
-                                               rc, 0, 0 );
+                                               "be_add failed (%d)\n", rs_add.sr_err, 0, 0 );
 #else
                                        Debug( LDAP_DEBUG_ANY,
-                                               "be_add failed (%d)\n",
-                                               rc, 0, 0 );
+                                               "be_add failed (%d)\n", rs_add.sr_err, 0, 0 );
 #endif
                                }
                        } else {
@@ -1605,10 +1878,10 @@ update_cookie_retry:
                } else {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR,
-                               "be_modify failed (%d)\n", rc, 0, 0 );
+                               "be_modify failed (%d)\n", rs_modify.sr_err, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
-                               "be_modify failed (%d)\n", rc, 0, 0 );
+                               "be_modify failed (%d)\n", rs_modify.sr_err, 0, 0 );
 #endif
                }
        }
@@ -1641,6 +1914,31 @@ done :
        return;
 }
 
+int
+syncrepl_isupdate( Operation *op )
+{
+       return ( syncrepl_isupdate_dn( op->o_bd, &op->o_ndn ));
+}
+
+int
+syncrepl_isupdate_dn(
+       Backend*                be,
+       struct berval*  ndn
+)
+{
+       syncinfo_t*     si;
+       int                     ret = 0;
+
+       if ( !LDAP_STAILQ_EMPTY( &be->be_syncinfo )) {
+               LDAP_STAILQ_FOREACH( si, &be->be_syncinfo, si_next ) {
+                       if ( ( ret = dn_match( &si->si_updatedn, ndn ) ) ) {
+                               return ret;
+                       }
+               }
+       }
+       return 0;
+}
+
 static int
 dn_callback(
        Operation*      op,
@@ -1653,13 +1951,23 @@ dn_callback(
                if ( si->si_syncUUID_ndn.bv_val != NULL ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR,
-                               "dn_callback : multiple entries match dn\n", 0, 0, 0 );
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
-                               "dn_callback : multiple entries match dn\n", 0, 0, 0 );
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
 #endif
                } else {
-                       ber_dupbv_x( &si->si_syncUUID_ndn, &rs->sr_entry->e_nname, op->o_tmpmemctx );
+                       ber_dupbv_x( &si->si_syncUUID_ndn, &rs->sr_entry->e_nname, NULL );
+               }
+       } else if ( rs->sr_type == REP_RESULT ) {
+               if ( rs->sr_err == LDAP_SIZELIMIT_EXCEEDED ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG( OPERATION, ERR,
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
+#else
+                       Debug( LDAP_DEBUG_ANY,
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
+#endif
                }
        }
 
@@ -1687,7 +1995,7 @@ nonpresent_callback(
 
                if ( a == NULL ) return 0;
 
-               present_uuid = avl_find( si->si_presentlist, &a->a_vals[0],
+               present_uuid = avl_find( si->si_presentlist, &a->a_nvals[0],
                        syncuuid_cmp );
 
                if ( present_uuid == NULL ) {
@@ -1699,7 +2007,7 @@ nonpresent_callback(
 
                } else {
                        avl_delete( &si->si_presentlist,
-                                       &a->a_vals[0], syncuuid_cmp );
+                                       &a->a_nvals[0], syncuuid_cmp );
                        ch_free( present_uuid->bv_val );
                        ch_free( present_uuid );
                }
@@ -1710,13 +2018,13 @@ nonpresent_callback(
 static int
 null_callback(
        Operation*      op,
-       SlapReply*      rs
-)
+       SlapReply*      rs )
 {
        if ( rs->sr_err != LDAP_SUCCESS &&
                rs->sr_err != LDAP_REFERRAL &&
                rs->sr_err != LDAP_ALREADY_EXISTS &&
-               rs->sr_err != LDAP_NO_SUCH_OBJECT )
+               rs->sr_err != LDAP_NO_SUCH_OBJECT &&
+               rs->sr_err != LDAP_NOT_ALLOWED_ON_NONLEAF )
        {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, ERR,
@@ -1736,8 +2044,7 @@ slap_create_syncrepl_entry(
        Backend *be,
        struct berval *context_csn,
        struct berval *rdn,
-       struct berval *cn
-)
+       struct berval *cn )
 {
        Entry* e;
 
@@ -1831,7 +2138,7 @@ syncuuid_cmp( const void* v_uuid1, const void* v_uuid2 )
        const struct berval *uuid2 = v_uuid2;
        int rc = uuid1->bv_len - uuid2->bv_len;
        if ( rc ) return rc;
-       return ( strcmp( uuid1->bv_val, uuid2->bv_val ) );
+       return ( memcmp( uuid1->bv_val, uuid2->bv_val, uuid1->bv_len ) );
 }
 
 static void
@@ -1846,3 +2153,97 @@ avl_ber_bvfree( void *bv )
        ch_free ( (char *) bv );
 }
 
+void
+syncinfo_free( syncinfo_t *sie )
+{
+       if ( sie->si_provideruri ) {
+               ch_free( sie->si_provideruri );
+       }
+       if ( sie->si_provideruri_bv ) {
+               ber_bvarray_free( sie->si_provideruri_bv );
+       }
+       if ( sie->si_updatedn.bv_val ) {
+               ch_free( sie->si_updatedn.bv_val );
+       }
+       if ( sie->si_binddn ) {
+               ch_free( sie->si_binddn );
+       }
+       if ( sie->si_passwd ) {
+               ch_free( sie->si_passwd );
+       }
+       if ( sie->si_saslmech ) {
+               ch_free( sie->si_saslmech );
+       }
+       if ( sie->si_secprops ) {
+               ch_free( sie->si_secprops );
+       }
+       if ( sie->si_realm ) {
+               ch_free( sie->si_realm );
+       }
+       if ( sie->si_authcId ) {
+               ch_free( sie->si_authcId );
+       }
+       if ( sie->si_authzId ) {
+               ch_free( sie->si_authzId );
+       }
+       if ( sie->si_filterstr.bv_val ) {
+               ch_free( sie->si_filterstr.bv_val );
+       }
+       if ( sie->si_base.bv_val ) {
+               ch_free( sie->si_base.bv_val );
+       }
+       if ( sie->si_attrs ) {
+               int i = 0;
+               while ( sie->si_attrs[i] != NULL ) {
+                       ch_free( sie->si_attrs[i] );
+                       i++;
+               }
+               ch_free( sie->si_attrs );
+       }
+       if ( sie->si_exattrs ) {
+               int i = 0;
+               while ( sie->si_exattrs[i] != NULL ) {
+                       ch_free( sie->si_exattrs[i] );
+                       i++;
+               }
+               ch_free( sie->si_exattrs );
+       }
+       if ( sie->si_retryinterval ) {
+               ch_free( sie->si_retryinterval );
+       }
+       if ( sie->si_retrynum ) {
+               ch_free( sie->si_retrynum );
+       }
+       if ( sie->si_retrynum_init ) {
+               ch_free( sie->si_retrynum_init );
+       }
+       slap_sync_cookie_free( &sie->si_syncCookie, 0 );
+       if ( sie->si_syncUUID_ndn.bv_val ) {
+               ch_free( sie->si_syncUUID_ndn.bv_val );
+       }
+       if ( sie->si_presentlist ) {
+           avl_free( sie->si_presentlist, avl_ber_bvfree );
+       }
+       if ( sie->si_ld ) {
+               ldap_ld_free( sie->si_ld, 1, NULL, NULL );
+       }
+       while ( !LDAP_LIST_EMPTY( &sie->si_nonpresentlist )) {
+               struct nonpresent_entry* npe;
+               npe = LDAP_LIST_FIRST( &sie->si_nonpresentlist );
+               LDAP_LIST_REMOVE( npe, npe_link );
+               if ( npe->npe_name ) {
+                       if ( npe->npe_name->bv_val ) {
+                               ch_free( npe->npe_name->bv_val );
+                       }
+                       ch_free( npe->npe_name );
+               }
+               if ( npe->npe_nname ) {
+                       if ( npe->npe_nname->bv_val ) {
+                               ch_free( npe->npe_nname->bv_val );
+                       }
+                       ch_free( npe->npe_nname );
+               }
+               ch_free( npe );
+       }
+       ch_free( sie );
+}