]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/syncrepl.c
ITS#2919 move OpenLDAPtime to OpenLDAPperson
[openldap] / servers / slapd / syncrepl.c
index fe4e41e47bd9ea917d411ee1f9c1583c35a4d9c5..58fca6ce87bf17e73c3ddae56545ec3c58d66460 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2003-2004 The OpenLDAP Foundation.
+ * Copyright 2003-2005 The OpenLDAP Foundation.
  * Portions Copyright 2003 by IBM Corporation.
  * Portions Copyright 2003 by Howard Chu, Symas Corporation.
  * All rights reserved.
 #undef ldap_debug
 #include "../../libraries/libldap/ldap-int.h"
 
-#define SYNCREPL_STR   "syncreplxxx"
-#define CN_STR "cn="
-
-static const struct berval slap_syncrepl_bvc = BER_BVC(SYNCREPL_STR);
-static const struct berval slap_syncrepl_cn_bvc = BER_BVC(CN_STR SYNCREPL_STR);
-
 static int syncuuid_cmp( const void *, const void * );
 static void avl_ber_bvfree( void * );
 static void syncrepl_del_nonpresent( Operation *, syncinfo_t *, BerVarray );
@@ -231,12 +225,11 @@ ldap_sync_search(
        ber_init2( ber, NULL, LBER_USE_DER );
        ber_set_option( ber, LBER_OPT_BER_MEMCTX, &ctx );
 
-       if ( si->si_syncCookie.octet_str &&
-               !BER_BVISNULL( &si->si_syncCookie.octet_str[0] ) )
+       if ( !BER_BVISNULL( &si->si_syncCookie.octet_str ) )
        {
                ber_printf( ber, "{eO}",
                        abs(si->si_type),
-                       &si->si_syncCookie.octet_str[0] );
+                       &si->si_syncCookie.octet_str );
        } else {
                ber_printf( ber, "{e}",
                        abs(si->si_type) );
@@ -251,9 +244,9 @@ ldap_sync_search(
        c[0].ldctl_iscritical = si->si_type < 0;
        ctrls[0] = &c[0];
 
-       if ( si->si_authzId ) {
+       if ( si->si_bindconf.sb_authzId ) {
                c[1].ldctl_oid = LDAP_CONTROL_PROXY_AUTHZ;
-               ber_str2bv( si->si_authzId, 0, 0, &c[1].ldctl_value );
+               ber_str2bv( si->si_bindconf.sb_authzId, 0, 0, &c[1].ldctl_value );
                c[1].ldctl_iscritical = 1;
                ctrls[1] = &c[1];
                ctrls[2] = NULL;
@@ -280,8 +273,6 @@ do_syncrep1(
        int     rc;
        int cmdline_cookie_found = 0;
 
-       char syncrepl_cbuf[sizeof(CN_STR SYNCREPL_STR)];
-       struct berval syncrepl_cn_bv;
        struct sync_cookie      *sc = NULL;
        struct berval   *psub;
 #ifdef HAVE_TLS
@@ -291,11 +282,11 @@ do_syncrep1(
        psub = &si->si_be->be_nsuffix[0];
 
        /* Init connection to master */
-       rc = ldap_initialize( &si->si_ld, si->si_provideruri );
+       rc = ldap_initialize( &si->si_ld, si->si_provideruri.bv_val );
        if ( rc != LDAP_SUCCESS ) {
                Debug( LDAP_DEBUG_ANY,
                        "do_syncrep1: ldap_initialize failed (%s)\n",
-                       si->si_provideruri, 0, 0 );
+                       si->si_provideruri.bv_val, 0, 0 );
                return rc;
        }
 
@@ -304,39 +295,40 @@ do_syncrep1(
 
        /* Bind to master */
 
-       if ( si->si_tls ) {
+       if ( si->si_bindconf.sb_tls ) {
                rc = ldap_start_tls_s( si->si_ld, NULL, NULL );
                if( rc != LDAP_SUCCESS ) {
                        Debug( LDAP_DEBUG_ANY,
                                "%s: ldap_start_tls failed (%d)\n",
-                               si->si_tls == SYNCINFO_TLS_CRITICAL ? "Error" : "Warning",
+                               si->si_bindconf.sb_tls == SB_TLS_CRITICAL ? "Error" : "Warning",
                                rc, 0 );
-                       if( si->si_tls == SYNCINFO_TLS_CRITICAL ) goto done;
+                       if( si->si_bindconf.sb_tls == SB_TLS_CRITICAL ) goto done;
                }
        }
 
-       if ( si->si_bindmethod == LDAP_AUTH_SASL ) {
+       if ( si->si_bindconf.sb_method == LDAP_AUTH_SASL ) {
 #ifdef HAVE_CYRUS_SASL
                void *defaults;
 
-               if ( si->si_secprops != NULL ) {
+               if ( si->si_bindconf.sb_secprops != NULL ) {
                        rc = ldap_set_option( si->si_ld,
-                               LDAP_OPT_X_SASL_SECPROPS, si->si_secprops);
+                               LDAP_OPT_X_SASL_SECPROPS, si->si_bindconf.sb_secprops);
 
                        if( rc != LDAP_OPT_SUCCESS ) {
                                Debug( LDAP_DEBUG_ANY, "Error: ldap_set_option "
                                        "(%s,SECPROPS,\"%s\") failed!\n",
-                                       si->si_provideruri, si->si_secprops, 0 );
+                                       si->si_provideruri.bv_val, si->si_bindconf.sb_secprops, 0 );
                                goto done;
                        }
                }
 
-               defaults = lutil_sasl_defaults( si->si_ld, si->si_saslmech,
-                       si->si_realm, si->si_authcId, si->si_passwd, si->si_authzId );
+               defaults = lutil_sasl_defaults( si->si_ld, si->si_bindconf.sb_saslmech,
+                       si->si_bindconf.sb_realm, si->si_bindconf.sb_authcId,
+                       si->si_bindconf.sb_cred, si->si_bindconf.sb_authzId );
 
                rc = ldap_sasl_interactive_bind_s( si->si_ld,
-                               si->si_binddn,
-                               si->si_saslmech,
+                               si->si_bindconf.sb_binddn,
+                               si->si_bindconf.sb_saslmech,
                                NULL, NULL,
                                LDAP_SASL_QUIET,
                                lutil_sasl_interact,
@@ -355,7 +347,7 @@ do_syncrep1(
 
                        /* FIXME (see above comment) */
                        /* if Kerberos credentials cache is not active, retry */
-                       if ( strcmp( si->si_saslmech, "GSSAPI" ) == 0 &&
+                       if ( strcmp( si->si_bindconf.sb_saslmech, "GSSAPI" ) == 0 &&
                                rc == LDAP_LOCAL_ERROR )
                        {
                                rc = LDAP_SERVER_DOWN;
@@ -372,8 +364,8 @@ do_syncrep1(
 #endif
 
        } else {
-               rc = ldap_bind_s( si->si_ld,
-                       si->si_binddn, si->si_passwd, si->si_bindmethod );
+               rc = ldap_bind_s( si->si_ld, si->si_bindconf.sb_binddn,
+                       si->si_bindconf.sb_cred, si->si_bindconf.sb_method );
                if ( rc != LDAP_SUCCESS ) {
                        Debug( LDAP_DEBUG_ANY, "do_syncrep1: "
                                "ldap_bind_s failed (%d)\n", rc, 0, 0 );
@@ -396,94 +388,51 @@ do_syncrep1(
        op->o_ssf = ( op->o_sasl_ssf > op->o_tls_ssf )
                ?  op->o_sasl_ssf : op->o_tls_ssf;
 
-       /* get syncrepl cookie of shadow replica from subentry */
-       assert( si->si_rid < 1000 );
-       syncrepl_cn_bv.bv_val = syncrepl_cbuf;
-       syncrepl_cn_bv.bv_len = snprintf( syncrepl_cbuf, sizeof(syncrepl_cbuf),
-               CN_STR "syncrepl%ld", si->si_rid );
-       build_new_dn( &op->o_req_ndn, psub, &syncrepl_cn_bv, op->o_tmpmemctx );
-       op->o_req_dn = op->o_req_ndn;
-
-       LDAP_STAILQ_FOREACH( sc, &slap_sync_cookie, sc_next ) {
-               if ( si->si_rid == sc->rid ) {
-                       cmdline_cookie_found = 1;
-                       break;
-               }
-       }
 
-       if ( cmdline_cookie_found ) {
-               /* cookie is supplied in the command line */
-               BerVarray cookie = NULL;
-               struct berval cookie_bv;
+       if ( BER_BVISNULL( &si->si_syncCookie.octet_str )) {
+               /* get contextCSN shadow replica from database */
+               BerVarray csn = NULL;
+               struct berval newcookie;
 
-               LDAP_STAILQ_REMOVE( &slap_sync_cookie, sc, sync_cookie, sc_next );
-               slap_sync_cookie_free( &si->si_syncCookie, 0 );
+               assert( si->si_rid < 1000 );
+               op->o_req_ndn = op->o_bd->be_nsuffix[0];
+               op->o_req_dn = op->o_req_ndn;
 
-               /* read stored cookie if it exists */
+               /* try to read stored contextCSN */
                backend_attribute( op, NULL, &op->o_req_ndn,
-                       slap_schema.si_ad_syncreplCookie, &cookie, ACL_READ );
+                       slap_schema.si_ad_contextCSN, &csn, ACL_READ );
+               if ( csn ) {
+                       ch_free( si->si_syncCookie.ctxcsn.bv_val );
+                       ber_dupbv( &si->si_syncCookie.ctxcsn, csn );
+                       ber_bvarray_free_x( csn, op->o_tmpmemctx );
+               }
+
+               si->si_syncCookie.rid = si->si_rid;
 
-               if ( !cookie ) {
-                       /* no stored cookie */
-                       if ( sc->ctxcsn == NULL ||
-                                BER_BVISNULL( sc->ctxcsn ) ) {
+               LDAP_STAILQ_FOREACH( sc, &slap_sync_cookie, sc_next ) {
+                       if ( si->si_rid == sc->rid ) {
+                               cmdline_cookie_found = 1;
+                               break;
+                       }
+               }
+
+               if ( cmdline_cookie_found ) {
+                       /* cookie is supplied in the command line */
+
+                       LDAP_STAILQ_REMOVE( &slap_sync_cookie, sc, sync_cookie, sc_next );
+
+                       if ( BER_BVISNULL( &sc->ctxcsn ) ) {
                                /* if cmdline cookie does not have ctxcsn */
                                /* component, set it to an initial value */
                                slap_init_sync_cookie_ctxcsn( sc );
                        }
+                       slap_sync_cookie_free( &si->si_syncCookie, 0 );
                        slap_dup_sync_cookie( &si->si_syncCookie, sc );
                        slap_sync_cookie_free( sc, 1 );
-                       sc = NULL;
-
-               } else {
-                       /* stored cookie */
-                       struct berval newcookie = BER_BVNULL;
-                       ber_dupbv( &cookie_bv, &cookie[0] );
-                       ber_bvarray_add( &si->si_syncCookie.octet_str, &cookie_bv );
-                       slap_parse_sync_cookie( &si->si_syncCookie );
-                       ber_bvarray_free( si->si_syncCookie.octet_str );
-                       si->si_syncCookie.octet_str = NULL;
-                       ber_bvarray_free_x( cookie, op->o_tmpmemctx );
-                       if ( sc->sid != -1 ) {
-                               /* command line cookie wins */
-                               si->si_syncCookie.sid = sc->sid;
-                       }
-                       if ( sc->ctxcsn != NULL ) {
-                               /* command line cookie wins */
-                               if ( si->si_syncCookie.ctxcsn ) {
-                                       ber_bvarray_free( si->si_syncCookie.ctxcsn );
-                                       si->si_syncCookie.ctxcsn = NULL;
-                               }
-                               ber_dupbv( &cookie_bv, &sc->ctxcsn[0] );
-                               ber_bvarray_add( &si->si_syncCookie.ctxcsn, &cookie_bv );
-                       }
-                       if ( sc->rid != -1 ) {
-                               /* command line cookie wins */
-                               si->si_syncCookie.rid = sc->rid;
-                       }
-                       slap_sync_cookie_free( sc, 1 );
-                       sc = NULL;
-                       slap_compose_sync_cookie( NULL, &newcookie,
-                                       &si->si_syncCookie.ctxcsn[0],
-                                       si->si_syncCookie.sid, si->si_syncCookie.rid );
-                       ber_bvarray_add( &si->si_syncCookie.octet_str, &newcookie );
                }
 
-       } else {
-               /* no command line cookie is specified */
-               if ( si->si_syncCookie.octet_str == NULL ) {
-                       BerVarray cookie = NULL;
-                       struct berval cookie_bv;
-                       /* try to read stored cookie */
-                       backend_attribute( op, NULL, &op->o_req_ndn,
-                               slap_schema.si_ad_syncreplCookie, &cookie, ACL_READ );
-                       if ( cookie ) {
-                               ber_dupbv( &cookie_bv, &cookie[0] );
-                               ber_bvarray_add( &si->si_syncCookie.octet_str, &cookie_bv );
-                               slap_parse_sync_cookie( &si->si_syncCookie );
-                               ber_bvarray_free_x( cookie, op->o_tmpmemctx );
-                       }
-               }
+               slap_compose_sync_cookie( NULL, &si->si_syncCookie.octet_str,
+                       &si->si_syncCookie.ctxcsn, si->si_syncCookie.rid );
        }
 
        rc = ldap_sync_search( si, op->o_tmpmemctx );
@@ -501,8 +450,6 @@ done:
                }
        }
 
-       slap_sl_free( op->o_req_ndn.bv_val, op->o_tmpmemctx );
-
        return rc;
 }
 
@@ -527,8 +474,8 @@ do_syncrep2(
 
        int             syncstate;
        struct berval   syncUUID = BER_BVNULL;
-       struct sync_cookie      syncCookie = { NULL, -1, NULL };
-       struct sync_cookie      syncCookie_req = { NULL, -1, NULL };
+       struct sync_cookie      syncCookie = { 0 };
+       struct sync_cookie      syncCookie_req = { 0 };
        struct berval           cookie = BER_BVNULL;
 
        int     rc, err, i;
@@ -581,6 +528,10 @@ do_syncrep2(
                        msg != NULL;
                        msg = ldap_next_message( si->si_ld, msg ) )
                {
+                       if ( slapd_shutdown ) {
+                               rc = -2;
+                               goto done;
+                       }
                        switch( ldap_msgtype( msg ) ) {
                        case LDAP_RES_SEARCH_ENTRY:
                                ldap_get_entry_controls( si->si_ld, msg, &rctrls );
@@ -598,12 +549,10 @@ do_syncrep2(
                                if ( ber_peek_tag( ber, &len ) == LDAP_TAG_SYNC_COOKIE ) {
                                        ber_scanf( ber, /*"{"*/ "m}", &cookie );
                                        if ( !BER_BVISNULL( &cookie ) ) {
-                                               struct berval tmp_bv;
-                                               ber_dupbv( &tmp_bv, &cookie );
-                                               ber_bvarray_add( &syncCookie.octet_str, &tmp_bv );
+                                               ch_free( syncCookie.octet_str.bv_val );
+                                               ber_dupbv( &syncCookie.octet_str, &cookie );
                                        }
-                                       if ( syncCookie.octet_str &&
-                                                       !BER_BVISNULL( &syncCookie.octet_str[0] ) )
+                                       if ( !BER_BVISNULL( &syncCookie.octet_str ) )
                                        {
                                                slap_parse_sync_cookie( &syncCookie );
                                        }
@@ -611,9 +560,8 @@ do_syncrep2(
                                if ( syncrepl_message_to_entry( si, op, msg,
                                        &modlist, &entry, syncstate ) == LDAP_SUCCESS ) {
                                        rc_efree = syncrepl_entry( si, op, entry, &modlist,
-                                               syncstate, &syncUUID, &syncCookie_req, syncCookie.ctxcsn );
-                                       if ( syncCookie.octet_str &&
-                                               !BER_BVISNULL( &syncCookie.octet_str[0] ) )
+                                               syncstate, &syncUUID, &syncCookie_req, &syncCookie.ctxcsn );
+                                       if ( !BER_BVISNULL( &syncCookie.octet_str ) )
                                        {
                                                syncrepl_updateCookie( si, op, psub, &syncCookie );
                                        }
@@ -646,12 +594,10 @@ do_syncrep2(
                                        if ( ber_peek_tag( ber, &len ) == LDAP_TAG_SYNC_COOKIE ) {
                                                ber_scanf( ber, "m", &cookie );
                                                if ( !BER_BVISNULL( &cookie ) ) {
-                                                       struct berval tmp_bv;
-                                                       ber_dupbv( &tmp_bv, &cookie );
-                                                       ber_bvarray_add( &syncCookie.octet_str, &tmp_bv);
+                                                       ch_free( syncCookie.octet_str.bv_val );
+                                                       ber_dupbv( &syncCookie.octet_str, &cookie);
                                                }
-                                               if ( syncCookie.octet_str &&
-                                                       !BER_BVISNULL( &syncCookie.octet_str[0] ) )
+                                               if ( !BER_BVISNULL( &syncCookie.octet_str ) )
                                                {
                                                        slap_parse_sync_cookie( &syncCookie );
                                                }
@@ -662,18 +608,18 @@ do_syncrep2(
                                        }
                                        ber_scanf( ber, /*"{"*/ "}" );
                                }
-                               if ( syncCookie_req.ctxcsn == NULL ) {
+                               if ( BER_BVISNULL( &syncCookie_req.ctxcsn )) {
                                        match = -1;
-                               } else if ( syncCookie.ctxcsn == NULL ) {
+                               } else if ( BER_BVISNULL( &syncCookie.ctxcsn )) {
                                        match = 1;
                                } else {
                                        value_match( &match, slap_schema.si_ad_entryCSN,
                                                slap_schema.si_ad_entryCSN->ad_type->sat_ordering,
                                                SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
-                                               &syncCookie_req.ctxcsn[0], &syncCookie.ctxcsn[0],
+                                               &syncCookie_req.ctxcsn, &syncCookie.ctxcsn,
                                                &text );
                                }
-                               if ( syncCookie.octet_str && !BER_BVISNULL( syncCookie.octet_str ) &&
+                               if ( !BER_BVISNULL( &syncCookie.octet_str ) &&
                                        match < 0 && err == LDAP_SUCCESS )
                                {
                                        syncrepl_updateCookie( si, op, psub, &syncCookie );
@@ -715,11 +661,6 @@ do_syncrep2(
                                                ber_scanf( ber, "tm", &tag, &cookie );
                                                break;
                                        case LDAP_TAG_SYNC_REFRESH_DELETE:
-                                               Debug( LDAP_DEBUG_SYNC,
-                                                       "do_syncrep2: %s - %s%s\n", 
-                                                       "LDAP_RES_INTERMEDIATE", 
-                                                       "REFRESH_DELETE\n", "\n" );
-                                               si->si_refreshDelete = 1;
                                        case LDAP_TAG_SYNC_REFRESH_PRESENT:
                                                Debug( LDAP_DEBUG_SYNC,
                                                        "do_syncrep2: %s - %s%s\n", 
@@ -727,20 +668,20 @@ do_syncrep2(
                                                        si_tag == LDAP_TAG_SYNC_REFRESH_PRESENT ?
                                                        "REFRESH_PRESENT" : "REFRESH_DELETE",
                                                        "\n" );
-                                               si->si_refreshDelete = 1;
-                                               si->si_refreshPresent = 1;
+                                               if ( si_tag == LDAP_TAG_SYNC_REFRESH_DELETE ) {
+                                                       si->si_refreshDelete = 1;
+                                               } else {
+                                                       si->si_refreshPresent = 1;
+                                               }
                                                ber_scanf( ber, "t{" /*"}"*/, &tag );
                                                if ( ber_peek_tag( ber, &len ) == LDAP_TAG_SYNC_COOKIE )
                                                {
                                                        ber_scanf( ber, "m", &cookie );
                                                        if ( !BER_BVISNULL( &cookie ) ) {
-                                                               struct berval tmp_bv;
-                                                               ber_dupbv( &tmp_bv, &cookie );
-                                                               ber_bvarray_add( &syncCookie.octet_str,
-                                                                       &tmp_bv);
+                                                               ch_free( syncCookie.octet_str.bv_val );
+                                                               ber_dupbv( &syncCookie.octet_str, &cookie );
                                                        }
-                                                       if ( syncCookie.octet_str &&
-                                                               !BER_BVISNULL( &syncCookie.octet_str[0] ) )
+                                                       if ( !BER_BVISNULL( &syncCookie.octet_str ) )
                                                        {
                                                                slap_parse_sync_cookie( &syncCookie );
                                                        }
@@ -764,13 +705,10 @@ do_syncrep2(
                                                {
                                                        ber_scanf( ber, "m", &cookie );
                                                        if ( !BER_BVISNULL( &cookie ) ) {
-                                                               struct berval tmp_bv;
-                                                               ber_dupbv( &tmp_bv, &cookie );
-                                                               ber_bvarray_add( &syncCookie.octet_str,
-                                                                       &tmp_bv );
+                                                               ch_free( syncCookie.octet_str.bv_val );
+                                                               ber_dupbv( &syncCookie.octet_str, &cookie );
                                                        }
-                                                       if ( syncCookie.octet_str &&
-                                                                       !BER_BVISNULL( &syncCookie.octet_str[0] ) )
+                                                       if ( !BER_BVISNULL( &syncCookie.octet_str ) )
                                                        {
                                                                slap_parse_sync_cookie( &syncCookie );
                                                        }
@@ -806,19 +744,19 @@ do_syncrep2(
                                                continue;
                                        }
 
-                                       if ( syncCookie_req.ctxcsn == NULL ) {
+                                       if ( BER_BVISNULL( &syncCookie_req.ctxcsn )) {
                                                match = -1;
-                                       } else if ( syncCookie.ctxcsn == NULL ) {
+                                       } else if ( BER_BVISNULL( &syncCookie.ctxcsn )) {
                                                match = 1;
                                        } else {
                                                value_match( &match, slap_schema.si_ad_entryCSN,
                                                        slap_schema.si_ad_entryCSN->ad_type->sat_ordering,
                                                        SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX,
-                                                       &syncCookie_req.ctxcsn[0],
-                                                       &syncCookie.ctxcsn[0], &text );
+                                                       &syncCookie_req.ctxcsn,
+                                                       &syncCookie.ctxcsn, &text );
                                        }
 
-                                       if ( syncCookie.ctxcsn && !BER_BVISNULL( &syncCookie.ctxcsn[0] ) &&
+                                       if ( !BER_BVISNULL( &syncCookie.ctxcsn ) &&
                                                match < 0 )
                                        {
                                                syncrepl_updateCookie( si, op, psub, &syncCookie);
@@ -850,7 +788,7 @@ do_syncrep2(
                                break;
 
                        }
-                       if ( syncCookie.octet_str ) {
+                       if ( !BER_BVISNULL( &syncCookie.octet_str )) {
                                slap_sync_cookie_free( &syncCookie_req, 0 );
                                slap_dup_sync_cookie( &syncCookie_req, &syncCookie );
                                slap_sync_cookie_free( &syncCookie, 0 );
@@ -906,19 +844,25 @@ do_syncrepl(
        if ( si == NULL )
                return NULL;
 
+       ldap_pvt_thread_mutex_lock( &si->si_mutex );
+
        switch( abs( si->si_type )) {
        case LDAP_SYNC_REFRESH_ONLY:
        case LDAP_SYNC_REFRESH_AND_PERSIST:
                break;
        default:
+               ldap_pvt_thread_mutex_unlock( &si->si_mutex );
                return NULL;
        }
 
-       if ( slapd_shutdown && si->si_ld ) {
-               ldap_get_option( si->si_ld, LDAP_OPT_DESC, &s );
-               connection_client_stop( s );
-               ldap_unbind( si->si_ld );
-               si->si_ld = NULL;
+       if ( slapd_shutdown ) {
+               if ( si->si_ld ) {
+                       ldap_get_option( si->si_ld, LDAP_OPT_DESC, &s );
+                       connection_client_stop( s );
+                       ldap_unbind( si->si_ld );
+                       si->si_ld = NULL;
+               }
+               ldap_pvt_thread_mutex_unlock( &si->si_mutex );
                return NULL;
        }
 
@@ -929,10 +873,10 @@ do_syncrepl(
        op->o_tmpmemctx = NULL;
        op->o_tmpmfuncs = &ch_mfuncs;
 
-       op->o_dn = si->si_updatedn;
-       op->o_ndn = si->si_updatedn;
        op->o_managedsait = SLAP_CONTROL_NONCRITICAL;
        op->o_bd = be = si->si_be;
+       op->o_dn = op->o_bd->be_rootdn;
+       op->o_ndn = op->o_bd->be_rootndn;
 
        /* Establish session, do search */
        if ( !si->si_ld ) {
@@ -1002,8 +946,6 @@ do_syncrepl(
 
                if ( !si->si_retrynum || si->si_retrynum[i] == -2 ) {
                        ldap_pvt_runqueue_remove( &slapd_rq, rtask );
-                       LDAP_STAILQ_REMOVE( &be->be_syncinfo, si, syncinfo_s, si_next );
-                       syncinfo_free( si );
                } else if ( si->si_retrynum[i] >= -1 ) {
                        if ( si->si_retrynum[i] > 0 )
                                si->si_retrynum[i]--;
@@ -1014,6 +956,7 @@ do_syncrepl(
        }
        
        ldap_pvt_thread_mutex_unlock( &slapd_rq.rq_mutex );
+       ldap_pvt_thread_mutex_unlock( &si->si_mutex );
 
        return NULL;
 }
@@ -1107,7 +1050,7 @@ syncrepl_message_to_entry(
                goto done;
        }
 
-       rc = slap_mods_check( *modlist, 1, &text, txtbuf, textlen, NULL );
+       rc = slap_mods_check( *modlist, &text, txtbuf, textlen, NULL );
 
        if ( rc != LDAP_SUCCESS ) {
                Debug( LDAP_DEBUG_ANY, "syncrepl_message_to_entry: mods check (%s)\n",
@@ -1158,6 +1101,8 @@ done:
        return rc;
 }
 
+static struct berval generic_filterstr = BER_BVC("(objectclass=*)");
+
 /* During a refresh, we may get an LDAP_SYNC_ADD for an already existing
  * entry if a previous refresh was interrupted before sending us a new
  * context state. We try to compare the new entry to the existing entry
@@ -1208,16 +1153,11 @@ syncrepl_entry(
        SlapReply       rs_add = {REP_RESULT};
        SlapReply       rs_modify = {REP_RESULT};
        Filter f = {0};
-       AttributeAssertion ava = {0};
+       AttributeAssertion ava = { NULL, BER_BVNULL, NULL };
        int rc = LDAP_SUCCESS;
        int ret = LDAP_SUCCESS;
 
        struct berval pdn = BER_BVNULL;
-       struct berval org_req_dn = BER_BVNULL;
-       struct berval org_req_ndn = BER_BVNULL;
-       struct berval org_dn = BER_BVNULL;
-       struct berval org_ndn = BER_BVNULL;
-       int     org_managedsait;
        dninfo dni = {0};
        int     retry = 1;
 
@@ -1271,12 +1211,13 @@ syncrepl_entry(
        ava.aa_value = *syncUUID;
        op->ors_filter = &f;
 
-       op->ors_filterstr.bv_len = STRLENOF( "entryUUID=" ) + syncUUID->bv_len;
+       op->ors_filterstr.bv_len = STRLENOF( "(entryUUID=)" ) + syncUUID->bv_len;
        op->ors_filterstr.bv_val = (char *) slap_sl_malloc(
                op->ors_filterstr.bv_len + 1, op->o_tmpmemctx ); 
-       AC_MEMCPY( op->ors_filterstr.bv_val, "entryUUID=", STRLENOF( "entryUUID=" ) );
-       AC_MEMCPY( &op->ors_filterstr.bv_val[STRLENOF( "entryUUID=" )],
+       AC_MEMCPY( op->ors_filterstr.bv_val, "(entryUUID=", STRLENOF( "(entryUUID=" ) );
+       AC_MEMCPY( &op->ors_filterstr.bv_val[STRLENOF( "(entryUUID=" )],
                syncUUID->bv_val, syncUUID->bv_len );
+       op->ors_filterstr.bv_val[op->ors_filterstr.bv_len - 1] = ')';
        op->ors_filterstr.bv_val[op->ors_filterstr.bv_len] = '\0';
 
        op->o_tag = LDAP_REQ_SEARCH;
@@ -1313,7 +1254,7 @@ syncrepl_entry(
        cb.sc_response = null_callback;
        cb.sc_private = si;
 
-       if ( entry && entry->e_name.bv_val ) {
+       if ( entry && !BER_BVISNULL( &entry->e_name ) ) {
                Debug( LDAP_DEBUG_SYNC,
                                "syncrepl_entry: %s\n",
                                entry->e_name.bv_val, 0, 0 );
@@ -1323,19 +1264,23 @@ syncrepl_entry(
                                dni.dn.bv_val ? dni.dn.bv_val : "(null)", 0, 0 );
        }
 
-       org_req_dn = op->o_req_dn;
-       org_req_ndn = op->o_req_ndn;
-       org_dn = op->o_dn;
-       org_ndn = op->o_ndn;
-       org_managedsait = get_manageDSAit( op );
-       op->o_dn = op->o_bd->be_rootdn;
-       op->o_ndn = op->o_bd->be_rootndn;
-       op->o_managedsait = SLAP_CONTROL_NONCRITICAL;
-
        if ( syncstate != LDAP_SYNC_DELETE ) {
-               attr_delete( &entry->e_attrs, slap_schema.si_ad_entryUUID );
-               attr_merge_one( entry, slap_schema.si_ad_entryUUID,
-                       &syncUUID_strrep, syncUUID );
+               Attribute       *a = attr_find( entry->e_attrs, slap_schema.si_ad_entryUUID );
+
+               if ( a == NULL ) {
+                       /* add if missing */
+                       attr_merge_one( entry, slap_schema.si_ad_entryUUID,
+                               &syncUUID_strrep, syncUUID );
+
+               } else if ( !bvmatch( &a->a_nvals[0], syncUUID ) ) {
+                       /* replace only if necessary */
+                       if ( a->a_nvals != a->a_vals ) {
+                               ber_memfree( a->a_nvals[0].bv_val );
+                               ber_dupbv( &a->a_nvals[0], syncUUID );
+                       }
+                       ber_memfree( a->a_vals[0].bv_val );
+                       ber_dupbv( &a->a_vals[0], &syncUUID_strrep );
+               }
        }
 
        switch ( syncstate ) {
@@ -1370,7 +1315,10 @@ retry_add:;
                        /* if an entry was added via syncrepl_add_glue(),
                         * it likely has no entryUUID, so the previous
                         * be_search() doesn't find it.  In this case,
-                        * give syncrepl a chance to modify it. */
+                        * give syncrepl a chance to modify it. Also
+                        * allow for entries that were recreated with the
+                        * same DN but a different entryUUID.
+                        */
                        case LDAP_ALREADY_EXISTS:
                                if ( retry ) {
                                        Operation       op2 = *op;
@@ -1378,12 +1326,8 @@ retry_add:;
                                        slap_callback   cb2 = { 0 };
 
                                        op2.o_tag = LDAP_REQ_SEARCH;
-                                       ber_dupbv_x( &op2.o_req_dn,
-                                               &entry->e_name,
-                                               op2.o_tmpmemctx );
-                                       ber_dupbv_x( &op2.o_req_ndn,
-                                               &entry->e_nname,
-                                               op2.o_tmpmemctx );
+                                       op2.o_req_dn = entry->e_name;
+                                       op2.o_req_ndn = entry->e_nname;
                                        op2.ors_scope = LDAP_SCOPE_BASE;
                                        op2.ors_attrs = slap_anlist_all_attributes;
                                        op2.ors_attrsonly = 0;
@@ -1391,15 +1335,10 @@ retry_add:;
                                        op2.ors_slimit = 1;
                                        op2.ors_tlimit = SLAP_NO_LIMIT;
 
-                                       f.f_choice = LDAP_FILTER_EQUALITY;
-                                       f.f_ava = &ava;
-                                       ava.aa_desc = slap_schema.si_ad_objectClass;
-                                       ber_dupbv_x( &ava.aa_value,
-                                               &slap_schema.si_oc_glue->soc_cname,
-                                               op2.o_tmpmemctx );
+                                       f.f_choice = LDAP_FILTER_PRESENT;
+                                       f.f_desc = slap_schema.si_ad_objectClass;
                                        op2.ors_filter = &f;
-                                       filter2bv_x( &op2, op2.ors_filter,
-                                                       &op2.ors_filterstr );
+                                       op2.ors_filterstr = generic_filterstr;
 
                                        op2.o_callback = &cb2;
                                        cb2.sc_response = dn_callback;
@@ -1407,15 +1346,6 @@ retry_add:;
 
                                        be->be_search( &op2, &rs2 );
 
-                                       op2.o_tmpfree( op2.o_req_dn.bv_val,
-                                               op2.o_tmpmemctx );
-                                       op2.o_tmpfree( op2.o_req_ndn.bv_val,
-                                               op2.o_tmpmemctx );
-                                       op2.o_tmpfree( ava.aa_value.bv_val,
-                                               op2.o_tmpmemctx );
-                                       op2.o_tmpfree( op2.ors_filterstr.bv_val,
-                                               op2.o_tmpmemctx );
-
                                        retry = 0;
                                        goto retry_add;
                                }
@@ -1470,11 +1400,11 @@ retry_add:;
                        assert( *modlist );
 
                        /* Delete all the old attrs */
-                       for ( i=0; i<dni.attrs; i++) {
-                               mod = ch_malloc( sizeof(Modifications));
+                       for ( i = 0; i < dni.attrs; i++ ) {
+                               mod = ch_malloc( sizeof( Modifications ) );
                                mod->sml_op = LDAP_MOD_DELETE;
                                mod->sml_desc = dni.ads[i];
-                               mod->sml_type =mod->sml_desc->ad_cname;
+                               mod->sml_type = mod->sml_desc->ad_cname;
                                mod->sml_values = NULL;
                                mod->sml_nvalues = NULL;
                                if ( !modhead ) modhead = mod;
@@ -1596,19 +1526,11 @@ syncrepl_del_nonpresent(
        SlapReply       rs_modify = {REP_RESULT};
        struct nonpresent_entry *np_list, *np_prev;
        int rc;
-       Modifications *ml;
-       Modifications *mlnext;
-       Modifications *mod;
-       Modifications *modlist = NULL;
-       Modifications **modtail;
        AttributeName   an[2];
 
        struct berval pdn = BER_BVNULL;
        struct berval org_req_dn = BER_BVNULL;
        struct berval org_req_ndn = BER_BVNULL;
-       struct berval org_dn = BER_BVNULL;
-       struct berval org_ndn = BER_BVNULL;
-       int     org_managedsait;
 
        op->o_req_dn = si->si_base;
        op->o_req_ndn = si->si_base;
@@ -1626,14 +1548,13 @@ syncrepl_del_nonpresent(
 
        if ( uuids ) {
                Filter uf;
-               AttributeAssertion eq;
+               AttributeAssertion eq = { NULL, BER_BVNULL, NULL };
                int i;
 
                op->ors_attrsonly = 1;
                op->ors_attrs = slap_anlist_no_attrs;
                op->ors_limit = NULL;
                op->ors_filter = &uf;
-               op->o_managedsait = SLAP_CONTROL_NONCRITICAL;
 
                uf.f_ava = &eq;
                uf.f_av_desc = slap_schema.si_ad_entryUUID;
@@ -1657,7 +1578,6 @@ syncrepl_del_nonpresent(
                op->ors_filter = str2filter_x( op, si->si_filterstr.bv_val );
                op->ors_filterstr = si->si_filterstr;
                op->o_nocaching = 1;
-               op->o_managedsait = SLAP_CONTROL_NONE;
 
                if ( limits_check( op, &rs_search ) == 0 ) {
                        rc = be->be_search( op, &rs_search );
@@ -1665,10 +1585,12 @@ syncrepl_del_nonpresent(
                if ( op->ors_filter ) filter_free_x( op, op->ors_filter );
        }
 
-       op->o_managedsait = SLAP_CONTROL_NONCRITICAL;
        op->o_nocaching = 0;
 
        if ( !LDAP_LIST_EMPTY( &si->si_nonpresentlist ) ) {
+
+               slap_queue_csn( op, &si->si_syncCookie.ctxcsn );
+
                np_list = LDAP_LIST_FIRST( &si->si_nonpresentlist );
                while ( np_list != NULL ) {
                        LDAP_LIST_REMOVE( np_list, npe_link );
@@ -1683,43 +1605,27 @@ syncrepl_del_nonpresent(
                        rc = op->o_bd->be_delete( op, &rs_delete );
 
                        if ( rs_delete.sr_err == LDAP_NOT_ALLOWED_ON_NONLEAF ) {
-                               modtail = &modlist;
-                               mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
-                               mod->sml_op = LDAP_MOD_REPLACE;
-                               mod->sml_desc = slap_schema.si_ad_objectClass;
-                               mod->sml_type = mod->sml_desc->ad_cname;
-                               mod->sml_values = &gcbva[0];
-                               *modtail = mod;
-                               modtail = &mod->sml_next;
-
-                               mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
-                               mod->sml_op = LDAP_MOD_REPLACE;
-                               mod->sml_desc = slap_schema.si_ad_structuralObjectClass;
-                               mod->sml_type = mod->sml_desc->ad_cname;
-                               mod->sml_values = &gcbva[1];
-                               *modtail = mod;
-                               modtail = &mod->sml_next;
+                               Modifications mod1, mod2;
+                               mod1.sml_op = LDAP_MOD_REPLACE;
+                               mod1.sml_desc = slap_schema.si_ad_objectClass;
+                               mod1.sml_type = mod1.sml_desc->ad_cname;
+                               mod1.sml_values = &gcbva[0];
+                               mod1.sml_nvalues = NULL;
+                               mod1.sml_next = &mod2;
+
+                               mod2.sml_op = LDAP_MOD_REPLACE;
+                               mod2.sml_desc = slap_schema.si_ad_structuralObjectClass;
+                               mod2.sml_type = mod2.sml_desc->ad_cname;
+                               mod2.sml_values = &gcbva[1];
+                               mod2.sml_nvalues = NULL;
+                               mod2.sml_next = NULL;
 
                                op->o_tag = LDAP_REQ_MODIFY;
-                               op->orm_modlist = modlist;
+                               op->orm_modlist = &mod1;
 
                                rc = be->be_modify( op, &rs_modify );
-
-                               for ( ml = modlist; ml != NULL; ml = mlnext ) {
-                                       mlnext = ml->sml_next;
-                                       free( ml );
-                               }
                        }
 
-                       org_req_dn = op->o_req_dn;
-                       org_req_ndn = op->o_req_ndn;
-                       org_dn = op->o_dn;
-                       org_ndn = op->o_ndn;
-                       org_managedsait = get_manageDSAit( op );
-                       op->o_dn = op->o_bd->be_rootdn;
-                       op->o_ndn = op->o_bd->be_rootndn;
-                       op->o_managedsait = SLAP_CONTROL_NONCRITICAL;
-
                        while ( rs_delete.sr_err == LDAP_SUCCESS &&
                                        op->o_delete_glue_parent ) {
                                op->o_delete_glue_parent = 0;
@@ -1737,19 +1643,14 @@ syncrepl_del_nonpresent(
                            }
                        }
 
-                       op->o_managedsait = org_managedsait;
-                       op->o_dn = org_dn;
-                       op->o_ndn = org_ndn;
-                       op->o_req_dn = org_req_dn;
-                       op->o_req_ndn = org_req_ndn;
                        op->o_delete_glue_parent = 0;
 
                        ber_bvfree( np_prev->npe_name );
                        ber_bvfree( np_prev->npe_nname );
-                       BER_BVZERO( &op->o_req_dn );
-                       BER_BVZERO( &op->o_req_ndn );
                        ch_free( np_prev );
                }
+
+               slap_graduate_commit_csn( op );
        }
 
        return;
@@ -1883,28 +1784,6 @@ syncrepl_add_glue(
        return;
 }
 
-static struct berval ocbva[] = {
-       BER_BVC("top"),
-       BER_BVC("subentry"),
-       BER_BVC("syncConsumerSubentry"),
-       BER_BVNULL
-};
-
-static struct berval cnbva[] = {
-       BER_BVNULL,
-       BER_BVNULL
-};
-
-static struct berval ssbva[] = {
-       BER_BVC("{}"),
-       BER_BVNULL
-};
-
-static struct berval scbva[] = {
-       BER_BVNULL,
-       BER_BVNULL
-};
-
 void
 syncrepl_updateCookie(
        syncinfo_t *si,
@@ -1913,210 +1792,59 @@ syncrepl_updateCookie(
        struct sync_cookie *syncCookie )
 {
        Backend *be = op->o_bd;
-       Modifications *ml;
-       Modifications *mlnext;
-       Modifications *mod;
-       Modifications *modlist = NULL;
-       Modifications **modtail = &modlist;
+       Modifications mod = {0};
+       struct berval vals[2];
 
        const char      *text;
        char txtbuf[SLAP_TEXT_BUFLEN];
        size_t textlen = sizeof txtbuf;
 
-       Entry* e = NULL;
        int rc;
 
-       char syncrepl_cbuf[sizeof(CN_STR SYNCREPL_STR)];
-       struct berval slap_syncrepl_dn_bv = BER_BVNULL;
-       struct berval slap_syncrepl_cn_bv = BER_BVNULL;
-       
        slap_callback cb = { NULL };
-       SlapReply       rs_add = {REP_RESULT};
        SlapReply       rs_modify = {REP_RESULT};
 
        slap_sync_cookie_free( &si->si_syncCookie, 0 );
        slap_dup_sync_cookie( &si->si_syncCookie, syncCookie );
 
-       mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
-       mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_objectClass;
-       mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_values = ocbva;
-       *modtail = mod;
-       modtail = &mod->sml_next;
-
-       ber_dupbv( &cnbva[0], (struct berval *) &slap_syncrepl_bvc );
-       assert( si->si_rid < 1000 );
-       cnbva[0].bv_len = snprintf( cnbva[0].bv_val,
-               slap_syncrepl_bvc.bv_len + 1,
-               "syncrepl%ld", si->si_rid );
-       mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
-       mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_cn;
-       mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_values = cnbva;
-       *modtail = mod;
-       modtail = &mod->sml_next;
-
-       mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
-       mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_subtreeSpecification;
-       mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_values = ssbva;
-       *modtail = mod;
-       modtail = &mod->sml_next;
-
-       /* Keep this last, so we can avoid touching the previous
-        * attributes unnecessarily.
-        */
-       if ( scbva[0].bv_val ) ch_free( scbva[0].bv_val );
-       ber_dupbv( &scbva[0], &si->si_syncCookie.octet_str[0] );
-       mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
-       mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_syncreplCookie;
-       mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_values = scbva;
-       *modtail = mod;
-       modtail = &mod->sml_next;
-
-       slap_queue_csn( op, si->si_syncCookie.ctxcsn );
+       mod.sml_op = LDAP_MOD_REPLACE;
+       mod.sml_desc = slap_schema.si_ad_contextCSN;
+       mod.sml_type = mod.sml_desc->ad_cname;
+       mod.sml_values = vals;
+       vals[0] = si->si_syncCookie.ctxcsn;
+       vals[1].bv_val = NULL;
+       vals[1].bv_len = 0;
 
-       mlnext = mod;
+       slap_queue_csn( op, &si->si_syncCookie.ctxcsn );
 
-       op->o_tag = LDAP_REQ_ADD;
-       rc = slap_mods_opattrs( op, modlist, modtail,
-                &text, txtbuf, textlen, 0 );
-
-       for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
-               ml->sml_op = LDAP_MOD_REPLACE;
-       }
-
-       if( rc != LDAP_SUCCESS ) {
-               Debug( LDAP_DEBUG_ANY, "syncrepl_updateCookie: mods opattrs (%s)\n",
-                        text, 0, 0 );
-       }
-
-       e = ( Entry * ) ch_calloc( 1, sizeof( Entry ));
+       op->o_tag = LDAP_REQ_MODIFY;
 
-       slap_syncrepl_cn_bv.bv_val = syncrepl_cbuf;
        assert( si->si_rid < 1000 );
-       slap_syncrepl_cn_bv.bv_len = snprintf( slap_syncrepl_cn_bv.bv_val,
-               slap_syncrepl_cn_bvc.bv_len + 1,
-               "cn=syncrepl%ld", si->si_rid );
-
-       build_new_dn( &slap_syncrepl_dn_bv, pdn, &slap_syncrepl_cn_bv,
-               op->o_tmpmemctx );
-       ber_dupbv( &e->e_name, &slap_syncrepl_dn_bv );
-       ber_dupbv( &e->e_nname, &slap_syncrepl_dn_bv );
-
-       if ( !BER_BVISNULL( &slap_syncrepl_dn_bv ) ) {
-               slap_sl_free( slap_syncrepl_dn_bv.bv_val, op->o_tmpmemctx );
-       }
-
-       e->e_attrs = NULL;
-
-       rc = slap_mods2entry( modlist, &e, 1, 1, &text, txtbuf, textlen );
-
-       if( rc != LDAP_SUCCESS ) {
-               Debug( LDAP_DEBUG_ANY, "syncrepl_updateCookie: mods2entry (%s)\n",
-                        text, 0, 0 );
-       }
 
        cb.sc_response = null_callback;
        cb.sc_private = si;
 
        op->o_callback = &cb;
-       op->o_req_dn = e->e_name;
-       op->o_req_ndn = e->e_nname;
+       op->o_req_dn = op->o_bd->be_suffix[0];
+       op->o_req_ndn = op->o_bd->be_nsuffix[0];
 
-       /* update persistent cookie */
-update_cookie_retry:
-       op->o_tag = LDAP_REQ_MODIFY;
-       /* Just modify the cookie value, not the entire entry */
-       op->orm_modlist = mod;
+       /* update contextCSN */
+       op->o_msgid = SLAP_SYNC_UPDATE_MSGID;
+       op->orm_modlist = &mod;
        rc = be->be_modify( op, &rs_modify );
+       op->o_msgid = 0;
 
        if ( rs_modify.sr_err != LDAP_SUCCESS ) {
-               if ( rs_modify.sr_err == LDAP_REFERRAL ||
-                        rs_modify.sr_err == LDAP_NO_SUCH_OBJECT ) {
-                       op->o_tag = LDAP_REQ_ADD;
-                       op->ora_e = e;
-                       rc = be->be_add( op, &rs_add );
-                       if ( rs_add.sr_err != LDAP_SUCCESS ) {
-                               if ( rs_add.sr_err == LDAP_ALREADY_EXISTS ) {
-                                       goto update_cookie_retry;
-                               } else if ( rs_add.sr_err == LDAP_REFERRAL ||
-                                                       rs_add.sr_err == LDAP_NO_SUCH_OBJECT ) {
-                                       Debug( LDAP_DEBUG_ANY,
-                                               "cookie will be non-persistent\n",
-                                               0, 0, 0 );
-                               } else {
-                                       Debug( LDAP_DEBUG_ANY,
-                                               "be_add failed (%d)\n", rs_add.sr_err, 0, 0 );
-                               }
-                       } else {
-                               be_entry_release_w( op, e );
-                               goto done;
-                       }
-               } else {
-                       Debug( LDAP_DEBUG_ANY,
-                               "be_modify failed (%d)\n", rs_modify.sr_err, 0, 0 );
-               }
-       }
-       if ( e != NULL ) {
-               entry_free( e );
+               Debug( LDAP_DEBUG_ANY,
+                       "be_modify failed (%d)\n", rs_modify.sr_err, 0, 0 );
        }
 
 done :
        slap_graduate_commit_csn( op );
 
-
-       if ( !BER_BVISNULL( &cnbva[0] ) ) {
-               ch_free( cnbva[0].bv_val );
-               BER_BVZERO( &cnbva[0] );
-       }
-       if ( !BER_BVISNULL( &scbva[0] ) ) {
-               ch_free( scbva[0].bv_val );
-               BER_BVZERO( &scbva[0] );
-       }
-
-       if ( mlnext->sml_next ) {
-               slap_mods_free( mlnext->sml_next );
-               mlnext->sml_next = NULL;
-       }
-
-       for (ml = modlist ; ml != NULL; ml = mlnext ) {
-               mlnext = ml->sml_next;
-               free( ml );
-       }
-
        return;
 }
 
-int
-syncrepl_isupdate( Operation *op )
-{
-       return ( syncrepl_isupdate_dn( op->o_bd, &op->o_ndn ));
-}
-
-int
-syncrepl_isupdate_dn(
-       Backend*                be,
-       struct berval*  ndn )
-{
-       syncinfo_t*     si;
-       int                     ret = 0;
-
-       if ( !LDAP_STAILQ_EMPTY( &be->be_syncinfo )) {
-               LDAP_STAILQ_FOREACH( si, &be->be_syncinfo, si_next ) {
-                       if ( ( ret = dn_match( &si->si_updatedn, ndn ) ) ) {
-                               return ret;
-                       }
-               }
-       }
-       return 0;
-}
-
 static int
 dn_callback(
        Operation*      op,
@@ -2275,40 +2003,6 @@ null_callback(
        return LDAP_SUCCESS;
 }
 
-Entry *
-slap_create_syncrepl_entry(
-       Backend *be,
-       struct berval *context_csn,
-       struct berval *rdn,
-       struct berval *cn )
-{
-       Entry* e;
-
-       struct berval bv;
-
-       e = ( Entry * ) ch_calloc( 1, sizeof( Entry ));
-
-       attr_merge( e, slap_schema.si_ad_objectClass, ocbva, NULL );
-
-       attr_merge_one( e, slap_schema.si_ad_structuralObjectClass,
-               &ocbva[1], NULL );
-
-       attr_merge_one( e, slap_schema.si_ad_cn, cn, NULL );
-
-       if ( context_csn ) {
-               attr_merge_one( e, slap_schema.si_ad_syncreplCookie,
-                       context_csn, NULL );
-       }
-
-       BER_BVSTR( &bv, "{}" );
-       attr_merge_one( e, slap_schema.si_ad_subtreeSpecification, &bv, NULL );
-
-       build_new_dn( &e->e_name, &be->be_nsuffix[0], rdn, NULL );
-       ber_dupbv( &e->e_nname, &e->e_name );
-
-       return e;
-}
-
 struct berval *
 slap_uuidstr_from_normalized(
        struct berval* uuidstr,
@@ -2390,36 +2084,13 @@ avl_ber_bvfree( void *v_bv )
 void
 syncinfo_free( syncinfo_t *sie )
 {
-       if ( sie->si_provideruri ) {
-               ch_free( sie->si_provideruri );
-       }
-       if ( sie->si_provideruri_bv ) {
-               ber_bvarray_free( sie->si_provideruri_bv );
-       }
-       if ( sie->si_updatedn.bv_val ) {
-               ch_free( sie->si_updatedn.bv_val );
-       }
-       if ( sie->si_binddn ) {
-               ch_free( sie->si_binddn );
-       }
-       if ( sie->si_passwd ) {
-               ch_free( sie->si_passwd );
-       }
-       if ( sie->si_saslmech ) {
-               ch_free( sie->si_saslmech );
-       }
-       if ( sie->si_secprops ) {
-               ch_free( sie->si_secprops );
-       }
-       if ( sie->si_realm ) {
-               ch_free( sie->si_realm );
-       }
-       if ( sie->si_authcId ) {
-               ch_free( sie->si_authcId );
-       }
-       if ( sie->si_authzId ) {
-               ch_free( sie->si_authzId );
+       ldap_pvt_thread_mutex_destroy( &sie->si_mutex );
+       if ( !BER_BVISNULL( &sie->si_provideruri ) ) {
+               ch_free( sie->si_provideruri.bv_val );
        }
+
+       bindconf_free( &sie->si_bindconf );
+
        if ( sie->si_filterstr.bv_val ) {
                ch_free( sie->si_filterstr.bv_val );
        }