]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/syncrepl.c
Plug leaks
[openldap] / servers / slapd / syncrepl.c
index cb14169c8feb98950aafbb053fea0e118a9cd0aa..c297650da2b359b674029c58b8360ad131f86c93 100644 (file)
@@ -453,47 +453,15 @@ do_syncrep1(
        op->o_ssf = ( op->o_sasl_ssf > op->o_tls_ssf )
                ?  op->o_sasl_ssf : op->o_tls_ssf;
 
-
+       /* We've just started up, or the remote server hasn't sent us
+        * any meaningful state.
+        */
        if ( BER_BVISNULL( &si->si_syncCookie.octet_str ) ) {
                int i;
 
-               ldap_pvt_thread_mutex_lock( &si->si_cookieState->cs_mutex );
-               if ( !si->si_cookieState->cs_num ) {
-                       /* get contextCSN shadow replica from database */
-                       BerVarray csn = NULL;
-                       void *ctx = op->o_tmpmemctx;
-
-                       op->o_req_ndn = op->o_bd->be_nsuffix[0];
-                       op->o_req_dn = op->o_req_ndn;
-
-                       /* try to read stored contextCSN */
-                       op->o_tmpmemctx = NULL;
-                       backend_attribute( op, NULL, &op->o_req_ndn,
-                               slap_schema.si_ad_contextCSN, &csn, ACL_READ );
-                       op->o_tmpmemctx = ctx;
-                       if ( csn ) {
-                               si->si_cookieState->cs_vals = csn;
-                               for (i=0; !BER_BVISNULL( &csn[i] ); i++);
-                               si->si_cookieState->cs_num = i;
-                               si->si_cookieState->cs_sids = slap_parse_csn_sids( csn, i );
-                       }
-               }
-               if ( si->si_cookieState->cs_num ) {
-                       ber_bvarray_free( si->si_syncCookie.ctxcsn );
-                       if ( ber_bvarray_dup_x( &si->si_syncCookie.ctxcsn,
-                               si->si_cookieState->cs_vals, NULL )) {
-                               rc = LDAP_NO_MEMORY;
-                               goto done;
-                       }
-                       si->si_syncCookie.numcsns = si->si_cookieState->cs_num;
-                       si->si_syncCookie.sids = ch_malloc( si->si_cookieState->cs_num *
-                               sizeof(int) );
-                       for ( i=0; i<si->si_syncCookie.numcsns; i++ )
-                               si->si_syncCookie.sids[i] = si->si_cookieState->cs_sids[i];
-               }
-               ldap_pvt_thread_mutex_unlock( &si->si_cookieState->cs_mutex );
-
                si->si_syncCookie.rid = si->si_rid;
+               si->si_syncCookie.sid = SLAP_SINGLE_SHADOW( si->si_be ) ? -1 :
+                       slap_serverID;
 
                LDAP_STAILQ_FOREACH( sc, &slap_sync_cookie, sc_next ) {
                        if ( si->si_rid == sc->rid ) {
@@ -509,25 +477,109 @@ do_syncrep1(
 
                        /* ctxcsn wasn't parsed yet, do it now */
                        slap_parse_sync_cookie( sc, op->o_tmpmemctx );
-                       if ( !sc->ctxcsn ) {
-                               /* if cmdline cookie does not have ctxcsn */
-                               /* component, set it to an initial value */
-                               slap_init_sync_cookie_ctxcsn( sc );
-                       }
                        slap_sync_cookie_free( &si->si_syncCookie, 0 );
                        slap_dup_sync_cookie( &si->si_syncCookie, sc );
                        slap_sync_cookie_free( sc, 1 );
+               } else {
+                       ldap_pvt_thread_mutex_lock( &si->si_cookieState->cs_mutex );
+                       if ( !si->si_cookieState->cs_num ) {
+                               /* get contextCSN shadow replica from database */
+                               BerVarray csn = NULL;
+                               void *ctx = op->o_tmpmemctx;
+
+                               op->o_req_ndn = op->o_bd->be_nsuffix[0];
+                               op->o_req_dn = op->o_req_ndn;
+
+                               /* try to read stored contextCSN */
+                               op->o_tmpmemctx = NULL;
+                               backend_attribute( op, NULL, &op->o_req_ndn,
+                                       slap_schema.si_ad_contextCSN, &csn, ACL_READ );
+                               op->o_tmpmemctx = ctx;
+                               if ( csn ) {
+                                       si->si_cookieState->cs_vals = csn;
+                                       for (i=0; !BER_BVISNULL( &csn[i] ); i++);
+                                       si->si_cookieState->cs_num = i;
+                                       si->si_cookieState->cs_sids = slap_parse_csn_sids( csn, i, NULL );
+                               }
+                       }
+                       if ( si->si_cookieState->cs_num ) {
+                               ber_bvarray_free( si->si_syncCookie.ctxcsn );
+                               if ( ber_bvarray_dup_x( &si->si_syncCookie.ctxcsn,
+                                       si->si_cookieState->cs_vals, NULL )) {
+                                       rc = LDAP_NO_MEMORY;
+                                       goto done;
+                               }
+                               si->si_syncCookie.numcsns = si->si_cookieState->cs_num;
+                               si->si_syncCookie.sids = ch_malloc( si->si_cookieState->cs_num *
+                                       sizeof(int) );
+                               for ( i=0; i<si->si_syncCookie.numcsns; i++ )
+                                       si->si_syncCookie.sids[i] = si->si_cookieState->cs_sids[i];
+                       }
+                       ldap_pvt_thread_mutex_unlock( &si->si_cookieState->cs_mutex );
                }
 
                slap_compose_sync_cookie( NULL, &si->si_syncCookie.octet_str,
                        si->si_syncCookie.ctxcsn, si->si_syncCookie.rid,
-                       SLAP_SINGLE_SHADOW( si->si_be ) ? -1 : slap_serverID );
+                       si->si_syncCookie.sid );
        } else {
+               AttributeName at[2];
+               Attribute a = { slap_schema.si_ad_contextCSN };
+               Entry e = {0};
+               SlapReply rs = {0};
+               int i, j, changed = 0;
+
+               /* Look for contextCSN from syncprov overlay. If
+                * there's no overlay, this will be a no-op. That means
+                * this is a pure consumer, so local changes will not be
+                * allowed, and all changes will already be reflected in
+                * the cookieState.
+                */
+               e.e_attrs = &a;
+               e.e_name = si->si_wbe->be_suffix[0];
+               e.e_nname = si->si_wbe->be_nsuffix[0];
+               rs.sr_entry = &e;
+               rs.sr_flags = REP_ENTRY_MODIFIABLE;
+               at[0].an_name = a.a_desc->ad_cname;
+               at[0].an_desc = a.a_desc;
+               BER_BVZERO( &at[1].an_name );
+
                ldap_pvt_thread_mutex_lock( &si->si_cookieState->cs_mutex );
-               /* match SIDs */
+               rc = backend_operational( op, &rs );
+               if ( rc == LDAP_SUCCESS && a.a_vals ) {
+                       int num;
+                       for (i=0; !BER_BVISNULL( &a.a_vals[i] ); i++) ;
+                       num = i;
+                       /* check for differences */
+                       if ( num != si->si_cookieState->cs_num ) {
+                               changed = 1;
+                       } else {
+                               for ( i=0; i<num; i++ ) {
+                                       if ( ber_bvcmp( &a.a_vals[i],
+                                               &si->si_cookieState->cs_vals[i] )) {
+                                               changed =1;
+                                               break;
+                                       }
+                               }
+                       }
+                       if ( changed ) {
+                               ber_bvarray_free( si->si_cookieState->cs_vals );
+                               ch_free( si->si_cookieState->cs_sids );
+                               si->si_cookieState->cs_num = num;
+                               si->si_cookieState->cs_vals = a.a_vals;
+                               si->si_cookieState->cs_sids = slap_parse_csn_sids( a.a_vals,
+                                       num, NULL );
+                               si->si_cookieState->cs_age++;
+                       } else {
+                               ber_bvarray_free( a.a_vals );
+                       }
+                       changed = 0;
+               }
+               /* See if the cookieState has changed due to anything outside
+                * this particular consumer. That includes other consumers in
+                * the same context, or local changes detected above.
+                */
                if ( si->si_cookieState->cs_num > 1 && si->si_cookieAge !=
                        si->si_cookieState->cs_age ) {
-                       int i, j, changed = 0;
 
                        for (i=0; !BER_BVISNULL( &si->si_syncCookie.ctxcsn[i] ); i++) {
                                /* bogus, just dup everything */
@@ -542,6 +594,9 @@ do_syncrep1(
                                        if ( si->si_syncCookie.sids[i] !=
                                                si->si_cookieState->cs_sids[j] )
                                                continue;
+                                       if ( bvmatch( &si->si_syncCookie.ctxcsn[i],
+                                               &si->si_cookieState->cs_vals[j] ))
+                                               break;
                                        ber_bvreplace( &si->si_syncCookie.ctxcsn[i],
                                                &si->si_cookieState->cs_vals[j] );
                                        changed = 1;
@@ -797,11 +852,11 @@ do_syncrep2(
                                        }
                                        ber_scanf( ber, /*"{"*/ "}" );
                                }
-                               if ( !syncCookie_req.ctxcsn ) {
+                               if ( !syncCookie.ctxcsn ) {
+                                       match = 1;
+                               } else if ( !syncCookie_req.ctxcsn ) {
                                        match = -1;
                                        m = 0;
-                               } else if ( !syncCookie.ctxcsn ) {
-                                       match = 1;
                                } else {
                                        match = compare_csns( &syncCookie_req, &syncCookie, &m );
                                }
@@ -944,11 +999,11 @@ do_syncrep2(
                                                continue;
                                        }
 
-                                       if ( !syncCookie_req.ctxcsn ) {
+                                       if ( !syncCookie.ctxcsn ) {
+                                               match = 1;
+                                       } else if ( !syncCookie_req.ctxcsn ) {
                                                match = -1;
                                                m = 0;
-                                       } else if ( !syncCookie.ctxcsn ) {
-                                               match = 1;
                                        } else {
                                                match = compare_csns( &syncCookie_req, &syncCookie, &m );
                                        }
@@ -1196,10 +1251,11 @@ reload:
                cs = be->be_syncinfo->si_cookieState;
                for ( sip = &be->be_syncinfo; *sip != si; sip = &(*sip)->si_next );
                *sip = si->si_next;
-               syncinfo_free( si );
+               syncinfo_free( si, 0 );
                if ( !be->be_syncinfo ) {
                        SLAP_DBFLAGS( be ) &= ~(SLAP_DBFLAG_SHADOW|SLAP_DBFLAG_SYNC_SHADOW);
                        if ( cs ) {
+                               ch_free( cs->cs_sids );
                                ber_bvarray_free( cs->cs_vals );
                                ldap_pvt_thread_mutex_destroy( &cs->cs_mutex );
                                ch_free( cs );
@@ -1578,8 +1634,7 @@ syncrepl_message_to_entry(
        }
 
        if ( entry == NULL ) {
-               rc = -1;
-               goto done;
+               return -1;
        }
 
        dnPrettyNormal( NULL, &bdn, &dn, &ndn, op->o_tmpmemctx );
@@ -1679,7 +1734,8 @@ done:
                        e = NULL;
                }
        }
-       *entry = e;
+       if ( entry )
+               *entry = e;
 
        return rc;
 }
@@ -2552,7 +2608,7 @@ syncrepl_updateCookie(
                        value_add( &si->si_cookieState->cs_vals, syncCookie->ctxcsn );
                        free( si->si_cookieState->cs_sids );
                        si->si_cookieState->cs_sids = slap_parse_csn_sids(
-                               si->si_cookieState->cs_vals, si->si_cookieState->cs_num );
+                               si->si_cookieState->cs_vals, si->si_cookieState->cs_num, NULL );
                }
 
                si->si_cookieState->cs_age++;
@@ -3014,106 +3070,119 @@ avl_ber_bvfree( void *v_bv )
 }
 
 void
-syncinfo_free( syncinfo_t *sie )
+syncinfo_free( syncinfo_t *sie, int free_all )
 {
-       if ( sie->si_ld ) {
-               if ( sie->si_conn_setup ) {
-                       ber_socket_t s;
-                       ldap_get_option( sie->si_ld, LDAP_OPT_DESC, &s );
-                       connection_client_stop( s );
-                       sie->si_conn_setup = 0;
-               }
-               ldap_unbind_ext( sie->si_ld, NULL, NULL );
-       }
+       syncinfo_t *si_next;
 
-       /* re-fetch it, in case it was already removed */
-       sie->si_re = ldap_pvt_runqueue_find( &slapd_rq, do_syncrepl, sie );
-       if ( sie->si_re ) {
-               if ( ldap_pvt_runqueue_isrunning( &slapd_rq, sie->si_re ) )
-                       ldap_pvt_runqueue_stoptask( &slapd_rq, sie->si_re );
-               ldap_pvt_runqueue_remove( &slapd_rq, sie->si_re );
+       if ( free_all && sie->si_cookieState ) {
+               ch_free( sie->si_cookieState->cs_sids );
+               ber_bvarray_free( sie->si_cookieState->cs_vals );
+               ldap_pvt_thread_mutex_destroy( &sie->si_cookieState->cs_mutex );
+               ch_free( sie->si_cookieState );
        }
+       do {
+               si_next = sie->si_next;
 
-       ldap_pvt_thread_mutex_destroy( &sie->si_mutex );
-
-       bindconf_free( &sie->si_bindconf );
-
-       if ( sie->si_filterstr.bv_val ) {
-               ch_free( sie->si_filterstr.bv_val );
-       }
-       if ( sie->si_logfilterstr.bv_val ) {
-               ch_free( sie->si_logfilterstr.bv_val );
-       }
-       if ( sie->si_base.bv_val ) {
-               ch_free( sie->si_base.bv_val );
-       }
-       if ( sie->si_logbase.bv_val ) {
-               ch_free( sie->si_logbase.bv_val );
-       }
-       if ( sie->si_attrs ) {
-               int i = 0;
-               while ( sie->si_attrs[i] != NULL ) {
-                       ch_free( sie->si_attrs[i] );
-                       i++;
+               if ( sie->si_ld ) {
+                       if ( sie->si_conn_setup ) {
+                               ber_socket_t s;
+                               ldap_get_option( sie->si_ld, LDAP_OPT_DESC, &s );
+                               connection_client_stop( s );
+                               sie->si_conn_setup = 0;
+                       }
+                       ldap_unbind_ext( sie->si_ld, NULL, NULL );
                }
-               ch_free( sie->si_attrs );
-       }
-       if ( sie->si_exattrs ) {
-               int i = 0;
-               while ( sie->si_exattrs[i] != NULL ) {
-                       ch_free( sie->si_exattrs[i] );
-                       i++;
+       
+               /* re-fetch it, in case it was already removed */
+               sie->si_re = ldap_pvt_runqueue_find( &slapd_rq, do_syncrepl, sie );
+               if ( sie->si_re ) {
+                       if ( ldap_pvt_runqueue_isrunning( &slapd_rq, sie->si_re ) )
+                               ldap_pvt_runqueue_stoptask( &slapd_rq, sie->si_re );
+                       ldap_pvt_runqueue_remove( &slapd_rq, sie->si_re );
                }
-               ch_free( sie->si_exattrs );
-       }
-       if ( sie->si_anlist ) {
-               int i = 0;
-               while ( sie->si_anlist[i].an_name.bv_val != NULL ) {
-                       ch_free( sie->si_anlist[i].an_name.bv_val );
-                       i++;
+       
+               ldap_pvt_thread_mutex_destroy( &sie->si_mutex );
+       
+               bindconf_free( &sie->si_bindconf );
+       
+               if ( sie->si_filterstr.bv_val ) {
+                       ch_free( sie->si_filterstr.bv_val );
                }
-               ch_free( sie->si_anlist );
-       }
-       if ( sie->si_exanlist ) {
-               int i = 0;
-               while ( sie->si_exanlist[i].an_name.bv_val != NULL ) {
-                       ch_free( sie->si_exanlist[i].an_name.bv_val );
-                       i++;
+               if ( sie->si_logfilterstr.bv_val ) {
+                       ch_free( sie->si_logfilterstr.bv_val );
                }
-               ch_free( sie->si_exanlist );
-       }
-       if ( sie->si_retryinterval ) {
-               ch_free( sie->si_retryinterval );
-       }
-       if ( sie->si_retrynum ) {
-               ch_free( sie->si_retrynum );
-       }
-       if ( sie->si_retrynum_init ) {
-               ch_free( sie->si_retrynum_init );
-       }
-       slap_sync_cookie_free( &sie->si_syncCookie, 0 );
-       if ( sie->si_presentlist ) {
-           avl_free( sie->si_presentlist, avl_ber_bvfree );
-       }
-       while ( !LDAP_LIST_EMPTY( &sie->si_nonpresentlist ) ) {
-               struct nonpresent_entry* npe;
-               npe = LDAP_LIST_FIRST( &sie->si_nonpresentlist );
-               LDAP_LIST_REMOVE( npe, npe_link );
-               if ( npe->npe_name ) {
-                       if ( npe->npe_name->bv_val ) {
-                               ch_free( npe->npe_name->bv_val );
+               if ( sie->si_base.bv_val ) {
+                       ch_free( sie->si_base.bv_val );
+               }
+               if ( sie->si_logbase.bv_val ) {
+                       ch_free( sie->si_logbase.bv_val );
+               }
+               if ( sie->si_attrs ) {
+                       int i = 0;
+                       while ( sie->si_attrs[i] != NULL ) {
+                               ch_free( sie->si_attrs[i] );
+                               i++;
                        }
-                       ch_free( npe->npe_name );
+                       ch_free( sie->si_attrs );
                }
-               if ( npe->npe_nname ) {
-                       if ( npe->npe_nname->bv_val ) {
-                               ch_free( npe->npe_nname->bv_val );
+               if ( sie->si_exattrs ) {
+                       int i = 0;
+                       while ( sie->si_exattrs[i] != NULL ) {
+                               ch_free( sie->si_exattrs[i] );
+                               i++;
                        }
-                       ch_free( npe->npe_nname );
+                       ch_free( sie->si_exattrs );
                }
-               ch_free( npe );
-       }
-       ch_free( sie );
+               if ( sie->si_anlist ) {
+                       int i = 0;
+                       while ( sie->si_anlist[i].an_name.bv_val != NULL ) {
+                               ch_free( sie->si_anlist[i].an_name.bv_val );
+                               i++;
+                       }
+                       ch_free( sie->si_anlist );
+               }
+               if ( sie->si_exanlist ) {
+                       int i = 0;
+                       while ( sie->si_exanlist[i].an_name.bv_val != NULL ) {
+                               ch_free( sie->si_exanlist[i].an_name.bv_val );
+                               i++;
+                       }
+                       ch_free( sie->si_exanlist );
+               }
+               if ( sie->si_retryinterval ) {
+                       ch_free( sie->si_retryinterval );
+               }
+               if ( sie->si_retrynum ) {
+                       ch_free( sie->si_retrynum );
+               }
+               if ( sie->si_retrynum_init ) {
+                       ch_free( sie->si_retrynum_init );
+               }
+               slap_sync_cookie_free( &sie->si_syncCookie, 0 );
+               if ( sie->si_presentlist ) {
+                   avl_free( sie->si_presentlist, avl_ber_bvfree );
+               }
+               while ( !LDAP_LIST_EMPTY( &sie->si_nonpresentlist ) ) {
+                       struct nonpresent_entry* npe;
+                       npe = LDAP_LIST_FIRST( &sie->si_nonpresentlist );
+                       LDAP_LIST_REMOVE( npe, npe_link );
+                       if ( npe->npe_name ) {
+                               if ( npe->npe_name->bv_val ) {
+                                       ch_free( npe->npe_name->bv_val );
+                               }
+                               ch_free( npe->npe_name );
+                       }
+                       if ( npe->npe_nname ) {
+                               if ( npe->npe_nname->bv_val ) {
+                                       ch_free( npe->npe_nname->bv_val );
+                               }
+                               ch_free( npe->npe_nname );
+                       }
+                       ch_free( npe );
+               }
+               ch_free( sie );
+               sie = si_next;
+       } while ( free_all && si_next );
 }
 
 
@@ -3650,7 +3719,7 @@ add_syncrepl(
                        Debug( LDAP_DEBUG_ANY,
                                "version %d incompatible with syncrepl\n",
                                si->si_bindconf.sb_version, 0, 0 );
-                       syncinfo_free( si );    
+                       syncinfo_free( si, 0 ); 
                        return 1;
                }
 
@@ -3693,7 +3762,7 @@ add_syncrepl(
 #endif
        if ( rc < 0 ) {
                Debug( LDAP_DEBUG_ANY, "failed to add syncinfo\n", 0, 0, 0 );
-               syncinfo_free( si );    
+               syncinfo_free( si, 0 ); 
                return 1;
        } else {
                Debug( LDAP_DEBUG_CONFIG,
@@ -3912,7 +3981,7 @@ syncrepl_config( ConfigArgs *c )
                                                ldap_pvt_runqueue_isrunning( &slapd_rq, si->si_re ) ) {
                                                si->si_ctype = 0;
                                        } else {
-                                               syncinfo_free( si );
+                                               syncinfo_free( si, 0 );
                                        }
                                        if ( i == c->valx )
                                                break;