]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/syncrepl.c
ITS#4832 fix unint'd var
[openldap] / servers / slapd / syncrepl.c
index 154734e68f727e2863ce8c4f77f6ed332b76229e..cb14169c8feb98950aafbb053fea0e118a9cd0aa 100644 (file)
@@ -60,6 +60,7 @@ typedef struct cookie_state {
 typedef struct syncinfo_s {
        struct syncinfo_s       *si_next;
        struct slap_backend_db *si_be;
+       struct slap_backend_db *si_wbe;
        struct re_s                     *si_re;
        int                                     si_rid;
        char                            si_ridtxt[8];
@@ -111,8 +112,7 @@ static int syncrepl_message_to_entry(
                                        Modifications **, Entry **, int );
 static int syncrepl_entry(
                                        syncinfo_t *, Operation*, Entry*,
-                                       Modifications**,int, struct berval*,
-                                       struct sync_cookie * );
+                                       Modifications**,int, struct berval* );
 static int syncrepl_updateCookie(
                                        syncinfo_t *, Operation *, struct berval *,
                                        struct sync_cookie * );
@@ -520,13 +520,14 @@ do_syncrep1(
                }
 
                slap_compose_sync_cookie( NULL, &si->si_syncCookie.octet_str,
-                       si->si_syncCookie.ctxcsn, si->si_syncCookie.rid );
+                       si->si_syncCookie.ctxcsn, si->si_syncCookie.rid,
+                       SLAP_SINGLE_SHADOW( si->si_be ) ? -1 : slap_serverID );
        } else {
                ldap_pvt_thread_mutex_lock( &si->si_cookieState->cs_mutex );
                /* match SIDs */
                if ( si->si_cookieState->cs_num > 1 && si->si_cookieAge !=
                        si->si_cookieState->cs_age ) {
-                       int i, j;
+                       int i, j, changed = 0;
 
                        for (i=0; !BER_BVISNULL( &si->si_syncCookie.ctxcsn[i] ); i++) {
                                /* bogus, just dup everything */
@@ -534,6 +535,7 @@ do_syncrep1(
                                        ber_bvarray_free( si->si_syncCookie.ctxcsn );
                                        ber_bvarray_dup_x( &si->si_syncCookie.ctxcsn,
                                                si->si_cookieState->cs_vals, NULL );
+                                       changed = 1;
                                        break;
                                }
                                for (j=0; j<si->si_cookieState->cs_num; j++) {
@@ -542,9 +544,16 @@ do_syncrep1(
                                                continue;
                                        ber_bvreplace( &si->si_syncCookie.ctxcsn[i],
                                                &si->si_cookieState->cs_vals[j] );
+                                       changed = 1;
                                        break;
                                }
                        }
+                       if ( changed ) {
+                               ch_free( si->si_syncCookie.octet_str.bv_val );
+                               slap_compose_sync_cookie( NULL, &si->si_syncCookie.octet_str,
+                                       si->si_syncCookie.ctxcsn, si->si_syncCookie.rid,
+                                       SLAP_SINGLE_SHADOW( si->si_be ) ? -1 : slap_serverID );
+                       }
                }
                ldap_pvt_thread_mutex_unlock( &si->si_cookieState->cs_mutex );
        }
@@ -727,7 +736,7 @@ do_syncrep2(
                                        &modlist, &entry, syncstate ) ) == LDAP_SUCCESS )
                                {
                                        if ( ( rc = syncrepl_entry( si, op, entry, &modlist,
-                                               syncstate, &syncUUID, &syncCookie_req ) ) == LDAP_SUCCESS &&
+                                               syncstate, &syncUUID ) ) == LDAP_SUCCESS &&
                                                syncCookie.ctxcsn )
                                        {
                                                rc = syncrepl_updateCookie( si, op, psub, &syncCookie );
@@ -790,6 +799,7 @@ do_syncrep2(
                                }
                                if ( !syncCookie_req.ctxcsn ) {
                                        match = -1;
+                                       m = 0;
                                } else if ( !syncCookie.ctxcsn ) {
                                        match = 1;
                                } else {
@@ -936,6 +946,7 @@ do_syncrep2(
 
                                        if ( !syncCookie_req.ctxcsn ) {
                                                match = -1;
+                                               m = 0;
                                        } else if ( !syncCookie.ctxcsn ) {
                                                match = 1;
                                        } else {
@@ -1074,6 +1085,15 @@ do_syncrepl(
        if ( !si->si_schemachecking )
                op->o_no_schema_check = 1;
 
+       /* If we're glued, send writes through the glue parent */
+       if ( !si->si_wbe ) {
+               if ( SLAP_GLUE_SUBORDINATE( be )) {
+                       si->si_wbe = select_backend( &be->be_nsuffix[0], 0, 1 );
+               } else {
+                       si->si_wbe = be;
+               }
+       }
+
        /* Establish session, do search */
        if ( !si->si_ld ) {
                si->si_refreshDelete = 0;
@@ -1092,6 +1112,13 @@ reload:
                        goto reload;
                }
 
+               /* We got deleted while running on cn=config */
+               if ( !si->si_ctype ) {
+                       if ( si->si_conn_setup )
+                               dostop = 1;
+                       rc = -1;
+               }
+
                if ( abs(si->si_type) == LDAP_SYNC_REFRESH_AND_PERSIST ) {
                        /* If we succeeded, enable the connection for further listening.
                         * If we failed, tear down the connection and reschedule.
@@ -1146,7 +1173,8 @@ reload:
                                break;
                }
 
-               if ( !si->si_retrynum || si->si_retrynum[i] == RETRYNUM_TAIL ) {
+               if ( !si->si_ctype
+                       || !si->si_retrynum || si->si_retrynum[i] == RETRYNUM_TAIL ) {
                        ldap_pvt_runqueue_remove( &slapd_rq, rtask );
                } else if ( RETRYNUM_VALID( si->si_retrynum[i] ) ) {
                        if ( si->si_retrynum[i] > 0 )
@@ -1160,6 +1188,24 @@ reload:
        ldap_pvt_thread_mutex_unlock( &slapd_rq.rq_mutex );
        ldap_pvt_thread_mutex_unlock( &si->si_mutex );
 
+       /* Do final delete cleanup */
+       if ( !si->si_ctype ) {
+               cookie_state *cs = NULL;
+               syncinfo_t **sip;
+
+               cs = be->be_syncinfo->si_cookieState;
+               for ( sip = &be->be_syncinfo; *sip != si; sip = &(*sip)->si_next );
+               *sip = si->si_next;
+               syncinfo_free( si );
+               if ( !be->be_syncinfo ) {
+                       SLAP_DBFLAGS( be ) &= ~(SLAP_DBFLAG_SHADOW|SLAP_DBFLAG_SYNC_SHADOW);
+                       if ( cs ) {
+                               ber_bvarray_free( cs->cs_vals );
+                               ldap_pvt_thread_mutex_destroy( &cs->cs_mutex );
+                               ch_free( cs );
+                       }
+               }
+       }
        return NULL;
 }
 
@@ -1301,6 +1347,7 @@ syncrepl_message_to_op(
        }
 
        op->o_tag = LBER_DEFAULT;
+       op->o_bd = si->si_wbe;
 
        while (( rc = ldap_get_attribute_ber( si->si_ld, msg, ber, &bv, &bvals ) )
                == LDAP_SUCCESS ) {
@@ -1394,10 +1441,12 @@ syncrepl_message_to_op(
                                be_entry_release_w( op, op->ora_e );
                } else {
                        op->orm_modlist = modlist;
+                       op->o_bd = si->si_wbe;
                        rc = op->o_bd->be_modify( op, &rs );
                        Debug( rc ? LDAP_DEBUG_ANY : LDAP_DEBUG_SYNC,
                                "syncrepl_message_to_op: %s be_modify %s (%d)\n", 
                                si->si_ridtxt, op->o_req_dn.bv_val, rc );
+                       op->o_bd = si->si_be;
                }
                break;
        case LDAP_REQ_MODRDN:
@@ -1451,6 +1500,7 @@ syncrepl_message_to_op(
        }
 done:
        slap_graduate_commit_csn( op );
+       op->o_bd = si->si_be;
        op->o_tmpfree( op->o_csn.bv_val, op->o_tmpmemctx );
        BER_BVZERO( &op->o_csn );
        if ( modlist ) {
@@ -1672,8 +1722,7 @@ syncrepl_entry(
        Entry* entry,
        Modifications** modlist,
        int syncstate,
-       struct berval* syncUUID,
-       struct sync_cookie* syncCookie_req )
+       struct berval* syncUUID )
 {
        Backend *be = op->o_bd;
        slap_callback   cb = { NULL, NULL, NULL, NULL };
@@ -1853,8 +1902,9 @@ retry_add:;
                        op->o_req_ndn = entry->e_nname;
                        op->o_tag = LDAP_REQ_ADD;
                        op->ora_e = entry;
+                       op->o_bd = si->si_wbe;
 
-                       rc = be->be_add( op, &rs_add );
+                       rc = op->o_bd->be_add( op, &rs_add );
                        Debug( LDAP_DEBUG_SYNC,
                                        "syncrepl_entry: %s be_add (%d)\n", 
                                        si->si_ridtxt, rc, 0 );
@@ -1887,6 +1937,7 @@ retry_add:;
                                        SlapReply       rs2 = { 0 };
                                        slap_callback   cb2 = { 0 };
 
+                                       op2.o_bd = be;
                                        op2.o_tag = LDAP_REQ_SEARCH;
                                        op2.o_req_dn = entry->e_name;
                                        op2.o_req_ndn = entry->e_nname;
@@ -1922,6 +1973,7 @@ retry_add:;
                                        si->si_ridtxt, rs_add.sr_err, 0 );
                                break;
                        }
+                       op->o_bd = be;
                        goto done;
                }
                /* FALLTHRU */
@@ -1988,7 +2040,8 @@ retry_add:;
                                        }
                                }
                        }
-                       rc = be->be_modrdn( op, &rs_modify );
+                       op->o_bd = si->si_wbe;
+                       rc = op->o_bd->be_modrdn( op, &rs_modify );
                        op->o_tmpfree( op->orr_nnewrdn.bv_val, op->o_tmpmemctx );
                        op->o_tmpfree( op->orr_newrdn.bv_val, op->o_tmpmemctx );
 
@@ -1996,14 +2049,16 @@ retry_add:;
                        Debug( LDAP_DEBUG_SYNC,
                                        "syncrepl_entry: %s be_modrdn (%d)\n", 
                                        si->si_ridtxt, rc, 0 );
+                       op->o_bd = be;
                        goto done;
                }
                if ( dni.mods ) {
                        op->o_tag = LDAP_REQ_MODIFY;
                        op->orm_modlist = dni.mods;
                        op->orm_no_opattrs = 1;
+                       op->o_bd = si->si_wbe;
 
-                       rc = be->be_modify( op, &rs_modify );
+                       rc = op->o_bd->be_modify( op, &rs_modify );
                        slap_mods_free( op->orm_modlist, 1 );
                        Debug( LDAP_DEBUG_SYNC,
                                        "syncrepl_entry: %s be_modify (%d)\n", 
@@ -2013,6 +2068,7 @@ retry_add:;
                                        "syncrepl_entry: %s be_modify failed (%d)\n",
                                        si->si_ridtxt, rs_modify.sr_err, 0 );
                        }
+                       op->o_bd = be;
                } else {
                        Debug( LDAP_DEBUG_SYNC,
                                        "syncrepl_entry: %s entry unchanged, ignored (%s)\n", 
@@ -2024,7 +2080,8 @@ retry_add:;
                        op->o_req_dn = dni.dn;
                        op->o_req_ndn = dni.ndn;
                        op->o_tag = LDAP_REQ_DELETE;
-                       rc = be->be_delete( op, &rs_delete );
+                       op->o_bd = si->si_wbe;
+                       rc = op->o_bd->be_delete( op, &rs_delete );
                        Debug( LDAP_DEBUG_SYNC,
                                        "syncrepl_entry: %s be_delete (%d)\n", 
                                        si->si_ridtxt, rc, 0 );
@@ -2032,7 +2089,7 @@ retry_add:;
                        while ( rs_delete.sr_err == LDAP_SUCCESS
                                && op->o_delete_glue_parent ) {
                                op->o_delete_glue_parent = 0;
-                               if ( !be_issuffix( op->o_bd, &op->o_req_ndn ) ) {
+                               if ( !be_issuffix( be, &op->o_req_ndn ) ) {
                                        slap_callback cb = { NULL };
                                        cb.sc_response = slap_null_cb;
                                        dnParent( &op->o_req_ndn, &pdn );
@@ -2044,6 +2101,7 @@ retry_add:;
                                        break;
                                }
                        }
+                       op->o_bd = be;
                }
                goto done;
 
@@ -2169,6 +2227,7 @@ syncrepl_del_nonpresent(
                        csn = si->si_syncCookie.ctxcsn[0];
                }
 
+               op->o_bd = si->si_wbe;
                slap_queue_csn( op, &csn );
 
                np_list = LDAP_LIST_FIRST( &si->si_nonpresentlist );
@@ -2208,14 +2267,14 @@ syncrepl_del_nonpresent(
                                op->o_tag = LDAP_REQ_MODIFY;
                                op->orm_modlist = &mod1;
 
-                               rc = be->be_modify( op, &rs_modify );
+                               rc = op->o_bd->be_modify( op, &rs_modify );
                                if ( mod2.sml_next ) slap_mods_free( mod2.sml_next, 1 );
                        }
 
                        while ( rs_delete.sr_err == LDAP_SUCCESS &&
                                        op->o_delete_glue_parent ) {
                                op->o_delete_glue_parent = 0;
-                               if ( !be_issuffix( op->o_bd, &op->o_req_ndn ) ) {
+                               if ( !be_issuffix( be, &op->o_req_ndn ) ) {
                                        slap_callback cb = { NULL };
                                        cb.sc_response = slap_null_cb;
                                        dnParent( &op->o_req_ndn, &pdn );
@@ -2237,6 +2296,7 @@ syncrepl_del_nonpresent(
                }
 
                slap_graduate_commit_csn( op );
+               op->o_bd = be;
 
                op->o_tmpfree( op->o_csn.bv_val, op->o_tmpmemctx );
                BER_BVZERO( &op->o_csn );
@@ -2447,6 +2507,7 @@ syncrepl_updateCookie(
                                first = syncCookie->ctxcsn[i];
                }
        }
+       op->o_bd = si->si_wbe;
        slap_queue_csn( op, &first );
 
        op->o_tag = LDAP_REQ_MODIFY;
@@ -2467,7 +2528,7 @@ syncrepl_updateCookie(
                op->orm_modlist = &mod[1];
 
        op->orm_no_opattrs = 1;
-       rc = be->be_modify( op, &rs_modify );
+       rc = op->o_bd->be_modify( op, &rs_modify );
        op->o_msgid = 0;
 
        if ( rs_modify.sr_err == LDAP_SUCCESS ) {
@@ -2504,6 +2565,7 @@ syncrepl_updateCookie(
        ldap_pvt_thread_mutex_unlock( &si->si_cookieState->cs_mutex );
 
        slap_graduate_commit_csn( op );
+       op->o_bd = be;
        op->o_tmpfree( op->o_csn.bv_val, op->o_tmpmemctx );
        BER_BVZERO( &op->o_csn );
        if ( mod[1].sml_next ) slap_mods_free( mod[1].sml_next, 1 );
@@ -2711,6 +2773,12 @@ dn_callback(
                                        slap_schema.si_ad_entryCSN );
                                if ( new && old && ber_bvcmp( &old->a_vals[0],
                                        &new->a_vals[0] ) >= 0 ) {
+                                       Debug( LDAP_DEBUG_SYNC,
+                                               "dn_callback : new entry is older than ours "
+                                               "%s ours %s, new %s\n",
+                                               rs->sr_entry->e_name.bv_val,
+                                               old->a_vals[0].bv_val,
+                                               new->a_vals[0].bv_val );
                                        return LDAP_SUCCESS;
                                }
 
@@ -3836,7 +3904,18 @@ syncrepl_config( ConfigArgs *c )
                                si = *sip;
                                if ( c->valx == -1 || i == c->valx ) {
                                        *sip = si->si_next;
-                                       syncinfo_free( si );
+                                       /* If the task is currently active, we have to leave
+                                        * it running. It will exit on its own. This will only
+                                        * happen when running on the cn=config DB.
+                                        */
+                                       if ( si->si_re &&
+                                               ldap_pvt_runqueue_isrunning( &slapd_rq, si->si_re ) ) {
+                                               si->si_ctype = 0;
+                                       } else {
+                                               syncinfo_free( si );
+                                       }
+                                       if ( i == c->valx )
+                                               break;
                                } else {
                                        sip = &si->si_next;
                                }