]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/syncrepl.c
Fix prev commit
[openldap] / servers / slapd / syncrepl.c
index 92d51347eca627edc378f37f9edb88d0fcc0b7b9..ea3da5f929513ec5e2990d86f6fd69234fc3e842 100644 (file)
@@ -1,33 +1,19 @@
+/* syncrepl.c -- Replication Engine which uses the LDAP Sync protocol */
 /* $OpenLDAP$ */
-/*
- * Replication Engine which uses the LDAP Sync protocol
- */
-/*
- * Copyright 2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
- */
-/* Copyright (c) 2003 by International Business Machines, Inc.
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * International Business Machines, Inc. (hereinafter called IBM) grants
- * permission under its copyrights to use, copy, modify, and distribute this
- * Software with or without fee, provided that the above copyright notice and
- * all paragraphs of this notice appear in all copies, and that the name of IBM
- * not be used in connection with the marketing of any product incorporating
- * the Software or modifications thereof, without specific, written prior
- * permission.
+ * Copyright 2003-2004 The OpenLDAP Foundation.
+ * Portions Copyright 2003 by IBM Corporation.
+ * Portions Copyright 2003 by Howard Chu, Symas Corporation.
+ * All rights reserved.
  *
- * THE SOFTWARE IS PROVIDED "AS IS", AND IBM DISCLAIMS ALL WARRANTIES,
- * INCLUDING ALL IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A
- * PARTICULAR PURPOSE.  IN NO EVENT SHALL IBM BE LIABLE FOR ANY SPECIAL,
- * DIRECT, INDIRECT, OR CONSEQUENTIAL DAMAGES OR ANY DAMAGES WHATSOEVER ARISING
- * OUT OF OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE, EVEN
- * IF IBM IS APPRISED OF THE POSSIBILITY OF SUCH DAMAGES.
- */
-/* Modified by Howard Chu
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
  *
- * Copyright (c) 2003 by Howard Chu, Symas Corporation
- *
- * Modifications provided under the terms of the OpenLDAP public license.
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
  */
 
 #include "portable.h"
 static const struct berval slap_syncrepl_bvc = BER_BVC(SYNCREPL_STR);
 static const struct berval slap_syncrepl_cn_bvc = BER_BVC(CN_STR SYNCREPL_STR);
 
+static int syncuuid_cmp( const void *, const void * );
 static void avl_ber_bvfree( void * );
-
-static void
-syncrepl_del_nonpresent( Operation *, syncinfo_t * );
+static void syncrepl_del_nonpresent( Operation *, syncinfo_t * );
 
 /* callback functions */
 static int dn_callback( struct slap_op *, struct slap_rep * );
@@ -188,10 +173,15 @@ do_syncrep1(
        syncinfo_t *si )
 {
        int     rc;
+       int cmdline_cookie_found = 0;
 
        char syncrepl_cbuf[sizeof(CN_STR SYNCREPL_STR)];
        struct berval syncrepl_cn_bv;
+       struct sync_cookie      *sc = NULL;
        struct sync_cookie      syncCookie = { NULL, -1, NULL };
+       struct berval   *psub;
+
+       psub = &si->si_be->be_nsuffix[0];
 
        /* Init connection to master */
 
@@ -306,37 +296,90 @@ do_syncrep1(
 
        /* get syncrepl cookie of shadow replica from subentry */
 
-       assert( si->si_id < 1000 );
+       assert( si->si_rid < 1000 );
        syncrepl_cn_bv.bv_val = syncrepl_cbuf;
        syncrepl_cn_bv.bv_len = snprintf(syncrepl_cbuf, sizeof(syncrepl_cbuf),
-               CN_STR "syncrepl%d", si->si_id );
-       build_new_dn( &op->o_req_ndn, &si->si_base, &syncrepl_cn_bv,
-               op->o_tmpmemctx );
+               CN_STR "syncrepl%ld", si->si_rid );
+       build_new_dn( &op->o_req_ndn, psub, &syncrepl_cn_bv, op->o_tmpmemctx );
        op->o_req_dn = op->o_req_ndn;
 
-       if ( slap_sync_cookie != NULL ) {
-               slap_sync_cookie_free( &si->si_syncCookie, 0 );
-               slap_parse_sync_cookie( slap_sync_cookie );
-               if ( slap_sync_cookie->ctxcsn == NULL ||
-                        slap_sync_cookie->ctxcsn->bv_val == NULL ) {
-                       slap_init_sync_cookie_ctxcsn( slap_sync_cookie );
+       LDAP_STAILQ_FOREACH( sc, &slap_sync_cookie, sc_next ) {
+               if ( si->si_rid == sc->rid ) {
+                       cmdline_cookie_found = 1;
+                       break;
                }
-               slap_dup_sync_cookie( &si->si_syncCookie, slap_sync_cookie );
-               slap_sync_cookie_free( slap_sync_cookie, 1 );
-               slap_sync_cookie = NULL;
        }
 
-       /* use in-memory version if it exists */
-       if ( si->si_syncCookie.octet_str == NULL ) {
+       if ( cmdline_cookie_found ) {
+               /* cookie is supplied in the command line */
                BerVarray cookie = NULL;
                struct berval cookie_bv;
+
+               LDAP_STAILQ_REMOVE( &slap_sync_cookie, sc, sync_cookie, sc_next );
+               slap_sync_cookie_free( &si->si_syncCookie, 0 );
+
+               /* read stored cookie if it exists */
                backend_attribute( op, NULL, &op->o_req_ndn,
                        slap_schema.si_ad_syncreplCookie, &cookie );
-               if ( cookie ) {
+
+               if ( !cookie ) {
+                       /* no stored cookie */
+                       if ( sc->ctxcsn == NULL ||
+                                sc->ctxcsn->bv_val == NULL ) {
+                               /* if cmdline cookie does not have ctxcsn */
+                               /* component, set it to an initial value */
+                               slap_init_sync_cookie_ctxcsn( sc );
+                       }
+                       slap_dup_sync_cookie( &si->si_syncCookie, sc );
+                       slap_sync_cookie_free( sc, 1 );
+                       sc = NULL;
+               } else {
+                       /* stored cookie */
+                       struct berval newcookie = { 0, NULL };
                        ber_dupbv( &cookie_bv, &cookie[0] );
                        ber_bvarray_add( &si->si_syncCookie.octet_str, &cookie_bv );
                        slap_parse_sync_cookie( &si->si_syncCookie );
+                       ber_bvarray_free( si->si_syncCookie.octet_str );
+                       si->si_syncCookie.octet_str = NULL;
                        ber_bvarray_free_x( cookie, op->o_tmpmemctx );
+                       if ( sc->sid != -1 ) {
+                               /* command line cookie wins */
+                               si->si_syncCookie.sid = sc->sid;
+                       }
+                       if ( sc->ctxcsn != NULL ) {
+                               /* command line cookie wins */
+                               if ( si->si_syncCookie.ctxcsn ) {
+                                       ber_bvarray_free( si->si_syncCookie.ctxcsn );
+                                       si->si_syncCookie.ctxcsn = NULL;
+                               }
+                               ber_dupbv( &cookie_bv, &sc->ctxcsn[0] );
+                               ber_bvarray_add( &si->si_syncCookie.ctxcsn, &cookie_bv );
+                       }
+                       if ( sc->rid != -1 ) {
+                               /* command line cookie wins */
+                               si->si_syncCookie.rid = sc->rid;
+                       }
+                       slap_sync_cookie_free( sc, 1 );
+                       sc = NULL;
+                       slap_compose_sync_cookie( NULL, &newcookie,
+                                       &si->si_syncCookie.ctxcsn[0],
+                                       si->si_syncCookie.sid, si->si_syncCookie.rid );
+                       ber_bvarray_add( &si->si_syncCookie.octet_str, &newcookie );
+               }
+       } else {
+               /* no command line cookie is specified */
+               if ( si->si_syncCookie.octet_str == NULL ) {
+                       BerVarray cookie = NULL;
+                       struct berval cookie_bv;
+                       /* try to read stored cookie */
+                       backend_attribute( op, NULL, &op->o_req_ndn,
+                               slap_schema.si_ad_syncreplCookie, &cookie );
+                       if ( cookie ) {
+                               ber_dupbv( &cookie_bv, &cookie[0] );
+                               ber_bvarray_add( &si->si_syncCookie.octet_str, &cookie_bv );
+                               slap_parse_sync_cookie( &si->si_syncCookie );
+                               ber_bvarray_free_x( cookie, op->o_tmpmemctx );
+                       }
                }
        }
 
@@ -388,13 +431,10 @@ do_syncrep2(
        struct sync_cookie      syncCookie_req = { NULL, -1, NULL };
        struct berval           cookie = { 0, NULL };
 
-       int     rc;
-       int     err;
+       int     rc, err, i;
        ber_len_t       len;
 
-       slap_callback   cb;
-
-       int rc_efree;
+       int rc_efree = 1;
 
        struct berval   *psub;
        Modifications   *modlist = NULL;
@@ -407,22 +447,23 @@ do_syncrep2(
 
        int             refreshDeletes = 0;
        int             refreshDone = 1;
-       BerVarray syncUUIDs;
+       BerVarray syncUUIDs = NULL;
        ber_tag_t si_tag;
 
-       if ( slapd_abrupt_shutdown ) {
+       if ( slapd_shutdown ) {
                rc = -2;
                goto done;
        }
 
+       ber_init2( ber, NULL, LBER_USE_DER );
+       ber_set_option( ber, LBER_OPT_BER_MEMCTX, &op->o_tmpmemctx );
+
 #ifdef NEW_LOGGING
        LDAP_LOG ( OPERATION, DETAIL1, "do_syncrep2\n", 0, 0, 0 );
 #else
        Debug( LDAP_DEBUG_TRACE, "=>do_syncrep2\n", 0, 0, 0 );
 #endif
 
-       op->o_callback = &cb;
-
        psub = &si->si_be->be_nsuffix[0];
 
        slap_dup_sync_cookie( &syncCookie_req, &si->si_syncCookie );
@@ -436,7 +477,7 @@ do_syncrep2(
        while (( rc = ldap_result( si->si_ld, LDAP_RES_ANY, LDAP_MSG_ONE, tout_p, &res ))
                > 0 )
        {
-               if ( slapd_abrupt_shutdown ) {
+               if ( slapd_shutdown ) {
                        rc = -2;
                        goto done;
                }
@@ -466,12 +507,14 @@ do_syncrep2(
                                                        syncCookie.octet_str[0].bv_val )
                                                slap_parse_sync_cookie( &syncCookie );
                                }
-                               entry = syncrepl_message_to_entry( si, op, msg,
-                                       &modlist, syncstate );
-                               rc_efree = syncrepl_entry( si, op, entry, modlist, syncstate,
-                                                       &syncUUID, &syncCookie_req );
-                               if ( syncCookie.octet_str && syncCookie.octet_str[0].bv_val ) {
-                                       syncrepl_updateCookie( si, op, psub, &syncCookie );
+                               if ( syncrepl_message_to_entry( si, op, msg,
+                                       &modlist, &entry, syncstate ) == LDAP_SUCCESS ) {
+                                       rc_efree = syncrepl_entry( si, op, entry, modlist,
+                                                               syncstate, &syncUUID, &syncCookie_req );
+                                       if ( syncCookie.octet_str &&
+                                                syncCookie.octet_str[0].bv_val ) {
+                                               syncrepl_updateCookie( si, op, psub, &syncCookie );
+                                       }
                                }
                                ldap_controls_free( rctrls );
                                if ( modlist ) {
@@ -479,6 +522,7 @@ do_syncrep2(
                                }
                                if ( rc_efree && entry ) {
                                        entry_free( entry );
+                                       entry = NULL;
                                }
                                break;
 
@@ -529,7 +573,7 @@ do_syncrep2(
                                                &syncCookie_req.ctxcsn[0], &syncCookie.ctxcsn[0], &text );
                                }
                                if ( syncCookie.octet_str && syncCookie.octet_str->bv_val
-                                        && match < 0 ) {
+                                        && match < 0 && err == LDAP_SUCCESS ) {
                                        syncrepl_updateCookie( si, op, psub, &syncCookie );
                                }
                                if ( rctrls ) {
@@ -540,7 +584,8 @@ do_syncrep2(
                                         *      1) err code : LDAP_BUSY ...
                                         *      2) on err policy : stop service, stop sync, retry
                                         */
-                                       if ( refreshDeletes == 0 && match < 0 ) {
+                                       if ( refreshDeletes == 0 && match < 0 &&
+                                                err == LDAP_SUCCESS ) {
                                                syncrepl_del_nonpresent( op, si );
                                        } else {
                                                avl_free( si->si_presentlist, avl_ber_bvfree );
@@ -589,15 +634,15 @@ do_syncrep2(
                                                ber_scanf( ber, "}" );
                                                break;
                                        case LDAP_TAG_SYNC_ID_SET:
-                                               /* FIXME : to be supported */
                                                ber_scanf( ber, "t{", &tag );
-                                               if ( ber_peek_tag( ber, &len ) == LDAP_TAG_SYNC_COOKIE )
-                                               {
+                                               if ( ber_peek_tag( ber, &len ) ==
+                                                               LDAP_TAG_SYNC_COOKIE ) {
                                                        ber_scanf( ber, "m", &cookie );
                                                        if ( cookie.bv_val ) {
                                                                struct berval tmp_bv;
                                                                ber_dupbv( &tmp_bv, &cookie );
-                                                               ber_bvarray_add( &syncCookie.octet_str, &tmp_bv);
+                                                               ber_bvarray_add( &syncCookie.octet_str,
+                                                                                                &tmp_bv );
                                                        }
                                                        if ( syncCookie.octet_str &&
                                                                         syncCookie.octet_str[0].bv_val )
@@ -610,16 +655,24 @@ do_syncrep2(
                                                }
                                                ber_scanf( ber, "[W]", &syncUUIDs );
                                                ber_scanf( ber, "}" );
+                                               for ( i = 0; syncUUIDs[i].bv_val; i++ ) {
+                                                       struct berval *syncuuid_bv;
+                                                       syncuuid_bv = ber_dupbv( NULL, &syncUUIDs[i] );
+                                                       avl_insert( &si->si_presentlist,
+                                                                       (caddr_t) syncuuid_bv,
+                                                                       syncuuid_cmp, avl_dup_error );
+                                               }
+                                               ber_memfree_x( syncUUIDs, op->o_tmpmemctx );
                                                break;
                                        default:
 #ifdef NEW_LOGGING
                                        LDAP_LOG( OPERATION, ERR,
-                                               "do_syncrep2 : unknown syncinfo tag (%d)\n",
-                                               si_tag, 0, 0 );
+                                               "do_syncrep2 : unknown syncinfo tag (%ld)\n",
+                                               (long) si_tag, 0, 0 );
 #else
                                        Debug( LDAP_DEBUG_ANY,
-                                               "do_syncrep2 : unknown syncinfo tag (%d)\n",
-                                               si_tag, 0, 0 );
+                                               "do_syncrep2 : unknown syncinfo tag (%ld)\n",
+                                               (long) si_tag, 0, 0 );
 #endif
                                                ldap_memfree( retoid );
                                                ber_bvfree( retdata );
@@ -748,7 +801,7 @@ do_syncrepl(
                return NULL;
        }
 
-       if ( slapd_abrupt_shutdown && si->si_ld ) {
+       if ( slapd_shutdown && si->si_ld ) {
                ldap_get_option( si->si_ld, LDAP_OPT_DESC, &s );
                connection_client_stop( s );
                ldap_unbind( si->si_ld );
@@ -764,8 +817,7 @@ do_syncrepl(
        conn.c_peer_name = slap_empty_bv;
 
        /* set memory context */
-#define SLAB_SIZE 1048576
-       op.o_tmpmemctx = sl_mem_create( SLAB_SIZE, ctx );
+       op.o_tmpmemctx = sl_mem_create( SLMALLOC_SLAB_SIZE, ctx );
        op.o_tmpmfuncs = &sl_mfuncs;
 
        op.o_dn = si->si_updatedn;
@@ -846,12 +898,13 @@ do_syncrepl(
        return NULL;
 }
 
-Entry*
+int
 syncrepl_message_to_entry(
        syncinfo_t      *si,
        Operation       *op,
        LDAPMessage     *msg,
        Modifications   **modlist,
+       Entry                   **entry,
        int             syncstate
 )
 {
@@ -878,7 +931,7 @@ syncrepl_message_to_entry(
                Debug( LDAP_DEBUG_ANY,
                        "Message type should be entry (%d)", ldap_msgtype( msg ), 0, 0 );
 #endif
-               return NULL;
+               return -1;
        }
 
        op->o_tag = LDAP_REQ_ADD;
@@ -893,7 +946,7 @@ syncrepl_message_to_entry(
                Debug( LDAP_DEBUG_ANY,
                        "syncrepl_message_to_entry : dn get failed (%d)", rc, 0, 0 );
 #endif
-               return NULL;
+               return rc;
        }
 
        dnPrettyNormal( NULL, &bdn, &dn, &ndn, op->o_tmpmemctx );
@@ -902,11 +955,17 @@ syncrepl_message_to_entry(
        sl_free( ndn.bv_val, op->o_tmpmemctx );
        sl_free( dn.bv_val, op->o_tmpmemctx );
 
-       if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE ) {
-               return NULL;
+       if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE )
+       {
+               return LDAP_SUCCESS;
+       }
+
+       if ( entry == NULL ) {
+               return -1;
        }
 
        e = ( Entry * ) ch_calloc( 1, sizeof( Entry ) );
+       *entry = e;
        e->e_name = op->o_req_dn;
        e->e_nname = op->o_req_ndn;
 
@@ -971,18 +1030,13 @@ done:
                e = NULL;
        }
 
-       return e;
+       return rc;
 }
 
-int
-syncuuid_cmp( const void* v_uuid1, const void* v_uuid2 )
-{
-       const struct berval *uuid1 = v_uuid1;
-       const struct berval *uuid2 = v_uuid2;
-       int rc = uuid1->bv_len - uuid2->bv_len;
-       if ( rc ) return rc;
-       return ( strcmp( uuid1->bv_val, uuid2->bv_val ) );
-}
+static struct berval uuidbva[] = {
+       BER_BVNULL,
+       BER_BVNULL
+};
 
 int
 syncrepl_entry(
@@ -996,8 +1050,9 @@ syncrepl_entry(
 )
 {
        Backend *be = op->o_bd;
-       slap_callback   cb;
+       slap_callback   cb = { NULL };
        struct berval   *syncuuid_bv = NULL;
+       struct berval   syncUUID_strrep = { 0, NULL };
 
        SlapReply       rs = {REP_RESULT};
        Filter f = {0};
@@ -1006,6 +1061,13 @@ syncrepl_entry(
        int ret = LDAP_SUCCESS;
        const char *text;
 
+       struct berval pdn = { 0, NULL };
+       struct berval org_req_dn = { 0, NULL };
+       struct berval org_req_ndn = { 0, NULL };
+       struct berval org_dn = { 0, NULL };
+       struct berval org_ndn = { 0, NULL };
+       int     org_managedsait;
+
        if (( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_ADD ))
        {
                syncuuid_bv = ber_dupbv( NULL, syncUUID );
@@ -1020,12 +1082,8 @@ syncrepl_entry(
        f.f_choice = LDAP_FILTER_EQUALITY;
        f.f_ava = &ava;
        ava.aa_desc = slap_schema.si_ad_entryUUID;
-       rc = asserted_value_validate_normalize(
-               ava.aa_desc, ad_mr(ava.aa_desc, SLAP_MR_EQUALITY),
-               SLAP_MR_EQUALITY, syncUUID, &ava.aa_value, &text, op->o_tmpmemctx );
-       if ( rc != LDAP_SUCCESS ) {
-               return rc;
-       }
+       slap_uuidstr_from_normalized( &syncUUID_strrep, syncUUID, op->o_tmpmemctx );
+       ava.aa_value = *syncUUID;
        op->ors_filter = &f;
 
        op->ors_filterstr.bv_len = (sizeof("entryUUID=")-1) + syncUUID->bv_len;
@@ -1036,6 +1094,7 @@ syncrepl_entry(
                syncUUID->bv_val, syncUUID->bv_len );
        op->ors_filterstr.bv_val[op->ors_filterstr.bv_len] = '\0';
 
+       op->o_tag = LDAP_REQ_SEARCH;
        op->ors_scope = LDAP_SCOPE_SUBTREE;
 
        /* get syncrepl cookie of shadow replica from subentry */
@@ -1049,7 +1108,9 @@ syncrepl_entry(
 
        si->si_syncUUID_ndn.bv_val = NULL;
 
-       rc = be->be_search( op, &rs );
+       if ( limits_check( op, &rs ) == 0 ) {
+               rc = be->be_search( op, &rs );
+       }
 
        if ( op->ors_filterstr.bv_val ) {
                sl_free( op->ors_filterstr.bv_val, op->o_tmpmemctx );
@@ -1077,6 +1138,39 @@ syncrepl_entry(
                op->o_req_ndn = si->si_syncUUID_ndn;
                op->o_tag = LDAP_REQ_DELETE;
                rc = be->be_delete( op, &rs );
+
+               org_req_dn = op->o_req_dn;
+               org_req_ndn = op->o_req_ndn;
+               org_dn = op->o_dn;
+               org_ndn = op->o_ndn;
+               org_managedsait = get_manageDSAit( op );
+               op->o_dn = op->o_bd->be_rootdn;
+               op->o_ndn = op->o_bd->be_rootndn;
+               op->o_managedsait = 1;
+
+               while ( rs.sr_err == LDAP_SUCCESS &&
+                               op->o_delete_glue_parent ) {
+                       op->o_delete_glue_parent = 0;
+                       if ( !be_issuffix( op->o_bd, &op->o_req_ndn )) {
+                               slap_callback cb = { NULL };
+                               cb.sc_response = slap_null_cb;
+                               dnParent( &op->o_req_ndn, &pdn );
+                               op->o_req_dn = pdn;
+                               op->o_req_ndn = pdn;
+                               op->o_callback = &cb;
+                               op->o_bd->be_delete( op, &rs );
+                       } else {
+                               break;
+                   }
+               }
+
+               op->o_managedsait = org_managedsait;
+               op->o_dn = org_dn;
+               op->o_ndn = org_ndn;
+               op->o_req_dn = org_req_dn;
+               op->o_req_ndn = org_req_ndn;
+               op->o_delete_glue_parent = 0;
+
                op->o_no_psearch = 0;
        }
 
@@ -1085,7 +1179,8 @@ syncrepl_entry(
        case LDAP_SYNC_MODIFY:
                if ( rc == LDAP_SUCCESS ||
                         rc == LDAP_REFERRAL ||
-                        rc == LDAP_NO_SUCH_OBJECT )
+                        rc == LDAP_NO_SUCH_OBJECT ||
+                        rc == LDAP_NOT_ALLOWED_ON_NONLEAF )
                {
                        attr_delete( &e->e_attrs, slap_schema.si_ad_entryUUID );
                        attr_merge_one( e, slap_schema.si_ad_entryUUID,
@@ -1098,11 +1193,27 @@ syncrepl_entry(
                        rc = be->be_add( op, &rs );
 
                        if ( rc != LDAP_SUCCESS ) {
-                               if ( rc == LDAP_ALREADY_EXISTS ) {      
+                               if ( rc == LDAP_ALREADY_EXISTS ) {
+                                       Modifications *mod;
+                                       Modifications *modtail;
+
+                                       for ( mod = modlist; mod != NULL; mod = mod->sml_next ) {
+                                               modtail = mod;
+                                       }
+
+                                       mod = (Modifications *)ch_calloc(1, sizeof(Modifications));
+                                       ber_dupbv( &uuidbva[0], syncUUID );
+                                       mod->sml_op = LDAP_MOD_REPLACE;
+                                       mod->sml_desc = slap_schema.si_ad_entryUUID;
+                                       mod->sml_type = mod->sml_desc->ad_cname;
+                                       mod->sml_bvalues = uuidbva;
+                                       modtail->sml_next = mod;
+                                       
                                        op->o_tag = LDAP_REQ_MODIFY;
                                        op->orm_modlist = modlist;
                                        op->o_req_dn = e->e_name;
                                        op->o_req_ndn = e->e_nname;
+
                                        rc = be->be_modify( op, &rs );
                                        if ( rc != LDAP_SUCCESS ) {
 #ifdef NEW_LOGGING
@@ -1153,7 +1264,7 @@ syncrepl_entry(
 
        case LDAP_SYNC_DELETE :
                /* Already deleted */
-               ret = 1;
+               ret = 0;
                goto done;
 
        default :
@@ -1170,8 +1281,8 @@ syncrepl_entry(
 
 done :
 
-       if ( ava.aa_value.bv_val ) {
-               ber_memfree_x( ava.aa_value.bv_val, op->o_tmpmemctx );
+       if ( syncUUID_strrep.bv_val ) {
+               ber_memfree_x( syncUUID_strrep.bv_val, op->o_tmpmemctx );
        }
        if ( si->si_syncUUID_ndn.bv_val ) {
                ber_memfree_x( si->si_syncUUID_ndn.bv_val, op->o_tmpmemctx );
@@ -1179,6 +1290,12 @@ done :
        return ret;
 }
 
+static struct berval gcbva[] = {
+       BER_BVC("top"),
+       BER_BVC("glue"),
+       BER_BVNULL
+};
+
 static void
 syncrepl_del_nonpresent(
        Operation *op,
@@ -1186,9 +1303,23 @@ syncrepl_del_nonpresent(
 )
 {
        Backend* be = op->o_bd;
-       slap_callback   cb;
+       slap_callback   cb = { NULL };
        SlapReply       rs = {REP_RESULT};
        struct nonpresent_entry *np_list, *np_prev;
+       int rc;
+       Modifications *ml;
+       Modifications *mlnext;
+       Modifications *mod;
+       Modifications *modlist = NULL;
+       Modifications **modtail = &modlist;
+       Attribute       *attr;
+
+       struct berval pdn = { 0, NULL };
+       struct berval org_req_dn = { 0, NULL };
+       struct berval org_req_ndn = { 0, NULL };
+       struct berval org_dn = { 0, NULL };
+       struct berval org_ndn = { 0, NULL };
+       int     org_managedsait;
 
        op->o_req_dn = si->si_base;
        op->o_req_ndn = si->si_base;
@@ -1208,7 +1339,13 @@ syncrepl_del_nonpresent(
        op->ors_filterstr = si->si_filterstr;
 
        op->o_nocaching = 1;
-       be->be_search( op, &rs );
+       op->o_managedsait = 0;
+
+       if ( limits_check( op, &rs ) == 0 ) {
+               be->be_search( op, &rs );
+       }
+
+       op->o_managedsait = 1;
        op->o_nocaching = 0;
 
        if ( op->ors_filter ) filter_free_x( op, op->ors_filter );
@@ -1225,7 +1362,69 @@ syncrepl_del_nonpresent(
                        cb.sc_private = si;
                        op->o_req_dn = *np_prev->npe_name;
                        op->o_req_ndn = *np_prev->npe_nname;
-                       op->o_bd->be_delete( op, &rs );
+                       rc = op->o_bd->be_delete( op, &rs );
+
+                       if ( rc == LDAP_NOT_ALLOWED_ON_NONLEAF ) {
+                               mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
+                               mod->sml_op = LDAP_MOD_REPLACE;
+                               mod->sml_desc = slap_schema.si_ad_objectClass;
+                               mod->sml_type = mod->sml_desc->ad_cname;
+                               mod->sml_bvalues = &gcbva[0];
+                               *modtail = mod;
+                               modtail = &mod->sml_next;
+
+                               mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
+                               mod->sml_op = LDAP_MOD_REPLACE;
+                               mod->sml_desc = slap_schema.si_ad_structuralObjectClass;
+                               mod->sml_type = mod->sml_desc->ad_cname;
+                               mod->sml_bvalues = &gcbva[1];
+                               *modtail = mod;
+                               modtail = &mod->sml_next;
+
+                               op->o_tag = LDAP_REQ_MODIFY;
+                               op->orm_modlist = modlist;
+
+                               rc = be->be_modify( op, &rs );
+
+                               for ( ml = modlist; ml != NULL; ml = mlnext ) {
+                                       mlnext = ml->sml_next;
+                                       free( ml );
+                               }
+                       }
+
+                       org_req_dn = op->o_req_dn;
+                       org_req_ndn = op->o_req_ndn;
+                       org_dn = op->o_dn;
+                       org_ndn = op->o_ndn;
+                       org_managedsait = get_manageDSAit( op );
+                       op->o_dn = op->o_bd->be_rootdn;
+                       op->o_ndn = op->o_bd->be_rootndn;
+                       op->o_managedsait = 1;
+
+                       while ( rs.sr_err == LDAP_SUCCESS &&
+                                       op->o_delete_glue_parent ) {
+                               op->o_delete_glue_parent = 0;
+                               if ( !be_issuffix( op->o_bd, &op->o_req_ndn )) {
+                                       slap_callback cb = { NULL };
+                                       cb.sc_response = slap_null_cb;
+                                       dnParent( &op->o_req_ndn, &pdn );
+                                       op->o_req_dn = pdn;
+                                       op->o_req_ndn = pdn;
+                                       op->o_callback = &cb;
+                                       /* give it a root privil ? */
+                                       op->o_bd->be_delete( op, &rs );
+                               } else {
+                                       break;
+                           }
+                       }
+
+                       op->o_managedsait = org_managedsait;
+                       op->o_dn = org_dn;
+                       op->o_ndn = org_ndn;
+                       op->o_req_dn = org_req_dn;
+                       op->o_req_ndn = org_req_ndn;
+                       op->o_delete_glue_parent = 0;
+
                        ber_bvfree( np_prev->npe_name );
                        ber_bvfree( np_prev->npe_nname );
                        op->o_req_dn.bv_val = NULL;
@@ -1238,11 +1437,6 @@ syncrepl_del_nonpresent(
 }
 
 
-static struct berval gcbva[] = {
-       BER_BVC("top"),
-       BER_BVC("glue")
-};
-
 void
 syncrepl_add_glue(
        Operation* op,
@@ -1250,7 +1444,7 @@ syncrepl_add_glue(
 )
 {
        Backend *be = op->o_bd;
-       slap_callback cb;
+       slap_callback cb = { NULL };
        Attribute       *a;
        int     rc;
        int suffrdns;
@@ -1312,8 +1506,7 @@ syncrepl_add_glue(
                a->a_vals = ch_calloc( 3, sizeof( struct berval ));
                ber_dupbv( &a->a_vals[0], &gcbva[0] );
                ber_dupbv( &a->a_vals[1], &gcbva[1] );
-               a->a_vals[2].bv_len = 0;
-               a->a_vals[2].bv_val = NULL;
+               ber_dupbv( &a->a_vals[2], &gcbva[2] );
 
                a->a_nvals = a->a_vals;
 
@@ -1325,8 +1518,7 @@ syncrepl_add_glue(
 
                a->a_vals = ch_calloc( 2, sizeof( struct berval ));
                ber_dupbv( &a->a_vals[0], &gcbva[1] );
-               a->a_vals[1].bv_len = 0;
-               a->a_vals[1].bv_val = NULL;
+               ber_dupbv( &a->a_vals[1], &gcbva[2] );
 
                a->a_nvals = a->a_vals;
 
@@ -1422,7 +1614,7 @@ syncrepl_updateCookie(
        struct berval slap_syncrepl_dn_bv = BER_BVNULL;
        struct berval slap_syncrepl_cn_bv = BER_BVNULL;
        
-       slap_callback cb;
+       slap_callback cb = { NULL };
        SlapReply       rs = {REP_RESULT};
 
        slap_sync_cookie_free( &si->si_syncCookie, 0 );
@@ -1437,10 +1629,10 @@ syncrepl_updateCookie(
        modtail = &mod->sml_next;
 
        ber_dupbv( &cnbva[0], (struct berval *) &slap_syncrepl_bvc );
-       assert( si->si_id < 1000 );
+       assert( si->si_rid < 1000 );
        cnbva[0].bv_len = snprintf( cnbva[0].bv_val,
                slap_syncrepl_bvc.bv_len,
-               "syncrepl%d", si->si_id );
+               "syncrepl%ld", si->si_rid );
        mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
        mod->sml_op = LDAP_MOD_REPLACE;
        mod->sml_desc = slap_schema.si_ad_cn;
@@ -1490,10 +1682,10 @@ syncrepl_updateCookie(
        e = ( Entry * ) ch_calloc( 1, sizeof( Entry ));
 
        slap_syncrepl_cn_bv.bv_val = syncrepl_cbuf;
-       assert( si->si_id < 1000 );
+       assert( si->si_rid < 1000 );
        slap_syncrepl_cn_bv.bv_len = snprintf( slap_syncrepl_cn_bv.bv_val,
                slap_syncrepl_cn_bvc.bv_len,
-               "cn=syncrepl%d", si->si_id );
+               "cn=syncrepl%ld", si->si_rid );
 
        build_new_dn( &slap_syncrepl_dn_bv, pdn, &slap_syncrepl_cn_bv,
                op->o_tmpmemctx );
@@ -1674,13 +1866,13 @@ nonpresent_callback(
 static int
 null_callback(
        Operation*      op,
-       SlapReply*      rs
-)
+       SlapReply*      rs )
 {
        if ( rs->sr_err != LDAP_SUCCESS &&
                rs->sr_err != LDAP_REFERRAL &&
                rs->sr_err != LDAP_ALREADY_EXISTS &&
-               rs->sr_err != LDAP_NO_SUCH_OBJECT )
+               rs->sr_err != LDAP_NO_SUCH_OBJECT &&
+               rs->sr_err != LDAP_NOT_ALLOWED_ON_NONLEAF )
        {
 #ifdef NEW_LOGGING
                LDAP_LOG( OPERATION, ERR,
@@ -1700,8 +1892,7 @@ slap_create_syncrepl_entry(
        Backend *be,
        struct berval *context_csn,
        struct berval *rdn,
-       struct berval *cn
-)
+       struct berval *cn )
 {
        Entry* e;
 
@@ -1731,6 +1922,73 @@ slap_create_syncrepl_entry(
        return e;
 }
 
+struct berval *
+slap_uuidstr_from_normalized(
+       struct berval* uuidstr,
+       struct berval* normalized,
+       void *ctx )
+{
+       struct berval *new;
+       unsigned char nibble;
+       int i, d = 0;
+
+       if ( normalized == NULL )
+               return NULL;
+
+       if ( normalized->bv_len != 16 ) {
+               return NULL;
+       }
+
+       if ( uuidstr ) {
+               new = uuidstr;
+       } else {
+               new = (struct berval *)sl_malloc( sizeof(struct berval), ctx );
+       }
+
+       new->bv_len = 36;
+
+       if (( new->bv_val = sl_malloc( new->bv_len + 1, ctx )) == NULL) {
+               if ( !uuidstr )
+                       sl_free( new, ctx );
+               return NULL;
+       }
+
+       for ( i = 0; i < 16; i++ ) {
+               if ( i == 4 || i == 6 || i == 8 || i == 10 ) {
+                       new->bv_val[(i<<1)+d] = '-';
+                       d += 1;
+               }
+
+               nibble = (normalized->bv_val[i] >> 4) & 0xF;
+               if ( nibble < 10 ) {
+                       new->bv_val[(i<<1)+d] = nibble + '0';
+               } else {
+                       new->bv_val[(i<<1)+d] = nibble - 10 + 'a';
+               }
+
+               nibble = (normalized->bv_val[i]) & 0xF;
+               if ( nibble < 10 ) {
+                       new->bv_val[(i<<1)+d+1] = nibble + '0';
+               } else {
+                       new->bv_val[(i<<1)+d+1] = nibble - 10 + 'a';
+               }
+       }
+
+       new->bv_val[new->bv_len] = '\0';
+
+       return new;
+}
+
+static int
+syncuuid_cmp( const void* v_uuid1, const void* v_uuid2 )
+{
+       const struct berval *uuid1 = v_uuid1;
+       const struct berval *uuid2 = v_uuid2;
+       int rc = uuid1->bv_len - uuid2->bv_len;
+       if ( rc ) return rc;
+       return ( strcmp( uuid1->bv_val, uuid2->bv_val ) );
+}
+
 static void
 avl_ber_bvfree( void *bv )
 {