]> git.sur5r.net Git - openldap/blobdiff - servers/slapd/syncrepl.c
Import ITS#4158 fixes from HEAD
[openldap] / servers / slapd / syncrepl.c
index 244a7a5031093be57a6d401b331fc06f894123f1..fbdf1d86fc6183c89fa7a1b11ddc7317bc8d0d3b 100644 (file)
@@ -2,7 +2,7 @@
 /* $OpenLDAP$ */
 /* This work is part of OpenLDAP Software <http://www.openldap.org/>.
  *
- * Copyright 2003-2004 The OpenLDAP Foundation.
+ * Copyright 2003-2005 The OpenLDAP Foundation.
  * Portions Copyright 2003 by IBM Corporation.
  * Portions Copyright 2003 by Howard Chu, Symas Corporation.
  * All rights reserved.
@@ -38,7 +38,7 @@ static const struct berval slap_syncrepl_cn_bvc = BER_BVC(CN_STR SYNCREPL_STR);
 
 static int syncuuid_cmp( const void *, const void * );
 static void avl_ber_bvfree( void * );
-static void syncrepl_del_nonpresent( Operation *, syncinfo_t * );
+static void syncrepl_del_nonpresent( Operation *, syncinfo_t *, BerVarray );
 
 /* callback functions */
 static int dn_callback( struct slap_op *, struct slap_rep * );
@@ -47,6 +47,17 @@ static int null_callback( struct slap_op *, struct slap_rep * );
 
 static AttributeDescription *sync_descs[4];
 
+static AttributeName anlist_no_attrs[] = {
+       { BER_BVC( LDAP_NO_ATTRS ) },
+       { BER_BVNULL }
+};
+
+static AttributeName anlist_all_attrs[] = {
+       { BER_BVC( LDAP_ALL_USER_ATTRIBUTES ) },
+       { BER_BVC( LDAP_ALL_OPERATIONAL_ATTRIBUTES ) },
+       { BER_BVNULL }
+};
+
 struct runqueue_s syncrepl_rq;
 
 void
@@ -87,8 +98,15 @@ init_syncrepl(syncinfo_t *si)
                        Debug( LDAP_DEBUG_ANY, "out of memory\n", 0,0,0 );
 #endif
                }
+
+               /* Add Attributes */
+               for ( i = 0; sync_descs[ i ] != NULL; i++ ) {
+                       tmp[ n++ ] = ch_strdup ( sync_descs[i]->ad_cname.bv_val );
+                       tmp[ n ] = NULL;
+               }
+
        } else {
-               tmp = ( char ** ) ch_realloc( si->si_attrs, 5 * sizeof( char * ));
+               tmp = ( char ** ) ch_realloc( si->si_attrs, 3 * sizeof( char * ));
                if ( tmp == NULL ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR, "out of memory\n", 0,0,0 );
@@ -97,15 +115,27 @@ init_syncrepl(syncinfo_t *si)
 #endif
                }
                tmp[ n++ ] = ch_strdup( "*" );
+               tmp[ n++ ] = ch_strdup( "+" );
+               tmp[ n ] = NULL;
        }
        
        si->si_attrs = tmp;
 
-       /* Add Attributes */
-
-       for ( i = 0; sync_descs[ i ] != NULL; i++ ) {
-               si->si_attrs[ n++ ] = ch_strdup ( sync_descs[i]->ad_cname.bv_val );
-               si->si_attrs[ n ] = NULL;
+       for ( n = 0; si->si_exattrs[ n ] != NULL; n++ ) /* empty */;
+       if ( n ) {
+               /* Delete Attributes from exattrs list */
+               for ( i = 0; sync_descs[i] != NULL; i++ ) {
+                       for ( j = 0; si->si_exattrs[j] != NULL; j++ ) {
+                               if ( strcmp( si->si_exattrs[j], sync_descs[i]->ad_cname.bv_val )
+                                       == 0 )
+                               {
+                                       ch_free( si->si_exattrs[j] );
+                                       for ( k = j; si->si_exattrs[k] != NULL; k++ ) {
+                                               si->si_exattrs[k] = si->si_exattrs[k+1];
+                                       }
+                               }
+                       }
+               }
        }
 }
 
@@ -153,12 +183,12 @@ ldap_sync_search(
                ctrls[1] = NULL;
        }
 
-       timeout.tv_sec = si->si_tlimit > 0 ? si->si_tlimit : 1;
+       timeout.tv_sec = si->si_tlimit;
        timeout.tv_usec = 0;
 
        rc = ldap_search_ext( si->si_ld, si->si_base.bv_val, si->si_scope,
                si->si_filterstr.bv_val, si->si_attrs, si->si_attrsonly,
-               ctrls, NULL, si->si_tlimit < 0 ? NULL : &timeout,
+               ctrls, NULL, si->si_tlimit > 0 ? &timeout : NULL,
                si->si_slimit, &msgid );
        ber_free_buf( ber );
 
@@ -178,6 +208,9 @@ do_syncrep1(
        struct sync_cookie      *sc = NULL;
        struct sync_cookie      syncCookie = { NULL, -1, NULL };
        struct berval   *psub;
+#ifdef HAVE_TLS
+       void    *ssl;
+#endif
 
        psub = &si->si_be->be_nsuffix[0];
 
@@ -273,7 +306,7 @@ do_syncrep1(
 
                        /* FIXME (see above comment) */
                        /* if Kerberos credentials cache is not active, retry */
-                       if ( strcmp( si->si_saslmech, "GSSAPI" ) == 0 &&
+                       if ( si->si_saslmech && !strcmp( si->si_saslmech, "GSSAPI" ) &&
                                rc == LDAP_LOCAL_ERROR )
                        {
                                rc = LDAP_SERVER_DOWN;
@@ -302,6 +335,21 @@ do_syncrep1(
                }
        }
 
+       /* Set SSF to strongest of TLS, SASL SSFs */
+       op->o_sasl_ssf = 0;
+       op->o_tls_ssf = 0;
+       op->o_transport_ssf = 0;
+#ifdef HAVE_TLS
+       if ( ldap_get_option( si->si_ld, LDAP_OPT_X_TLS_SSL_CTX, &ssl )
+               == LDAP_SUCCESS && ssl != NULL )
+       {
+               op->o_tls_ssf = ldap_pvt_tls_get_strength( ssl );
+       }
+#endif /* HAVE_TLS */
+       ldap_get_option( si->si_ld, LDAP_OPT_X_SASL_SSF, &op->o_sasl_ssf );
+       op->o_ssf = ( op->o_sasl_ssf > op->o_tls_ssf )
+               ?  op->o_sasl_ssf : op->o_tls_ssf;
+
        /* get syncrepl cookie of shadow replica from subentry */
 
        assert( si->si_rid < 1000 );
@@ -328,7 +376,7 @@ do_syncrep1(
 
                /* read stored cookie if it exists */
                backend_attribute( op, NULL, &op->o_req_ndn,
-                       slap_schema.si_ad_syncreplCookie, &cookie );
+                       slap_schema.si_ad_syncreplCookie, &cookie, ACL_READ );
 
                if ( !cookie ) {
                        /* no stored cookie */
@@ -381,7 +429,7 @@ do_syncrep1(
                        struct berval cookie_bv;
                        /* try to read stored cookie */
                        backend_attribute( op, NULL, &op->o_req_ndn,
-                               slap_schema.si_ad_syncreplCookie, &cookie );
+                               slap_schema.si_ad_syncreplCookie, &cookie, ACL_READ );
                        if ( cookie ) {
                                ber_dupbv( &cookie_bv, &cookie[0] );
                                ber_bvarray_add( &si->si_syncCookie.octet_str, &cookie_bv );
@@ -411,6 +459,8 @@ done:
                }
        }
 
+       slap_sl_free( op->o_req_ndn.bv_val, op->o_tmpmemctx );
+
        return rc;
 }
 
@@ -493,6 +543,10 @@ do_syncrep2(
                  msg != NULL;
                  msg = ldap_next_message( si->si_ld, msg ) )
                {
+                       if ( slapd_shutdown ) {
+                               rc = -2;
+                               goto done;
+                       }
                        switch( ldap_msgtype( msg ) ) {
                        case LDAP_RES_SEARCH_ENTRY:
                                ldap_get_entry_controls( si->si_ld, msg, &rctrls );
@@ -517,8 +571,8 @@ do_syncrep2(
                                }
                                if ( syncrepl_message_to_entry( si, op, msg,
                                        &modlist, &entry, syncstate ) == LDAP_SUCCESS ) {
-                                       rc_efree = syncrepl_entry( si, op, entry, modlist,
-                                                               syncstate, &syncUUID, &syncCookie_req );
+                                       rc_efree = syncrepl_entry( si, op, entry, &modlist,
+                                                               syncstate, &syncUUID, &syncCookie_req, syncCookie.ctxcsn );
                                        if ( syncCookie.octet_str &&
                                                 syncCookie.octet_str[0].bv_val ) {
                                                syncrepl_updateCookie( si, op, psub, &syncCookie );
@@ -530,17 +584,17 @@ do_syncrep2(
                                }
                                if ( rc_efree && entry ) {
                                        entry_free( entry );
-                                       entry = NULL;
                                }
+                               entry = NULL;
                                break;
 
                        case LDAP_RES_SEARCH_REFERENCE:
 #ifdef NEW_LOGGING
                                LDAP_LOG( OPERATION, ERR,
-                                       "do_syncrep2 : reference received\n", 0, 0, 0 );
+                                       "do_syncrep2: reference received error\n", 0, 0, 0 );
 #else
                                Debug( LDAP_DEBUG_ANY,
-                                       "do_syncrep2 : reference received\n", 0, 0, 0 );
+                                       "do_syncrep2: reference received error\n", 0, 0, 0 );
 #endif
                                break;
 
@@ -594,7 +648,7 @@ do_syncrep2(
                                         */
                                        if ( refreshDeletes == 0 && match < 0 &&
                                                 err == LDAP_SUCCESS ) {
-                                               syncrepl_del_nonpresent( op, si );
+                                               syncrepl_del_nonpresent( op, si, NULL );
                                        } else {
                                                avl_free( si->si_presentlist, avl_ber_bvfree );
                                                si->si_presentlist = NULL;
@@ -608,8 +662,6 @@ do_syncrep2(
                                rc = ldap_parse_intermediate( si->si_ld, msg,
                                        &retoid, &retdata, NULL, 0 );
                                if ( !rc && !strcmp( retoid, LDAP_SYNC_INFO ) ) {
-                                       int             si_refreshDelete = 0;
-                                       int             si_refreshPresent = 0;
                                        ber_init2( ber, retdata, LBER_USE_DER );
 
                                        switch ( si_tag = ber_peek_tag( ber, &len )) {
@@ -618,9 +670,12 @@ do_syncrep2(
                                                ber_scanf( ber, "tm", &tag, &cookie );
                                                break;
                                        case LDAP_TAG_SYNC_REFRESH_DELETE:
-                                               si_refreshDelete = 1;
                                        case LDAP_TAG_SYNC_REFRESH_PRESENT:
-                                               si_refreshPresent = 1;
+                                               if ( si_tag == LDAP_TAG_SYNC_REFRESH_DELETE ) {
+                                                       si->si_refreshDelete = 1;
+                                               } else {
+                                                       si->si_refreshPresent = 1;
+                                               }
                                                ber_scanf( ber, "t{", &tag );
                                                if ( ber_peek_tag( ber, &len ) == LDAP_TAG_SYNC_COOKIE )
                                                {
@@ -663,14 +718,20 @@ do_syncrep2(
                                                }
                                                ber_scanf( ber, "[W]", &syncUUIDs );
                                                ber_scanf( ber, "}" );
-                                               for ( i = 0; syncUUIDs[i].bv_val; i++ ) {
-                                                       struct berval *syncuuid_bv;
-                                                       syncuuid_bv = ber_dupbv( NULL, &syncUUIDs[i] );
-                                                       avl_insert( &si->si_presentlist,
-                                                                       (caddr_t) syncuuid_bv,
-                                                                       syncuuid_cmp, avl_dup_error );
+                                               if ( refreshDeletes ) {
+                                                       syncrepl_del_nonpresent( op, si, syncUUIDs );
+                                                       ber_bvarray_free_x( syncUUIDs, op->o_tmpmemctx );
+                                               } else {
+                                                       for ( i = 0; syncUUIDs[i].bv_val; i++ ) {
+                                                               struct berval *syncuuid_bv;
+                                                               syncuuid_bv = ber_dupbv( NULL, &syncUUIDs[i] );
+                                                               slap_sl_free( syncUUIDs[i].bv_val,op->o_tmpmemctx );
+                                                               avl_insert( &si->si_presentlist,
+                                                                               (caddr_t) syncuuid_bv,
+                                                                               syncuuid_cmp, avl_dup_error );
+                                                       }
+                                                       slap_sl_free( syncUUIDs, op->o_tmpmemctx );
                                                }
-                                               ber_memfree_x( syncUUIDs, op->o_tmpmemctx );
                                                break;
                                        default:
 #ifdef NEW_LOGGING
@@ -704,9 +765,9 @@ do_syncrep2(
                                                syncrepl_updateCookie( si, op, psub, &syncCookie);
                                        }
 
-                                       if ( si_refreshPresent == 1 ) {
+                                       if ( si->si_refreshPresent == 1 ) {
                                                if ( match < 0 ) {
-                                                       syncrepl_del_nonpresent( op, si );
+                                                       syncrepl_del_nonpresent( op, si, NULL );
                                                }
                                        } 
 
@@ -791,6 +852,8 @@ do_syncrepl(
        int first = 0;
        int dostop = 0;
        ber_socket_t s;
+       int i, defer = 1;
+       Backend *be;
 
 #ifdef NEW_LOGGING
        LDAP_LOG ( OPERATION, DETAIL1, "do_syncrepl\n", 0, 0, 0 );
@@ -801,28 +864,38 @@ do_syncrepl(
        if ( si == NULL )
                return NULL;
 
+       ldap_pvt_thread_mutex_lock( &si->si_mutex );
+
        switch( abs( si->si_type )) {
        case LDAP_SYNC_REFRESH_ONLY:
        case LDAP_SYNC_REFRESH_AND_PERSIST:
                break;
        default:
+               ldap_pvt_thread_mutex_unlock( &si->si_mutex );
                return NULL;
        }
 
-       if ( slapd_shutdown && si->si_ld ) {
-               ldap_get_option( si->si_ld, LDAP_OPT_DESC, &s );
-               connection_client_stop( s );
-               ldap_unbind( si->si_ld );
-               si->si_ld = NULL;
+       if ( slapd_shutdown ) {
+               if ( si->si_ld ) {
+                       ldap_get_option( si->si_ld, LDAP_OPT_DESC, &s );
+                       connection_client_stop( s );
+                       ldap_unbind( si->si_ld );
+                       si->si_ld = NULL;
+               }
+               ldap_pvt_thread_mutex_unlock( &si->si_mutex );
                return NULL;
        }
 
        connection_fake_init( &conn, &op, ctx );
 
+       /* use global malloc for now */
+       op.o_tmpmemctx = NULL;
+       op.o_tmpmfuncs = &ch_mfuncs;
+
        op.o_dn = si->si_updatedn;
        op.o_ndn = si->si_updatedn;
        op.o_managedsait = 1;
-       op.o_bd = si->si_be;
+       op.o_bd = be = si->si_be;
 
        op.o_sync_state.ctxcsn = NULL;
        op.o_sync_state.sid = -1;
@@ -834,6 +907,8 @@ do_syncrepl(
        /* Establish session, do search */
        if ( !si->si_ld ) {
                first = 1;
+               si->si_refreshDelete = 0;
+               si->si_refreshPresent = 0;
                rc = do_syncrep1( &op, si );
        }
 
@@ -849,11 +924,10 @@ do_syncrepl(
                         */
                        if ( rc == LDAP_SUCCESS ) {
                                if ( first ) {
-                                       rc = connection_client_setup( s, do_syncrepl,
-                                               arg );
+                                       rc = connection_client_setup( s, do_syncrepl, arg );
                                } else {
                                        connection_client_enable( s );
-                               }
+                               } 
                        } else if ( !first ) {
                                dostop = 1;
                        }
@@ -869,6 +943,7 @@ do_syncrepl(
         * 4) for Persist and Success, reschedule to defer
         */
        ldap_pvt_thread_mutex_lock( &syncrepl_rq.rq_mutex );
+
        if ( ldap_pvt_runqueue_isrunning( &syncrepl_rq, rtask )) {
                ldap_pvt_runqueue_stoptask( &syncrepl_rq, rtask );
        }
@@ -877,18 +952,39 @@ do_syncrepl(
                connection_client_stop( s );
        }
 
-       if ( rc && rc != LDAP_SERVER_DOWN ) {
-               ldap_pvt_runqueue_remove( &syncrepl_rq, rtask );
+       if ( rc == LDAP_SUCCESS ) {
+               if ( si->si_type == LDAP_SYNC_REFRESH_ONLY ) {
+                       defer = 0;
+               }
+               rtask->interval.tv_sec = si->si_interval;
+               ldap_pvt_runqueue_resched( &syncrepl_rq, rtask, defer );
+               if ( si->si_retrynum ) {
+                       for ( i = 0; si->si_retrynum_init[i] != -2; i++ ) {
+                               si->si_retrynum[i] = si->si_retrynum_init[i];
+                       }
+                       si->si_retrynum[i] = -2;
+               }
        } else {
-               if ( rc == LDAP_SERVER_DOWN ||
-                       si->si_type == LDAP_SYNC_REFRESH_ONLY ) {
-                       rc = 0;
-               } else {
-                       rc = 1;
+               for ( i = 0; si->si_retrynum && si->si_retrynum[i] <= 0; i++ ) {
+                       if ( si->si_retrynum[i] == -1  || si->si_retrynum[i] == -2 )
+                               break;
+               }
+
+               if ( !si->si_retrynum || si->si_retrynum[i] == -2 ) {
+                       ldap_pvt_runqueue_remove( &syncrepl_rq, rtask );
+                       LDAP_STAILQ_REMOVE( &be->be_syncinfo, si, syncinfo_s, si_next );
+                       syncinfo_free( si );
+               } else if ( si->si_retrynum[i] >= -1 ) {
+                       if ( si->si_retrynum[i] > 0 )
+                               si->si_retrynum[i]--;
+                       rtask->interval.tv_sec = si->si_retryinterval[i];
+                       ldap_pvt_runqueue_resched( &syncrepl_rq, rtask, 0 );
+                       slap_wake_listener();
                }
-               ldap_pvt_runqueue_resched( &syncrepl_rq, rtask, rc );
        }
+       
        ldap_pvt_thread_mutex_unlock( &syncrepl_rq.rq_mutex );
+       ldap_pvt_thread_mutex_unlock( &si->si_mutex );
 
        return NULL;
 }
@@ -950,8 +1046,9 @@ syncrepl_message_to_entry(
        sl_free( ndn.bv_val, op->o_tmpmemctx );
        sl_free( dn.bv_val, op->o_tmpmemctx );
 
-       if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE )
-       {
+       if ( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_DELETE ) {
+               if ( entry )
+                       *entry = NULL;
                return LDAP_SUCCESS;
        }
 
@@ -992,6 +1089,8 @@ syncrepl_message_to_entry(
                Debug( LDAP_DEBUG_ANY, "syncrepl_message_to_entry: no attributes\n",
                                0, 0, 0 );
 #endif
+               rc = -1;
+               goto done;
        }
 
        rc = slap_mods_check( *modlist, 1, &text, txtbuf, textlen, NULL );
@@ -1006,6 +1105,31 @@ syncrepl_message_to_entry(
 #endif
                goto done;
        }
+
+       /* Strip out dynamically generated attrs */
+       for ( modtail = modlist; *modtail ; ) {
+               mod = *modtail;
+               if ( mod->sml_desc->ad_type->sat_flags & SLAP_AT_DYNAMIC ) {
+                       *modtail = mod->sml_next;
+                       slap_mod_free( &mod->sml_mod, 0 );
+                       ch_free( mod );
+               } else {
+                       modtail = &mod->sml_next;
+               }
+       }
+
+       /* Strip out attrs in exattrs list */
+       for ( modtail = modlist; *modtail ; ) {
+               mod = *modtail;
+               if ( ldap_charray_inlist( si->si_exattrs,
+                                       mod->sml_desc->ad_type->sat_cname.bv_val )) {
+                       *modtail = mod->sml_next;
+                       slap_mod_free( &mod->sml_mod, 0 );
+                       ch_free( mod );
+               } else {
+                       modtail = &mod->sml_next;
+               }
+       }
        
        rc = slap_mods2entry( *modlist, &e, 1, 1, &text, txtbuf, textlen);
        if( rc != LDAP_SUCCESS ) {
@@ -1021,22 +1145,55 @@ syncrepl_message_to_entry(
 done:
        ber_free ( ber, 0 );
        if ( rc != LDAP_SUCCESS ) {
-               entry_free( e );
-               e = NULL;
+               if ( e ) {
+                       entry_free( e );
+                       *entry = e = NULL;
+               }
        }
 
        return rc;
 }
 
+static struct berval generic_filterstr = BER_BVC("(objectclass=*)");
+
+/* During a refresh, we may get an LDAP_SYNC_ADD for an already existing
+ * entry if a previous refresh was interrupted before sending us a new
+ * context state. We try to compare the new entry to the existing entry
+ * and ignore the new entry if they are the same.
+ *
+ * Also, we may get an update where the entryDN has changed, due to
+ * a ModDn on the provider. We detect this as well, so we can issue
+ * the corresponding operation locally.
+ *
+ * In the case of a modify, we get a list of all the attributes
+ * in the original entry. Rather than deleting the entry and re-adding it,
+ * we issue a Modify request that deletes all the attributes and adds all
+ * the new ones. This avoids the issue of trying to delete/add a non-leaf
+ * entry.
+ *
+ * We don't try to otherwise distinguish ModDN from Modify; in the case of
+ * a ModDN we will issue both operations on the local database.
+ */
+typedef struct dninfo {
+       Entry *new_entry;
+       struct berval dn;
+       struct berval ndn;
+       int renamed;    /* Was an existing entry renamed? */
+       int wasChanged; /* are the attributes changed? */
+       int attrs;      /* how many attribute types are in the ads list */
+       AttributeDescription **ads;
+} dninfo;
+
 int
 syncrepl_entry(
        syncinfo_t* si,
        Operation *op,
-       Entry* e,
-       Modifications* modlist,
+       Entry* entry,
+       Modifications** modlist,
        int syncstate,
        struct berval* syncUUID,
-       struct sync_cookie* syncCookie_req
+       struct sync_cookie* syncCookie_req,
+       struct berval* syncCSN
 )
 {
        Backend *be = op->o_bd;
@@ -1045,7 +1202,10 @@ syncrepl_entry(
        struct berval   syncUUID_strrep = BER_BVNULL;
        struct berval   uuid_bv = BER_BVNULL;
 
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_search = {REP_RESULT};
+       SlapReply       rs_delete = {REP_RESULT};
+       SlapReply       rs_add = {REP_RESULT};
+       SlapReply       rs_modify = {REP_RESULT};
        Filter f = {0};
        AttributeAssertion ava = {0};
        int rc = LDAP_SUCCESS;
@@ -1058,16 +1218,24 @@ syncrepl_entry(
        struct berval org_dn = BER_BVNULL;
        struct berval org_ndn = BER_BVNULL;
        int     org_managedsait;
+       dninfo dni = {0};
+       int retry = 1;
 
        if (( syncstate == LDAP_SYNC_PRESENT || syncstate == LDAP_SYNC_ADD ))
        {
-               syncuuid_bv = ber_dupbv( NULL, syncUUID );
-               avl_insert( &si->si_presentlist, (caddr_t) syncuuid_bv,
-                       syncuuid_cmp, avl_dup_error );
+               if (!si->si_refreshPresent) {
+                       syncuuid_bv = ber_dupbv( NULL, syncUUID );
+                       avl_insert( &si->si_presentlist, (caddr_t) syncuuid_bv,
+                               syncuuid_cmp, avl_dup_error );
+               }
        }
 
        if ( syncstate == LDAP_SYNC_PRESENT ) {
-               return e ? 1 : 0;
+               return 0;
+       } else if ( syncstate != LDAP_SYNC_DELETE ) {
+               if ( entry == NULL ) {
+                       return 0;
+               }
        }
 
        f.f_choice = LDAP_FILTER_EQUALITY;
@@ -1088,173 +1256,222 @@ syncrepl_entry(
        op->o_tag = LDAP_REQ_SEARCH;
        op->ors_scope = LDAP_SCOPE_SUBTREE;
 
-       /* get syncrepl cookie of shadow replica from subentry */
+       /* get the entry for this UUID */
        op->o_req_dn = si->si_base;
        op->o_req_ndn = si->si_base;
 
+       op->o_time = slap_get_time();
+       op->ors_tlimit = SLAP_NO_LIMIT;
+       op->ors_slimit = 1;
+       op->ors_attrs = anlist_all_attrs;
+       op->ors_attrsonly = 0;
+
        /* set callback function */
        op->o_callback = &cb;
        cb.sc_response = dn_callback;
-       cb.sc_private = si;
-
-       si->si_syncUUID_ndn.bv_val = NULL;
+       cb.sc_private = &dni;
+       dni.new_entry = entry;
 
-       if ( limits_check( op, &rs ) == 0 ) {
-               rc = be->be_search( op, &rs );
+       if ( limits_check( op, &rs_search ) == 0 ) {
+               rc = be->be_search( op, &rs_search );
        }
 
        if ( op->ors_filterstr.bv_val ) {
                sl_free( op->ors_filterstr.bv_val, op->o_tmpmemctx );
        }
 
-       cb.sc_response = null_callback;
-       cb.sc_private = si;
-
-       if ( rc == LDAP_SUCCESS && si->si_syncUUID_ndn.bv_val )
-       {
-               char *subseq_ptr;
-
-               if ( syncstate != LDAP_SYNC_DELETE ) {
-                       op->o_no_psearch = 1;
-               }
-
-               ber_dupbv( &op->o_sync_csn, syncCookie_req->ctxcsn );
-               if ( op->o_sync_csn.bv_val ) {
-                       subseq_ptr = strstr( op->o_sync_csn.bv_val, "#0000" );
-                       subseq_ptr += 4;
-                       *subseq_ptr = '1';
-               }
-               
-               op->o_req_dn = si->si_syncUUID_ndn;
-               op->o_req_ndn = si->si_syncUUID_ndn;
-               op->o_tag = LDAP_REQ_DELETE;
-               rc = be->be_delete( op, &rs );
-
-               org_req_dn = op->o_req_dn;
-               org_req_ndn = op->o_req_ndn;
-               org_dn = op->o_dn;
-               org_ndn = op->o_ndn;
-               org_managedsait = get_manageDSAit( op );
-               op->o_dn = op->o_bd->be_rootdn;
-               op->o_ndn = op->o_bd->be_rootndn;
-               op->o_managedsait = 1;
-
-               while ( rs.sr_err == LDAP_SUCCESS &&
-                               op->o_delete_glue_parent ) {
-                       op->o_delete_glue_parent = 0;
-                       if ( !be_issuffix( op->o_bd, &op->o_req_ndn )) {
-                               slap_callback cb = { NULL };
-                               cb.sc_response = slap_null_cb;
-                               dnParent( &op->o_req_ndn, &pdn );
-                               op->o_req_dn = pdn;
-                               op->o_req_ndn = pdn;
-                               op->o_callback = &cb;
-                               op->o_bd->be_delete( op, &rs );
-                       } else {
-                               break;
-                   }
-               }
-
-               op->o_managedsait = org_managedsait;
-               op->o_dn = org_dn;
-               op->o_ndn = org_ndn;
-               op->o_req_dn = org_req_dn;
-               op->o_req_ndn = org_req_ndn;
-               op->o_delete_glue_parent = 0;
+       org_req_dn = op->o_req_dn;
+       org_req_ndn = op->o_req_ndn;
+       org_dn = op->o_dn;
+       org_ndn = op->o_ndn;
+       org_managedsait = get_manageDSAit( op );
+       op->o_dn = op->o_bd->be_rootdn;
+       op->o_ndn = op->o_bd->be_rootndn;
+       op->o_managedsait = 1;
 
-               op->o_no_psearch = 0;
+       if ( syncstate != LDAP_SYNC_DELETE ) {
+               attr_delete( &entry->e_attrs, slap_schema.si_ad_entryUUID );
+               attr_merge_one( entry, slap_schema.si_ad_entryUUID,
+                       &syncUUID_strrep, syncUUID );
        }
 
        switch ( syncstate ) {
        case LDAP_SYNC_ADD:
        case LDAP_SYNC_MODIFY:
-               if ( rc == LDAP_SUCCESS ||
-                        rc == LDAP_REFERRAL ||
-                        rc == LDAP_NO_SUCH_OBJECT ||
-                        rc == LDAP_NOT_ALLOWED_ON_NONLEAF )
-               {
-                       attr_delete( &e->e_attrs, slap_schema.si_ad_entryUUID );
-                       attr_merge_one( e, slap_schema.si_ad_entryUUID,
-                               syncUUID, &ava.aa_value );
-
+retry_add:;
+               if ( BER_BVISNULL( &dni.dn )) {
                        op->o_tag = LDAP_REQ_ADD;
-                       op->ora_e = e;
-                       op->o_req_dn = e->e_name;
-                       op->o_req_ndn = e->e_nname;
-                       rc = be->be_add( op, &rs );
-
-                       if ( rc != LDAP_SUCCESS ) {
-                               if ( rc == LDAP_ALREADY_EXISTS ) {
-                                       Modifications *mod;
-                                       Modifications *modtail;
+                       op->ora_e = entry;
+                       op->o_req_dn = entry->e_name;
+                       op->o_req_ndn = entry->e_nname;
+
+                       rc = be->be_add( op, &rs_add );
+                       switch( rs_add.sr_err ) {
+                       case LDAP_SUCCESS:
+                               be_entry_release_w( op, entry );
+                               ret = 0;
+                               break;
 
-                                       for ( mod = modlist; mod != NULL; mod = mod->sml_next ) {
-                                               modtail = mod;
-                                       }
+                       case LDAP_REFERRAL:
+                       /* we assume that LDAP_NO_SUCH_OBJECT is returned
+                        * only if the suffix entry is not present */
+                       case LDAP_NO_SUCH_OBJECT:
+                               syncrepl_add_glue( op, entry );
+                               ret = 0;
+                               break;
 
-                                       mod = (Modifications *)ch_calloc(1, sizeof(Modifications));
-                                       ber_dupbv( &uuid_bv, syncUUID );
-                                       mod->sml_op = LDAP_MOD_REPLACE;
-                                       mod->sml_desc = slap_schema.si_ad_entryUUID;
-                                       mod->sml_type = mod->sml_desc->ad_cname;
-                                       ber_bvarray_add( &mod->sml_values, &uuid_bv );
-                                       modtail->sml_next = mod;
-                                       
-                                       op->o_tag = LDAP_REQ_MODIFY;
-                                       op->orm_modlist = modlist;
-                                       op->o_req_dn = e->e_name;
-                                       op->o_req_ndn = e->e_nname;
-
-                                       rc = be->be_modify( op, &rs );
-                                       if ( rc != LDAP_SUCCESS ) {
-#ifdef NEW_LOGGING
-                                               LDAP_LOG( OPERATION, ERR,
-                                                       "syncrepl_entry : be_modify failed (%d)\n",
-                                                       rc, 0, 0 );
-#else
-                                               Debug( LDAP_DEBUG_ANY,
-                                                       "syncrepl_entry : be_modify failed (%d)\n",
-                                                       rc, 0, 0 );
-#endif
-                                       }
-                                       ret = 1;
-                                       goto done;
-                               } else if ( rc == LDAP_REFERRAL || rc == LDAP_NO_SUCH_OBJECT ) {
-                                       syncrepl_add_glue( op, e );
-                                       ret = 0;
-                                       goto done;
-                               } else {
-#ifdef NEW_LOGGING
-                                       LDAP_LOG( OPERATION, ERR,
-                                               "syncrepl_entry : be_add failed (%d)\n",
-                                               rc, 0, 0 );
-#else
-                                       Debug( LDAP_DEBUG_ANY,
-                                               "syncrepl_entry : be_add failed (%d)\n",
-                                               rc, 0, 0 );
-#endif
-                                       ret = 1;
-                                       goto done;
+                       /* if an entry was added via syncrepl_add_glue(),
+                        * it likely has no entryUUID, so the previous
+                        * be_search() doesn't find it.  In this case,
+                        * give syncrepl a chance to modify it. Also
+                        * allow for entries that were recreated with the
+                        * same DN but a different entryUUID.
+                        */
+                       case LDAP_ALREADY_EXISTS:
+                               if ( retry ) {
+                                       Operation   op2 = *op;
+                                       SlapReply   rs2 = { 0 };
+                                       slap_callback   cb2 = { 0 };
+                                       op2.o_tag = LDAP_REQ_SEARCH;
+                                       op2.o_req_dn = entry->e_name;
+                                       op2.o_req_ndn = entry->e_nname;
+                                       op2.ors_scope = LDAP_SCOPE_BASE;
+                                       op2.ors_attrs = anlist_all_attrs;
+                                       op2.ors_attrsonly = 0;
+                                       op2.ors_limit = NULL;
+                                       op2.ors_slimit = 1;
+                                       op2.ors_tlimit = SLAP_NO_LIMIT;
+                                       f.f_choice = LDAP_FILTER_PRESENT;
+                                       f.f_desc = slap_schema.si_ad_objectClass;
+                                       op2.ors_filter = &f;
+                                       op2.ors_filterstr = generic_filterstr;
+
+                                       op2.o_callback = &cb2;
+                                       cb2.sc_response = dn_callback;
+                                       cb2.sc_private = &dni;
+
+                                       be->be_search( &op2, &rs2 );
+                                       retry = 0;
+                                       goto retry_add;
                                }
+                               /* FALLTHRU */
+
+                       default:
+                               ret = 1;
+                               break;
+                       }
+                       goto done;
+               }
+               /* FALLTHRU */
+               op->o_req_dn = dni.dn;
+               op->o_req_ndn = dni.ndn;
+               if ( dni.renamed ) {
+                       struct berval noldp, newp, nnewp;
+                       op->o_tag = LDAP_REQ_MODRDN;
+                       dnRdn( &entry->e_name, &op->orr_newrdn );
+                       dnRdn( &entry->e_nname, &op->orr_nnewrdn );
+                       dnParent( &dni.ndn, &noldp );
+                       dnParent( &entry->e_nname, &nnewp );
+                       if ( !dn_match( &noldp, &newp )) {
+                               dnParent( &entry->e_name, &newp );
+                               op->orr_newSup = &newp;
+                               op->orr_nnewSup = &nnewp;
+                       }
+                       op->orr_deleteoldrdn = 0;
+                       rc = be->be_modrdn( op, &rs_modify );
+                       if ( rs_modify.sr_err == LDAP_SUCCESS ) {
+                               op->o_req_dn = entry->e_name;
+                               op->o_req_ndn = entry->e_nname;
                        } else {
-                               be_entry_release_w( op, e );
-                               ret = 0;
+                               ret = 1;
                                goto done;
                        }
-               } else {
-#ifdef NEW_LOGGING
-                       LDAP_LOG( OPERATION, ERR,
-                               "syncrepl_entry : be_search failed (%d)\n", rc, 0, 0 );
-#else
-                       Debug( LDAP_DEBUG_ANY,
-                               "syncrepl_entry : be_search failed (%d)\n", rc, 0, 0 );
-#endif
-                       ret = 1;
-                       goto done;
                }
+               if ( dni.wasChanged ) {
+                       Modifications *mod, *modhead = NULL;
+                       Modifications *modtail = NULL;
+                       int i;
+                       op->o_tag = LDAP_REQ_MODIFY;
+                       assert( *modlist );
+                       /* Delete all the old attrs */
+                       for ( i=0; i<dni.attrs; i++) {
+                               mod = ch_malloc( sizeof(Modifications));
+                               mod->sml_op = LDAP_MOD_DELETE;
+                               mod->sml_desc = dni.ads[i];
+                               mod->sml_type =mod->sml_desc->ad_cname;
+                               mod->sml_values = NULL;
+                               mod->sml_nvalues = NULL;
+                               if ( !modhead ) modhead = mod;
+                               if ( modtail ) {
+                                       modtail->sml_next = mod;
+                               }
+                               modtail = mod;
+                       }
 
+                       /* Append passed in list to ours */
+                       if ( modtail ) {
+                               modtail->sml_next = *modlist;
+                               *modlist = modhead;
+                       } else {
+                               mod = *modlist;
+                       }
+                       /* Find end of this list */
+                       for ( ; mod != NULL; mod = mod->sml_next ) {
+                               modtail = mod;
+                       }
+                       mod = (Modifications *)ch_calloc(1, sizeof(Modifications));
+                       mod->sml_op = LDAP_MOD_REPLACE;
+                       mod->sml_desc = slap_schema.si_ad_entryUUID;
+                       mod->sml_type = mod->sml_desc->ad_cname;
+                       ber_dupbv( &uuid_bv, &syncUUID_strrep );
+                       ber_bvarray_add( &mod->sml_values, &uuid_bv );
+                       ber_dupbv( &uuid_bv, syncUUID );
+                       ber_bvarray_add( &mod->sml_nvalues, &uuid_bv );
+                       modtail->sml_next = mod;
+                       op->o_tag = LDAP_REQ_MODIFY;
+                       op->orm_modlist = *modlist;
+                       rc = be->be_modify( op, &rs_modify );
+                       if ( rs_modify.sr_err != LDAP_SUCCESS ) {
+                               Debug( LDAP_DEBUG_ANY,
+                                       "syncrepl_entry : be_modify failed (%d)\n",
+                                       rs_modify.sr_err, 0, 0 );
+                       }
+               }
+               ret = 1;
+               goto done;
        case LDAP_SYNC_DELETE :
-               /* Already deleted */
+               if ( !BER_BVISNULL( &dni.dn )) {
+                       op->o_req_dn = dni.dn;
+                       op->o_req_ndn = dni.ndn;
+                       op->o_tag = LDAP_REQ_DELETE;
+                       rc = be->be_delete( op, &rs_delete );
+                       while ( rs_delete.sr_err == LDAP_SUCCESS
+                               && op->o_delete_glue_parent ) {
+                               op->o_delete_glue_parent = 0;
+                               if ( !be_issuffix( op->o_bd, &op->o_req_ndn )) {
+                                       slap_callback cb = { NULL };
+                                       cb.sc_response = slap_null_cb;
+                                       dnParent( &op->o_req_ndn, &pdn );
+                                       op->o_req_dn = pdn;
+                                       op->o_req_ndn = pdn;
+                                       op->o_callback = &cb;
+                                       op->o_bd->be_delete( op, &rs_delete );
+                               } else {
+                                       break;
+                               }
+                       }
+               }
                ret = 0;
                goto done;
 
@@ -1272,11 +1489,18 @@ syncrepl_entry(
 
 done :
 
-       if ( syncUUID_strrep.bv_val ) {
-               ber_memfree_x( syncUUID_strrep.bv_val, op->o_tmpmemctx );
+       if ( !BER_BVISNULL( &syncUUID_strrep ) ) {
+               slap_sl_free( syncUUID_strrep.bv_val, op->o_tmpmemctx );
+               BER_BVZERO( &syncUUID_strrep );
+       }
+       if ( dni.ads ) {
+               op->o_tmpfree( dni.ads, op->o_tmpmemctx );
+       }
+       if ( !BER_BVISNULL( &dni.ndn ) ) {
+               op->o_tmpfree( dni.ndn.bv_val, op->o_tmpmemctx );
        }
-       if ( si->si_syncUUID_ndn.bv_val ) {
-               ber_memfree_x( si->si_syncUUID_ndn.bv_val, op->o_tmpmemctx );
+       if ( !BER_BVISNULL( &dni.dn ) ) {
+               op->o_tmpfree( dni.dn.bv_val, op->o_tmpmemctx );
        }
        return ret;
 }
@@ -1287,23 +1511,28 @@ static struct berval gcbva[] = {
        BER_BVNULL
 };
 
+#define NP_DELETE_ONE  2
+
 static void
 syncrepl_del_nonpresent(
        Operation *op,
-       syncinfo_t *si
+       syncinfo_t *si,
+       BerVarray uuids
 )
 {
        Backend* be = op->o_bd;
        slap_callback   cb = { NULL };
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_search = {REP_RESULT};
+       SlapReply       rs_delete = {REP_RESULT};
+       SlapReply       rs_modify = {REP_RESULT};
        struct nonpresent_entry *np_list, *np_prev;
        int rc;
        Modifications *ml;
        Modifications *mlnext;
        Modifications *mod;
        Modifications *modlist = NULL;
-       Modifications **modtail = &modlist;
-       Attribute       *attr;
+       Modifications **modtail;
+       AttributeName   an[2];
 
        struct berval pdn = BER_BVNULL;
        struct berval org_req_dn = BER_BVNULL;
@@ -1322,25 +1551,53 @@ syncrepl_del_nonpresent(
        op->o_tag = LDAP_REQ_SEARCH;
        op->ors_scope = si->si_scope;
        op->ors_deref = LDAP_DEREF_NEVER;
-       op->ors_slimit = 0;
-       op->ors_tlimit = 0;
-       op->ors_attrsonly = 0;
-       op->ors_attrs = NULL;
-       op->ors_filter = str2filter_x( op, si->si_filterstr.bv_val );
-       op->ors_filterstr = si->si_filterstr;
-
-       op->o_nocaching = 1;
-       op->o_managedsait = 0;
-
-       if ( limits_check( op, &rs ) == 0 ) {
-               be->be_search( op, &rs );
+       op->o_time = slap_get_time();
+       op->ors_tlimit = SLAP_NO_LIMIT;
+
+       if ( uuids ) {
+               Filter uf;
+               AttributeAssertion eq;
+               int i;
+               op->ors_attrsonly = 1;
+               op->ors_attrs = anlist_no_attrs;
+               op->ors_limit = NULL;
+               op->ors_filter = &uf;
+               op->o_managedsait = 1;
+               uf.f_ava = &eq;
+               uf.f_av_desc = slap_schema.si_ad_entryUUID;
+               uf.f_next = NULL;
+               uf.f_choice = LDAP_FILTER_EQUALITY;
+               si->si_refreshDelete |= NP_DELETE_ONE;
+               for (i=0; uuids[i].bv_val; i++) {
+                       op->ors_slimit = 1;
+                       uf.f_av_value = uuids[i];
+                       rc = be->be_search( op, &rs_search );
+               }
+               si->si_refreshDelete ^= NP_DELETE_ONE;
+       } else {
+               memset( &an[0], 0, 2 * sizeof( AttributeName ) );
+               an[0].an_name = slap_schema.si_ad_entryUUID->ad_cname;
+               an[0].an_desc = slap_schema.si_ad_entryUUID;
+               op->ors_attrs = an;
+               op->ors_slimit = SLAP_NO_LIMIT;
+               op->ors_attrsonly = 0;
+               op->ors_filter = str2filter_x( op, si->si_filterstr.bv_val );
+               op->ors_filterstr = si->si_filterstr;
+               op->o_nocaching = 1;
+               op->o_managedsait = 0;
+
+               if ( limits_check( op, &rs_search ) == 0 ) {
+                       rc = be->be_search( op, &rs_search );
+               }
+               if ( op->ors_filter ) filter_free_x( op, op->ors_filter );
        }
 
        op->o_managedsait = 1;
        op->o_nocaching = 0;
 
-       if ( op->ors_filter ) filter_free_x( op, op->ors_filter );
-
        if ( !LDAP_LIST_EMPTY( &si->si_nonpresentlist ) ) {
                np_list = LDAP_LIST_FIRST( &si->si_nonpresentlist );
                while ( np_list != NULL ) {
@@ -1353,9 +1610,10 @@ syncrepl_del_nonpresent(
                        cb.sc_private = si;
                        op->o_req_dn = *np_prev->npe_name;
                        op->o_req_ndn = *np_prev->npe_nname;
-                       rc = op->o_bd->be_delete( op, &rs );
+                       rc = op->o_bd->be_delete( op, &rs_delete );
 
-                       if ( rc == LDAP_NOT_ALLOWED_ON_NONLEAF ) {
+                       if ( rs_delete.sr_err == LDAP_NOT_ALLOWED_ON_NONLEAF ) {
+                               modtail = &modlist;
                                mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
                                mod->sml_op = LDAP_MOD_REPLACE;
                                mod->sml_desc = slap_schema.si_ad_objectClass;
@@ -1375,7 +1633,7 @@ syncrepl_del_nonpresent(
                                op->o_tag = LDAP_REQ_MODIFY;
                                op->orm_modlist = modlist;
 
-                               rc = be->be_modify( op, &rs );
+                               rc = be->be_modify( op, &rs_modify );
 
                                for ( ml = modlist; ml != NULL; ml = mlnext ) {
                                        mlnext = ml->sml_next;
@@ -1392,7 +1650,7 @@ syncrepl_del_nonpresent(
                        op->o_ndn = op->o_bd->be_rootndn;
                        op->o_managedsait = 1;
 
-                       while ( rs.sr_err == LDAP_SUCCESS &&
+                       while ( rs_delete.sr_err == LDAP_SUCCESS &&
                                        op->o_delete_glue_parent ) {
                                op->o_delete_glue_parent = 0;
                                if ( !be_issuffix( op->o_bd, &op->o_req_ndn )) {
@@ -1403,7 +1661,7 @@ syncrepl_del_nonpresent(
                                        op->o_req_ndn = pdn;
                                        op->o_callback = &cb;
                                        /* give it a root privil ? */
-                                       op->o_bd->be_delete( op, &rs );
+                                       op->o_bd->be_delete( op, &rs_delete );
                                } else {
                                        break;
                            }
@@ -1443,7 +1701,7 @@ syncrepl_add_glue(
        struct berval dn = {0, NULL};
        struct berval ndn = {0, NULL};
        Entry   *glue;
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_add = {REP_RESULT};
        char    *ptr, *comma;
 
        op->o_tag = LDAP_REQ_ADD;
@@ -1519,8 +1777,8 @@ syncrepl_add_glue(
                op->o_req_dn = glue->e_name;
                op->o_req_ndn = glue->e_nname;
                op->ora_e = glue;
-               rc = be->be_add ( op, &rs );
-               if ( rc == LDAP_SUCCESS ) {
+               rc = be->be_add ( op, &rs_add );
+               if ( rs_add.sr_err == LDAP_SUCCESS ) {
                        be_entry_release_w( op, glue );
                } else {
                /* incl. ALREADY EXIST */
@@ -1547,8 +1805,8 @@ syncrepl_add_glue(
        op->o_req_dn = e->e_name;
        op->o_req_ndn = e->e_nname;
        op->ora_e = e;
-       rc = be->be_add ( op, &rs );
-       if ( rc == LDAP_SUCCESS ) {
+       rc = be->be_add ( op, &rs_add );
+       if ( rs_add.sr_err == LDAP_SUCCESS ) {
                be_entry_release_w( op, e );
        } else {
                entry_free( e );
@@ -1606,7 +1864,8 @@ syncrepl_updateCookie(
        struct berval slap_syncrepl_cn_bv = BER_BVNULL;
        
        slap_callback cb = { NULL };
-       SlapReply       rs = {REP_RESULT};
+       SlapReply       rs_add = {REP_RESULT};
+       SlapReply       rs_modify = {REP_RESULT};
 
        slap_sync_cookie_free( &si->si_syncCookie, 0 );
        slap_dup_sync_cookie( &si->si_syncCookie, syncCookie );
@@ -1632,21 +1891,24 @@ syncrepl_updateCookie(
        *modtail = mod;
        modtail = &mod->sml_next;
 
-       if ( scbva[0].bv_val ) ch_free( scbva[0].bv_val );
-       ber_dupbv( &scbva[0], &si->si_syncCookie.octet_str[0] );
        mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
        mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_syncreplCookie;
+       mod->sml_desc = slap_schema.si_ad_subtreeSpecification;
        mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_values = scbva;
+       mod->sml_values = ssbva;
        *modtail = mod;
        modtail = &mod->sml_next;
 
+       /* Keep this last, so we can avoid touching the previous
+        * attributes unnecessarily.
+        */
+       if ( scbva[0].bv_val ) ch_free( scbva[0].bv_val );
+       ber_dupbv( &scbva[0], &si->si_syncCookie.octet_str[0] );
        mod = (Modifications *) ch_calloc( 1, sizeof( Modifications ));
        mod->sml_op = LDAP_MOD_REPLACE;
-       mod->sml_desc = slap_schema.si_ad_subtreeSpecification;
+       mod->sml_desc = slap_schema.si_ad_syncreplCookie;
        mod->sml_type = mod->sml_desc->ad_cname;
-       mod->sml_values = ssbva;
+       mod->sml_values = scbva;
        *modtail = mod;
        modtail = &mod->sml_next;
 
@@ -1654,7 +1916,7 @@ syncrepl_updateCookie(
 
        op->o_tag = LDAP_REQ_ADD;
        rc = slap_mods_opattrs( op, modlist, modtail,
-                                                        &text,txtbuf, textlen );
+                &text, txtbuf, textlen, 0 );
 
        for ( ml = modlist; ml != NULL; ml = ml->sml_next ) {
                ml->sml_op = LDAP_MOD_REPLACE;
@@ -1711,20 +1973,21 @@ syncrepl_updateCookie(
        /* update persistent cookie */
 update_cookie_retry:
        op->o_tag = LDAP_REQ_MODIFY;
-       op->orm_modlist = modlist;
-       rc = be->be_modify( op, &rs );
+       /* Just modify the cookie value, not the entire entry */
+       op->orm_modlist = mod;
+       rc = be->be_modify( op, &rs_modify );
 
-       if ( rc != LDAP_SUCCESS ) {
-               if ( rc == LDAP_REFERRAL ||
-                        rc == LDAP_NO_SUCH_OBJECT ) {
+       if ( rs_modify.sr_err != LDAP_SUCCESS ) {
+               if ( rs_modify.sr_err == LDAP_REFERRAL ||
+                        rs_modify.sr_err == LDAP_NO_SUCH_OBJECT ) {
                        op->o_tag = LDAP_REQ_ADD;
                        op->ora_e = e;
-                       rc = be->be_add( op, &rs );
-                       if ( rc != LDAP_SUCCESS ) {
-                               if ( rc == LDAP_ALREADY_EXISTS ) {
+                       rc = be->be_add( op, &rs_add );
+                       if ( rs_add.sr_err != LDAP_SUCCESS ) {
+                               if ( rs_add.sr_err == LDAP_ALREADY_EXISTS ) {
                                        goto update_cookie_retry;
-                               } else if ( rc == LDAP_REFERRAL ||
-                                                       rc == LDAP_NO_SUCH_OBJECT ) {
+                               } else if ( rs_add.sr_err == LDAP_REFERRAL ||
+                                                       rs_add.sr_err == LDAP_NO_SUCH_OBJECT ) {
 #ifdef NEW_LOGGING
                                        LDAP_LOG( OPERATION, ERR,
                                                "cookie will be non-persistent\n",
@@ -1737,12 +2000,10 @@ update_cookie_retry:
                                } else {
 #ifdef NEW_LOGGING
                                        LDAP_LOG( OPERATION, ERR,
-                                               "be_add failed (%d)\n",
-                                               rc, 0, 0 );
+                                               "be_add failed (%d)\n", rs_add.sr_err, 0, 0 );
 #else
                                        Debug( LDAP_DEBUG_ANY,
-                                               "be_add failed (%d)\n",
-                                               rc, 0, 0 );
+                                               "be_add failed (%d)\n", rs_add.sr_err, 0, 0 );
 #endif
                                }
                        } else {
@@ -1752,10 +2013,10 @@ update_cookie_retry:
                } else {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR,
-                               "be_modify failed (%d)\n", rc, 0, 0 );
+                               "be_modify failed (%d)\n", rs_modify.sr_err, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
-                               "be_modify failed (%d)\n", rc, 0, 0 );
+                               "be_modify failed (%d)\n", rs_modify.sr_err, 0, 0 );
 #endif
                }
        }
@@ -1805,7 +2066,7 @@ syncrepl_isupdate_dn(
 
        if ( !LDAP_STAILQ_EMPTY( &be->be_syncinfo )) {
                LDAP_STAILQ_FOREACH( si, &be->be_syncinfo, si_next ) {
-                       if ( ret = dn_match( &si->si_updatedn, ndn )) {
+                       if ( ( ret = dn_match( &si->si_updatedn, ndn ) ) ) {
                                return ret;
                        }
                }
@@ -1819,19 +2080,101 @@ dn_callback(
        SlapReply*      rs
 )
 {
-       syncinfo_t *si = op->o_callback->sc_private;
+       dninfo *dni = op->o_callback->sc_private;
 
        if ( rs->sr_type == REP_SEARCH ) {
-               if ( si->si_syncUUID_ndn.bv_val != NULL ) {
+               if ( !BER_BVISNULL( &dni->dn ) ) {
 #ifdef NEW_LOGGING
                        LDAP_LOG( OPERATION, ERR,
-                               "dn_callback : multiple entries match dn\n", 0, 0, 0 );
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
 #else
                        Debug( LDAP_DEBUG_ANY,
-                               "dn_callback : multiple entries match dn\n", 0, 0, 0 );
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
 #endif
                } else {
-                       ber_dupbv_x( &si->si_syncUUID_ndn, &rs->sr_entry->e_nname, op->o_tmpmemctx );
+                       ber_dupbv_x( &dni->dn, &rs->sr_entry->e_name, op->o_tmpmemctx );
+                       ber_dupbv_x( &dni->ndn, &rs->sr_entry->e_nname, op->o_tmpmemctx );
+                       /* If there is a new entry, see if it differs from the old.
+                        * We compare the non-normalized values so that cosmetic changes
+                        * in the provider are always propagated.
+                        */
+                       if ( dni->new_entry ) {
+                               Attribute *old, *new;
+                               int i;
+                               /* Did the DN change? Note that we don't explicitly try to
+                                * discover if the deleteOldRdn argument applies here. It
+                                * would save an unnecessary Modify if we detected it, but
+                                * that's a fair amount of trouble to compare the two attr
+                                * lists in detail.
+                                */
+                               if ( !dn_match( &rs->sr_entry->e_name,
+                                               &dni->new_entry->e_name ) )
+                               {
+                                       dni->renamed = 1;
+                               }
+                               for ( i = 0, old = rs->sr_entry->e_attrs;
+                                               old;
+                                               i++, old = old->a_next )
+                                       ;
+                               dni->attrs = i;
+                               /* We assume that attributes are saved in the same order
+                                * in the remote and local databases. So if we walk through
+                                * the attributeDescriptions one by one they should match in
+                                * lock step. If not, we signal a change. Otherwise we test
+                                * all the values...
+                                */
+                               for ( old = rs->sr_entry->e_attrs, new = dni->new_entry->e_attrs;
+                                               old && new;
+                                               old = old->a_next, new = new->a_next )
+                               {
+                                       if ( old->a_desc != new->a_desc ) {
+                                               dni->wasChanged = 1;
+                                               break;
+                                       }
+                                       for ( i = 0; ; i++ ) {
+                                               int nold, nnew;
+                                               nold = BER_BVISNULL( &old->a_vals[i] );
+                                               nnew = BER_BVISNULL( &new->a_vals[i] );
+                                               /* If both are empty, stop looking */
+                                               if ( nold && nnew ) {
+                                                       break;
+                                               }
+                                               /* If they are different, stop looking */
+                                               if ( nold != nnew ) {
+                                                       dni->wasChanged = 1;
+                                                       break;
+                                               }
+                                               if ( ber_bvcmp( &old->a_vals[i], &new->a_vals[i] )) {
+                                                       dni->wasChanged = 1;
+                                                       break;
+                                               }
+                                       }
+                                       if ( dni->wasChanged ) break;
+                               }
+                               if ( dni->wasChanged ) {
+                                       dni->ads = op->o_tmpalloc( dni->attrs *
+                                               sizeof(AttributeDescription *), op->o_tmpmemctx );
+                                       i = 0;
+                                       for ( old = rs->sr_entry->e_attrs; old; old = old->a_next ) {
+                                               dni->ads[i] = old->a_desc;
+                                               i++;
+                                       }
+                               }
+                       }
+               }
+       } else if ( rs->sr_type == REP_RESULT ) {
+               if ( rs->sr_err == LDAP_SIZELIMIT_EXCEEDED ) {
+#ifdef NEW_LOGGING
+                       LDAP_LOG( OPERATION, ERR,
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
+#else
+                       Debug( LDAP_DEBUG_ANY,
+                               "dn_callback : consistency error - entryUUID is not unique\n", 0, 0, 0 );
+#endif
                }
        }
 
@@ -1855,12 +2198,14 @@ nonpresent_callback(
                si->si_presentlist = NULL;
 
        } else if ( rs->sr_type == REP_SEARCH ) {
-               a = attr_find( rs->sr_entry->e_attrs, slap_schema.si_ad_entryUUID );
+               if ( !(si->si_refreshDelete & NP_DELETE_ONE )) {
+                       a = attr_find( rs->sr_entry->e_attrs, slap_schema.si_ad_entryUUID );
 
-               if ( a == NULL ) return 0;
+                       if ( a == NULL ) return 0;
 
-               present_uuid = avl_find( si->si_presentlist, &a->a_nvals[0],
-                       syncuuid_cmp );
+                       present_uuid = avl_find( si->si_presentlist, &a->a_nvals[0],
+                               syncuuid_cmp );
+               }
 
                if ( present_uuid == NULL ) {
                        np_entry = (struct nonpresent_entry *)
@@ -2016,3 +2361,96 @@ avl_ber_bvfree( void *bv )
        }
        ch_free ( (char *) bv );
 }
+
+void
+syncinfo_free( syncinfo_t *sie )
+{
+       ldap_pvt_thread_mutex_destroy( &sie->si_mutex );
+       if ( sie->si_provideruri ) {
+               ch_free( sie->si_provideruri );
+       }
+       if ( sie->si_provideruri_bv ) {
+               ber_bvarray_free( sie->si_provideruri_bv );
+       }
+       if ( sie->si_updatedn.bv_val ) {
+               ch_free( sie->si_updatedn.bv_val );
+       }
+       if ( sie->si_binddn ) {
+               ch_free( sie->si_binddn );
+       }
+       if ( sie->si_passwd ) {
+               ch_free( sie->si_passwd );
+       }
+       if ( sie->si_saslmech ) {
+               ch_free( sie->si_saslmech );
+       }
+       if ( sie->si_secprops ) {
+               ch_free( sie->si_secprops );
+       }
+       if ( sie->si_realm ) {
+               ch_free( sie->si_realm );
+       }
+       if ( sie->si_authcId ) {
+               ch_free( sie->si_authcId );
+       }
+       if ( sie->si_authzId ) {
+               ch_free( sie->si_authzId );
+       }
+       if ( sie->si_filterstr.bv_val ) {
+               ch_free( sie->si_filterstr.bv_val );
+       }
+       if ( sie->si_base.bv_val ) {
+               ch_free( sie->si_base.bv_val );
+       }
+       if ( sie->si_attrs ) {
+               int i = 0;
+               while ( sie->si_attrs[i] != NULL ) {
+                       ch_free( sie->si_attrs[i] );
+                       i++;
+               }
+               ch_free( sie->si_attrs );
+       }
+       if ( sie->si_exattrs ) {
+               int i = 0;
+               while ( sie->si_exattrs[i] != NULL ) {
+                       ch_free( sie->si_exattrs[i] );
+                       i++;
+               }
+               ch_free( sie->si_exattrs );
+       }
+       if ( sie->si_retryinterval ) {
+               ch_free( sie->si_retryinterval );
+       }
+       if ( sie->si_retrynum ) {
+               ch_free( sie->si_retrynum );
+       }
+       if ( sie->si_retrynum_init ) {
+               ch_free( sie->si_retrynum_init );
+       }
+       slap_sync_cookie_free( &sie->si_syncCookie, 0 );
+       if ( sie->si_presentlist ) {
+           avl_free( sie->si_presentlist, avl_ber_bvfree );
+       }
+       if ( sie->si_ld ) {
+               ldap_ld_free( sie->si_ld, 1, NULL, NULL );
+       }
+       while ( !LDAP_LIST_EMPTY( &sie->si_nonpresentlist )) {
+               struct nonpresent_entry* npe;
+               npe = LDAP_LIST_FIRST( &sie->si_nonpresentlist );
+               LDAP_LIST_REMOVE( npe, npe_link );
+               if ( npe->npe_name ) {
+                       if ( npe->npe_name->bv_val ) {
+                               ch_free( npe->npe_name->bv_val );
+                       }
+                       ch_free( npe->npe_name );
+               }
+               if ( npe->npe_nname ) {
+                       if ( npe->npe_nname->bv_val ) {
+                               ch_free( npe->npe_nname->bv_val );
+                       }
+                       ch_free( npe->npe_nname );
+               }
+               ch_free( npe );
+       }
+       ch_free( sie );
+}