Cleanup and SIGTRAP

[openldap] / servers / slapd / value.c

diff --git a/servers/slapd/value.c b/servers/slapd/value.c
index 01ee39b08a0ea4ac7306490795575795984a91e8..7911714c27fea32b8d13e786126e4ad2a1bcf882 100644 (file)
--- a/servers/slapd/value.c
+++ b/servers/slapd/value.c
@@ -1,8 +1,28 @@
 /* value.c - routines for dealing with values */
 /* $OpenLDAP$ */
+/* This work is part of OpenLDAP Software <http://www.openldap.org/>.
+ *
+ * Copyright 1998-2004 The OpenLDAP Foundation.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted only as authorized by the OpenLDAP
+ * Public License.
+ *
+ * A copy of this license is available in the file LICENSE in the
+ * top-level directory of the distribution or, alternatively, at
+ * <http://www.OpenLDAP.org/license.html>.
+ */
 /*
- * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
- * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
+ * Copyright (c) 1995 Regents of the University of Michigan.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms are permitted
+ * provided that this notice is preserved and that due credit is given
+ * to the University of Michigan at Ann Arbor. The name of the University
+ * may not be used to endorse or promote products derived from this
+ * software without specific prior written permission. This software
+ * is provided ``as is'' without express or implied warranty.
  */
 
 #include "portable.h"
@@ -20,15 +40,16 @@
 
 int
 value_add( 
-    BerVarray *vals,
-    BerVarray addvals
-)
+    BerVarray  *vals,
+    BerVarray  addvals )
 {
-       int     n, nn;
-       BerVarray v2;
+       int             n, nn = 0;
+       BerVarray       v2;
 
-       for ( nn = 0; addvals != NULL && addvals[nn].bv_val != NULL; nn++ )
-               ;       /* NULL */
+       if ( addvals != NULL ) {
+               for ( ; !BER_BVISNULL( &addvals[nn] ); nn++ )
+                       ;       /* NULL */
+       }
 
        if ( *vals == NULL ) {
                *vals = (BerVarray) SLAP_MALLOC( (nn + 1)
@@ -44,8 +65,9 @@ value_add(
                        return LBER_ERROR_MEMORY;
                }
                n = 0;
+
        } else {
-               for ( n = 0; (*vals)[n].bv_val != NULL; n++ ) {
+               for ( n = 0; !BER_BVISNULL( &(*vals)[n] ); n++ ) {
                        ;       /* Empty */
                }
                *vals = (BerVarray) SLAP_REALLOC( (char *) *vals,
@@ -62,25 +84,23 @@ value_add(
                }
        }
 
-       v2 = *vals + n;
-       for ( ; addvals->bv_val; v2++, addvals++ ) {
-               ber_dupbv(v2, addvals);
-               if (v2->bv_val == NULL) break;
+       v2 = &(*vals)[n];
+       for ( ; !BER_BVISNULL( addvals ); v2++, addvals++ ) {
+               ber_dupbv( v2, addvals );
+               if ( BER_BVISNULL( v2 ) ) break;
        }
-       v2->bv_val = NULL;
-       v2->bv_len = 0;
+       BER_BVZERO( v2 );
 
        return LDAP_SUCCESS;
 }
 
 int
 value_add_one( 
-    BerVarray *vals,
-    struct berval *addval
-)
+    BerVarray          *vals,
+    struct berval      *addval )
 {
-       int     n;
-       BerVarray v2;
+       int             n;
+       BerVarray       v2;
 
        if ( *vals == NULL ) {
                *vals = (BerVarray) SLAP_MALLOC( 2 * sizeof(struct berval) );
@@ -95,8 +115,9 @@ value_add_one(
                        return LBER_ERROR_MEMORY;
                }
                n = 0;
+
        } else {
-               for ( n = 0; (*vals)[n].bv_val != NULL; n++ ) {
+               for ( n = 0; !BER_BVISNULL( &(*vals)[n] ); n++ ) {
                        ;       /* Empty */
                }
                *vals = (BerVarray) SLAP_REALLOC( (char *) *vals,
@@ -113,12 +134,11 @@ value_add_one(
                }
        }
 
-       v2 = *vals + n;
+       v2 = &(*vals)[n];
        ber_dupbv(v2, addval);
 
        v2++;
-       v2->bv_val = NULL;
-       v2->bv_len = 0;
+       BER_BVZERO( v2 );
 
        return LDAP_SUCCESS;
 }
@@ -197,8 +217,6 @@ value_match(
        const char ** text )
 {
        int rc;
-       struct berval nv1 = { 0, NULL };
-       struct berval nv2 = { 0, NULL };
 
        assert( mr != NULL );
 
@@ -207,13 +225,8 @@ value_match(
        }
 
        rc = (mr->smr_match)( match, flags,
-               ad->ad_type->sat_syntax,
-               mr,
-               nv1.bv_val != NULL ? &nv1 : v1,
-               nv2.bv_val != NULL ? &nv2 : v2 );
+               ad->ad_type->sat_syntax, mr, v1, v2 );
        
-       if (nv1.bv_val ) free( nv1.bv_val );
-       if (nv2.bv_val ) free( nv2.bv_val );
        return rc;
 }
 
@@ -226,7 +239,7 @@ int value_find_ex(
 {
        int     i;
        int rc;
-       struct berval nval = { 0, NULL };
+       struct berval nval = BER_BVNULL;
        MatchingRule *mr = ad->ad_type->sat_equality;
 
        if( mr == NULL || !mr->smr_match ) {