Add missing semicolon.

[openldap] / servers / slapd / value.c

diff --git a/servers/slapd/value.c b/servers/slapd/value.c
index f5ee5f47772798de588772427fce2c35da80247a..ccabdf06a42ae84c2e6250a0591da93e163f6d84 100644 (file)
--- a/servers/slapd/value.c
+++ b/servers/slapd/value.c
@@ -98,13 +98,11 @@ value_normalize(
                if ( (syntax & SYNTAX_TEL) && (*s == ' ' || *s == '-') ) {
                        continue;
                }
-               *d++ = TOUPPER( *s );
+               *d++ = TOUPPER( (unsigned char) *s );
        }
        *d = '\0';
 }
 
-#define LDAP_MIN( a, b )       ((a) < (b) ? (a) : (b) )
-
 int
 value_cmp(
     struct berval      *v1,
@@ -114,7 +112,6 @@ value_cmp(
 )
 {
        int             rc;
-       struct stat     st1, st2;
 
        if ( normalize & 1 ) {
                v1 = ber_bvdup( v1 );
@@ -137,8 +134,9 @@ value_cmp(
                break;
 
        case SYNTAX_BIN:
-               rc = memcmp( v1->bv_val, v2->bv_val, LDAP_MIN( v1->bv_len,
-                   v2->bv_len ) );
+               rc = (v1->bv_len == v2->bv_len
+                     ? memcmp( v1->bv_val, v2->bv_val, v1->bv_len )
+                     : v1->bv_len > v2->bv_len ? 1 : -1);
                break;
        }
 
@@ -152,50 +150,6 @@ value_cmp(
        return( rc );
 }
 
-int
-value_ncmp(
-    struct berval      *v1,
-    struct berval      *v2,
-    int                        syntax,
-    int                        len,
-    int                        normalize
-)
-{
-       int     rc;
-
-       if ( normalize & 1 ) {
-               v1 = ber_bvdup( v1 );
-               value_normalize( v1->bv_val, syntax );
-       }
-       if ( normalize & 2 ) {
-               v2 = ber_bvdup( v2 );
-               value_normalize( v2->bv_val, syntax );
-       }
-
-       switch ( syntax ) {
-       case SYNTAX_CIS:
-       case (SYNTAX_CIS | SYNTAX_TEL):
-               rc = strncasecmp( v1->bv_val, v2->bv_val, len );
-               break;
-
-       case SYNTAX_CES:
-               rc = strncmp( v1->bv_val, v2->bv_val, len );
-               break;
-
-       case SYNTAX_BIN:
-               rc = memcmp( v1->bv_val, v2->bv_val, len );
-       }
-
-       if ( normalize & 1 ) {
-               ber_bvfree( v1 );
-       }
-       if ( normalize & 2 ) {
-               ber_bvfree( v2 );
-       }
-
-       return( rc );
-}
-
 int
 value_find(
     struct berval      **vals,