]> git.sur5r.net Git - i3/i3/blobdiff - src/commands.c
Bugfix: Repeatedly try to find screens if none are available (Thanks mxf)
[i3/i3] / src / commands.c
index 6c9ba500bea1d25610a81d8fe61e7be936f5b8ad..275f8f96bb08c931d09842656a91b6e46f848dbe 100644 (file)
@@ -3,7 +3,7 @@
  *
  * i3 - an improved dynamic tiling window manager
  *
- * (c) 2009 Michael Stapelberg and contributors
+ * © 2009 Michael Stapelberg and contributors
  *
  * See file LICENSE for license information.
  *
 #include "table.h"
 #include "layout.h"
 #include "i3.h"
+#include "xinerama.h"
+#include "client.h"
+#include "floating.h"
+#include "xcb.h"
 
-static bool focus_window_in_container(xcb_connection_t *connection, Container *container,
-                direction_t direction) {
+bool focus_window_in_container(xcb_connection_t *conn, Container *container, direction_t direction) {
         /* If this container is empty, we’re done */
         if (container->currently_focused == NULL)
                 return false;
 
-        Client *candidad = NULL;
-        if (direction == D_UP)
-                candidad = CIRCLEQ_PREV(container->currently_focused, clients);
-        else if (direction == D_DOWN)
-                candidad = CIRCLEQ_NEXT(container->currently_focused, clients);
-        else printf("Direction not implemented!\n");
+        /* Get the previous/next client or wrap around */
+        Client *candidate = NULL;
+        if (direction == D_UP) {
+                if ((candidate = CIRCLEQ_PREV_OR_NULL(&(container->clients), container->currently_focused, clients)) == NULL)
+                        candidate = CIRCLEQ_LAST(&(container->clients));
+        }
+        else if (direction == D_DOWN) {
+                if ((candidate = CIRCLEQ_NEXT_OR_NULL(&(container->clients), container->currently_focused, clients)) == NULL)
+                        candidate = CIRCLEQ_FIRST(&(container->clients));
+        } else LOG("Direction not implemented!\n");
 
-        /* If we don’t have anything to select, we’re done */
-        if (candidad == CIRCLEQ_END(&(container->clients)))
+        /* If we could not switch, the container contains exactly one client. We return false */
+        if (candidate == container->currently_focused)
                 return false;
 
-        /* Set focus if we could successfully move */
-        set_focus(connection, candidad);
+        /* Set focus */
+        set_focus(conn, candidate, true);
 
         return true;
 }
 
-static void focus_window(xcb_connection_t *connection, direction_t direction) {
-        printf("focusing direction %d\n", direction);
+typedef enum { THING_WINDOW, THING_CONTAINER } thing_t;
+
+static void focus_thing(xcb_connection_t *conn, direction_t direction, thing_t thing) {
+        LOG("focusing direction %d\n", direction);
+
+        int new_row = current_row,
+            new_col = current_col;
+        Container *container = CUR_CELL;
+        Workspace *t_ws = c_ws;
+
+        /* Makes sure new_col and new_row are within bounds of the new workspace */
+        void check_colrow_boundaries() {
+                if (new_col >= t_ws->cols)
+                        new_col = (t_ws->cols - 1);
+                if (new_row >= t_ws->rows)
+                        new_row = (t_ws->rows - 1);
+        }
+
+        /* There always is a container. If not, current_col or current_row is wrong */
+        assert(container != NULL);
+
+        if (container->workspace->fullscreen_client != NULL) {
+                LOG("You're in fullscreen mode. Won't switch focus\n");
+                return;
+        }
+
         /* TODO: for horizontal default layout, this has to be expanded to LEFT/RIGHT */
         if (direction == D_UP || direction == D_DOWN) {
-                /* Let’s see if we can perform up/down focus in the current container */
-                Container *container = CUR_CELL;
+                if (thing == THING_WINDOW)
+                        /* Let’s see if we can perform up/down focus in the current container */
+                        if (focus_window_in_container(conn, container, direction))
+                                return;
 
-                /* There always is a container. If not, current_col or current_row is wrong */
-                assert(container != NULL);
+                if (direction == D_DOWN && cell_exists(current_col, current_row+1))
+                        new_row = current_row + t_ws->table[current_col][current_row]->rowspan;
+                else if (direction == D_UP && cell_exists(current_col, current_row-1)) {
+                        /* Set new_row as a sane default, but it may get overwritten in a second */
+                        new_row--;
 
-                if (focus_window_in_container(connection, container, direction))
-                        return;
+                        /* Search from the top to correctly handle rowspanned containers */
+                        for (int rows = 0; rows < current_row; rows += t_ws->table[current_col][rows]->rowspan) {
+                                if (new_row > (rows + (t_ws->table[current_col][rows]->rowspan - 1)))
+                                        continue;
+
+                                new_row = rows;
+                                break;
+                        }
+                } else {
+                        /* Let’s see if there is a screen down/up there to which we can switch */
+                        LOG("container is at %d with height %d\n", container->y, container->height);
+                        i3Screen *screen;
+                        int destination_y = (direction == D_UP ? (container->y - 1) : (container->y + container->height + 1));
+                        if ((screen = get_screen_containing(container->x, destination_y)) == NULL) {
+                                LOG("Wrapping screen around vertically\n");
+                                /* No screen found? Then wrap */
+                                screen = get_screen_most((direction == D_UP ? D_DOWN : D_UP));
+                        }
+                        t_ws = &(workspaces[screen->current_workspace]);
+                        new_row = (direction == D_UP ? (t_ws->rows - 1) : 0);
+                }
+
+                check_colrow_boundaries();
+
+                LOG("new_col = %d, new_row = %d\n", new_col, new_row);
+                if (t_ws->table[new_col][new_row]->currently_focused == NULL) {
+                        LOG("Cell empty, checking for colspanned client above...\n");
+                        for (int cols = 0; cols < new_col; cols += t_ws->table[cols][new_row]->colspan) {
+                                if (new_col > (cols + (t_ws->table[cols][new_row]->colspan - 1)))
+                                        continue;
+
+                                new_col = cols;
+                                break;
+                        }
+                        LOG("Fixed it to new col %d\n", new_col);
+                }
         } else if (direction == D_LEFT || direction == D_RIGHT) {
                 if (direction == D_RIGHT && cell_exists(current_col+1, current_row))
-                        current_col++;
-                else if (direction == D_LEFT && cell_exists(current_col-1, current_row))
-                        current_col--;
-                else {
-                        printf("nah, not possible\n");
-                        return;
-                }
-                if (CUR_CELL->currently_focused != NULL) {
-                        xcb_set_input_focus(connection, XCB_INPUT_FOCUS_POINTER_ROOT,
-                                        CUR_CELL->currently_focused->child, XCB_CURRENT_TIME);
-                        render_layout(connection);
+                        new_col = current_col + t_ws->table[current_col][current_row]->colspan;
+                else if (direction == D_LEFT && cell_exists(current_col-1, current_row)) {
+                        /* Set new_col as a sane default, but it may get overwritten in a second */
+                        new_col--;
+
+                        /* Search from the left to correctly handle colspanned containers */
+                        for (int cols = 0; cols < current_col; cols += t_ws->table[cols][current_row]->colspan) {
+                                if (new_col > (cols + (t_ws->table[cols][current_row]->colspan - 1)))
+                                        continue;
+
+                                new_col = cols;
+                                break;
+                        }
+                } else {
+                        /* Let’s see if there is a screen left/right here to which we can switch */
+                        LOG("container is at %d with width %d\n", container->x, container->width);
+                        i3Screen *screen;
+                        int destination_x = (direction == D_LEFT ? (container->x - 1) : (container->x + container->width + 1));
+                        if ((screen = get_screen_containing(destination_x, container->y)) == NULL) {
+                                LOG("Wrapping screen around horizontally\n");
+                                screen = get_screen_most((direction == D_LEFT ? D_RIGHT : D_LEFT));
+                        }
+                        t_ws = &(workspaces[screen->current_workspace]);
+                        new_col = (direction == D_LEFT ? (t_ws->cols - 1) : 0);
                 }
 
+                check_colrow_boundaries();
+
+                LOG("new_col = %d, new_row = %d\n", new_col, new_row);
+                if (t_ws->table[new_col][new_row]->currently_focused == NULL) {
+                        LOG("Cell empty, checking for rowspanned client above...\n");
+                        for (int rows = 0; rows < new_row; rows += t_ws->table[new_col][rows]->rowspan) {
+                                if (new_row > (rows + (t_ws->table[new_col][rows]->rowspan - 1)))
+                                        continue;
+
+                                new_row = rows;
+                                break;
+                        }
+                        LOG("Fixed it to new row %d\n", new_row);
+                }
         } else {
-                printf("direction unhandled\n");
+                LOG("direction unhandled\n");
+                return;
         }
+
+        check_colrow_boundaries();
+
+        if (t_ws->table[new_col][new_row]->currently_focused != NULL)
+                set_focus(conn, t_ws->table[new_col][new_row]->currently_focused, true);
 }
 
 /*
@@ -84,31 +187,34 @@ static void focus_window(xcb_connection_t *connection, direction_t direction) {
  * Returns true if the window could be moved, false otherwise.
  *
  */
-static bool move_current_window_in_container(xcb_connection_t *connection, Client *client,
+static bool move_current_window_in_container(xcb_connection_t *conn, Client *client,
                 direction_t direction) {
+        assert(client->container != NULL);
+
         Client *other = (direction == D_UP ? CIRCLEQ_PREV(client, clients) :
-                                                CIRCLEQ_NEXT(client, clients));
+                                             CIRCLEQ_NEXT(client, clients));
 
         if (other == CIRCLEQ_END(&(client->container->clients)))
                 return false;
 
-        printf("i can do that\n");
+        LOG("i can do that\n");
         /* We can move the client inside its current container */
         CIRCLEQ_REMOVE(&(client->container->clients), client, clients);
         if (direction == D_UP)
                 CIRCLEQ_INSERT_BEFORE(&(client->container->clients), other, client, clients);
         else CIRCLEQ_INSERT_AFTER(&(client->container->clients), other, client, clients);
-        render_layout(connection);
+        render_layout(conn);
         return true;
 }
 
 /*
- * Moves the current window to the given direction, creating a column/row if
- * necessary
+ * Moves the current window or whole container to the given direction, creating a column/row if
+ * necessary.
  *
  */
-static void move_current_window(xcb_connection_t *connection, direction_t direction) {
-        printf("moving window to direction %d\n", direction);
+static void move_current_window(xcb_connection_t *conn, direction_t direction) {
+        LOG("moving window to direction %s\n", (direction == D_UP ? "up" : (direction == D_DOWN ? "down" :
+                                            (direction == D_LEFT ? "left" : "right"))));
         /* Get current window */
         Container *container = CUR_CELL,
                   *new = NULL;
@@ -116,23 +222,30 @@ static void move_current_window(xcb_connection_t *connection, direction_t direct
         /* There has to be a container, see focus_window() */
         assert(container != NULL);
 
-        /* If there is no window, we’re done */
-        if (container->currently_focused == NULL)
+        /* If there is no window or the dock window is focused, we’re done */
+        if (container->currently_focused == NULL ||
+            container->currently_focused->dock)
                 return;
 
-        /* As soon as the client is moved away, the next client in the old
+        /* As soon as the client is moved away, the last focused client in the old
          * container needs to get focus, if any. Therefore, we save it here. */
         Client *current_client = container->currently_focused;
-        Client *to_focus = CIRCLEQ_NEXT(current_client, clients);
-        if (to_focus == CIRCLEQ_END(&(container->clients)))
-                to_focus = NULL;
+        Client *to_focus = get_last_focused_client(conn, container, current_client);
+
+        if (to_focus == NULL) {
+                to_focus = CIRCLEQ_NEXT_OR_NULL(&(container->clients), current_client, clients);
+                if (to_focus == NULL)
+                        to_focus = CIRCLEQ_PREV_OR_NULL(&(container->clients), current_client, clients);
+        }
 
         switch (direction) {
                 case D_LEFT:
-                        if (current_col == 0)
-                                return;
-
-                        new = CUR_TABLE[--current_col][current_row];
+                        /* If we’re at the left-most position, move the rest of the table right */
+                        if (current_col == 0) {
+                                expand_table_cols_at_head(c_ws);
+                                new = CUR_CELL;
+                        } else
+                                new = CUR_TABLE[--current_col][current_row];
                         break;
                 case D_RIGHT:
                         if (current_col == (c_ws->cols-1))
@@ -141,15 +254,18 @@ static void move_current_window(xcb_connection_t *connection, direction_t direct
                         new = CUR_TABLE[++current_col][current_row];
                         break;
                 case D_UP:
-                        /* TODO: if we’re at the up-most position, move the rest of the table down */
-                        if (move_current_window_in_container(connection, current_client, D_UP) ||
-                                current_row == 0)
+                        if (move_current_window_in_container(conn, current_client, D_UP))
                                 return;
 
-                        new = CUR_TABLE[current_col][--current_row];
+                        /* if we’re at the up-most position, move the rest of the table down */
+                        if (current_row == 0) {
+                                expand_table_rows_at_head(c_ws);
+                                new = CUR_CELL;
+                        } else
+                                new = CUR_TABLE[current_col][--current_row];
                         break;
                 case D_DOWN:
-                        if (move_current_window_in_container(connection, current_client, D_DOWN))
+                        if (move_current_window_in_container(conn, current_client, D_DOWN))
                                 return;
 
                         if (current_row == (c_ws->rows-1))
@@ -157,20 +273,110 @@ static void move_current_window(xcb_connection_t *connection, direction_t direct
 
                         new = CUR_TABLE[current_col][++current_row];
                         break;
+                /* To make static analyzers happy: */
+                default:
+                        return;
         }
 
         /* Remove it from the old container and put it into the new one */
-        CIRCLEQ_REMOVE(&(container->clients), current_client, clients);
-        CIRCLEQ_INSERT_TAIL(&(new->clients), current_client, clients);
+        client_remove_from_container(conn, current_client, container, true);
+
+        if (new->currently_focused != NULL)
+                CIRCLEQ_INSERT_AFTER(&(new->clients), new->currently_focused, current_client, clients);
+        else CIRCLEQ_INSERT_TAIL(&(new->clients), current_client, clients);
+        SLIST_INSERT_HEAD(&(new->workspace->focus_stack), current_client, focus_clients);
 
         /* Update data structures */
         current_client->container = new;
+        current_client->workspace = new->workspace;
         container->currently_focused = to_focus;
         new->currently_focused = current_client;
 
-        /* TODO: delete all empty columns/rows */
+        Workspace *workspace = container->workspace;
+
+        /* delete all empty columns/rows */
+        cleanup_table(conn, workspace);
+
+        /* Fix colspan/rowspan if it’d overlap */
+        fix_colrowspan(conn, workspace);
+
+        render_workspace(conn, workspace->screen, workspace);
+        xcb_flush(conn);
+
+        set_focus(conn, current_client, true);
+}
+
+static void move_current_container(xcb_connection_t *conn, direction_t direction) {
+        LOG("moving container to direction %s\n", (direction == D_UP ? "up" : (direction == D_DOWN ? "down" :
+                                            (direction == D_LEFT ? "left" : "right"))));
+        /* Get current window */
+        Container *container = CUR_CELL,
+                  *new = NULL;
+
+        Container **old = &CUR_CELL;
+
+        /* There has to be a container, see focus_window() */
+        assert(container != NULL);
+
+        switch (direction) {
+                case D_LEFT:
+                        /* If we’re at the left-most position, move the rest of the table right */
+                        if (current_col == 0) {
+                                expand_table_cols_at_head(c_ws);
+                                new = CUR_CELL;
+                                old = &CUR_TABLE[current_col+1][current_row];
+                        } else
+                                new = CUR_TABLE[--current_col][current_row];
+                        break;
+                case D_RIGHT:
+                        if (current_col == (c_ws->cols-1))
+                                expand_table_cols(c_ws);
+
+                        new = CUR_TABLE[++current_col][current_row];
+                        break;
+                case D_UP:
+                        /* if we’re at the up-most position, move the rest of the table down */
+                        if (current_row == 0) {
+                                expand_table_rows_at_head(c_ws);
+                                new = CUR_CELL;
+                                old = &CUR_TABLE[current_col][current_row+1];
+                        } else
+                                new = CUR_TABLE[current_col][--current_row];
+                        break;
+                case D_DOWN:
+                        if (current_row == (c_ws->rows-1))
+                                expand_table_rows(c_ws);
+
+                        new = CUR_TABLE[current_col][++current_row];
+                        break;
+                /* To make static analyzers happy: */
+                default:
+                        return;
+        }
+
+        LOG("old = %d,%d and new = %d,%d\n", container->col, container->row, new->col, new->row);
+
+        /* Swap the containers */
+        int col = new->col;
+        int row = new->row;
+
+        *old = new;
+        new->col = container->col;
+        new->row = container->row;
+
+        CUR_CELL = container;
+        container->col = col;
+        container->row = row;
+
+        Workspace *workspace = container->workspace;
 
-        render_layout(connection);
+        /* delete all empty columns/rows */
+        cleanup_table(conn, workspace);
+
+        /* Fix colspan/rowspan if it’d overlap */
+        fix_colrowspan(conn, workspace);
+
+        render_layout(conn);
 }
 
 /*
@@ -178,8 +384,8 @@ static void move_current_window(xcb_connection_t *connection, direction_t direct
  * to the given direction, that is, adjusts cellspan/rowspan
  *
  */
-static void snap_current_container(xcb_connection_t *connection, direction_t direction) {
-        printf("snapping container to direction %d\n", direction);
+static void snap_current_container(xcb_connection_t *conn, direction_t direction) {
+        LOG("snapping container to direction %d\n", direction);
 
         Container *container = CUR_CELL;
 
@@ -188,64 +394,220 @@ static void snap_current_container(xcb_connection_t *connection, direction_t dir
         switch (direction) {
                 case D_LEFT:
                         /* Snap to the left is actually a move to the left and then a snap right */
-                        move_current_window(connection, D_LEFT);
-                        snap_current_container(connection, D_RIGHT);
-                        return;
-                case D_RIGHT:
-                        /* Check if the cell is used */
-                        if (!cell_exists(container->col + 1, container->row) ||
-                                CUR_TABLE[container->col+1][container->row]->currently_focused != NULL) {
-                                printf("cannot snap to right - the cell is already used\n");
+                        if (!cell_exists(container->col - 1, container->row) ||
+                            CUR_TABLE[container->col-1][container->row]->currently_focused != NULL) {
+                                LOG("cannot snap to left - the cell is already used\n");
                                 return;
                         }
 
+                        move_current_window(conn, D_LEFT);
+                        snap_current_container(conn, D_RIGHT);
+                        return;
+                case D_RIGHT: {
+                        /* Check if the cell is used */
+                        int new_col = container->col + container->colspan;
+                        for (int i = 0; i < container->rowspan; i++)
+                                if (!cell_exists(new_col, container->row + i) ||
+                                    CUR_TABLE[new_col][container->row + i]->currently_focused != NULL) {
+                                        LOG("cannot snap to right - the cell is already used\n");
+                                        return;
+                                }
+
                         /* Check if there are other cells with rowspan, which are in our way.
                          * If so, reduce their rowspan. */
                         for (int i = container->row-1; i >= 0; i--) {
-                                printf("we got cell %d, %d with rowspan %d\n",
-                                                container->col+1, i, CUR_TABLE[container->col+1][i]->rowspan);
-                                while ((CUR_TABLE[container->col+1][i]->rowspan-1) >= (container->row - i))
-                                        CUR_TABLE[container->col+1][i]->rowspan--;
-                                printf("new rowspan = %d\n", CUR_TABLE[container->col+1][i]->rowspan);
+                                LOG("we got cell %d, %d with rowspan %d\n",
+                                                new_col, i, CUR_TABLE[new_col][i]->rowspan);
+                                while ((CUR_TABLE[new_col][i]->rowspan-1) >= (container->row - i))
+                                        CUR_TABLE[new_col][i]->rowspan--;
+                                LOG("new rowspan = %d\n", CUR_TABLE[new_col][i]->rowspan);
                         }
 
                         container->colspan++;
                         break;
+                }
                 case D_UP:
-                        move_current_window(connection, D_UP);
-                        snap_current_container(connection, D_DOWN);
-                        return;
-                case D_DOWN:
-                        printf("snapping down\n");
-                        if (!cell_exists(container->col, container->row+1) ||
-                                CUR_TABLE[container->col][container->row+1]->currently_focused != NULL) {
-                                printf("cannot snap down - the cell is already used\n");
+                        if (!cell_exists(container->col, container->row - 1) ||
+                            CUR_TABLE[container->col][container->row-1]->currently_focused != NULL) {
+                                LOG("cannot snap to top - the cell is already used\n");
                                 return;
                         }
 
+                        move_current_window(conn, D_UP);
+                        snap_current_container(conn, D_DOWN);
+                        return;
+                case D_DOWN: {
+                        LOG("snapping down\n");
+                        int new_row = container->row + container->rowspan;
+                        for (int i = 0; i < container->colspan; i++)
+                                if (!cell_exists(container->col + i, new_row) ||
+                                    CUR_TABLE[container->col + i][new_row]->currently_focused != NULL) {
+                                        LOG("cannot snap down - the cell is already used\n");
+                                        return;
+                                }
+
                         for (int i = container->col-1; i >= 0; i--) {
-                                printf("we got cell %d, %d with colspan %d\n",
-                                                i, container->row+1, CUR_TABLE[i][container->row+1]->colspan);
-                                while ((CUR_TABLE[i][container->row+1]->colspan-1) >= (container->col - i))
-                                        CUR_TABLE[i][container->row+1]->colspan--;
-                                printf("new colspan = %d\n", CUR_TABLE[i][container->row+1]->colspan);
+                                LOG("we got cell %d, %d with colspan %d\n",
+                                                i, new_row, CUR_TABLE[i][new_row]->colspan);
+                                while ((CUR_TABLE[i][new_row]->colspan-1) >= (container->col - i))
+                                        CUR_TABLE[i][new_row]->colspan--;
+                                LOG("new colspan = %d\n", CUR_TABLE[i][new_row]->colspan);
 
                         }
 
                         container->rowspan++;
                         break;
+                }
+                /* To make static analyzers happy: */
+                default:
+                        return;
+        }
+
+        render_layout(conn);
+}
+
+static void move_floating_window_to_workspace(xcb_connection_t *conn, Client *client, int workspace) {
+        /* t_ws (to workspace) is just a container pointer to the workspace we’re switching to */
+        Workspace *t_ws = &(workspaces[workspace-1]),
+                  *old_ws = client->workspace;
+
+        LOG("moving floating\n");
+
+        if (t_ws->screen == NULL) {
+                LOG("initializing new workspace, setting num to %d\n", workspace-1);
+                t_ws->screen = c_ws->screen;
+                /* Copy the dimensions from the virtual screen */
+               memcpy(&(t_ws->rect), &(t_ws->screen->rect), sizeof(Rect));
+        } else {
+                /* Check if there is already a fullscreen client on the destination workspace and
+                 * stop moving if so. */
+                if (client->fullscreen && (t_ws->fullscreen_client != NULL)) {
+                        LOG("Not moving: Fullscreen client already existing on destination workspace.\n");
+                        return;
+                }
+        }
+
+        floating_assign_to_workspace(client, t_ws);
+
+        bool target_invisible = t_ws->screen->current_workspace != t_ws->num;
+
+        /* If we’re moving it to an invisible screen, we need to unmap it */
+        if (target_invisible) {
+                LOG("This workspace is not visible, unmapping\n");
+                xcb_unmap_window(conn, client->frame);
+        } else {
+                /* If this is not the case, we move the window to a workspace
+                 * which is on another screen, so we also need to adjust its
+                 * coordinates. */
+                LOG("before x = %d, y = %d\n", client->rect.x, client->rect.y);
+                uint32_t relative_x = client->rect.x - old_ws->rect.x,
+                         relative_y = client->rect.y - old_ws->rect.y;
+                LOG("rel_x = %d, rel_y = %d\n", relative_x, relative_y);
+                client->rect.x = t_ws->rect.x + relative_x;
+                client->rect.y = t_ws->rect.y + relative_y;
+                LOG("after x = %d, y = %d\n", client->rect.x, client->rect.y);
+                reposition_client(conn, client);
+                xcb_flush(conn);
+        }
+
+        LOG("done\n");
+
+        render_layout(conn);
+
+        if (!target_invisible)
+                set_focus(conn, client, true);
+}
+
+/*
+ * Moves the currently selected window to the given workspace
+ *
+ */
+static void move_current_window_to_workspace(xcb_connection_t *conn, int workspace) {
+        LOG("Moving current window to workspace %d\n", workspace);
+
+        Container *container = CUR_CELL;
+
+        assert(container != NULL);
+
+        /* t_ws (to workspace) is just a container pointer to the workspace we’re switching to */
+        Workspace *t_ws = &(workspaces[workspace-1]);
+
+        Client *current_client = container->currently_focused;
+        if (current_client == NULL) {
+                LOG("No currently focused client in current container.\n");
+                return;
+        }
+        Client *to_focus = CIRCLEQ_NEXT_OR_NULL(&(container->clients), current_client, clients);
+        if (to_focus == NULL)
+                to_focus = CIRCLEQ_PREV_OR_NULL(&(container->clients), current_client, clients);
+
+        if (t_ws->screen == NULL) {
+                LOG("initializing new workspace, setting num to %d\n", workspace-1);
+                t_ws->screen = container->workspace->screen;
+                /* Copy the dimensions from the virtual screen */
+               memcpy(&(t_ws->rect), &(container->workspace->screen->rect), sizeof(Rect));
+        } else {
+                /* Check if there is already a fullscreen client on the destination workspace and
+                 * stop moving if so. */
+                if (current_client->fullscreen && (t_ws->fullscreen_client != NULL)) {
+                        LOG("Not moving: Fullscreen client already existing on destination workspace.\n");
+                        return;
+                }
+        }
+
+        Container *to_container = t_ws->table[t_ws->current_col][t_ws->current_row];
+
+        assert(to_container != NULL);
+
+        client_remove_from_container(conn, current_client, container, true);
+        if (container->workspace->fullscreen_client == current_client)
+                container->workspace->fullscreen_client = NULL;
+
+        /* TODO: insert it to the correct position */
+        CIRCLEQ_INSERT_TAIL(&(to_container->clients), current_client, clients);
+
+        SLIST_INSERT_HEAD(&(to_container->workspace->focus_stack), current_client, focus_clients);
+        LOG("Moved.\n");
+
+        current_client->container = to_container;
+        current_client->workspace = to_container->workspace;
+        container->currently_focused = to_focus;
+        to_container->currently_focused = current_client;
+
+        bool target_invisible = (to_container->workspace->screen->current_workspace != to_container->workspace->num);
+
+        /* If we’re moving it to an invisible screen, we need to unmap it */
+        if (target_invisible) {
+                LOG("This workspace is not visible, unmapping\n");
+                xcb_unmap_window(conn, current_client->frame);
+        } else {
+                if (current_client->fullscreen) {
+                        LOG("Calling client_enter_fullscreen again\n");
+                        client_enter_fullscreen(conn, current_client);
+                }
         }
 
-        render_layout(connection);
+        /* delete all empty columns/rows */
+        cleanup_table(conn, container->workspace);
+
+        render_layout(conn);
+
+        if (!target_invisible)
+                set_focus(conn, current_client, true);
 }
 
-static void show_workspace(xcb_connection_t *conn, int workspace) {
+/*
+ * Switches to the given workspace
+ *
+ */
+void show_workspace(xcb_connection_t *conn, int workspace) {
         Client *client;
+        bool need_warp = false;
         xcb_window_t root = xcb_setup_roots_iterator(xcb_get_setup(conn)).data->root;
         /* t_ws (to workspace) is just a convenience pointer to the workspace we’re switching to */
         Workspace *t_ws = &(workspaces[workspace-1]);
 
-        printf("show_workspace(%d)\n", workspace);
+        LOG("show_workspace(%d)\n", workspace);
 
         /* Store current_row/current_col */
         c_ws->current_row = current_row;
@@ -253,7 +615,7 @@ static void show_workspace(xcb_connection_t *conn, int workspace) {
 
         /* Check if the workspace has not been used yet */
         if (t_ws->screen == NULL) {
-                printf("initializing new workspace, setting num to %d\n", workspace);
+                LOG("initializing new workspace, setting num to %d\n", workspace);
                 t_ws->screen = c_ws->screen;
                 /* Copy the dimensions from the virtual screen */
                memcpy(&(t_ws->rect), &(t_ws->screen->rect), sizeof(Rect));
@@ -261,105 +623,409 @@ static void show_workspace(xcb_connection_t *conn, int workspace) {
 
         if (c_ws->screen != t_ws->screen) {
                 /* We need to switch to the other screen first */
-                printf("Just moving over to other screen.\n");
+                LOG("moving over to other screen.\n");
+
+                /* Store the old client */
+                Client *old_client = CUR_CELL->currently_focused;
+
                 c_ws = &(workspaces[t_ws->screen->current_workspace]);
                 current_col = c_ws->current_col;
                 current_row = c_ws->current_row;
                 if (CUR_CELL->currently_focused != NULL)
-                        warp_pointer_into(conn, CUR_CELL->currently_focused);
+                        need_warp = true;
                 else {
                         Rect *dims = &(c_ws->screen->rect);
                         xcb_warp_pointer(conn, XCB_NONE, root, 0, 0, 0, 0,
                                          dims->x + (dims->width / 2), dims->y + (dims->height / 2));
                 }
+
+                /* Re-decorate the old client, it’s not focused anymore */
+                if ((old_client != NULL) && !old_client->dock)
+                        redecorate_window(conn, old_client);
+                else xcb_flush(conn);
         }
 
         /* Check if we need to change something or if we’re already there */
-        if (c_ws->screen->current_workspace == (workspace-1))
+        if (c_ws->screen->current_workspace == (workspace-1)) {
+                Client *last_focused = SLIST_FIRST(&(c_ws->focus_stack));
+                if (last_focused != SLIST_END(&(c_ws->focus_stack))) {
+                        set_focus(conn, last_focused, true);
+                        if (need_warp) {
+                                client_warp_pointer_into(conn, last_focused);
+                                xcb_flush(conn);
+                        }
+                }
+
                 return;
+        }
 
         t_ws->screen->current_workspace = workspace-1;
+        Workspace *old_workspace = c_ws;
+        c_ws = &workspaces[workspace-1];
 
-        /* TODO: does grabbing the server actually bring us any (speed)advantages? */
-        //xcb_grab_server(conn);
-
-        /* Unmap all clients of the current workspace */
-        for (int cols = 0; cols < c_ws->cols; cols++)
-                for (int rows = 0; rows < c_ws->rows; rows++)
-                        CIRCLEQ_FOREACH(client, &(c_ws->table[cols][rows]->clients), clients)
-                                xcb_unmap_window(conn, client->frame);
+        /* Unmap all clients of the old workspace */
+        unmap_workspace(conn, old_workspace);
 
-        c_ws = &workspaces[workspace-1];
         current_row = c_ws->current_row;
         current_col = c_ws->current_col;
-        printf("new current row = %d, current col = %d\n", current_row, current_col);
+        LOG("new current row = %d, current col = %d\n", current_row, current_col);
+
+        ignore_enter_notify_forall(conn, c_ws, true);
 
         /* Map all clients on the new workspace */
-        for (int cols = 0; cols < c_ws->cols; cols++)
-                for (int rows = 0; rows < c_ws->rows; rows++)
-                        CIRCLEQ_FOREACH(client, &(c_ws->table[cols][rows]->clients), clients)
-                                xcb_map_window(conn, client->frame);
+        FOR_TABLE(c_ws)
+                CIRCLEQ_FOREACH(client, &(c_ws->table[cols][rows]->clients), clients)
+                        xcb_map_window(conn, client->frame);
 
-        /* Restore focus on the new workspace */
-        if (CUR_CELL->currently_focused != NULL)
-                xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, CUR_CELL->currently_focused->child, XCB_CURRENT_TIME);
-        else xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, root, XCB_CURRENT_TIME);
+        /* Map all floating clients */
+        if (!c_ws->floating_hidden)
+                TAILQ_FOREACH(client, &(c_ws->floating_clients), floating_clients)
+                        xcb_map_window(conn, client->frame);
+
+        /* Map all stack windows, if any */
+        struct Stack_Window *stack_win;
+        SLIST_FOREACH(stack_win, &stack_wins, stack_windows)
+                if (stack_win->container->workspace == c_ws)
+                        xcb_map_window(conn, stack_win->window);
+
+        ignore_enter_notify_forall(conn, c_ws, false);
 
-        //xcb_ungrab_server(conn);
+        /* Restore focus on the new workspace */
+        Client *last_focused = SLIST_FIRST(&(c_ws->focus_stack));
+        if (last_focused != SLIST_END(&(c_ws->focus_stack))) {
+                set_focus(conn, last_focused, true);
+                if (need_warp) {
+                        client_warp_pointer_into(conn, last_focused);
+                        xcb_flush(conn);
+                }
+        } else xcb_set_input_focus(conn, XCB_INPUT_FOCUS_POINTER_ROOT, root, XCB_CURRENT_TIME);
 
         render_layout(conn);
 }
 
+/*
+ * Jumps to the given window class / title.
+ * Title is matched using strstr, that is, matches if it appears anywhere
+ * in the string. Regular expressions seem to be a bit overkill here. However,
+ * if we need them for something else somewhen, we may introduce them here, too.
+ *
+ */
+static void jump_to_window(xcb_connection_t *conn, const char *arguments) {
+        char *classtitle;
+        Client *client;
+
+        /* The first character is a quote, this was checked before */
+        classtitle = sstrdup(arguments+1);
+        /* The last character is a quote, we just set it to NULL */
+        classtitle[strlen(classtitle)-1] = '\0';
+
+        if ((client = get_matching_client(conn, classtitle, NULL)) == NULL) {
+                free(classtitle);
+                LOG("No matching client found.\n");
+                return;
+        }
+
+        free(classtitle);
+        set_focus(conn, client, true);
+}
+
+/*
+ * Jump directly to the specified workspace, row and col.
+ * Great for reaching windows that you always keep in the same spot (hello irssi, I'm looking at you)
+ *
+ */
+static void jump_to_container(xcb_connection_t *conn, const char *arguments) {
+        int ws, row, col;
+        int result;
+
+        result = sscanf(arguments, "%d %d %d", &ws, &col, &row);
+        LOG("Jump called with %d parameters (\"%s\")\n", result, arguments);
+
+        /* No match? Either no arguments were specified, or no numbers */
+        if (result < 1) {
+                LOG("At least one valid argument required\n");
+                return;
+        }
+
+        /* Move to the target workspace */
+        show_workspace(conn, ws);
+
+        if (result < 3)
+                return;
+
+        LOG("Boundary-checking col %d, row %d... (max cols %d, max rows %d)\n", col, row, c_ws->cols, c_ws->rows);
+
+        /* Move to row/col */
+        if (row >= c_ws->rows)
+                row = c_ws->rows - 1;
+        if (col >= c_ws->cols)
+                col = c_ws->cols - 1;
+
+        LOG("Jumping to col %d, row %d\n", col, row);
+        if (c_ws->table[col][row]->currently_focused != NULL)
+                set_focus(conn, c_ws->table[col][row]->currently_focused, true);
+}
+
+/*
+ * Travels the focus stack by the given number of times (or once, if no argument
+ * was specified). That is, selects the window you were in before you focused
+ * the current window.
+ *
+ * The special values 'floating' (select the next floating window), 'tiling'
+ * (select the next tiling window), 'ft' (if the current window is floating,
+ * select the next tiling window and vice-versa) are also valid
+ *
+ */
+static void travel_focus_stack(xcb_connection_t *conn, const char *arguments) {
+        /* Start count at -1 to always skip the first element */
+        int times, count = -1;
+        Client *current;
+        bool floating_criteria;
+
+        /* Either it’s one of the special values… */
+        if (strcasecmp(arguments, "floating") == 0) {
+                floating_criteria = true;
+        } else if (strcasecmp(arguments, "tiling") == 0) {
+                floating_criteria = false;
+        } else if (strcasecmp(arguments, "ft") == 0) {
+                Client *last_focused = SLIST_FIRST(&(c_ws->focus_stack));
+                if (last_focused == SLIST_END(&(c_ws->focus_stack))) {
+                        LOG("Cannot select the next floating/tiling client because there is no client at all\n");
+                        return;
+                }
+
+                floating_criteria = !client_is_floating(last_focused);
+        } else {
+                /* …or a number was specified */
+                if (sscanf(arguments, "%u", &times) != 1) {
+                        LOG("No or invalid argument given (\"%s\"), using default of 1 times\n", arguments);
+                        times = 1;
+                }
+
+                SLIST_FOREACH(current, &(CUR_CELL->workspace->focus_stack), focus_clients) {
+                        if (++count < times) {
+                                LOG("Skipping\n");
+                                continue;
+                        }
+
+                        LOG("Focussing\n");
+                        set_focus(conn, current, true);
+                        break;
+                }
+                return;
+        }
+
+        /* Select the next client matching the criteria parsed above */
+        SLIST_FOREACH(current, &(CUR_CELL->workspace->focus_stack), focus_clients)
+                if (client_is_floating(current) == floating_criteria) {
+                        set_focus(conn, current, true);
+                        break;
+                }
+}
+
+/*
+ * Goes through the list of arguments (for exec()) and checks if the given argument
+ * is present. If not, it copies the arguments (because we cannot realloc it) and
+ * appends the given argument.
+ *
+ */
+static char **append_argument(char **original, char *argument) {
+        int num_args;
+        for (num_args = 0; original[num_args] != NULL; num_args++) {
+                LOG("original argument: \"%s\"\n", original[num_args]);
+                /* If the argument is already present we return the original pointer */
+                if (strcmp(original[num_args], argument) == 0)
+                        return original;
+        }
+        /* Copy the original array */
+        char **result = smalloc((num_args+2) * sizeof(char*));
+        memcpy(result, original, num_args * sizeof(char*));
+        result[num_args] = argument;
+        result[num_args+1] = NULL;
+
+        return result;
+}
+
 /*
  * Parses a command, see file CMDMODE for more information
  *
  */
 void parse_command(xcb_connection_t *conn, const char *command) {
-        printf("--- parsing command \"%s\" ---\n", command);
+        LOG("--- parsing command \"%s\" ---\n", command);
+        /* Get the first client from focus stack because floating clients are not
+         * in any container, therefore CUR_CELL is not appropriate. */
+        Client *last_focused = SLIST_FIRST(&(c_ws->focus_stack));
+        if (last_focused == SLIST_END(&(c_ws->focus_stack)))
+                last_focused = NULL;
+
         /* Hmm, just to be sure */
         if (command[0] == '\0')
                 return;
 
-        /* Is it an <exec>? */
-        if (strncmp(command, "exec ", strlen("exec ")) == 0) {
-                printf("starting \"%s\"\n", command + strlen("exec "));
+        /* Is it an <exec>? Then execute the given command. */
+        if (STARTS_WITH(command, "exec ")) {
+                LOG("starting \"%s\"\n", command + strlen("exec "));
                 start_application(command+strlen("exec "));
                 return;
         }
 
+        /* Is it an <exit>? */
+        if (STARTS_WITH(command, "exit")) {
+                LOG("User issued exit-command, exiting without error.\n");
+                exit(EXIT_SUCCESS);
+        }
+
+        /* Is it <restart>? Then restart in place. */
+        if (STARTS_WITH(command, "restart")) {
+                LOG("restarting \"%s\"...\n", start_argv[0]);
+                /* make sure -a is in the argument list or append it */
+                start_argv = append_argument(start_argv, "-a");
+
+                execvp(start_argv[0], start_argv);
+                /* not reached */
+        }
+
+        if (STARTS_WITH(command, "kill")) {
+                if (last_focused == NULL) {
+                        LOG("There is no window to kill\n");
+                        return;
+                }
+
+                LOG("Killing current window\n");
+                client_kill(conn, last_focused);
+                return;
+        }
+
+        /* Is it a jump to a specified workspace, row, col? */
+        if (STARTS_WITH(command, "jump ")) {
+                const char *arguments = command + strlen("jump ");
+                if (arguments[0] == '"')
+                        jump_to_window(conn, arguments);
+                else jump_to_container(conn, arguments);
+                return;
+        }
+
+        /* Should we travel the focus stack? */
+        if (STARTS_WITH(command, "focus")) {
+                const char *arguments = command + strlen("focus ");
+                travel_focus_stack(conn, arguments);
+                return;
+        }
+
         /* Is it 'f' for fullscreen? */
         if (command[0] == 'f') {
-                if (CUR_CELL->currently_focused == NULL)
+                if (last_focused == NULL)
                         return;
-                toggle_fullscreen(conn, CUR_CELL->currently_focused);
+                client_toggle_fullscreen(conn, last_focused);
                 return;
         }
 
+        /* Is it just 's' for stacking or 'd' for default? */
+        if ((command[0] == 's' || command[0] == 'd') && (command[1] == '\0')) {
+                if (last_focused == NULL || client_is_floating(last_focused)) {
+                        LOG("not switching, this is a floating client\n");
+                        return;
+                }
+                LOG("Switching mode for current container\n");
+                switch_layout_mode(conn, CUR_CELL, (command[0] == 's' ? MODE_STACK : MODE_DEFAULT));
+                return;
+        }
+
+        if (command[0] == 'H') {
+                LOG("Hiding all floating windows\n");
+                floating_toggle_hide(conn, c_ws);
+                return;
+        }
+
+        enum { WITH_WINDOW, WITH_CONTAINER, WITH_WORKSPACE } with = WITH_WINDOW;
+
         /* Is it a <with>? */
         if (command[0] == 'w') {
+                command++;
                 /* TODO: implement */
-                printf("not yet implemented.\n");
+                if (command[0] == 'c') {
+                        with = WITH_CONTAINER;
+                        command++;
+                } else if (command[0] == 'w') {
+                        with = WITH_WORKSPACE;
+                        command++;
+                } else {
+                        LOG("not yet implemented.\n");
+                        return;
+                }
+        }
+
+        /* Is it 't' for toggle tiling/floating? */
+        if (command[0] == 't') {
+                if (with == WITH_WORKSPACE) {
+                        c_ws->auto_float = !c_ws->auto_float;
+                        LOG("autofloat is now %d\n", c_ws->auto_float);
+                        return;
+                }
+                if (last_focused == NULL) {
+                        LOG("Cannot toggle tiling/floating: workspace empty\n");
+                        return;
+                }
+
+                toggle_floating_mode(conn, last_focused, false);
+                /* delete all empty columns/rows */
+                cleanup_table(conn, last_focused->workspace);
+
+                /* Fix colspan/rowspan if it’d overlap */
+                fix_colrowspan(conn, last_focused->workspace);
+
+                render_workspace(conn, last_focused->workspace->screen, last_focused->workspace);
+
+                /* Re-focus the client because cleanup_table sets the focus to the last
+                 * focused client inside a container only. */
+                set_focus(conn, last_focused, true);
+
                 return;
         }
 
-        /* It's a normal <cmd> */
-        int times;
+        /* It’s a normal <cmd> */
         char *rest = NULL;
         enum { ACTION_FOCUS, ACTION_MOVE, ACTION_SNAP } action = ACTION_FOCUS;
         direction_t direction;
-        times = strtol(command, &rest, 10);
+        int times = strtol(command, &rest, 10);
         if (rest == NULL) {
-                printf("Invalid command (\"%s\")\n", command);
+                LOG("Invalid command (\"%s\")\n", command);
                 return;
         }
+
+        if (*rest == '\0') {
+                /* No rest? This was a workspace number, not a times specification */
+                show_workspace(conn, times);
+                return;
+        }
+
         if (*rest == 'm' || *rest == 's') {
                 action = (*rest == 'm' ? ACTION_MOVE : ACTION_SNAP);
                 rest++;
         }
 
+        int workspace = strtol(rest, &rest, 10);
+
+        if (rest == NULL) {
+                LOG("Invalid command (\"%s\")\n", command);
+                return;
+        }
+
         if (*rest == '\0') {
-                /* No rest? This was a tag number, not a times specification */
-                show_workspace(conn, times);
+                if (last_focused != NULL && client_is_floating(last_focused))
+                        move_floating_window_to_workspace(conn, last_focused, workspace);
+                else move_current_window_to_workspace(conn, workspace);
+                return;
+        }
+
+        if (last_focused == NULL) {
+                LOG("Not performing (no window found)\n");
+                return;
+        }
+
+        if (client_is_floating(last_focused) &&
+            (action != ACTION_FOCUS && action != ACTION_MOVE)) {
+                LOG("Not performing (floating)\n");
                 return;
         }
 
@@ -374,19 +1040,36 @@ void parse_command(xcb_connection_t *conn, const char *command) {
                 else if (*rest == 'l')
                         direction = D_RIGHT;
                 else {
-                        printf("unknown direction: %c\n", *rest);
+                        LOG("unknown direction: %c\n", *rest);
                         return;
                 }
+                rest++;
 
-                if (action == ACTION_FOCUS)
-                        focus_window(conn, direction);
-                else if (action == ACTION_MOVE)
-                        move_current_window(conn, direction);
-                else if (action == ACTION_SNAP)
-                        snap_current_container(conn, direction);
+                if (action == ACTION_FOCUS) {
+                        if (client_is_floating(last_focused)) {
+                                floating_focus_direction(conn, last_focused, direction);
+                                continue;
+                        }
+                        focus_thing(conn, direction, (with == WITH_WINDOW ? THING_WINDOW : THING_CONTAINER));
+                        continue;
+                }
 
-                rest++;
+                if (action == ACTION_MOVE) {
+                        if (client_is_floating(last_focused)) {
+                                floating_move(conn, last_focused, direction);
+                                continue;
+                        }
+                        if (with == WITH_WINDOW)
+                                move_current_window(conn, direction);
+                        else move_current_container(conn, direction);
+                        continue;
+                }
+
+                if (action == ACTION_SNAP) {
+                        snap_current_container(conn, direction);
+                        continue;
+                }
         }
 
-        printf("--- done ---\n");
+        LOG("--- done ---\n");
 }