]> git.sur5r.net Git - i3/i3/blobdiff - src/layout.c
Implement assignments of workspaces to screens, big cleanup of workspace code
[i3/i3] / src / layout.c
index ac3ee36149917dc02e6f942312062d3df466bf72..c0471173bd0e376d251001f110f830e13298cb8c 100644 (file)
@@ -15,6 +15,7 @@
 #include <stdlib.h>
 #include <xcb/xcb.h>
 #include <assert.h>
+#include <math.h>
 
 #include "config.h"
 #include "i3.h"
 #include "util.h"
 #include "xinerama.h"
 #include "layout.h"
+#include "client.h"
+#include "floating.h"
 
-/* This macro copies the old value of the given variable, changes the variable to contain
-   the new one and returns true if it changed.
-   Note that when combining multiple HAS_CHANGED statements, you need to use different variables.
-   If someone by chance knows why this is necessary (order of expressions in gcc?) and/or can
-   come up with a fix, please mail me. */
-#define HAS_CHANGED(temp, value, new) (temp = value, temp != (value = new))
+/*
+ * Updates *destination with new_value and returns true if it was changed or false
+ * if it was the same
+ *
+ */
+static bool update_if_necessary(uint32_t *destination, const uint32_t new_value) {
+        uint32_t old_value = *destination;
 
-static int old_value_1;
-static int old_value_2;
-static int old_value_3;
-static int old_value_4;
+        return ((*destination = new_value) != old_value);
+}
 
 /*
  * Gets the unoccupied space (= space which is available for windows which were resized by the user)
@@ -42,23 +44,20 @@ static int old_value_4;
  * windows correctly, meaning that the aspect ratio will be maintained when opening new windows.
  *
  */
-int get_unoccupied_x(Workspace *workspace, int row) {
+int get_unoccupied_x(Workspace *workspace) {
         int unoccupied = workspace->rect.width;
         float default_factor = ((float)workspace->rect.width / workspace->cols) / workspace->rect.width;
 
-        printf("get_unoccupied_x(), starting with %d, default_factor = %f\n", unoccupied, default_factor);
+        LOG("get_unoccupied_x(), starting with %d, default_factor = %f\n", unoccupied, default_factor);
 
-        for (int cols = 0; cols < workspace->cols;) {
-                Container *con = workspace->table[cols][row];
-                printf("width_factor[%d][%d] = %f, colspan = %d\n", cols, row, con->width_factor, con->colspan);
-                if (con->width_factor == 0)
-                        unoccupied -= workspace->rect.width * default_factor * con->colspan;
-                cols += con->colspan;
-        }
+        for (int cols = 0; cols < workspace->cols; cols++) {
+                LOG("width_factor[%d] = %f\n", cols, workspace->width_factor[cols]);
 
-        assert(unoccupied != 0);
+                if (workspace->width_factor[cols] == 0)
+                        unoccupied -= workspace->rect.width * default_factor;
+        }
 
-        printf("unoccupied space: %d\n", unoccupied);
+        LOG("unoccupied space: %d\n", unoccupied);
         return unoccupied;
 }
 
@@ -67,19 +66,15 @@ int get_unoccupied_y(Workspace *workspace, int col) {
         int unoccupied = workspace->rect.height;
         float default_factor = ((float)workspace->rect.height / workspace->rows) / workspace->rect.height;
 
-        printf("get_unoccupied_y(), starting with %d, default_factor = %f\n", unoccupied, default_factor);
+        LOG("get_unoccupied_y(), starting with %d, default_factor = %f\n", unoccupied, default_factor);
 
-        for (int rows = 0; rows < workspace->rows;) {
-                Container *con = workspace->table[col][rows];
-                printf("height_factor[%d][%d] = %f, rowspan %d\n", col, rows, con->height_factor, con->rowspan);
-                if (con->height_factor == 0)
-                        unoccupied -= workspace->rect.height * default_factor * con->rowspan;
-                rows += con->rowspan;
+        for (int rows = 0; rows < workspace->rows; rows++) {
+                LOG("height_factor[%d] = %f\n", rows, workspace->height_factor[rows]);
+                if (workspace->height_factor[rows] == 0)
+                        unoccupied -= workspace->rect.height * default_factor;
         }
 
-        assert(unoccupied != 0);
-
-        printf("unoccupied space: %d\n", unoccupied);
+        LOG("unoccupied space: %d\n", unoccupied);
         return unoccupied;
 }
 
@@ -90,10 +85,13 @@ int get_unoccupied_y(Workspace *workspace, int col) {
  *
  */
 void redecorate_window(xcb_connection_t *conn, Client *client) {
-        if (client->container->mode == MODE_STACK) {
+        if (client->container != NULL && client->container->mode == MODE_STACK) {
                 render_container(conn, client->container);
-                xcb_flush(conn);
+                /* We clear the frame to generate exposure events, because the color used
+                   in drawing may be different */
+                xcb_clear_area(conn, true, client->frame, 0, 0, client->rect.width, client->rect.height);
         } else decorate_window(conn, client, client->frame, client->titlegc, 0);
+        xcb_flush(conn);
 }
 
 /*
@@ -103,82 +101,122 @@ void redecorate_window(xcb_connection_t *conn, Client *client) {
  */
 void decorate_window(xcb_connection_t *conn, Client *client, xcb_drawable_t drawable, xcb_gcontext_t gc, int offset) {
         i3Font *font = load_font(conn, config.font);
-        uint32_t background_color,
-                 text_color,
-                 border_color;
+        int decoration_height = font->height + 2 + 2;
+        struct Colortriple *color;
+        Client *last_focused;
 
         /* Clients without a container (docks) won’t get decorated */
-        if (client->container == NULL)
+        if (client->dock)
                 return;
 
-        if (client->container->currently_focused == client) {
-                /* Distinguish if the window is currently focused… */
-                if (CUR_CELL->currently_focused == client)
-                        background_color = get_colorpixel(conn, client, client->frame, "#285577");
-                /* …or if it is the focused window in a not focused container */
-                else background_color = get_colorpixel(conn, client, client->frame, "#555555");
-
-                text_color = get_colorpixel(conn, client, client->frame, "#ffffff");
-                border_color = get_colorpixel(conn, client, client->frame, "#4c7899");
+        LOG("redecorating child %08x\n", client->child);
+        last_focused = SLIST_FIRST(&(client->workspace->focus_stack));
+        if (client_is_floating(client)) {
+                if (last_focused == client)
+                        color = &(config.client.focused);
+                else color = &(config.client.unfocused);
         } else {
-                background_color = get_colorpixel(conn, client, client->frame, "#222222");
-                text_color = get_colorpixel(conn, client, client->frame, "#888888");
-                border_color = get_colorpixel(conn, client, client->frame, "#333333");
+                if (client->container->currently_focused == client) {
+                        /* Distinguish if the window is currently focused… */
+                        if (last_focused == client)
+                                color = &(config.client.focused);
+                        /* …or if it is the focused window in a not focused container */
+                        else color = &(config.client.focused_inactive);
+                } else color = &(config.client.unfocused);
         }
 
         /* Our plan is the following:
-           - Draw a rect around the whole client in background_color
+           - Draw a rect around the whole client in color->background
            - Draw two lines in a lighter color
            - Draw the window’s title
          */
 
         /* Draw a rectangle in background color around the window */
-        xcb_change_gc_single(conn, gc, XCB_GC_FOREGROUND, background_color);
-
-        /* We need to use the container’s width because it is the more recent value - when
-           in stacking mode, clients get reconfigured only on demand (the not active client
-           is not reconfigured), so the client’s rect.width would be wrong */
-        xcb_rectangle_t rect = {0, offset, client->container->width, offset + client->rect.height};
-        xcb_poly_fill_rectangle(conn, drawable, gc, 1, &rect);
-
-        /* Draw the lines */
-        xcb_draw_line(conn, drawable, gc, border_color, 2, offset, client->rect.width, offset);
-        xcb_draw_line(conn, drawable, gc, border_color, 2, offset + font->height + 3,
-                      2 + client->rect.width, offset + font->height + 3);
-
-        /* Draw the font */
-        uint32_t mask = XCB_GC_FOREGROUND | XCB_GC_BACKGROUND | XCB_GC_FONT;
-        uint32_t values[] = { text_color, background_color, font->id };
-        xcb_change_gc(conn, gc, mask, values);
-
-        /* TODO: utf8? */
-        char *label;
-        asprintf(&label, "%.*s", client->name_len, client->name);
-        xcb_void_cookie_t text_cookie = xcb_image_text_8_checked(conn, strlen(label), drawable,
-                                        gc, 3 /* X */, offset + font->height /* Y = baseline of font */, label);
-        check_error(conn, text_cookie, "Could not draw client's title");
-        free(label);
+        xcb_change_gc_single(conn, gc, XCB_GC_FOREGROUND, color->background);
+
+        /* In stacking mode, we only render the rect for this specific decoration */
+        if (client->container != NULL && client->container->mode == MODE_STACK) {
+                /* We need to use the container’s width because it is the more recent value - when
+                   in stacking mode, clients get reconfigured only on demand (the not active client
+                   is not reconfigured), so the client’s rect.width would be wrong */
+                xcb_rectangle_t rect = {0, offset, client->container->width, offset + decoration_height };
+                xcb_poly_fill_rectangle(conn, drawable, gc, 1, &rect);
+        } else {
+                xcb_rectangle_t rect = {0, 0, client->rect.width, client->rect.height};
+                xcb_poly_fill_rectangle(conn, drawable, gc, 1, &rect);
+
+                /* Draw the inner background to have a black frame around clients (such as mplayer)
+                   which cannot be resized exactly in our frames and therefore are centered */
+                xcb_change_gc_single(conn, client->titlegc, XCB_GC_FOREGROUND, get_colorpixel(conn, "#000000"));
+                xcb_rectangle_t crect = {2, decoration_height,
+                                         client->rect.width - (2 + 2), client->rect.height - 2 - decoration_height};
+                xcb_poly_fill_rectangle(conn, client->frame, client->titlegc, 1, &crect);
+        }
+
+        if (client->titlebar_position != TITLEBAR_OFF) {
+                /* Draw the lines */
+                xcb_draw_line(conn, drawable, gc, color->border, 0, offset, client->rect.width, offset);
+                xcb_draw_line(conn, drawable, gc, color->border, 2, offset + font->height + 3,
+                              client->rect.width - 3, offset + font->height + 3);
+        }
+
+        /* If the client has a title, we draw it */
+        if (client->name != NULL) {
+                /* Draw the font */
+                uint32_t mask = XCB_GC_FOREGROUND | XCB_GC_BACKGROUND | XCB_GC_FONT;
+                uint32_t values[] = { color->text, color->background, font->id };
+                xcb_change_gc(conn, gc, mask, values);
+
+                /* name_len == -1 means this is a legacy application which does not specify _NET_WM_NAME,
+                   and we don’t handle the old window name (COMPOUND_TEXT) but only _NET_WM_NAME, which
+                   is UTF-8 */
+                if (client->name_len == -1)
+                        xcb_image_text_8(conn, strlen(client->name), drawable, gc, 3 /* X */,
+                                         offset + font->height /* Y = baseline of font */, client->name);
+                else
+                        xcb_image_text_16(conn, client->name_len, drawable, gc, 3 /* X */,
+                                          offset + font->height /* Y = baseline of font */, (xcb_char2b_t*)client->name);
+        }
 }
 
 /*
  * Pushes the client’s x and y coordinates to X11
  *
  */
-static void reposition_client(xcb_connection_t *conn, Client *client) {
-        printf("frame needs to be pushed to %dx%d\n", client->rect.x, client->rect.y);
+void reposition_client(xcb_connection_t *conn, Client *client) {
+        i3Screen *screen;
+
+        LOG("frame 0x%08x needs to be pushed to %dx%d\n", client->frame, client->rect.x, client->rect.y);
         /* Note: We can use a pointer to client->x like an array of uint32_ts
            because it is followed by client->y by definition */
         xcb_configure_window(conn, client->frame, XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_Y, &(client->rect.x));
+
+        if (!client_is_floating(client))
+                return;
+
+        /* If the client is floating, we need to check if we moved it to a different workspace */
+        if (client->workspace->screen == (screen = get_screen_containing(client->rect.x, client->rect.y)))
+                return;
+
+        if (screen == NULL) {
+                LOG("Boundary checking disabled, no screen found for (%d, %d)\n", client->rect.x, client->rect.y);
+                return;
+        }
+
+        LOG("Client is on workspace %p with screen %p\n", client->workspace, client->workspace->screen);
+        LOG("but screen at %d, %d is %p\n", client->rect.x, client->rect.y, screen);
+        floating_assign_to_workspace(client, &workspaces[screen->current_workspace]);
+        LOG("fixed that\n");
 }
 
 /*
  * Pushes the client’s width/height to X11 and resizes the child window
  *
  */
-static void resize_client(xcb_connection_t *conn, Client *client) {
+void resize_client(xcb_connection_t *conn, Client *client) {
         i3Font *font = load_font(conn, config.font);
 
-        printf("resizing client to %d x %d\n", client->rect.width, client->rect.height);
+        LOG("resizing client 0x%08x to %d x %d\n", client->frame, client->rect.width, client->rect.height);
         xcb_configure_window(conn, client->frame,
                         XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT,
                         &(client->rect.width));
@@ -191,7 +229,7 @@ static void resize_client(xcb_connection_t *conn, Client *client) {
                         XCB_CONFIG_WINDOW_WIDTH |
                         XCB_CONFIG_WINDOW_HEIGHT;
         Rect *rect = &(client->child_rect);
-        switch (client->container->mode) {
+        switch ((client->container != NULL ? client->container->mode : MODE_DEFAULT)) {
                 case MODE_STACK:
                         rect->x = 2;
                         rect->y = 0;
@@ -199,11 +237,16 @@ static void resize_client(xcb_connection_t *conn, Client *client) {
                         rect->height = client->rect.height - 2;
                         break;
                 default:
-                        if (client->titlebar_position == TITLEBAR_OFF) {
+                        if (client->titlebar_position == TITLEBAR_OFF && client->borderless) {
                                 rect->x = 0;
                                 rect->y = 0;
                                 rect->width = client->rect.width;
                                 rect->height = client->rect.height;
+                        } else if (client->titlebar_position == TITLEBAR_OFF && !client->borderless) {
+                                rect->x = 1;
+                                rect->y = 1;
+                                rect->width = client->rect.width - 1 - 1;
+                                rect->height = client->rect.height - 1 - 1;
                         } else {
                                 rect->x = 2;
                                 rect->y = font->height + 2 + 2;
@@ -213,29 +256,36 @@ static void resize_client(xcb_connection_t *conn, Client *client) {
                         break;
         }
 
-        printf("child will be at %dx%d with size %dx%d\n", rect->x, rect->y, rect->width, rect->height);
+        /* Obey the ratio, if any */
+        if (client->proportional_height != 0 &&
+            client->proportional_width != 0) {
+                LOG("proportional height = %d, width = %d\n", client->proportional_height, client->proportional_width);
+                double new_height = rect->height + 1;
+                int new_width = rect->width;
 
-        xcb_configure_window(conn, client->child, mask, &(rect->x));
+                while (new_height > rect->height) {
+                        new_height = ((double)client->proportional_height / client->proportional_width) * new_width;
 
-        /* After configuring a child window we need to fake a configure_notify_event according
-           to ICCCM 4.2.3. This seems rather broken, especially since X sends exactly the same
-           configure_notify_event automatically according to xtrace. Anyone knows details? */
-        xcb_configure_notify_event_t event;
+                        if (new_height > rect->height)
+                                new_width--;
+                }
+                /* Center the window */
+                rect->y += ceil(rect->height / 2) - floor(new_height / 2);
+                rect->x += ceil(rect->width / 2) - floor(new_width / 2);
 
-        event.event = client->child;
-        event.window = client->child;
-        event.response_type = XCB_CONFIGURE_NOTIFY;
+                rect->height = new_height;
+                rect->width = new_width;
+                LOG("new_height = %f, new_width = %d\n", new_height, new_width);
+        }
 
-        event.x = rect->x;
-        event.y = rect->y;
-        event.width = rect->width;
-        event.height = rect->height;
+        LOG("child will be at %dx%d with size %dx%d\n", rect->x, rect->y, rect->width, rect->height);
 
-        event.border_width = 0;
-        event.above_sibling = XCB_NONE;
-        event.override_redirect = false;
+        xcb_configure_window(conn, client->child, mask, &(rect->x));
 
-        xcb_send_event(conn, false, client->child, XCB_EVENT_MASK_STRUCTURE_NOTIFY, (char*)&event);
+        /* After configuring a child window we need to fake a configure_notify_event (see ICCCM 4.2.3).
+         * This is necessary to inform the client of its position relative to the root window,
+         * not relative to its frame (as done in the configure_notify_event by the x server). */
+        fake_absolute_configure_notify(conn, client);
 }
 
 /*
@@ -247,27 +297,30 @@ void render_container(xcb_connection_t *conn, Container *container) {
         Client *client;
         int num_clients = 0, current_client = 0;
 
-        if (container->currently_focused == NULL)
-                return;
-
         CIRCLEQ_FOREACH(client, &(container->clients), clients)
                 num_clients++;
 
         if (container->mode == MODE_DEFAULT) {
-                printf("got %d clients in this default container.\n", num_clients);
+                LOG("got %d clients in this default container.\n", num_clients);
                 CIRCLEQ_FOREACH(client, &(container->clients), clients) {
+                        /* If the client is in fullscreen mode, it does not get reconfigured */
+                        if (container->workspace->fullscreen_client == client) {
+                                current_client++;
+                                continue;
+                        }
+
                         /* Check if we changed client->x or client->y by updating it.
                          * Note the bitwise OR instead of logical OR to force evaluation of both statements */
                         if (client->force_reconfigure |
-                            HAS_CHANGED(old_value_1, client->rect.x, container->x) |
-                            HAS_CHANGED(old_value_2, client->rect.y, container->y +
+                            update_if_necessary(&(client->rect.x), container->x) |
+                            update_if_necessary(&(client->rect.y), container->y +
                                         (container->height / num_clients) * current_client))
                                 reposition_client(conn, client);
 
                         /* TODO: vertical default layout */
                         if (client->force_reconfigure |
-                            HAS_CHANGED(old_value_1, client->rect.width, container->width) |
-                            HAS_CHANGED(old_value_2, client->rect.height, container->height / num_clients))
+                            update_if_necessary(&(client->rect.width), container->width) |
+                            update_if_necessary(&(client->rect.height), container->height / num_clients))
                                 resize_client(conn, client);
 
                         client->force_reconfigure = false;
@@ -281,97 +334,108 @@ void render_container(xcb_connection_t *conn, Container *container) {
 
                 /* Check if we need to remap our stack title window, it gets unmapped when the container
                    is empty in src/handlers.c:unmap_notify() */
-                if (stack_win->rect.height == 0)
+                if (stack_win->rect.height == 0 && num_clients > 0)
                         xcb_map_window(conn, stack_win->window);
 
                 /* Check if we need to reconfigure our stack title window */
-                if (HAS_CHANGED(old_value_1, stack_win->rect.x, container->x) |
-                    HAS_CHANGED(old_value_2, stack_win->rect.y, container->y) |
-                    HAS_CHANGED(old_value_3, stack_win->rect.width, container->width) |
-                    HAS_CHANGED(old_value_4, stack_win->rect.height, decoration_height * num_clients)) {
+                if (update_if_necessary(&(stack_win->rect.x), container->x) |
+                    update_if_necessary(&(stack_win->rect.y), container->y) |
+                    update_if_necessary(&(stack_win->rect.width), container->width) |
+                    update_if_necessary(&(stack_win->rect.height), decoration_height * num_clients)) {
+
+                        /* Configuration can happen in two slightly different ways:
+
+                           If there is no client in fullscreen mode, 5 parameters are passed
+                           (x, y, width, height, stack mode is set to above which means top-most position).
 
+                           If there is a fullscreen client, the fourth parameter is set to to the
+                           fullscreen window as sibling and the stack mode is set to below, which means
+                           that the stack_window will be placed just below the sibling, that is, under
+                           the fullscreen window.
+                         */
                         uint32_t values[] = { stack_win->rect.x, stack_win->rect.y,
                                               stack_win->rect.width, stack_win->rect.height,
-                                              XCB_STACK_MODE_ABOVE };
+                                              XCB_STACK_MODE_ABOVE, XCB_STACK_MODE_BELOW };
+                        uint32_t mask = XCB_CONFIG_WINDOW_X | XCB_CONFIG_WINDOW_Y |
+                                        XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT |
+                                        XCB_CONFIG_WINDOW_STACK_MODE;
+
+                        /* Raise the stack window, but keep it below the first floating client
+                         * and below the fullscreen client (if any) */
+                        Client *first_floating = TAILQ_FIRST(&(container->workspace->floating_clients));
+                        if (first_floating != TAILQ_END(&(container->workspace->floating_clients))) {
+                                mask |= XCB_CONFIG_WINDOW_SIBLING;
+                                values[4] = first_floating->frame;
+                        } else if (container->workspace->fullscreen_client != NULL) {
+                                mask |= XCB_CONFIG_WINDOW_SIBLING;
+                                values[4] = container->workspace->fullscreen_client->frame;
+                        }
 
-                        xcb_configure_window(conn, stack_win->window,
-                                             XCB_CONFIG_WINDOW_X     | XCB_CONFIG_WINDOW_Y      |
-                                             XCB_CONFIG_WINDOW_WIDTH | XCB_CONFIG_WINDOW_HEIGHT |
-                                             XCB_CONFIG_WINDOW_STACK_MODE,
-                                             values);
+                        xcb_configure_window(conn, stack_win->window, mask, values);
                 }
 
-                /* Reconfigure the currently focused client, if necessary. It is the only visible one */
-                client = container->currently_focused;
-
-                if (container->workspace->fullscreen_client == NULL) {
-                        uint32_t values[] = { XCB_STACK_MODE_ABOVE };
-                        xcb_configure_window(conn, client->frame, XCB_CONFIG_WINDOW_STACK_MODE, values);
-                }
+                /* Prepare the pixmap for usage */
+                cached_pixmap_prepare(conn, &(stack_win->pixmap));
 
                 /* Render the decorations of all clients */
                 CIRCLEQ_FOREACH(client, &(container->clients), clients) {
+                        /* If the client is in fullscreen mode, it does not get reconfigured */
+                        if (container->workspace->fullscreen_client == client) {
+                                current_client++;
+                                continue;
+                        }
+
                         /* Check if we changed client->x or client->y by updating it.
                          * Note the bitwise OR instead of logical OR to force evaluation of both statements */
                         if (client->force_reconfigure |
-                            HAS_CHANGED(old_value_1, client->rect.x, container->x) |
-                            HAS_CHANGED(old_value_2, client->rect.y, container->y + (decoration_height * num_clients)))
+                            update_if_necessary(&(client->rect.x), container->x) |
+                            update_if_necessary(&(client->rect.y), container->y + (decoration_height * num_clients)))
                                 reposition_client(conn, client);
 
                         if (client->force_reconfigure |
-                            HAS_CHANGED(old_value_1, client->rect.width, container->width) |
-                            HAS_CHANGED(old_value_2, client->rect.height, container->height - (decoration_height * num_clients)))
+                            update_if_necessary(&(client->rect.width), container->width) |
+                            update_if_necessary(&(client->rect.height), container->height - (decoration_height * num_clients)))
                                 resize_client(conn, client);
 
                         client->force_reconfigure = false;
 
-                        decorate_window(conn, client, stack_win->window, stack_win->gc,
+                        decorate_window(conn, client, stack_win->pixmap.id, stack_win->pixmap.gc,
                                         current_client++ * decoration_height);
                 }
+
+                xcb_copy_area(conn, stack_win->pixmap.id, stack_win->window, stack_win->pixmap.gc,
+                              0, 0, 0, 0, stack_win->rect.width, stack_win->rect.height);
         }
 }
 
 static void render_bars(xcb_connection_t *conn, Workspace *r_ws, int width, int *height) {
         Client *client;
-        SLIST_FOREACH(client, &(r_ws->dock_clients), dock_clients) {
+        SLIST_FOREACH(client, &(r_ws->screen->dock_clients), dock_clients) {
+                LOG("client is at %d, should be at %d\n", client->rect.y, *height);
                 if (client->force_reconfigure |
-                    HAS_CHANGED(old_value_1, client->rect.x, 0) |
-                    HAS_CHANGED(old_value_2, client->rect.y, *height))
+                    update_if_necessary(&(client->rect.x), r_ws->rect.x) |
+                    update_if_necessary(&(client->rect.y), *height))
                         reposition_client(conn, client);
 
                 if (client->force_reconfigure |
-                    HAS_CHANGED(old_value_1, client->rect.width, width) |
-                    HAS_CHANGED(old_value_2, client->rect.height, client->desired_height))
+                    update_if_necessary(&(client->rect.width), width) |
+                    update_if_necessary(&(client->rect.height), client->desired_height))
                         resize_client(conn, client);
 
                 client->force_reconfigure = false;
+                LOG("desired_height = %d\n", client->desired_height);
                 *height += client->desired_height;
         }
 }
 
 static void render_internal_bar(xcb_connection_t *conn, Workspace *r_ws, int width, int height) {
-        printf("Rendering internal bar\n");
+        LOG("Rendering internal bar\n");
         i3Font *font = load_font(conn, config.font);
         i3Screen *screen = r_ws->screen;
         enum { SET_NORMAL = 0, SET_FOCUSED = 1 };
-        uint32_t background_color[2],
-                 text_color[2],
-                 border_color[2],
-                 black;
-        char label[3];
-
-        black = get_colorpixel(conn, NULL, screen->bar, "#000000");
-
-        background_color[SET_NORMAL] = get_colorpixel(conn, NULL, screen->bar, "#222222");
-        text_color[SET_NORMAL] = get_colorpixel(conn, NULL, screen->bar, "#888888");
-        border_color[SET_NORMAL] = get_colorpixel(conn, NULL, screen->bar, "#333333");
-
-        background_color[SET_FOCUSED] = get_colorpixel(conn, NULL, screen->bar, "#285577");
-        text_color[SET_FOCUSED] = get_colorpixel(conn, NULL, screen->bar, "#ffffff");
-        border_color[SET_FOCUSED] = get_colorpixel(conn, NULL, screen->bar, "#4c7899");
 
         /* Fill the whole bar in black */
-        xcb_change_gc_single(conn, screen->bargc, XCB_GC_FOREGROUND, black);
+        xcb_change_gc_single(conn, screen->bargc, XCB_GC_FOREGROUND, get_colorpixel(conn, "#000000"));
         xcb_rectangle_t rect = {0, 0, width, height};
         xcb_poly_fill_rectangle(conn, screen->bar, screen->bargc, 1, &rect);
 
@@ -380,95 +444,156 @@ static void render_internal_bar(xcb_connection_t *conn, Workspace *r_ws, int wid
 
         int drawn = 0;
         for (int c = 0; c < 10; c++) {
-                if (workspaces[c].screen == screen) {
-                        int set = (screen->current_workspace == c ? SET_FOCUSED : SET_NORMAL);
-
-                        xcb_draw_rect(conn, screen->bar, screen->bargc, border_color[set],
-                                      drawn * height, 1, height - 2, height - 2);
-                        xcb_draw_rect(conn, screen->bar, screen->bargc, background_color[set],
-                                      drawn * height + 1, 2, height - 4, height - 4);
-
-                        snprintf(label, sizeof(label), "%d", c+1);
-                        xcb_change_gc_single(conn, screen->bargc, XCB_GC_FOREGROUND, text_color[set]);
-                        xcb_change_gc_single(conn, screen->bargc, XCB_GC_BACKGROUND, background_color[set]);
-                        xcb_void_cookie_t text_cookie = xcb_image_text_8_checked(conn, strlen(label), screen->bar,
-                                                        screen->bargc, drawn * height + 5 /* X */,
-                                                        font->height + 1 /* Y = baseline of font */, label);
-                        check_error(conn, text_cookie, "Could not draw workspace title");
-                        drawn++;
-                }
+                if (workspaces[c].screen != screen)
+                        continue;
+
+                struct Colortriple *color = (screen->current_workspace == c ? &(config.bar.focused) :
+                                             &(config.bar.unfocused));
+                Workspace *ws = &workspaces[c];
+
+                /* Draw the outer rect */
+                xcb_draw_rect(conn, screen->bar, screen->bargc, color->border,
+                              drawn,              /* x */
+                              1,                  /* y */
+                              ws->text_width + 5 + 5, /* width = text width + 5 px left + 5px right */
+                              height - 2          /* height = max. height - 1 px upper and 1 px bottom border */);
+
+                /* Draw the background of this rect */
+                xcb_draw_rect(conn, screen->bar, screen->bargc, color->background,
+                              drawn + 1,
+                              2,
+                              ws->text_width + 4 + 4,
+                              height - 4);
+
+                xcb_change_gc_single(conn, screen->bargc, XCB_GC_FOREGROUND, color->text);
+                xcb_change_gc_single(conn, screen->bargc, XCB_GC_BACKGROUND, color->background);
+                xcb_image_text_16(conn, ws->name_len, screen->bar, screen->bargc, drawn + 5 /* X */,
+                                  font->height + 1 /* Y = baseline of font */,
+                                  (xcb_char2b_t*)ws->name);
+                drawn += ws->text_width + 12;
         }
 
-        printf("done rendering internal\n");
+        LOG("done rendering internal\n");
 }
 
-void render_layout(xcb_connection_t *conn) {
-        i3Screen *screen;
+/*
+ * Modifies the event mask of all clients on the given workspace to either ignore or to handle
+ * enter notifies. It is handy to ignore notifies because they will be sent when a window is mapped
+ * under the cursor, thus when the user didn’t enter the window actively at all.
+ *
+ */
+void ignore_enter_notify_forall(xcb_connection_t *conn, Workspace *workspace, bool ignore_enter_notify) {
+        Client *client;
+        uint32_t values[1];
+
+        LOG("Ignore enter_notify = %d\n", ignore_enter_notify);
+
+        FOR_TABLE(workspace)
+                CIRCLEQ_FOREACH(client, &(workspace->table[cols][rows]->clients), clients) {
+                        /* Change event mask for the decorations */
+                        values[0] = FRAME_EVENT_MASK;
+                        if (ignore_enter_notify)
+                                values[0] &= ~(XCB_EVENT_MASK_ENTER_WINDOW);
+                        xcb_change_window_attributes(conn, client->frame, XCB_CW_EVENT_MASK, values);
+
+                        /* Change event mask for the child itself */
+                        values[0] = CHILD_EVENT_MASK;
+                        if (ignore_enter_notify)
+                                values[0] &= ~(XCB_EVENT_MASK_ENTER_WINDOW);
+                        xcb_change_window_attributes(conn, client->child, XCB_CW_EVENT_MASK, values);
+                }
+}
+
+/*
+ * Renders the given workspace on the given screen
+ *
+ */
+void render_workspace(xcb_connection_t *conn, i3Screen *screen, Workspace *r_ws) {
         i3Font *font = load_font(conn, config.font);
+        int width = r_ws->rect.width;
+        int height = r_ws->rect.height;
 
-        TAILQ_FOREACH(screen, virtual_screens, screens) {
-                /* r_ws (rendering workspace) is just a shortcut to the Workspace being currently rendered */
-                Workspace *r_ws = &(workspaces[screen->current_workspace]);
+        /* Reserve space for dock clients */
+        Client *client;
+        SLIST_FOREACH(client, &(screen->dock_clients), dock_clients)
+                height -= client->desired_height;
+
+        /* Space for the internal bar */
+        height -= (font->height + 6);
+
+        LOG("got %d rows and %d cols\n", r_ws->rows, r_ws->cols);
+
+        int xoffset[r_ws->rows];
+        int yoffset[r_ws->cols];
+        /* Initialize offsets */
+        for (int cols = 0; cols < r_ws->cols; cols++)
+                yoffset[cols] = r_ws->rect.y;
+        for (int rows = 0; rows < r_ws->rows; rows++)
+                xoffset[rows] = r_ws->rect.x;
+
+        dump_table(conn, r_ws);
+
+        ignore_enter_notify_forall(conn, r_ws, true);
+
+        /* Go through the whole table and render what’s necessary */
+        FOR_TABLE(r_ws) {
+                Container *container = r_ws->table[cols][rows];
+                int single_width = -1, single_height;
+                LOG("\n");
+                LOG("========\n");
+                LOG("container has %d colspan, %d rowspan\n",
+                                container->colspan, container->rowspan);
+                LOG("container at %d, %d\n", xoffset[rows], yoffset[cols]);
+                /* Update position of the container */
+                container->row = rows;
+                container->col = cols;
+                container->x = xoffset[rows];
+                container->y = yoffset[cols];
+                container->width = 0;
+
+                for (int c = 0; c < container->colspan; c++) {
+                        if (r_ws->width_factor[cols+c] == 0)
+                                container->width += (width / r_ws->cols);
+                        else container->width += get_unoccupied_x(r_ws) * r_ws->width_factor[cols+c];
+
+                        if (single_width == -1)
+                                single_width = container->width;
+                }
 
-                printf("Rendering screen %d\n", screen->num);
-                if (r_ws->fullscreen_client != NULL)
-                        /* This is easy: A client has entered fullscreen mode, so we don’t render at all */
-                        continue;
+                //if (container->height_factor == 0)
+                        container->height = (height / r_ws->rows);
+                //else container->height = get_unoccupied_y(r_ws, cols) * container->height_factor;
+                single_height = container->height;
+                container->height *= container->rowspan;
 
-                int width = r_ws->rect.width;
-                int height = r_ws->rect.height;
-
-                /* Reserve space for dock clients */
-                Client *client;
-                SLIST_FOREACH(client, &(r_ws->dock_clients), dock_clients)
-                        height -= client->desired_height;
-
-                /* Space for the internal bar */
-                height -= (font->height + 6);
-
-                printf("got %d rows and %d cols\n", r_ws->rows, r_ws->cols);
-
-                int xoffset[r_ws->rows];
-                int yoffset[r_ws->cols];
-                /* Initialize offsets */
-                for (int cols = 0; cols < r_ws->cols; cols++)
-                        yoffset[cols] = r_ws->rect.y;
-                for (int rows = 0; rows < r_ws->rows; rows++)
-                        xoffset[rows] = r_ws->rect.x;
-
-                /* Go through the whole table and render what’s necessary */
-                for (int cols = 0; cols < r_ws->cols; cols++)
-                        for (int rows = 0; rows < r_ws->rows; rows++) {
-                                Container *container = r_ws->table[cols][rows];
-                                printf("\n========\ncontainer has %d colspan, %d rowspan\n",
-                                                container->colspan, container->rowspan);
-                                printf("container at %d, %d\n", xoffset[rows], yoffset[cols]);
-                                /* Update position of the container */
-                                container->row = rows;
-                                container->col = cols;
-                                container->x = xoffset[rows];
-                                container->y = yoffset[cols];
-
-                                if (container->width_factor == 0)
-                                        container->width = (width / r_ws->cols);
-                                else container->width = get_unoccupied_x(r_ws, rows) * container->width_factor;
-                                container->width *= container->colspan;
-
-                                if (container->height_factor == 0)
-                                        container->height = (height / r_ws->rows);
-                                else container->height = get_unoccupied_y(r_ws, cols) * container->height_factor;
-                                container->height *= container->rowspan;
-
-                                /* Render the container if it is not empty */
-                                render_container(conn, container);
-
-                                xoffset[rows] += container->width;
-                                yoffset[cols] += container->height;
-                                printf("==========\n");
-                        }
+                /* Render the container if it is not empty */
+                render_container(conn, container);
+
+                xoffset[rows] += single_width;
+                yoffset[cols] += single_height;
+                LOG("==========\n");
+        }
 
-                render_bars(conn, r_ws, width, &height);
-                render_internal_bar(conn, r_ws, width, 18);
+        ignore_enter_notify_forall(conn, r_ws, false);
+
+        render_bars(conn, r_ws, width, &height);
+        render_internal_bar(conn, r_ws, width, font->height + 6);
+}
+
+/*
+ * Renders the whole layout, that is: Go through each screen, each workspace, each container
+ * and render each client. This also renders the bars.
+ *
+ * If you don’t need to render *everything*, you should call render_container on the container
+ * you want to refresh.
+ *
+ */
+void render_layout(xcb_connection_t *conn) {
+        i3Screen *screen;
+
+        TAILQ_FOREACH(screen, virtual_screens, screens) {
+                LOG("Rendering screen %d\n", screen->num);
+                render_workspace(conn, screen, &(workspaces[screen->current_workspace]));
         }
 
         xcb_flush(conn);