Change the root window cursor to 'watch' during startups

[i3/i3] / src / tree.c

diff --git a/src/tree.c b/src/tree.c
index fb6d6cc7ee5b44c5149f6e5799f8ec0639ac961c..8c73b6ab57eff07531b90e3c96faabe6eaadd668 100644 (file)
--- a/src/tree.c
+++ b/src/tree.c
@@ -114,8 +114,15 @@ static bool _is_con_mapped(Con *con) {
  * Returns true if the container was killed or false if just WM_DELETE was sent
  * and the window is expected to kill itself.
  *
+ * The dont_kill_parent flag is specified when the function calls itself
+ * recursively while deleting a containers children.
+ *
+ * The force_set_focus flag is specified in the case of killing a floating
+ * window: tree_close() will be invoked for the CT_FLOATINGCON (the parent
+ * container) and focus should be set there.
+ *
  */
-bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent) {
+bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent, bool force_set_focus) {
     bool was_mapped = con->mapped;
     Con *parent = con->parent;
 
@@ -138,7 +145,7 @@ bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent) {
     for (child = TAILQ_FIRST(&(con->nodes_head)); child; ) {
         nextchild = TAILQ_NEXT(child, nodes);
         DLOG("killing child=%p\n", child);
-        if (!tree_close(child, kill_window, true))
+        if (!tree_close(child, kill_window, true, false))
             abort_kill = true;
         child = nextchild;
     }
@@ -191,7 +198,7 @@ bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent) {
     if (con_is_floating(con)) {
         Con *ws = con_get_workspace(con);
         DLOG("Container was floating, killing floating container\n");
-        tree_close(parent, DONT_KILL_WINDOW, false);
+        tree_close(parent, DONT_KILL_WINDOW, false, (con == focused));
         DLOG("parent container killed\n");
         if (con == focused) {
             DLOG("This is the focused container, i need to find another one to focus. I start looking at ws = %p\n", ws);
@@ -220,12 +227,13 @@ bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent) {
     if (was_mapped || con == focused) {
         if ((kill_window != DONT_KILL_WINDOW) || !dont_kill_parent || con == focused) {
             DLOG("focusing %p / %s\n", next, next->name);
-            /* TODO: check if the container (or one of its children) was focused */
             if (next->type == CT_DOCKAREA) {
                 /* Instead of focusing the dockarea, we need to restore focus to the workspace */
                 con_focus(con_descend_focused(output_get_content(next->parent)));
             } else {
-                con_focus(next);
+                if (!force_set_focus && con != focused)
+                    DLOG("not changing focus, the container was not focused before\n");
+                else con_focus(next);
             }
         }
         else {
@@ -258,7 +266,7 @@ void tree_close_con(kill_window_t kill_window) {
     assert(focused->type != CT_ROOT);
 
     /* Kill con */
-    tree_close(focused, kill_window, false);
+    tree_close(focused, kill_window, false, false);
 }
 
 /*
@@ -393,9 +401,9 @@ static bool _tree_next(Con *con, char way, orientation_t orientation, bool wrap)
         else if (way == 'p' && orientation == HORIZ)
             direction = D_LEFT;
         else if (way == 'n' && orientation == VERT)
-            direction = D_UP;
-        else if (way == 'p' && orientation == VERT)
             direction = D_DOWN;
+        else if (way == 'p' && orientation == VERT)
+            direction = D_UP;
         else
             return false;
 
@@ -405,27 +413,51 @@ static bool _tree_next(Con *con, char way, orientation_t orientation, bool wrap)
         DLOG("Next output is %s\n", next_output->name);
 
         /* Find visible workspace on next output */
-        Con* workspace = NULL;
+        Con *workspace = NULL;
         GREP_FIRST(workspace, output_get_content(next_output->con), workspace_is_visible(child));
 
         /* Show next workspace and focus appropriate container if possible. */
-        if (workspace) {
-            workspace_show(workspace->name);
-            Con* focus = con_descend_direction(workspace, direction);
-            if (focus)
-                con_focus(focus);
-            return true;
-        }
+        if (!workspace)
+            return false;
 
-        return false;
+        workspace_show(workspace);
+        Con *focus = con_descend_direction(workspace, direction);
+        if (focus) {
+            con_focus(focus);
+            x_set_warp_to(&(focus->rect));
+        }
+        return true;
     }
 
+    Con *parent = con->parent;
+
     if (con->type == CT_FLOATING_CON) {
-        /* TODO: implement focus for floating windows */
-        return false;
-    }
+        /* left/right focuses the previous/next floating container */
+        if (orientation == HORIZ) {
+            Con *next;
+            if (way == 'n')
+                next = TAILQ_NEXT(con, floating_windows);
+            else next = TAILQ_PREV(con, floating_head, floating_windows);
+
+            /* If there is no next/previous container, wrap */
+            if (!next) {
+                if (way == 'n')
+                    next = TAILQ_FIRST(&(parent->floating_head));
+                else next = TAILQ_LAST(&(parent->floating_head), floating_head);
+            }
 
-    Con *parent = con->parent;
+            /* Still no next/previous container? bail out */
+            if (!next)
+                return false;
+
+            con_focus(con_descend_focused(next));
+            return true;
+        } else {
+            /* up/down cycles through the Z-index */
+            /* TODO: implement cycling through the z-index */
+            return false;
+        }
+    }
 
     /* If the orientation does not match or there is no other con to focus, we
      * need to go higher in the hierarchy */
@@ -547,7 +579,7 @@ void tree_flatten(Con *con) {
 
     /* 4: close the redundant cons */
     DLOG("closing redundant cons\n");
-    tree_close(con, DONT_KILL_WINDOW, true);
+    tree_close(con, DONT_KILL_WINDOW, true, false);
 
     /* Well, we got to abort the recursion here because we destroyed the
      * container. However, if tree_flatten() is called sufficiently often,