con = focused->parent;
/* If the parent is an output, we are on a workspace. In this case,
* the new container needs to be opened as a leaf of the workspace. */
- if (con->type == CT_OUTPUT)
+ if (con->parent->type == CT_OUTPUT && con->type != CT_DOCKAREA) {
con = focused;
+ }
+
/* If the currently focused container is a floating container, we
* attach the new container to the workspace */
if (con->type == CT_FLOATING_CON)
con = con->parent;
+ DLOG("con = %p\n", con);
}
assert(con != NULL);
- /* 3: re-calculate child->percent for each child */
- con_fix_percent(con, WINDOW_ADD);
-
- /* 4: add a new container leaf to this con */
+ /* 3. create the container and attach it to its parent */
Con *new = con_new(con);
- con_focus(new);
+
+ /* 4: re-calculate child->percent for each child */
+ con_fix_percent(con);
return new;
}
}
/*
- * Closes the given container including all children
+ * Closes the given container including all children.
+ * Returns true if the container was killed or false if just WM_DELETE was sent
+ * and the window is expected to kill itself.
*
*/
-void tree_close(Con *con, bool kill_window, bool dont_kill_parent) {
+bool tree_close(Con *con, kill_window_t kill_window, bool dont_kill_parent) {
bool was_mapped = con->mapped;
Con *parent = con->parent;
DLOG("next = %p, focused = %p\n", next, focused);
DLOG("closing %p, kill_window = %d\n", con, kill_window);
- Con *child;
+ Con *child, *nextchild;
+ bool abort_kill = false;
/* We cannot use TAILQ_FOREACH because the children get deleted
* in their parent’s nodes_head */
- while (!TAILQ_EMPTY(&(con->nodes_head))) {
- child = TAILQ_FIRST(&(con->nodes_head));
+ for (child = TAILQ_FIRST(&(con->nodes_head)); child; ) {
+ nextchild = TAILQ_NEXT(child, nodes);
DLOG("killing child=%p\n", child);
- tree_close(child, kill_window, true);
+ if (!tree_close(child, kill_window, true))
+ abort_kill = true;
+ child = nextchild;
+ }
+
+ if (abort_kill) {
+ DLOG("One of the children could not be killed immediately (WM_DELETE sent), aborting.\n");
+ return false;
}
if (con->window != NULL) {
- if (kill_window)
- x_window_kill(con->window->id);
- else {
+ if (kill_window != DONT_KILL_WINDOW) {
+ x_window_kill(con->window->id, kill_window);
+ return false;
+ } else {
/* un-parent the window */
xcb_reparent_window(conn, con->window->id, root, 0, 0);
- /* TODO: client_unmap to set state to withdrawn */
-
+ /* We are no longer handling this window, thus set WM_STATE to
+ * WM_STATE_WITHDRAWN (see ICCCM 4.1.3.1) */
+ long data[] = { XCB_ICCCM_WM_STATE_WITHDRAWN, XCB_NONE };
+ xcb_change_property(conn, XCB_PROP_MODE_REPLACE, con->window->id,
+ A_WM_STATE, A_WM_STATE, 32, 2, data);
}
FREE(con->window->class_class);
FREE(con->window->class_instance);
if (con->type != CT_FLOATING_CON) {
/* If the container is *not* floating, we might need to re-distribute
* percentage values for the resized containers. */
- con_fix_percent(parent, WINDOW_REMOVE);
+ con_fix_percent(parent);
}
if (con_is_floating(con)) {
Con *ws = con_get_workspace(con);
DLOG("Container was floating, killing floating container\n");
- tree_close(parent, false, false);
+ tree_close(parent, DONT_KILL_WINDOW, false);
DLOG("parent container killed\n");
if (con == focused) {
DLOG("This is the focused container, i need to find another one to focus. I start looking at ws = %p\n", ws);
- next = ws;
- /* now go down the focus stack as far as
- * possible, excluding the current container */
- while (!TAILQ_EMPTY(&(next->focus_head)))
- next = TAILQ_FIRST(&(next->focus_head));
+ /* go down the focus stack as far as possible */
+ next = con_descend_focused(ws);
dont_kill_parent = true;
DLOG("Alright, focusing %p\n", next);
}
free(con->name);
+ FREE(con->deco_render_params);
TAILQ_REMOVE(&all_cons, con, all_cons);
free(con);
* when closing the parent, so we can exit now. */
if (!next) {
DLOG("No next container, i will just exit now\n");
- return;
+ return true;
}
if (was_mapped || con == focused) {
- DLOG("focusing %p / %s\n", next, next->name);
- /* TODO: check if the container (or one of its children) was focused */
- con_focus(next);
+ if ((kill_window != DONT_KILL_WINDOW) || !dont_kill_parent || con == focused) {
+ DLOG("focusing %p / %s\n", next, next->name);
+ /* TODO: check if the container (or one of its children) was focused */
+ if (next->type == CT_DOCKAREA) {
+ /* Instead of focusing the dockarea, we need to restore focus to the workspace */
+ con_focus(con_descend_focused(output_get_content(next->parent)));
+ } else {
+ con_focus(next);
+ }
+ }
+ else {
+ DLOG("not focusing because we're not killing anybody");
+ }
} else {
DLOG("not focusing, was not mapped\n");
}
/* check if the parent container is empty now and close it */
- if (!dont_kill_parent &&
- parent->type != CT_WORKSPACE &&
- TAILQ_EMPTY(&(parent->nodes_head))) {
- DLOG("Closing empty parent container\n");
- /* TODO: check if this container would swallow any other client and
- * don’t close it automatically. */
- tree_close(parent, false, false);
- }
+ if (!dont_kill_parent)
+ CALL(parent, on_remove_child);
+
+ return true;
}
/*
* Closes the current container using tree_close().
*
*/
-void tree_close_con() {
+void tree_close_con(kill_window_t kill_window) {
assert(focused != NULL);
if (focused->type == CT_WORKSPACE) {
LOG("Cannot close workspace\n");
assert(focused->type != CT_ROOT);
/* Kill con */
- tree_close(focused, true, false);
+ tree_close(focused, kill_window, false);
}
/*
*
*/
void level_up() {
+ /* We cannot go up when we are in fullscreen mode at the moment, that would
+ * be totally not intuitive */
+ if (focused->fullscreen_mode != CF_NONE) {
+ LOG("Currently in fullscreen, not going up\n");
+ return;
+ }
/* We can focus up to the workspace, but not any higher in the tree */
- if (focused->parent->type != CT_CON &&
- focused->parent->type != CT_WORKSPACE) {
- printf("cannot go up\n");
+ if ((focused->parent->type != CT_CON &&
+ focused->parent->type != CT_WORKSPACE) ||
+ focused->type == CT_WORKSPACE) {
+ LOG("Cannot go up any further\n");
return;
}
con_focus(focused->parent);
/* 1: get the first parent with the same orientation */
Con *parent = focused->parent;
while (focused->type != CT_WORKSPACE &&
- con_orientation(parent) != orientation) {
+ (con_orientation(parent) != orientation ||
+ con_num_children(parent) == 1)) {
LOG("need to go one level further up\n");
/* if the current parent is an output, we are at a workspace
* and the orientation still does not match */
Con *current = TAILQ_FIRST(&(parent->focus_head));
assert(current != TAILQ_END(&(parent->focus_head)));
+ if (TAILQ_EMPTY(&(parent->nodes_head))) {
+ DLOG("Nothing to focus here, move along...\n");
+ return;
+ }
+
/* 2: chose next (or previous) */
Con *next;
if (way == 'n') {
/* 3: focus choice comes in here. at the moment we will go down
* until we find a window */
/* TODO: check for window, atm we only go down as far as possible */
- while (!TAILQ_EMPTY(&(next->focus_head)))
- next = TAILQ_FIRST(&(next->focus_head));
-
- DLOG("focusing %p\n", next);
- con_focus(next);
-}
-
-/*
- * Moves the current container in the given way (next/previous) and given
- * orientation (horizontal/vertical).
- *
- */
-void tree_move(char way, orientation_t orientation) {
- /* 1: get the first parent with the same orientation */
- Con *parent = focused->parent;
- Con *old_parent = parent;
- if (focused->type == CT_WORKSPACE)
- return;
- bool level_changed = false;
- while (con_orientation(parent) != orientation) {
- DLOG("need to go one level further up\n");
- /* If the current parent is an output, we are at a workspace
- * and the orientation still does not match. In this case, we split the
- * workspace to have the same look & feel as in older i3 releases. */
- if (parent->type == CT_WORKSPACE) {
- DLOG("Arrived at workspace, splitting...\n");
- /* 1: create a new split container */
- Con *new = con_new(NULL);
- new->parent = parent;
-
- /* 2: copy layout and orientation from workspace */
- new->layout = parent->layout;
- new->orientation = parent->orientation;
-
- Con *old_focused = TAILQ_FIRST(&(parent->focus_head));
- if (old_focused == TAILQ_END(&(parent->focus_head)))
- old_focused = NULL;
-
- /* 3: move the existing cons of this workspace below the new con */
- DLOG("Moving cons\n");
- Con *child;
- while (!TAILQ_EMPTY(&(parent->nodes_head))) {
- child = TAILQ_FIRST(&(parent->nodes_head));
- con_detach(child);
- con_attach(child, new, true);
- }
-
- /* 4: switch workspace orientation */
- parent->orientation = orientation;
-
- /* 4: attach the new split container to the workspace */
- DLOG("Attaching new split to ws\n");
- con_attach(new, parent, false);
-
- if (old_focused)
- con_focus(old_focused);
-
- level_changed = true;
-
- break;
- }
- parent = parent->parent;
- level_changed = true;
- }
- Con *current = TAILQ_FIRST(&(parent->focus_head));
- assert(current != TAILQ_END(&(parent->focus_head)));
-
- /* 2: chose next (or previous) */
- Con *next = current;
- if (way == 'n') {
- LOG("i would insert it after %p / %s\n", next, next->name);
-
- /* Have a look at the next container: If there is no next container or
- * if it is a leaf node, we move the focused one left to it. However,
- * for split containers, we descend into it. */
- next = TAILQ_NEXT(next, nodes);
- if (next == TAILQ_END(&(next->parent->nodes_head))) {
- if (focused == current)
- return;
- next = current;
- } else {
- if (level_changed && con_is_leaf(next)) {
- next = current;
- } else {
- /* if this is a split container, we need to go down */
- while (!TAILQ_EMPTY(&(next->focus_head)))
- next = TAILQ_FIRST(&(next->focus_head));
- }
- }
-
- con_detach(focused);
- focused->parent = next->parent;
-
- TAILQ_INSERT_AFTER(&(next->parent->nodes_head), next, focused, nodes);
- TAILQ_INSERT_HEAD(&(next->parent->focus_head), focused, focused);
- /* TODO: don’t influence focus handling? */
- } else {
- LOG("i would insert it before %p / %s\n", current, current->name);
- bool gone_down = false;
- next = TAILQ_PREV(next, nodes_head, nodes);
- if (next == TAILQ_END(&(next->parent->nodes_head))) {
- if (focused == current)
- return;
- next = current;
- } else {
- if (level_changed && con_is_leaf(next)) {
- next = current;
- } else {
- /* if this is a split container, we need to go down */
- while (!TAILQ_EMPTY(&(next->focus_head))) {
- gone_down = true;
- next = TAILQ_FIRST(&(next->focus_head));
- }
- }
- }
-
- con_detach(focused);
- focused->parent = next->parent;
-
- /* After going down in the tree, we insert the container *after*
- * the currently focused one even though the command used "before".
- * This is to keep the user experience clear, since the before/after
- * only signifies the direction of the movement on top-level */
- if (gone_down)
- TAILQ_INSERT_AFTER(&(next->parent->nodes_head), next, focused, nodes);
- else TAILQ_INSERT_BEFORE(next, focused, nodes);
- TAILQ_INSERT_HEAD(&(next->parent->focus_head), focused, focused);
- /* TODO: don’t influence focus handling? */
- }
-
- /* We need to call con_focus() to fix the focus stack "above" the container
- * we just inserted the focused container into (otherwise, the parent
- * container(s) would still point to the old container(s)). */
- con_focus(focused);
-
- if (con_num_children(old_parent) == 0) {
- DLOG("Old container empty after moving. Let's close it\n");
- tree_close(old_parent, false, false);
- }
-
- tree_flatten(croot);
+ con_focus(con_descend_focused(next));
}
/*
/* Ensure it got only one child */
child = TAILQ_FIRST(&(con->nodes_head));
- if (TAILQ_NEXT(child, nodes) != NULL)
+ if (child == NULL || TAILQ_NEXT(child, nodes) != NULL)
goto recurse;
/* The child must have a different orientation than the con but the same as
TAILQ_INSERT_BEFORE(con, current, nodes);
DLOG("attaching to focus list\n");
TAILQ_INSERT_TAIL(&(parent->focus_head), current, focused);
+ current->percent = con->percent;
}
DLOG("re-attached all\n");
/* 4: close the redundant cons */
DLOG("closing redundant cons\n");
- tree_close(con, false, true);
+ tree_close(con, DONT_KILL_WINDOW, true);
/* Well, we got to abort the recursion here because we destroyed the
* container. However, if tree_flatten() is called sufficiently often,
projects / i3 / i3 / blobdiff