X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=bacula%2Fsrc%2Flib%2Faddress_conf.c;h=5932e89bd393611e38c28e23e4d46730697cd513;hb=a84ce1aa4c55f255e02a1c5f76c1e0284459c3b1;hp=1b5fcb4ed911a84ef2f65b8d4096f9c629fc11a9;hpb=bc0378fff3d0d45c71bb72c8f50f1c5a8232d1a9;p=bacula%2Fbacula

diff --git a/bacula/src/lib/address_conf.c b/bacula/src/lib/address_conf.c
index 1b5fcb4ed9..5932e89bd3 100644
--- a/bacula/src/lib/address_conf.c
+++ b/bacula/src/lib/address_conf.c
@@ -1,56 +1,77 @@
 /*
- *   Configuration file parser for IP-Addresse ipv4 and ipv6
- *
- *     Written by Meno Abels, June MMIIII
- *
- *     Version $Id$
- */
-/*
-   Copyright (C) 2004 Kern Sibbald and John Walker
+   Bacula® - The Network Backup Solution
+
+   Copyright (C) 2004-2008 Free Software Foundation Europe e.V.
 
-   This program is free software; you can redistribute it and/or
-   modify it under the terms of the GNU General Public License as
-   published by the Free Software Foundation; either version 2 of
-   the License, or (at your option) any later version.
+   The main author of Bacula is Kern Sibbald, with contributions from
+   many others, a complete list can be found in the file AUTHORS.
+   This program is Free Software; you can redistribute it and/or
+   modify it under the terms of version two of the GNU General Public
+   License as published by the Free Software Foundation and included
+   in the file LICENSE.
 
-   This program is distributed in the hope that it will be useful,
-   but WITHOUT ANY WARRANTY; without even the implied warranty of
+   This program is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
    General Public License for more details.
 
-   You should have received a copy of the GNU General Public
-   License along with this program; if not, write to the Free
-   Software Foundation, Inc., 59 Temple Place - Suite 330, Boston,
-   MA 02111-1307, USA.
+   You should have received a copy of the GNU General Public License
+   along with this program; if not, write to the Free Software
+   Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
+   02110-1301, USA.
 
+   Bacula® is a registered trademark ofJohn Walker.
+   The licensor of Bacula is the Free Software Foundation Europe
+   (FSFE), Fiduciary Program, Sumatrastrasse 25, 8006 Zürich,
+   Switzerland, email:ftf@fsfeurope.org.
+*/
+/*
+ *   Configuration file parser for IP-Addresse ipv4 and ipv6
+ *
+ *     Written by Meno Abels, June MMIV
+ *
+ *     Version $Id$
  */
 
 
 #include "bacula.h"
+#ifdef HAVE_ARPA_NAMESER_H
+#include <arpa/nameser.h>
+#endif
+#ifdef HAVE_RESOLV_H
+#include <resolv.h>
+#endif
 
 static int add_address(dlist **out, IPADDR::i_type type, unsigned short defaultport, int family,
-		const char *hostname_str, const char *port_str, char **errstr);
+                const char *hostname_str, const char *port_str, char *buf, int buflen);
 
 
 IPADDR::IPADDR(const IPADDR &src) : type(src.type)
 {
-  memcpy(&buf, &src.buf, sizeof(buf));
-  saddr  = &buf.dontuse;
-  saddr4 = &buf.dontuse4; 
+  memcpy(&saddrbuf, &src.saddrbuf, sizeof(saddrbuf));
+  saddr  = &saddrbuf.dontuse;
+  saddr4 = &saddrbuf.dontuse4;
 #ifdef HAVE_IPV6
-  saddr6 = &buf.dontuse6;
+  saddr6 = &saddrbuf.dontuse6;
 #endif
 }
 
 IPADDR::IPADDR(int af) : type(R_EMPTY)
 {
-  if (!(af  == AF_INET6 || af  == AF_INET)) {
-     Emsg1(M_ERROR_TERM, 0, _("Only ipv4 and ipv6 are supported(%d)\n"), af);
+#ifdef HAVE_IPV6
+  if (!(af == AF_INET6 || af == AF_INET)) {
+     Emsg1(M_ERROR_TERM, 0, _("Only ipv4 and ipv6 are supported (%d)\n"), af);
+  }
+#else
+  if (af != AF_INET) {
+     Emsg1(M_ERROR_TERM, 0, _("Only ipv4 is supported (%d)\n"), af);
   }
-  saddr  = &buf.dontuse;
-  saddr4 = &buf.dontuse4; 
+#endif
+  memset(&saddrbuf, 0, sizeof(saddrbuf));
+  saddr  = &saddrbuf.dontuse;
+  saddr4 = &saddrbuf.dontuse4;
 #ifdef HAVE_IPV6
-  saddr6 = &buf.dontuse6;
+  saddr6 = &saddrbuf.dontuse6;
 #endif
   saddr->sa_family = af;
   if (af  == AF_INET) {
@@ -68,8 +89,8 @@ IPADDR::IPADDR(int af) : type(R_EMPTY)
   saddr->sa_len = sizeof(sockaddr_in);
 #endif
 #endif
-   set_addr_any(); 
-} 
+   set_addr_any();
+}
 
 void IPADDR::set_type(i_type o)
 {
@@ -110,7 +131,7 @@ void IPADDR::set_port_net(unsigned short port)
 int IPADDR::get_family() const
 {
     return saddr->sa_family;
-}	
+}
 
 struct sockaddr *IPADDR::get_sockaddr()
 {
@@ -135,7 +156,7 @@ void IPADDR::copy_addr(IPADDR *src)
       saddr6->sin6_addr = src->saddr6->sin6_addr;
    }
 #endif
-} 
+}
 
 void IPADDR::set_addr_any()
 {
@@ -150,7 +171,7 @@ void IPADDR::set_addr_any()
 }
 
 void IPADDR::set_addr4(struct in_addr *ip4)
-{ 
+{
    if (saddr->sa_family != AF_INET) {
       Emsg1(M_ERROR_TERM, 0, _("It was tried to assign a ipv6 address to a ipv4(%d)\n"), saddr->sa_family);
    }
@@ -159,7 +180,7 @@ void IPADDR::set_addr4(struct in_addr *ip4)
 
 #ifdef HAVE_IPV6
 void IPADDR::set_addr6(struct in6_addr *ip6)
-{ 
+{
    if (saddr->sa_family != AF_INET6) {
       Emsg1(M_ERROR_TERM, 0, _("It was tried to assign a ipv4 address to a ipv6(%d)\n"), saddr->sa_family);
    }
@@ -170,28 +191,32 @@ void IPADDR::set_addr6(struct in6_addr *ip6)
 const char *IPADDR::get_address(char *outputbuf, int outlen)
 {
    outputbuf[0] = '\0';
-#if defined(HAVE_INET_NTOP) && defined(HAVE_IPV6)
+#ifdef HAVE_INET_NTOP
+# ifdef HAVE_IPV6
    inet_ntop(saddr->sa_family, saddr->sa_family == AF_INET ?
-	      (void*)&(saddr4->sin_addr) : (void*)&(saddr6->sin6_addr),
-	      outputbuf, outlen);
+              (void*)&(saddr4->sin_addr) : (void*)&(saddr6->sin6_addr),
+              outputbuf, outlen);
+# else
+   inet_ntop(saddr->sa_family, (void*)&(saddr4->sin_addr), outputbuf, outlen);
+# endif
 #else
    bstrncpy(outputbuf, inet_ntoa(saddr4->sin_addr), outlen);
 #endif
    return outputbuf;
 }
 
-const char *IPADDR::build_address_str(char *buf, int blen) 
+const char *IPADDR::build_address_str(char *buf, int blen)
 {
    char tmp[1024];
    bsnprintf(buf, blen, "host[%s:%s:%hu] ",
             get_family() == AF_INET ? "ipv4" : "ipv6",
-	    get_address(tmp, sizeof(tmp) - 1), get_port_host_order());
+            get_address(tmp, sizeof(tmp) - 1), get_port_host_order());
    return buf;
 }
 
-const char *build_addresses_str(dlist *addrs, char *buf, int blen) 
+const char *build_addresses_str(dlist *addrs, char *buf, int blen)
 {
-   if (!addrs->size()) {
+   if (!addrs || addrs->size() == 0) {
       bstrncpy(buf, "", blen);
       return buf;
    }
@@ -201,51 +226,47 @@ const char *build_addresses_str(dlist *addrs, char *buf, int blen)
       char tmp[1024];
       int len = bsnprintf(work, blen, "%s", p->build_address_str(tmp, sizeof(tmp)));
       if (len < 0)
-	 break;
+         break;
       work += len;
       blen -= len;
    }
    return buf;
 }
 
-const char *get_first_address(dlist * addrs, char *outputbuf, int outlen)
+const char *get_first_address(dlist *addrs, char *outputbuf, int outlen)
 {
    return ((IPADDR *)(addrs->first()))->get_address(outputbuf, outlen);
 }
 
-int get_first_port_net_order(dlist * addrs)
-{
-   return ((IPADDR *)(addrs->first()))->get_port_net_order();				  
-}
-
-int get_first_port_host_order(dlist * addrs)
+int get_first_port_net_order(dlist *addrs)
 {
-   return ((IPADDR *)(addrs->first()))->get_port_host_order();				  
+   if (!addrs) {
+      return 0;
+   } else {
+      return ((IPADDR *)(addrs->first()))->get_port_net_order();
+   }
 }
 
-static int skip_to_next_not_eol(LEX * lc)
+int get_first_port_host_order(dlist *addrs)
 {
-   int token;
-
-   do {
-      token = lex_get_token(lc, T_ALL);
-   } while (token == T_EOL);
-   return token;
+   if (!addrs) {
+      return 0;
+   } else {
+      return ((IPADDR *)(addrs->first()))->get_port_host_order();
+   }
 }
 
-
 void init_default_addresses(dlist **out, int port)
 {
-   char *errstr;
+   char buf[1024];
    unsigned short sport = port;
-   if (!add_address(out, IPADDR::R_DEFAULT, htons(sport), AF_INET, 0, 0, &errstr)) {
-      Emsg1(M_ERROR_TERM, 0, _("Can't add default address (%s)\n"), errstr);
-      free(errstr);
+   if (!add_address(out, IPADDR::R_DEFAULT, htons(sport), AF_INET, 0, 0, buf, sizeof(buf))) {
+      Emsg1(M_ERROR_TERM, 0, _("Can't add default address (%s)\n"), buf);
    }
 }
 
 static int add_address(dlist **out, IPADDR::i_type type, unsigned short defaultport, int family,
-		const char *hostname_str, const char *port_str, char **errstr)
+                const char *hostname_str, const char *port_str, char *buf, int buflen)
 {
    IPADDR *iaddr;
    IPADDR *jaddr;
@@ -253,6 +274,7 @@ static int add_address(dlist **out, IPADDR::i_type type, unsigned short defaultp
    unsigned short port;
    IPADDR::i_type intype = type;
 
+   buf[0] = 0;
    dlist *addrs = (dlist *)(*(out));
    if (!addrs) {
       IPADDR *tmp = 0;
@@ -260,94 +282,121 @@ static int add_address(dlist **out, IPADDR::i_type type, unsigned short defaultp
    }
 
    type = (type == IPADDR::R_SINGLE_PORT
-	   || type == IPADDR::R_SINGLE_ADDR) ? IPADDR::R_SINGLE : type;
+           || type == IPADDR::R_SINGLE_ADDR) ? IPADDR::R_SINGLE : type;
    if (type != IPADDR::R_DEFAULT) {
       IPADDR *def = 0;
       foreach_dlist(iaddr, addrs) {
-	 if (iaddr->get_type() == IPADDR::R_DEFAULT) {
-	    def = iaddr;
-	 } else if (iaddr->get_type() != type) {
-	    *errstr = (char *)malloc(1024);
-	    bsnprintf(*errstr, 1023,
-                      "the old style addresses could mixed with new style");
-	    return 0;
-	 }
+         if (iaddr->get_type() == IPADDR::R_DEFAULT) {
+            def = iaddr;
+         } else if (iaddr->get_type() != type) {
+            bsnprintf(buf, buflen,
+                      _("the old style addresses cannot be mixed with new style"));
+            return 0;
+         }
       }
       if (def) {
-	 addrs->remove(def);
-	 delete def;
+         addrs->remove(def);
+         delete def;
       }
    }
 
-
    if (!port_str || port_str[0] == '\0') {
       port = defaultport;
    } else {
       int pnum = atol(port_str);
       if (0 < pnum && pnum < 0xffff) {
-	 port = htons(pnum);
+         port = htons(pnum);
       } else {
          struct servent *s = getservbyname(port_str, "tcp");
-	 if (s) {
-	    port = s->s_port;
-	 } else {
-	    *errstr = (char *)malloc(1024);
-            bsnprintf(*errstr, 1023, "can't resolve service(%s)", port_str);
-	    return 0;
-	 }
+         if (s) {
+            port = s->s_port;
+         } else {
+            bsnprintf(buf, buflen, _("can't resolve service(%s)"), port_str);
+            return 0;
+         }
       }
    }
 
    const char *myerrstr;
    hostaddrs = bnet_host2ipaddrs(hostname_str, family, &myerrstr);
    if (!hostaddrs) {
-      *errstr = (char *)malloc(1024);
-      bsnprintf(*errstr, 1023, "can't resolve hostname(%s) %s", hostname_str,
-		myerrstr);
+      bsnprintf(buf, buflen, _("can't resolve hostname(%s) %s"), hostname_str,
+                myerrstr);
       return 0;
    }
 
    if (intype == IPADDR::R_SINGLE_PORT || intype == IPADDR::R_SINGLE_ADDR) {
       IPADDR *addr;
       if (addrs->size()) {
-	 addr = (IPADDR *)addrs->first();
+         addr = (IPADDR *)addrs->first();
       } else {
-	 addr = New(IPADDR(family)); 
-	 addr->set_type(type);
-	 addr->set_port_net(defaultport);
-	 addr->set_addr_any();
-	 addrs->append(addr);
+         addr = New(IPADDR(family));
+         addr->set_type(type);
+         addr->set_port_net(defaultport);
+         addr->set_addr_any();
+         addrs->append(addr);
       }
       if (intype == IPADDR::R_SINGLE_PORT) {
-	 addr->set_port_net(port);
+         addr->set_port_net(port);
       }
       if (intype == IPADDR::R_SINGLE_ADDR) {
-	 addr->copy_addr((IPADDR *) (hostaddrs->first()));
+         addr->copy_addr((IPADDR *)(hostaddrs->first()));
       }
    } else {
       foreach_dlist(iaddr, hostaddrs) {
-	 IPADDR *clone;
-	 /* for duplicates */
-	 foreach_dlist(jaddr, addrs) {
-	    if (iaddr->get_sockaddr_len() == jaddr->get_sockaddr_len() &&
-	    !memcmp(iaddr->get_sockaddr(), jaddr->get_sockaddr(), 
-		    iaddr->get_sockaddr_len()))
-		{
-	       goto skip;	   /* no price */
-	    }
-	 }
-	 clone = New(IPADDR(*iaddr)); 
-	 clone->set_type(type);
-	 clone->set_port_net(port);
-	 addrs->append(clone);
+         IPADDR *clone;
+         /* for duplicates */
+         foreach_dlist(jaddr, addrs) {
+            if (iaddr->get_sockaddr_len() == jaddr->get_sockaddr_len() &&
+            !memcmp(iaddr->get_sockaddr(), jaddr->get_sockaddr(),
+                    iaddr->get_sockaddr_len()))
+                {
+               goto skip;          /* no price */
+            }
+         }
+         clone = New(IPADDR(*iaddr));
+         clone->set_type(type);
+         clone->set_port_net(port);
+         addrs->append(clone);
        skip:
-	 continue;
+         continue;
       }
    }
    free_addresses(hostaddrs);
    return 1;
 }
 
+/*
+ *   my tests
+ *   positiv
+ *   = { ip = { addr = 1.2.3.4; port = 1205; } ipv4 = { addr = 1.2.3.4; port = http; } }
+ *   = { ip = {
+ *         addr = 1.2.3.4; port = 1205; }
+ *     ipv4 = {
+ *         addr = 1.2.3.4; port = http; }
+ *     ipv6 = {
+ *       addr = 1.2.3.4;
+ *       port = 1205;
+ *     }
+ *     ip = {
+ *       addr = 1.2.3.4
+ *       port = 1205
+ *     }
+ *     ip = {
+ *       addr = 1.2.3.4
+ *     }
+ *     ip = {
+ *       addr = 2001:220:222::2
+ *     }
+ *     ip = {
+ *       addr = bluedot.thun.net
+ (     }
+ *   }
+ *   negativ
+ *   = { ip = { } }
+ *   = { ipv4 { addr = doof.nowaytoheavenxyz.uhu; } }
+ *   = { ipv4 { port = 4711 } }
+ */
 void store_addresses(LEX * lc, RES_ITEM * item, int index, int pass)
 {
    int token;
@@ -356,48 +405,15 @@ void store_addresses(LEX * lc, RES_ITEM * item, int index, int pass)
    char hostname_str[1024];
    char port_str[128];
    int family = 0;
+   char errmsg[1024];
 
-    
-
-   /*
-    *   =  { [[ip|ipv4|ipv6] = { [[addr|port] = [^ ]+[\n;]+] }]+ }
-    *	or my tests
-    *	positiv
-    *	= { ip = { addr = 1.2.3.4; port = 1205; } ipv4 = { addr = 1.2.3.4; port = http; } }
-    *	= { ip = { 
-    *	      addr = 1.2.3.4; port = 1205; } 
-    *	  ipv4 = { 
-    *	      addr = 1.2.3.4; port = http; } 
-    *	  ipv6 = { 
-    *	    addr = 1.2.3.4; 
-    *	    port = 1205;
-    *	  } 
-    *	  ip = {
-    *	    addr = 1.2.3.4
-    *	    port = 1205
-    *	  } 
-    *	  ip = {
-    *	    addr = 1.2.3.4
-    *	  } 
-    *	  ip = {
-    *	    addr = 2001:220:222::2
-    *	  } 
-    *	  ip = {
-    *	    addr = bluedot.thun.net
-    (	  } 
-    *	}
-    *	negativ
-    *	= { ip = { } }
-    *	= { ipv4 { addr = doof.nowaytoheavenxyz.uhu; } }
-    *	= { ipv4 { port = 4711 } }
-    */
-
-   token = skip_to_next_not_eol(lc);
+
+   token = lex_get_token(lc, T_SKIP_EOL);
    if (token != T_BOB) {
       scan_err1(lc, _("Expected a block begin { , got: %s"), lc->str);
    }
 
-   token = skip_to_next_not_eol(lc);
+   token = lex_get_token(lc, T_SKIP_EOL);
    if (token == T_EOB) {
       scan_err0(lc, _("Empty addr block is not allowed"));
    }
@@ -405,86 +421,88 @@ void store_addresses(LEX * lc, RES_ITEM * item, int index, int pass)
       if (!(token == T_UNQUOTED_STRING || token == T_IDENTIFIER)) {
          scan_err1(lc, _("Expected a string, got: %s"), lc->str);
       }
-      if (!strcmp("ip", lc->str) || !strcmp("ipv4", lc->str)) {
-	 family = AF_INET;
+      if (strcasecmp("ip", lc->str) == 0 || strcasecmp("ipv4", lc->str) == 0) {
+         family = AF_INET;
       }
 #ifdef HAVE_IPV6
-      else if (!strcmp("ipv6", lc->str)) {
-	 family = AF_INET6;
+      else if (strcasecmp("ipv6", lc->str) == 0) {
+         family = AF_INET6;
+      } else {
+         scan_err1(lc, _("Expected a string [ip|ipv4|ipv6], got: %s"), lc->str);
       }
-#endif
+#else
       else {
-         scan_err1(lc, _("Expected a string [ip|ipv4|ipv6], got: %s"), lc->str);
+         scan_err1(lc, _("Expected a string [ip|ipv4], got: %s"), lc->str);
       }
-      token = skip_to_next_not_eol(lc);
+#endif
+      token = lex_get_token(lc, T_SKIP_EOL);
       if (token != T_EQUALS) {
          scan_err1(lc, _("Expected a equal =, got: %s"), lc->str);
       }
-      token = skip_to_next_not_eol(lc);
+      token = lex_get_token(lc, T_SKIP_EOL);
       if (token != T_BOB) {
-         scan_err1(lc, _("Expected a block beginn { , got: %s"), lc->str);
+         scan_err1(lc, _("Expected a block begin { , got: %s"), lc->str);
       }
-      token = skip_to_next_not_eol(lc);
+      token = lex_get_token(lc, T_SKIP_EOL);
       exist = EMPTYLINE;
       port_str[0] = hostname_str[0] = '\0';
       do {
-	 if (token != T_IDENTIFIER) {
+         if (token != T_IDENTIFIER) {
             scan_err1(lc, _("Expected a identifier [addr|port], got: %s"), lc->str);
-	 }
-         if (!strcmp("port", lc->str)) {
-	    next_line = PORTLINE;
-	    if (exist & PORTLINE) {
+         }
+         if (strcasecmp("port", lc->str) == 0) {
+            next_line = PORTLINE;
+            if (exist & PORTLINE) {
                scan_err0(lc, _("Only one port per address block"));
-	    }
-	    exist |= PORTLINE;
-         } else if (!strcmp("addr", lc->str)) {
-	    next_line = ADDRLINE;
-	    if (exist & ADDRLINE) {
+            }
+            exist |= PORTLINE;
+         } else if (strcasecmp("addr", lc->str) == 0) {
+            next_line = ADDRLINE;
+            if (exist & ADDRLINE) {
                scan_err0(lc, _("Only one addr per address block"));
-	    }
-	    exist |= ADDRLINE;
-	 } else {
+            }
+            exist |= ADDRLINE;
+         } else {
             scan_err1(lc, _("Expected a identifier [addr|port], got: %s"), lc->str);
-	 }
-	 token = lex_get_token(lc, T_ALL);
-	 if (token != T_EQUALS) {
+         }
+         token = lex_get_token(lc, T_SKIP_EOL);
+         if (token != T_EQUALS) {
             scan_err1(lc, _("Expected a equal =, got: %s"), lc->str);
-	 }
-	 token = lex_get_token(lc, T_ALL);
-	 switch (next_line) {
-	 case PORTLINE:
-	    if (!
-		(token == T_UNQUOTED_STRING || token == T_NUMBER
-		 || token == T_IDENTIFIER)) {
+         }
+         token = lex_get_token(lc, T_SKIP_EOL);
+         switch (next_line) {
+         case PORTLINE:
+            if (!
+                (token == T_UNQUOTED_STRING || token == T_NUMBER
+                 || token == T_IDENTIFIER)) {
                scan_err1(lc, _("Expected a number or a string, got: %s"), lc->str);
-	    }
-	    bstrncpy(port_str, lc->str, sizeof(port_str));
-	    break;
-	 case ADDRLINE:
-	    if (!(token == T_UNQUOTED_STRING || token == T_IDENTIFIER)) {
-               scan_err1(lc, _("Expected a ipnumber or a hostname, got: %s"),
-			 lc->str);
-	    }
-	    bstrncpy(hostname_str, lc->str, sizeof(hostname_str));
-	    break;
-	 case EMPTYLINE:
-            scan_err0(lc, _("Statemachine missmatch"));
-	    break;
-	 }
-	 token = skip_to_next_not_eol(lc);
+            }
+            bstrncpy(port_str, lc->str, sizeof(port_str));
+            break;
+         case ADDRLINE:
+            if (!(token == T_UNQUOTED_STRING || token == T_IDENTIFIER)) {
+               scan_err1(lc, _("Expected an IP number or a hostname, got: %s"),
+                         lc->str);
+            }
+            bstrncpy(hostname_str, lc->str, sizeof(hostname_str));
+            break;
+         case EMPTYLINE:
+            scan_err0(lc, _("State machine missmatch"));
+            break;
+         }
+         token = lex_get_token(lc, T_SKIP_EOL);
       } while (token == T_IDENTIFIER);
       if (token != T_EOB) {
          scan_err1(lc, _("Expected a end of block }, got: %s"), lc->str);
       }
 
-      char *errstr;
-      if (pass == 1 && !add_address((dlist **)(item->value), IPADDR::R_MULTIPLE, 
-	       htons(item->default_value), family, hostname_str, port_str, &errstr)) {
+      if (pass == 1 && !add_address((dlist **)(item->value), IPADDR::R_MULTIPLE,
+               htons(item->default_value), family, hostname_str, port_str, 
+               errmsg, sizeof(errmsg))) {
            scan_err3(lc, _("Can't add hostname(%s) and port(%s) to addrlist (%s)"),
-		   hostname_str, port_str, errstr);
-	   free(errstr);
-	}
-      token = skip_to_next_not_eol(lc);
+                   hostname_str, port_str, errmsg);
+        }
+      token = scan_to_next_not_eol(lc);
    } while ((token == T_IDENTIFIER || token == T_UNQUOTED_STRING));
    if (token != T_EOB) {
       scan_err1(lc, _("Expected a end of block }, got: %s"), lc->str);
@@ -493,30 +511,29 @@ void store_addresses(LEX * lc, RES_ITEM * item, int index, int pass)
 
 void store_addresses_address(LEX * lc, RES_ITEM * item, int index, int pass)
 {
-
-   int token = lex_get_token(lc, T_ALL);
+   char errmsg[1024];
+   int token = lex_get_token(lc, T_SKIP_EOL);
    if (!(token == T_UNQUOTED_STRING || token == T_NUMBER || token == T_IDENTIFIER)) {
-      scan_err1(lc, _("Expected a hostname or ipnummer, got: %s"), lc->str);
+      scan_err1(lc, _("Expected an IP number or a hostname, got: %s"), lc->str);
    }
-   char *errstr;
-   if (pass == 1 && !add_address((dlist **) (item->value), IPADDR::R_SINGLE_ADDR,
-		    htons(item->default_value), AF_INET, lc->str, 0, &errstr)) {
-      scan_err2(lc, _("can't add port (%s) to (%s)"), lc->str, errstr);
-      free(errstr);
+   if (pass == 1 && !add_address((dlist **)(item->value), IPADDR::R_SINGLE_ADDR,
+                    htons(item->default_value), AF_INET, lc->str, 0, 
+                    errmsg, sizeof(errmsg))) {
+      scan_err2(lc, _("can't add port (%s) to (%s)"), lc->str, errmsg);
    }
 }
 
 void store_addresses_port(LEX * lc, RES_ITEM * item, int index, int pass)
 {
-   int token = lex_get_token(lc, T_ALL);
+   char errmsg[1024];
+   int token = lex_get_token(lc, T_SKIP_EOL);
    if (!(token == T_UNQUOTED_STRING || token == T_NUMBER || token == T_IDENTIFIER)) {
-      scan_err1(lc, _("Expected a port nummer or string, got: %s"), lc->str);
+      scan_err1(lc, _("Expected a port number or string, got: %s"), lc->str);
    }
-   char *errstr;
    if (pass == 1 && !add_address((dlist **)(item->value), IPADDR::R_SINGLE_PORT,
-		    htons(item->default_value), AF_INET, 0, lc->str, &errstr)) {
-      scan_err2(lc, _("can't add port (%s) to (%s)"), lc->str, errstr);
-      free(errstr);
+                    htons(item->default_value), AF_INET, 0, lc->str, 
+                    errmsg, sizeof(errmsg))) {
+      scan_err2(lc, _("can't add port (%s) to (%s)"), lc->str, errmsg);
    }
 }
 
@@ -543,18 +560,48 @@ int sockaddr_get_port_net_order(const struct sockaddr *client_addr)
    return -1;
 }
 
-int  sockaddr_to_ascii(const struct sockaddr *sa, char *buf, int len)
+int sockaddr_get_port(const struct sockaddr *client_addr)
+{
+   if (client_addr->sa_family == AF_INET) {
+      return ntohs(((struct sockaddr_in *)client_addr)->sin_port);
+   }
+#ifdef HAVE_IPV6
+   else {
+      return ntohs(((struct sockaddr_in6 *)client_addr)->sin6_port);
+   }
+#endif
+   return -1;
+}
+
+
+char *sockaddr_to_ascii(const struct sockaddr *sa, char *buf, int len)
 {
 #ifdef HAVE_INET_NTOP
    /* MA Bug 5 the problem was that i mixed up sockaddr and in_addr */
    inet_ntop(sa->sa_family,
-	     sa->sa_family == AF_INET ? 
-		 (void*)&(((struct sockaddr_in*)sa)->sin_addr) :
-		 (void*)&(((struct sockaddr_in6*)sa)->sin6_addr),
-	     buf,
-	     sizeof(buf));
+# ifdef HAVE_IPV6
+             sa->sa_family == AF_INET ? 
+                 (void*)&(((struct sockaddr_in*)sa)->sin_addr) :
+                 (void*)&(((struct sockaddr_in6*)sa)->sin6_addr),
+# else
+                 (void*)&(((struct sockaddr_in*)sa)->sin_addr),
+# endif /* HAVE_IPV6 */
+             buf, len);
 #else
    bstrncpy(buf, inet_ntoa(((struct sockaddr_in *)sa)->sin_addr), len);
 #endif
-   return 1;
+   return buf;
+}
+
+#ifdef HAVE_OLD_SOCKOPT
+int inet_aton(const char *cp, struct in_addr *inp)
+{
+   struct in_addr inaddr;
+
+   if((inaddr.s_addr = inet_addr(cp)) != INADDR_NONE) {
+      inp->s_addr = inaddr.s_addr;
+      return 1;
+   }
+   return 0;
 }
+#endif