X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=bacula%2Fsrc%2Fstored%2Facquire.c;h=8595dd5d4261aacba5dc9ca7c77e78bfb9db6d70;hb=6ad0c1d5ca58b2b02d86eb879aa70940d945126c;hp=42ae4747ea5c2547fbad32b6f88fcf6d0364c180;hpb=71025c877b28da7326d650dd3598b9bd64d00e23;p=bacula%2Fbacula diff --git a/bacula/src/stored/acquire.c b/bacula/src/stored/acquire.c index 42ae4747ea..8595dd5d42 100644 --- a/bacula/src/stored/acquire.c +++ b/bacula/src/stored/acquire.c @@ -2,11 +2,11 @@ * Routines to acquire and release a device for read/write * * Kern Sibbald, August MMII - * + * * Version $Id$ */ /* - Copyright (C) 2002-2003 Kern Sibbald and John Walker + Copyright (C) 2002-2005 Kern Sibbald This program is free software; you can redistribute it and/or modify it under the terms of the GNU General Public License as @@ -28,70 +28,247 @@ #include "bacula.h" /* pull in global headers */ #include "stored.h" /* pull in Storage Deamon headers */ -static pthread_mutex_t mutex = PTHREAD_MUTEX_INITIALIZER; +/* + * Create a new Device Control Record and attach + * it to the device (if this is a real job). + */ +DCR *new_dcr(JCR *jcr, DEVICE *dev) +{ + if (jcr && jcr->dcr) { + return jcr->dcr; + } + DCR *dcr = (DCR *)malloc(sizeof(DCR)); + memset(dcr, 0, sizeof(DCR)); + if (jcr) { + jcr->dcr = dcr; + } + dcr->jcr = jcr; + dcr->dev = dev; + if (dev) { + dcr->device = dev->device; + } + dcr->block = new_block(dev); + dcr->rec = new_record(); + dcr->spool_fd = -1; + dcr->max_spool_size = dev->device->max_spool_size; + /* Attach this dcr only if dev is initialized */ + if (dev->fd != 0 && jcr && jcr->JobType != JT_SYSTEM) { + dev->attached_dcrs->append(dcr); +// jcr->dcrs->append(dcr); + } + return dcr; +} + +/* + * Search the dcrs list for the given dcr. If it is found, + * as it should be, then remove it. Also zap the jcr pointer + * to the dcr if it is the same one. + */ +#ifdef needed +static void remove_dcr_from_dcrs(DCR *dcr) +{ + JCR *jcr = dcr->jcr; + if (jcr->dcrs) { + int i = 0; + DCR *ldcr; + int num = jcr->dcrs->size(); + for (i=0; i < num; i++) { + ldcr = (DCR *)jcr->dcrs->get(i); + if (ldcr == dcr) { + jcr->dcrs->remove(i); + if (jcr->dcr == dcr) { + jcr->dcr = NULL; + } + } + } + } +} +#endif + +/* + * Free up all aspects of the given dcr -- i.e. dechain it, + * release allocated memory, zap pointers, ... + */ +void free_dcr(DCR *dcr) +{ + JCR *jcr = dcr->jcr; + DEVICE *dev = dcr->dev; + + /* + * If we reserved the device, we must decrement the + * number of writers. + */ + if (dcr->reserved_device) { + lock_device(dev); + dev->num_writers--; + if (dev->num_writers < 0) { + Jmsg1(dcr->jcr, M_ERROR, 0, _("Hey! num_writers=%d!!!!\n"), dev->num_writers); + dev->num_writers = 0; + dcr->reserved_device = false; + } + unlock_device(dev); + } + + /* Detach this dcr only if the dev is initialized */ + if (dev->fd != 0 && jcr && jcr->JobType != JT_SYSTEM) { + dev->attached_dcrs->remove(dcr); +// remove_dcr_from_dcrs(dcr); + } + if (dcr->block) { + free_block(dcr->block); + } + if (dcr->rec) { + free_record(dcr->rec); + } + if (dcr->jcr) { + dcr->jcr->dcr = NULL; + } + free(dcr); +} + -/********************************************************************* - * Acquire device for reading. We permit (for the moment) - * only one reader. We read the Volume label from the block and +/* + * We "reserve" the drive by setting the ST_READ bit. No one else + * should touch the drive until that is cleared. + * This allows the DIR to "reserve" the device before actually + * starting the job. If the device is not available, the DIR + * can wait (to be implemented 1/05). + */ +bool reserve_device_for_read(JCR *jcr, DEVICE *dev) +{ + DCR *dcr = jcr->dcr; + bool ok = false; + + ASSERT(dcr); + if (device_is_unmounted(dev)) { + Jmsg(jcr, M_WARNING, 0, _("device %s is BLOCKED due to user unmount.\n"), + dev->print_name()); + return false; + } + lock_device(dev); + block_device(dev, BST_DOING_ACQUIRE); + unlock_device(dev); + + if (dev->is_busy()) { + Jmsg2(jcr, M_FATAL, 0, _("Device %s is busy. Job %d canceled.\n"), + dev->print_name(), jcr->JobId); + goto get_out; + } + if (!dcr) { + dcr = new_dcr(jcr, dev); + } + dev->clear_append(); + dev->set_read(); + ok = true; + +get_out: + P(dev->mutex); + unblock_device(dev); + V(dev->mutex); + return ok; +} + + +/********************************************************************* + * Acquire device for reading. + * The drive should have previously been reserved by calling + * reserve_device_for_read(). We read the Volume label from the block and * leave the block pointers just after the label. * - * Returns: 0 if failed for any reason - * 1 if successful + * Returns: NULL if failed for any reason + * dcr if successful */ -int acquire_device_for_read(JCR *jcr, DEVICE *dev, DEV_BLOCK *block) +DCR *acquire_device_for_read(JCR *jcr, DEVICE *dev) { - int stat = 0; - int tape_previously_mounted; + bool vol_ok = false; + bool tape_previously_mounted; + bool tape_initially_mounted; VOL_LIST *vol; - int autochanger = 0; - + bool try_autochanger = true; + int i; + DCR *dcr = jcr->dcr; + int vol_label_status; + lock_device(dev); block_device(dev, BST_DOING_ACQUIRE); unlock_device(dev); - tape_previously_mounted = (dev->state & ST_READ) || (dev->state & ST_APPEND); + init_dev_wait_timers(dev); + + tape_previously_mounted = dev->can_read() || + dev->can_append() || + dev->is_labeled(); + tape_initially_mounted = tape_previously_mounted; - if (dev->state & ST_READ || dev->num_writers > 0) { - Jmsg1(jcr, M_FATAL, 0, _("Device %s is busy. Job canceled.\n"), dev_name(dev)); + if (dev->num_writers > 0) { + Jmsg2(jcr, M_FATAL, 0, _("Num_writers=%d not zero. Job %d canceled.\n"), + dev->num_writers, jcr->JobId); goto get_out; } /* Find next Volume, if any */ vol = jcr->VolList; if (!vol) { - Jmsg(jcr, M_FATAL, 0, _("No volumes specified. Job canceled.\n")); + Jmsg(jcr, M_FATAL, 0, _("No volumes specified. Job %d canceled.\n"), jcr->JobId); goto get_out; } jcr->CurVolume++; - for (int i=1; iCurVolume; i++) { + for (i=1; iCurVolume; i++) { vol = vol->next; } - pm_strcpy(&jcr->VolumeName, vol->VolumeName); + bstrncpy(dcr->VolumeName, vol->VolumeName, sizeof(dcr->VolumeName)); - for (int i=0; i<5; i++) { + /* Volume info is always needed because of VolParts */ + Dmsg0(200, "dir_get_volume_info\n"); + if (!dir_get_volume_info(dcr, GET_VOL_INFO_FOR_READ)) { + Jmsg1(jcr, M_WARNING, 0, "%s", jcr->errmsg); + } + + dev->num_parts = dcr->VolCatInfo.VolCatParts; + + for (i=0; i<5; i++) { + dev->clear_labeled(); /* force reread of label */ if (job_canceled(jcr)) { - Mmsg0(&dev->errmsg, _("Job canceled.\n")); + Mmsg1(dev->errmsg, _("Job %d canceled.\n"), jcr->JobId); goto get_out; /* error return */ } /* * This code ensures that the device is ready for * reading. If it is a file, it opens it. - * If it is a tape, it checks the volume name + * If it is a tape, it checks the volume name */ - for ( ; !(dev->state & ST_OPENED); ) { - Dmsg1(120, "bstored: open vol=%s\n", jcr->VolumeName); - if (open_dev(dev, jcr->VolumeName, READ_ONLY) < 0) { - Jmsg(jcr, M_FATAL, 0, _("Open device %s volume %s failed, ERR=%s\n"), - dev_name(dev), jcr->VolumeName, strerror_dev(dev)); - goto get_out; - } - Dmsg1(129, "open_dev %s OK\n", dev_name(dev)); + for ( ; !dev->is_open(); ) { + Dmsg1(120, "bstored: open vol=%s\n", dcr->VolumeName); + if (open_dev(dev, dcr->VolumeName, OPEN_READ_ONLY) < 0) { + if (dev->dev_errno == EIO) { /* no tape loaded */ + goto default_path; + } + + /* If we have a dvd that requires mount, + * we need to try to open the label, so the info can be reported + * if a wrong volume has been mounted. */ + if (dev->is_dvd() && (dcr->VolCatInfo.VolCatParts > 0)) { + break; + } + + Jmsg(jcr, M_FATAL, 0, _("Open device %s Volume \"%s\" failed: ERR=%s\n"), + dev->print_name(), dcr->VolumeName, strerror_dev(dev)); + goto get_out; + } + Dmsg1(129, "open_dev %s OK\n", dev->print_name()); } - dev->state &= ~ST_LABEL; /* force reread of label */ + + if (dev->is_dvd()) { + vol_label_status = read_dev_volume_label_guess(dcr, 0); + } else { + vol_label_status = read_dev_volume_label(dcr); + } + Dmsg0(200, "calling read-vol-label\n"); - switch (read_dev_volume_label(jcr, dev, block)) { + switch (vol_label_status) { case VOL_OK: - stat = 1; + vol_ok = true; + memcpy(&dev->VolCatInfo, &dcr->VolCatInfo, sizeof(dev->VolCatInfo)); break; /* got it */ case VOL_IO_ERROR: /* @@ -100,54 +277,160 @@ int acquire_device_for_read(JCR *jcr, DEVICE *dev, DEV_BLOCK *block) * error messages when nothing is mounted. */ if (tape_previously_mounted) { - Jmsg(jcr, M_WARNING, 0, "%s", jcr->errmsg); + Jmsg(jcr, M_WARNING, 0, "%s", jcr->errmsg); } goto default_path; + case VOL_NAME_ERROR: + if (tape_initially_mounted) { + tape_initially_mounted = false; + goto default_path; + } + /* Fall through */ default: Jmsg(jcr, M_WARNING, 0, "%s", jcr->errmsg); default_path: - tape_previously_mounted = 1; - Dmsg0(200, "dir_get_volume_info\n"); - if (!dir_get_volume_info(jcr, 0)) { - Jmsg1(jcr, M_WARNING, 0, "%s", jcr->errmsg); + tape_previously_mounted = true; + + /* If the device requires mount, close it, so the device can be ejected. + * FIXME: This should perhaps be done for all devices. */ + if (dev_cap(dev, CAP_REQMOUNT)) { + force_close_dev(dev); } + /* Call autochanger only once unless ask_sysop called */ - if (!autochanger) { + if (try_autochanger) { + int stat; Dmsg2(200, "calling autoload Vol=%s Slot=%d\n", - jcr->VolumeName, jcr->VolCatInfo.Slot); - if ((autochanger=autoload_device(jcr, dev, 0, NULL))) { - continue; + dcr->VolumeName, dcr->VolCatInfo.Slot); + stat = autoload_device(dcr, 0, NULL); + if (stat > 0) { + try_autochanger = false; + continue; /* try reading volume mounted */ } } + /* Mount a specific volume and no other */ Dmsg0(200, "calling dir_ask_sysop\n"); - if (!dir_ask_sysop_to_mount_volume(jcr, dev)) { + if (!dir_ask_sysop_to_mount_volume(dcr)) { goto get_out; /* error return */ } - autochanger = 0; /* permit using autochanger again */ + try_autochanger = true; /* permit using autochanger again */ continue; /* try reading again */ } /* end switch */ break; } /* end for loop */ - if (stat == 0) { - Jmsg1(jcr, M_FATAL, 0, _("Too many errors trying to mount device \"%s\".\n"), - dev_name(dev)); + if (!vol_ok) { + Jmsg1(jcr, M_FATAL, 0, _("Too many errors trying to mount device %s.\n"), + dev->print_name()); goto get_out; } - dev->state |= ST_READ; - attach_jcr_to_device(dev, jcr); /* attach jcr to device */ - if ((dev->state & ST_TAPE) && vol->start_file > 0) { - Dmsg1(200, "====== Got start_file = %d\n", vol->start_file); - Jmsg(jcr, M_INFO, 0, _("Forward spacing to file %d.\n"), vol->start_file); - fsf_dev(dev, vol->start_file); - } + dev->clear_append(); + dev->set_read(); + set_jcr_job_status(jcr, JS_Running); + dir_send_job_status(jcr); + Jmsg(jcr, M_INFO, 0, _("Ready to read from volume \"%s\" on device %s.\n"), + dcr->VolumeName, dev->print_name()); get_out: - P(dev->mutex); + P(dev->mutex); unblock_device(dev); V(dev->mutex); - return stat; + if (!vol_ok) { + free_dcr(dcr); + dcr = NULL; + } + return dcr; +} + +/* + * We reserve the device for appending by incrementing the + * reserved_device. We do virtually all the same work that + * is done in acquire_device_for_append(), but we do + * not attempt to mount the device. This routine allows + * the DIR to reserve multiple devices before *really* + * starting the job. It also permits the SD to refuse + * certain devices (not up, ...). + * + * Note, in reserving a device, if the device is for the + * same pool and the same pool type, then it is acceptable. + * The Media Type has already been checked. If we are + * the first tor reserve the device, we put the pool + * name and pool type in the device record. + */ +bool reserve_device_for_append(JCR *jcr, DEVICE *dev) +{ + DCR *dcr = jcr->dcr; + bool ok = false; + + ASSERT(dcr); + + lock_device(dev); + block_device(dev, BST_DOING_ACQUIRE); + unlock_device(dev); + if (dev->can_read()) { + Jmsg(jcr, M_WARNING, 0, _("Device %s is busy reading.\n"), dev->print_name()); + goto bail_out; + } + if (device_is_unmounted(dev)) { + Jmsg(jcr, M_WARNING, 0, _("device %s is BLOCKED due to user unmount.\n"), + dev->print_name()); + goto bail_out; + } + Dmsg1(190, "reserve_append device is %s\n", dev_is_tape(dev)?"tape":"disk"); + /* + * First handle the case that the drive is not yet in append mode + */ + if (!dev->can_append() && dev->num_writers == 0) { + /* Now check if there are any reservations on the drive */ + if (dev->reserved_device) { + /* Yes, now check if we want the same Pool and pool type */ + if (strcmp(dev->pool_name, dcr->pool_name) == 0 && + strcmp(dev->pool_type, dcr->pool_type) == 0) { + /* OK, compatible device */ + } else { + /* Drive not suitable for us */ + Jmsg(jcr, M_WARNING, 0, _("Device %s is busy writing on another Volume.\n"), dev->print_name()); + goto bail_out; + } + } else { + /* Device is available but not yet reserved, reserve it for us */ + bstrncpy(dev->pool_name, dcr->pool_name, sizeof(dev->pool_name)); + bstrncpy(dev->pool_type, dcr->pool_type, sizeof(dev->pool_type)); + dev->PoolId = dcr->PoolId; + } + goto do_reserve; + } + + /* + * Now check if the device is in append mode + */ + if (dev->can_append() || dev->num_writers > 0) { + Dmsg0(190, "device already in append.\n"); + /* Yes, now check if we want the same Pool and pool type */ + if (strcmp(dev->pool_name, dcr->pool_name) == 0 && + strcmp(dev->pool_type, dcr->pool_type) == 0) { + /* OK, compatible device */ + } else { + /* Drive not suitable for us */ + Jmsg(jcr, M_WARNING, 0, _("Device %s is busy writing on another Volume.\n"), dev->print_name()); + goto bail_out; + } + } else { + Pmsg0(000, "Logic error!!!! Should not get here.\n"); + goto bail_out; /* should not get here */ + } + +do_reserve: + dev->reserved_device++; + dcr->reserved_device = true; + ok = true; + +bail_out: + P(dev->mutex); + unblock_device(dev); + V(dev->mutex); + return ok; } /* @@ -155,102 +438,117 @@ get_out: * If this is the first one, we read the label. * * Returns: NULL if failed for any reason - * dev if successful (may change if new dev opened) - * This routine must be single threaded because we may create - * multiple devices (for files), thus we have our own mutex - * on top of the device mutex. + * dcr if successful. + * Note, normally reserve_device_for_append() is called + * before this routine. */ -DEVICE * acquire_device_for_append(JCR *jcr, DEVICE *dev, DEV_BLOCK *block) +DCR *acquire_device_for_append(JCR *jcr, DEVICE *dev) { - int release = 0; - int do_mount = 0; - DEVICE *rtn_dev = NULL; + bool release = false; + bool recycle = false; + bool do_mount = false; + DCR *dcr = jcr->dcr; + if (!dcr) { + dcr = new_dcr(jcr, dev); + } lock_device(dev); block_device(dev, BST_DOING_ACQUIRE); unlock_device(dev); - P(mutex); /* lock all devices */ Dmsg1(190, "acquire_append device is %s\n", dev_is_tape(dev)?"tape":"disk"); - - if (dev->state & ST_APPEND) { - /* - * Device already in append mode + if (dcr->reserved_device) { + dev->reserved_device--; + dcr->reserved_device = false; + } + + /* + * With the reservation system, this should not happen + */ + if (dev->can_read()) { + Jmsg(jcr, M_FATAL, 0, _("Device %s is busy reading.\n"), dev->print_name()); + goto get_out; + } + + if (dev->can_append()) { + Dmsg0(190, "device already in append.\n"); + /* + * Device already in append mode * - * Check if we have the right Volume mounted + * Check if we have the right Volume mounted * OK if current volume info OK * OK if next volume matches current volume * otherwise mount desired volume obtained from * dir_find_next_appendable_volume */ - pm_strcpy(&jcr->VolumeName, dev->VolHdr.VolName); - if (!dir_get_volume_info(jcr, 1) && - !(dir_find_next_appendable_volume(jcr) && - strcmp(dev->VolHdr.VolName, jcr->VolumeName) == 0)) { /* wrong tape mounted */ - if (dev->num_writers != 0) { - DEVICE *d = ((DEVRES *)dev->device)->dev; - uint32_t open_vols = 0; - for ( ; d; d=d->next) { - open_vols++; - } - if (dev->state & ST_FILE && dev->max_open_vols > open_vols) { - d = init_dev(NULL, (DEVRES *)dev->device); /* init new device */ - d->prev = dev; /* chain in new device */ - d->next = dev->next; - dev->next = d; - /* Release old device */ - P(dev->mutex); - unblock_device(dev); - V(dev->mutex); - /* Make new device current device and lock it */ - dev = d; - lock_device(dev); - block_device(dev, BST_DOING_ACQUIRE); - unlock_device(dev); - } else { - Jmsg(jcr, M_FATAL, 0, _("Device %s is busy writing on another Volume.\n"), dev_name(dev)); - goto get_out; - } + bstrncpy(dcr->VolumeName, dev->VolHdr.VolName, sizeof(dcr->VolumeName)); + if (!dir_get_volume_info(dcr, GET_VOL_INFO_FOR_WRITE) && + !(dir_find_next_appendable_volume(dcr) && + strcmp(dev->VolHdr.VolName, dcr->VolumeName) == 0)) { /* wrong tape mounted */ + Dmsg0(190, "Wrong tape mounted.\n"); + if (dev->num_writers != 0 || dev->reserved_device) { + Jmsg(jcr, M_FATAL, 0, _("Device %s is busy writing on another Volume.\n"), dev->print_name()); + goto get_out; } /* Wrong tape mounted, release it, then fall through to get correct one */ - release = 1; - do_mount = 1; - } - } else { + Dmsg0(190, "Wrong tape mounted, release and try mount.\n"); + release = true; + do_mount = true; + } else { + /* + * At this point, the correct tape is already mounted, so + * we do not need to do mount_next_write_volume(), unless + * we need to recycle the tape. + */ + recycle = strcmp(dcr->VolCatInfo.VolCatStatus, "Recycle") == 0; + Dmsg1(190, "Correct tape mounted. recycle=%d\n", recycle); + if (recycle && dev->num_writers != 0) { + Jmsg(jcr, M_FATAL, 0, _("Cannot recycle volume \"%s\"" + " because it is in use by another job.\n")); + goto get_out; + } + if (dev->num_writers == 0) { + memcpy(&dev->VolCatInfo, &dcr->VolCatInfo, sizeof(dev->VolCatInfo)); + } + } + } else { /* Not already in append mode, so mount the device */ - if (dev->state & ST_READ) { - Jmsg(jcr, M_FATAL, 0, _("Device %s is busy reading.\n"), dev_name(dev)); - goto get_out; - } + Dmsg0(190, "Not in append mode, try mount.\n"); ASSERT(dev->num_writers == 0); - do_mount = 1; + do_mount = true; } - if (do_mount) { - if (!mount_next_write_volume(jcr, dev, block, release)) { - Jmsg(jcr, M_FATAL, 0, _("Could not ready device %s for append.\n"), - dev_name(dev)); + if (do_mount || recycle) { + Dmsg0(190, "Do mount_next_write_vol\n"); + bool mounted = mount_next_write_volume(dcr, release); + if (!mounted) { + if (!job_canceled(jcr)) { + /* Reduce "noise" -- don't print if job canceled */ + Jmsg(jcr, M_FATAL, 0, _("Could not ready device %s for append.\n"), + dev->print_name()); + } goto get_out; } } - dev->num_writers++; - if (dev->num_writers > 1) { - Dmsg2(100, "Hey!!!! There are %d writers on device %s\n", dev->num_writers, - dev_name(dev)); - } + dev->num_writers++; /* we are now a writer */ if (jcr->NumVolumes == 0) { jcr->NumVolumes = 1; } - attach_jcr_to_device(dev, jcr); /* attach jcr to device */ - rtn_dev = dev; /* return device */ + goto ok_out; +/* + * If we jump here, it is an error return because + * rtn_dev will still be NULL + */ get_out: - P(dev->mutex); + free_dcr(dcr); + dcr = NULL; +ok_out: + P(dev->mutex); unblock_device(dev); V(dev->mutex); - V(mutex); /* unlock other threads */ - return rtn_dev; + return dcr; } /* @@ -258,70 +556,93 @@ get_out: * the device remains open. * */ -int release_device(JCR *jcr, DEVICE *dev) +bool release_device(DCR *dcr) { + bool ok = true; + JCR *jcr = dcr->jcr; + DEVICE *dev = dcr->dev; + lock_device(dev); Dmsg1(100, "release_device device is %s\n", dev_is_tape(dev)?"tape":"disk"); - if (dev->state & ST_READ) { - dev->state &= ~ST_READ; /* clear read bit */ - if (!dev_is_tape(dev) || !dev_cap(dev, CAP_ALWAYSOPEN)) { - if (dev_cap(dev, CAP_OFFLINEUNMOUNT)) { - offline_dev(dev); - } + + /* if device is reserved, job never started, so release the reserve here */ + if (dcr->reserved_device) { + dev->reserved_device--; + dcr->reserved_device = false; + } + + if (dev->can_read()) { + dev->clear_read(); /* clear read bit */ + /* Close if file or !CAP_ALWAYSOPEN */ + if (!dev->is_tape() || !dev_cap(dev, CAP_ALWAYSOPEN)) { + offline_or_rewind_dev(dev); close_dev(dev); } /******FIXME**** send read volume usage statistics to director */ } else if (dev->num_writers > 0) { dev->num_writers--; - if (dev->state & ST_TAPE) { - jcr->EndBlock = dev->EndBlock; - jcr->EndFile = dev->EndFile; - Dmsg2(200, "Release device: EndFile=%u EndBlock=%u\n", jcr->EndFile, jcr->EndBlock); - } else { - jcr->EndBlock = (uint32_t)dev->file_addr; - jcr->EndFile = (uint32_t)(dev->file_addr >> 32); - } Dmsg1(100, "There are %d writers in release_device\n", dev->num_writers); - if (dev->num_writers == 0) { + if (dev->is_labeled()) { Dmsg0(100, "dir_create_jobmedia_record. Release\n"); - dir_create_jobmedia_record(jcr); - if (dev_can_write(dev)) { + if (!dir_create_jobmedia_record(dcr)) { + Jmsg(jcr, M_FATAL, 0, _("Could not create JobMedia record for Volume=\"%s\" Job=%s\n"), + dcr->VolCatInfo.VolCatName, jcr->Job); + ok = false; + } + /* If no more writers, write an EOF */ + if (!dev->num_writers && dev_can_write(dev)) { weof_dev(dev, 1); + write_ansi_ibm_labels(dcr, ANSI_EOF_LABEL, dev->VolHdr.VolName); } dev->VolCatInfo.VolCatFiles = dev->file; /* set number of files */ dev->VolCatInfo.VolCatJobs++; /* increment number of jobs */ /* Note! do volume update before close, which zaps VolCatInfo */ - Dmsg0(200, "dir_update_vol_info. Release0\n"); - dir_update_volume_info(jcr, &dev->VolCatInfo, 0); /* send Volume info to Director */ + Dmsg0(100, "dir_update_vol_info. Release0\n"); + dir_update_volume_info(dcr, false); /* send Volume info to Director */ + Dmsg0(100, "==== write ansi eof label \n"); + } - if (!dev_is_tape(dev) || !dev_cap(dev, CAP_ALWAYSOPEN)) { - if (dev_cap(dev, CAP_OFFLINEUNMOUNT)) { - offline_dev(dev); - } - close_dev(dev); - } - } else { - Dmsg0(100, "dir_create_jobmedia_record. Release\n"); - dir_create_jobmedia_record(jcr); - Dmsg0(200, "dir_update_vol_info. Release1\n"); - dev->VolCatInfo.VolCatFiles = dev->file; /* set number of files */ - dev->VolCatInfo.VolCatJobs++; /* increment number of jobs */ - dir_update_volume_info(jcr, &dev->VolCatInfo, 0); /* send Volume info to Director */ + /* If no writers, close if file or !CAP_ALWAYS_OPEN */ + if (dev->num_writers == 0 && (!dev->is_tape() || !dev_cap(dev, CAP_ALWAYSOPEN))) { + offline_or_rewind_dev(dev); + close_dev(dev); } } else { - Jmsg2(jcr, M_ERROR, 0, _("BAD ERROR: release_device %s, Volume %s not in use.\n"), - dev_name(dev), NPRT(jcr->VolumeName)); + Jmsg2(jcr, M_FATAL, 0, _("BAD ERROR: release_device %s, Volume \"%s\" not in use.\n"), + dev->print_name(), NPRT(dcr->VolumeName)); + Jmsg2(jcr, M_ERROR, 0, _("num_writers=%d state=%x\n"), dev->num_writers, dev->state); + ok = false; } - detach_jcr_from_device(dev, jcr); - if (dev->prev && !(dev->state & ST_READ) && dev->num_writers == 0) { - P(mutex); - unlock_device(dev); - dev->prev->next = dev->next; /* dechain */ - term_dev(dev); - V(mutex); - } else { - unlock_device(dev); + + /* Fire off Alert command and include any output */ + if (!job_canceled(jcr) && dcr->device->alert_command) { + POOLMEM *alert; + int status = 1; + BPIPE *bpipe; + char line[MAXSTRING]; + alert = get_pool_memory(PM_FNAME); + alert = edit_device_codes(dcr, alert, ""); + bpipe = open_bpipe(alert, 0, "r"); + if (bpipe) { + while (fgets(line, sizeof(line), bpipe->rfd)) { + Jmsg(jcr, M_ALERT, 0, _("Alert: %s"), line); + } + status = close_bpipe(bpipe); + } else { + status = errno; + } + if (status != 0) { + berrno be; + Jmsg(jcr, M_ALERT, 0, _("3997 Bad alert command: %s: ERR=%s.\n"), + alert, be.strerror(status)); + } + + Dmsg1(400, "alert status=%d\n", status); + free_pool_memory(alert); } - return 1; + unlock_device(dev); + free_dcr(dcr); + jcr->dcr = NULL; + return ok; }