X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=bacula%2Fsrc%2Fstored%2Facquire.c;h=e0ce9c5be3ff54ebcd71d16e3877ac96453a54f1;hb=eeeb98532770101aa2b310ac43c9379316c447ce;hp=4b88e35146f630c346a4bfe0da00ad09764ba1e5;hpb=fcc810b54e2fac2c96d6b8e24eb7ec8dd445ab34;p=bacula%2Fbacula diff --git a/bacula/src/stored/acquire.c b/bacula/src/stored/acquire.c index 4b88e35146..e0ce9c5be3 100644 --- a/bacula/src/stored/acquire.c +++ b/bacula/src/stored/acquire.c @@ -29,16 +29,10 @@ */ DCR *new_dcr(JCR *jcr, DEVICE *dev) { - if (jcr && jcr->dcr) { - return jcr->dcr; - } DCR *dcr = (DCR *)malloc(sizeof(DCR)); memset(dcr, 0, sizeof(DCR)); dcr->jcr = jcr; if (dev) { - if (jcr) { - jcr->dcr = dcr; - } dcr->dev = dev; dcr->device = dev->device; dcr->block = new_block(dev); @@ -195,16 +189,6 @@ DCR *acquire_device_for_read(DCR *dcr) goto default_path; } -#ifdef xxx_needed - /* If we have a dvd that requires mount, - * we need to try to open the label, so the info can be reported - * if a wrong volume has been mounted. - */ - if (dev->is_dvd() && (dcr->VolCatInfo.VolCatParts > 0)) { - break; - } -#endif - Jmsg3(jcr, M_FATAL, 0, _("Open device %s Volume \"%s\" failed: ERR=%s\n"), dev->print_name(), dcr->VolumeName, strerror_dev(dev)); goto get_out; @@ -285,7 +269,6 @@ default_path: get_out: dev->unblock(); if (!vol_ok) { - free_dcr(dcr); dcr = NULL; } return dcr; @@ -433,6 +416,7 @@ bool release_device(DCR *dcr) JCR *jcr = dcr->jcr; DEVICE *dev = dcr->dev; bool ok = true; + bool was_reading = false; lock_device(dev); Dmsg1(100, "release_device device is %s\n", dev->is_tape()?"tape":"disk"); @@ -446,6 +430,7 @@ bool release_device(DCR *dcr) if (dev->can_read()) { dev->clear_read(); /* clear read bit */ + was_reading = true; /******FIXME**** send read volume usage statistics to director */ @@ -520,7 +505,11 @@ bool release_device(DCR *dcr) } unlock_device(dev); free_dcr(dcr); - jcr->dcr = NULL; + if (was_reading) { + jcr->read_dcr = NULL; + } else { + jcr->dcr = NULL; + } pthread_cond_broadcast(&wait_device_release); return ok; }