X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=bacula%2Fsrc%2Fstored%2Fmount.c;h=98c3b80b3eb7780810439dd0af747f52aed2414e;hb=5c358307600ad7cd6983b8773f8d7dc1e7346c56;hp=08b0b33d474c0b2a255aeb82fa334f209d54be5a;hpb=eb1c6dff405b1dbd88df75f0559fc814ca9bbd8d;p=bacula%2Fbacula diff --git a/bacula/src/stored/mount.c b/bacula/src/stored/mount.c index 08b0b33d47..98c3b80b3e 100644 --- a/bacula/src/stored/mount.c +++ b/bacula/src/stored/mount.c @@ -72,7 +72,7 @@ bool DCR::mount_next_write_volume() int mode; DCR *dcr = this; - Dmsg2(150, "Enter mount_next_volume(release=%d) dev=%s\n", unload_device, + Dmsg2(150, "Enter mount_next_volume(release=%d) dev=%s\n", dev->must_unload(), dev->print_name()); init_device_wait_timers(dcr); @@ -89,50 +89,51 @@ mount_next_vol: if (!dev->poll && retry++ > 4) { /* Last ditch effort before giving up, force operator to respond */ VolCatInfo.Slot = 0; + unlock_volumes(); if (!dir_ask_sysop_to_mount_volume(dcr, ST_APPEND)) { Jmsg(jcr, M_FATAL, 0, _("Too many errors trying to mount device %s.\n"), dev->print_name()); - goto bail_out; + goto no_lock_bail_out; } + lock_volumes(); } if (job_canceled(jcr)) { Jmsg(jcr, M_FATAL, 0, _("Job %d canceled.\n"), jcr->JobId); goto bail_out; } recycle = false; - if (unload_device) { - Dmsg0(150, "mount_next_volume release=1\n"); - release_volume(dcr); - unload_autochanger(dcr, -1); - unload_device = false; + + if (dev->must_unload()) { ask = true; /* ask operator to mount tape */ } + do_swapping(true /*writing*/); - /* - * See if we are asked to swap the Volume from another device - * if so, unload the other device here, and attach the - * volume to our drive. - */ - if (swap_dev) { - Dmsg1(150, "Swap vol=%d\n", swap_dev->vol->vol_name); - dev->vol = swap_dev->vol; /* take its volume */ - swap_dev->vol = NULL; - unload_dev(dcr, swap_dev); - swap_dev = NULL; - dev->vol->clear_swapping(); - } if (!is_suitable_volume_mounted()) { + bool have_vol = false; + /* Do we have a candidate volume? */ + if (dev->vol) { + bstrncpy(VolumeName, dev->vol->vol_name, sizeof(VolumeName)); + have_vol = dir_get_volume_info(this, GET_VOL_INFO_FOR_WRITE); + } /* * Get Director's idea of what tape we should have mounted. * in dcr->VolCatInfo */ - Dmsg0(200, "Before dir_find_next_appendable_volume.\n"); - while (!dir_find_next_appendable_volume(dcr)) { - Dmsg0(200, "not dir_find_next\n"); - if (!dir_ask_sysop_to_create_appendable_volume(dcr)) { - goto bail_out; - } - Dmsg0(200, "Again dir_find_next_append...\n"); + if (!have_vol) { + Dmsg0(200, "Before dir_find_next_appendable_volume.\n"); + while (!dir_find_next_appendable_volume(dcr)) { + Dmsg0(200, "not dir_find_next\n"); + if (job_canceled(jcr)) { + goto bail_out; + } + unlock_volumes(); + if (!dir_ask_sysop_to_create_appendable_volume(dcr)) { + goto no_lock_bail_out; + } + lock_volumes(); + Dmsg0(200, "Again dir_find_next_append...\n"); + } + goto mount_next_vol; } } if (job_canceled(jcr)) { @@ -152,21 +153,21 @@ mount_next_vol: * and move the tape to the end of data. * */ - if (autoload_device(dcr, 1, NULL) > 0) { + if (autoload_device(dcr, true/*writing*/, NULL) > 0) { autochanger = true; ask = false; } else { autochanger = false; VolCatInfo.Slot = 0; } - Dmsg1(200, "autoload_dev returns %d\n", autochanger); + Dmsg1(150, "autoload_dev returns %d\n", autochanger); /* * If we autochanged to correct Volume or (we have not just * released the Volume AND we can automount) we go ahead * and read the label. If there is no tape in the drive, * we will fail, recurse and ask the operator the next time. */ - if (!unload_device && dev->is_tape() && dev->has_cap(CAP_AUTOMOUNT)) { + if (!dev->must_unload() && dev->is_tape() && dev->has_cap(CAP_AUTOMOUNT)) { Dmsg0(150, "(1)Ask=0\n"); ask = false; /* don't ask SYSOP this time */ } @@ -176,7 +177,7 @@ mount_next_vol: ask = false; } Dmsg2(150, "Ask=%d autochanger=%d\n", ask, autochanger); - unload_device = true; /* release next time if we "recurse" */ + dev->must_unload(); /* release next time if we "recurse" */ if (ask && !dir_ask_sysop_to_mount_volume(dcr, ST_APPEND)) { Dmsg0(150, "Error return ask_sysop ...\n"); @@ -226,7 +227,7 @@ mount_next_vol: } /* If DVD, ignore the error, very often you cannot open the device * (when there is no DVD, or when the one inserted is a wrong one) */ - if (dev->poll || dev->is_dvd() || dev->is_removable()) { + if (dev->poll || dev->is_dvd()) { goto mount_next_vol; } else { Jmsg(jcr, M_ERROR, 0, _("Could not open device %s: ERR=%s\n"), @@ -308,6 +309,8 @@ read_volume: bail_out: unlock_volumes(); + +no_lock_bail_out: return false; } @@ -337,7 +340,7 @@ int DCR::check_volume_label(bool &ask, bool &autochanger) */ switch (vol_label_status) { case VOL_OK: - Dmsg1(150, "Vol OK name=%s\n", VolumeName); + Dmsg1(150, "Vol OK name=%s\n", dev->VolHdr.VolumeName); dev->VolCatInfo = VolCatInfo; /* structure assignment */ break; /* got a Volume */ case VOL_NAME_ERROR: @@ -401,7 +404,7 @@ int DCR::check_volume_label(bool &ask, bool &autochanger) * This was not the volume we expected, but it is OK with * the Director, so use it. */ - Dmsg1(150, "want new name=%s\n", VolumeName); + Dmsg1(150, "Got new Volume name=%s\n", VolumeName); dev->VolCatInfo = VolCatInfo; /* structure assignment */ break; /* got a Volume */ /* @@ -460,13 +463,48 @@ bool DCR::is_suitable_volume_mounted() { /* Volume mounted? */ - if (dev->VolHdr.VolumeName[0] == 0 || swap_dev || unload_device) { + if (dev->VolHdr.VolumeName[0] == 0 || dev->swap_dev || dev->must_unload()) { return false; /* no */ } bstrncpy(VolumeName, dev->VolHdr.VolumeName, sizeof(VolumeName)); return dir_get_volume_info(this, GET_VOL_INFO_FOR_WRITE); } +void DCR::do_swapping(bool is_writing) +{ + if (dev->must_unload()) { + Dmsg1(100, "swapping: unloading %s\n", dev->print_name()); + release_volume(); + dev->clear_unload(); + } + /* + * See if we are asked to swap the Volume from another device + * if so, unload the other device here, and attach the + * volume to our drive. + */ + if (dev->swap_dev) { + if (dev->swap_dev->must_unload()) { + if (dev->vol) { + dev->swap_dev->set_slot(dev->vol->get_slot()); + } + Dmsg2(100, "Swap unloading slot=%d %s\n", dev->swap_dev->get_slot(), + dev->swap_dev->print_name()); + unload_dev(this, dev->swap_dev); + } + if (dev->vol) { + dev->vol->clear_swapping(); + dev->vol->set_in_use(); + dev->VolHdr.VolumeName[0] = 0; /* don't yet have right Volume */ + } + dev->swap_dev = NULL; + } + if (dev->must_load()) { + Dmsg1(100, "swapping: must load %s\n", dev->print_name()); + if (autoload_device(this, is_writing, NULL) > 0) { + dev->clear_load(); + } + } +} /* @@ -600,11 +638,12 @@ void DCR::mark_volume_in_error() { Jmsg(jcr, M_INFO, 0, _("Marking Volume \"%s\" in Error in Catalog.\n"), VolumeName); - dev->VolCatInfo = VolCatInfo; /* structure assignment */ + dev->VolCatInfo = VolCatInfo; /* structure assignment */ bstrncpy(dev->VolCatInfo.VolCatStatus, "Error", sizeof(dev->VolCatInfo.VolCatStatus)); Dmsg0(150, "dir_update_vol_info. Set Error.\n"); dir_update_volume_info(this, false, false); volume_unused(this); + dev->set_unload(); /* must get a new volume */ } /* @@ -627,11 +666,11 @@ void DCR::mark_volume_not_inchanger() * Either because we are going to hang a new volume, or because * of explicit user request, we release the current volume. */ -void release_volume(DCR *dcr) +void DCR::release_volume() { - JCR *jcr = dcr->jcr; - DEVICE *dev = dcr->dev; - if (dcr->WroteVol) { + unload_autochanger(this, -1); + + if (WroteVol) { Jmsg0(jcr, M_ERROR, 0, _("Hey!!!!! WroteVol non-zero !!!!!\n")); Dmsg0(190, "Hey!!!!! WroteVol non-zero !!!!!\n"); } @@ -642,14 +681,14 @@ void release_volume(DCR *dcr) dev->block_num = dev->file = 0; dev->EndBlock = dev->EndFile = 0; memset(&dev->VolCatInfo, 0, sizeof(dev->VolCatInfo)); -// memset(&dcr->VolCatInfo, 0, sizeof(dcr->VolCatInfo)); +// memset(&VolCatInfo, 0, sizeof(VolCatInfo)); dev->clear_volhdr(); /* Force re-read of label */ dev->clear_labeled(); dev->clear_read(); dev->clear_append(); dev->label_type = B_BACULA_LABEL; -// dcr->VolumeName[0] = 0; + VolumeName[0] = 0; if (dev->is_open() && (!dev->is_tape() || !dev->has_cap(CAP_ALWAYSOPEN))) { dev->close(); @@ -659,9 +698,48 @@ void release_volume(DCR *dcr) if (dev->is_open()) { dev->offline_or_rewind(); } + dev->set_unload(); Dmsg0(190, "release_volume\n"); } +/* + * Insanity check + * + * Check to see if the tape position as defined by the OS is + * the same as our concept. If it is not, + * it means the user has probably manually rewound the tape. + * Note, we check only if num_writers == 0, but this code will + * also work fine for any number of writers. If num_writers > 0, + * we probably should cancel all jobs using this device, or + * perhaps even abort the SD, or at a minimum, mark the tape + * in error. Another strategy with num_writers == 0, would be + * to rewind the tape and do a new eod() request. + */ +bool DCR::is_tape_position_ok() +{ + if (dev->is_tape() && dev->num_writers == 0) { + int32_t file = dev->get_os_tape_file(); + if (file >= 0 && file != (int32_t)dev->get_file()) { + Jmsg(jcr, M_ERROR, 0, _("Invalid tape position on volume \"%s\"" + " on device %s. Expected %d, got %d\n"), + dev->VolHdr.VolumeName, dev->print_name(), dev->get_file(), file); + /* + * If the current file is greater than zero, it means we probably + * have some bad count of EOF marks, so mark tape in error. Otherwise + * the operator might have moved the tape, so we just release it + * and try again. + */ + if (file > 0) { + mark_volume_in_error(); + } + release_volume(); + return false; + } + } + return true; +} + + /* * If we are reading, we come here at the end of the tape * and see if there are more volumes to be mounted.