X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=bacula%2Fsrc%2Fstored%2Fmount.c;h=efb76029d654fc00e9150ee54c23ea5754589972;hb=36b40d5c7f3ff90565ab73ac75f0dc4f6660ff37;hp=79edb8affb9babf4d9d2bc2708b037c27caa730d;hpb=ea8732e51723287fea374f57b2fb5211cda81231;p=bacula%2Fbacula diff --git a/bacula/src/stored/mount.c b/bacula/src/stored/mount.c index 79edb8affb..efb76029d6 100644 --- a/bacula/src/stored/mount.c +++ b/bacula/src/stored/mount.c @@ -20,7 +20,7 @@ Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. - Bacula® is a registered trademark of John Walker. + Bacula® is a registered trademark of Kern Sibbald. The licensor of Bacula is the Free Software Foundation Europe (FSFE), Fiduciary Program, Sumatrastrasse 25, 8006 Zürich, Switzerland, email:ftf@fsfeurope.org. @@ -38,9 +38,6 @@ #include "bacula.h" /* pull in global headers */ #include "stored.h" /* pull in Storage Deamon headers */ -static void mark_volume_not_inchanger(DCR *dcr); -static int try_autolabel(DCR *dcr, bool opened); -static bool is_eod_valid(DCR *dcr); enum { try_next_vol = 1, @@ -49,6 +46,13 @@ enum { try_default }; +enum { + check_next_vol = 1, + check_ok, + check_read_vol, + check_error +}; + /* * If release is set, we rewind the current volume, * which we no longer want, and ask the user (console) @@ -65,11 +69,11 @@ bool DCR::mount_next_write_volume() { int retry = 0; bool ask = false, recycle, autochanger; - int vol_label_status; + bool do_find = true; int mode; DCR *dcr = this; - Dmsg2(150, "Enter mount_next_volume(release=%d) dev=%s\n", unload_device, + Dmsg2(150, "Enter mount_next_volume(release=%d) dev=%s\n", dev->must_unload(), dev->print_name()); init_device_wait_timers(dcr); @@ -86,37 +90,37 @@ mount_next_vol: if (!dev->poll && retry++ > 4) { /* Last ditch effort before giving up, force operator to respond */ VolCatInfo.Slot = 0; + unlock_volumes(); if (!dir_ask_sysop_to_mount_volume(dcr, ST_APPEND)) { Jmsg(jcr, M_FATAL, 0, _("Too many errors trying to mount device %s.\n"), dev->print_name()); - goto bail_out; + goto no_lock_bail_out; } + lock_volumes(); + Dmsg1(150, "Continue after dir_ask_sysop_to_mount. must_load=%d\n", dev->must_load()); } if (job_canceled(jcr)) { Jmsg(jcr, M_FATAL, 0, _("Job %d canceled.\n"), jcr->JobId); goto bail_out; } recycle = false; - if (unload_device) { - Dmsg0(150, "mount_next_volume release=1\n"); - release_volume(dcr); - unload_autochanger(dcr, -1); - unload_device = false; + + if (retry >= 2) { + do_find = false; + } + + if (dev->must_unload()) { ask = true; /* ask operator to mount tape */ + do_find = true; /* re-find a volume after unload */ } + do_unload(); + do_swapping(true /*is_writing*/); + do_load(true /*is_writing*/); - /* - * Get Director's idea of what tape we should have mounted. - * in dcr->VolCatInfo - */ - Dmsg0(200, "Before dir_find_next_appendable_volume.\n"); - while (!dir_find_next_appendable_volume(dcr)) { - Dmsg0(200, "not dir_find_next\n"); - if (!dir_ask_sysop_to_create_appendable_volume(dcr)) { - goto bail_out; - } - Dmsg0(200, "Again dir_find_next_append...\n"); + if (do_find && !find_a_volume()) { + goto no_lock_bail_out; } + if (job_canceled(jcr)) { goto bail_out; } @@ -134,41 +138,39 @@ mount_next_vol: * and move the tape to the end of data. * */ - if (swap_dev) { - dev->vol = swap_dev->vol; /* take its volume */ - swap_dev->vol = NULL; - unload_dev(dcr, swap_dev); - swap_dev = NULL; - } - if (autoload_device(dcr, 1, NULL) > 0) { + if (autoload_device(dcr, true/*writing*/, NULL) > 0) { autochanger = true; ask = false; } else { autochanger = false; VolCatInfo.Slot = 0; + ask = retry >= 2; } - Dmsg1(200, "autoload_dev returns %d\n", autochanger); + Dmsg1(150, "autoload_dev returns %d\n", autochanger); /* * If we autochanged to correct Volume or (we have not just * released the Volume AND we can automount) we go ahead * and read the label. If there is no tape in the drive, * we will fail, recurse and ask the operator the next time. */ - if (!unload_device && dev->is_tape() && dev->has_cap(CAP_AUTOMOUNT)) { - Dmsg0(150, "(1)Ask=0\n"); + if (!dev->must_unload() && dev->is_tape() && dev->has_cap(CAP_AUTOMOUNT)) { + Dmsg0(250, "(1)Ask=0\n"); ask = false; /* don't ask SYSOP this time */ } /* Don't ask if not removable */ if (!dev->is_removable()) { - Dmsg0(150, "(2)Ask=0\n"); + Dmsg0(250, "(2)Ask=0\n"); ask = false; } - Dmsg2(150, "Ask=%d autochanger=%d\n", ask, autochanger); - unload_device = true; /* release next time if we "recurse" */ + Dmsg2(250, "Ask=%d autochanger=%d\n", ask, autochanger); - if (ask && !dir_ask_sysop_to_mount_volume(dcr, ST_APPEND)) { - Dmsg0(150, "Error return ask_sysop ...\n"); - goto bail_out; /* error return */ + if (ask) { + unlock_volumes(); + if (!dir_ask_sysop_to_mount_volume(dcr, ST_APPEND)) { + Dmsg0(150, "Error return ask_sysop ...\n"); + goto no_lock_bail_out; + } + lock_volumes(); } if (job_canceled(jcr)) { goto bail_out; @@ -188,7 +190,7 @@ mount_next_vol: } /* Try autolabel if enabled */ if (dev->open(dcr, mode) < 0) { - try_autolabel(dcr, false); /* try to create a new volume label */ + try_autolabel(false); /* try to create a new volume label */ } while (dev->open(dcr, mode) < 0) { Dmsg1(150, "open_device failed: ERR=%s\n", dev->bstrerror()); @@ -209,24 +211,139 @@ mount_next_vol: dev->unmount(0); } } - if (try_autolabel(dcr, false) == try_read_vol) { + if (try_autolabel(false) == try_read_vol) { break; /* created a new volume label */ } - /* If DVD, ignore the error, very often you cannot open the device - * (when there is no DVD, or when the one inserted is a wrong one) */ - if (dev->poll || dev->is_dvd() || dev->is_removable()) { - goto mount_next_vol; - } else { - Jmsg(jcr, M_ERROR, 0, _("Could not open device %s: ERR=%s\n"), - dev->print_name(), dev->print_errmsg()); - goto bail_out; - } + Dmsg0(50, "set_unload\n"); + dev->set_unload(); /* force ask sysop */ + ask = true; + Dmsg0(150, "goto mount_next_vol\n"); + goto mount_next_vol; } /* - * Now make sure we have the right tape mounted + * Now check the volume label to make sure we have the right tape mounted */ read_volume: + switch (check_volume_label(ask, autochanger)) { + case check_next_vol: + Dmsg0(50, "set_unload\n"); + dev->set_unload(); /* want a different Volume */ + Dmsg0(150, "goto mount_next_vol\n"); + goto mount_next_vol; + case check_read_vol: + goto read_volume; + case check_error: + goto bail_out; + case check_ok: + break; + } + + /* + * See if we have a fresh tape or a tape with data. + * + * Note, if the LabelType is PRE_LABEL, it was labeled + * but never written. If so, rewrite the label but set as + * VOL_LABEL. We rewind and return the label (reconstructed) + * in the block so that in the case of a new tape, data can + * be appended just after the block label. If we are writing + * a second volume, the calling routine will write the label + * before writing the overflow block. + * + * If the tape is marked as Recycle, we rewrite the label. + */ + recycle = strcmp(dev->VolCatInfo.VolCatStatus, "Recycle") == 0; + if (dev->VolHdr.LabelType == PRE_LABEL || recycle) { + if (!rewrite_volume_label(dcr, recycle)) { + mark_volume_in_error(); + goto mount_next_vol; + } + } else { + /* + * OK, at this point, we have a valid Bacula label, but + * we need to position to the end of the volume, since we are + * just now putting it into append mode. + */ + Dmsg0(200, "Device previously written, moving to end of data\n"); + Jmsg(jcr, M_INFO, 0, _("Volume \"%s\" previously written, moving to end of data.\n"), + VolumeName); + + if (!dev->eod(dcr)) { + Jmsg(jcr, M_ERROR, 0, _("Unable to position to end of data on device %s: ERR=%s\n"), + dev->print_name(), dev->bstrerror()); + mark_volume_in_error(); + goto mount_next_vol; + } + if (!is_eod_valid()) { + Dmsg0(150, "goto mount_next_vol\n"); + goto mount_next_vol; + } + + dev->VolCatInfo.VolCatMounts++; /* Update mounts */ + Dmsg1(150, "update volinfo mounts=%d\n", dev->VolCatInfo.VolCatMounts); + if (!dir_update_volume_info(dcr, false, false)) { + goto bail_out; + } + + /* Return an empty block */ + empty_block(block); /* we used it for reading so set for write */ + } + dev->set_append(); + Dmsg1(150, "set APPEND, normal return from mount_next_write_volume. dev=%s\n", + dev->print_name()); + + unlock_volumes(); + return true; + +bail_out: + unlock_volumes(); + +no_lock_bail_out: + return false; +} + +/* + * This routine is meant to be called once the first pass + * to ensure that we have a candidate volume to mount. + * Otherwise, we ask the sysop to created one. + */ +bool DCR::find_a_volume() +{ + DCR *dcr = this; + if (!is_suitable_volume_mounted()) { + bool have_vol = false; + /* Do we have a candidate volume? */ + if (dev->vol) { + bstrncpy(VolumeName, dev->vol->vol_name, sizeof(VolumeName)); + have_vol = dir_get_volume_info(this, GET_VOL_INFO_FOR_WRITE); + } + /* + * Get Director's idea of what tape we should have mounted. + * in dcr->VolCatInfo + */ + if (!have_vol) { + Dmsg0(200, "Before dir_find_next_appendable_volume.\n"); + while (!dir_find_next_appendable_volume(dcr)) { + Dmsg0(200, "not dir_find_next\n"); + if (job_canceled(jcr)) { + unlock_volumes(); + return false; + } + unlock_volumes(); + if (!dir_ask_sysop_to_create_appendable_volume(dcr)) { + return false; + } + lock_volumes(); + Dmsg0(150, "Again dir_find_next_append...\n"); + } + } + } + return true; +} + +int DCR::check_volume_label(bool &ask, bool &autochanger) +{ + int vol_label_status; /* * If we are writing to a stream device, ASSUME the volume label * is correct. @@ -236,10 +353,10 @@ read_volume: create_volume_label(dev, VolumeName, "Default", false /* not DVD */); dev->VolHdr.LabelType = PRE_LABEL; } else { - vol_label_status = read_dev_volume_label(dcr); + vol_label_status = read_dev_volume_label(this); } if (job_canceled(jcr)) { - goto bail_out; + goto check_bail_out; } Dmsg2(150, "Want dirVol=%s dirStat=%s\n", VolumeName, @@ -250,29 +367,27 @@ read_volume: */ switch (vol_label_status) { case VOL_OK: - Dmsg1(150, "Vol OK name=%s\n", VolumeName); + Dmsg1(150, "Vol OK name=%s\n", dev->VolHdr.VolumeName); dev->VolCatInfo = VolCatInfo; /* structure assignment */ - recycle = strcmp(dev->VolCatInfo.VolCatStatus, "Recycle") == 0; break; /* got a Volume */ case VOL_NAME_ERROR: VOLUME_CAT_INFO dcrVolCatInfo, devVolCatInfo; - char VolumeName[MAX_NAME_LENGTH]; + char saveVolumeName[MAX_NAME_LENGTH]; + + Dmsg2(150, "Vol NAME Error Have=%s, want=%s\n", dev->VolHdr.VolumeName, VolumeName); + if (dev->is_volume_to_unload()) { + ask = true; + goto check_next_volume; + } /* If not removable, Volume is broken */ if (!dev->is_removable()) { Jmsg(jcr, M_WARNING, 0, _("Volume \"%s\" not on device %s.\n"), VolumeName, dev->print_name()); - dcr->mark_volume_in_error(); - goto mount_next_vol; + mark_volume_in_error(); + goto check_next_volume; } - Dmsg1(150, "Vol NAME Error Name=%s\n", VolumeName); - /* If polling and got a previous bad name, ignore it */ - if (dev->poll && strcmp(dev->BadVolName, dev->VolHdr.VolumeName) == 0) { - ask = true; - Dmsg1(200, "Vol Name error supress due to poll. Name=%s\n", VolumeName); - goto mount_next_vol; - } /* * OK, we got a different volume mounted. First save the * requested Volume info (dcr) structure, then query if @@ -282,24 +397,24 @@ read_volume: dcrVolCatInfo = VolCatInfo; /* structure assignment */ devVolCatInfo = dev->VolCatInfo; /* structure assignment */ /* Check if this is a valid Volume in the pool */ - bstrncpy(VolumeName, VolumeName, sizeof(VolumeName)); + bstrncpy(saveVolumeName, VolumeName, sizeof(saveVolumeName)); bstrncpy(VolumeName, dev->VolHdr.VolumeName, sizeof(VolumeName)); - if (!dir_get_volume_info(dcr, GET_VOL_INFO_FOR_WRITE)) { + if (!dir_get_volume_info(this, GET_VOL_INFO_FOR_WRITE)) { POOL_MEM vol_info_msg; pm_strcpy(vol_info_msg, jcr->dir_bsock->msg); /* save error message */ /* Restore desired volume name, note device info out of sync */ /* This gets the info regardless of the Pool */ bstrncpy(VolumeName, dev->VolHdr.VolumeName, sizeof(VolumeName)); - if (autochanger && !dir_get_volume_info(dcr, GET_VOL_INFO_FOR_READ)) { + if (autochanger && !dir_get_volume_info(this, GET_VOL_INFO_FOR_READ)) { /* * If we get here, we know we cannot write on the Volume, * and we know that we cannot read it either, so it * is not in the autochanger. */ - mark_volume_not_inchanger(dcr); + mark_volume_not_inchanger(); } dev->VolCatInfo = devVolCatInfo; /* structure assignment */ - bstrncpy(dev->BadVolName, dev->VolHdr.VolumeName, sizeof(dev->BadVolName)); + dev->set_unload(); /* unload this volume */ Jmsg(jcr, M_WARNING, 0, _("Director wanted Volume \"%s\".\n" " Current Volume \"%s\" not acceptable because:\n" " %s"), @@ -307,17 +422,23 @@ read_volume: vol_info_msg.c_str()); ask = true; /* Restore saved DCR before continuing */ - bstrncpy(VolumeName, VolumeName, sizeof(VolumeName)); + bstrncpy(VolumeName, saveVolumeName, sizeof(VolumeName)); VolCatInfo = dcrVolCatInfo; /* structure assignment */ - goto mount_next_vol; + goto check_next_volume; } /* * This was not the volume we expected, but it is OK with * the Director, so use it. */ - Dmsg1(150, "want new name=%s\n", VolumeName); + Dmsg1(150, "Got new Volume name=%s\n", VolumeName); dev->VolCatInfo = VolCatInfo; /* structure assignment */ - recycle = strcmp(dev->VolCatInfo.VolCatStatus, "Recycle") == 0; + Dmsg1(100, "Call reserve_volume=%s\n", dev->VolHdr.VolumeName); + if (reserve_volume(this, dev->VolHdr.VolumeName) == NULL) { + Jmsg2(jcr, M_WARNING, 0, _("Could not reserve volume %s on %s\n"), + dev->VolHdr.VolumeName, dev->print_name()); + ask = true; + goto check_next_volume; + } break; /* got a Volume */ /* * At this point, we assume we have a blank tape mounted. @@ -325,18 +446,18 @@ read_volume: case VOL_IO_ERROR: if (dev->is_dvd()) { Jmsg(jcr, M_FATAL, 0, "%s", jcr->errmsg); - dcr->mark_volume_in_error(); - goto bail_out; /* we could not write on DVD */ + mark_volume_in_error(); + goto check_bail_out; /* we could not write on DVD */ } /* Fall through wanted */ case VOL_NO_LABEL: - switch (try_autolabel(dcr, true)) { + switch (try_autolabel(true)) { case try_next_vol: - goto mount_next_vol; + goto check_next_volume; case try_read_vol: - goto read_volume; + goto check_read_volume; case try_error: - goto bail_out; + goto check_bail_out; case try_default: break; } @@ -355,66 +476,78 @@ read_volume: if (dev->requires_mount()) { dev->close(); } - goto mount_next_vol; + goto check_next_volume; } + return check_ok; - /* - * See if we have a fresh tape or a tape with data. - * - * Note, if the LabelType is PRE_LABEL, it was labeled - * but never written. If so, rewrite the label but set as - * VOL_LABEL. We rewind and return the label (reconstructed) - * in the block so that in the case of a new tape, data can - * be appended just after the block label. If we are writing - * a second volume, the calling routine will write the label - * before writing the overflow block. - * - * If the tape is marked as Recycle, we rewrite the label. - */ - if (dev->VolHdr.LabelType == PRE_LABEL || recycle) { - if (!rewrite_volume_label(dcr, recycle)) { - dcr->mark_volume_in_error(); - goto mount_next_vol; - } - } else { - /* - * OK, at this point, we have a valid Bacula label, but - * we need to position to the end of the volume, since we are - * just now putting it into append mode. - */ - Dmsg0(200, "Device previously written, moving to end of data\n"); - Jmsg(jcr, M_INFO, 0, _("Volume \"%s\" previously written, moving to end of data.\n"), - VolumeName); +check_next_volume: + return check_next_vol; - if (!dev->eod(dcr)) { - Jmsg(jcr, M_ERROR, 0, _("Unable to position to end of data on device %s: ERR=%s\n"), - dev->print_name(), dev->bstrerror()); - dcr->mark_volume_in_error(); - goto mount_next_vol; - } - if (!is_eod_valid(dcr)) { - goto mount_next_vol; - } +check_bail_out: + return check_error; - dev->VolCatInfo.VolCatMounts++; /* Update mounts */ - Dmsg1(150, "update volinfo mounts=%d\n", dev->VolCatInfo.VolCatMounts); - if (!dir_update_volume_info(dcr, false, false)) { - goto bail_out; - } - - /* Return an empty block */ - empty_block(block); /* we used it for reading so set for write */ +check_read_volume: + return check_read_vol; + +} + + +bool DCR::is_suitable_volume_mounted() +{ + /* Volume mounted? */ + if (dev->VolHdr.VolumeName[0] == 0 || dev->swap_dev || dev->must_unload()) { + return false; /* no */ } - dev->set_append(); - Dmsg1(150, "set APPEND, normal return from mount_next_write_volume. dev=%s\n", - dev->print_name()); + bstrncpy(VolumeName, dev->VolHdr.VolumeName, sizeof(VolumeName)); + return dir_get_volume_info(this, GET_VOL_INFO_FOR_WRITE); +} - unlock_volumes(); +bool DCR::do_unload() +{ + if (dev->must_unload()) { + Dmsg1(100, "must_unload release %s\n", dev->print_name()); + release_volume(); + } + return false; +} + +bool DCR::do_load(bool is_writing) +{ + if (dev->must_load()) { + Dmsg1(100, "Must load %s\n", dev->print_name()); + if (autoload_device(this, is_writing, NULL) > 0) { + dev->clear_load(); + return true; + } + return false; + } return true; +} -bail_out: - unlock_volumes(); - return false; +void DCR::do_swapping(bool is_writing) +{ + /* + * See if we are asked to swap the Volume from another device + * if so, unload the other device here, and attach the + * volume to our drive. + */ + if (dev->swap_dev) { + if (dev->swap_dev->must_unload()) { + if (dev->vol) { + dev->swap_dev->set_slot(dev->vol->get_slot()); + } + Dmsg2(100, "Swap unloading slot=%d %s\n", dev->swap_dev->get_slot(), + dev->swap_dev->print_name()); + unload_dev(this, dev->swap_dev); + } + if (dev->vol) { + dev->vol->clear_swapping(); + Dmsg1(100, "=== set in_use vol=%s\n", dev->vol->vol_name); + dev->vol->set_in_use(); + dev->VolHdr.VolumeName[0] = 0; /* don't yet have right Volume */ + } + dev->swap_dev = NULL; + } } @@ -422,24 +555,21 @@ bail_out: * Check if the current position on the volume corresponds to * what is in the catalog. */ -static bool is_eod_valid(DCR *dcr) +bool DCR::is_eod_valid() { - DEVICE *dev = dcr->dev; - JCR *jcr = dcr->jcr; - if (dev->is_dvd()) { char ed1[50], ed2[50]; if (dev->VolCatInfo.VolCatBytes == dev->part_start + dev->part_size) { Jmsg(jcr, M_INFO, 0, _("Ready to append to end of Volume \"%s\"" - " part=%d size=%s\n"), dcr->VolumeName, + " part=%d size=%s\n"), VolumeName, dev->part, edit_uint64(dev->VolCatInfo.VolCatBytes,ed1)); } else { Jmsg(jcr, M_ERROR, 0, _("Bacula cannot write on DVD Volume \"%s\" because: " "The sizes do not match! Volume=%s Catalog=%s\n"), - dcr->VolumeName, + VolumeName, edit_uint64(dev->part_start + dev->part_size, ed1), edit_uint64(dev->VolCatInfo.VolCatBytes, ed2)); - dcr->mark_volume_in_error(); + mark_volume_in_error(); return false; } } else if (dev->is_tape()) { @@ -449,29 +579,29 @@ static bool is_eod_valid(DCR *dcr) */ if (dev->VolCatInfo.VolCatFiles == dev->get_file()) { Jmsg(jcr, M_INFO, 0, _("Ready to append to end of Volume \"%s\" at file=%d.\n"), - dcr->VolumeName, dev->get_file()); + VolumeName, dev->get_file()); } else { Jmsg(jcr, M_ERROR, 0, _("Bacula cannot write on tape Volume \"%s\" because:\n" "The number of files mismatch! Volume=%u Catalog=%u\n"), - dcr->VolumeName, dev->get_file(), dev->VolCatInfo.VolCatFiles); - dcr->mark_volume_in_error(); + VolumeName, dev->get_file(), dev->VolCatInfo.VolCatFiles); + mark_volume_in_error(); return false; } } else if (dev->is_file()) { char ed1[50], ed2[50]; boffset_t pos; - pos = dev->lseek(dcr, (boffset_t)0, SEEK_END); + pos = dev->lseek(this, (boffset_t)0, SEEK_END); if (dev->VolCatInfo.VolCatBytes == (uint64_t)pos) { Jmsg(jcr, M_INFO, 0, _("Ready to append to end of Volume \"%s\"" - " size=%s\n"), dcr->VolumeName, + " size=%s\n"), VolumeName, edit_uint64(dev->VolCatInfo.VolCatBytes, ed1)); } else { Jmsg(jcr, M_ERROR, 0, _("Bacula cannot write on disk Volume \"%s\" because: " "The sizes do not match! Volume=%s Catalog=%s\n"), - dcr->VolumeName, + VolumeName, edit_uint64(pos, ed1), edit_uint64(dev->VolCatInfo.VolCatBytes, ed2)); - dcr->mark_volume_in_error(); + mark_volume_in_error(); return false; } } @@ -496,9 +626,9 @@ static bool is_eod_valid(DCR *dcr) * try_error hard error (catalog update) * try_default I couldn't do anything */ -static int try_autolabel(DCR *dcr, bool opened) +int DCR::try_autolabel(bool opened) { - DEVICE *dev = dcr->dev; + DCR *dcr = this; if (dev->poll && !dev->is_tape()) { return try_default; /* if polling, don't try to create new labels */ @@ -507,38 +637,39 @@ static int try_autolabel(DCR *dcr, bool opened) if (!opened && dev->is_tape()) { return try_default; } - if (dev->has_cap(CAP_LABEL) && (dcr->VolCatInfo.VolCatBytes == 0 || - (!dev->is_tape() && strcmp(dcr->VolCatInfo.VolCatStatus, + if (dev->has_cap(CAP_LABEL) && (VolCatInfo.VolCatBytes == 0 || + (!dev->is_tape() && strcmp(VolCatInfo.VolCatStatus, "Recycle") == 0))) { Dmsg0(150, "Create volume label\n"); /* Create a new Volume label and write it to the device */ - if (!write_new_volume_label_to_dev(dcr, dcr->VolumeName, - dcr->pool_name, false, /* no relabel */ false /* defer DVD label */)) { - Dmsg0(150, "!write_vol_label\n"); + if (!write_new_volume_label_to_dev(dcr, VolumeName, + pool_name, false, /* no relabel */ false /* defer DVD label */)) { + Dmsg2(150, "write_vol_label failed. vol=%s, pool=%s\n", + VolumeName, pool_name); if (opened) { - dcr->mark_volume_in_error(); + mark_volume_in_error(); } return try_next_vol; } Dmsg0(150, "dir_update_vol_info. Set Append\n"); /* Copy Director's info into the device info */ - dev->VolCatInfo = dcr->VolCatInfo; /* structure assignment */ + dev->VolCatInfo = VolCatInfo; /* structure assignment */ if (!dir_update_volume_info(dcr, true, true)) { /* indicate tape labeled */ return try_error; } Jmsg(dcr->jcr, M_INFO, 0, _("Labeled new Volume \"%s\" on device %s.\n"), - dcr->VolumeName, dev->print_name()); + VolumeName, dev->print_name()); return try_read_vol; /* read label we just wrote */ } - if (!dev->has_cap(CAP_LABEL) && dcr->VolCatInfo.VolCatBytes == 0) { - Jmsg(dcr->jcr, M_WARNING, 0, _("Device %s not configured to autolabel Volumes.\n"), + if (!dev->has_cap(CAP_LABEL) && VolCatInfo.VolCatBytes == 0) { + Jmsg(jcr, M_WARNING, 0, _("Device %s not configured to autolabel Volumes.\n"), dev->print_name()); } /* If not removable, Volume is broken */ if (!dev->is_removable()) { - Jmsg(dcr->jcr, M_WARNING, 0, _("Volume \"%s\" not on device %s.\n"), - dcr->VolumeName, dev->print_name()); - dcr->mark_volume_in_error(); + Jmsg(jcr, M_WARNING, 0, _("Volume \"%s\" not on device %s.\n"), + VolumeName, dev->print_name()); + mark_volume_in_error(); return try_next_vol; } return try_default; @@ -552,42 +683,42 @@ void DCR::mark_volume_in_error() { Jmsg(jcr, M_INFO, 0, _("Marking Volume \"%s\" in Error in Catalog.\n"), VolumeName); - dev->VolCatInfo = VolCatInfo; /* structure assignment */ + dev->VolCatInfo = VolCatInfo; /* structure assignment */ bstrncpy(dev->VolCatInfo.VolCatStatus, "Error", sizeof(dev->VolCatInfo.VolCatStatus)); Dmsg0(150, "dir_update_vol_info. Set Error.\n"); dir_update_volume_info(this, false, false); volume_unused(this); + Dmsg0(50, "set_unload\n"); + dev->set_unload(); /* must get a new volume */ } /* * The Volume is not in the correct slot, so mark this * Volume as not being in the Changer. */ -static void mark_volume_not_inchanger(DCR *dcr) +void DCR::mark_volume_not_inchanger() { - JCR *jcr = dcr->jcr; - DEVICE *dev = dcr->dev; Jmsg(jcr, M_ERROR, 0, _("Autochanger Volume \"%s\" not found in slot %d.\n" " Setting InChanger to zero in catalog.\n"), - dcr->VolCatInfo.VolCatName, dcr->VolCatInfo.Slot); - dev->VolCatInfo = dcr->VolCatInfo; /* structure assignment */ - dcr->VolCatInfo.InChanger = false; + VolCatInfo.VolCatName, VolCatInfo.Slot); + dev->VolCatInfo = VolCatInfo; /* structure assignment */ + VolCatInfo.InChanger = false; dev->VolCatInfo.InChanger = false; Dmsg0(400, "update vol info in mount\n"); - dir_update_volume_info(dcr, true, false); /* set new status */ + dir_update_volume_info(this, true, false); /* set new status */ } /* * Either because we are going to hang a new volume, or because * of explicit user request, we release the current volume. */ -void release_volume(DCR *dcr) +void DCR::release_volume() { - JCR *jcr = dcr->jcr; - DEVICE *dev = dcr->dev; - if (dcr->WroteVol) { + unload_autochanger(this, -1); + + if (WroteVol) { Jmsg0(jcr, M_ERROR, 0, _("Hey!!!!! WroteVol non-zero !!!!!\n")); - Dmsg0(190, "Hey!!!!! WroteVol non-zero !!!!!\n"); + Pmsg0(190, "Hey!!!!! WroteVol non-zero !!!!!\n"); } /* * First erase all memory of the current volume @@ -596,14 +727,13 @@ void release_volume(DCR *dcr) dev->block_num = dev->file = 0; dev->EndBlock = dev->EndFile = 0; memset(&dev->VolCatInfo, 0, sizeof(dev->VolCatInfo)); -// memset(&dcr->VolCatInfo, 0, sizeof(dcr->VolCatInfo)); dev->clear_volhdr(); /* Force re-read of label */ dev->clear_labeled(); dev->clear_read(); dev->clear_append(); dev->label_type = B_BACULA_LABEL; -// dcr->VolumeName[0] = 0; + VolumeName[0] = 0; if (dev->is_open() && (!dev->is_tape() || !dev->has_cap(CAP_ALWAYSOPEN))) { dev->close(); @@ -613,9 +743,49 @@ void release_volume(DCR *dcr) if (dev->is_open()) { dev->offline_or_rewind(); } +// Dmsg0(50, "set_unload\n"); +// dev->set_unload(); Dmsg0(190, "release_volume\n"); } +/* + * Insanity check + * + * Check to see if the tape position as defined by the OS is + * the same as our concept. If it is not, + * it means the user has probably manually rewound the tape. + * Note, we check only if num_writers == 0, but this code will + * also work fine for any number of writers. If num_writers > 0, + * we probably should cancel all jobs using this device, or + * perhaps even abort the SD, or at a minimum, mark the tape + * in error. Another strategy with num_writers == 0, would be + * to rewind the tape and do a new eod() request. + */ +bool DCR::is_tape_position_ok() +{ + if (dev->is_tape() && dev->num_writers == 0) { + int32_t file = dev->get_os_tape_file(); + if (file >= 0 && file != (int32_t)dev->get_file()) { + Jmsg(jcr, M_ERROR, 0, _("Invalid tape position on volume \"%s\"" + " on device %s. Expected %d, got %d\n"), + dev->VolHdr.VolumeName, dev->print_name(), dev->get_file(), file); + /* + * If the current file is greater than zero, it means we probably + * have some bad count of EOF marks, so mark tape in error. Otherwise + * the operator might have moved the tape, so we just release it + * and try again. + */ + if (file > 0) { + mark_volume_in_error(); + } + release_volume(); + return false; + } + } + return true; +} + + /* * If we are reading, we come here at the end of the tape * and see if there are more volumes to be mounted.