X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=libraries%2Flibldap%2Fdntest.c;h=72d3c52febb82f4e73f4c1564564ccfcef8a84eb;hb=bb17493d31e19c47bc3a906a39ffa3d57e28aaa4;hp=f5d7fbde5e32058936f3b313ab4ada0e4aa51f3b;hpb=0e2af54a3ffdeebe3901370683be56fcc53023b0;p=openldap

diff --git a/libraries/libldap/dntest.c b/libraries/libldap/dntest.c
index f5d7fbde5e..72d3c52feb 100644
--- a/libraries/libldap/dntest.c
+++ b/libraries/libldap/dntest.c
@@ -31,8 +31,8 @@ int
 main( int argc, char *argv[] )
 {
 	int 		rc, i, debug = 0, f2 = 0;
-	unsigned 	flags[ 2 ] = { 0U, LDAP_DN_FORMAT_LDAPV3 };
-	char		*strin, *str, *str2, buf[ 1024 ];
+	unsigned 	flags[ 2 ] = { 0U, 0 };
+	char		*strin, *str = NULL, buf[ 1024 ];
 	LDAPDN		*dn, *dn2 = NULL;
 
 	while ( 1 ) {
@@ -72,8 +72,8 @@ main( int argc, char *argv[] )
 		size_t len;
 		
 		fgets( buf, sizeof( buf ), stdin );
-		len = strlen( buf ) - 1;
-		if ( len >= 0 && buf[ len ] == '\n' ) {
+		len = strlen( buf );
+		if ( len > 0 && buf[ --len ] == '\n' ) {
 			buf[ len ] = '\0';
 		}
 		strin = buf;
@@ -114,16 +114,19 @@ main( int argc, char *argv[] )
 		}
 	}
 
+	if ( flags[ 1 ] == 0 )
+		flags[ 1 ] = LDAP_DN_FORMAT_LDAPV3;
+
 	f2 = 1;
 
 	rc = ldap_str2dn( strin, &dn, flags[ 0 ] );
 
 	if ( rc == LDAP_SUCCESS ) {
 		int i;
-		if( dn ) {
-			for ( i = 0; dn[i]; i++ ) {
+		if ( dn ) {
+			for ( i = 0; dn[ 0 ][ i ]; i++ ) {
 				LDAPRDN		*rdn = dn[ 0 ][ i ];
-				char		*rstr;
+				char		*rstr = NULL;
 
 				if ( ldap_rdn2str( rdn, &rstr, flags[ f2 ] ) ) {
 					fprintf( stdout, "\tldap_rdn2str() failed\n" );
@@ -138,10 +141,11 @@ main( int argc, char *argv[] )
 		}
 	}
 
+	str = NULL;
 	if ( rc == LDAP_SUCCESS &&
 		ldap_dn2str( dn, &str, flags[ f2 ] ) == LDAP_SUCCESS )
 	{
-		char	**values, *tmp, *tmp2;
+		char	**values, *tmp, *tmp2, *str2 = NULL;
 		int	n;
 		
 		fprintf( stdout, "\nldap_dn2str(ldap_str2dn(\"%s\"))\n"
@@ -158,6 +162,7 @@ main( int argc, char *argv[] )
 			fprintf( stdout, "\nldap_dn2ufn(\"%s\")\n"
 					"\t= \"%s\"\n", strin, tmp );
 			ldap_memfree( tmp );
+
 			tmp = ldap_dn2dcedn( strin );
 			fprintf( stdout, "\nldap_dn2dcedn(\"%s\")\n"
 					"\t= \"%s\"\n", strin, tmp );
@@ -166,6 +171,7 @@ main( int argc, char *argv[] )
 					"\t= \"%s\"\n", tmp, tmp2 );
 			ldap_memfree( tmp );
 			ldap_memfree( tmp2 );
+
 			tmp = ldap_dn2ad_canonical( strin );
 			fprintf( stdout, "\nldap_dn2ad_canonical(\"%s\")\n"
 					"\t= \"%s\"\n", strin, tmp );
@@ -210,8 +216,10 @@ main( int argc, char *argv[] )
 
 			break;
 		}
-	
+
+		dn2 = NULL;	
 		rc = ldap_str2dn( str, &dn2, flags[ f2 ] );
+		str2 = NULL;
 		if ( rc == LDAP_SUCCESS && 
 				ldap_dn2str( dn2, &str2, flags[ f2 ] )
 				== LDAP_SUCCESS ) {
@@ -221,10 +229,8 @@ main( int argc, char *argv[] )
 				str, str2, 
 				strcmp( str, str2 ) == 0 ? "yes" : "no" );
 
-			if(( dn != NULL && dn2 == NULL )
-				|| ( dn != NULL && dn2 == NULL ))
-			{
-				fprintf( stdout, "mismatch\n" );
+			if( dn != NULL && dn2 == NULL ) {
+				fprintf( stdout, "dn mismatch\n" );
 			} else if (( dn != NULL ) && (dn2 != NULL))
 				for ( iRDN = 0; dn[ 0 ][ iRDN ] && dn2[ 0 ][ iRDN ]; iRDN++ )
 			{
@@ -236,15 +242,23 @@ main( int argc, char *argv[] )
 					LDAPAVA		*a = r[ 0 ][ iAVA ];
 					LDAPAVA		*a2 = r2[ 0 ][ iAVA ];
 
-					if ( a->la_attr.bv_len != a2->la_attr.bv_len
-						|| memcmp( a->la_attr.bv_val, a2->la_attr.bv_val,
-							a->la_attr.bv_len )
-						|| a->la_flags != a2->la_flags
-						|| a->la_value.bv_len != a2->la_value.bv_len
-						|| memcmp( a->la_value.bv_val, a2->la_value.bv_val,
-							a->la_value.bv_len ) )
-					{
-						fprintf( stdout, "mismatch\n" );
+					if ( a->la_attr.bv_len != a2->la_attr.bv_len ) {
+						fprintf( stdout, "ava(%d), rdn(%d) attr len mismatch (%ld->%ld)\n", 
+								iAVA + 1, iRDN + 1,
+								a->la_attr.bv_len, a2->la_attr.bv_len );
+					} else if ( memcmp( a->la_attr.bv_val, a2->la_attr.bv_val, a->la_attr.bv_len ) ) {
+						fprintf( stdout, "ava(%d), rdn(%d) attr mismatch\n", 
+								iAVA + 1, iRDN + 1 );
+					} else if ( a->la_flags != a2->la_flags ) {
+						fprintf( stdout, "ava(%d), rdn(%d) flag mismatch (%x->%x)\n", 
+								iAVA + 1, iRDN + 1, a->la_flags, a2->la_flags );
+					} else if ( a->la_value.bv_len != a2->la_value.bv_len ) {
+						fprintf( stdout, "ava(%d), rdn(%d) value len mismatch (%ld->%ld)\n", 
+								iAVA + 1, iRDN + 1, 
+								a->la_value.bv_len, a2->la_value.bv_len );
+					} else if ( memcmp( a->la_value.bv_val, a2->la_value.bv_val, a->la_value.bv_len ) ) {
+						fprintf( stdout, "ava(%d), rdn(%d) value mismatch\n", 
+								iAVA + 1, iRDN + 1 );
 					}
 				}
 			}