X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=libraries%2Flibldap%2Fpasswd.c;h=b6caab58310268cf8afd804b540637882a9f477f;hb=c3e28a5488a8011ef0352f48fca85c48679205ba;hp=7fbc0cf900be4a40e581b44a0a66f2ac225e6f91;hpb=3c598e89fb34a892d369a138daa8c3314294493c;p=openldap
diff --git a/libraries/libldap/passwd.c b/libraries/libldap/passwd.c
index 7fbc0cf900..b6caab5831 100644
--- a/libraries/libldap/passwd.c
+++ b/libraries/libldap/passwd.c
@@ -1,7 +1,7 @@
/* $OpenLDAP$ */
/* This work is part of OpenLDAP Software .
*
- * Copyright 1998-2004 The OpenLDAP Foundation.
+ * Copyright 1998-2007 The OpenLDAP Foundation.
* All rights reserved.
*
* Redistribution and use in source and binary forms, with or without
@@ -12,6 +12,10 @@
* top-level directory of the distribution or, alternatively, at
* .
*/
+/* ACKNOWLEDGEMENTS:
+ * This program was orignally developed by Kurt D. Zeilenga for inclusion in
+ * OpenLDAP Software.
+ */
#include "portable.h"
@@ -23,7 +27,7 @@
#include "ldap-int.h"
/*
- * LDAP Password Modify (Extended) Operation
+ * LDAP Password Modify (Extended) Operation (RFC 3062)
*/
int ldap_parse_passwd(
@@ -32,8 +36,7 @@ int ldap_parse_passwd(
struct berval *newpasswd )
{
int rc;
- char *retoid = NULL;
- struct berval *retdata;
+ struct berval *retdata = NULL;
assert( ld != NULL );
assert( LDAP_VALID( ld ) );
@@ -43,31 +46,32 @@ int ldap_parse_passwd(
newpasswd->bv_val = NULL;
newpasswd->bv_len = 0;
- rc = ldap_parse_extended_result( ld, res, &retoid, &retdata, 0 );
-
- if( rc != LDAP_SUCCESS ) {
+ rc = ldap_parse_extended_result( ld, res, NULL, &retdata, 0 );
+ if ( rc != LDAP_SUCCESS ) {
return rc;
}
- if( retdata != NULL ) {
+ if ( retdata != NULL ) {
ber_tag_t tag;
BerElement *ber = ber_init( retdata );
- if( ber == NULL ) {
- ld->ld_errno = LDAP_NO_MEMORY;
- return ld->ld_errno;
+ if ( ber == NULL ) {
+ rc = ld->ld_errno = LDAP_NO_MEMORY;
+ goto done;
}
/* we should check the tag */
tag = ber_scanf( ber, "{o}", newpasswd );
ber_free( ber, 1 );
- if( tag == LBER_ERROR ) {
+ if ( tag == LBER_ERROR ) {
rc = ld->ld_errno = LDAP_DECODING_ERROR;
}
}
- ber_memfree( retoid );
+done:;
+ ber_bvfree( retdata );
+
return rc;
}
@@ -81,7 +85,7 @@ ldap_passwd( LDAP *ld,
int *msgidp )
{
int rc;
- struct berval bv = {0, NULL};
+ struct berval bv = BER_BVNULL;
BerElement *ber = NULL;
assert( ld != NULL );
@@ -152,7 +156,7 @@ ldap_passwd_s(
return rc;
}
- if ( ldap_result( ld, msgid, 1, (struct timeval *) NULL, &res ) == -1 ) {
+ if ( ldap_result( ld, msgid, LDAP_MSG_ALL, (struct timeval *) NULL, &res ) == -1 || !res ) {
return ld->ld_errno;
}