X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Faclparse.c;h=567e2b63f37071d511e0c52fc0900a31a022fef7;hb=fa1f4d3c38b332fc5faf6d84911df2618ce9af09;hp=e9f4a69655ca56908036fb37534500c0fff6ef5a;hpb=b79d4bdce510921f7d07d3d4757aa274b9b67df8;p=openldap diff --git a/servers/slapd/aclparse.c b/servers/slapd/aclparse.c index e9f4a69655..567e2b63f3 100644 --- a/servers/slapd/aclparse.c +++ b/servers/slapd/aclparse.c @@ -2,7 +2,7 @@ /* $OpenLDAP$ */ /* This work is part of OpenLDAP Software . * - * Copyright 1998-2005 The OpenLDAP Foundation. + * Copyright 1998-2006 The OpenLDAP Foundation. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -58,7 +58,7 @@ char *style_strings[] = { static void split(char *line, int splitchar, char **left, char **right); static void access_append(Access **l, Access *a); -static void acl_usage(void) LDAP_GCCATTR((noreturn)); +static int acl_usage(void); static void acl_regex_normalized_dn(const char *src, struct berval *pat); @@ -87,7 +87,7 @@ slap_dynacl_config( Debug( LDAP_DEBUG_ANY, "%s: line %d: dynacl \"%s\" already specified.\n", fname, lineno, name ); - acl_usage(); + return acl_usage(); } } @@ -154,7 +154,8 @@ regtest(const char *fname, int lineno, char *pat) { Debug( LDAP_DEBUG_ANY, "%s: line %d: regular expression \"%s\" too large\n", fname, lineno, pat ); - acl_usage(); + (void)acl_usage(); + exit( EXIT_FAILURE ); } if ((e = regcomp(&re, buf, REG_EXTENDED|REG_ICASE))) { @@ -169,6 +170,7 @@ regtest(const char *fname, int lineno, char *pat) { "%s: line %d: %s\n", fname, lineno, buf ); acl_usage(); + exit( EXIT_FAILURE ); } regfree(&re); } @@ -313,17 +315,17 @@ regex_done:; return ACL_SCOPE_UNKNOWN; } -void +int parse_acl( - Backend *be, - const char *fname, - int lineno, - int argc, - char **argv, + Backend *be, + const char *fname, + int lineno, + int argc, + char **argv, int pos ) { int i; - char *left, *right, *style, *next; + char *left, *right, *style; struct berval bv; AccessControl *a; Access *b; @@ -338,7 +340,7 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: " "only one to clause allowed in access line\n", fname, lineno, 0 ); - acl_usage(); + return acl_usage(); } a = (AccessControl *) ch_calloc( 1, sizeof(AccessControl) ); for ( ++i; i < argc; i++ ) { @@ -355,7 +357,7 @@ parse_acl( "%s: line %d: dn pattern" " already specified in to clause.\n", fname, lineno, 0 ); - acl_usage(); + return acl_usage(); } ber_str2bv( "*", STRLENOF( "*" ), 1, &a->acl_dn_pat ); @@ -369,7 +371,7 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: " "missing \"=\" in \"%s\" in to clause\n", fname, lineno, left ); - acl_usage(); + return acl_usage(); } if ( strcasecmp( left, "dn" ) == 0 ) { @@ -380,7 +382,7 @@ parse_acl( "%s: line %d: dn pattern" " already specified in to clause.\n", fname, lineno, 0 ); - acl_usage(); + return acl_usage(); } if ( style == NULL || *style == '\0' || @@ -438,7 +440,7 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: " "unknown dn style \"%s\" in to clause\n", fname, lineno, style ); - acl_usage(); + return acl_usage(); } continue; @@ -449,7 +451,7 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: bad filter \"%s\" in to clause\n", fname, lineno, right ); - acl_usage(); + return acl_usage(); } } else if ( strcasecmp( left, "attr" ) == 0 /* TOLERATED */ @@ -469,27 +471,28 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: unknown attr \"%s\" in to clause\n", fname, lineno, right ); - acl_usage(); + return acl_usage(); } } else if ( strncasecmp( left, "val", 3 ) == 0 ) { - char *mr; + struct berval bv; + char *mr; if ( !BER_BVISEMPTY( &a->acl_attrval ) ) { Debug( LDAP_DEBUG_ANY, "%s: line %d: attr val already specified in to clause.\n", fname, lineno, 0 ); - acl_usage(); + return acl_usage(); } if ( a->acl_attrs == NULL || !BER_BVISEMPTY( &a->acl_attrs[1].an_name ) ) { Debug( LDAP_DEBUG_ANY, "%s: line %d: attr val requires a single attribute.\n", fname, lineno, 0 ); - acl_usage(); + return acl_usage(); } - ber_str2bv( right, 0, 1, &a->acl_attrval ); + ber_str2bv( right, 0, 0, &bv ); a->acl_attrval_style = ACL_STYLE_BASE; mr = strchr( left, '/' ); @@ -502,7 +505,7 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: " "invalid matching rule \"%s\".\n", fname, lineno, mr ); - acl_usage(); + return acl_usage(); } if( !mr_usable_with_at( a->acl_attrval_mr, a->acl_attrs[ 0 ].an_desc->ad_type ) ) @@ -517,13 +520,13 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: %s\n", fname, lineno, buf ); - acl_usage(); + return acl_usage(); } } if ( style != NULL ) { if ( strcasecmp( style, "regex" ) == 0 ) { - int e = regcomp( &a->acl_attrval_re, a->acl_attrval.bv_val, + int e = regcomp( &a->acl_attrval_re, bv.bv_val, REG_EXTENDED | REG_ICASE | REG_NOSUB ); if ( e ) { char err[SLAP_TEXT_BUFLEN], @@ -537,7 +540,7 @@ parse_acl( Debug( LDAP_DEBUG_ANY, "%s: line %d: %s\n", fname, lineno, buf ); - acl_usage(); + return acl_usage(); } a->acl_attrval_style = ACL_STYLE_REGEX; @@ -551,8 +554,6 @@ parse_acl( } else if ( a->acl_attrs[0].an_desc->ad_type-> sat_syntax == slap_schema.si_syn_distinguishedName ) { - struct berval bv; - if ( !strcasecmp( style, "baseObject" ) || !strcasecmp( style, "base" ) ) { @@ -573,23 +574,18 @@ parse_acl( /* FIXME: should be an error */ snprintf( buf, sizeof( buf ), - "unknown val.