X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fadd.c;h=1dcc082833f118e1e9fa69388e449a0b75700ba3;hb=9767c87531d193a4bef19286b77623aff18590fb;hp=e446eaf2480da8afa9fb190502d12472bf23aa5b;hpb=ef7421b87ddcc9566410f6fa166d104cdb330081;p=openldap diff --git a/servers/slapd/add.c b/servers/slapd/add.c index e446eaf248..1dcc082833 100644 --- a/servers/slapd/add.c +++ b/servers/slapd/add.c @@ -1,7 +1,7 @@ /* $OpenLDAP$ */ /* This work is part of OpenLDAP Software . * - * Copyright 1998-2005 The OpenLDAP Foundation. + * Copyright 1998-2009 The OpenLDAP Foundation. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -30,6 +30,7 @@ #include #include +#include "lutil.h" #include "slap.h" int @@ -46,8 +47,12 @@ do_add( Operation *op, SlapReply *rs ) char textbuf[ SLAP_TEXT_BUFLEN ]; size_t textlen = sizeof( textbuf ); int rc = 0; + int freevals = 1; + OpExtraDB oex; + + Debug( LDAP_DEBUG_TRACE, "%s do_add\n", + op->o_log_prefix, 0, 0 ); - Debug( LDAP_DEBUG_TRACE, "do_add\n", 0, 0, 0 ); /* * Parse the add request. It looks like this: * @@ -62,26 +67,14 @@ do_add( Operation *op, SlapReply *rs ) /* get the name */ if ( ber_scanf( ber, "{m", /*}*/ &dn ) == LBER_ERROR ) { - Debug( LDAP_DEBUG_ANY, "do_add: ber_scanf failed\n", 0, 0, 0 ); + Debug( LDAP_DEBUG_ANY, "%s do_add: ber_scanf failed\n", + op->o_log_prefix, 0, 0 ); send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" ); return SLAPD_DISCONNECT; } - op->ora_e = (Entry *) ch_calloc( 1, sizeof(Entry) ); - - rs->sr_err = dnPrettyNormal( NULL, &dn, &op->o_req_dn, &op->o_req_ndn, - op->o_tmpmemctx ); - - if ( rs->sr_err != LDAP_SUCCESS ) { - Debug( LDAP_DEBUG_ANY, "do_add: invalid dn (%s)\n", dn.bv_val, 0, 0 ); - send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid DN" ); - goto done; - } - - ber_dupbv( &op->ora_e->e_name, &op->o_req_dn ); - ber_dupbv( &op->ora_e->e_nname, &op->o_req_ndn ); - - Debug( LDAP_DEBUG_ARGS, "do_add: dn (%s)\n", op->ora_e->e_dn, 0, 0 ); + Debug( LDAP_DEBUG_ARGS, "%s do_add: dn (%s)\n", + op->o_log_prefix, dn.bv_val, 0 ); /* get the attrs */ for ( tag = ber_first_element( ber, &len, &last ); tag != LBER_DEFAULT; @@ -95,22 +88,22 @@ do_add( Operation *op, SlapReply *rs ) rtag = ber_scanf( ber, "{m{W}}", &tmp.sml_type, &tmp.sml_values ); if ( rtag == LBER_ERROR ) { - Debug( LDAP_DEBUG_ANY, "do_add: decoding error\n", 0, 0, 0 ); + Debug( LDAP_DEBUG_ANY, "%s do_add: decoding error\n", + op->o_log_prefix, 0, 0 ); send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" ); rs->sr_err = SLAPD_DISCONNECT; goto done; } if ( tmp.sml_values == NULL ) { - Debug( LDAP_DEBUG_ANY, "no values for type %s\n", - tmp.sml_type.bv_val, 0, 0 ); + Debug( LDAP_DEBUG_ANY, "%s do_add: no values for type %s\n", + op->o_log_prefix, tmp.sml_type.bv_val, 0 ); send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR, "no values for attribute type" ); goto done; } mod = (Modifications *) ch_malloc( sizeof(Modifications) ); - mod->sml_managing = 0; mod->sml_op = LDAP_MOD_ADD; mod->sml_flags = 0; mod->sml_next = NULL; @@ -124,26 +117,42 @@ do_add( Operation *op, SlapReply *rs ) } if ( ber_scanf( ber, /*{*/ "}") == LBER_ERROR ) { - Debug( LDAP_DEBUG_ANY, "do_add: ber_scanf failed\n", 0, 0, 0 ); + Debug( LDAP_DEBUG_ANY, "%s do_add: ber_scanf failed\n", + op->o_log_prefix, 0, 0 ); send_ldap_discon( op, rs, LDAP_PROTOCOL_ERROR, "decoding error" ); rs->sr_err = SLAPD_DISCONNECT; goto done; } if ( get_ctrls( op, rs, 1 ) != LDAP_SUCCESS ) { - Debug( LDAP_DEBUG_ANY, "do_add: get_ctrls failed\n", 0, 0, 0 ); + Debug( LDAP_DEBUG_ANY, "%s do_add: get_ctrls failed\n", + op->o_log_prefix, 0, 0 ); goto done; } + rs->sr_err = dnPrettyNormal( NULL, &dn, &op->o_req_dn, &op->o_req_ndn, + op->o_tmpmemctx ); + + if ( rs->sr_err != LDAP_SUCCESS ) { + Debug( LDAP_DEBUG_ANY, "%s do_add: invalid dn (%s)\n", + op->o_log_prefix, dn.bv_val, 0 ); + send_ldap_error( op, rs, LDAP_INVALID_DN_SYNTAX, "invalid DN" ); + goto done; + } + + op->ora_e = entry_alloc(); + ber_dupbv( &op->ora_e->e_name, &op->o_req_dn ); + ber_dupbv( &op->ora_e->e_nname, &op->o_req_ndn ); + + Statslog( LDAP_DEBUG_STATS, "%s ADD dn=\"%s\"\n", + op->o_log_prefix, op->o_req_dn.bv_val, 0, 0, 0 ); + if ( modlist == NULL ) { send_ldap_error( op, rs, LDAP_PROTOCOL_ERROR, "no attributes provided" ); goto done; } - Statslog( LDAP_DEBUG_STATS, "%s ADD dn=\"%s\"\n", - op->o_log_prefix, op->ora_e->e_name.bv_val, 0, 0, 0 ); - if ( dn_match( &op->ora_e->e_nname, &slap_empty_bv ) ) { /* protocolError may be a more appropriate error */ send_ldap_error( op, rs, LDAP_ALREADY_EXISTS, @@ -156,7 +165,7 @@ do_add( Operation *op, SlapReply *rs ) goto done; } - rs->sr_err = slap_mods_check( modlist, &rs->sr_text, + rs->sr_err = slap_mods_check( op, modlist, &rs->sr_text, textbuf, textlen, NULL ); if ( rs->sr_err != LDAP_SUCCESS ) { @@ -175,28 +184,39 @@ do_add( Operation *op, SlapReply *rs ) goto done; } + freevals = 0; + + oex.oe.oe_key = (void *)do_add; + oex.oe_db = NULL; + LDAP_SLIST_INSERT_HEAD(&op->o_extra, &oex.oe, oe_next); + op->o_bd = frontendDB; rc = frontendDB->be_add( op, rs ); + LDAP_SLIST_REMOVE(&op->o_extra, &oex.oe, OpExtra, oe_next); + +#ifdef LDAP_X_TXN + if ( rc == LDAP_X_TXN_SPECIFY_OKAY ) { + /* skip cleanup */ + return rc; + } else +#endif if ( rc == 0 ) { - if ( op->ora_e != NULL && op->o_private != NULL ) { + if ( op->ora_e != NULL && oex.oe_db != NULL ) { BackendDB *bd = op->o_bd; - op->o_bd = (BackendDB *)op->o_private; - op->o_private = NULL; + op->o_bd = oex.oe_db; be_entry_release_w( op, op->ora_e ); op->ora_e = NULL; op->o_bd = bd; - op->o_private = NULL; } } done:; - slap_graduate_commit_csn( op ); - if ( modlist != NULL ) { - slap_mods_free( modlist, 0 ); + /* in case of error, free the values as well */ + slap_mods_free( modlist, freevals ); } if ( op->ora_e != NULL ) { @@ -211,40 +231,33 @@ done:; int fe_op_add( Operation *op, SlapReply *rs ) { - int manageDSAit; - Modifications *modlist = op->ora_modlist; - Modifications **modtail = &modlist; + Modifications **modtail = &op->ora_modlist; int rc = 0; - BackendDB *op_be; + BackendDB *op_be, *bd = op->o_bd; char textbuf[ SLAP_TEXT_BUFLEN ]; size_t textlen = sizeof( textbuf ); - manageDSAit = get_manageDSAit( op ); - /* * We could be serving multiple database backends. Select the * appropriate one, or send a referral to our "referral server" * if we don't hold it. */ - op->o_bd = select_backend( &op->ora_e->e_nname, manageDSAit, 1 ); + op->o_bd = select_backend( &op->ora_e->e_nname, 1 ); if ( op->o_bd == NULL ) { + op->o_bd = bd; rs->sr_ref = referral_rewrite( default_referral, NULL, &op->ora_e->e_name, LDAP_SCOPE_DEFAULT ); if ( !rs->sr_ref ) rs->sr_ref = default_referral; if ( rs->sr_ref ) { rs->sr_err = LDAP_REFERRAL; - op->o_bd = frontendDB; send_ldap_result( op, rs ); - op->o_bd = NULL; if ( rs->sr_ref != default_referral ) { ber_bvarray_free( rs->sr_ref ); } } else { - op->o_bd = frontendDB; send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM, "no global superior knowledge" ); - op->o_bd = NULL; } goto done; } @@ -252,7 +265,7 @@ fe_op_add( Operation *op, SlapReply *rs ) /* If we've got a glued backend, check the real backend */ op_be = op->o_bd; if ( SLAP_GLUE_INSTANCE( op->o_bd )) { - op->o_bd = select_backend( &op->ora_e->e_nname, manageDSAit, 0 ); + op->o_bd = select_backend( &op->ora_e->e_nname, 0 ); } /* check restrictions */ @@ -266,7 +279,7 @@ fe_op_add( Operation *op, SlapReply *rs ) goto done; } - rs->sr_err = slap_mods_obsolete_check( op, modlist, + rs->sr_err = slap_mods_obsolete_check( op, op->ora_modlist, &rs->sr_text, textbuf, textlen ); if ( rs->sr_err != LDAP_SUCCESS ) { @@ -283,17 +296,13 @@ fe_op_add( Operation *op, SlapReply *rs ) if ( op->o_bd->be_add ) { /* do the update here */ int repl_user = be_isupdate( op ); -#ifndef SLAPD_MULTIMASTER - if ( !SLAP_SHADOW(op->o_bd) || repl_user ) -#endif - { + if ( !SLAP_SINGLE_SHADOW(op->o_bd) || repl_user ) { int update = !BER_BVISEMPTY( &op->o_bd->be_update_ndn ); - slap_callback cb = { NULL, slap_replog_cb, NULL, NULL }; op->o_bd = op_be; if ( !update ) { - rs->sr_err = slap_mods_no_user_mod_check( op, modlist, + rs->sr_err = slap_mods_no_user_mod_check( op, op->ora_modlist, &rs->sr_text, textbuf, textlen ); if ( rs->sr_err != LDAP_SUCCESS ) { @@ -304,7 +313,7 @@ fe_op_add( Operation *op, SlapReply *rs ) if ( !repl_user ) { /* go to the last mod */ - for ( modtail = &modlist; + for ( modtail = &op->ora_modlist; *modtail != NULL; modtail = &(*modtail)->sml_next ) { @@ -313,47 +322,30 @@ fe_op_add( Operation *op, SlapReply *rs ) } - rs->sr_err = slap_mods_opattrs( op, modlist, - modtail, &rs->sr_text, - textbuf, textlen, 1 ); - if ( rs->sr_err != LDAP_SUCCESS ) { - send_ldap_result( op, rs ); - goto done; - } - - /* check for duplicate values */ + /* check for unmodifiable attributes */ rs->sr_err = slap_mods_no_repl_user_mod_check( op, - modlist, &rs->sr_text, textbuf, textlen ); - if ( rs->sr_err != LDAP_SUCCESS ) { - send_ldap_result( op, rs ); - goto done; - } - - rs->sr_err = slap_mods2entry( *modtail, &op->ora_e, - 0, 0, &rs->sr_text, textbuf, textlen ); + op->ora_modlist, &rs->sr_text, textbuf, textlen ); if ( rs->sr_err != LDAP_SUCCESS ) { send_ldap_result( op, rs ); goto done; } } -#ifdef SLAPD_MULTIMASTER - if ( !repl_user ) -#endif - { - cb.sc_next = op->o_callback; - op->o_callback = &cb; - } rc = op->o_bd->be_add( op, rs ); if ( rc == LDAP_SUCCESS ) { + OpExtra *oex; /* NOTE: be_entry_release_w() is * called by do_add(), so that global * overlays on the way back can * at least read the entry */ - op->o_private = op->o_bd; + LDAP_SLIST_FOREACH(oex, &op->o_extra, oe_next) { + if ( oex->oe_key == (void *)do_add ) { + ((OpExtraDB *)oex)->oe_db = op->o_bd; + break; + } + } } -#ifndef SLAPD_MULTIMASTER } else { BerVarray defref = NULL; @@ -376,15 +368,15 @@ fe_op_add( Operation *op, SlapReply *rs ) LDAP_UNWILLING_TO_PERFORM, "shadow context; no update referral" ); } -#endif /* SLAPD_MULTIMASTER */ } } else { - Debug( LDAP_DEBUG_ARGS, " do_add: no backend support\n", 0, 0, 0 ); - send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM, + Debug( LDAP_DEBUG_ARGS, "do_add: no backend support\n", 0, 0, 0 ); + send_ldap_error( op, rs, LDAP_UNWILLING_TO_PERFORM, "operation not supported within namingContext" ); } done:; + op->o_bd = bd; return rc; } @@ -398,6 +390,7 @@ slap_mods2entry( char *textbuf, size_t textlen ) { Attribute **tail; + int i; if ( initial ) { assert( (*e)->e_attrs == NULL ); @@ -418,7 +411,7 @@ slap_mods2entry( if( attr != NULL ) { #define SLURPD_FRIENDLY #ifdef SLURPD_FRIENDLY - ber_len_t i,j; + int j; if ( !initial ) { /* @@ -431,18 +424,15 @@ slap_mods2entry( return LDAP_SUCCESS; } - for( i=0; attr->a_vals[i].bv_val; i++ ) { - /* count them */ - } - for( j=0; mods->sml_values[j].bv_val; j++ ) { - /* count them */ - } + i = attr->a_numvals; + j = mods->sml_numvals; + attr->a_numvals += j; j++; /* NULL */ attr->a_vals = ch_realloc( attr->a_vals, sizeof( struct berval ) * (i+j) ); - /* should check for duplicates */ + /* checked for duplicates in slap_mods_check */ if ( dup ) { for ( j = 0; mods->sml_values[j].bv_val; j++ ) { @@ -476,55 +466,17 @@ slap_mods2entry( snprintf( textbuf, textlen, "attribute '%s' provided more than once", mods->sml_desc->ad_cname.bv_val ); + *text = textbuf; return LDAP_TYPE_OR_VALUE_EXISTS; #endif } - if( mods->sml_values[1].bv_val != NULL ) { - /* check for duplicates */ - int i, j, rc, match; - MatchingRule *mr = mods->sml_desc->ad_type->sat_equality; - - for ( i = 1; mods->sml_values[i].bv_val != NULL; i++ ) { - /* test asserted values against themselves */ - for( j = 0; j < i; j++ ) { - rc = ordered_value_match( &match, mods->sml_desc, mr, - SLAP_MR_EQUALITY - | SLAP_MR_VALUE_OF_ATTRIBUTE_SYNTAX - | SLAP_MR_ASSERTED_VALUE_NORMALIZED_MATCH - | SLAP_MR_ATTRIBUTE_VALUE_NORMALIZED_MATCH, - mods->sml_nvalues - ? &mods->sml_nvalues[i] - : &mods->sml_values[i], - mods->sml_nvalues - ? &mods->sml_nvalues[j] - : &mods->sml_values[j], - text ); - - if ( rc == LDAP_SUCCESS && match == 0 ) { - /* value exists already */ - snprintf( textbuf, textlen, - "%s: value #%d provided more than once", - mods->sml_desc->ad_cname.bv_val, j ); - return LDAP_TYPE_OR_VALUE_EXISTS; - - } else if ( rc != LDAP_SUCCESS ) { - return rc; - } - } - } - } - - attr = ch_calloc( 1, sizeof(Attribute) ); - - /* move ad to attr structure */ - attr->a_desc = mods->sml_desc; + attr = attr_alloc( mods->sml_desc ); /* move values to attr structure */ - /* should check for duplicates */ + i = mods->sml_numvals; + attr->a_numvals = mods->sml_numvals; if ( dup ) { - int i; - for ( i = 0; mods->sml_values[i].bv_val; i++ ) /* EMPTY */; attr->a_vals = (BerVarray) ch_calloc( i+1, sizeof( BerValue )); for ( i = 0; mods->sml_values[i].bv_val; i++ ) { ber_dupbv( &attr->a_vals[i], &mods->sml_values[i] ); @@ -536,8 +488,7 @@ slap_mods2entry( if ( mods->sml_nvalues ) { if ( dup ) { - int i; - for ( i = 0; mods->sml_nvalues[i].bv_val; i++ ) /* EMPTY */; + i = mods->sml_numvals; attr->a_nvals = (BerVarray) ch_calloc( i+1, sizeof( BerValue )); for ( i = 0; mods->sml_nvalues[i].bv_val; i++ ) { ber_dupbv( &attr->a_nvals[i], &mods->sml_nvalues[i] ); @@ -549,6 +500,9 @@ slap_mods2entry( } else { attr->a_nvals = attr->a_vals; } + /* slap_mods_check() gives us sorted results */ + if ( attr->a_desc->ad_type->sat_flags & SLAP_AT_SORTED_VAL ) + attr->a_flags |= SLAP_ATTR_SORTED_VALS; *tail = attr; tail = &attr->a_next; @@ -577,17 +531,17 @@ slap_entry2mods( while ( a_new != NULL ) { a_new_desc = a_new->a_desc; - mod = (Modifications *) malloc( sizeof( Modifications )); - mod->sml_managing = 0; + mod = (Modifications *) ch_malloc( sizeof( Modifications )); mod->sml_op = LDAP_MOD_REPLACE; mod->sml_flags = 0; mod->sml_type = a_new_desc->ad_cname; - for ( count = 0; a_new->a_vals[count].bv_val; count++ ) /* EMPTY */; + count = a_new->a_numvals; + mod->sml_numvals = a_new->a_numvals; - mod->sml_values = (struct berval*) malloc( + mod->sml_values = (struct berval*) ch_malloc( (count+1) * sizeof( struct berval) ); /* see slap_mods_check() comments... @@ -595,7 +549,7 @@ slap_entry2mods( * in this case, mod->sml_nvalues must be left NULL. */ if ( a_new->a_vals != a_new->a_nvals ) { - mod->sml_nvalues = (struct berval*) malloc( + mod->sml_nvalues = (struct berval*) ch_malloc( (count+1) * sizeof( struct berval) ); } else { mod->sml_nvalues = NULL; @@ -628,3 +582,108 @@ slap_entry2mods( return LDAP_SUCCESS; } +int slap_add_opattrs( + Operation *op, + const char **text, + char *textbuf, + size_t textlen, + int manage_ctxcsn ) +{ + struct berval name, timestamp, csn = BER_BVNULL; + struct berval nname, tmp; + char timebuf[ LDAP_LUTIL_GENTIME_BUFSIZE ]; + char csnbuf[ LDAP_LUTIL_CSNSTR_BUFSIZE ]; + Attribute *a; + + if ( SLAP_LASTMOD( op->o_bd ) ) { + char *ptr; + int gotcsn = 0; + + timestamp.bv_val = timebuf; + a = attr_find( op->ora_e->e_attrs, slap_schema.si_ad_entryCSN ); + if ( a ) { + gotcsn = 1; + csn = a->a_vals[0]; + } + if ( BER_BVISEMPTY( &op->o_csn )) { + if ( !gotcsn ) { + csn.bv_val = csnbuf; + csn.bv_len = sizeof(csnbuf); + slap_get_csn( op, &csn, manage_ctxcsn ); + } else { + if ( manage_ctxcsn ) + slap_queue_csn( op, &csn ); + } + } else { + csn = op->o_csn; + } + ptr = ber_bvchr( &csn, '#' ); + if ( ptr ) { + timestamp.bv_len = STRLENOF("YYYYMMDDHHMMSSZ"); + AC_MEMCPY( timebuf, csn.bv_val, timestamp.bv_len ); + timebuf[timestamp.bv_len-1] = 'Z'; + timebuf[timestamp.bv_len] = '\0'; + } else { + time_t now = slap_get_time(); + + timestamp.bv_len = sizeof(timebuf); + + slap_timestamp( &now, ×tamp ); + } + + if ( BER_BVISEMPTY( &op->o_dn ) ) { + BER_BVSTR( &name, SLAPD_ANONYMOUS ); + nname = name; + } else { + name = op->o_dn; + nname = op->o_ndn; + } + + a = attr_find( op->ora_e->e_attrs, + slap_schema.si_ad_entryUUID ); + if ( !a ) { + char uuidbuf[ LDAP_LUTIL_UUIDSTR_BUFSIZE ]; + + tmp.bv_len = lutil_uuidstr( uuidbuf, sizeof( uuidbuf ) ); + tmp.bv_val = uuidbuf; + + attr_merge_normalize_one( op->ora_e, + slap_schema.si_ad_entryUUID, &tmp, op->o_tmpmemctx ); + } + + a = attr_find( op->ora_e->e_attrs, + slap_schema.si_ad_creatorsName ); + if ( !a ) { + attr_merge_one( op->ora_e, + slap_schema.si_ad_creatorsName, &name, &nname ); + } + + a = attr_find( op->ora_e->e_attrs, + slap_schema.si_ad_createTimestamp ); + if ( !a ) { + attr_merge_one( op->ora_e, + slap_schema.si_ad_createTimestamp, ×tamp, NULL ); + } + + if ( !gotcsn ) { + attr_merge_one( op->ora_e, + slap_schema.si_ad_entryCSN, &csn, NULL ); + } + + a = attr_find( op->ora_e->e_attrs, + slap_schema.si_ad_modifiersName ); + if ( !a ) { + attr_merge_one( op->ora_e, + slap_schema.si_ad_modifiersName, &name, &nname ); + } + + a = attr_find( op->ora_e->e_attrs, + slap_schema.si_ad_modifyTimestamp ); + if ( !a ) { + attr_merge_one( op->ora_e, + slap_schema.si_ad_modifyTimestamp, ×tamp, NULL ); + } + } + + return LDAP_SUCCESS; +}