X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fadd.c;h=f3a9a02da6ca7ba3344bdb8494dcedbeb879c339;hb=1878d201c1e0a7f42b0d5ee66d7f5a2368027c9c;hp=9c6ca2e6eedd06e66cc47378a482eeab49e54188;hpb=e8c2414831e73d4b09eaf340f3052c572edaf9a1;p=openldap diff --git a/servers/slapd/add.c b/servers/slapd/add.c index 9c6ca2e6ee..f3a9a02da6 100644 --- a/servers/slapd/add.c +++ b/servers/slapd/add.c @@ -1,7 +1,7 @@ /* $OpenLDAP$ */ /* This work is part of OpenLDAP Software . * - * Copyright 1998-2007 The OpenLDAP Foundation. + * Copyright 1998-2012 The OpenLDAP Foundation. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -48,6 +48,7 @@ do_add( Operation *op, SlapReply *rs ) size_t textlen = sizeof( textbuf ); int rc = 0; int freevals = 1; + OpExtraDB oex; Debug( LDAP_DEBUG_TRACE, "%s do_add\n", op->o_log_prefix, 0, 0 ); @@ -185,8 +186,13 @@ do_add( Operation *op, SlapReply *rs ) freevals = 0; + oex.oe.oe_key = (void *)do_add; + oex.oe_db = NULL; + LDAP_SLIST_INSERT_HEAD(&op->o_extra, &oex.oe, oe_next); + op->o_bd = frontendDB; rc = frontendDB->be_add( op, rs ); + LDAP_SLIST_REMOVE(&op->o_extra, &oex.oe, OpExtra, oe_next); #ifdef LDAP_X_TXN if ( rc == LDAP_X_TXN_SPECIFY_OKAY ) { @@ -195,17 +201,15 @@ do_add( Operation *op, SlapReply *rs ) } else #endif if ( rc == 0 ) { - if ( op->ora_e != NULL && op->o_private != NULL ) { + if ( op->ora_e != NULL && oex.oe_db != NULL ) { BackendDB *bd = op->o_bd; - op->o_bd = (BackendDB *)op->o_private; - op->o_private = NULL; + op->o_bd = oex.oe_db; be_entry_release_w( op, op->ora_e ); op->ora_e = NULL; op->o_bd = bd; - op->o_private = NULL; } } @@ -329,11 +333,17 @@ fe_op_add( Operation *op, SlapReply *rs ) rc = op->o_bd->be_add( op, rs ); if ( rc == LDAP_SUCCESS ) { + OpExtra *oex; /* NOTE: be_entry_release_w() is * called by do_add(), so that global * overlays on the way back can * at least read the entry */ - op->o_private = op->o_bd; + LDAP_SLIST_FOREACH(oex, &op->o_extra, oe_next) { + if ( oex->oe_key == (void *)do_add ) { + ((OpExtraDB *)oex)->oe_db = op->o_bd; + break; + } + } } } else { @@ -490,9 +500,6 @@ slap_mods2entry( } else { attr->a_nvals = attr->a_vals; } - /* slap_mods_check() gives us sorted results */ - if ( attr->a_desc->ad_type->sat_flags & SLAP_AT_SORTED_VAL ) - attr->a_flags |= SLAP_ATTR_SORTED_VALS; *tail = attr; tail = &attr->a_next; @@ -521,7 +528,7 @@ slap_entry2mods( while ( a_new != NULL ) { a_new_desc = a_new->a_desc; - mod = (Modifications *) malloc( sizeof( Modifications )); + mod = (Modifications *) ch_malloc( sizeof( Modifications )); mod->sml_op = LDAP_MOD_REPLACE; mod->sml_flags = 0; @@ -531,7 +538,7 @@ slap_entry2mods( count = a_new->a_numvals; mod->sml_numvals = a_new->a_numvals; - mod->sml_values = (struct berval*) malloc( + mod->sml_values = (struct berval*) ch_malloc( (count+1) * sizeof( struct berval) ); /* see slap_mods_check() comments... @@ -539,7 +546,7 @@ slap_entry2mods( * in this case, mod->sml_nvalues must be left NULL. */ if ( a_new->a_vals != a_new->a_nvals ) { - mod->sml_nvalues = (struct berval*) malloc( + mod->sml_nvalues = (struct berval*) ch_malloc( (count+1) * sizeof( struct berval) ); } else { mod->sml_nvalues = NULL; @@ -582,7 +589,7 @@ int slap_add_opattrs( struct berval name, timestamp, csn = BER_BVNULL; struct berval nname, tmp; char timebuf[ LDAP_LUTIL_GENTIME_BUFSIZE ]; - char csnbuf[ LDAP_LUTIL_CSNSTR_BUFSIZE ]; + char csnbuf[ LDAP_PVT_CSNSTR_BUFSIZE ]; Attribute *a; if ( SLAP_LASTMOD( op->o_bd ) ) {