X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fava.c;h=da6a2e3355ae37a296b8e9b24387ad04d394e690;hb=0f30fb0d8f0adbbb7b41fd455c57aa56d64c9853;hp=ad151d5a0d49fe4404af881115eda234db90fbab;hpb=60802201e3a39b0a46bfa7156c608026f7d361ba;p=openldap

diff --git a/servers/slapd/ava.c b/servers/slapd/ava.c
index ad151d5a0d..da6a2e3355 100644
--- a/servers/slapd/ava.c
+++ b/servers/slapd/ava.c
@@ -14,7 +14,6 @@
 
 #include "slap.h"
 
-#ifdef SLAPD_SCHEMA_NOT_COMPAT
 
 void
 ava_free(
@@ -22,7 +21,6 @@ ava_free(
     int	freeit
 )
 {
-	ad_free( ava->aa_desc, 1 );
 	ber_bvfree( ava->aa_value );
 	if ( freeit ) {
 		ch_free( (char *) ava );
@@ -44,18 +42,24 @@ get_ava(
 	rc = ber_scanf( ber, "{oo}", &type, &value );
 
 	if( rc == LBER_ERROR ) {
+#ifdef NEW_LOGGING
+		LDAP_LOG(( "filter", LDAP_LEVEL_ERR,
+			   "get_ava:  ber_scanf failure\n" ));
+#else
 		Debug( LDAP_DEBUG_ANY, "  get_ava ber_scanf\n", 0, 0, 0 );
+#endif
 		*text = "Error decoding attribute value assertion";
 		return SLAPD_DISCONNECT;
 	}
 
 	aa = ch_malloc( sizeof( AttributeAssertion ) );
 	aa->aa_desc = NULL;
+	aa->aa_value = NULL;
 
 	rc = slap_bv2ad( &type, &aa->aa_desc, text );
+	ch_free( type.bv_val );
 
 	if( rc != LDAP_SUCCESS ) {
-		ch_free( type.bv_val );
 		ch_free( value.bv_val );
 		ch_free( aa );
 		return rc;
@@ -65,8 +69,6 @@ get_ava(
 	ch_free( value.bv_val );
 
 	if( rc != LDAP_SUCCESS ) {
-		ch_free( type.bv_val );
-		ad_free( aa->aa_desc, 1 );
 		ch_free( aa );
 		return rc;
 	}
@@ -77,39 +79,3 @@ get_ava(
 	return LDAP_SUCCESS;
 }
 
-#else
-
-void
-ava_free(
-    Ava	*ava,
-    int	freeit
-)
-{
-	ch_free( (char *) ava->ava_type );
-	ch_free( (char *) ava->ava_value.bv_val );
-	if ( freeit ) {
-		ch_free( (char *) ava );
-	}
-}
-
-int
-get_ava(
-    BerElement	*ber,
-    Ava		*ava,
-	const char **text
-)
-{
-	if ( ber_scanf( ber, "{ao}", &ava->ava_type, &ava->ava_value )
-	    == LBER_ERROR ) {
-		Debug( LDAP_DEBUG_ANY, "  get_ava ber_scanf\n", 0, 0, 0 );
-		*text = "Error decoding attribute value assertion";
-		return SLAPD_DISCONNECT;
-	}
-
-	attr_normalize( ava->ava_type );
-	value_normalize( ava->ava_value.bv_val, attr_syntax( ava->ava_type ) );
-
-	return LDAP_SUCCESS;
-}
-
-#endif