X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fback-bdb%2Ftools.c;h=bcec7c7c5525b977906c0e4d46cf236f366ee8ae;hb=a61d2b914dafe2326a0336c87c530b93333e5eef;hp=2e102ae0aed42b264387793f75197832ae1a4902;hpb=ef31250591144910405471748e66ec2118100151;p=openldap

diff --git a/servers/slapd/back-bdb/tools.c b/servers/slapd/back-bdb/tools.c
index 2e102ae0ae..bcec7c7c55 100644
--- a/servers/slapd/back-bdb/tools.c
+++ b/servers/slapd/back-bdb/tools.c
@@ -1,7 +1,7 @@
 /* tools.c - tools for slap tools */
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
@@ -112,7 +112,8 @@ Entry* bdb_tool_entry_get( BackendDB *be, ID id )
 
 ID bdb_tool_entry_put(
 	BackendDB *be,
-	Entry *e )
+	Entry *e,
+	struct berval *text )
 {
 	int rc;
 	struct bdb_info *bdb = (struct bdb_info *) be->be_private;
@@ -122,77 +123,94 @@ ID bdb_tool_entry_put(
 	assert( be != NULL );
 	assert( slapMode & SLAP_TOOL_MODE );
 
+	assert( text );
+	assert( text->bv_val );
+	assert( text->bv_val[0] == '\0' );
+
 	Debug( LDAP_DEBUG_TRACE, "=> bdb_tool_entry_put( %ld, \"%s\" )\n",
 		(long) e->e_id, e->e_dn, 0 );
 
-	if( bdb->bi_txn ) {
-		rc = txn_begin( bdb->bi_dbenv, NULL, &tid, 
-			bdb->bi_db_opflags );
-		if( rc != 0 ) {
-			Debug( LDAP_DEBUG_ANY,
-				"=> bdb_tool_entry_put: txn_begin failed: %s (%d)\n",
-				db_strerror(rc), rc, 0 );
-			return NOID;
-		}
+	rc = TXN_BEGIN( bdb->bi_dbenv, NULL, &tid, 
+		bdb->bi_db_opflags );
+	if( rc != 0 ) {
+		snprintf( text->bv_val, text->bv_len,
+			"txn_begin failed: %s (%d)",
+			db_strerror(rc), rc );
+		Debug( LDAP_DEBUG_ANY,
+			"=> bdb_tool_entry_put: %s\n",
+			 text->bv_val, 0, 0 );
+		return NOID;
 	}
 
 	rc = bdb_next_id( be, tid, &e->e_id );
 	if( rc != 0 ) {
+		snprintf( text->bv_val, text->bv_len,
+				"next_id failed: %s (%d)",
+				db_strerror(rc), rc );
 		Debug( LDAP_DEBUG_ANY,
-			"=> bdb_tool_entry_put: next_id failed: %s (%d)\n",
-			db_strerror(rc), rc, 0 );
+			"=> bdb_tool_entry_put: %s\n", text->bv_val, 0, 0 );
 		goto done;
 	}
 
 	/* add dn2id indices */
-	pdn.bv_val = dn_parent( be, e->e_ndn );
-	if (pdn.bv_val)
-		pdn.bv_len = e->e_nname.bv_len - (pdn.bv_val - e->e_ndn);
-	else
-		pdn.bv_len = 0;
+	if ( be_issuffix( be, &e->e_nname ) ) {
+		pdn = slap_empty_bv;
+	} else {
+		dnParent( &e->e_nname, &pdn );
+	}
 	rc = bdb_dn2id_add( be, tid, &pdn, e );
 	if( rc != 0 ) {
+		snprintf( text->bv_val, text->bv_len, 
+				"dn2id_add failed: %s (%d)",
+				db_strerror(rc), rc );
 		Debug( LDAP_DEBUG_ANY,
-			"=> bdb_tool_entry_put: dn2id_add failed: %s (%d)\n",
-			db_strerror(rc), rc, 0 );
+			"=> bdb_tool_entry_put: %s\n", text->bv_val, 0, 0 );
 		goto done;
 	}
 
 	/* id2entry index */
 	rc = bdb_id2entry_add( be, tid, e );
 	if( rc != 0 ) {
+		snprintf( text->bv_val, text->bv_len,
+				"id2entry_add failed: %s (%d)",
+				db_strerror(rc), rc );
 		Debug( LDAP_DEBUG_ANY,
-			"=> bdb_tool_entry_put: id2entry_add failed: %s (%d)\n",
-			db_strerror(rc), rc, 0 );
+			"=> bdb_tool_entry_put: %s\n", text->bv_val, 0, 0 );
 		goto done;
 	}
 
 	rc = bdb_index_entry_add( be, tid, e, e->e_attrs );
 	if( rc != 0 ) {
+		snprintf( text->bv_val, text->bv_len,
+				"index_entry_add failed: %s (%d)",
+				db_strerror(rc), rc );
 		Debug( LDAP_DEBUG_ANY,
-			"=> bdb_tool_entry_put: index_entry_add failed: %s (%d)\n",
-			db_strerror(rc), rc, 0 );
+			"=> bdb_tool_entry_put: %s\n", text->bv_val, 0, 0 );
 		goto done;
 	}
 
 done:
-	if( bdb->bi_txn ) {
-		if( rc == 0 ) {
-			rc = txn_commit( tid, 0 );
-			if( rc != 0 ) {
-				Debug( LDAP_DEBUG_ANY,
-					"=> bdb_tool_entry_put: txn_commit failed: %s (%d)\n",
-					db_strerror(rc), rc, 0 );
-				e->e_id = NOID;
-			}
-
-		} else {
-			txn_abort( tid );
+	if( rc == 0 ) {
+		rc = TXN_COMMIT( tid, 0 );
+		if( rc != 0 ) {
+			snprintf( text->bv_val, text->bv_len,
+					"txn_commit failed: %s (%d)",
+					db_strerror(rc), rc );
 			Debug( LDAP_DEBUG_ANY,
-				"=> bdb_tool_entry_put: txn_aborted! %s (%d)\n",
-				db_strerror(rc), rc, 0 );
+				"=> bdb_tool_entry_put: %s\n",
+				text->bv_val, 0, 0 );
 			e->e_id = NOID;
 		}
+
+	} else {
+		TXN_ABORT( tid );
+		snprintf( text->bv_val, text->bv_len,
+			"txn_aborted! %s (%d)",
+			db_strerror(rc), rc );
+		Debug( LDAP_DEBUG_ANY,
+			"=> bdb_tool_entry_put: %s\n",
+			text->bv_val, 0, 0 );
+		e->e_id = NOID;
 	}
 
 	return e->e_id;
@@ -220,14 +238,12 @@ int bdb_tool_entry_reindex(
 		return -1;
 	}
 
-	if( bi->bi_txn ) {
-		rc = txn_begin( bi->bi_dbenv, NULL, &tid, bi->bi_db_opflags );
-		if( rc != 0 ) {
-			Debug( LDAP_DEBUG_ANY,
-				"=> bdb_tool_entry_reindex: txn_begin failed: %s (%d)\n",
-				db_strerror(rc), rc, 0 );
-			goto done;
-		}
+	rc = TXN_BEGIN( bi->bi_dbenv, NULL, &tid, bi->bi_db_opflags );
+	if( rc != 0 ) {
+		Debug( LDAP_DEBUG_ANY,
+			"=> bdb_tool_entry_reindex: txn_begin failed: %s (%d)\n",
+			db_strerror(rc), rc, 0 );
+		goto done;
 	}
  	
 	/*
@@ -241,11 +257,11 @@ int bdb_tool_entry_reindex(
 		(long) id, e->e_dn, 0 );
 
 	/* add dn2id indices */
-	pdn.bv_val = dn_parent( be, e->e_ndn );
-	if (pdn.bv_val)
-		pdn.bv_len = e->e_nname.bv_len - (pdn.bv_val - e->e_ndn);
-	else
-		pdn.bv_len = 0;
+	if ( be_issuffix( be, &e->e_nname ) ) {
+		pdn = slap_empty_bv;
+	} else {
+		dnParent( &e->e_nname, &pdn );
+	}
 	rc = bdb_dn2id_add( be, tid, &pdn, e );
 	if( rc != 0 && rc != DB_KEYEXIST ) {
 		Debug( LDAP_DEBUG_ANY,
@@ -257,23 +273,21 @@ int bdb_tool_entry_reindex(
 	rc = bdb_index_entry_add( be, tid, e, e->e_attrs );
 
 done:
-	if( bi->bi_txn ) {
-		if( rc == 0 ) {
-			rc = txn_commit( tid, 0 );
-			if( rc != 0 ) {
-				Debug( LDAP_DEBUG_ANY,
-					"=> bdb_tool_entry_reindex: txn_commit failed: %s (%d)\n",
-					db_strerror(rc), rc, 0 );
-				e->e_id = NOID;
-			}
-
-		} else {
-			txn_abort( tid );
+	if( rc == 0 ) {
+		rc = TXN_COMMIT( tid, 0 );
+		if( rc != 0 ) {
 			Debug( LDAP_DEBUG_ANY,
-				"=> bdb_tool_entry_reindex: txn_aborted! %s (%d)\n",
+				"=> bdb_tool_entry_reindex: txn_commit failed: %s (%d)\n",
 				db_strerror(rc), rc, 0 );
 			e->e_id = NOID;
 		}
+
+	} else {
+		TXN_ABORT( tid );
+		Debug( LDAP_DEBUG_ANY,
+			"=> bdb_tool_entry_reindex: txn_aborted! %s (%d)\n",
+			db_strerror(rc), rc, 0 );
+		e->e_id = NOID;
 	}
 
 	return rc;