X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fbackover.c;h=8260f29a6d863e9fd1eecd9bb3115824d8decf95;hb=e281e08e79829175aa9545dc2e3eb85e4e873717;hp=f63ac792a96ad6b0e2eeb4cccc92aa084a5864f3;hpb=171e934bf03d66db26e40a645538930ea9476039;p=openldap diff --git a/servers/slapd/backover.c b/servers/slapd/backover.c index f63ac792a9..8260f29a6d 100644 --- a/servers/slapd/backover.c +++ b/servers/slapd/backover.c @@ -2,7 +2,7 @@ /* $OpenLDAP$ */ /* This work is part of OpenLDAP Software . * - * Copyright 2003 The OpenLDAP Foundation. + * Copyright 2003-2005 The OpenLDAP Foundation. * All rights reserved. * * Redistribution and use in source and binary forms, with or without @@ -25,10 +25,16 @@ #define SLAPD_TOOLS #include "slap.h" +#include "config.h" static slap_overinst *overlays; -enum db_which { db_open = 0, db_close, db_destroy }; +enum db_which { + db_open = 0, + db_close, + db_destroy, + db_last +}; static int over_db_func( @@ -36,27 +42,26 @@ over_db_func( enum db_which which ) { - slap_overinfo *oi = (slap_overinfo *) be->bd_info; + slap_overinfo *oi = be->bd_info->bi_private; slap_overinst *on = oi->oi_list; - BackendDB bd; + BackendInfo *bi_orig = be->bd_info; BI_db_open **func; int rc = 0; - func = &oi->oi_bd.bd_info->bi_db_open; + func = &oi->oi_orig->bi_db_open; if ( func[which] ) { - rc = func[which]( &oi->oi_bd ); - if ( rc ) return rc; + be->bd_info = oi->oi_orig; + rc = func[which]( be ); } - bd = *be; - for (; on; on=on->on_next) { - bd.bd_info = &on->on_bi; + for (; on && rc == 0; on=on->on_next) { + be->bd_info = &on->on_bi; func = &on->on_bi.bi_db_open; if (func[which]) { - rc = func[which]( &bd ); - if ( rc ) break; + rc = func[which]( be ); } } + be->bd_info = bi_orig; return rc; } @@ -69,26 +74,89 @@ over_db_config( char **argv ) { - slap_overinfo *oi = (slap_overinfo *) be->bd_info; + slap_overinfo *oi = be->bd_info->bi_private; slap_overinst *on = oi->oi_list; - BackendDB bd; + BackendInfo *bi_orig = be->bd_info; + struct ConfigOCs *be_cf_ocs = be->be_cf_ocs; + ConfigArgs ca = {0}; int rc = 0; - if ( oi->oi_bd.bd_info->bi_db_config ) { - rc = oi->oi_bd.bd_info->bi_db_config( &oi->oi_bd, fname, lineno, + if ( oi->oi_orig->bi_db_config ) { + be->bd_info = oi->oi_orig; + be->be_cf_ocs = oi->oi_orig->bi_cf_ocs; + rc = oi->oi_orig->bi_db_config( be, fname, lineno, argc, argv ); + + if ( be->bd_info != oi->oi_orig ) { + slap_overinfo *oi2; + slap_overinst *on2, **onp; + BackendDB be2 = *be; + int i; + + /* a database added an overlay; + * work it around... */ + assert( overlay_is_over( be ) ); + + oi2 = ( slap_overinfo * )be->bd_info->bi_private; + on2 = oi2->oi_list; + + /* need to put a uniqueness check here as well; + * note that in principle there could be more than + * one overlay as a result of multiple calls to + * overlay_config() */ + be2.bd_info = (BackendInfo *)oi; + + for ( i = 0, onp = &on2; *onp; i++, onp = &(*onp)->on_next ) { + if ( overlay_is_inst( &be2, (*onp)->on_bi.bi_type ) ) { + Debug( LDAP_DEBUG_ANY, "over_db_config(): " + "warning, freshly added " + "overlay #%d \"%s\" is already in list\n", + i, (*onp)->on_bi.bi_type, 0 ); + + /* NOTE: if the overlay already exists, + * there is no way to merge the results + * of the configuration that may have + * occurred during bi_db_config(); we + * just issue a warning, and the + * administrator should deal with this */ + } + } + *onp = oi->oi_list; + + oi->oi_list = on2; + + ch_free( be->bd_info ); + } + + be->bd_info = (BackendInfo *)oi; if ( rc != SLAP_CONF_UNKNOWN ) return rc; } - bd = *be; + ca.argv = argv; + ca.argc = argc; + ca.fname = fname; + ca.lineno = lineno; + ca.be = be; for (; on; on=on->on_next) { - bd.bd_info = &on->on_bi; - if (on->on_bi.bi_db_config) { - rc = on->on_bi.bi_db_config( &bd, fname, lineno, + rc = SLAP_CONF_UNKNOWN; + if (on->on_bi.bi_cf_ocs) { + ConfigTable *ct; + ca.bi = &on->on_bi; + ct = config_find_keyword( on->on_bi.bi_cf_ocs->co_table, &ca ); + if ( ct ) { + rc = config_add_vals( ct, &ca ); + } + } + if (on->on_bi.bi_db_config && rc == SLAP_CONF_UNKNOWN) { + be->bd_info = &on->on_bi; + rc = on->on_bi.bi_db_config( be, fname, lineno, argc, argv ); if ( rc != SLAP_CONF_UNKNOWN ) break; } } + be->bd_info = bi_orig; + be->be_cf_ocs = be_cf_ocs; + return rc; } @@ -105,7 +173,25 @@ over_db_close( BackendDB *be ) { - return over_db_func( be, db_close ); + slap_overinfo *oi = be->bd_info->bi_private; + slap_overinst *on = oi->oi_list; + BackendInfo *bi_orig = be->bd_info; + int rc = 0; + + for (; on && rc == 0; on=on->on_next) { + be->bd_info = &on->on_bi; + if ( be->bd_info->bi_db_close ) { + rc = be->bd_info->bi_db_close( be ); + } + } + + if ( oi->oi_orig->bi_db_close ) { + be->bd_info = oi->oi_orig; + rc = be->bd_info->bi_db_close( be ); + } + + be->bd_info = bi_orig; + return rc; } static int @@ -113,7 +199,7 @@ over_db_destroy( BackendDB *be ) { - slap_overinfo *oi = (slap_overinfo *) be->bd_info; + slap_overinfo *oi = be->bd_info->bi_private; slap_overinst *on = oi->oi_list, *next; int rc; @@ -130,11 +216,12 @@ over_db_destroy( static int over_back_response ( Operation *op, SlapReply *rs ) { - slap_overinfo *oi = (slap_overinfo *) op->o_bd->bd_info; + slap_overinfo *oi = op->o_callback->sc_private; slap_overinst *on = oi->oi_list; int rc = SLAP_CB_CONTINUE; BackendDB *be = op->o_bd, db = *op->o_bd; + db.be_flags |= SLAP_DBFLAG_OVERLAY; op->o_bd = &db; for (; on; on=on->on_next ) { if ( on->on_response ) { @@ -147,46 +234,312 @@ over_back_response ( Operation *op, SlapReply *rs ) return rc; } -enum op_which { op_bind = 0, op_unbind, op_search, op_compare, - op_modify, op_modrdn, op_add, op_delete, op_abandon, - op_cancel, op_extended }; +#ifdef SLAP_OVERLAY_ACCESS +static int +over_access_allowed( + Operation *op, + Entry *e, + AttributeDescription *desc, + struct berval *val, + slap_access_t access, + AccessControlState *state, + slap_mask_t *maskp ) +{ + slap_overinfo *oi; + slap_overinst *on; + BackendInfo *bi = op->o_bd->bd_info; + BackendDB *be = op->o_bd, db; + int rc = SLAP_CB_CONTINUE; + + /* FIXME: used to happen for instance during abandon + * when global overlays are used... */ + assert( op->o_bd != NULL ); + + oi = op->o_bd->bd_info->bi_private; + on = oi->oi_list; + + for ( ; on; on = on->on_next ) { + if ( on->on_bi.bi_access_allowed ) { + /* NOTE: do not copy the structure until required */ + if ( !SLAP_ISOVERLAY( op->o_bd ) ) { + db = *op->o_bd; + db.be_flags |= SLAP_DBFLAG_OVERLAY; + op->o_bd = &db; + } + + op->o_bd->bd_info = (BackendInfo *)on; + rc = on->on_bi.bi_access_allowed( op, e, + desc, val, access, state, maskp ); + if ( rc != SLAP_CB_CONTINUE ) break; + } + } + + if ( rc == SLAP_CB_CONTINUE ) { + BI_access_allowed *bi_access_allowed; + + /* if the database structure was changed, o_bd points to a + * copy of the structure; put the original bd_info in place */ + if ( SLAP_ISOVERLAY( op->o_bd ) ) { + op->o_bd->bd_info = oi->oi_orig; + } + + if ( oi->oi_orig->bi_access_allowed ) { + bi_access_allowed = oi->oi_orig->bi_access_allowed; + } else { + bi_access_allowed = slap_access_allowed; + } + + rc = bi_access_allowed( op, e, + desc, val, access, state, maskp ); + } + /* should not fall thru this far without anything happening... */ + if ( rc == SLAP_CB_CONTINUE ) { + /* access not allowed */ + rc = 0; + } + + op->o_bd = be; + op->o_bd->bd_info = bi; + + return rc; +} static int -over_op_func( +over_acl_group( + Operation *op, + Entry *e, + struct berval *gr_ndn, + struct berval *op_ndn, + ObjectClass *group_oc, + AttributeDescription *group_at ) +{ + slap_overinfo *oi; + slap_overinst *on; + BackendInfo *bi = op->o_bd->bd_info; + BackendDB *be = op->o_bd, db; + int rc = SLAP_CB_CONTINUE; + + /* FIXME: used to happen for instance during abandon + * when global overlays are used... */ + assert( op->o_bd != NULL ); + + oi = op->o_bd->bd_info->bi_private; + on = oi->oi_list; + + for ( ; on; on = on->on_next ) { + if ( on->on_bi.bi_acl_group ) { + /* NOTE: do not copy the structure until required */ + if ( !SLAP_ISOVERLAY( op->o_bd ) ) { + db = *op->o_bd; + db.be_flags |= SLAP_DBFLAG_OVERLAY; + op->o_bd = &db; + } + + op->o_bd->bd_info = (BackendInfo *)on; + rc = on->on_bi.bi_acl_group( op, e, + gr_ndn, op_ndn, group_oc, group_at ); + if ( rc != SLAP_CB_CONTINUE ) break; + } + } + + if ( rc == SLAP_CB_CONTINUE ) { + BI_acl_group *bi_acl_group; + + /* if the database structure was changed, o_bd points to a + * copy of the structure; put the original bd_info in place */ + if ( SLAP_ISOVERLAY( op->o_bd ) ) { + op->o_bd->bd_info = oi->oi_orig; + } + + if ( oi->oi_orig->bi_acl_group ) { + bi_acl_group = oi->oi_orig->bi_acl_group; + } else { + bi_acl_group = backend_group; + } + + rc = bi_acl_group( op, e, + gr_ndn, op_ndn, group_oc, group_at ); + } + /* should not fall thru this far without anything happening... */ + if ( rc == SLAP_CB_CONTINUE ) { + /* access not allowed */ + rc = 0; + } + + op->o_bd = be; + op->o_bd->bd_info = bi; + + return rc; +} + +static int +over_acl_attribute( + Operation *op, + Entry *target, + struct berval *entry_ndn, + AttributeDescription *entry_at, + BerVarray *vals, + slap_access_t access ) +{ + slap_overinfo *oi; + slap_overinst *on; + BackendInfo *bi = op->o_bd->bd_info; + BackendDB *be = op->o_bd, db; + int rc = SLAP_CB_CONTINUE; + + /* FIXME: used to happen for instance during abandon + * when global overlays are used... */ + assert( op->o_bd != NULL ); + + oi = op->o_bd->bd_info->bi_private; + on = oi->oi_list; + + for ( ; on; on = on->on_next ) { + if ( on->on_bi.bi_acl_attribute ) { + /* NOTE: do not copy the structure until required */ + if ( !SLAP_ISOVERLAY( op->o_bd ) ) { + db = *op->o_bd; + db.be_flags |= SLAP_DBFLAG_OVERLAY; + op->o_bd = &db; + } + + op->o_bd->bd_info = (BackendInfo *)on; + rc = on->on_bi.bi_acl_attribute( op, target, + entry_ndn, entry_at, vals, access ); + if ( rc != SLAP_CB_CONTINUE ) break; + } + } + + if ( rc == SLAP_CB_CONTINUE ) { + BI_acl_attribute *bi_acl_attribute; + + /* if the database structure was changed, o_bd points to a + * copy of the structure; put the original bd_info in place */ + if ( SLAP_ISOVERLAY( op->o_bd ) ) { + op->o_bd->bd_info = oi->oi_orig; + } + + if ( oi->oi_orig->bi_acl_attribute ) { + bi_acl_attribute = oi->oi_orig->bi_acl_attribute; + } else { + bi_acl_attribute = backend_attribute; + } + + rc = bi_acl_attribute( op, target, + entry_ndn, entry_at, vals, access ); + } + /* should not fall thru this far without anything happening... */ + if ( rc == SLAP_CB_CONTINUE ) { + /* access not allowed */ + rc = 0; + } + + op->o_bd = be; + op->o_bd->bd_info = bi; + + return rc; +} +#endif /* SLAP_OVERLAY_ACCESS */ + +/* + * default return code in case of missing backend function + * and overlay stack returning SLAP_CB_CONTINUE + */ +static int op_rc[ op_last ] = { + LDAP_UNWILLING_TO_PERFORM, /* bind */ + LDAP_UNWILLING_TO_PERFORM, /* unbind */ + LDAP_UNWILLING_TO_PERFORM, /* search */ + SLAP_CB_CONTINUE, /* compare; pass to frontend */ + LDAP_UNWILLING_TO_PERFORM, /* modify */ + LDAP_UNWILLING_TO_PERFORM, /* modrdn */ + LDAP_UNWILLING_TO_PERFORM, /* add */ + LDAP_UNWILLING_TO_PERFORM, /* delete */ + LDAP_UNWILLING_TO_PERFORM, /* abandon */ + LDAP_UNWILLING_TO_PERFORM, /* cancel */ + LDAP_UNWILLING_TO_PERFORM, /* extended */ + LDAP_SUCCESS, /* aux_operational */ + LDAP_SUCCESS, /* aux_chk_referrals */ + SLAP_CB_CONTINUE /* aux_chk_controls; pass to frontend */ +}; + +int overlay_op_walk( Operation *op, SlapReply *rs, - enum op_which which + slap_operation_t which, + slap_overinfo *oi, + slap_overinst *on ) { - slap_overinfo *oi = (slap_overinfo *) op->o_bd->bd_info; - slap_overinst *on = oi->oi_list; BI_op_bind **func; - BackendDB *be = op->o_bd, db = *op->o_bd; - slap_callback cb = {NULL, over_back_response, NULL, NULL}; int rc = SLAP_CB_CONTINUE; - op->o_bd = &db; - cb.sc_next = op->o_callback; - op->o_callback = &cb; - for (; on; on=on->on_next ) { func = &on->on_bi.bi_op_bind; if ( func[which] ) { - db.bd_info = (BackendInfo *)on; + op->o_bd->bd_info = (BackendInfo *)on; rc = func[which]( op, rs ); if ( rc != SLAP_CB_CONTINUE ) break; } } - op->o_bd = be; - func = &oi->oi_bd.bd_info->bi_op_bind; + func = &oi->oi_orig->bi_op_bind; if ( func[which] && rc == SLAP_CB_CONTINUE ) { + op->o_bd->bd_info = oi->oi_orig; rc = func[which]( op, rs ); } /* should not fall thru this far without anything happening... */ if ( rc == SLAP_CB_CONTINUE ) { - rc = LDAP_UNWILLING_TO_PERFORM; + rc = op_rc[ which ]; + } + + /* The underlying backend didn't handle the request, make sure + * overlay cleanup is processed. + */ + if ( rc == LDAP_UNWILLING_TO_PERFORM ) { + slap_callback *sc_next; + for ( ; op->o_callback && op->o_callback->sc_response != + over_back_response; op->o_callback = sc_next ) { + sc_next = op->o_callback->sc_next; + if ( op->o_callback->sc_cleanup ) { + op->o_callback->sc_cleanup( op, rs ); + } + } + } + return rc; +} + +static int +over_op_func( + Operation *op, + SlapReply *rs, + slap_operation_t which +) +{ + slap_overinfo *oi; + slap_overinst *on; + BackendDB *be = op->o_bd, db; + slap_callback cb = {NULL, over_back_response, NULL, NULL}; + int rc = SLAP_CB_CONTINUE; + + /* FIXME: used to happen for instance during abandon + * when global overlays are used... */ + assert( op->o_bd != NULL ); + + oi = op->o_bd->bd_info->bi_private; + on = oi->oi_list; + + if ( !SLAP_ISOVERLAY( op->o_bd )) { + db = *op->o_bd; + db.be_flags |= SLAP_DBFLAG_OVERLAY; + op->o_bd = &db; } + cb.sc_next = op->o_callback; + cb.sc_private = oi; + op->o_callback = &cb; + + rc = overlay_op_walk( op, rs, which, oi, on ); + + op->o_bd = be; op->o_callback = cb.sc_next; return rc; } @@ -257,6 +610,96 @@ over_op_extended( Operation *op, SlapReply *rs ) return over_op_func( op, rs, op_extended ); } +static int +over_aux_operational( Operation *op, SlapReply *rs ) +{ + return over_op_func( op, rs, op_aux_operational ); +} + +static int +over_aux_chk_referrals( Operation *op, SlapReply *rs ) +{ + return over_op_func( op, rs, op_aux_chk_referrals ); +} + +static int +over_aux_chk_controls( Operation *op, SlapReply *rs ) +{ + return over_op_func( op, rs, op_aux_chk_controls ); +} + +enum conn_which { + conn_init = 0, + conn_destroy, + conn_last +}; + +static int +over_connection_func( + BackendDB *bd, + Connection *conn, + enum conn_which which +) +{ + slap_overinfo *oi; + slap_overinst *on; + BackendDB db; + int rc = SLAP_CB_CONTINUE; + BI_connection_init **func; + + /* FIXME: used to happen for instance during abandon + * when global overlays are used... */ + assert( bd != NULL ); + + oi = bd->bd_info->bi_private; + on = oi->oi_list; + + if ( !SLAP_ISOVERLAY( bd ) ) { + db = *bd; + db.be_flags |= SLAP_DBFLAG_OVERLAY; + bd = &db; + } + + for ( ; on; on = on->on_next ) { + func = &on->on_bi.bi_connection_init; + if ( func[ which ] ) { + bd->bd_info = (BackendInfo *)on; + rc = func[ which ]( bd, conn ); + if ( rc != SLAP_CB_CONTINUE ) break; + } + } + + func = &oi->oi_orig->bi_connection_init; + if ( func[ which ] && rc == SLAP_CB_CONTINUE ) { + bd->bd_info = oi->oi_orig; + rc = func[ which ]( bd, conn ); + } + /* should not fall thru this far without anything happening... */ + if ( rc == SLAP_CB_CONTINUE ) { + rc = LDAP_UNWILLING_TO_PERFORM; + } + + return rc; +} + +static int +over_connection_init( + BackendDB *bd, + Connection *conn +) +{ + return over_connection_func( bd, conn, conn_init ); +} + +static int +over_connection_destroy( + BackendDB *bd, + Connection *conn +) +{ + return over_connection_func( bd, conn, conn_destroy ); +} + int overlay_register( slap_overinst *on @@ -267,32 +710,173 @@ overlay_register( return 0; } +/* + * iterator on registered overlays; overlay_next( NULL ) returns the first + * overlay; * subsequent calls with the previously returned value allow to + * iterate * over the entire list; returns NULL when no more overlays are + * registered. + */ + +slap_overinst * +overlay_next( + slap_overinst *on +) +{ + if ( on == NULL ) { + return overlays; + } + + return on->on_next; +} + +/* + * returns a specific registered overlay based on the type; NULL if not + * registered. + */ + +slap_overinst * +overlay_find( const char *over_type ) +{ + slap_overinst *on = overlays; + + assert( over_type != NULL ); + + for ( ; on; on = on->on_next ) { + if ( strcmp( on->on_bi.bi_type, over_type ) == 0 ) { + break; + } + } + + return on; +} + static const char overtype[] = "over"; -/* add an overlay to a particular backend. */ +/* + * returns TRUE (1) if the database is actually an overlay instance; + * FALSE (0) otherwise. + */ + int -overlay_config( BackendDB *be, const char *ov ) +overlay_is_over( BackendDB *be ) { - slap_overinst *on, *on2, *prev; - slap_overinfo *oi; - BackendInfo *bi; + return be->bd_info->bi_type == overtype; +} + +/* + * returns TRUE (1) if the given database is actually an overlay + * instance and, somewhere in the list, contains the requested overlay; + * FALSE (0) otherwise. + */ + +int +overlay_is_inst( BackendDB *be, const char *over_type ) +{ + slap_overinst *on; + + assert( be != NULL ); + + if ( !overlay_is_over( be ) ) { + return 0; + } + + on = ((slap_overinfo *)be->bd_info->bi_private)->oi_list; + for ( ; on; on = on->on_next ) { + if ( strcmp( on->on_bi.bi_type, over_type ) == 0 ) { + return 1; + } + } + + return 0; +} + +int +overlay_register_control( BackendDB *be, const char *oid ) +{ + int rc = 0; + int gotit = 0; + int cid; + + if ( slap_find_control_id( oid, &cid ) == LDAP_CONTROL_NOT_FOUND ) { + return -1; + } + + if ( SLAP_DBFLAGS( be ) & SLAP_DBFLAG_GLOBAL_OVERLAY ) { + BackendDB *bd; + + /* add to all backends... */ + LDAP_STAILQ_FOREACH( bd, &backendDB, be_next ) { + if ( be == bd ) { + gotit = 1; + } + + bd->be_ctrls[ cid ] = 1; + bd->be_ctrls[ SLAP_MAX_CIDS ] = 1; + } + + } + + if ( rc == 0 && !gotit ) { + be->be_ctrls[ cid ] = 1; + be->be_ctrls[ SLAP_MAX_CIDS ] = 1; + } - for ( on = overlays; on; on=on->on_next ) { - if (!strcmp( ov, on->on_bi.bi_type ) ) + return rc; +} + +void +overlay_destroy_one( BackendDB *be, slap_overinst *on ) +{ + slap_overinfo *oi = on->on_info; + slap_overinst **oidx; + + for ( oidx = &oi->oi_list; *oidx; oidx = &(*oidx)->on_next ) { + if ( *oidx == on ) { + *oidx = on->on_next; + if ( on->on_bi.bi_db_destroy ) { + BackendInfo *bi_orig = be->bd_info; + be->bd_info = (BackendInfo *)on; + on->on_bi.bi_db_destroy( be ); + be->bd_info = bi_orig; + } + free( on ); break; + } } - if (!on) { - Debug( LDAP_DEBUG_ANY, "overlay %s not found\n", ov, 0, 0 ); +} + +/* add an overlay to a particular backend. */ +int +overlay_config( BackendDB *be, const char *ov ) +{ + slap_overinst *on = NULL, *on2 = NULL; + slap_overinfo *oi = NULL; + BackendInfo *bi = NULL; + + on = overlay_find( ov ); + if ( !on ) { + Debug( LDAP_DEBUG_ANY, "overlay \"%s\" not found\n", ov, 0, 0 ); return 1; } /* If this is the first overlay on this backend, set up the * overlay info structure */ - if ( be->bd_info->bi_type != overtype ) { - oi = ch_malloc( sizeof(slap_overinfo) ); - oi->oi_bd = *be; + if ( !overlay_is_over( be ) ) { + oi = ch_malloc( sizeof( slap_overinfo ) ); + oi->oi_orig = be->bd_info; oi->oi_bi = *be->bd_info; + + /* NOTE: the first time a global overlay is configured, + * frontendDB gets this flag; it is used later by overlays + * to determine if they're stacked on top of the frontendDB */ + if ( oi->oi_orig == frontendDB->bd_info ) { + SLAP_DBFLAGS( be ) |= SLAP_DBFLAG_GLOBAL_OVERLAY; + } + + /* Save a pointer to ourself in bi_private. + */ + oi->oi_bi.bi_private = oi; oi->oi_list = NULL; bi = (BackendInfo *)oi; @@ -313,27 +897,41 @@ overlay_config( BackendDB *be, const char *ov ) bi->bi_op_delete = over_op_delete; bi->bi_op_abandon = over_op_abandon; bi->bi_op_cancel = over_op_cancel; + bi->bi_extended = over_op_extended; + /* + * this is fine because it has the same + * args of the operations; we need to rework + * all the hooks to share the same args + * of the operations... + */ + bi->bi_operational = over_aux_operational; + bi->bi_chk_referrals = over_aux_chk_referrals; + bi->bi_chk_controls = over_aux_chk_controls; + +#ifdef SLAP_OVERLAY_ACCESS + /* these have specific arglists */ + bi->bi_access_allowed = over_access_allowed; + bi->bi_acl_group = over_acl_group; + bi->bi_acl_attribute = over_acl_attribute; +#endif /* SLAP_OVERLAY_ACCESS */ + + bi->bi_connection_init = over_connection_init; + bi->bi_connection_destroy = over_connection_destroy; + be->bd_info = bi; - } -#if 0 - /* Walk to the end of the list of overlays, add the new - * one onto the end - */ - oi = (slap_overinfo *) be->bd_info; - for ( prev=NULL, on2 = oi->oi_list; on2; prev=on2, on2=on2->on_next ); - on2 = ch_calloc( 1, sizeof(slap_overinst) ); - if ( !prev ) { - oi->oi_list = on2; } else { - prev->on_next = on2; + if ( overlay_is_inst( be, ov ) ) { + Debug( LDAP_DEBUG_ANY, "overlay_config(): " + "warning, overlay \"%s\" " + "already in list\n", ov, 0, 0 ); + } + + oi = be->bd_info->bi_private; } - *on2 = *on; - on2->on_next = NULL; - on2->on_info = oi; -#else + /* Insert new overlay on head of list. Overlays are executed * in reverse of config order... */ @@ -342,13 +940,14 @@ overlay_config( BackendDB *be, const char *ov ) on2->on_info = oi; on2->on_next = oi->oi_list; oi->oi_list = on2; -#endif /* Any initialization needed? */ if ( on->on_bi.bi_db_init ) { + int rc; be->bd_info = (BackendInfo *)on2; - on2->on_bi.bi_db_init( be ); + rc = on2->on_bi.bi_db_init( be ); be->bd_info = (BackendInfo *)oi; + if ( rc ) return rc; } return 0;