X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fconnection.c;h=436a76c5d2cb33948a84b3fceb1107b70aa20d9a;hb=306795461663a6bab277205554fa4df8f9515c8a;hp=ce4f7f08615d63f8f799380e58a2c7f6b4aa46ad;hpb=4191f390370fbbf2a0805d7642e14fa24a4580fa;p=openldap diff --git a/servers/slapd/connection.c b/servers/slapd/connection.c index ce4f7f0861..436a76c5d2 100644 --- a/servers/slapd/connection.c +++ b/servers/slapd/connection.c @@ -1,6 +1,6 @@ /* $OpenLDAP$ */ /* - * Copyright 1998-2002 The OpenLDAP Foundation, All Rights Reserved. + * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved. * COPYING RESTRICTIONS APPLY, see COPYRIGHT file */ @@ -11,7 +11,6 @@ #include #include -#include #include #include #include @@ -56,15 +55,12 @@ static Connection* connection_get( ber_socket_t s ); static int connection_input( Connection *c ); static void connection_close( Connection *c ); -static int connection_op_activate( Connection *conn, Operation *op ); +static int connection_op_activate( Operation *op ); static int connection_resched( Connection *conn ); static void connection_abandon( Connection *conn ); static void connection_destroy( Connection *c ); -struct co_arg { - Connection *co_conn; - Operation *co_op; -}; +static ldap_pvt_thread_start_t connection_operation; /* * Initialize connection management infrastructure. @@ -75,8 +71,8 @@ int connections_init(void) if( connections != NULL) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connections_init: already initialized.\n" )); + LDAP_LOG( CONNECTION, INFO, + "connections_init: already initialized.\n", 0, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "connections_init: already initialized.\n", 0, 0, 0 ); @@ -87,13 +83,13 @@ int connections_init(void) /* should check return of every call */ ldap_pvt_thread_mutex_init( &connections_mutex ); - connections = (Connection *) calloc( dtblsize, sizeof(Connection) ); + connections = (Connection *) ch_calloc( dtblsize, sizeof(Connection) ); if( connections == NULL ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connections_init: allocation (%d * %ld) of connection array failed\n", - dtblsize, (long) sizeof(Connection) )); + LDAP_LOG( CONNECTION, ERR, + "connections_init: allocation (%d * %ld) of connection " + "array failed\n", dtblsize, (long) sizeof(Connection), 0 ); #else Debug( LDAP_DEBUG_ANY, "connections_init: allocation (%d*%ld) of connection array failed\n", @@ -124,8 +120,8 @@ int connections_destroy(void) if( connections == NULL) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connections_destroy: nothing to destroy.\n")); + LDAP_LOG( CONNECTION, INFO, + "connections_destroy: nothing to destroy.\n", 0, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "connections_destroy: nothing to destroy.\n", 0, 0, 0 ); @@ -209,8 +205,7 @@ static Connection* connection_get( ber_socket_t s ) Connection *c; #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ENTRY, - "connection_get: socket %ld\n", (long)s )); + LDAP_LOG( CONNECTION, ENTRY, "connection_get: socket %ld\n", (long)s, 0, 0 ); #else Debug( LDAP_DEBUG_ARGS, "connection_get(%ld)\n", @@ -234,15 +229,15 @@ static Connection* connection_get( ber_socket_t s ) ber_socket_t i, sd; for(i=0; ic_connid )); + LDAP_LOG( CONNECTION, RESULTS, + "connection_get: get for %d got connid %lu\n", s, c->c_connid, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_get(%d): got connid=%ld\n", + "connection_get(%d): got connid=%lu\n", s, c->c_connid, 0 ); #endif @@ -320,10 +315,9 @@ static void connection_return( Connection *c ) long connection_init( ber_socket_t s, - const char* url, + Listener *listener, const char* dnsname, const char* peername, - const char* sockname, int tls_udp_option, slap_ssf_t ssf, const char *authid ) @@ -333,9 +327,9 @@ long connection_init( assert( connections != NULL ); + assert( listener != NULL ); assert( dnsname != NULL ); assert( peername != NULL ); - assert( sockname != NULL ); #ifndef HAVE_TLS assert( tls_udp_option != 1 ); @@ -343,8 +337,8 @@ long connection_init( if( s == AC_SOCKET_INVALID ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_init: init of socket %ld invalid.\n", (long)s )); + LDAP_LOG( CONNECTION, INFO, + "connection_init: init of socket %ld invalid.\n", (long)s, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "connection_init(%ld): invalid.\n", @@ -395,37 +389,44 @@ long connection_init( if( c == NULL ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_init: skt %d connection table full (%d/%d)\n", - s, i, dtblsize )); + LDAP_LOG( CONNECTION, INFO, + "connection_init: skt %d connection table full " + "(%d/%d)\n", s, i, dtblsize ); #else Debug( LDAP_DEBUG_ANY, - "connection_init(%d): connection table full (%d/%d)\n", - s, i, dtblsize); + "connection_init(%d): connection table full " + "(%d/%d)\n", s, i, dtblsize); #endif ldap_pvt_thread_mutex_unlock( &connections_mutex ); return -1; } - } + } #endif - assert( c != NULL ); + assert( c != NULL ); if( c->c_struct_state == SLAP_C_UNINITIALIZED ) { + c->c_send_ldap_result = slap_send_ldap_result; + c->c_send_search_entry = slap_send_search_entry; + c->c_send_search_reference = slap_send_search_reference; + c->c_send_ldap_extended = slap_send_ldap_extended; +#ifdef LDAP_RES_INTERMEDIATE_RESP + c->c_send_ldap_intermediate_resp = slap_send_ldap_intermediate_resp; +#endif + c->c_authmech.bv_val = NULL; c->c_authmech.bv_len = 0; c->c_dn.bv_val = NULL; c->c_dn.bv_len = 0; c->c_ndn.bv_val = NULL; c->c_ndn.bv_len = 0; - c->c_cdn.bv_val = NULL; - c->c_cdn.bv_len = 0; c->c_groups = NULL; - c->c_listener_url = NULL; - c->c_peer_domain = NULL; - c->c_peer_name = NULL; - c->c_sock_name = NULL; + c->c_listener = NULL; + c->c_peer_domain.bv_val = NULL; + c->c_peer_domain.bv_len = 0; + c->c_peer_name.bv_val = NULL; + c->c_peer_name.bv_len = 0; LDAP_STAILQ_INIT(&c->c_ops); LDAP_STAILQ_INIT(&c->c_pending_ops); @@ -434,6 +435,7 @@ long connection_init( c->c_sasl_bind_mech.bv_len = 0; c->c_sasl_context = NULL; c->c_sasl_extra = NULL; + c->c_sasl_bindop = NULL; c->c_sb = ber_sockbuf_alloc( ); @@ -458,23 +460,21 @@ long connection_init( assert( c->c_authmech.bv_val == NULL ); assert( c->c_dn.bv_val == NULL ); assert( c->c_ndn.bv_val == NULL ); - assert( c->c_cdn.bv_val == NULL ); assert( c->c_groups == NULL ); - assert( c->c_listener_url == NULL ); - assert( c->c_peer_domain == NULL ); - assert( c->c_peer_name == NULL ); - assert( c->c_sock_name == NULL ); + assert( c->c_listener == NULL ); + assert( c->c_peer_domain.bv_val == NULL ); + assert( c->c_peer_name.bv_val == NULL ); assert( LDAP_STAILQ_EMPTY(&c->c_ops) ); assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) ); assert( c->c_sasl_bind_mech.bv_val == NULL ); assert( c->c_sasl_context == NULL ); assert( c->c_sasl_extra == NULL ); + assert( c->c_sasl_bindop == NULL ); assert( c->c_currentber == NULL ); - c->c_listener_url = ch_strdup( url ); - c->c_peer_domain = ch_strdup( dnsname ); - c->c_peer_name = ch_strdup( peername ); - c->c_sock_name = ch_strdup( sockname ); + c->c_listener = listener; + ber_str2bv( dnsname, 0, 1, &c->c_peer_domain ); + ber_str2bv( peername, 0, 1, &c->c_peer_name ); c->c_n_ops_received = 0; c->c_n_ops_executing = 0; @@ -498,26 +498,25 @@ long connection_init( #ifdef LDAP_CONNECTIONLESS c->c_is_udp = 0; - if (tls_udp_option == 2) - { + if( tls_udp_option == 2 ) { c->c_is_udp = 1; #ifdef LDAP_DEBUG - ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_debug, - LBER_SBIOD_LEVEL_PROVIDER, (void*)"udp_" ); + ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_debug, + LBER_SBIOD_LEVEL_PROVIDER, (void*)"udp_" ); #endif - ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_udp, - LBER_SBIOD_LEVEL_PROVIDER, (void *)&s ); - ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_readahead, - LBER_SBIOD_LEVEL_PROVIDER, NULL ); + ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_udp, + LBER_SBIOD_LEVEL_PROVIDER, (void *)&s ); + ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_readahead, + LBER_SBIOD_LEVEL_PROVIDER, NULL ); } else #endif { #ifdef LDAP_DEBUG - ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_debug, - LBER_SBIOD_LEVEL_PROVIDER, (void*)"tcp_" ); + ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_debug, + LBER_SBIOD_LEVEL_PROVIDER, (void*)"tcp_" ); #endif - ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_tcp, - LBER_SBIOD_LEVEL_PROVIDER, (void *)&s ); + ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_tcp, + LBER_SBIOD_LEVEL_PROVIDER, (void *)&s ); } #ifdef LDAP_DEBUG @@ -529,13 +528,13 @@ long connection_init( c /* non-NULL */ ) < 0 ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_init: conn %d set nonblocking failed\n", - c->c_connid )); + LDAP_LOG( CONNECTION, INFO, + "connection_init: conn %lu set nonblocking failed\n", + c->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "connection_init(%d, %s): set nonblocking failed\n", - s, c->c_peer_name, 0 ); + s, c->c_peer_name.bv_val, 0 ); #endif } @@ -570,8 +569,8 @@ long connection_init( void connection2anonymous( Connection *c ) { - assert( connections != NULL ); - assert( c != NULL ); + assert( connections != NULL ); + assert( c != NULL ); { ber_len_t max = sockbuf_max_incoming; @@ -584,36 +583,27 @@ void connection2anonymous( Connection *c ) } c->c_authmech.bv_len = 0; - if(c->c_dn.bv_val != NULL) { - free(c->c_dn.bv_val); - c->c_dn.bv_val = NULL; - } - c->c_dn.bv_len = 0; - if(c->c_ndn.bv_val != NULL) { - free(c->c_ndn.bv_val); - c->c_ndn.bv_val = NULL; - } - c->c_ndn.bv_len = 0; - - if(c->c_cdn.bv_val != NULL) { - free(c->c_cdn.bv_val); - c->c_cdn.bv_val = NULL; + if(c->c_dn.bv_val != NULL) { + free(c->c_dn.bv_val); + c->c_dn.bv_val = NULL; } - c->c_cdn.bv_len = 0; + c->c_dn.bv_len = 0; + if(c->c_ndn.bv_val != NULL) { + free(c->c_ndn.bv_val); + c->c_ndn.bv_val = NULL; + } + c->c_ndn.bv_len = 0; - c->c_authc_backend = NULL; c->c_authz_backend = NULL; - - { - GroupAssertion *g, *n; - for (g = c->c_groups; g; g=n) + { - n = g->next; - free(g); + GroupAssertion *g, *n; + for (g = c->c_groups; g; g=n) { + n = g->ga_next; + free(g); + } + c->c_groups = NULL; } - c->c_groups = NULL; - } - } static void @@ -621,6 +611,7 @@ connection_destroy( Connection *c ) { /* note: connections_mutex should be locked by caller */ ber_socket_t sd; + unsigned long connid; assert( connections != NULL ); assert( c != NULL ); @@ -628,6 +619,9 @@ connection_destroy( Connection *c ) assert( c->c_conn_state != SLAP_C_INVALID ); assert( LDAP_STAILQ_EMPTY(&c->c_ops) ); + /* only for stats (print -1 as "%lu" may give unexpected results ;) */ + connid = c->c_connid; + backend_connection_destroy(c); c->c_protocol = 0; @@ -636,38 +630,18 @@ connection_destroy( Connection *c ) c->c_activitytime = c->c_starttime = 0; connection2anonymous( c ); + c->c_listener = NULL; - if(c->c_listener_url != NULL) { - free(c->c_listener_url); - c->c_listener_url = NULL; - } - - if(c->c_peer_domain != NULL) { - free(c->c_peer_domain); - c->c_peer_domain = NULL; - } - if(c->c_peer_name != NULL) { -#ifdef LDAP_PF_lOCAL - /* - * If peer was a domain socket, unlink. Mind you, - * they may be un-named. Should we leave this to - * the client? - */ - if (strncmp(c->c_peer_name, "PATH=", 5) == 0) { - char *path = c->c_peer_name + 5; - if (path != '\0') { - (void)unlink(path); - } - } -#endif /* LDAP_PF_LOCAL */ - - free(c->c_peer_name); - c->c_peer_name = NULL; + if(c->c_peer_domain.bv_val != NULL) { + free(c->c_peer_domain.bv_val); + c->c_peer_domain.bv_val = NULL; } - if(c->c_sock_name != NULL) { - free(c->c_sock_name); - c->c_sock_name = NULL; + c->c_peer_domain.bv_len = 0; + if(c->c_peer_name.bv_val != NULL) { + free(c->c_peer_name.bv_val); + c->c_peer_name.bv_val = NULL; } + c->c_peer_name.bv_len = 0; c->c_sasl_bind_in_progress = 0; if(c->c_sasl_bind_mech.bv_val != NULL) { @@ -688,8 +662,8 @@ connection_destroy( Connection *c ) slapd_remove( sd, 0 ); Statslog( LDAP_DEBUG_STATS, - "conn=%ld fd=%d closed\n", - c->c_connid, sd, 0, 0, 0 ); + "conn=%lu fd=%d closed\n", + connid, sd, 0, 0, 0 ); } ber_sockbuf_free( c->c_sb ); @@ -727,9 +701,7 @@ static void connection_abandon( Connection *c ) Operation *o; LDAP_STAILQ_FOREACH(o, &c->c_ops, o_next) { - ldap_pvt_thread_mutex_lock( &o->o_abandonmutex ); o->o_abandon = 1; - ldap_pvt_thread_mutex_unlock( &o->o_abandonmutex ); } /* remove pending operations */ @@ -754,12 +726,12 @@ void connection_closing( Connection *c ) ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd ); #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1, - "connection_closing: conn %d readying socket %d for close.\n", - c->c_connid, sd )); + LDAP_LOG( CONNECTION, DETAIL1, + "connection_closing: conn %lu readying socket %d for close.\n", + c->c_connid, sd, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_closing: readying conn=%ld sd=%d for close\n", + "connection_closing: readying conn=%lu sd=%d for close\n", c->c_connid, sd, 0 ); #endif /* update state to closing */ @@ -791,23 +763,22 @@ static void connection_close( Connection *c ) ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd ); if( !LDAP_STAILQ_EMPTY(&c->c_ops) ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1, - "connection_close: conn %d deferring sd %d\n", - c->c_connid, sd )); + LDAP_LOG( CONNECTION, DETAIL1, + "connection_close: conn %lu deferring sd %d\n", + c->c_connid, sd, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_close: deferring conn=%ld sd=%d\n", + "connection_close: deferring conn=%lu sd=%d\n", c->c_connid, sd, 0 ); #endif return; } #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_RESULTS, - "connection_close: conn %d sd %d\n", - c->c_connid, sd )); + LDAP_LOG( CONNECTION, RESULTS, + "connection_close: conn %lu sd %d\n", c->c_connid, sd, 0 ); #else - Debug( LDAP_DEBUG_TRACE, "connection_close: conn=%ld sd=%d\n", + Debug( LDAP_DEBUG_TRACE, "connection_close: conn=%lu sd=%d\n", c->c_connid, sd, 0 ); #endif connection_destroy( c ); @@ -895,110 +866,220 @@ void connection_done( Connection *c ) * calls the appropriate stub to handle it. */ +#ifdef SLAPD_MONITOR +#define INCR_OP(var,index) \ + do { \ + ldap_pvt_thread_mutex_lock( &num_ops_mutex ); \ + (var)[(index)]++; \ + ldap_pvt_thread_mutex_unlock( &num_ops_mutex ); \ + } while (0) +#else /* !SLAPD_MONITOR */ +#define INCR_OP(var,index) +#endif /* !SLAPD_MONITOR */ + static void * -connection_operation( void *arg_v ) +connection_operation( void *ctx, void *arg_v ) { - int rc; - struct co_arg *arg = arg_v; - ber_tag_t tag = arg->co_op->o_tag; - Connection *conn = arg->co_conn; + int rc = SLAPD_DISCONNECT; + Operation *op = arg_v; + SlapReply rs = {REP_RESULT}; + ber_tag_t tag = op->o_tag; +#ifdef SLAPD_MONITOR + ber_tag_t oldtag = tag; +#endif /* SLAPD_MONITOR */ + Connection *conn = op->o_conn; + void *memctx; + ber_len_t memsiz; ldap_pvt_thread_mutex_lock( &num_ops_mutex ); num_ops_initiated++; ldap_pvt_thread_mutex_unlock( &num_ops_mutex ); + op->o_threadctx = ctx; + if( conn->c_sasl_bind_in_progress && tag != LDAP_REQ_BIND ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_operation: conn %d SASL bind in progress (tag=%ld).\n", - conn->c_connid, (long)tag )); + LDAP_LOG( CONNECTION, ERR, + "connection_operation: conn %lu SASL bind in progress (tag=%ld).\n", + conn->c_connid, (long)tag, 0 ); #else Debug( LDAP_DEBUG_ANY, "connection_operation: " "error: SASL bind in progress (tag=%ld).\n", (long) tag, 0, 0 ); #endif - send_ldap_result( conn, arg->co_op, - rc = LDAP_OPERATIONS_ERROR, - NULL, "SASL bind in progress", NULL, NULL ); + send_ldap_error( op, &rs, LDAP_OPERATIONS_ERROR, + "SASL bind in progress" ); goto operations_error; } + /* We can use Thread-Local storage for most mallocs. We can + * also use TL for ber parsing, but not on Add or Modify. + */ +#define SLAB_SIZE 1048576 +#if 0 + memsiz = ber_len( op->o_ber ) * 64; + if ( SLAB_SIZE > memsiz ) memsiz = SLAB_SIZE; +#endif + memsiz = SLAB_SIZE; + + memctx = sl_mem_create( memsiz, ctx ); + op->o_tmpmemctx = memctx; + op->o_tmpmfuncs = &sl_mfuncs; + if ( tag != LDAP_REQ_ADD && tag != LDAP_REQ_MODIFY ) { + ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, memctx ); + } + switch ( tag ) { case LDAP_REQ_BIND: - rc = do_bind( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_BIND); + rc = do_bind( op, &rs ); break; case LDAP_REQ_UNBIND: - rc = do_unbind( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_UNBIND); + rc = do_unbind( op, &rs ); break; case LDAP_REQ_ADD: - rc = do_add( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_ADD); + rc = do_add( op, &rs ); break; case LDAP_REQ_DELETE: - rc = do_delete( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_DELETE); + rc = do_delete( op, &rs ); break; case LDAP_REQ_MODRDN: - rc = do_modrdn( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_MODRDN); + rc = do_modrdn( op, &rs ); break; case LDAP_REQ_MODIFY: - rc = do_modify( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_MODIFY); + rc = do_modify( op, &rs ); break; case LDAP_REQ_COMPARE: - rc = do_compare( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_COMPARE); + rc = do_compare( op, &rs ); break; case LDAP_REQ_SEARCH: - rc = do_search( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_SEARCH); + rc = do_search( op, &rs ); break; case LDAP_REQ_ABANDON: - rc = do_abandon( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_ABANDON); + rc = do_abandon( op, &rs ); break; case LDAP_REQ_EXTENDED: - rc = do_extended( conn, arg->co_op ); + INCR_OP(num_ops_initiated_, SLAP_OP_EXTENDED); + rc = do_extended( op, &rs ); break; default: #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_operation: conn %d unknown LDAP request 0x%lx\n", - conn->c_connid, tag )); + LDAP_LOG( CONNECTION, INFO, + "connection_operation: conn %lu unknown LDAP request 0x%lx\n", + conn->c_connid, tag, 0 ); #else Debug( LDAP_DEBUG_ANY, "unknown LDAP request 0x%lx\n", tag, 0, 0 ); #endif - arg->co_op->o_tag = LBER_ERROR; - send_ldap_disconnect( conn, arg->co_op, - LDAP_PROTOCOL_ERROR, "unknown LDAP request" ); + op->o_tag = LBER_ERROR; + rs.sr_err = LDAP_PROTOCOL_ERROR; + rs.sr_text = "unknown LDAP request"; + send_ldap_disconnect( op, &rs ); rc = -1; break; } +#ifdef SLAPD_MONITOR + oldtag = tag; +#endif /* SLAPD_MONITOR */ if( rc == SLAPD_DISCONNECT ) tag = LBER_ERROR; operations_error: ldap_pvt_thread_mutex_lock( &num_ops_mutex ); num_ops_completed++; +#ifdef SLAPD_MONITOR + switch (oldtag) { + case LDAP_REQ_BIND: + num_ops_completed_[SLAP_OP_BIND]++; + break; + case LDAP_REQ_UNBIND: + num_ops_completed_[SLAP_OP_UNBIND]++; + break; + case LDAP_REQ_ADD: + num_ops_completed_[SLAP_OP_ADD]++; + break; + case LDAP_REQ_DELETE: + num_ops_completed_[SLAP_OP_DELETE]++; + break; + case LDAP_REQ_MODRDN: + num_ops_completed_[SLAP_OP_MODRDN]++; + break; + case LDAP_REQ_MODIFY: + num_ops_completed_[SLAP_OP_MODIFY]++; + break; + case LDAP_REQ_COMPARE: + num_ops_completed_[SLAP_OP_COMPARE]++; + break; + case LDAP_REQ_SEARCH: + num_ops_completed_[SLAP_OP_SEARCH]++; + break; + case LDAP_REQ_ABANDON: + num_ops_completed_[SLAP_OP_ABANDON]++; + break; + case LDAP_REQ_EXTENDED: + num_ops_completed_[SLAP_OP_EXTENDED]++; + break; + } +#endif /* SLAPD_MONITOR */ ldap_pvt_thread_mutex_unlock( &num_ops_mutex ); +#ifdef LDAP_EXOP_X_CANCEL + if ( op->o_cancel == SLAP_CANCEL_REQ ) { + op->o_cancel = LDAP_TOO_LATE; + } + + while ( op->o_cancel != SLAP_CANCEL_NONE && + op->o_cancel != SLAP_CANCEL_DONE ) + { + ldap_pvt_thread_yield(); + } +#endif + ldap_pvt_thread_mutex_lock( &conn->c_mutex ); conn->c_n_ops_executing--; conn->c_n_ops_completed++; - LDAP_STAILQ_REMOVE( &conn->c_ops, arg->co_op, slap_op, o_next); - LDAP_STAILQ_NEXT(arg->co_op, o_next) = NULL; - slap_op_free( arg->co_op ); - arg->co_op = NULL; - arg->co_conn = NULL; - free( (char *) arg ); - arg = NULL; + LDAP_STAILQ_REMOVE( &conn->c_ops, op, slap_op, o_next); + LDAP_STAILQ_NEXT(op, o_next) = NULL; + +#if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC) + if ( op->o_cancel == SLAP_CANCEL_ACK ) + goto co_op_free; +#endif +#ifdef LDAP_CLIENT_UPDATE + if ( ( op->o_clientupdate_type & SLAP_LCUP_PERSIST ) ) + goto no_co_op_free; +#endif +#ifdef LDAP_SYNC + if ( ( op->o_sync_mode & SLAP_SYNC_PERSIST ) ) + goto no_co_op_free; +#endif + +co_op_free: + + ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, NULL ); + slap_op_free( op ); + +no_co_op_free: switch( tag ) { case LBER_ERROR: @@ -1027,6 +1108,7 @@ int connection_read(ber_socket_t s) { int rc = 0; Connection *c; + assert( connections != NULL ); ldap_pvt_thread_mutex_lock( &connections_mutex ); @@ -1036,9 +1118,8 @@ int connection_read(ber_socket_t s) if( c == NULL ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_read: sock %ld no connection\n", - (long)s )); + LDAP_LOG( CONNECTION, INFO, + "connection_read: sock %ld no connection\n", (long)s, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "connection_read(%ld): no connection!\n", @@ -1054,12 +1135,12 @@ int connection_read(ber_socket_t s) if( c->c_conn_state == SLAP_C_CLOSING ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_read: conn %d connection closing, ignoring input\n", - c->c_connid)); + LDAP_LOG( CONNECTION, INFO, + "connection_read: conn %lu connection closing, ignoring input\n", + c->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_read(%d): closing, ignoring input for id=%ld\n", + "connection_read(%d): closing, ignoring input for id=%lu\n", s, c->c_connid, 0 ); #endif connection_return( c ); @@ -1068,11 +1149,12 @@ int connection_read(ber_socket_t s) } #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1, - "connection_read: conn %d checking for input.\n", c->c_connid )); + LDAP_LOG( CONNECTION, DETAIL1, + "connection_read: conn %lu checking for input.\n", + c->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_read(%d): checking for input on id=%ld\n", + "connection_read(%d): checking for input on id=%lu\n", s, c->c_connid, 0 ); #endif @@ -1086,13 +1168,13 @@ int connection_read(ber_socket_t s) #endif #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_read: conn %d TLS accept error, error %d\n", - c->c_connid, rc )); + LDAP_LOG( CONNECTION, ERR, + "connection_read: conn %lu TLS accept error, error %d\n", + c->c_connid, rc, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_read(%d): TLS accept error " - "error=%d id=%ld, closing\n", + "error=%d id=%lu, closing\n", s, rc, c->c_connid ); #endif c->c_needs_tls_accept = 0; @@ -1104,38 +1186,56 @@ int connection_read(ber_socket_t s) * to propagate to client. */ FD_ZERO(&rfd); FD_SET(s, &rfd); - for (rc=1; rc>0;) - { + for (rc=1; rc>0;) { tv.tv_sec = 1; tv.tv_usec = 0; rc = select(s+1, &rfd, NULL, NULL, &tv); - if (rc == 1) - ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DRAIN, - NULL); + if (rc == 1) { + ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DRAIN, NULL); + } } #endif connection_close( c ); } else if ( rc == 0 ) { void *ssl; - char *authid; + struct berval authid = { 0, NULL }; c->c_needs_tls_accept = 0; /* we need to let SASL know */ - ssl = (void *)ldap_pvt_tls_sb_ctx( c->c_sb ); + ssl = ldap_pvt_tls_sb_ctx( c->c_sb ); c->c_tls_ssf = (slap_ssf_t) ldap_pvt_tls_get_strength( ssl ); if( c->c_tls_ssf > c->c_ssf ) { c->c_ssf = c->c_tls_ssf; } - authid = (char *)ldap_pvt_tls_get_peer( ssl ); - slap_sasl_external( c, c->c_tls_ssf, authid ); + rc = dnX509peerNormalize( ssl, &authid ); + if ( rc != LDAP_SUCCESS ) { +#ifdef NEW_LOGGING + LDAP_LOG( CONNECTION, INFO, + "connection_read: conn %lu unable to get TLS client DN, " + "error %d\n", c->c_connid, rc, 0 ); +#else + Debug( LDAP_DEBUG_TRACE, + "connection_read(%d): unable to get TLS client DN " + "error=%d id=%lu\n", + s, rc, c->c_connid ); +#endif + } + slap_sasl_external( c, c->c_tls_ssf, authid.bv_val ); + if ( authid.bv_val ) free( authid.bv_val ); + } + + /* if success and data is ready, fall thru to data input loop */ + if( rc != 0 || + !ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ) ) + { + connection_return( c ); + ldap_pvt_thread_mutex_unlock( &connections_mutex ); + return 0; } - connection_return( c ); - ldap_pvt_thread_mutex_unlock( &connections_mutex ); - return 0; } #endif @@ -1147,13 +1247,13 @@ int connection_read(ber_socket_t s) if( rc != LDAP_SUCCESS ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_read: conn %d SASL install error %d, closing\n", - c->c_connid, rc )); + LDAP_LOG( CONNECTION, ERR, + "connection_read: conn %lu SASL install error %d, closing\n", + c->c_connid, rc, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_read(%d): SASL install error " - "error=%d id=%ld, closing\n", + "error=%d id=%lu, closing\n", s, rc, c->c_connid ); #endif /* connections_mutex and c_mutex are locked */ @@ -1167,25 +1267,29 @@ int connection_read(ber_socket_t s) #endif #define CONNECTION_INPUT_LOOP 1 +/* #define DATA_READY_LOOP 1 */ -#ifdef DATA_READY_LOOP - while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_DATA_READY, NULL ) ) -#elif CONNECTION_INPUT_LOOP - while(!rc) -#endif + do { /* How do we do this without getting into a busy loop ? */ rc = connection_input( c ); } +#ifdef DATA_READY_LOOP + while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ) ); +#elif CONNECTION_INPUT_LOOP + while(!rc); +#else + while(0); +#endif if( rc < 0 ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_read: conn %d input error %d, closing.\n", - c->c_connid, rc )); + LDAP_LOG( CONNECTION, ERR, + "connection_read: conn %lu input error %d, closing.\n", + c->c_connid, rc, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_read(%d): input error=%d id=%ld, closing.\n", + "connection_read(%d): input error=%d id=%lu, closing.\n", s, rc, c->c_connid ); #endif /* connections_mutex and c_mutex are locked */ @@ -1219,16 +1323,19 @@ connection_input( ber_len_t len; ber_int_t msgid; BerElement *ber; + int rc; #ifdef LDAP_CONNECTIONLESS Sockaddr peeraddr; char *cdn = NULL; #endif - if ( conn->c_currentber == NULL && (conn->c_currentber = ber_alloc()) - == NULL ) { + if ( conn->c_currentber == NULL && + ( conn->c_currentber = ber_alloc()) == NULL ) + { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_input: conn %d ber_alloc failed.\n", conn->c_connid )); + LDAP_LOG( CONNECTION, ERR, + "connection_input: conn %lu ber_alloc failed.\n", + conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "ber_alloc failed\n", 0, 0, 0 ); #endif @@ -1238,8 +1345,7 @@ connection_input( errno = 0; #ifdef LDAP_CONNECTIONLESS - if (conn->c_is_udp) - { + if ( conn->c_is_udp ) { char peername[sizeof("IP=255.255.255.255:65336")]; len = ber_int_sb_read(conn->c_sb, &peeraddr, sizeof(struct sockaddr)); @@ -1249,9 +1355,8 @@ connection_input( inet_ntoa( peeraddr.sa_in_addr.sin_addr ), (unsigned) ntohs( peeraddr.sa_in_addr.sin_port ) ); Statslog( LDAP_DEBUG_STATS, - "conn=%ld UDP request from %s (%s) accepted.\n", - conn->c_connid, peername, - conn->c_sock_name, 0, 0 ); + "conn=%lu UDP request from %s (%s) accepted.\n", + conn->c_connid, peername, conn->c_sock_name.bv_val, 0, 0 ); } #endif tag = ber_get_next( conn->c_sb, &len, conn->c_currentber ); @@ -1262,9 +1367,9 @@ connection_input( ber_sockbuf_ctrl( conn->c_sb, LBER_SB_OPT_GET_FD, &sd ); #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_input: conn %d ber_get_next failed, errno %d (%s).\n", - conn->c_connid, err, sock_errstr(err) )); + LDAP_LOG( CONNECTION, ERR, + "connection_input: conn %lu ber_get_next failed, errno %d (%s).\n", + conn->c_connid, err, sock_errstr(err) ); #else Debug( LDAP_DEBUG_TRACE, "ber_get_next on fd %d failed errno=%d (%s)\n", @@ -1286,9 +1391,9 @@ connection_input( if ( (tag = ber_get_int( ber, &msgid )) != LDAP_TAG_MSGID ) { /* log, close and send error */ #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_input: conn %d ber_get_int returns 0x%lx.\n", - conn->c_connid, tag )); + LDAP_LOG( CONNECTION, ERR, + "connection_input: conn %lu ber_get_int returns 0x%lx.\n", + conn->c_connid, tag, 0 ); #else Debug( LDAP_DEBUG_ANY, "ber_get_int returns 0x%lx\n", tag, 0, 0 ); @@ -1300,9 +1405,9 @@ connection_input( if ( (tag = ber_peek_tag( ber, &len )) == LBER_ERROR ) { /* log, close and send error */ #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_input: conn %d ber_peek_tag returns 0x%lx.\n", - conn->c_connid, tag )); + LDAP_LOG( CONNECTION, ERR, + "connection_input: conn %lu ber_peek_tag returns 0x%lx.\n", + conn->c_connid, tag, 0 ); #else Debug( LDAP_DEBUG_ANY, "ber_peek_tag returns 0x%lx\n", tag, 0, 0 ); @@ -1313,16 +1418,16 @@ connection_input( } #ifdef LDAP_CONNECTIONLESS - if (conn->c_is_udp) { - if (tag == LBER_OCTETSTRING) { + if( conn->c_is_udp ) { + if( tag == LBER_OCTETSTRING ) { ber_get_stringa( ber, &cdn ); tag = ber_peek_tag(ber, &len); } - if (tag != LDAP_REQ_ABANDON && tag != LDAP_REQ_SEARCH) { + if( tag != LDAP_REQ_ABANDON && tag != LDAP_REQ_SEARCH ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_input: conn %d invalid req for UDP 0x%lx.\n", - conn->c_connid, tag )); + LDAP_LOG( CONNECTION, ERR, + "connection_input: conn %lu invalid req for UDP 0x%lx.\n", + conn->c_connid, tag, 0 ); #else Debug( LDAP_DEBUG_ANY, "invalid req for UDP 0x%lx\n", tag, 0, 0 ); @@ -1339,29 +1444,83 @@ connection_input( op = slap_op_alloc( ber, msgid, tag, conn->c_n_ops_received++ ); + op->o_conn = conn; + op->vrFilter = NULL; +#ifdef LDAP_CONTROL_PAGEDRESULTS + op->o_pagedresults_state = conn->c_pagedresults_state; +#endif #ifdef LDAP_CONNECTIONLESS - op->o_peeraddr = peeraddr; - if (cdn) { - op->o_dn = cdn; - op->o_protocol = LDAP_VERSION2; - } + if (conn->c_is_udp) { + + if ( cdn ) { + ber_str2bv( cdn, 0, 1, &op->o_dn ); + op->o_protocol = LDAP_VERSION2; + } + op->o_res_ber = ber_alloc_t( LBER_USE_DER ); + if (op->o_res_ber == NULL) + return 1; + + rc = ber_write(op->o_res_ber, (char *)&peeraddr, sizeof(struct sockaddr), 0); + if (rc != sizeof(struct sockaddr)) { +#ifdef NEW_LOGGING + LDAP_LOG( CONNECTION, INFO, + "connection_input: conn %lu ber_write failed\n", + conn->c_connid, 0, 0 ); +#else + Debug( LDAP_DEBUG_ANY, "ber_write failed\n", 0, 0, 0 ); #endif + return 1; + } + + if (op->o_protocol == LDAP_VERSION2) { + rc = ber_printf(op->o_res_ber, "{is{" /*}}*/, op->o_msgid, ""); + if (rc == -1) { +#ifdef NEW_LOGGING + LDAP_LOG( CONNECTION, INFO, + "connection_input: conn %lu put outer sequence failed\n", + conn->c_connid, 0, 0 ); +#else + Debug( LDAP_DEBUG_ANY, "ber_write failed\n", 0, 0, 0 ); +#endif + return rc; + } + } + } +#endif /* LDAP_CONNECTIONLESS */ + + rc = 0; + + /* Don't process requests when the conn is in the middle of a + * Bind, or if it's closing. Also, don't let any single conn + * use up all the available threads, and don't execute if we're + * currently blocked on output. And don't execute if there are + * already pending ops, let them go first. + */ if ( conn->c_conn_state == SLAP_C_BINDING - || conn->c_conn_state == SLAP_C_CLOSING ) + || conn->c_conn_state == SLAP_C_CLOSING + || conn->c_n_ops_executing >= connection_pool_max/2 + || conn->c_n_ops_pending + || conn->c_writewaiter) { + int max = conn->c_dn.bv_len ? slap_conn_max_pending_auth + : slap_conn_max_pending; #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_input: conn %d deferring operation\n", - conn->c_connid )); + LDAP_LOG( CONNECTION, INFO, + "connection_input: conn %lu deferring operation\n", + conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "deferring operation\n", 0, 0, 0 ); #endif conn->c_n_ops_pending++; LDAP_STAILQ_INSERT_TAIL( &conn->c_pending_ops, op, o_next ); - + if ( conn->c_n_ops_pending > max ) { + rc = -1; + } else { + rc = 1; + } } else { conn->c_n_ops_executing++; - connection_op_activate( conn, op ); + connection_op_activate( op ); } #ifdef NO_THREADS @@ -1372,7 +1531,7 @@ connection_input( #endif assert( conn->c_struct_state == SLAP_C_USED ); - return 0; + return rc; } static int @@ -1390,12 +1549,12 @@ connection_resched( Connection *conn ) if( rc ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1, - "connection_resched: conn %d reaquiring locks.\n", - conn->c_connid )); + LDAP_LOG( CONNECTION, DETAIL1, + "connection_resched: conn %lu reaquiring locks.\n", + conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_resched: reaquiring locks conn=%ld sd=%d\n", + "connection_resched: reaquiring locks conn=%lu sd=%d\n", conn->c_connid, sd, 0 ); #endif /* @@ -1410,22 +1569,22 @@ connection_resched( Connection *conn ) if( conn->c_conn_state != SLAP_C_CLOSING ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_INFO, - "connection_resched: conn %d closed by other thread.\n", - conn->c_connid )); + LDAP_LOG( CONNECTION, INFO, + "connection_resched: conn %lu closed by other thread.\n", + conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_resched: " - "closed by other thread conn=%ld sd=%d\n", + "closed by other thread conn=%lu sd=%d\n", conn->c_connid, sd, 0 ); #endif } else { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1, - "connection_resched: conn %d attempting closing.\n", - conn->c_connid )); + LDAP_LOG( CONNECTION, DETAIL1, + "connection_resched: conn %lu attempting closing.\n", + conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_resched: " - "attempting closing conn=%ld sd=%d\n", + "attempting closing conn=%lu sd=%d\n", conn->c_connid, sd, 0 ); #endif connection_close( conn ); @@ -1435,12 +1594,15 @@ connection_resched( Connection *conn ) return 0; } - if( conn->c_conn_state != SLAP_C_ACTIVE ) { + if( conn->c_conn_state != SLAP_C_ACTIVE || conn->c_writewaiter ) { /* other states need different handling */ return 0; } while ((op = LDAP_STAILQ_FIRST( &conn->c_pending_ops )) != NULL) { + if ( conn->c_n_ops_executing > connection_pool_max/2 ) { + break; + } LDAP_STAILQ_REMOVE_HEAD( &conn->c_pending_ops, o_next ); LDAP_STAILQ_NEXT(op, o_next) = NULL; /* pending operations should not be marked for abandonment */ @@ -1449,7 +1611,7 @@ connection_resched( Connection *conn ) conn->c_n_ops_pending--; conn->c_n_ops_executing++; - connection_op_activate( conn, op ); + connection_op_activate( op ); if ( conn->c_conn_state == SLAP_C_BINDING ) { break; @@ -1458,46 +1620,44 @@ connection_resched( Connection *conn ) return 0; } -static int connection_op_activate( Connection *conn, Operation *op ) +static int connection_op_activate( Operation *op ) { - struct co_arg *arg; int status; ber_tag_t tag = op->o_tag; if(tag == LDAP_REQ_BIND) { - conn->c_conn_state = SLAP_C_BINDING; + op->o_conn->c_conn_state = SLAP_C_BINDING; } - arg = (struct co_arg *) ch_malloc( sizeof(struct co_arg) ); - arg->co_conn = conn; - arg->co_op = op; - - if (!arg->co_op->o_dn.bv_len) { - arg->co_op->o_authz = conn->c_authz; - arg->co_op->o_dn.bv_val = ch_strdup( conn->c_dn.bv_val ? - conn->c_dn.bv_val : "" ); - arg->co_op->o_ndn.bv_val = ch_strdup( conn->c_ndn.bv_val ? - conn->c_ndn.bv_val : "" ); + if (!op->o_dn.bv_len) { + op->o_authz = op->o_conn->c_authz; + ber_dupbv( &op->o_dn, &op->o_conn->c_dn ); + ber_dupbv( &op->o_ndn, &op->o_conn->c_ndn ); } - arg->co_op->o_authtype = conn->c_authtype; - ber_dupbv( &arg->co_op->o_authmech, &conn->c_authmech ); + op->o_authtype = op->o_conn->c_authtype; + ber_dupbv( &op->o_authmech, &op->o_conn->c_authmech ); - if (!arg->co_op->o_protocol) { - arg->co_op->o_protocol = conn->c_protocol - ? conn->c_protocol : LDAP_VERSION3; + if (!op->o_protocol) { + op->o_protocol = op->o_conn->c_protocol + ? op->o_conn->c_protocol : LDAP_VERSION3; + } + if (op->o_conn->c_conn_state == SLAP_C_INACTIVE + && op->o_protocol > LDAP_VERSION2) { + op->o_conn->c_conn_state = SLAP_C_ACTIVE; } - arg->co_op->o_connid = conn->c_connid; - LDAP_STAILQ_INSERT_TAIL( &conn->c_ops, arg->co_op, o_next ); + op->o_connid = op->o_conn->c_connid; + + LDAP_STAILQ_INSERT_TAIL( &op->o_conn->c_ops, op, o_next ); status = ldap_pvt_thread_pool_submit( &connection_pool, - connection_operation, (void *) arg ); + connection_operation, (void *) op ); if ( status != 0 ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_op_activate: conn %d thread pool submit failed.\n", - conn->c_connid )); + LDAP_LOG( CONNECTION, ERR, + "connection_op_activate: conn %lu thread pool submit failed.\n", + op->o_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "ldap_pvt_thread_pool_submit failed (%d)\n", status, 0, 0 ); @@ -1511,6 +1671,7 @@ static int connection_op_activate( Connection *conn, Operation *op ) int connection_write(ber_socket_t s) { Connection *c; + assert( connections != NULL ); ldap_pvt_thread_mutex_lock( &connections_mutex ); @@ -1521,8 +1682,8 @@ int connection_write(ber_socket_t s) if( c == NULL ) { #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_ERR, - "connection_write: sock %ld no connection!\n",(long)s)); + LDAP_LOG( CONNECTION, ERR, + "connection_write: sock %ld no connection!\n", (long)s, 0, 0); #else Debug( LDAP_DEBUG_ANY, "connection_write(%ld): no connection!\n", @@ -1536,12 +1697,11 @@ int connection_write(ber_socket_t s) c->c_n_write++; #ifdef NEW_LOGGING - LDAP_LOG(( "connection", LDAP_LEVEL_DETAIL1, - "connection_write conn %d waking output.\n", - c->c_connid )); + LDAP_LOG( CONNECTION, DETAIL1, + "connection_write conn %lu waking output.\n", c->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, - "connection_write(%d): waking output for id=%ld\n", + "connection_write(%d): waking output for id=%lu\n", s, c->c_connid, 0 ); #endif ldap_pvt_thread_cond_signal( &c->c_write_cv );