X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fconnection.c;h=d7a87ee02725d06a39163bd85e0298830e617aee;hb=49fac602e138e36ee43e3e58c753e743d6e99e22;hp=20da8a2e5cbbf9d14e759e065178bc0d76e75797;hpb=0423ec0bd613c97fcbe9610fcc241aab3ee769ad;p=openldap diff --git a/servers/slapd/connection.c b/servers/slapd/connection.c index 20da8a2e5c..d7a87ee027 100644 --- a/servers/slapd/connection.c +++ b/servers/slapd/connection.c @@ -1,7 +1,26 @@ /* $OpenLDAP$ */ -/* - * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved. - * COPYING RESTRICTIONS APPLY, see COPYRIGHT file +/* This work is part of OpenLDAP Software . + * + * Copyright 1998-2004 The OpenLDAP Foundation. + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted only as authorized by the OpenLDAP + * Public License. + * + * A copy of this license is available in the file LICENSE in the + * top-level directory of the distribution or, alternatively, at + * . + */ +/* Portions Copyright (c) 1995 Regents of the University of Michigan. + * All rights reserved. + * + * Redistribution and use in source and binary forms are permitted + * provided that this notice is preserved and that due credit is given + * to the University of Michigan at Ann Arbor. The name of the University + * may not be used to endorse or promote products derived from this + * software without specific prior written permission. This software + * is provided ``as is'' without express or implied warranty. */ #include "portable.h" @@ -19,9 +38,15 @@ #include "lutil.h" #include "slap.h" +#ifdef LDAP_SLAPI +#include "slapi/slapi.h" +#endif + /* protected by connections_mutex */ static ldap_pvt_thread_mutex_t connections_mutex; static Connection *connections = NULL; + +static ldap_pvt_thread_mutex_t conn_nextid_mutex; static unsigned long conn_nextid = 0; /* structure state (protected by connections_mutex) */ @@ -35,16 +60,18 @@ static unsigned long conn_nextid = 0; #define SLAP_C_ACTIVE 0x02 /* one or more threads */ #define SLAP_C_BINDING 0x03 /* binding */ #define SLAP_C_CLOSING 0x04 /* closing */ +#define SLAP_C_CLIENT 0x05 /* outbound client conn */ const char * connection_state2str( int state ) { switch( state ) { - case SLAP_C_INVALID: return "!"; - case SLAP_C_INACTIVE: return "|"; - case SLAP_C_ACTIVE: return ""; + case SLAP_C_INVALID: return "!"; + case SLAP_C_INACTIVE: return "|"; + case SLAP_C_ACTIVE: return ""; case SLAP_C_BINDING: return "B"; - case SLAP_C_CLOSING: return "C"; + case SLAP_C_CLOSING: return "C"; + case SLAP_C_CLIENT: return "L"; } return "?"; @@ -55,29 +82,26 @@ static Connection* connection_get( ber_socket_t s ); static int connection_input( Connection *c ); static void connection_close( Connection *c ); -static int connection_op_activate( Connection *conn, Operation *op ); +static int connection_op_activate( Operation *op ); static int connection_resched( Connection *conn ); static void connection_abandon( Connection *conn ); static void connection_destroy( Connection *c ); static ldap_pvt_thread_start_t connection_operation; -struct co_arg { - Connection *co_conn; - Operation *co_op; -}; - /* * Initialize connection management infrastructure. */ int connections_init(void) { + int i; + assert( connections == NULL ); if( connections != NULL) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, INFO, - "connections_init: already initialized.\n", 0, 0, 0 ); + "connections_init: already initialized.\n", 0, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "connections_init: already initialized.\n", 0, 0, 0 ); @@ -87,14 +111,15 @@ int connections_init(void) /* should check return of every call */ ldap_pvt_thread_mutex_init( &connections_mutex ); + ldap_pvt_thread_mutex_init( &conn_nextid_mutex ); - connections = (Connection *) calloc( dtblsize, sizeof(Connection) ); + connections = (Connection *) ch_calloc( dtblsize, sizeof(Connection) ); if( connections == NULL ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connections_init: allocation (%d * %ld) of connection " - "array failed\n", dtblsize, (long) sizeof(Connection), 0 ); + "connections_init: allocation (%d * %ld) of connection " + "array failed\n", dtblsize, (long) sizeof(Connection), 0 ); #else Debug( LDAP_DEBUG_ANY, "connections_init: allocation (%d*%ld) of connection array failed\n", @@ -103,8 +128,10 @@ int connections_init(void) return -1; } - assert( connections[0].c_struct_state == SLAP_C_UNINITIALIZED ); - assert( connections[dtblsize-1].c_struct_state == SLAP_C_UNINITIALIZED ); + assert( connections[0].c_struct_state == SLAP_C_UNINITIALIZED ); + assert( connections[dtblsize-1].c_struct_state == SLAP_C_UNINITIALIZED ); + + for (i=0; ic_n_ops_executing || + c->c_conn_state == SLAP_C_CLIENT ) continue; + if( difftime( c->c_activitytime+global_idletimeout, now) < 0 ) { /* close it */ connection_closing( c ); @@ -275,7 +319,7 @@ static Connection* connection_get( ber_socket_t s ) #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ARGS, - "connection_get: connection %d not used\n", s, 0, 0 ); + "connection_get: connection %d not used\n", s, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_get(%d): connection not used\n", @@ -323,9 +367,9 @@ long connection_init( Listener *listener, const char* dnsname, const char* peername, - int tls_udp_option, + int flags, slap_ssf_t ssf, - const char *authid ) + struct berval *authid ) { unsigned long id; Connection *c; @@ -337,17 +381,16 @@ long connection_init( assert( peername != NULL ); #ifndef HAVE_TLS - assert( tls_udp_option != 1 ); + assert( flags != CONN_IS_TLS ); #endif if( s == AC_SOCKET_INVALID ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, INFO, - "connection_init: init of socket %ld invalid.\n", (long)s, 0, 0 ); + "connection_init: init of socket %ld invalid.\n", (long)s, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, - "connection_init(%ld): invalid.\n", - (long) s, 0, 0 ); + "connection_init: init of socket %ld invalid.\n", (long)s, 0, 0 ); #endif return -1; } @@ -364,48 +407,53 @@ long connection_init( #else { - ber_socket_t i; - + ber_socket_t i; c = NULL; - for( i=0; i < dtblsize; i++) { - ber_socket_t sd; + for( i=0; i < dtblsize; i++) { + ber_socket_t sd; - if( connections[i].c_struct_state == SLAP_C_UNINITIALIZED ) { - assert( connections[i].c_sb == 0 ); - c = &connections[i]; - break; - } + if( connections[i].c_struct_state == SLAP_C_UNINITIALIZED ) { + assert( connections[i].c_sb == 0 ); + c = &connections[i]; + break; + } sd = AC_SOCKET_INVALID; - if (connections[i].c_sb != NULL) - ber_sockbuf_ctrl( connections[i].c_sb, LBER_SB_OPT_GET_FD, &sd ); - - if( connections[i].c_struct_state == SLAP_C_UNUSED ) { - assert( sd == AC_SOCKET_INVALID ); - c = &connections[i]; - break; - } + if (connections[i].c_sb != NULL) { + ber_sockbuf_ctrl( connections[i].c_sb, + LBER_SB_OPT_GET_FD, &sd ); + } - assert( connections[i].c_struct_state == SLAP_C_USED ); - assert( connections[i].c_conn_state != SLAP_C_INVALID ); - assert( sd != AC_SOCKET_INVALID ); - } + if( connections[i].c_struct_state == SLAP_C_UNUSED ) { + assert( sd == AC_SOCKET_INVALID ); + c = &connections[i]; + break; + } - if( c == NULL ) { + if( connections[i].c_conn_state == SLAP_C_CLIENT ) { + continue; + } + + assert( connections[i].c_struct_state == SLAP_C_USED ); + assert( connections[i].c_conn_state != SLAP_C_INVALID ); + assert( sd != AC_SOCKET_INVALID ); + } + + if( c == NULL ) { #ifdef NEW_LOGGING - LDAP_LOG( CONNECTION, INFO, - "connection_init: skt %d connection table full " - "(%d/%d)\n", s, i, dtblsize ); + LDAP_LOG( CONNECTION, INFO, + "connection_init(%d): connection table full " + "(%d/%d)\n", s, i, dtblsize ); #else - Debug( LDAP_DEBUG_ANY, + Debug( LDAP_DEBUG_ANY, "connection_init(%d): connection table full " "(%d/%d)\n", s, i, dtblsize); #endif - ldap_pvt_thread_mutex_unlock( &connections_mutex ); - return -1; + ldap_pvt_thread_mutex_unlock( &connections_mutex ); + return -1; + } } - } #endif assert( c != NULL ); @@ -413,11 +461,10 @@ long connection_init( if( c->c_struct_state == SLAP_C_UNINITIALIZED ) { c->c_send_ldap_result = slap_send_ldap_result; c->c_send_search_entry = slap_send_search_entry; - c->c_send_search_result = slap_send_search_result; c->c_send_search_reference = slap_send_search_reference; c->c_send_ldap_extended = slap_send_ldap_extended; -#ifdef LDAP_RES_INTERMEDIATE_RESP - c->c_send_ldap_intermediate_resp = slap_send_ldap_intermediate_resp; +#ifdef LDAP_RES_INTERMEDIATE + c->c_send_ldap_intermediate = slap_send_ldap_intermediate; #endif c->c_authmech.bv_val = NULL; @@ -426,7 +473,6 @@ long connection_init( c->c_dn.bv_len = 0; c->c_ndn.bv_val = NULL; c->c_ndn.bv_len = 0; - c->c_groups = NULL; c->c_listener = NULL; c->c_peer_domain.bv_val = NULL; @@ -439,7 +485,9 @@ long connection_init( c->c_sasl_bind_mech.bv_val = NULL; c->c_sasl_bind_mech.bv_len = 0; - c->c_sasl_context = NULL; + c->c_sasl_done = 0; + c->c_sasl_authctx = NULL; + c->c_sasl_sockctx = NULL; c->c_sasl_extra = NULL; c->c_sasl_bindop = NULL; @@ -457,35 +505,54 @@ long connection_init( ldap_pvt_thread_mutex_init( &c->c_write_mutex ); ldap_pvt_thread_cond_init( &c->c_write_cv ); +#ifdef LDAP_SLAPI + if ( slapi_plugins_used ) { + slapi_int_create_object_extensions( SLAPI_X_EXT_CONNECTION, c ); + } +#endif + c->c_struct_state = SLAP_C_UNUSED; } - ldap_pvt_thread_mutex_lock( &c->c_mutex ); + ldap_pvt_thread_mutex_lock( &c->c_mutex ); - assert( c->c_struct_state == SLAP_C_UNUSED ); - assert( c->c_authmech.bv_val == NULL ); - assert( c->c_dn.bv_val == NULL ); - assert( c->c_ndn.bv_val == NULL ); - assert( c->c_groups == NULL ); - assert( c->c_listener == NULL ); - assert( c->c_peer_domain.bv_val == NULL ); - assert( c->c_peer_name.bv_val == NULL ); - assert( LDAP_STAILQ_EMPTY(&c->c_ops) ); - assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) ); + assert( c->c_struct_state == SLAP_C_UNUSED ); + assert( c->c_authmech.bv_val == NULL ); + assert( c->c_dn.bv_val == NULL ); + assert( c->c_ndn.bv_val == NULL ); + assert( c->c_listener == NULL ); + assert( c->c_peer_domain.bv_val == NULL ); + assert( c->c_peer_name.bv_val == NULL ); + assert( LDAP_STAILQ_EMPTY(&c->c_ops) ); + assert( LDAP_STAILQ_EMPTY(&c->c_pending_ops) ); assert( c->c_sasl_bind_mech.bv_val == NULL ); - assert( c->c_sasl_context == NULL ); + assert( c->c_sasl_done == 0 ); + assert( c->c_sasl_authctx == NULL ); + assert( c->c_sasl_sockctx == NULL ); assert( c->c_sasl_extra == NULL ); assert( c->c_sasl_bindop == NULL ); assert( c->c_currentber == NULL ); + assert( c->c_writewaiter == 0); c->c_listener = listener; + + if ( flags == CONN_IS_CLIENT ) { + c->c_conn_state = SLAP_C_CLIENT; + c->c_struct_state = SLAP_C_USED; + ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_FD, &s ); + ldap_pvt_thread_mutex_unlock( &c->c_mutex ); + ldap_pvt_thread_mutex_unlock( &connections_mutex ); + + return 0; + } + ber_str2bv( dnsname, 0, 1, &c->c_peer_domain ); ber_str2bv( peername, 0, 1, &c->c_peer_name ); - c->c_n_ops_received = 0; - c->c_n_ops_executing = 0; - c->c_n_ops_pending = 0; - c->c_n_ops_completed = 0; + c->c_n_ops_received = 0; + c->c_n_ops_executing = 0; + c->c_n_ops_pending = 0; + c->c_n_ops_completed = 0; c->c_n_get = 0; c->c_n_read = 0; @@ -504,7 +571,7 @@ long connection_init( #ifdef LDAP_CONNECTIONLESS c->c_is_udp = 0; - if( tls_udp_option == 2 ) { + if( flags == CONN_IS_UDP ) { c->c_is_udp = 1; #ifdef LDAP_DEBUG ber_sockbuf_add_io( c->c_sb, &ber_sockbuf_io_debug, @@ -535,8 +602,8 @@ long connection_init( { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, INFO, - "connection_init: conn %lu set nonblocking failed\n", - c->c_connid, 0, 0 ); + "connection_init: conn %lu set nonblocking failed\n", + c->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "connection_init(%d, %s): set nonblocking failed\n", @@ -544,33 +611,35 @@ long connection_init( #endif } - id = c->c_connid = conn_nextid++; + ldap_pvt_thread_mutex_lock( &conn_nextid_mutex ); + id = c->c_connid = conn_nextid++; + ldap_pvt_thread_mutex_unlock( &conn_nextid_mutex ); - c->c_conn_state = SLAP_C_INACTIVE; - c->c_struct_state = SLAP_C_USED; + c->c_conn_state = SLAP_C_INACTIVE; + c->c_struct_state = SLAP_C_USED; c->c_ssf = c->c_transport_ssf = ssf; c->c_tls_ssf = 0; #ifdef HAVE_TLS - if ( tls_udp_option == 1 ) { - c->c_is_tls = 1; - c->c_needs_tls_accept = 1; - } else { - c->c_is_tls = 0; - c->c_needs_tls_accept = 0; - } + if ( flags == CONN_IS_TLS ) { + c->c_is_tls = 1; + c->c_needs_tls_accept = 1; + } else { + c->c_is_tls = 0; + c->c_needs_tls_accept = 0; + } #endif - slap_sasl_open( c ); + slap_sasl_open( c, 0 ); slap_sasl_external( c, ssf, authid ); - ldap_pvt_thread_mutex_unlock( &c->c_mutex ); - ldap_pvt_thread_mutex_unlock( &connections_mutex ); + ldap_pvt_thread_mutex_unlock( &c->c_mutex ); + ldap_pvt_thread_mutex_unlock( &connections_mutex ); - backend_connection_init(c); + backend_connection_init(c); - return id; + return id; } void connection2anonymous( Connection *c ) @@ -601,39 +670,31 @@ void connection2anonymous( Connection *c ) c->c_ndn.bv_len = 0; c->c_authz_backend = NULL; - - { - GroupAssertion *g, *n; - for (g = c->c_groups; g; g=n) { - n = g->ga_next; - free(g); - } - c->c_groups = NULL; - } } static void connection_destroy( Connection *c ) { /* note: connections_mutex should be locked by caller */ - ber_socket_t sd; - unsigned long connid; + ber_socket_t sd; + unsigned long connid; - assert( connections != NULL ); - assert( c != NULL ); - assert( c->c_struct_state != SLAP_C_UNUSED ); - assert( c->c_conn_state != SLAP_C_INVALID ); - assert( LDAP_STAILQ_EMPTY(&c->c_ops) ); + assert( connections != NULL ); + assert( c != NULL ); + assert( c->c_struct_state != SLAP_C_UNUSED ); + assert( c->c_conn_state != SLAP_C_INVALID ); + assert( LDAP_STAILQ_EMPTY(&c->c_ops) ); + assert( c->c_writewaiter == 0); - /* only for stats (print -1 as "%lu" may give unexpected results ;) */ - connid = c->c_connid; + /* only for stats (print -1 as "%lu" may give unexpected results ;) */ + connid = c->c_connid; - backend_connection_destroy(c); + backend_connection_destroy(c); - c->c_protocol = 0; - c->c_connid = -1; + c->c_protocol = 0; + c->c_connid = -1; - c->c_activitytime = c->c_starttime = 0; + c->c_activitytime = c->c_starttime = 0; connection2anonymous( c ); c->c_listener = NULL; @@ -665,11 +726,11 @@ connection_destroy( Connection *c ) ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd ); if ( sd != AC_SOCKET_INVALID ) { - slapd_remove( sd, 0 ); + slapd_remove( sd, 1, 0 ); Statslog( LDAP_DEBUG_STATS, - "conn=%lu fd=%d closed\n", - connid, sd, 0, 0, 0 ); + "conn=%lu fd=%ld closed\n", + connid, (long) sd, 0, 0, 0 ); } ber_sockbuf_free( c->c_sb ); @@ -681,8 +742,15 @@ connection_destroy( Connection *c ) ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_SET_MAX_INCOMING, &max ); } - c->c_conn_state = SLAP_C_INVALID; - c->c_struct_state = SLAP_C_UNUSED; + c->c_conn_state = SLAP_C_INVALID; + c->c_struct_state = SLAP_C_UNUSED; + +#ifdef LDAP_SLAPI + /* call destructors, then constructors; avoids unnecessary allocation */ + if ( slapi_plugins_used ) { + slapi_int_clear_object_extensions( SLAPI_X_EXT_CONNECTION, c ); + } +#endif } int connection_state_closing( Connection *c ) @@ -733,8 +801,8 @@ void connection_closing( Connection *c ) ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_GET_FD, &sd ); #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, DETAIL1, - "connection_closing: conn %lu readying socket %d for close.\n", - c->c_connid, sd, 0 ); + "connection_closing: conn %lu readying socket %d for close.\n", + c->c_connid, sd, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_closing: readying conn=%lu sd=%d for close\n", @@ -770,8 +838,8 @@ static void connection_close( Connection *c ) if( !LDAP_STAILQ_EMPTY(&c->c_ops) ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, DETAIL1, - "connection_close: conn %lu deferring sd %d\n", - c->c_connid, sd, 0 ); + "connection_close: conn %lu deferring sd %d\n", + c->c_connid, sd, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_close: deferring conn=%lu sd=%d\n", @@ -782,7 +850,7 @@ static void connection_close( Connection *c ) #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, RESULTS, - "connection_close: conn %lu sd %d\n", c->c_connid, sd, 0 ); + "connection_close: conn %lu sd %d\n", c->c_connid, sd, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_close: conn=%lu sd=%d\n", c->c_connid, sd, 0 ); @@ -886,19 +954,53 @@ void connection_done( Connection *c ) static void * connection_operation( void *ctx, void *arg_v ) { - int rc; - struct co_arg *arg = arg_v; - ber_tag_t tag = arg->co_op->o_tag; + int rc = LDAP_OTHER; + Operation *op = arg_v; + SlapReply rs = {REP_RESULT}; + ber_tag_t tag = op->o_tag; #ifdef SLAPD_MONITOR ber_tag_t oldtag = tag; #endif /* SLAPD_MONITOR */ - Connection *conn = arg->co_conn; + Connection *conn = op->o_conn; + void *memctx = NULL; + void *memctx_null = NULL; + ber_len_t memsiz; ldap_pvt_thread_mutex_lock( &num_ops_mutex ); num_ops_initiated++; ldap_pvt_thread_mutex_unlock( &num_ops_mutex ); - arg->co_op->o_threadctx = ctx; + op->o_threadctx = ctx; + + switch ( tag ) { + case LDAP_REQ_BIND: + case LDAP_REQ_UNBIND: + case LDAP_REQ_ADD: + case LDAP_REQ_DELETE: + case LDAP_REQ_MODRDN: + case LDAP_REQ_MODIFY: + case LDAP_REQ_COMPARE: + case LDAP_REQ_SEARCH: + case LDAP_REQ_ABANDON: + case LDAP_REQ_EXTENDED: + break; + default: +#ifdef NEW_LOGGING + LDAP_LOG( CONNECTION, INFO, "connection_operation: " + "conn %lu unknown LDAP request 0x%lx\n", + conn->c_connid, tag, 0 ); +#else + Debug( LDAP_DEBUG_ANY, "connection_operation: " + "conn %lu unknown LDAP request 0x%lx\n", + conn->c_connid, tag, 0 ); +#endif + op->o_tag = LBER_ERROR; + rs.sr_err = LDAP_PROTOCOL_ERROR; + rs.sr_text = "unknown LDAP request"; + send_ldap_disconnect( op, &rs ); + rc = SLAPD_DISCONNECT; + goto operations_error; + } if( conn->c_sasl_bind_in_progress && tag != LDAP_REQ_BIND ) { #ifdef NEW_LOGGING @@ -910,86 +1012,93 @@ connection_operation( void *ctx, void *arg_v ) "error: SASL bind in progress (tag=%ld).\n", (long) tag, 0, 0 ); #endif - send_ldap_result( conn, arg->co_op, - rc = LDAP_OPERATIONS_ERROR, - NULL, "SASL bind in progress", NULL, NULL ); + send_ldap_error( op, &rs, LDAP_OPERATIONS_ERROR, + "SASL bind in progress" ); + rc = LDAP_OPERATIONS_ERROR; goto operations_error; } + /* We can use Thread-Local storage for most mallocs. We can + * also use TL for ber parsing, but not on Add or Modify. + */ +#if 0 + memsiz = ber_len( op->o_ber ) * 64; + if ( SLMALLOC_SLAB_SIZE > memsiz ) memsiz = SLMALLOC_SLAB_SIZE; +#endif + memsiz = SLMALLOC_SLAB_SIZE; + + memctx = sl_mem_create( memsiz, ctx ); + op->o_tmpmemctx = memctx; + op->o_tmpmfuncs = &sl_mfuncs; + if ( tag != LDAP_REQ_ADD && tag != LDAP_REQ_MODIFY ) { + /* Note - the ber and its buffer are already allocated from + * regular memory; this only affects subsequent mallocs that + * ber_scanf may invoke. + */ + ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, &memctx ); + } + switch ( tag ) { case LDAP_REQ_BIND: INCR_OP(num_ops_initiated_, SLAP_OP_BIND); - rc = do_bind( conn, arg->co_op ); + rc = do_bind( op, &rs ); break; case LDAP_REQ_UNBIND: INCR_OP(num_ops_initiated_, SLAP_OP_UNBIND); - rc = do_unbind( conn, arg->co_op ); + rc = do_unbind( op, &rs ); break; case LDAP_REQ_ADD: INCR_OP(num_ops_initiated_, SLAP_OP_ADD); - rc = do_add( conn, arg->co_op ); + rc = do_add( op, &rs ); break; case LDAP_REQ_DELETE: INCR_OP(num_ops_initiated_, SLAP_OP_DELETE); - rc = do_delete( conn, arg->co_op ); + rc = do_delete( op, &rs ); break; case LDAP_REQ_MODRDN: INCR_OP(num_ops_initiated_, SLAP_OP_MODRDN); - rc = do_modrdn( conn, arg->co_op ); + rc = do_modrdn( op, &rs ); break; case LDAP_REQ_MODIFY: INCR_OP(num_ops_initiated_, SLAP_OP_MODIFY); - rc = do_modify( conn, arg->co_op ); + rc = do_modify( op, &rs ); break; case LDAP_REQ_COMPARE: INCR_OP(num_ops_initiated_, SLAP_OP_COMPARE); - rc = do_compare( conn, arg->co_op ); + rc = do_compare( op, &rs ); break; case LDAP_REQ_SEARCH: INCR_OP(num_ops_initiated_, SLAP_OP_SEARCH); - rc = do_search( conn, arg->co_op ); + rc = do_search( op, &rs ); break; case LDAP_REQ_ABANDON: INCR_OP(num_ops_initiated_, SLAP_OP_ABANDON); - rc = do_abandon( conn, arg->co_op ); + rc = do_abandon( op, &rs ); break; case LDAP_REQ_EXTENDED: INCR_OP(num_ops_initiated_, SLAP_OP_EXTENDED); - rc = do_extended( conn, arg->co_op ); + rc = do_extended( op, &rs ); break; default: -#ifdef NEW_LOGGING - LDAP_LOG( CONNECTION, INFO, - "connection_operation: conn %lu unknown LDAP request 0x%lx\n", - conn->c_connid, tag, 0 ); -#else - Debug( LDAP_DEBUG_ANY, "unknown LDAP request 0x%lx\n", - tag, 0, 0 ); -#endif - arg->co_op->o_tag = LBER_ERROR; - send_ldap_disconnect( conn, arg->co_op, - LDAP_PROTOCOL_ERROR, "unknown LDAP request" ); - rc = -1; - break; + /* not reachable */ + assert( 0 ); } -#ifdef SLAPD_MONITOR - oldtag = tag; -#endif /* SLAPD_MONITOR */ +operations_error: if( rc == SLAPD_DISCONNECT ) tag = LBER_ERROR; -operations_error: ldap_pvt_thread_mutex_lock( &num_ops_mutex ); + num_ops_completed++; #ifdef SLAPD_MONITOR switch (oldtag) { @@ -1023,53 +1132,45 @@ operations_error: case LDAP_REQ_EXTENDED: num_ops_completed_[SLAP_OP_EXTENDED]++; break; + default: + /* not reachable */ + assert( 0 ); } #endif /* SLAPD_MONITOR */ ldap_pvt_thread_mutex_unlock( &num_ops_mutex ); -#ifdef LDAP_EXOP_X_CANCEL - if ( arg->co_op->o_cancel == SLAP_CANCEL_REQ ) { - arg->co_op->o_cancel = LDAP_TOO_LATE; + if ( op->o_cancel == SLAP_CANCEL_REQ ) { + op->o_cancel = LDAP_TOO_LATE; } - - while ( arg->co_op->o_cancel != SLAP_CANCEL_NONE && - arg->co_op->o_cancel != SLAP_CANCEL_DONE ) + while ( op->o_cancel != SLAP_CANCEL_NONE && + op->o_cancel != SLAP_CANCEL_DONE ) { ldap_pvt_thread_yield(); } -#endif ldap_pvt_thread_mutex_lock( &conn->c_mutex ); - conn->c_n_ops_executing--; - conn->c_n_ops_completed++; - - LDAP_STAILQ_REMOVE( &conn->c_ops, arg->co_op, slap_op, o_next); - LDAP_STAILQ_NEXT(arg->co_op, o_next) = NULL; - -#if defined(LDAP_CLIENT_UPDATE) || defined(LDAP_SYNC) - if ( arg->co_op->o_cancel == SLAP_CANCEL_ACK ) - goto co_op_free; -#endif -#ifdef LDAP_CLIENT_UPDATE - if ( ( arg->co_op->o_clientupdate_type & SLAP_LCUP_PERSIST ) ) - goto no_co_op_free; -#endif -#ifdef LDAP_SYNC - if ( ( arg->co_op->o_sync_mode & SLAP_SYNC_PERSIST ) ) - goto no_co_op_free; -#endif - -co_op_free: + ber_set_option( op->o_ber, LBER_OPT_BER_MEMCTX, &memctx_null ); - slap_op_free( arg->co_op ); + if ( op->o_cancel != SLAP_CANCEL_ACK && + ( op->o_sync_mode & SLAP_SYNC_PERSIST ) ) + { + sl_mem_detach( ctx, memctx ); -no_co_op_free: + } else if ( op->o_sync_slog_size != -1 ) { + sl_mem_detach( ctx, memctx ); + LDAP_STAILQ_REMOVE( &conn->c_ops, op, slap_op, o_next); + LDAP_STAILQ_NEXT(op, o_next) = NULL; + conn->c_n_ops_executing--; + conn->c_n_ops_completed++; - arg->co_op = NULL; - arg->co_conn = NULL; - free( (char *) arg ); - arg = NULL; + } else { + LDAP_STAILQ_REMOVE( &conn->c_ops, op, slap_op, o_next); + LDAP_STAILQ_NEXT(op, o_next) = NULL; + slap_op_free( op ); + conn->c_n_ops_executing--; + conn->c_n_ops_completed++; + } switch( tag ) { case LBER_ERROR: @@ -1088,12 +1189,56 @@ no_co_op_free: } connection_resched( conn ); - ldap_pvt_thread_mutex_unlock( &conn->c_mutex ); - return NULL; } +static const Listener dummy_list = { BER_BVC(""), BER_BVC("") }; + +int connection_client_setup( + ber_socket_t s, + ldap_pvt_thread_start_t *func, + void *arg ) +{ + int rc; + Connection *c; + + rc = connection_init( s, (Listener *)&dummy_list, "", "", + CONN_IS_CLIENT, 0, NULL ); + if ( rc < 0 ) return -1; + + c = connection_get( s ); + c->c_clientfunc = func; + c->c_clientarg = arg; + connection_return( c ); + slapd_add_internal( s, 0 ); + slapd_set_read( s, 1 ); + return 0; +} + +void connection_client_enable( + ber_socket_t s ) +{ + slapd_set_read( s, 1 ); +} + +void connection_client_stop( + ber_socket_t s ) +{ + Connection *c; + + /* get (locked) connection */ + c = connection_get( s ); + + assert( c->c_conn_state == SLAP_C_CLIENT ); + + c->c_listener = NULL; + c->c_conn_state = SLAP_C_INVALID; + c->c_struct_state = SLAP_C_UNUSED; + connection_return( c ); + slapd_remove( s, 0, 1 ); +} + int connection_read(ber_socket_t s) { int rc = 0; @@ -1115,7 +1260,7 @@ int connection_read(ber_socket_t s) "connection_read(%ld): no connection!\n", (long) s, 0, 0 ); #endif - slapd_remove(s, 0); + slapd_remove(s, 1, 0); ldap_pvt_thread_mutex_unlock( &connections_mutex ); return -1; @@ -1138,10 +1283,19 @@ int connection_read(ber_socket_t s) return 0; } + if ( c->c_conn_state == SLAP_C_CLIENT ) { + slapd_clr_read( s, 0 ); + ldap_pvt_thread_pool_submit( &connection_pool, + c->c_clientfunc, c->c_clientarg ); + connection_return( c ); + ldap_pvt_thread_mutex_unlock( &connections_mutex ); + return 0; + } + #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, DETAIL1, - "connection_read: conn %lu checking for input.\n", - c->c_connid, 0, 0 ); + "connection_read: conn %lu checking for input.\n", + c->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_read(%d): checking for input on id=%lu\n", @@ -1150,7 +1304,7 @@ int connection_read(ber_socket_t s) #ifdef HAVE_TLS if ( c->c_is_tls && c->c_needs_tls_accept ) { - rc = ldap_pvt_tls_accept( c->c_sb, NULL ); + rc = ldap_pvt_tls_accept( c->c_sb, slap_tls_ctx ); if ( rc < 0 ) { #if 0 /* required by next #if 0 */ struct timeval tv; @@ -1159,8 +1313,8 @@ int connection_read(ber_socket_t s) #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connection_read: conn %lu TLS accept error, error %d\n", - c->c_connid, rc, 0 ); + "connection_read: conn %lu TLS accept error, error %d\n", + c->c_connid, rc, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_read(%d): TLS accept error " @@ -1177,10 +1331,10 @@ int connection_read(ber_socket_t s) FD_ZERO(&rfd); FD_SET(s, &rfd); for (rc=1; rc>0;) { - tv.tv_sec = 1; - tv.tv_usec = 0; - rc = select(s+1, &rfd, NULL, NULL, &tv); - if (rc == 1) { + tv.tv_sec = 1; + tv.tv_usec = 0; + rc = select(s+1, &rfd, NULL, NULL, &tv); + if (rc == 1) { ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DRAIN, NULL); } } @@ -1189,7 +1343,7 @@ int connection_read(ber_socket_t s) } else if ( rc == 0 ) { void *ssl; - struct berval authid = { 0, NULL }; + struct berval authid = BER_BVNULL; c->c_needs_tls_accept = 0; @@ -1204,18 +1358,17 @@ int connection_read(ber_socket_t s) rc = dnX509peerNormalize( ssl, &authid ); if ( rc != LDAP_SUCCESS ) { #ifdef NEW_LOGGING - LDAP_LOG( CONNECTION, INFO, - "connection_read: conn %lu unable to get TLS client DN, " - "error %d\n", c->c_connid, rc, 0 ); + LDAP_LOG( CONNECTION, INFO, "connection_read: " + "conn %lu unable to get TLS client DN, error %d\n", + c->c_connid, rc, 0 ); #else - Debug( LDAP_DEBUG_TRACE, - "connection_read(%d): unable to get TLS client DN " - "error=%d id=%lu\n", - s, rc, c->c_connid ); + Debug( LDAP_DEBUG_TRACE, "connection_read(%d): " + "unable to get TLS client DN, error=%d id=%lu\n", + s, rc, c->c_connid ); #endif } - slap_sasl_external( c, c->c_tls_ssf, authid.bv_val ); - if ( authid.bv_val ) free( authid.bv_val ); + slap_sasl_external( c, c->c_tls_ssf, &authid ); + if ( authid.bv_val ) free( authid.bv_val ); } /* if success and data is ready, fall thru to data input loop */ @@ -1231,9 +1384,16 @@ int connection_read(ber_socket_t s) #ifdef HAVE_CYRUS_SASL if ( c->c_sasl_layers ) { + /* If previous layer is not removed yet, give up for now */ + if ( !c->c_sasl_sockctx ) { + connection_return( c ); + ldap_pvt_thread_mutex_unlock( &connections_mutex ); + return 0; + } + c->c_sasl_layers = 0; - rc = ldap_pvt_sasl_install( c->c_sb, c->c_sasl_context ); + rc = ldap_pvt_sasl_install( c->c_sb, c->c_sasl_sockctx ); if( rc != LDAP_SUCCESS ) { #ifdef NEW_LOGGING @@ -1259,13 +1419,12 @@ int connection_read(ber_socket_t s) #define CONNECTION_INPUT_LOOP 1 /* #define DATA_READY_LOOP 1 */ - do - { + do { /* How do we do this without getting into a busy loop ? */ rc = connection_input( c ); } #ifdef DATA_READY_LOOP - while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL ) ); + while( !rc && ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_DATA_READY, NULL )); #elif CONNECTION_INPUT_LOOP while(!rc); #else @@ -1275,7 +1434,7 @@ int connection_read(ber_socket_t s) if( rc < 0 ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connection_read: conn %lu input error %d, closing.\n", + "connection_read: conn %lu input error %d, closing.\n", c->c_connid, rc, 0 ); #else Debug( LDAP_DEBUG_TRACE, @@ -1305,25 +1464,26 @@ int connection_read(ber_socket_t s) static int connection_input( - Connection *conn -) + Connection *conn ) { Operation *op; ber_tag_t tag; ber_len_t len; ber_int_t msgid; BerElement *ber; + int rc; #ifdef LDAP_CONNECTIONLESS Sockaddr peeraddr; char *cdn = NULL; #endif + char *defer = NULL; if ( conn->c_currentber == NULL && ( conn->c_currentber = ber_alloc()) == NULL ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connection_input: conn %lu ber_alloc failed.\n", + "connection_input: conn %lu ber_alloc failed.\n", conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "ber_alloc failed\n", 0, 0, 0 ); @@ -1357,7 +1517,7 @@ connection_input( #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connection_input: conn %lu ber_get_next failed, errno %d (%s).\n", + "connection_input: conn %lu ber_get_next failed, errno %d (%s).\n", conn->c_connid, err, sock_errstr(err) ); #else Debug( LDAP_DEBUG_TRACE, @@ -1381,11 +1541,11 @@ connection_input( /* log, close and send error */ #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connection_input: conn %lu ber_get_int returns 0x%lx.\n", + "connection_input: conn %lu ber_get_int returns 0x%lx.\n", conn->c_connid, tag, 0 ); #else - Debug( LDAP_DEBUG_ANY, "ber_get_int returns 0x%lx\n", tag, 0, - 0 ); + Debug( LDAP_DEBUG_ANY, "ber_get_int returns 0x%lx\n", + tag, 0, 0 ); #endif ber_free( ber, 1 ); return -1; @@ -1395,11 +1555,11 @@ connection_input( /* log, close and send error */ #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connection_input: conn %lu ber_peek_tag returns 0x%lx.\n", - conn->c_connid, tag, 0 ); + "connection_input: conn %lu ber_peek_tag returns 0x%lx.\n", + conn->c_connid, tag, 0 ); #else - Debug( LDAP_DEBUG_ANY, "ber_peek_tag returns 0x%lx\n", tag, 0, - 0 ); + Debug( LDAP_DEBUG_ANY, "ber_peek_tag returns 0x%lx\n", + tag, 0, 0 ); #endif ber_free( ber, 1 ); @@ -1414,15 +1574,14 @@ connection_input( } if( tag != LDAP_REQ_ABANDON && tag != LDAP_REQ_SEARCH ) { #ifdef NEW_LOGGING - LDAP_LOG( CONNECTION, ERR, - "connection_input: conn %lu invalid req for UDP 0x%lx.\n", - conn->c_connid, tag, 0 ); + LDAP_LOG( CONNECTION, ERR, + "connection_input: conn %lu invalid req for UDP 0x%lx.\n", + conn->c_connid, tag, 0 ); #else - Debug( LDAP_DEBUG_ANY, "invalid req for UDP 0x%lx\n", tag, 0, - 0 ); + Debug( LDAP_DEBUG_ANY, "invalid req for UDP 0x%lx\n", tag, 0, 0 ); #endif - ber_free( ber, 1 ); - return 0; + ber_free( ber, 1 ); + return 0; } } #endif @@ -1434,27 +1593,34 @@ connection_input( op = slap_op_alloc( ber, msgid, tag, conn->c_n_ops_received++ ); op->o_conn = conn; - op->vrFilter = NULL; -#ifdef LDAP_CONTROL_PAGEDRESULTS + op->o_assertion = NULL; + op->o_preread_attrs = NULL; + op->o_postread_attrs = NULL; + op->o_vrFilter = NULL; + /* clear state if the connection is being reused from inactive */ + if ( conn->c_conn_state == SLAP_C_INACTIVE ) { + memset( &conn->c_pagedresults_state, 0, sizeof( conn->c_pagedresults_state ) ); + } op->o_pagedresults_state = conn->c_pagedresults_state; -#endif + + op->o_res_ber = NULL; + #ifdef LDAP_CONNECTIONLESS if (conn->c_is_udp) { - int rc; - if ( cdn ) { - ber_str2bv( cdn, 0, 1, &op->o_dn ); - op->o_protocol = LDAP_VERSION2; + ber_str2bv( cdn, 0, 1, &op->o_dn ); + op->o_protocol = LDAP_VERSION2; } op->o_res_ber = ber_alloc_t( LBER_USE_DER ); - if (op->o_res_ber == NULL) - return 1; + if (op->o_res_ber == NULL) return 1; + + rc = ber_write( op->o_res_ber, (char *)&peeraddr, + sizeof(struct sockaddr), 0 ); - rc = ber_write(op->o_res_ber, (char *)&peeraddr, sizeof(struct sockaddr), 0); if (rc != sizeof(struct sockaddr)) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, INFO, - "connection_input: conn %lu ber_write failed\n", + "connection_input: conn %lu ber_write failed\n", conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "ber_write failed\n", 0, 0, 0 ); @@ -1467,7 +1633,7 @@ connection_input( if (rc == -1) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, INFO, - "connection_input: conn %lu put outer sequence failed\n", + "connection_input: conn %lu put outer sequence failed\n", conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, "ber_write failed\n", 0, 0, 0 ); @@ -1478,22 +1644,51 @@ connection_input( } #endif /* LDAP_CONNECTIONLESS */ - if ( conn->c_conn_state == SLAP_C_BINDING - || conn->c_conn_state == SLAP_C_CLOSING ) - { + rc = 0; + + /* Don't process requests when the conn is in the middle of a + * Bind, or if it's closing. Also, don't let any single conn + * use up all the available threads, and don't execute if we're + * currently blocked on output. And don't execute if there are + * already pending ops, let them go first. Abandon operations + * get exceptions to some, but not all, cases. + */ + if (tag != LDAP_REQ_ABANDON && conn->c_conn_state == SLAP_C_CLOSING) { + defer = "closing"; + } else if (tag != LDAP_REQ_ABANDON && conn->c_writewaiter) { + defer = "awaiting write"; + } else if (conn->c_n_ops_executing >= connection_pool_max/2) { + defer = "too many executing"; + } else if (conn->c_conn_state == SLAP_C_BINDING) { + defer = "binding"; + } else if (tag != LDAP_REQ_ABANDON && conn->c_n_ops_pending) { + defer = "pending operations"; + } + + if( defer ) { + int max = conn->c_dn.bv_len + ? slap_conn_max_pending_auth + : slap_conn_max_pending; + #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, INFO, - "connection_input: conn %lu deferring operation\n", - conn->c_connid, 0, 0 ); + "connection_input: conn %lu deferring operation: %s\n", + conn->c_connid, defer, 0 ); #else - Debug( LDAP_DEBUG_ANY, "deferring operation\n", 0, 0, 0 ); + Debug( LDAP_DEBUG_ANY, + "connection_input: conn=%lu deferring operation: %s\n", + conn->c_connid, defer, 0 ); #endif conn->c_n_ops_pending++; LDAP_STAILQ_INSERT_TAIL( &conn->c_pending_ops, op, o_next ); - + if ( conn->c_n_ops_pending > max ) { + rc = -1; + } else { + rc = 1; + } } else { conn->c_n_ops_executing++; - connection_op_activate( conn, op ); + connection_op_activate( op ); } #ifdef NO_THREADS @@ -1504,7 +1699,7 @@ connection_input( #endif assert( conn->c_struct_state == SLAP_C_USED ); - return 0; + return rc; } static int @@ -1523,7 +1718,7 @@ connection_resched( Connection *conn ) if( rc ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, DETAIL1, - "connection_resched: conn %lu reaquiring locks.\n", + "connection_resched: conn %lu reaquiring locks.\n", conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, @@ -1543,7 +1738,7 @@ connection_resched( Connection *conn ) if( conn->c_conn_state != SLAP_C_CLOSING ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, INFO, - "connection_resched: conn %lu closed by other thread.\n", + "connection_resched: conn %lu closed by other thread.\n", conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_resched: " @@ -1553,7 +1748,7 @@ connection_resched( Connection *conn ) } else { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, DETAIL1, - "connection_resched: conn %lu attempting closing.\n", + "connection_resched: conn %lu attempting closing.\n", conn->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_resched: " @@ -1567,12 +1762,15 @@ connection_resched( Connection *conn ) return 0; } - if( conn->c_conn_state != SLAP_C_ACTIVE ) { + if( conn->c_conn_state != SLAP_C_ACTIVE || conn->c_writewaiter ) { /* other states need different handling */ return 0; } while ((op = LDAP_STAILQ_FIRST( &conn->c_pending_ops )) != NULL) { + if ( conn->c_n_ops_executing > connection_pool_max/2 ) { + break; + } LDAP_STAILQ_REMOVE_HEAD( &conn->c_pending_ops, o_next ); LDAP_STAILQ_NEXT(op, o_next) = NULL; /* pending operations should not be marked for abandonment */ @@ -1581,7 +1779,7 @@ connection_resched( Connection *conn ) conn->c_n_ops_pending--; conn->c_n_ops_executing++; - connection_op_activate( conn, op ); + connection_op_activate( op ); if ( conn->c_conn_state == SLAP_C_BINDING ) { break; @@ -1590,49 +1788,49 @@ connection_resched( Connection *conn ) return 0; } -static int connection_op_activate( Connection *conn, Operation *op ) +static int connection_op_activate( Operation *op ) { - struct co_arg *arg; int status; ber_tag_t tag = op->o_tag; if(tag == LDAP_REQ_BIND) { - conn->c_conn_state = SLAP_C_BINDING; + op->o_conn->c_conn_state = SLAP_C_BINDING; } - arg = (struct co_arg *) ch_malloc( sizeof(struct co_arg) ); - arg->co_conn = conn; - arg->co_op = op; - - if (!arg->co_op->o_dn.bv_len) { - arg->co_op->o_authz = conn->c_authz; - arg->co_op->o_dn.bv_val = ch_strdup( conn->c_dn.bv_val ? - conn->c_dn.bv_val : "" ); - arg->co_op->o_ndn.bv_val = ch_strdup( conn->c_ndn.bv_val ? - conn->c_ndn.bv_val : "" ); + if (!op->o_dn.bv_len) { + op->o_authz = op->o_conn->c_authz; + ber_dupbv( &op->o_dn, &op->o_conn->c_dn ); + ber_dupbv( &op->o_ndn, &op->o_conn->c_ndn ); } - arg->co_op->o_authtype = conn->c_authtype; - ber_dupbv( &arg->co_op->o_authmech, &conn->c_authmech ); + op->o_authtype = op->o_conn->c_authtype; + ber_dupbv( &op->o_authmech, &op->o_conn->c_authmech ); - if (!arg->co_op->o_protocol) { - arg->co_op->o_protocol = conn->c_protocol - ? conn->c_protocol : LDAP_VERSION3; + if (!op->o_protocol) { + op->o_protocol = op->o_conn->c_protocol + ? op->o_conn->c_protocol : LDAP_VERSION3; } - arg->co_op->o_connid = conn->c_connid; + if (op->o_conn->c_conn_state == SLAP_C_INACTIVE + && op->o_protocol > LDAP_VERSION2) + { + op->o_conn->c_conn_state = SLAP_C_ACTIVE; + } + + op->o_connid = op->o_conn->c_connid; - LDAP_STAILQ_INSERT_TAIL( &conn->c_ops, arg->co_op, o_next ); + LDAP_STAILQ_INSERT_TAIL( &op->o_conn->c_ops, op, o_next ); status = ldap_pvt_thread_pool_submit( &connection_pool, - connection_operation, (void *) arg ); + connection_operation, (void *) op ); if ( status != 0 ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, "connection_op_activate: conn %lu thread pool submit failed.\n", - conn->c_connid, 0, 0 ); + op->o_connid, 0, 0 ); #else Debug( LDAP_DEBUG_ANY, - "ldap_pvt_thread_pool_submit failed (%d)\n", status, 0, 0 ); + "ldap_pvt_thread_pool_submit: failed (%d) for conn=%lu\n", + status, op->o_connid, 0 ); #endif /* should move op to pending list */ } @@ -1655,13 +1853,13 @@ int connection_write(ber_socket_t s) if( c == NULL ) { #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, ERR, - "connection_write: sock %ld no connection!\n", (long)s, 0, 0); + "connection_write: sock %ld no connection!\n", (long)s, 0, 0); #else Debug( LDAP_DEBUG_ANY, "connection_write(%ld): no connection!\n", - (long) s, 0, 0 ); + (long)s, 0, 0 ); #endif - slapd_remove(s, 0); + slapd_remove(s, 1, 0); ldap_pvt_thread_mutex_unlock( &connections_mutex ); return -1; } @@ -1670,7 +1868,7 @@ int connection_write(ber_socket_t s) #ifdef NEW_LOGGING LDAP_LOG( CONNECTION, DETAIL1, - "connection_write conn %lu waking output.\n", c->c_connid, 0, 0 ); + "connection_write conn %lu waking output.\n", c->c_connid, 0, 0 ); #else Debug( LDAP_DEBUG_TRACE, "connection_write(%d): waking output for id=%lu\n", @@ -1678,12 +1876,47 @@ int connection_write(ber_socket_t s) #endif ldap_pvt_thread_cond_signal( &c->c_write_cv ); - if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_READ, NULL ) ) + if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_READ, NULL ) ) { slapd_set_read( s, 1 ); - if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_WRITE, NULL ) ) + } + if ( ber_sockbuf_ctrl( c->c_sb, LBER_SB_OPT_NEEDS_WRITE, NULL ) ) { slapd_set_write( s, 1 ); + } connection_return( c ); ldap_pvt_thread_mutex_unlock( &connections_mutex ); return 0; } +void +connection_fake_init( + Connection *conn, + Operation *op, + void *ctx ) +{ + conn->c_connid = -1; + conn->c_send_ldap_result = slap_send_ldap_result; + conn->c_send_search_entry = slap_send_search_entry; + conn->c_send_search_reference = slap_send_search_reference; + conn->c_listener = (Listener *)&dummy_list; + conn->c_peer_domain = slap_empty_bv; + conn->c_peer_name = slap_empty_bv; + + /* set memory context */ + op->o_tmpmemctx = sl_mem_create( SLMALLOC_SLAB_SIZE, ctx ); + op->o_tmpmfuncs = &sl_mfuncs; + op->o_threadctx = ctx; + + op->o_conn = conn; + op->o_connid = op->o_conn->c_connid; + + op->o_time = slap_get_time(); +} + +void +connection_assign_nextid( Connection *conn ) +{ + ldap_pvt_thread_mutex_lock( &conn_nextid_mutex ); + conn->c_connid = conn_nextid++; + ldap_pvt_thread_mutex_unlock( &conn_nextid_mutex ); +} +