X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fdn.c;h=148d8155e9756adda8cd41f9053395a96af96769;hb=1fbbc1181152a32c1b9b82342ad6d63034ec7fbb;hp=588fc4a1eba7d74491a877661e4f8b74f0f63eae;hpb=292c575c1f8de2757524ffee9ea68229bbfcd733;p=openldap

diff --git a/servers/slapd/dn.c b/servers/slapd/dn.c
index 588fc4a1eb..148d8155e9 100644
--- a/servers/slapd/dn.c
+++ b/servers/slapd/dn.c
@@ -1,7 +1,7 @@
 /* dn.c - routines for dealing with distinguished names */
 /* $OpenLDAP$ */
 /*
- * Copyright 1998-2000 The OpenLDAP Foundation, All Rights Reserved.
+ * Copyright 1998-2003 The OpenLDAP Foundation, All Rights Reserved.
  * COPYING RESTRICTIONS APPLY, see COPYRIGHT file
  */
 
@@ -18,7 +18,9 @@
 
 #include "slap.h"
 
-#define SLAP_LDAPDN_PRETTY 0x1
+#include "lutil.h"
+
+const struct berval slap_empty_bv = { 0, "" };
 
 /*
  * The DN syntax-related functions take advantage of the dn representation
@@ -49,14 +51,14 @@ LDAPDN_validate( LDAPDN *dn )
 
 	assert( dn );
 
-	for ( iRDN = 0; dn[ iRDN ]; iRDN++ ) {
-		LDAPRDN		*rdn = dn[ iRDN ][ 0 ];
+	for ( iRDN = 0; dn[ 0 ][ iRDN ]; iRDN++ ) {
+		LDAPRDN		*rdn = dn[ 0 ][ iRDN ];
 		int		iAVA;
 
 		assert( rdn );
 
-		for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
-			LDAPAVA			*ava = rdn[ iAVA ][ 0 ];
+		for ( iAVA = 0; rdn[ 0 ][ iAVA ]; iAVA++ ) {
+			LDAPAVA			*ava = rdn[ 0 ][ iAVA ];
 			AttributeDescription	*ad;
 			slap_syntax_validate_func *validate = NULL;
 
@@ -65,7 +67,7 @@ LDAPDN_validate( LDAPDN *dn )
 			if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
 				const char	*text = NULL;
 
-				rc = slap_bv2ad( ava->la_attr, &ad, &text );
+				rc = slap_bv2ad( &ava->la_attr, &ad, &text );
 				if ( rc != LDAP_SUCCESS ) {
 					return LDAP_INVALID_SYNTAX;
 				}
@@ -76,8 +78,7 @@ LDAPDN_validate( LDAPDN *dn )
 			/* 
 			 * Replace attr oid/name with the canonical name
 			 */
-			ber_bvfree( ava->la_attr );
-			ava->la_attr = ber_bvdup( &ad->ad_cname );
+			ava->la_attr = ad->ad_cname;
 
 			validate = ad->ad_type->sat_syntax->ssyn_validate;
 
@@ -86,7 +87,7 @@ LDAPDN_validate( LDAPDN *dn )
 			 	 * validate value by validate function
 				 */
 				rc = ( *validate )( ad->ad_type->sat_syntax,
-					ava->la_value );
+					&ava->la_value );
 			
 				if ( rc != LDAP_SUCCESS ) {
 					return LDAP_INVALID_SYNTAX;
@@ -112,25 +113,30 @@ dnValidate(
 	assert( in );
 
 	if ( in->bv_len == 0 ) {
-		return( LDAP_SUCCESS );
+		return LDAP_SUCCESS;
+
+	} else if ( in->bv_len > SLAP_LDAPDN_MAXLEN ) {
+		return LDAP_INVALID_SYNTAX;
 	}
 
-	rc = ldap_str2dn( in->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+	rc = ldap_bv2dn( in, &dn, LDAP_DN_FORMAT_LDAP );
+	if ( rc != LDAP_SUCCESS ) {
+		return LDAP_INVALID_SYNTAX;
+	}
+
+	assert( strlen( in->bv_val ) == in->bv_len );
 
 	/*
 	 * Schema-aware validate
 	 */
-	if ( rc == LDAP_SUCCESS ) {
-		rc = LDAPDN_validate( dn );
-	}
-	
+	rc = LDAPDN_validate( dn );
 	ldap_dnfree( dn );
-	
+
 	if ( rc != LDAP_SUCCESS ) {
-		return( LDAP_INVALID_SYNTAX );
+		return LDAP_INVALID_SYNTAX;
 	}
 
-	return( LDAP_SUCCESS );
+	return LDAP_SUCCESS;
 }
 
 /*
@@ -141,6 +147,9 @@ dnValidate(
  * (use memcmp, which implies alphabetical order in case of IA5 value;
  * this should guarantee the repeatability of the operation).
  *
+ * Note: the sorting can be slightly improved by sorting first
+ * by attribute type length, then by alphabetical order.
+ *
  * uses a linear search; should be fine since the number of AVAs in
  * a RDN should be limited.
  */
@@ -148,18 +157,18 @@ static void
 AVA_Sort( LDAPRDN *rdn, int iAVA )
 {
 	int		i;
-	LDAPAVA		*ava_in = rdn[ iAVA ][ 0 ];
+	LDAPAVA		*ava_in = rdn[ 0 ][ iAVA ];
 
 	assert( rdn );
 	assert( ava_in );
 	
 	for ( i = 0; i < iAVA; i++ ) {
-		LDAPAVA		*ava = rdn[ i ][ 0 ];
+		LDAPAVA		*ava = rdn[ 0 ][ i ];
 		int		a, j;
 
 		assert( ava );
 
-		a = strcmp( ava_in->la_attr->bv_val, ava->la_attr->bv_val );
+		a = strcmp( ava_in->la_attr.bv_val, ava->la_attr.bv_val );
 
 		if ( a > 0 ) {
 			break;
@@ -168,12 +177,12 @@ AVA_Sort( LDAPRDN *rdn, int iAVA )
 		while ( a == 0 ) {
 			int		v, d;
 
-			d = ava_in->la_value->bv_len - ava->la_value->bv_len;
+			d = ava_in->la_value.bv_len - ava->la_value.bv_len;
 
-			v = memcmp( ava_in->la_value->bv_val, 
-					ava->la_value->bv_val,
-					d <= 0 ? ava_in->la_value->bv_len 
-						: ava->la_value->bv_len );
+			v = memcmp( ava_in->la_value.bv_val, 
+					ava->la_value.bv_val,
+					d <= 0 ? ava_in->la_value.bv_len 
+						: ava->la_value.bv_len );
 
 			if ( v == 0 && d != 0 ) {
 				v = d;
@@ -193,18 +202,18 @@ AVA_Sort( LDAPRDN *rdn, int iAVA )
 				return;
 			}
 
-			ava = rdn[ i ][ 0 ];
-			a = strcmp( ava_in->la_value->bv_val, 
-					ava->la_value->bv_val );
+			ava = rdn[ 0 ][ i ];
+			a = strcmp( ava_in->la_attr.bv_val, 
+					ava->la_attr.bv_val );
 		}
 
 		/*
 		 * move ahead
 		 */
 		for ( j = iAVA; j > i; j-- ) {
-			rdn[ j ][ 0 ] = rdn[ j - 1 ][ 0 ];
+			rdn[ 0 ][ j ] = rdn[ 0 ][ j - 1 ];
 		}
-		rdn[ i ][ 0 ] = ava_in;
+		rdn[ 0 ][ i ] = ava_in;
 
 		return;
 	}
@@ -222,52 +231,77 @@ LDAPDN_rewrite( LDAPDN *dn, unsigned flags )
 
 	assert( dn );
 
-	for ( iRDN = 0; dn[ iRDN ]; iRDN++ ) {
-		LDAPRDN		*rdn = dn[ iRDN ][ 0 ];
+	for ( iRDN = 0; dn[ 0 ][ iRDN ]; iRDN++ ) {
+		LDAPRDN		*rdn = dn[ 0 ][ iRDN ];
 		int		iAVA;
 
 		assert( rdn );
 
-		for ( iAVA = 0; rdn[ iAVA ]; iAVA++ ) {
-			LDAPAVA			*ava = rdn[ iAVA ][ 0 ];
+		for ( iAVA = 0; rdn[ 0 ][ iAVA ]; iAVA++ ) {
+			LDAPAVA			*ava = rdn[ 0 ][ iAVA ];
 			AttributeDescription	*ad;
+			slap_syntax_validate_func *validf = NULL;
 			slap_syntax_transform_func *transf = NULL;
 			MatchingRule *mr;
-			struct berval		*bv = NULL;
+			struct berval		bv = { 0, NULL };
+			int			do_sort = 0;
 
 			assert( ava );
 
 			if ( ( ad = AVA_PRIVATE( ava ) ) == NULL ) {
 				const char	*text = NULL;
 
-				rc = slap_bv2ad( ava->la_attr, &ad, &text );
+				rc = slap_bv2ad( &ava->la_attr, &ad, &text );
 				if ( rc != LDAP_SUCCESS ) {
 					return LDAP_INVALID_SYNTAX;
 				}
 				
 				ava->la_private = ( void * )ad;
+				do_sort = 1;
 			}
 
 			/* 
 			 * Replace attr oid/name with the canonical name
 			 */
-			ber_bvfree( ava->la_attr );
-			ava->la_attr = ber_bvdup( &ad->ad_cname );
+			ava->la_attr = ad->ad_cname;
 
-			if( flags & SLAP_LDAPDN_PRETTY ) {
+			if( ava->la_flags & LDAP_AVA_BINARY ) {
+				/* AVA is binary encoded, don't muck with it */
+				validf = NULL;
+				transf = NULL;
+				mr = NULL;
+			} else if( flags & SLAP_LDAPDN_PRETTY ) {
+				validf = NULL;
 				transf = ad->ad_type->sat_syntax->ssyn_pretty;
 				mr = NULL;
 			} else {
+				validf = ad->ad_type->sat_syntax->ssyn_validate;
 				transf = ad->ad_type->sat_syntax->ssyn_normalize;
 				mr = ad->ad_type->sat_equality;
 			}
 
+			if ( validf ) {
+				/* validate value before normalization */
+				rc = ( *validf )( ad->ad_type->sat_syntax,
+					ava->la_value.bv_len
+						? &ava->la_value
+						: (struct berval *) &slap_empty_bv );
+
+				if ( rc != LDAP_SUCCESS ) {
+					return LDAP_INVALID_SYNTAX;
+				}
+			}
+
 			if ( transf ) {
 				/*
 			 	 * transform value by normalize/pretty function
+				 *	if value is empty, use empty_bv
 				 */
 				rc = ( *transf )( ad->ad_type->sat_syntax,
-					ava->la_value, &bv );
+					ava->la_value.bv_len
+						? &ava->la_value
+						: (struct berval *) &slap_empty_bv,
+					&bv );
 			
 				if ( rc != LDAP_SUCCESS ) {
 					return LDAP_INVALID_SYNTAX;
@@ -275,20 +309,21 @@ LDAPDN_rewrite( LDAPDN *dn, unsigned flags )
 			}
 
 			if( mr && ( mr->smr_usage & SLAP_MR_DN_FOLD ) ) {
-				struct berval *s = bv;
+				char *s = bv.bv_val;
 
-				bv = ber_bvstr( UTF8normalize( bv ? bv : ava->la_value, 
-					UTF8_CASEFOLD ) );
-
-				ber_bvfree( s );
+				if ( UTF8bvnormalize( &bv, &bv, 
+						LDAP_UTF8_CASEFOLD ) == NULL ) {
+					return LDAP_INVALID_SYNTAX;
+				}
+				free( s );
 			}
 
-			if( bv ) {
-				ber_bvfree( ava->la_value );
+			if( bv.bv_val ) {
+				free( ava->la_value.bv_val );
 				ava->la_value = bv;
 			}
 
-			AVA_Sort( rdn, iAVA );
+			if( do_sort ) AVA_Sort( rdn, iAVA );
 		}
 	}
 
@@ -304,28 +339,45 @@ dnNormalize(
 	struct berval *val,
 	struct berval **normalized )
 {
-	struct berval *out = NULL;
-
-	Debug( LDAP_DEBUG_TRACE, ">>> dnNormalize: <%s>\n", val->bv_val, 0, 0 );
+	struct berval *out;
+	int rc;
+
+	assert( normalized && *normalized == NULL );
+
+	out = ch_malloc( sizeof( struct berval ) );
+	rc = dnNormalize2( syntax, val, out );
+	if ( rc != LDAP_SUCCESS )
+		free( out );
+	else
+		*normalized = out;
+	return rc;
+}
 
+int
+dnNormalize2(
+	Syntax *syntax,
+	struct berval *val,
+	struct berval *out )
+{
 	assert( val );
-	assert( normalized );
+	assert( out );
 
-	assert( *normalized == NULL );
+	Debug( LDAP_DEBUG_TRACE, ">>> dnNormalize: <%s>\n", val->bv_val, 0, 0 );
 
 	if ( val->bv_len != 0 ) {
 		LDAPDN		*dn = NULL;
-		char		*dn_out = NULL;
 		int		rc;
 
 		/*
 		 * Go to structural representation
 		 */
-		rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+		rc = ldap_bv2dn( val, &dn, LDAP_DN_FORMAT_LDAP );
 		if ( rc != LDAP_SUCCESS ) {
 			return LDAP_INVALID_SYNTAX;
 		}
 
+		assert( strlen( val->bv_val ) == val->bv_len );
+
 		/*
 		 * Schema-aware rewrite
 		 */
@@ -337,23 +389,20 @@ dnNormalize(
 		/*
 		 * Back to string representation
 		 */
-		rc = ldap_dn2str( dn, &dn_out, LDAP_DN_FORMAT_LDAPV3 );
+		rc = ldap_dn2bv( dn, out,
+			LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
 
 		ldap_dnfree( dn );
 
 		if ( rc != LDAP_SUCCESS ) {
 			return LDAP_INVALID_SYNTAX;
 		}
-
-		out = ber_bvstr( dn_out );
-
 	} else {
-		out = ber_bvdup( val );
+		ber_dupbv( out, val );
 	}
 
 	Debug( LDAP_DEBUG_TRACE, "<<< dnNormalize: <%s>\n", out->bv_val, 0, 0 );
 
-	*normalized = out;
 	return LDAP_SUCCESS;
 }
 
@@ -366,25 +415,53 @@ dnPretty(
 	struct berval *val,
 	struct berval **pretty)
 {
-	struct berval *out = NULL;
+	struct berval *out;
+	int rc;
+
+	assert( pretty && *pretty == NULL );
+
+	out = ch_malloc( sizeof( struct berval ) );
+	rc = dnPretty2( syntax, val, out );
+	if ( rc != LDAP_SUCCESS )
+		free( out );
+	else
+		*pretty = out;
+	return rc;
+}
+
+int
+dnPretty2(
+	Syntax *syntax,
+	struct berval *val,
+	struct berval *out)
+{
+	assert( val );
+	assert( out );
 
+#ifdef NEW_LOGGING
+	LDAP_LOG( OPERATION, ARGS, ">>> dnPretty: <%s>\n", val->bv_val, 0, 0 );
+#else
 	Debug( LDAP_DEBUG_TRACE, ">>> dnPretty: <%s>\n", val->bv_val, 0, 0 );
+#endif
 
-	assert( val );
-	assert( pretty );
-	assert( *pretty == NULL );
+	if ( val->bv_len == 0 ) {
+		ber_dupbv( out, val );
 
-	if ( val->bv_len != 0 ) {
+	} else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+		return LDAP_INVALID_SYNTAX;
+
+	} else {
 		LDAPDN		*dn = NULL;
-		char		*dn_out = NULL;
 		int		rc;
 
 		/* FIXME: should be liberal in what we accept */
-		rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+		rc = ldap_bv2dn( val, &dn, LDAP_DN_FORMAT_LDAP );
 		if ( rc != LDAP_SUCCESS ) {
 			return LDAP_INVALID_SYNTAX;
 		}
 
+		assert( strlen( val->bv_val ) == val->bv_len );
+
 		/*
 		 * Schema-aware rewrite
 		 */
@@ -397,7 +474,7 @@ dnPretty(
 		/* RE: the default is the form that is used as
 		 * an internal representation; the pretty form
 		 * is a variant */
-		rc = ldap_dn2str( dn, &dn_out,
+		rc = ldap_dn2bv( dn, out,
 			LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
 
 		ldap_dnfree( dn );
@@ -405,16 +482,63 @@ dnPretty(
 		if ( rc != LDAP_SUCCESS ) {
 			return LDAP_INVALID_SYNTAX;
 		}
+	}
+
+	Debug( LDAP_DEBUG_TRACE, "<<< dnPretty: <%s>\n", out->bv_val, 0, 0 );
+
+	return LDAP_SUCCESS;
+}
+
+int
+dnPrettyNormalDN(
+	Syntax *syntax,
+	struct berval *val,
+	LDAPDN **dn,
+	int flags )
+{
+	assert( val );
+	assert( dn );
+
+#ifdef NEW_LOGGING
+	LDAP_LOG( OPERATION, ARGS, ">>> dn%sDN: <%s>\n", 
+			flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal", 
+			val->bv_val, 0 );
+#else
+	Debug( LDAP_DEBUG_TRACE, ">>> dn%sDN: <%s>\n", 
+			flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal", 
+			val->bv_val, 0 );
+#endif
 
-		out = ber_bvstr( dn_out );
+	if ( val->bv_len == 0 ) {
+		return LDAP_SUCCESS;
+
+	} else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+		return LDAP_INVALID_SYNTAX;
 
 	} else {
-		out = ber_bvdup( val );
-	}
+		int		rc;
 
-	Debug( LDAP_DEBUG_TRACE, "<<< dnPretty: <%s>\n", out->bv_val, 0, 0 );
+		/* FIXME: should be liberal in what we accept */
+		rc = ldap_bv2dn( val, dn, LDAP_DN_FORMAT_LDAP );
+		if ( rc != LDAP_SUCCESS ) {
+			return LDAP_INVALID_SYNTAX;
+		}
 
-	*pretty = out;
+		assert( strlen( val->bv_val ) == val->bv_len );
+
+		/*
+		 * Schema-aware rewrite
+		 */
+		if ( LDAPDN_rewrite( *dn, flags ) != LDAP_SUCCESS ) {
+			ldap_dnfree( *dn );
+			*dn = NULL;
+			return LDAP_INVALID_SYNTAX;
+		}
+	}
+
+	Debug( LDAP_DEBUG_TRACE, "<<< dn%sDN\n", 
+			flags == SLAP_LDAPDN_PRETTY ? "Pretty" : "Normal",
+			0, 0 );
 
 	return LDAP_SUCCESS;
 }
@@ -429,15 +553,26 @@ dnPrettyNormal(
 	struct berval *pretty,
 	struct berval *normal)
 {
+#ifdef NEW_LOGGING
+	LDAP_LOG ( OPERATION, ENTRY, ">>> dnPrettyNormal: <%s>\n", val->bv_val, 0, 0 );
+#else
 	Debug( LDAP_DEBUG_TRACE, ">>> dnPrettyNormal: <%s>\n", val->bv_val, 0, 0 );
+#endif
 
 	assert( val );
 	assert( pretty );
 	assert( normal );
 
-	if ( val->bv_len != 0 ) {
+	if ( val->bv_len == 0 ) {
+		ber_dupbv( pretty, val );
+		ber_dupbv( normal, val );
+
+	} else if ( val->bv_len > SLAP_LDAPDN_MAXLEN ) {
+		/* too big */
+		return LDAP_INVALID_SYNTAX;
+
+	} else {
 		LDAPDN		*dn = NULL;
-		char		*dn_out = NULL;
 		int		rc;
 
 		pretty->bv_val = NULL;
@@ -446,11 +581,13 @@ dnPrettyNormal(
 		normal->bv_len = 0;
 
 		/* FIXME: should be liberal in what we accept */
-		rc = ldap_str2dn( val->bv_val, &dn, LDAP_DN_FORMAT_LDAP );
+		rc = ldap_bv2dn( val, &dn, LDAP_DN_FORMAT_LDAP );
 		if ( rc != LDAP_SUCCESS ) {
 			return LDAP_INVALID_SYNTAX;
 		}
 
+		assert( strlen( val->bv_val ) == val->bv_len );
+
 		/*
 		 * Schema-aware rewrite
 		 */
@@ -459,7 +596,7 @@ dnPrettyNormal(
 			return LDAP_INVALID_SYNTAX;
 		}
 
-		rc = ldap_dn2str( dn, &dn_out,
+		rc = ldap_dn2bv( dn, pretty,
 			LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
 
 		if ( rc != LDAP_SUCCESS ) {
@@ -467,8 +604,6 @@ dnPrettyNormal(
 			return LDAP_INVALID_SYNTAX;
 		}
 
-		ber_str2bv( dn_out, 0, 0, pretty );
-
 		if ( LDAPDN_rewrite( dn, 0 ) != LDAP_SUCCESS ) {
 			ldap_dnfree( dn );
 			free( pretty->bv_val );
@@ -477,7 +612,8 @@ dnPrettyNormal(
 			return LDAP_INVALID_SYNTAX;
 		}
 
-		rc = ldap_dn2str( dn, &dn_out, LDAP_DN_FORMAT_LDAPV3 );
+		rc = ldap_dn2bv( dn, normal,
+			LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
 
 		ldap_dnfree( dn );
 		if ( rc != LDAP_SUCCESS ) {
@@ -486,15 +622,15 @@ dnPrettyNormal(
 			pretty->bv_len = 0;
 			return LDAP_INVALID_SYNTAX;
 		}
-
-		ber_str2bv( dn_out, 0, 0, normal );
-	} else {
-		ber_dupbv( pretty, val );
-		ber_dupbv( normal, val );
 	}
 
+#ifdef NEW_LOGGING
+	LDAP_LOG (OPERATION, RESULTS, "<<< dnPrettyNormal: <%s>, <%s>\n",
+		pretty->bv_val, normal->bv_val, 0  );
+#else
 	Debug( LDAP_DEBUG_TRACE, "<<< dnPrettyNormal: <%s>, <%s>\n",
 		pretty->bv_val, normal->bv_val, 0 );
+#endif
 
 	return LDAP_SUCCESS;
 }
@@ -521,13 +657,13 @@ dnMatch(
 	match = value->bv_len - asserted->bv_len;
 
 	if ( match == 0 ) {
-		match = strcmp( value->bv_val, asserted->bv_val );
+		match = memcmp( value->bv_val, asserted->bv_val, 
+				value->bv_len );
 	}
 
 #ifdef NEW_LOGGING
-	LDAP_LOG(( "schema", LDAP_LEVEL_ENTRY,
-		"dnMatch: %d\n    %s\n    %s\n", match,
-		value->bv_val, asserted->bv_val ));
+	LDAP_LOG( CONFIG, ENTRY, "dnMatch: %d\n    %s\n    %s\n", 
+		match, value->bv_val, asserted->bv_val  );
 #else
 	Debug( LDAP_DEBUG_ARGS, "dnMatch %d\n\t\"%s\"\n\t\"%s\"\n",
 		match, value->bv_val, asserted->bv_val );
@@ -537,160 +673,45 @@ dnMatch(
 	return( LDAP_SUCCESS );
 }
 
-#ifdef SLAP_DN_MIGRATION
-/*
- * these routines are provided for migration purposes only!
- *	dn_validate is deprecated in favor of dnValidate
- *	dn_normalize is deprecated in favor of dnNormalize
- *	strcmp/strcasecmp for DNs is deprecated in favor of dnMatch
- *
- * other routines are likewise deprecated but may not yet have
- * replacement functions.
- */
-
-/*
- * dn_validate - validate and compress dn.  the dn is
- * compressed in place are returned if valid.
- * Deprecated in favor of dnValidate()
- */
-char *
-dn_validate( char *dn )
-{
-	struct berval val;
-	struct berval *pretty = NULL;
-	int		rc;
-
-	if ( dn == NULL || dn[0] == '\0' ) {
-		return dn;
-	}
-
-	val.bv_val = dn;
-	val.bv_len = strlen( dn );
-
-	rc = dnPretty( NULL, &val, &pretty );
-	if ( rc != LDAP_SUCCESS ) {
-		return NULL;
-	}
-
-	if ( val.bv_len < pretty->bv_len ) {
-		ber_bvfree( pretty );
-		return NULL;
-	}
-
-	AC_MEMCPY( dn, pretty->bv_val, pretty->bv_len + 1 );
-	ber_bvfree( pretty );
-
-	return dn;
-}
-
-/*
- * dn_normalize - put dn into a canonical form suitable for storing
- * in a hash database.	this involves normalizing the case as well as
- * the format.	the dn is normalized in place as well as returned if valid.
- * Deprecated in favor of dnNormalize()
- */
-char *
-dn_normalize( char *dn )
-{
-	struct berval val;
-	struct berval *normalized = NULL;
-	int		rc;
-
-	if ( dn == NULL || dn[0] == '\0' ) {
-		return dn;
-	}
-
-	val.bv_val = dn;
-	val.bv_len = strlen( dn );
-
-	rc = dnNormalize( NULL, &val, &normalized );
-	if ( rc != LDAP_SUCCESS ) {
-		return NULL;
-	}
-
-	if ( val.bv_len < normalized->bv_len ) {
-		ber_bvfree( normalized );
-		return NULL;
-	}
-
-	AC_MEMCPY( dn, normalized->bv_val, normalized->bv_len + 1 );
-	ber_bvfree( normalized );
-
-	return dn;
-}
-
 /*
  * dnParent - dn's parent, in-place
+ *
+ * note: the incoming dn is assumed to be normalized/prettyfied,
+ * so that escaped rdn/ava separators are in '\'+hexpair form
  */
-int
+void
 dnParent( 
-	const char	*dn, 
-	const char	**pdn )
+	struct berval	*dn, 
+	struct berval	*pdn )
 {
-	LDAPRDN		*tmpRDN;
-	const char	*p;
-	int		rc;
+	char	*p;
 
-	rc = ldap_str2rdn( dn, &tmpRDN, &p, LDAP_DN_FORMAT_LDAP );
-	if ( rc != LDAP_SUCCESS ) {
-		return rc;
+	p = strchr( dn->bv_val, ',' );
+
+	/* one-level dn */
+	if ( p == NULL ) {
+		pdn->bv_len = 0;
+		pdn->bv_val = dn->bv_val + dn->bv_len;
+		return;
 	}
-	ldap_rdnfree( tmpRDN );
 
 	assert( DN_SEPARATOR( p[ 0 ] ) );
 	p++;
 
-	while ( ASCII_SPACE( p[ 0 ] ) ) {
-		p++;
-	}
-
-	*pdn = p;
-
-	return LDAP_SUCCESS;
-}
-
-/*
- * dn_parent - return the dn's parent, in-place
- * FIXME: should be replaced by dnParent()
- */
-char *
-dn_parent(
-	Backend		*be,
-	const char	*dn )
-{
-	const char	*pdn;
-
-	if ( dn == NULL ) {
-		return NULL;
-	}
-
-	while ( dn[ 0 ] != '\0' && ASCII_SPACE( dn[ 0 ] ) ) {
-		dn++;
-	}
-
-	if ( dn[ 0 ] == '\0' ) {
-		return NULL;
-	}
+	assert( ATTR_LEADCHAR( p[ 0 ] ) );
+	pdn->bv_val = p;
+	pdn->bv_len = dn->bv_len - (p - dn->bv_val);
 
-	if ( be != NULL && be_issuffix( be, dn ) ) {
-		return NULL;
-	}
-
-	if ( dnParent( dn, &pdn ) != LDAP_SUCCESS ) {
-		return NULL;
-	}
-	
-	return ( char * )pdn;
+	return;
 }
 
 int
 dnExtractRdn( 
 	struct berval	*dn, 
-	struct berval 	**rdn )
+	struct berval 	*rdn )
 {
 	LDAPRDN		*tmpRDN;
 	const char	*p;
-	char		*rdnout;
 	int		rc;
 
 	assert( dn );
@@ -700,37 +721,30 @@ dnExtractRdn(
 		return LDAP_OTHER;
 	}
 
-	rc = ldap_str2rdn( dn->bv_val, &tmpRDN, &p, LDAP_DN_FORMAT_LDAP );
+	rc = ldap_bv2rdn( dn, &tmpRDN, (char **)&p, LDAP_DN_FORMAT_LDAP );
 	if ( rc != LDAP_SUCCESS ) {
 		return rc;
 	}
 
-	rc = ldap_rdn2str( tmpRDN, &rdnout, LDAP_DN_FORMAT_LDAPV3 );
+	rc = ldap_rdn2bv( tmpRDN, rdn, LDAP_DN_FORMAT_LDAPV3 | LDAP_DN_PRETTY );
+
 	ldap_rdnfree( tmpRDN );
 	if ( rc != LDAP_SUCCESS ) {
 		return rc;
 	}
 
-	*rdn = ber_bvstr( rdnout );
-	if ( *rdn == NULL ) {
-		free( rdnout );
-		return LDAP_NO_MEMORY;
-	}
-
 	return LDAP_SUCCESS;
 }
 
 /*
- * FIXME: should be replaced by dnExtractRdn() (together with dn_rdn)
+ * We can assume the input is a prettied or normalized DN
  */
 int 
 dn_rdnlen(
 	Backend		*be,
-	const char	*dn_in )
+	struct berval	*dn_in )
 {
-	struct berval bv;
-	struct berval	*rdn = NULL;
-	int		retval = 0;
+	const char	*p;
 
 	assert( dn_in );
 
@@ -738,11 +752,7 @@ dn_rdnlen(
 		return 0;
 	}
 
-	while ( dn_in[ 0 ] && ASCII_SPACE( dn_in[ 0 ] ) ) {
-		dn_in++;
-	}
-
-	if ( dn_in[ 0 ] == '\0' ) {
+	if ( !dn_in->bv_len ) {
 		return 0;
 	}
 
@@ -750,192 +760,9 @@ dn_rdnlen(
 		return 0;
 	}
 
-	bv.bv_val = (char *) dn_in;
-	bv.bv_len = strlen( bv.bv_val );
-
-	if ( dnExtractRdn( &bv, &rdn ) != LDAP_SUCCESS ) {
-		ber_bvfree( rdn );
-		return 0;
-	}
-
-	retval = rdn->bv_len;
-	ber_bvfree( rdn );
-
-	return retval;
-}
-
-/*
- * FIXME: should be replaced by dnExtractRdn() (together with dn_rdnlen)
- */
-char * dn_rdn(
-	Backend	*be,
-	const char	*dn_in )
-{
-	struct berval	bv;
-	struct berval	*rdn = NULL;
-	char		*retval;
-
-	assert( dn_in );
-
-	if ( dn_in == NULL ) {
-		return NULL;
-	}
-
-	while ( dn_in[ 0 ] && ASCII_SPACE( dn_in[ 0 ] ) ) {
-		dn_in++;
-	}
-
-	if ( dn_in[ 0 ] == '\0' ) {
-		return NULL;
-	}
-
-	if ( be != NULL && be_issuffix( be, dn_in ) ) {
-		return NULL;
-	}
-
-	bv.bv_val = (char *) dn_in;
-	bv.bv_len = strlen( bv.bv_val );
-
-	if ( dnExtractRdn( &bv, &rdn ) != LDAP_SUCCESS ) {
-		ber_bvfree( rdn );
-		return NULL;
-	}
-
-	retval = rdn->bv_val;
-	free( rdn );
-
-	return retval;
-}
-
-/*
- * dn_issuffix - tells whether suffix is a suffix of dn.
- * Both dn and suffix must be normalized.
- *	deprecated in favor of dnIsSuffix()
- */
-int
-dn_issuffix(
-	const char	*dn,
-	const char	*suffix
-)
-{
-	struct berval	bvdn, bvsuffix;
-
-	assert( dn );
-	assert( suffix );
-
-	bvdn.bv_val = (char *) dn;
-	bvdn.bv_len = strlen( dn );
-	bvsuffix.bv_val = (char *) suffix;
-	bvsuffix.bv_len = strlen( suffix );
-
-	return dnIsSuffix( &bvdn, &bvsuffix );
-}
-
-/* rdn_attr_type:
- *
- * Given a string (i.e. an rdn) of the form:
- *	 "attribute_type = attribute_value"
- * this function returns the type of an attribute, that is the
- * string "attribute_type" which is placed in newly allocated
- * memory. The returned string will be null-terminated.
- *
- * Deprecated
- */
-
-char * rdn_attr_type( const char * s )
-{
-	char 	**attrs, **values, *retval;
-
-	if ( rdn_attrs( s, &attrs, &values ) != LDAP_SUCCESS ) {
-		return NULL;
-	}
-
-	retval = ch_strdup( attrs[ 0 ] );
-
-	charray_free( attrs );
-	charray_free( values );
-
-	return retval;
-}
-
-
-/* rdn_attr_value:
- *
- * Given a string (i.e. an rdn) of the form:
- *	 "attribute_type = attribute_value"
- * this function returns "attribute_type" which is placed in newly allocated
- * memory. The returned string will be null-terminated and may contain
- * spaces (i.e. "John Doe\0").
- *
- * Deprecated
- */
-
-char *
-rdn_attr_value( const char * rdn )
-{
-	char 	**attrs, **values, *retval;
-
-	if ( rdn_attrs( rdn, &attrs, &values ) != LDAP_SUCCESS ) {
-		return NULL;
-	}
-
-	retval = ch_strdup( values[ 0 ] );
-
-	charray_free( attrs );
-	charray_free( values );
-
-	return retval;
-}
-
-
-/* rdn_attrs:
- *
- * Given a string (i.e. an rdn) of the form:
- *   "attribute_type=attribute_value[+attribute_type=attribute_value[...]]"
- * this function stores the types of the attributes in ptypes, that is the
- * array of strings "attribute_type" which is placed in newly allocated
- * memory, and the values of the attributes in pvalues, that is the
- * array of strings "attribute_value" which is placed in newly allocated
- * memory. Returns 0 on success, -1 on failure.
- *
- * note: got part of the code from dn_validate
- *
- * Deprecated; directly use LDAPRDN from ldap_str2rdn
- */
-int
-rdn_attrs( const char * rdn, char ***types, char ***values)
-{
-	LDAPRDN		*tmpRDN;
-	const char	*p;
-	int		iAVA;
-	int		rc;
-	
-	assert( rdn );
-	assert( values );
-
-	rc = ldap_str2rdn( rdn, &tmpRDN, &p, LDAP_DN_FORMAT_LDAP );
-	if ( rc != LDAP_SUCCESS ) {
-		return rc;
-	}
-
-	for ( iAVA = 0; tmpRDN[ iAVA ]; iAVA++ ) {
-		LDAPAVA		*ava = tmpRDN[ iAVA ][ 0 ];
-
-		assert( ava );
-		assert( ava->la_attr );
-		assert( ava->la_value );
-
-		if ( types ) {
-			charray_add_n( types, ava->la_attr->bv_val, 
-					ava->la_attr->bv_len );
-		}
-		charray_add_n( values, ava->la_value->bv_val, 
-				ava->la_value->bv_len );
-	}
-
-	ldap_rdnfree( tmpRDN );
+	p = strchr( dn_in->bv_val, ',' );
 
-	return LDAP_SUCCESS;
+	return p ? p - dn_in->bv_val : dn_in->bv_len;
 }
 
 
@@ -952,7 +779,9 @@ rdnValidate( struct berval *rdn )
 	 * input is a pretty or normalized DN
 	 * hence, we can just search for ','
 	 */
-	if( rdn == NULL || rdn->bv_len == 0 ) {
+	if( rdn == NULL || rdn->bv_len == 0 ||
+		rdn->bv_len > SLAP_LDAPDN_MAXLEN )
+	{
 		return LDAP_INVALID_SYNTAX;
 	}
 
@@ -974,7 +803,7 @@ rdnValidate( struct berval *rdn )
 	/*
 	 * must be parsable
 	 */
-	rc = ldap_str2rdn( rdn, &RDN, &p, LDAP_DN_FORMAT_LDAP );
+	rc = ldap_bv2rdn( rdn, &RDN, (char **)&p, LDAP_DN_FORMAT_LDAP );
 	if ( rc != LDAP_SUCCESS ) {
 		return 0;
 	}
@@ -1025,12 +854,11 @@ build_new_dn( struct berval * new_dn,
 	new_dn->bv_len = parent_dn->bv_len + newrdn->bv_len + 1;
 	new_dn->bv_val = (char *) ch_malloc( new_dn->bv_len + 1 );
 
-	ptr = slap_strcopy( new_dn->bv_val, newrdn->bv_val );
+	ptr = lutil_strcopy( new_dn->bv_val, newrdn->bv_val );
 	*ptr++ = ',';
 	strcpy( ptr, parent_dn->bv_val );
 }
 
-#endif /* SLAP_DN_MIGRATION */
 
 /*
  * dnIsSuffix - tells whether suffix is a suffix of dn.
@@ -1057,8 +885,7 @@ dnIsSuffix(
 	}
 
 	/* no rdn separator or escaped rdn separator */
-	if ( d > 1 && ( !DN_SEPARATOR( dn->bv_val[ d - 1 ] ) 
-				|| DN_ESCAPE( dn->bv_val[ d - 2 ] ) ) ) {
+	if ( d > 1 && !DN_SEPARATOR( dn->bv_val[ d - 1 ] ) ) {
 		return 0;
 	}
 
@@ -1070,3 +897,25 @@ dnIsSuffix(
 	/* compare */
 	return( strcmp( dn->bv_val + d, suffix->bv_val ) == 0 );
 }
+
+#ifdef HAVE_TLS
+/*
+ * Convert an X.509 DN into a normalized LDAP DN
+ */
+int
+dnX509normalize( void *x509_name, struct berval *out )
+{
+	/* Invoke the LDAP library's converter with our schema-rewriter */
+	return ldap_X509dn2bv( x509_name, out, LDAPDN_rewrite, 0 );
+}
+
+/*
+ * Get the TLS session's peer's DN into a normalized LDAP DN
+ */
+int
+dnX509peerNormalize( void *ssl, struct berval *dn )
+{
+
+	return ldap_pvt_tls_get_peer_dn( ssl, dn, (LDAPDN_rewrite_dummy *)LDAPDN_rewrite, 0 );
+}
+#endif