X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fsets.c;h=cd4a76c5fccb168fc9c4a75af8e4a2109d68bf42;hb=ed471a4d53b9bcd2cc89410743ffb4bd58b5fc05;hp=c2b4c257f3234bd3eb73247d667f9cec3be0a7b0;hpb=ac1332cdb868b6a30f545796aca8e0bbf13fe939;p=openldap

diff --git a/servers/slapd/sets.c b/servers/slapd/sets.c
index c2b4c257f3..cd4a76c5fc 100644
--- a/servers/slapd/sets.c
+++ b/servers/slapd/sets.c
@@ -20,14 +20,14 @@ static int set_samedn (char *dn1, char *dn2);
 long
 slap_set_size (BerVarray set)
 {
-	int i;
+	long	i;
 
 	i = 0;
 	if (set != NULL) {
 		while (set[i].bv_val)
 			i++;
 	}
-	return(i);
+	return i;
 }
 
 void
@@ -47,7 +47,7 @@ set_join (BerVarray lset, int op, BerVarray rset)
 		if (lset == NULL || lset->bv_val == NULL) {
 			if (rset == NULL) {
 				if (lset == NULL)
-					return(ch_calloc(1, sizeof(struct berval)));
+					return(SLAP_CALLOC(1, sizeof(struct berval)));
 				return(lset);
 			}
 			slap_set_dispose(lset);
@@ -59,7 +59,7 @@ set_join (BerVarray lset, int op, BerVarray rset)
 		}
 
 		i = slap_set_size(lset) + slap_set_size(rset) + 1;
-		set = ch_calloc(i, sizeof(struct berval));
+		set = SLAP_CALLOC(i, sizeof(struct berval));
 		if (set != NULL) {
 			/* set_chase() depends on this routine to
 			 * keep the first elements of the result
@@ -87,7 +87,7 @@ set_join (BerVarray lset, int op, BerVarray rset)
 
 	if (op == '&') {
 		if (lset == NULL || lset->bv_val == NULL || rset == NULL || rset->bv_val == NULL) {
-			set = ch_calloc(1, sizeof(struct berval));
+			set = SLAP_CALLOC(1, sizeof(struct berval));
 		} else {
 			set = lset;
 			lset = NULL;
@@ -119,11 +119,14 @@ set_chase (SLAP_SET_GATHER gatherer,
 {
 	BerVarray vals, nset;
 	char attrstr[32];
-	struct berval bv = {attr->bv_len, attrstr};
+	struct berval bv;
 	int i;
 
+	bv.bv_len = attr->bv_len;
+	bv.bv_val = attrstr;
+
 	if (set == NULL)
-		return(ch_calloc(1, sizeof(struct berval)));
+		return(SLAP_CALLOC(1, sizeof(struct berval)));
 
 	if (set->bv_val == NULL)
 		return(set);
@@ -135,13 +138,13 @@ set_chase (SLAP_SET_GATHER gatherer,
 	AC_MEMCPY(attrstr, attr->bv_val, attr->bv_len);
 	attrstr[attr->bv_len] = 0;
 
-	nset = ch_calloc(1, sizeof(struct berval));
+	nset = SLAP_CALLOC(1, sizeof(struct berval));
 	if (nset == NULL) {
 		slap_set_dispose(set);
 		return(NULL);
 	}
 	for (i = 0; set[i].bv_val; i++) {
-		vals = (gatherer)(cookie, set[i].bv_val, &bv);
+		vals = (gatherer)(cookie, &set[i], &bv);
 		if (vals != NULL)
 			nset = set_join(nset, '|', vals);
 	}
@@ -149,7 +152,7 @@ set_chase (SLAP_SET_GATHER gatherer,
 
 	if (closure) {
 		for (i = 0; nset[i].bv_val; i++) {
-			vals = (gatherer)(cookie, nset[i].bv_val, &bv);
+			vals = (gatherer)(cookie, &nset[i], &bv);
 			if (vals != NULL) {
 				nset = set_join(nset, '|', vals);
 				if (nset == NULL)
@@ -194,7 +197,7 @@ set_samedn (char *dn1, char *dn2)
 int
 slap_set_filter (SLAP_SET_GATHER gatherer,
 	void *cookie, struct berval *fbv,
-	char *user, char *this, BerVarray *results)
+	struct berval *user, struct berval *this, BerVarray *results)
 {
 #define IS_SET(x)	( (long)(x) >= 256 )
 #define IS_OP(x)	( (long)(x) < 256 )
@@ -284,10 +287,10 @@ slap_set_filter (SLAP_SET_GATHER gatherer,
 			if (c == 0)
 				SF_ERROR(syntax);
 			
-			set = ch_calloc(2, sizeof(struct berval));
+			set = SLAP_CALLOC(2, sizeof(struct berval));
 			if (set == NULL)
 				SF_ERROR(memory);
-			set->bv_val = ch_calloc(len + 1, sizeof(char));
+			set->bv_val = SLAP_CALLOC(len + 1, sizeof(char));
 			if (set->bv_val == NULL)
 				SF_ERROR(memory);
 			AC_MEMCPY(set->bv_val, &filter[-len - 1], len);
@@ -328,10 +331,10 @@ slap_set_filter (SLAP_SET_GATHER gatherer,
 			{
 				if ((SF_TOP() == (void *)'/') || IS_SET(SF_TOP()))
 					SF_ERROR(syntax);
-				set = ch_calloc(2, sizeof(struct berval));
+				set = SLAP_CALLOC(2, sizeof(struct berval));
 				if (set == NULL)
 					SF_ERROR(memory);
-				ber_str2bv( this, 0, 1, set );
+				ber_dupbv( set, this );
 				if (set->bv_val == NULL)
 					SF_ERROR(memory);
 			} else if (len == 4
@@ -339,10 +342,10 @@ slap_set_filter (SLAP_SET_GATHER gatherer,
 			{
 				if ((SF_TOP() == (void *)'/') || IS_SET(SF_TOP()))
 					SF_ERROR(syntax);
-				set = ch_calloc(2, sizeof(struct berval));
+				set = SLAP_CALLOC(2, sizeof(struct berval));
 				if (set == NULL)
 					SF_ERROR(memory);
-				ber_str2bv( user, 0, 1, set );
+				ber_dupbv( set, user );
 				if (set->bv_val == NULL)
 					SF_ERROR(memory);
 			} else if (SF_TOP() != (void *)'/') {
@@ -381,7 +384,7 @@ slap_set_filter (SLAP_SET_GATHER gatherer,
 		SF_ERROR(syntax);
 	}
 
-	rc = slap_set_size(set);
+	rc = slap_set_size(set) > 0 ? 1 : 0;
 	if (results) {
 		*results = set;
 		set = NULL;