X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fslapi%2Fslapi_ops.c;h=19f41961afb2ee1fbf7b8b0b3110e7e39cb34e45;hb=d2da9c1a7d1480eb6b8ae8c2a8e78392f44f4289;hp=b5f1c48b5dbde1eee47c80599cd3a34ade0a11af;hpb=71d76fbebaf7a1e4518936800d910d4695d60cd8;p=openldap diff --git a/servers/slapd/slapi/slapi_ops.c b/servers/slapd/slapi/slapi_ops.c index b5f1c48b5d..19f41961af 100644 --- a/servers/slapd/slapi/slapi_ops.c +++ b/servers/slapd/slapi/slapi_ops.c @@ -1,7 +1,7 @@ /* $OpenLDAP$ */ /* This work is part of OpenLDAP Software . * - * Copyright 2002-2005 The OpenLDAP Foundation. + * Copyright 2002-2012 The OpenLDAP Foundation. * Portions Copyright 1997,2002-2003 IBM Corporation. * All rights reserved. * @@ -33,7 +33,7 @@ #ifdef LDAP_SLAPI -static struct slap_listener slapi_listener = { +static struct Listener slapi_listener = { BER_BVC("slapi://"), BER_BVC("slapi://") }; @@ -187,9 +187,9 @@ slapi_int_connection_init_pb( Slapi_PBlock *pb, ber_tag_t tag ) LDAP_STAILQ_INIT( &conn->c_pending_ops ); - op = (Operation *) slapi_ch_calloc( 1, OPERATION_BUFFER_SIZE ); - op->o_hdr = (Opheader *)(op + 1); - op->o_controls = (void **)(op->o_hdr + 1); + op = (Operation *) slapi_ch_calloc( 1, sizeof(OperationBuffer) ); + op->o_hdr = &((OperationBuffer *) op)->ob_hdr; + op->o_controls = ((OperationBuffer *) op)->ob_controls; op->o_callback = (slap_callback *) slapi_ch_calloc( 1, sizeof(slap_callback) ); op->o_callback->sc_response = slapi_int_response; @@ -224,8 +224,10 @@ slapi_int_connection_init_pb( Slapi_PBlock *pb, ber_tag_t tag ) /* should check status of thread calls */ ldap_pvt_thread_mutex_init( &conn->c_mutex ); - ldap_pvt_thread_mutex_init( &conn->c_write_mutex ); - ldap_pvt_thread_cond_init( &conn->c_write_cv ); + ldap_pvt_thread_mutex_init( &conn->c_write1_mutex ); + ldap_pvt_thread_mutex_init( &conn->c_write2_mutex ); + ldap_pvt_thread_cond_init( &conn->c_write1_cv ); + ldap_pvt_thread_cond_init( &conn->c_write2_cv ); ldap_pvt_thread_mutex_lock( &conn->c_mutex ); @@ -253,7 +255,7 @@ slapi_int_connection_init_pb( Slapi_PBlock *pb, ber_tag_t tag ) conn->c_conn_state = 0x01; /* SLAP_C_ACTIVE */ conn->c_struct_state = 0x02; /* SLAP_C_USED */ - conn->c_ssf = conn->c_transport_ssf = 0; + conn->c_ssf = conn->c_transport_ssf = local_ssf; conn->c_tls_ssf = 0; backend_connection_init( conn ); @@ -296,7 +298,7 @@ slapi_int_set_operation_dn( Slapi_PBlock *pb ) if ( BER_BVISNULL( &op->o_ndn ) ) { /* set to root DN */ - be = select_backend( &op->o_req_ndn, get_manageDSAit( op ), 1 ); + be = select_backend( &op->o_req_ndn, 1 ); if ( be != NULL ) { ber_dupbv( &op->o_dn, &be->be_rootdn ); ber_dupbv( &op->o_ndn, &be->be_rootndn ); @@ -342,9 +344,10 @@ slapi_int_connection_done_pb( Slapi_PBlock *pb ) op->o_tmpfree( op->orr_nnewSup->bv_val, op->o_tmpmemctx ); op->o_tmpfree( op->orr_nnewSup, op->o_tmpmemctx ); } + slap_mods_free( op->orr_modlist, 1 ); break; case LDAP_REQ_ADD: - slap_mods_free( op->ora_modlist, 1 ); + slap_mods_free( op->ora_modlist, 0 ); break; case LDAP_REQ_MODIFY: slap_mods_free( op->orm_modlist, 1 ); @@ -362,6 +365,8 @@ slapi_int_connection_done_pb( Slapi_PBlock *pb ) slapi_ch_free_string( &conn->c_authmech.bv_val ); slapi_ch_free_string( &conn->c_dn.bv_val ); slapi_ch_free_string( &conn->c_ndn.bv_val ); + slapi_ch_free_string( &conn->c_peer_domain.bv_val ); + slapi_ch_free_string( &conn->c_peer_name.bv_val ); if ( conn->c_sb != NULL ) { ber_sockbuf_free( conn->c_sb ); @@ -407,7 +412,6 @@ slapi_delete_internal_pb( Slapi_PBlock *pb ) PBLOCK_ASSERT_INTOP( pb, LDAP_REQ_DELETE ); slapi_int_func_internal_pb( pb, op_delete ); - slap_graduate_commit_csn( pb->pb_op ); return 0; } @@ -417,6 +421,8 @@ slapi_add_internal_pb( Slapi_PBlock *pb ) { SlapReply *rs; Slapi_Entry *entry_orig = NULL; + OpExtraDB oex; + int rc; if ( pb == NULL ) { return -1; @@ -463,7 +469,7 @@ slapi_add_internal_pb( Slapi_PBlock *pb ) assert( pb->pb_op->ora_modlist != NULL ); } - rs->sr_err = slap_mods_check( pb->pb_op->ora_modlist, &rs->sr_text, + rs->sr_err = slap_mods_check( pb->pb_op, pb->pb_op->ora_modlist, &rs->sr_text, pb->pb_textbuf, sizeof( pb->pb_textbuf ), NULL ); if ( rs->sr_err != LDAP_SUCCESS ) { goto cleanup; @@ -471,26 +477,29 @@ slapi_add_internal_pb( Slapi_PBlock *pb ) /* Duplicate the values, because we may call slapi_entry_free() */ rs->sr_err = slap_mods2entry( pb->pb_op->ora_modlist, &pb->pb_op->ora_e, - 1, 1, &rs->sr_text, pb->pb_textbuf, sizeof( pb->pb_textbuf ) ); + 1, 0, &rs->sr_text, pb->pb_textbuf, sizeof( pb->pb_textbuf ) ); if ( rs->sr_err != LDAP_SUCCESS ) { goto cleanup; } - if ( slapi_int_func_internal_pb( pb, op_add ) == 0 ) { - if ( pb->pb_op->ora_e != NULL && pb->pb_op->o_private != NULL ) { + oex.oe.oe_key = (void *)do_add; + oex.oe_db = NULL; + LDAP_SLIST_INSERT_HEAD(&pb->pb_op->o_extra, &oex.oe, oe_next); + rc = slapi_int_func_internal_pb( pb, op_add ); + LDAP_SLIST_REMOVE(&pb->pb_op->o_extra, &oex.oe, OpExtra, oe_next); + + if ( !rc ) { + if ( pb->pb_op->ora_e != NULL && oex.oe_db != NULL ) { BackendDB *bd = pb->pb_op->o_bd; - pb->pb_op->o_bd = (BackendDB *)pb->pb_op->o_private; - pb->pb_op->o_private = NULL; + pb->pb_op->o_bd = oex.oe_db; be_entry_release_w( pb->pb_op, pb->pb_op->ora_e ); pb->pb_op->ora_e = NULL; pb->pb_op->o_bd = bd; - pb->pb_op->o_private = NULL; } } cleanup: - slap_graduate_commit_csn( pb->pb_op ); if ( pb->pb_op->ora_e != NULL ) { slapi_entry_free( pb->pb_op->ora_e ); @@ -522,7 +531,6 @@ slapi_modrdn_internal_pb( Slapi_PBlock *pb ) slapi_int_func_internal_pb( pb, op_modrdn ); cleanup: - slap_graduate_commit_csn( pb->pb_op ); return 0; } @@ -550,7 +558,7 @@ slapi_modify_internal_pb( Slapi_PBlock *pb ) goto cleanup; } - rs->sr_err = slap_mods_check( pb->pb_op->orm_modlist, + rs->sr_err = slap_mods_check( pb->pb_op, pb->pb_op->orm_modlist, &rs->sr_text, pb->pb_textbuf, sizeof( pb->pb_textbuf ), NULL ); if ( rs->sr_err != LDAP_SUCCESS ) { goto cleanup; @@ -559,7 +567,6 @@ slapi_modify_internal_pb( Slapi_PBlock *pb ) slapi_int_func_internal_pb( pb, op_modify ); cleanup: - slap_graduate_commit_csn( pb->pb_op ); return 0; } @@ -865,6 +872,7 @@ slapi_rename_internal_set_pb( Slapi_PBlock *pb, slapi_pblock_set( pb, SLAPI_TARGET_UNIQUEID, (void *)uniqueid ); slapi_pblock_set( pb, SLAPI_PLUGIN_IDENTITY, (void *)plugin_identity ); slapi_pblock_set( pb, SLAPI_X_INTOP_FLAGS, (void *)&operation_flags ); + slap_modrdn2mods( pb->pb_op, pb->pb_rs ); slapi_int_set_operation_dn( pb ); }