X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=servers%2Fslapd%2Fstarttls.c;h=b953e3e3e59fe20c058dae833126a2dfa11d3702;hb=9c550e7235830af9d031d8d7ba86b87f36dcc99f;hp=939646c09f509e64e4a8c84e05346b81ba4bec58;hpb=6af256b8e1df83c0ee32e2906fadd5e824b13835;p=openldap diff --git a/servers/slapd/starttls.c b/servers/slapd/starttls.c index 939646c09f..b953e3e3e5 100644 --- a/servers/slapd/starttls.c +++ b/servers/slapd/starttls.c @@ -1,12 +1,16 @@ /* $OpenLDAP$ */ -/* - * Copyright 1999-2003 The OpenLDAP Foundation. +/* This work is part of OpenLDAP Software . + * + * Copyright 1998-2004 The OpenLDAP Foundation. * All rights reserved. * - * Redistribution and use in source and binary forms are permitted only - * as authorized by the OpenLDAP Public License. A copy of this - * license is available at http://www.OpenLDAP.org/license.html or - * in file LICENSE in the top-level directory of the distribution. + * Redistribution and use in source and binary forms, with or without + * modification, are permitted only as authorized by the OpenLDAP + * Public License. + * + * A copy of this license is available in the file LICENSE in the + * top-level directory of the distribution or, alternatively, at + * . */ #include "portable.h" @@ -14,8 +18,6 @@ #include #include -#include - #include "slap.h" #ifdef HAVE_TLS @@ -57,8 +59,8 @@ starttls_extop ( Operation *op, SlapReply *rs ) ( op->o_conn->c_dn.bv_len != 0 ) ) { Statslog( LDAP_DEBUG_STATS, - "conn=%lu op=%lu AUTHZ anonymous mech=starttls ssf=0\n", - op->o_connid, op->o_opid, 0, 0, 0 ); + "%s AUTHZ anonymous mech=starttls ssf=0\n", + op->o_log_prefix, 0, 0, 0, 0 ); /* force to anonymous */ connection2anonymous( op->o_conn ); @@ -73,9 +75,7 @@ starttls_extop ( Operation *op, SlapReply *rs ) } /* fail if TLS could not be initialized */ - if (ldap_pvt_tls_get_option( NULL, LDAP_OPT_X_TLS_CTX, &ctx ) != 0 - || ctx == NULL) - { + if ( slap_tls_ctx == NULL ) { if (default_referral != NULL) { /* caller will put the referral in the result */ rc = LDAP_REFERRAL; @@ -96,8 +96,7 @@ done: /* give up connection lock */ ldap_pvt_thread_mutex_unlock( &op->o_conn->c_mutex ); - /* - * RACE CONDITION: we give up lock before sending result + /* FIXME: RACE CONDITION! we give up lock before sending result * Should be resolved by reworking connection state, not * by moving send here (so as to ensure proper TLS sequencing) */