X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=src%2Fewmh.c;h=986523dd3e9db2aef47b05319ba282a40535f596;hb=f13fa1e37a33bab8ea9f8424ec4e488fa5df5d42;hp=a8bc51c8b976260e2278de7bc21bab1b8c6edf0b;hpb=c0563af3e27543d97eb3d201c2e197cc6285cb80;p=i3%2Fi3 diff --git a/src/ewmh.c b/src/ewmh.c index a8bc51c8..986523dd 100644 --- a/src/ewmh.c +++ b/src/ewmh.c @@ -1,16 +1,14 @@ +#undef I3__FILE__ +#define I3__FILE__ "ewmh.c" /* * vim:ts=4:sw=4:expandtab * * i3 - an improved dynamic tiling window manager + * © 2009-2011 Michael Stapelberg and contributors (see also: LICENSE) * - * © 2009 Michael Stapelberg and contributors - * - * See file LICENSE for license information. - * - * ewmh.c: Functions to get/set certain EWMH properties easily. + * ewmh.c: Get/set certain EWMH properties easily. * */ - #include "all.h" /* @@ -20,16 +18,21 @@ * and _NET_NUMBER_OF_DESKTOPS - 1. * */ -void ewmh_update_current_desktop() { +void ewmh_update_current_desktop(void) { Con *focused_ws = con_get_workspace(focused); Con *output; uint32_t idx = 0; - TAILQ_FOREACH(output, &(croot->nodes_head), nodes) { + /* We count to get the index of this workspace because named workspaces + * don’t have the ->num property */ + TAILQ_FOREACH (output, &(croot->nodes_head), nodes) { Con *ws; - TAILQ_FOREACH(ws, &(output_get_content(output)->nodes_head), nodes) { + TAILQ_FOREACH (ws, &(output_get_content(output)->nodes_head), nodes) { + if (STARTS_WITH(ws->name, "__")) + continue; + if (ws == focused_ws) { xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, - atoms[_NET_CURRENT_DESKTOP], CARDINAL, 32, 1, &idx); + A__NET_CURRENT_DESKTOP, XCB_ATOM_CARDINAL, 32, 1, &idx); return; } ++idx; @@ -46,65 +49,94 @@ void ewmh_update_current_desktop() { */ void ewmh_update_active_window(xcb_window_t window) { xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, - atoms[_NET_ACTIVE_WINDOW], WINDOW, 32, 1, &window); + A__NET_ACTIVE_WINDOW, XCB_ATOM_WINDOW, 32, 1, &window); } /* - * Updates the workarea for each desktop. + * i3 currently does not support _NET_WORKAREA, because it does not correspond + * to i3’s concept of workspaces. See also: + * http://bugs.i3wm.org/539 + * http://bugs.i3wm.org/301 + * http://bugs.i3wm.org/1038 + * + * We need to actively delete this property because some display managers (e.g. + * LightDM) set it. * * EWMH: Contains a geometry for each desktop. These geometries specify an area * that is completely contained within the viewport. Work area SHOULD be used by * desktop applications to place desktop icons appropriately. * */ -void ewmh_update_workarea() { - int num_workspaces = 0, count = 0; - Rect last_rect = {0, 0, 0, 0}; - Con *output; +void ewmh_update_workarea(void) { + xcb_delete_property(conn, root, A__NET_WORKAREA); +} - TAILQ_FOREACH(output, &(croot->nodes_head), nodes) { - Con *ws; - TAILQ_FOREACH(ws, &(output_get_content(output)->nodes_head), nodes) { - /* Check if we need to initialize last_rect. The case that the - * first workspace is all-zero may happen when the user - * assigned workspace 2 for his first screen, for example. Thus - * we need an initialized last_rect in the very first run of - * the following loop. */ - if (last_rect.width == 0 && last_rect.height == 0 && - ws->rect.width != 0 && ws->rect.height != 0) { - memcpy(&last_rect, &(ws->rect), sizeof(Rect)); - } - num_workspaces++; - } - } +/* + * Updates the _NET_CLIENT_LIST hint. + * + */ +void ewmh_update_client_list(xcb_window_t *list, int num_windows) { + xcb_change_property( + conn, + XCB_PROP_MODE_REPLACE, + root, + A__NET_CLIENT_LIST, + XCB_ATOM_WINDOW, + 32, + num_windows, + list); +} - DLOG("Got %d workspaces\n", num_workspaces); - uint8_t *workarea = smalloc(sizeof(Rect) * num_workspaces); - TAILQ_FOREACH(output, &(croot->nodes_head), nodes) { - Con *ws; - TAILQ_FOREACH(ws, &(output_get_content(output)->nodes_head), nodes) { - DLOG("storing %d: %dx%d with %d x %d\n", count, ws->rect.x, - ws->rect.y, ws->rect.width, ws->rect.height); - /* If a workspace is not yet initialized and thus its - * dimensions are zero, we will instead put the dimensions - * of the last workspace in the list. For example firefox - * intersects all workspaces and does not cope so well with - * an all-zero workspace. */ - if (ws->rect.width == 0 || ws->rect.height == 0) { - DLOG("re-using last_rect (%dx%d, %d, %d)\n", - last_rect.x, last_rect.y, last_rect.width, - last_rect.height); - memcpy(workarea + (sizeof(Rect) * count++), &last_rect, sizeof(Rect)); - continue; - } - memcpy(workarea + (sizeof(Rect) * count++), &(ws->rect), sizeof(Rect)); - memcpy(&last_rect, &(ws->rect), sizeof(Rect)); - } - } - xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, - atoms[_NET_WORKAREA], CARDINAL, 32, - num_workspaces * (sizeof(Rect) / sizeof(uint32_t)), - workarea); - free(workarea); - xcb_flush(conn); +/* + * Updates the _NET_CLIENT_LIST_STACKING hint. + * + */ +void ewmh_update_client_list_stacking(xcb_window_t *stack, int num_windows) { + xcb_change_property( + conn, + XCB_PROP_MODE_REPLACE, + root, + A__NET_CLIENT_LIST_STACKING, + XCB_ATOM_WINDOW, + 32, + num_windows, + stack); +} + +/* + * Set up the EWMH hints on the root window. + * + */ +void ewmh_setup_hints(void) { + xcb_atom_t supported_atoms[] = { +#define xmacro(atom) A_##atom, +#include "atoms.xmacro" +#undef xmacro + }; + + /* Set up the window manager’s name. According to EWMH, section "Root Window + * Properties", to indicate that an EWMH-compliant window manager is + * present, a child window has to be created (and kept alive as long as the + * window manager is running) which has the _NET_SUPPORTING_WM_CHECK and + * _NET_WM_ATOMS. */ + xcb_window_t child_window = xcb_generate_id(conn); + xcb_create_window( + conn, + XCB_COPY_FROM_PARENT, /* depth */ + child_window, /* window id */ + root, /* parent */ + 0, 0, 1, 1, /* dimensions (x, y, w, h) */ + 0, /* border */ + XCB_WINDOW_CLASS_INPUT_ONLY, /* window class */ + XCB_COPY_FROM_PARENT, /* visual */ + 0, + NULL); + xcb_change_property(conn, XCB_PROP_MODE_REPLACE, child_window, A__NET_SUPPORTING_WM_CHECK, XCB_ATOM_WINDOW, 32, 1, &child_window); + xcb_change_property(conn, XCB_PROP_MODE_REPLACE, child_window, A__NET_WM_NAME, A_UTF8_STRING, 8, strlen("i3"), "i3"); + xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, A__NET_SUPPORTING_WM_CHECK, XCB_ATOM_WINDOW, 32, 1, &child_window); + + /* I’m not entirely sure if we need to keep _NET_WM_NAME on root. */ + xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, A__NET_WM_NAME, A_UTF8_STRING, 8, strlen("i3"), "i3"); + + xcb_change_property(conn, XCB_PROP_MODE_REPLACE, root, A__NET_SUPPORTED, XCB_ATOM_ATOM, 32, 19, supported_atoms); }