X-Git-Url: https://git.sur5r.net/?a=blobdiff_plain;f=src%2Fgeneral.c;h=2424cc60ea24fd4089d8d434f6c3fd48a1c44303;hb=445b1925e3d2e239740d7765e5892d0671174e8e;hp=4016ecdbf0902bf26c9859b7cd3e2643e08428ff;hpb=6fda988f360b3145d5772b6964f336dd652357ea;p=i3%2Fi3status diff --git a/src/general.c b/src/general.c index 4016ecd..2424cc6 100644 --- a/src/general.c +++ b/src/general.c @@ -1,3 +1,4 @@ +// vim:ts=4:sw=4:expandtab #include #include #include @@ -5,6 +6,7 @@ #include #include #include +#include #include "i3status.h" @@ -12,14 +14,19 @@ * Reads size bytes into the destination buffer from filename. * */ -void slurp(char *filename, char *destination, int size) { - int fd; +bool slurp(const char *filename, char *destination, int size) { + int fd; - if ((fd = open(filename, O_RDONLY)) == -1) - die("Could not open \"%s\"\n", filename); + if ((fd = open(filename, O_RDONLY)) == -1) + return false; - (void)read(fd, destination, size); - (void)close(fd); + /* We need one byte for the trailing 0 byte */ + int n = read(fd, destination, size - 1); + if (n != -1) + destination[n] = '\0'; + (void)close(fd); + + return true; } /* @@ -28,15 +35,15 @@ void slurp(char *filename, char *destination, int size) { * */ char *skip_character(char *input, char character, int amount) { - char *walk; - size_t len = strlen(input); - int blanks = 0; + char *walk; + size_t len = strlen(input); + int blanks = 0; - for (walk = input; ((size_t)(walk - input) < len) && (blanks < amount); walk++) - if (*walk == character) - blanks++; + for (walk = input; ((size_t)(walk - input) < len) && (blanks < amount); walk++) + if (*walk == character) + blanks++; - return (walk == input ? walk : walk-1); + return (walk == input ? walk : walk - 1); } /* @@ -44,27 +51,10 @@ char *skip_character(char *input, char character, int amount) { * */ void die(const char *fmt, ...) { - char buffer[512]; - va_list ap; - va_start(ap, fmt); - (void)vsnprintf(buffer, sizeof(buffer), fmt, ap); - va_end(ap); - - if (wmii_path != NULL) - write_error_to_statusbar(buffer); - else - fprintf(stderr, "%s", buffer); - exit(EXIT_FAILURE); -} + va_list ap; + va_start(ap, fmt); + (void)vfprintf(stderr, fmt, ap); + va_end(ap); -/* - * This function just concats two strings in place, it should only be used - * for concatting order to the name of a file or concatting color codes. - * Otherwise, the buffer size would have to be increased. - * - */ -char *concat(const char *str1, const char *str2) { - static char concatbuf[32]; - (void)snprintf(concatbuf, sizeof(concatbuf), "%s%s", str1, str2); - return concatbuf; + exit(EXIT_FAILURE); }