]> git.sur5r.net Git - openocd/commit
jtag/adi_v5_jtag: fix infinite recursion in jtagdp_transaction_endcheck()
authorPaul Fertser <fercerpav@gmail.com>
Mon, 6 Apr 2015 13:04:05 +0000 (16:04 +0300)
committerPaul Fertser <fercerpav@gmail.com>
Tue, 14 Apr 2015 11:39:02 +0000 (12:39 +0100)
commit20a077eadbeea77ed3f4d75fbe23b6f2db891dd8
tree544c1b32603fb7f9340b95045339a7fc1db3fd99
parentcf77040e1e435b9bd6e1d35cd5fc6ad874703d16
jtag/adi_v5_jtag: fix infinite recursion in jtagdp_transaction_endcheck()

Calling ahbap_debugport_init() is wrong here because the actions
performed by it might lead to jtagdp_transaction_endcheck errors thus
leading to infinite recursion.

The removed code is not needed now because target polling should lead
to reexamination automatically, and both cortex_a and cortex_m call
ahbap_debugport_init() as part of their target examine handler.

This was reported as a real life issue on IRC by Weaselweb with
Cortex-A target. Quitte reports similar results in some circumstances
(adapter_khz too high) with LPC17xx.

Change-Id: I7148022f76a1272b5262d251f2e807ffb1543547
Signed-off-by: Paul Fertser <fercerpav@gmail.com>
Reviewed-on: http://openocd.zylin.com/2697
Tested-by: jenkins
src/target/adi_v5_jtag.c